We read past the end of the initialized part of the buffer, seemingly
on purpose (no one knows the details of this code anymore). The right
thing to do is probably to zero that part of the buffer.
(The *right* right thing to would be to rewrite this so that it was
easier to see what data was supposed to be where when, but
priorities...)
BUG=chromium:683040
Review-Url: https://codereview.webrtc.org/2659383002
Cr-Commit-Position: refs/heads/master@{#16365}
This allows controllers to do internal logic upon the network metric changes, e.g., filtering.
BUG=webrtc:6303
Review-Url: https://codereview.webrtc.org/2643133003
Cr-Commit-Position: refs/heads/master@{#16363}
Left shifting negative integers is undefined behavior, and should be prevented. This CL fixes one such instance in the NetEq Expand function.
BUG=chromium:677106
Review-Url: https://codereview.webrtc.org/2616363003
Cr-Commit-Position: refs/heads/master@{#15966}
The test verifies that the hysteresis window in the configuration works
as intended.
BUG=webrtc:6708
Review-Url: https://codereview.webrtc.org/2594563002
Cr-Commit-Position: refs/heads/master@{#15700}
This effectively reverts commit c3e1cabc696240e4b5a128653264785292878205
(https://codereview.webrtc.org/2589703002/).
The reason the test was failing before was missing resource
dependencies in the GN file. This is now fixed.
Furthermore, the test did not trigger the complexity adaptation that
it was supposed to test, since the hysteresis window of the bitrate
was not taken into account. This is also fixed.
Finally, a percent label was added to a printout, to match the same
printout in the other test.
BUG=webrtc:6708
Review-Url: https://codereview.webrtc.org/2580383002
Cr-Commit-Position: refs/heads/master@{#15679}
Reason for revert:
This fails on perf bots.
See for instance https://uberchromegw.corp.google.com/i/client.webrtc.perf/builders/Android32%20Tests%20%28K%20Nexus5%29/builds/105/steps/webrtc_perf_tests/logs/stdio:
I 643.319s run_tests_on_device(03832b22f0e944a0) Note: Google Test filter = AudioEncoderOpusComplexityAdaptationTest.AdaptationOff
I 643.319s run_tests_on_device(03832b22f0e944a0) [==========] Running 1 test from 1 test case.
I 643.319s run_tests_on_device(03832b22f0e944a0) [----------] Global test environment set-up.
I 643.319s run_tests_on_device(03832b22f0e944a0) [----------] 1 test from AudioEncoderOpusComplexityAdaptationTest
I 643.319s run_tests_on_device(03832b22f0e944a0) [ RUN ] AudioEncoderOpusComplexityAdaptationTest.AdaptationOff
I 643.319s run_tests_on_device(03832b22f0e944a0) ../../webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc:36: Failure
I 643.319s run_tests_on_device(03832b22f0e944a0) Value of: audio_loop.Init(kInputFileName, kMaxLoopLengthSamples, kInputBlockSizeSamples)
I 643.320s run_tests_on_device(03832b22f0e944a0) Actual: false
I 643.320s run_tests_on_device(03832b22f0e944a0) Expected: true
I 643.320s run_tests_on_device(03832b22f0e944a0) [ CRASHED ]
I 643.405s run_tests_on_device(0384888cf0e945d1) >>ScopedMainEntryLogger
I 643.405s run_tests_on_device(0384888cf0e945d1) Note: Google Test filter = AudioEncoderOpusComplexityAdaptationTest.AdaptationOn
I 643.405s run_tests_on_device(0384888cf0e945d1) [==========] Running 1 test from 1 test case.
I 643.405s run_tests_on_device(0384888cf0e945d1) [----------] Global test environment set-up.
I 643.405s run_tests_on_device(0384888cf0e945d1) [----------] 1 test from AudioEncoderOpusComplexityAdaptationTest
I 643.405s run_tests_on_device(0384888cf0e945d1) [ RUN ] AudioEncoderOpusComplexityAdaptationTest.AdaptationOn
I 643.405s run_tests_on_device(0384888cf0e945d1) ../../webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc:36: Failure
I 643.405s run_tests_on_device(0384888cf0e945d1) Value of: audio_loop.Init(kInputFileName, kMaxLoopLengthSamples, kInputBlockSizeSamples)
I 643.405s run_tests_on_device(0384888cf0e945d1) Actual: false
I 643.405s run_tests_on_device(0384888cf0e945d1) Expected: true
I 643.405s run_tests_on_device(0384888cf0e945d1) [ CRASHED ]
Original issue's description:
> Re-enable Opus complexity tests on Android
>
> BUG=webrtc:6708
> TBR=minyue@webrtc.org
>
> Review-Url: https://codereview.webrtc.org/2589673002
> Cr-Commit-Position: refs/heads/master@{#15667}
> Committed: 14479ddfd4
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6708
Review-Url: https://codereview.webrtc.org/2589703002
Cr-Commit-Position: refs/heads/master@{#15668}
The file was aldready pruned down to the point where it only included
webrtc/typedefs.h. Therefore, all includes of
voice_engine_configurations.h are replaced with typedefs.h, except on
two occasions where it was obvously not needed.
BUG=webrtc:6506
Review-Url: https://codereview.webrtc.org/2553583002
Cr-Commit-Position: refs/heads/master@{#15547}
This moves some GN check configurations out of .gn to individual targets.
The now checked targets are:
"//webrtc/api/*",
"//webrtc/audio/*",
"//webrtc/modules/audio_coding/*",
Many targets were fixed by adding dependencies, but the ones that
requires more refactorings are left with the check_includes attribute
set to false instead.
Make //webrtc/test:test_support a public dep of //webrtc/test:test_main
to avoid having to add that to all users of it.
BUG=webrtc:6828
NOTRY=True
Review-Url: https://codereview.webrtc.org/2556943003
Cr-Commit-Position: refs/heads/master@{#15461}
The Bazel build format doesn't support having separate
lists of compilation flags for C and C++; it just has a single
copts list for cc_library:
https://bazel.build/versions/master/docs/be/c-cpp.html#cc_binary.copts
This makes it hard to convert our GN targets to Bazel when there are
compiler warnings that aren't supported for C (like -Woverloaded-virtual
being added in bugs.webrtc.org/6653).
The solution for this is to move all .c files to their own targets
and remove C++-only compiler flags during conversion.
New targets:
//webrtc/common_audio:common_audio_c
//webrtc/common_audio:common_audio_neon_c
//webrtc/modules/audio_coding:g711_c
//webrtc/modules/audio_coding:g722_c
//webrtc/modules/audio_coding:ilbc_c
//webrtc/modules/audio_coding:isac_c
//webrtc/modules/audio_coding:isac_fix_c
//webrtc/modules/audio_coding:isac_test_util
//webrtc/modules/audio_coding:pcm16b_c
//webrtc/modules/audio_coding:webrtc_opusj_c
//webrtc/modules/audio_device:mac_portaudio
//webrtc/modules/audio_procssing:audio_processing_c
//webrtc/modules/audio_procssing:audio_processing_neon_c
This CL also adds a PRESUBMIT.py check that will throw an error
if targets are mixing .c and .cc files, to preven this from regressing.
BUG=webrtc:6653
NOTRY=True
Review-Url: https://codereview.webrtc.org/2550563003
Cr-Commit-Position: refs/heads/master@{#15433}
There's no longer any need to make the two arguments have the same
signedness, so we can remove a bunch of superfluous (and sometimes
dangerous) casts.
It turned out I also had to fix the safe_cmp functions to properly handle
enums that are implicitly convertible to integers.
NOPRESUBMIT=true
BUG=webrtc:6645
Review-Url: https://codereview.webrtc.org/2534683002
Cr-Commit-Position: refs/heads/master@{#15281}
There's no longer any need to make the two arguments have the same
signedness, so we can drop the "u" suffix on literal integer
arguments.
NOPRESUBMIT=true
BUG=webrtc:6645
Review-Url: https://codereview.webrtc.org/2535593002
Cr-Commit-Position: refs/heads/master@{#15280}
