zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
28,139 Commits 1 Branch 0 Tags
587991c7e1ad25bbeafc8783c2e911634c049988
Commit Graph

28139 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Erik Språng
a57711c941 Fix issue with TransmissionOffset using new pacer code path 
This CL fixes two issues related to the TransmissionOffset header
extension and the new (not yet active) pacer mode.

Previously capture time (if unset) would be populated when put into the
packet history before entering the pacer. Since the pacer now owns the
packets, this does not occur until packet is actually sent, if at all.
Capture has really nothing to do with the packet history, this should
be set by the RtpSender pre-pacing instead.

Furthermore, for retransmissions the old path would take the capture
time from the original packet, build the RTX-wrapped retransmission and
set the toffset extension of the RTX packet using that captured capture
time. Since RTX packets are now fully built before the pacer, this does
not work, and we need to transfer the capture time from the original to
the RTX packet instead.

Bug: webrtc:10633
Change-Id: I031e8b6cc4ab20fb094dbd46720829b78951e7f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146218
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28657}
 2019-07-24 11:24:57 +00:00
Bjorn Terelius
54d9602fe1 Add y-axis tick labels. 
This is intended to by used for visualizing catagorical data, i.e. mapping
numerical enum values to string labels.

Bug: webrtc:10623
Change-Id: Ic9c3da9a3874f479c07412f394a774ae90fd3d7e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145408
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28656}
 2019-07-24 11:00:57 +00:00
Sebastian Jansson
46bbdec1ab Allow AbsSendTime extension to be used for audio streams. 
Bug: webrtc:10742
Change-Id: I565b58e9f8d70e09976775e0c87fe44c8f026e92
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146701
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28655}
 2019-07-24 10:58:37 +00:00
Sebastian Jansson
e1795f4158 Adds remote estimate RTCP packet. 
This adds the RemoteEstimate rtcp packet and wires it up to GoogCC where
it's used to improve congestion controller behavior.

The functionality is negotiated using SDP.

It's added with a field trial that allow disabling the functionality in
case there's any issues.

Bug: webrtc:10742
Change-Id: I1ea8e4216a27cd2b00505c99b42d1e38726256c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146602
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28654}
 2019-07-24 10:17:26 +00:00
Chen Xing
1796a820f6 Add performance optimization for empty RtpPacketInfos. 
Bug: webrtc:10668
Change-Id: I879afbb2d6aad77e9db97f8b6a938bf760aab9f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146703
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Chen Xing <chxg@google.com>
Cr-Commit-Position: refs/heads/master@{#28653}
 2019-07-24 10:10:16 +00:00
chromium-webrtc-autoroll
bc6f113bd2 Roll chromium_revision 30f282ecdc..5e244999c5 (680117:680219) 
Change log: 30f282ecdc..5e244999c5
Full diff: 30f282ecdc..5e244999c5

Changed dependencies
* src/base: 873df1d5e0..5c44878134
* src/ios: f19b964380..2ba186d7c8
* src/testing: f648669df2..6897d4e6af
* src/third_party: 5d2b72dcc1..d78a730cee
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/282f4dfee6..5f7b2c2ad2
* src/tools: 73b746fb8c..2cdc672efe
DEPS diff: 30f282ecdc..5e244999c5/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I30a5eb8ee8944801b46471a326226f475966f73d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146720
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28652}
 2019-07-24 00:36:23 +00:00
Yves Gerey
f781bb57c3 [Unit test] Add check to prevent segfault on empty vector. 
We rather have an unmet expectation than let the test crash.

Bug: webrtc:10827
Change-Id: I9e3d2dfb7cb856976305cd50377a71a2ed2ab4b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146700
Commit-Queue: Seth Hampson <shampson@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28651}
 2019-07-23 22:12:49 +00:00
Erik Språng
b9f5989e05 Remove legacy/unused RtpPacketHistory::StorageMode::kStore 
The kStoreAndCull mode has been the default since May 3rd 2019:
https://webrtc.googlesource.com/src/+/d2a634447f42d6856656a9fcdb65d5845b736941

Let's clean away the old code.

Bug: webrtc:8975
Change-Id: I5f41b48b68aecce281cbb713e50db60c8a89da9a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146213
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28650}
 2019-07-23 21:20:50 +00:00
chromium-webrtc-autoroll
d48fbfc513 Roll chromium_revision 4a2e9a72c6..30f282ecdc (680003:680117) 
Change log: 4a2e9a72c6..30f282ecdc
Full diff: 4a2e9a72c6..30f282ecdc

Changed dependencies
* src/base: e640294d88..873df1d5e0
* src/build: cec4d9f37c..e122797000
* src/buildtools: 67b293ca13..aeda9c123d
* src/buildtools/linux64: git_revision:972ed755f8e6d31cae9ba15fcd08136ae1a7886f..git_revision:152c5144ceed9592c20f0c8fd55769646077569b
* src/buildtools/mac: git_revision:972ed755f8e6d31cae9ba15fcd08136ae1a7886f..git_revision:152c5144ceed9592c20f0c8fd55769646077569b
* src/buildtools/win: git_revision:972ed755f8e6d31cae9ba15fcd08136ae1a7886f..git_revision:152c5144ceed9592c20f0c8fd55769646077569b
* src/ios: f1037b0efa..f19b964380
* src/testing: 0e2c31a7e4..f648669df2
* src/third_party: 6ca0968e6b..5d2b72dcc1
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/249e608964..282f4dfee6
* src/tools: c573f89604..73b746fb8c
DEPS diff: 4a2e9a72c6..30f282ecdc/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I62620b6ae101f87f623bb65427329c99a36b68ed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146682
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28649}
 2019-07-23 20:32:08 +00:00
chromium-webrtc-autoroll
66c5bdff64 Roll chromium_revision 54f75614d2..4a2e9a72c6 (679885:680003) 
Change log: 54f75614d2..4a2e9a72c6
Full diff: 54f75614d2..4a2e9a72c6

Changed dependencies
* src/base: 5d2a0d33d5..e640294d88
* src/build: 21f0d29253..cec4d9f37c
* src/ios: f487256b4a..f1037b0efa
* src/testing: 5e1cf8a4d0..0e2c31a7e4
* src/third_party: 44a886b579..6ca0968e6b
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1855bc3168..249e608964
* src/tools: 43225ed512..c573f89604
DEPS diff: 54f75614d2..4a2e9a72c6/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I67f646e36c07b32915bf8be09f60b2633fffa858
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146680
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28648}
 2019-07-23 16:36:32 +00:00
Bjorn A Mellem
74a1b4b132 Only include payload in bytes sent/received. 
According to https://www.w3.org/TR/webrtc-stats/#sentrtpstats-dict* and
https://tools.ietf.org/html/rfc3550#section-6.4.1, the bytes sent
statistic should not include headers or padding.

Similarly, according to
https://www.w3.org/TR/webrtc-stats/#inboundrtpstats-dict*, bytes
received are calculated the same way as bytes sent (eg. not including
padding or headers).

This change stops adding padding and headers to these statistics.

Bug: webrtc:8516,webrtc:10525
Change-Id: I891ad5a11a493cc3212afe93e13f62795bf4031f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146180
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Commit-Queue: Bjorn Mellem <mellem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28647}
 2019-07-23 13:52:55 +00:00
Mirko Bonadei
cfefa0aef3 Revert "Record audio/video bytes sent in analyzer stream stats." 
This reverts commit d978cb43c238ca24b2320acd7b656f446b906101.

Reason for revert: It breaks perf tests: https://ci.chromium.org/p/webrtc/builders/perf/Perf%20Android32%20(L%20Nexus4)/1561

Original change's description:
> Record audio/video bytes sent in analyzer stream stats.
> 
> For each SSRC report, record the number of bytes sent for that stream
> and expose them in analyzer stats.  These numbers can be used to
> determine useful metrics such as total media throughput (by adding the
> bytes sent for all streams) and overhead (by subtracting that amount
> from the total bytes sent to the network).
> 
> Bug: webrtc:9719
> Change-Id: I977bbd40acdd0a1ec64763ddd55a642b9a50f309
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146240
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Artem Titov <titovartem@webrtc.org>
> Commit-Queue: Bjorn Mellem <mellem@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28637}

TBR=mbonadei@webrtc.org,mellem@webrtc.org,titovartem@webrtc.org

Change-Id: I3e46307dd6ef121b9377b93fc8d9fa788245ea5f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9719
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146605
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28646}
 2019-07-23 13:24:42 +00:00
Mirko Bonadei
61689ab063 Make api/video:encoded_image public. 
Bug: webrtc:9378
Change-Id: I2cff5e1463f40af11fc011a41ecdddf3c763c4b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146601
Reviewed-by: Bjorn Mellem <mellem@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28645}
 2019-07-23 13:05:19 +00:00
Artem Titov
cbc91efaa0 Improve low bandwidth audio test instrumentatin, fix PC test 
Bug: webrtc:10138
Change-Id: I1d72fcac642064e569f6aac259fd0b6e0cf5c8b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146603
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28644}
 2019-07-23 11:54:10 +00:00
chromium-webrtc-autoroll
85ef3eab94 Roll chromium_revision 4bcccabeb9..54f75614d2 (679778:679885) 
Change log: 4bcccabeb9..54f75614d2
Full diff: 4bcccabeb9..54f75614d2

Changed dependencies
* src/base: 17dca3dbd2..5d2a0d33d5
* src/build: e7232efebc..21f0d29253
* src/ios: 64568b4437..f487256b4a
* src/testing: 760041599f..5e1cf8a4d0
* src/third_party: 917371f88f..44a886b579
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/da50ef4e8d..1855bc3168
* src/third_party/depot_tools: 73065b2067..c420221f1d
* src/tools: a8eba5322a..43225ed512
DEPS diff: 4bcccabeb9..54f75614d2/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I683505bbdb8e4057c08115b70958ddbf17fcb84f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146643
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28643}
 2019-07-23 06:34:20 +00:00
chromium-webrtc-autoroll
2ac9503910 Roll chromium_revision 753411f0de..4bcccabeb9 (679672:679778) 
Change log: 753411f0de..4bcccabeb9
Full diff: 753411f0de..4bcccabeb9

Changed dependencies
* src/base: 027091ac72..17dca3dbd2
* src/build: 100b5fe120..e7232efebc
* src/testing: e245f25502..760041599f
* src/third_party: 365ab9631c..917371f88f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/fddf524c1a..da50ef4e8d
* src/third_party/depot_tools: ee7b9dda90..73065b2067
* src/third_party/googletest/src: 6077f444da..b77e5c7625
* src/tools: cbd7c754d5..a8eba5322a
DEPS diff: 753411f0de..4bcccabeb9/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I660db993d2a889a99a4ddd75f10b923e4f098a9f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146640
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28642}
 2019-07-23 00:49:13 +00:00
chromium-webrtc-autoroll
e32cb728dc Roll chromium_revision 868676c219..753411f0de (679562:679672) 
Change log: 868676c219..753411f0de
Full diff: 868676c219..753411f0de

Changed dependencies
* src/base: 8b69cffbe6..027091ac72
* src/build: 2c38734e86..100b5fe120
* src/ios: 26f08c3278..64568b4437
* src/testing: 34b9e0128e..e245f25502
* src/third_party: 0d0f3845c1..365ab9631c
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/53913cecb1..fddf524c1a
* src/tools: 7da1abd795..cbd7c754d5
DEPS diff: 868676c219..753411f0de/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Id2e563007453acaa5b1012384b1b4519a220ac62
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146584
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28641}
 2019-07-22 21:07:54 +00:00
Yves Gerey
8fcf354fa1 [tsan] Suppress all of libpulsecommon*.so, following chromium. 
Hide benign data race in libpulse init.
Mirror what have been done here:
https://chromium-review.googlesource.com/c/chromium/src/+/690578/

Bug: chromium:244856
Change-Id: If9aa871ca3405141f2a62622704b6805cdda5fac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146545
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#28640}
 2019-07-22 18:28:22 +00:00
Debrian Figueroa
3f53edbe5e Add json output arg to mb gen and analyze. 
Allows writing of output error to json output path specified.

Bug: chromium:985959
Change-Id: I93205451d3537072607b2a243e9a5216ae231099
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146273
Commit-Queue: Debrian Figueroa <debrian@google.com>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#28639}
 2019-07-22 17:12:06 +00:00
chromium-webrtc-autoroll
97273d011a Roll chromium_revision 9f7a1184bf..868676c219 (679448:679562) 
Change log: 9f7a1184bf..868676c219
Full diff: 9f7a1184bf..868676c219

Changed dependencies
* src/base: eee74e3854..8b69cffbe6
* src/build: 1e5d7d692f..2c38734e86
* src/ios: c2f7679fa3..26f08c3278
* src/testing: 32b7b8aa8e..34b9e0128e
* src/third_party: d698d6facd..0d0f3845c1
* src/tools: 7b92ba98d4..7da1abd795
DEPS diff: 9f7a1184bf..868676c219/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: If8c1aa57ff64c72826d5846e93c3fb7f6a17bf0e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146582
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28638}
 2019-07-22 16:28:46 +00:00
Bjorn A Mellem
d978cb43c2 Record audio/video bytes sent in analyzer stream stats. 
For each SSRC report, record the number of bytes sent for that stream
and expose them in analyzer stats.  These numbers can be used to
determine useful metrics such as total media throughput (by adding the
bytes sent for all streams) and overhead (by subtracting that amount
from the total bytes sent to the network).

Bug: webrtc:9719
Change-Id: I977bbd40acdd0a1ec64763ddd55a642b9a50f309
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146240
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Bjorn Mellem <mellem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28637}
 2019-07-22 15:42:58 +00:00
Yves Gerey
432fe68af8 [Cleanup] Remove write-only member _sndCardRecDelay. 
The code was doing nothing except for triggering thread sanitizer,
since concurrent writes weren't guarded:
 * ReadRecordedData() through webrtc_audio_module_rec_thread
 * InitPlayout()      through main thread

Bug: webrtc:9751
Change-Id: I7ecf4fa436ff0695e5b998d7e3f159fb6c7e9214
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146216
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#28636}
 2019-07-22 14:26:28 +00:00
Yves Gerey
b93a2451e0 [Unit tests] Remove race condition and dangling pointer to mock. 
Lifetime issue: "webrtc_audio_module_rec_thread" was still accessing
                AudioTransport mock at and after its destruction.

Bug: webrtc:9751
Change-Id: I24308077cdeb77e570b8ec74098f1ae3397b7155
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146217
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#28635}
 2019-07-22 14:22:48 +00:00
Sebastian Jansson
e34d62caec Revert "Makes send side network estimation opt-in." 
This reverts commit c36c8e114df8f21ec286adf1ffe76cf5fc495f53.

Reason for revert: Breaks downstream code.

Original change's description:
> Makes send side network estimation opt-in.
> 
> Bug: webrtc:10742
> Change-Id: I57159a3bf853ef8de32f5ba70ad4fa897ee5c528
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144046
> Reviewed-by: Björn Terelius <terelius@webrtc.org>
> Commit-Queue: Sebastian Jansson <srte@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28631}

TBR=terelius@webrtc.org,srte@webrtc.org

Change-Id: Ie9ce099d9154551fd123dbc1eca96ca2730fbc9f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10742
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146544
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28634}
 2019-07-22 12:55:52 +00:00
Mirko Bonadei
f24729bba7 Add usage message to rtc_event_log2rtp_dump. 
Bug: webrtc:10616
Change-Id: I363715bedd28b9c74cefd3b4fd510f16963909f7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146210
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28633}
 2019-07-22 12:29:39 +00:00
Sebastian Jansson
7ea6b290d0 Adds improved estimate bounded backoff to AimdRateControl. 
Bug: webrtc:10498
Change-Id: I4e006e437dfa667b738beb009a599bacc6778da5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146215
Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28632}
 2019-07-22 12:22:09 +00:00
Sebastian Jansson
c36c8e114d Makes send side network estimation opt-in. 
Bug: webrtc:10742
Change-Id: I57159a3bf853ef8de32f5ba70ad4fa897ee5c528
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144046
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28631}
 2019-07-22 12:17:29 +00:00
Mirko Bonadei
6982f6091b Remove empty OWNERS file. 
No-Try: True
Bug: None
Change-Id: Ief114d10198c0b5871bd431c79c78eb5e36f35d8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146541
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28630}
 2019-07-22 11:55:23 +00:00
Artem Titov
39483c6662 Migrate some Vp8 simulcast and screen share tests on PC framework 
Bug: webrtc:10138
Change-Id: I2fc1cafc128c9604bfad4967066a8718edc62d20
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146083
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28629}
 2019-07-22 09:38:26 +00:00
Mirko Bonadei
ec3580361e Revert "Don't use all_dependent_configs for sdk frameworks" 
This reverts commit 63741c7fa1aa55a38af11ac8cc04498722f9407d.

Reason for revert: It breaks a chromium.fyi bot (https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Mac%20Builder%20(dbg)/3974)

Original change's description:
> Don't use all_dependent_configs for sdk frameworks
> 
> libs should be propagated to the final binary even without that:
> https://gn.googlesource.com/gn/+/master/docs/reference.md#var_libs
> 
> But add some missing SDK framework dependencies:
> 
> * RTCNativeI420Buffer.mm uses CGBitmapContextGetBytesPerRow.
> * socketrocket uses SecCertificateCopyData.
> 
> Bug: None
> Change-Id: Iba38a5dfaf470a5a790d494cbec8ade44b1d16ba
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146082
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28605}

TBR=mbonadei@webrtc.org,oprypin@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I9e2fdb5753905cb4bf04820a8077feba78f463e6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146542
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28628}
 2019-07-22 08:46:36 +00:00
Mirko Bonadei
e9ff992fd6 Fix isac_fix_test perf reporting. 
The regression has been introduced by [1] and here is an example of
the problem [2].

[1] - https://webrtc.googlesource.com/src/+/2ab97f6f8e27b47c0d9beeb8b6ca5387bda9f55c
[2] - https://ci.chromium.org/p/webrtc/builders/perf/Perf%20Linux%20Trusty/1543

TBR=minyue@webrtc.org

Bug: webrtc:10616
Change-Id: I109b55a612d49981ce74c3e4cd50603ee0003250
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146540
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28627}
 2019-07-22 07:24:07 +00:00
chromium-webrtc-autoroll
84d5d9f34e Roll chromium_revision 38f67470c9..9f7a1184bf (679342:679448) 
Change log: 38f67470c9..9f7a1184bf
Full diff: 38f67470c9..9f7a1184bf

Changed dependencies
* src/base: 9183ddf77a..eee74e3854
* src/build: 72caf3c67d..1e5d7d692f
* src/ios: d57620b0c9..c2f7679fa3
* src/testing: 53ac2c9ad0..32b7b8aa8e
* src/third_party: 56660a7590..d698d6facd
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/07432f325d..4dfd5af701
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5075be939f..53913cecb1
* src/third_party/depot_tools: 5e67857cb3..ee7b9dda90
* src/tools: e852164555..7b92ba98d4
DEPS diff: 38f67470c9..9f7a1184bf/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I0957338cf54a400ca1111e1d32e757aded94cc05
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146501
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28626}
 2019-07-22 02:48:15 +00:00
chromium-webrtc-autoroll
d518f3973c Roll chromium_revision 84818c0e32..38f67470c9 (679230:679342) 
Change log: 84818c0e32..38f67470c9
Full diff: 84818c0e32..38f67470c9

Changed dependencies
* src/base: ce23ecb4d8..9183ddf77a
* src/build: 2efaee3d3b..72caf3c67d
* src/buildtools: 7b7a5c0f25..67b293ca13
* src/ios: 4e3fdab69b..d57620b0c9
* src/testing: f58cf56634..53ac2c9ad0
* src/third_party: 3e042f6cec..56660a7590
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4f6d452cee..5075be939f
* src/third_party/depot_tools: f4e0cc69ee..5e67857cb3
* src/third_party/r8: -ZVn1C00lIdjTSJqwdg9GyT_jqzY8RmSrZ7NGfQFeZ4C..1ceH-5pheRe3OUeFz4TzVc2xcu6sm45yeFQBTT4rd6IC
* src/tools: 37c95773ff..e852164555
DEPS diff: 84818c0e32..38f67470c9/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Idfe274cb43bf0a115de3587096a8c4179904bb1c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146320
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28625}
 2019-07-20 02:42:43 +00:00
chromium-webrtc-autoroll
650df3842d Roll chromium_revision eec6819794..84818c0e32 (679083:679230) 
Change log: eec6819794..84818c0e32
Full diff: eec6819794..84818c0e32

Changed dependencies
* src/build: c98642948c..2efaee3d3b
* src/ios: 3e1870f4f4..4e3fdab69b
* src/testing: 1c9a871bd2..f58cf56634
* src/third_party: fe938bdd85..3e042f6cec
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/09050cb498..07432f325d
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5651a8c336..4f6d452cee
* src/tools: cab21fee1d..37c95773ff
DEPS diff: eec6819794..84818c0e32/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ibe2991963695a787f1049e06d5c42759d14c01b9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146271
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28624}
 2019-07-19 20:33:19 +00:00
Sebastian Jansson
22ff9fc6bc Removes overuse predictor. 
It's not currently used and it complicates receive side estimation.

Bug: webrtc:10742
Change-Id: Iaa3c86807c7b637aea3ff393e728dc91eac23db6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145724
Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28623}
 2019-07-19 15:22:25 +00:00
chromium-webrtc-autoroll
71c52a8002 Roll chromium_revision e02114c8fa..eec6819794 (678980:679083) 
Change log: e02114c8fa..eec6819794
Full diff: e02114c8fa..eec6819794

Changed dependencies
* src/ios: 9038e03eb1..3e1870f4f4
* src/testing: 46959ed82d..1c9a871bd2
* src/third_party: 3b2eb39e31..fe938bdd85
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/42a883d132..5651a8c336
* src/third_party/r8: 6xVKWv-ssICwyU5FC1osaRpeZio2kM4Tko33I_SIK-EC..-ZVn1C00lIdjTSJqwdg9GyT_jqzY8RmSrZ7NGfQFeZ4C
* src/tools: a99b9c5b68..cab21fee1d
DEPS diff: e02114c8fa..eec6819794/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I8130efc3272aa28f76390f5a5883c7cda4673f5f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146267
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28622}
 2019-07-19 14:38:55 +00:00
Steve Anton
fefa77c426 Add pthread thread-local storage support for ScopedYieldPolicy 
Emscripten does not support C++11 thread_local but does support
the pthread TLS API.

Bug: None
Change-Id: Ia21895148d1df7652579d086d9e1c0c53d7a85f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145441
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28621}
 2019-07-19 14:33:53 +00:00
Mirko Bonadei
836ab13f1c Remove rtc::Flag. 
WebRTC has been migrated to Abseil Flags.

Bug: webrtc:10616
Change-Id: Id4a363429ccd2dd55c0dff00c9490c15124fdccc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144631
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28620}
 2019-07-19 14:05:01 +00:00
Mirko Bonadei
5693c26ad3 Remove rtc_tools/frame_editing. 
This tool is unused, this CL removes it in order to reduce the cost
of the maintenance (in the last 2 years only maintenance commits have
been landed in this directory).

Bug: None
Change-Id: Ieec113bc25c480405d32e284a0456572758352e0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146204
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28619}
 2019-07-19 13:34:11 +00:00
Oleh Prypin
ef3eda94a2 Allow using more jni targets on Linux 
Bug: None
Change-Id: Ied19f9eb399ef89d4f95028857efe77d3ee54693
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146214
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28618}
 2019-07-19 13:31:21 +00:00
Yves Gerey
1afe657d5c [Sanitizers] Disable tests at compile-time rather than run-time. 
Rationale:
 * More explicit (you won't miss that when glancing at the code).
 * More consistent (see MAYBE_* in other tests).
 * Allow to re-activate tests via CLI (--gtest_also_run_disabled_tests).
 * Tests won't wrongly show up as PASSING (bug/webrtc:10819),
   since they won't show up at all.

Bug: webrtc:9778
Change-Id: Ic32e18cb8ee2352def95206c2aa66e1dea0cc1e3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146200
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#28617}
 2019-07-19 11:56:42 +00:00
Erik Språng
21f2fc9c73 Remove the non-useful rtx payload padding option 
This CL removes the field trial left in place as a kill-switch in case
there were any regressions related to selecting payload padding based
on the likelihood of being useful instead of matching size.

It also removes the functionality that was only enabled with the
kill-switch active.

The feature has been default-on since June 23rd 2019:
https://webrtc.googlesource.com/src.git/+/214f54365ec210db76218a35ead66c9ce23e068e

Since we have not observed any issues, let's clean this code up.

Bug: webrtc:8975
Change-Id: I7f49fe354227b3f6566a250332e56b6d70fe2f09
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145821
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28616}
 2019-07-19 11:19:18 +00:00
Mirko Bonadei
76c89daac5 Add usage message to peerconnection_server. 
Bug: webrtc:10616
Change-Id: I5d8165c3c1f73dc5b5c3eb2307c26fe107ed96be
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146211
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28615}
 2019-07-19 11:18:08 +00:00
Mirko Bonadei
249bade314 Add usage message to rgba_to_i420_converter. 
Bug: webrtc:10616
Change-Id: Id8268bada4ec42130d9b7b105da73218dfa43519
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146209
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28614}
 2019-07-19 11:17:04 +00:00
Erik Språng
0f6191d227 RtpSender::GeneratePadding() fixes for new PacedSender code path 
This CL fixes two things related to the (not yet active) new
PacedSender code path:

1. Make sure BWE header extensions are properly populated for all
   padding packets.
2. When generating padding, don't hold the RtpSender critsect when
   accessing the RtpPacketHistory as this may lead to a lock order
   inversion.

Bug: webrtc:10633
Change-Id: I8650fbf5dafddbeae61837d2137338163e1c48ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145723
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28613}
 2019-07-19 10:58:34 +00:00
Artem Titov
d70d80d882 Add support of negotiating Vp9 SVC in PC test framework. 
SVC support is limited:
During SVC testing there is no SFU, so framework will try to emulate SFU
behavior in regular p2p call. Because of it there are such limitations:
 * if |target_spatial_index| is not equal to the highest spatial layer
   then no packet/frame drops are allowed.

   If there will be any drops, that will affect requested layer, then
   WebRTC SVC implementation will continue decoding only the highest
   available layer and won't restore lower layers, so analyzer won't
   receive required data which will cause wrong results or test failures.

Bug: webrtc:10138
Change-Id: I079566260ca9f1815935bce365d1bca10766663a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144882
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28612}
 2019-07-19 10:01:43 +00:00
Mirko Bonadei
7ddca16e1e Add usage message to reference_less_video_analysis. 
Bug: webrtc:10616
Change-Id: Ibbaba9ec6a74466021e70d01f3a8ff4c3fd212b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146205
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28611}
 2019-07-19 09:16:00 +00:00
Mirko Bonadei
4e722459ec Add usage message to psnr_ssim_analyzer. 
Bug: webrtc:10616
Change-Id: I157fbf63b3794a1f655901ace7355edb1240cc72
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146203
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28610}
 2019-07-19 09:11:40 +00:00
Mirko Bonadei
06cdb23644 Add usage message to rtp_generator. 
Bug: webrtc:10616
Change-Id: Ia13b1e829063986be6b3b4a4b0c194dd4fea3511
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146202
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28609}
 2019-07-19 08:49:13 +00:00
Jonas Olsson
857ad62721 Remove priority_rate from AudioStreamConfig. 
This API is going away, we'll use the WebRTC-Audio-Allocation field
trial flag to set this value in the future.

Bug: webrtc:10556
Change-Id: I2c4c1948a33f909fac069dd038cea36a793e4745
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145405
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28608}
 2019-07-19 08:29:55 +00:00