3a285224b6
Reland "Linux capturers: organize X11 and Wayland implementations into separate folders"
...
Bug: webrtc:13429
Change-Id: I6e88de4f7ebcb64076312d83ac2c79db24f85ad8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239841
Commit-Queue: Mark Foltz <mfoltz@chromium.org >
Reviewed-by: Mark Foltz <mfoltz@chromium.org >
Cr-Commit-Position: refs/heads/main@{#35481}
2021-12-06 17:30:16 +00:00
833b095694
add more owners to mb
...
Bug: None
Change-Id: I24616c391b61264e4509f20ffd6d1accd7f3bab9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239843
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35480}
2021-12-06 16:46:16 +00:00
a74e6469af
Roll chromium_revision 73b489ca92..c9b7d1eaff (948404:948519)
...
Change log: 73b489ca92..c9b7d1eaff73b489ca92..c9b7d1eaff623bc83ae7..0b17eeba326f83205785..ec07f541c3546615a3cb..8d7a8e895b738d629096..388f393001https://chromium.googlesource.com/catapult.git/+log/32ccf21284..02439f647c
* src/third_party/depot_tools: 203a6447ad..440d06ad1ae9e81c0152..b54e61f0f20f5f7108d9..36b6cbee1773b489ca92..c9b7d1eaffhttps://webrtc-review.googlesource.com/c/src/+/240023
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35479}
2021-12-06 14:49:36 +00:00
4647528911
Optimize the saturation detection (used by AnalyzeCapture()).
...
Changing to an index for-loop (instead of a range for-loop) allows the compiler (clang for x86 at least) to unroll it x2.
Bug: None
Change-Id: I9b9612a8513a06e8aa3b12ae39f6911217da55fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239741
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Christian Schuldt <cschuldt@google.com >
Cr-Commit-Position: refs/heads/main@{#35478}
2021-12-06 13:00:59 +00:00
2394977f74
CodeHealth: Python3 migration for tools_webrtc/mb/
...
This CL includes:
* set Pylint to 2.7 in tools_webrtc/mb/PRESUBMIT.py
* fix some style warnings caused by scripts in tools_webrtc/mb/
* pass skip_shebang_check=True within tools_webrtc/mb/PRESUBMIT.py
Bug: chromium:1262287, chromium:1262352
Change-Id: Iae4f111942d724db6a7f4585c97a7c26c1e6ccc0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239660
Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35477}
2021-12-06 12:59:57 +00:00
73d0774b6b
Add PortAllocator configuration to RTCConfiguration
...
So applications don't need to create and inject their own instance of
BasicPortAllocator, just to change these settings.
Bug: webrtc:13145
Change-Id: I08ac8658b4c0ef87019fa579be9195a8a6b50feb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239643
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35476}
2021-12-06 12:14:28 +00:00
a0353c0630
Roll chromium_revision 170ab8e137..73b489ca92 (948299:948404)
...
Change log: 170ab8e137..73b489ca92170ab8e137..73b489ca927c4f75f108..c00740de5bb0031ae7bf..623bc83ae7b22b6075c9..6f832057856e378d06a3..546615a3cb43bd2945eb..738d6290961cb59b35ee..0f5f7108d9170ab8e137..73b489ca92170ab8e137..73b489ca92https://webrtc-review.googlesource.com/c/src/+/239988
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35475}
2021-12-05 22:32:17 +00:00
95d2d00ba1
Roll chromium_revision 3b44e37ab2..170ab8e137 (948184:948299)
...
Change log: 3b44e37ab2..170ab8e1373b44e37ab2..170ab8e137b0a41f08e3..7c4f75f1083771c48fc7..b0031ae7bf0f447a3138..74c6eec693ac4acc3a54..b22b6075c906928cf89e..6e378d06a32f231bb331..43bd2945ebhttps://chromium.googlesource.com/catapult.git/+log/f3173fa043..32ccf21284
* src/third_party/dav1d/libdav1d: 692c0ce873..7b99b0e17f26bfecdd07..203a6447ad1b2606425c..d61d4d8e64d3b90226c8..1cb59b35ee3b44e37ab2..170ab8e137https://webrtc-review.googlesource.com/c/src/+/239807
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35474}
2021-12-04 06:53:05 +00:00
cfe927be14
Roll chromium_revision a49799d372..3b44e37ab2 (947981:948184)
...
Change log: a49799d372..3b44e37ab2a49799d372..3b44e37ab2e46f153a92..b0a41f08e399876cacf7..e435ad79c139cd7a1728..ac4acc3a549044f53831..06928cf89eb0169acc37..2f231bb331https://chromium.googlesource.com/catapult.git/+log/dbf853603c..f3173fa043
* src/third_party/depot_tools: 98be56f2e0..26bfecdd07aeff6922a9..e9e81c01528452dca143..d3b90226c8a49799d372..3b44e37ab2https://webrtc-review.googlesource.com/c/src/+/239803
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35473}
2021-12-03 22:21:31 +00:00
fec9900cc0
Revert "Linux capturers: organize X11 and Wayland implementations into separate folders"
...
This reverts commit 998e9bd5c55de253106b697af691169853a4e91f.
Reason for revert: Breaks downstream projects because some headers
have been renamed without providing a forward header for backwards
compatibility.
Original change's description:
> Linux capturers: organize X11 and Wayland implementations into separate folders
>
> Bug: webrtc:13429
> Change-Id: I2db727797c2ca2bd85937ff732ce3f68bb45469a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238173
> Reviewed-by: Mark Foltz <mfoltz@chromium.org >
> Commit-Queue: Mark Foltz <mfoltz@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#35471}
TBR=tommi@webrtc.org ,sprang@chromium.org ,mfoltz@chromium.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com ,grulja@gmail.com
Change-Id: I2aadfeb30151fcbe1a8c05e856be989d60bb10a3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:13429
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239821
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Alexander Cooper <alcooper@chromium.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35472}
2021-12-03 21:17:14 +00:00
998e9bd5c5
Linux capturers: organize X11 and Wayland implementations into separate folders
...
Bug: webrtc:13429
Change-Id: I2db727797c2ca2bd85937ff732ce3f68bb45469a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238173
Reviewed-by: Mark Foltz <mfoltz@chromium.org >
Commit-Queue: Mark Foltz <mfoltz@chromium.org >
Cr-Commit-Position: refs/heads/main@{#35471}
2021-12-03 18:31:58 +00:00
c8d4c38f04
Roll chromium_revision d934d80b9b..a49799d372 (947870:947981)
...
Change log: d934d80b9b..a49799d372d934d80b9b..a49799d37274ec2dbb00..e46f153a92746224dc80..3771c48fc73e89982838..39cd7a17283ba4068b8f..9044f53831340fd67bdb..b0169acc37c1516f629e..8452dca143d934d80b9b..a49799d372https://webrtc-review.googlesource.com/c/src/+/239780
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35470}
2021-12-03 14:20:40 +00:00
0ee442256c
Add reporting of relay protocol
...
This patch adds reporting of relay protocol,
i.e how a client connect to the turn server.
This is added in the old stats api...cause there
are clients still using it.
Bug: none
Change-Id: Iac7fe3e3de0ba42d5897c304ebbae368edf498fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239640
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35469}
2021-12-03 12:01:14 +00:00
adf7dc34f0
Roll chromium_revision 80cfe1bbbe..d934d80b9b (947754:947870)
...
Change log: 80cfe1bbbe..d934d80b9b80cfe1bbbe..d934d80b9bc62004aeb3..74ec2dbb005b077d5e33..746224dc802029d646ad..3e8998283881f66eb774..3ba4068b8f2cb03de5b8..340fd67bdbhttps://chromium.googlesource.com/catapult.git/+log/fad4e048b0..dbf853603c
* src/third_party/depot_tools: fc79a33466..98be56f2e0e88723663f..c1516f629e80cfe1bbbe..d934d80b9bhttps://webrtc-review.googlesource.com/c/src/+/239727
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35468}
2021-12-03 04:34:28 +00:00
8f25690d54
Roll chromium_revision fbbdfd477b..80cfe1bbbe (947567:947754)
...
Change log: fbbdfd477b..80cfe1bbbefbbdfd477b..80cfe1bbbea82eea6df3..c62004aeb32c47f6b719..5b077d5e33a281fd3d4c..0f447a3138e89fc3f392..2029d646adc70310ef4a..81f66eb774842ebd1e14..2cb03de5b8https://chromium.googlesource.com/catapult.git/+log/5695a8426c..fad4e048b0
* src/third_party/googletest/src: bb9216085f..1b2606425c903f362c7c..e88723663ffbbdfd477b..80cfe1bbbehttps://webrtc-review.googlesource.com/c/src/+/239723
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35467}
2021-12-03 00:50:37 +00:00
5644e55c60
PipeWire capturer: fix issues reported by presubmit check
...
Bug: webrtc:13429
Change-Id: I409a29dad96538e8c555d12b4b455efb3a71e483
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239184
Reviewed-by: Mark Foltz <mfoltz@chromium.org >
Commit-Queue: Mark Foltz <mfoltz@chromium.org >
Cr-Commit-Position: refs/heads/main@{#35466}
2021-12-03 00:33:37 +00:00
7bafbd6c8c
DesktopCaptureOptions should return refptrs where possible
...
There are cases for each of these getters where other code later takes
a reference to the passed object, meaning that these getters should be
returning a refptr. To prevent additional overhead from places that
simply access the getter to call additional methods without needing to
worry about taking a ref, the return values are converted to const refs.
Bug: webrtc:13465
Change-Id: Ib27969c7f5ef9d6aadf3c95ac171ae6e778cdbfa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239720
Reviewed-by: Mark Foltz <mfoltz@chromium.org >
Commit-Queue: Alexander Cooper <alcooper@chromium.org >
Cr-Commit-Position: refs/heads/main@{#35465}
2021-12-02 23:54:57 +00:00
43fc10fc40
Roll chromium_revision b50c75ae41..fbbdfd477b (947439:947567)
...
Change log: b50c75ae41..fbbdfd477bb50c75ae41..fbbdfd477b0175fce238..a82eea6df37d4410e011..2c47f6b7194e83e0173c..e89fc3f3921a819afbae..842ebd1e144a9b683ccb..aeff6922a9f79e695e27..903f362c7cb50c75ae41..fbbdfd477bhttps://webrtc-review.googlesource.com/c/src/+/239700
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35464}
2021-12-02 18:40:47 +00:00
a642df2598
Revert "Use gtest_parallel with 1 worker for webrtc_perf_tests."
...
This reverts commit 258ed1a38ad9d4f0da798c40b6976eff2dce864f.
Reason for revert: This cl breaks the dumping of the perf proto histogram.
Original change's description:
> Use gtest_parallel with 1 worker for webrtc_perf_tests.
>
> This will enable test results to be uploaded to ResultDB.
>
> Bug: b/197492097
> Change-Id: Iec28520c4cd8f35fcff2cbd105a4b851ef41b9fc
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239641
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Christoffer Jansson <jansson@google.com >
> Commit-Queue: Jeremy Leconte <jleconte@google.com >
> Cr-Commit-Position: refs/heads/main@{#35458}
TBR=mbonadei@webrtc.org ,jansson@google.com ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com ,jleconte@webrtc.org
Change-Id: Ic4ab03d0e7f8bc1ce799d30e74420200d2f8f224
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/197492097
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239644
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Reviewed-by: Christoffer Jansson <jansson@google.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#35463}
2021-12-02 13:16:00 +00:00
6c94ad61e7
Roll chromium_revision ab1e4b1c09..b50c75ae41 (947322:947439)
...
Change log: ab1e4b1c09..b50c75ae41ab1e4b1c09..b50c75ae41122962bd63..0175fce23883e1eefbf9..7d4410e01158323b6846..4e83e0173cce98fdf6a9..c70310ef4a4c3d57f854..1a819afbaehttps://aomedia.googlesource.com/aom.git/+log/b5719d38f3..fae44ad047
* src/tools: e92d3d4043..f79e695e27ab1e4b1c09..b50c75ae41ab1e4b1c09..b50c75ae41https://webrtc-review.googlesource.com/c/src/+/239607
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35462}
2021-12-02 13:11:27 +00:00
4b7024b572
Revert "dcsctp: Use rtc::CopyOnWriteBuffer"
...
This reverts commit 2db59a6584eca54245794a0e657ca9ded9e6707f.
Reason for revert: Causes msan-issue in crc32c, reading uninitialized
memory.
Bug: webrtc:12943, chromium:1275559
Change-Id: I05f1012d896aeaca86c4562e0df15fa7ea326d60
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239560
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35461}
2021-12-02 12:33:46 +00:00
4ad09762da
Delete legacy RtpPacketSendInfo::ssrc field
...
Bug: webrtc:12713
Change-Id: I8785eaabbb8725fb119067f5897ef245e6187996
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239642
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35460}
2021-12-02 11:59:37 +00:00
500d6e7f14
Return kSampleUnderrun if the number of samples does not fit in an AudioFrame.
...
If the number of samples does not fit in an AudioFrame, we should return
kSampleUnderrun to avoid crashes further downstream.
Bug: chromium:1265806
Change-Id: Ie94e1de53810167fd9b52ade72b3cb669a2a4f06
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238666
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35459}
2021-12-02 11:48:17 +00:00
258ed1a38a
Use gtest_parallel with 1 worker for webrtc_perf_tests.
...
This will enable test results to be uploaded to ResultDB.
Bug: b/197492097
Change-Id: Iec28520c4cd8f35fcff2cbd105a4b851ef41b9fc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239641
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Christoffer Jansson <jansson@google.com >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#35458}
2021-12-02 10:40:46 +00:00
0763ccc8e3
Don't configure SVC params without per layer bitrate configured.
...
Change-Id: Ieb200ce1a710078e380047ed8af73db0c5e0c751
Bug: none
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239442
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35457}
2021-12-02 09:52:32 +00:00
b5dcbbf9a6
Roll chromium_revision 28e5940d2a..ab1e4b1c09 (947206:947322)
...
Change log: 28e5940d2a..ab1e4b1c0928e5940d2a..ab1e4b1c094056842853..122962bd6310c5306b5f..83e1eefbf91da5f9f6aa..58323b68465c6ecb9673..ce98fdf6a94c819f4a1a..4c3d57f854e685543855..fc79a334664f3656c38b..e92d3d404328e5940d2a..ab1e4b1c09https://webrtc-review.googlesource.com/c/src/+/239620
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35456}
2021-12-02 02:25:17 +00:00
e889b5f801
Roll chromium_revision 27e299b2f4..28e5940d2a (947091:947206)
...
Change log: 27e299b2f4..28e5940d2a27e299b2f4..28e5940d2af510ba5363..4056842853f7800e3695..10c5306b5f665b74f7d1..89f2e82120c936d73ff7..a281fd3d4cf3f80e3620..1da5f9f6aa1018546e10..5c6ecb9673daa9aa1570..4c819f4a1a9296f1edfe..4a9b683ccb023af79284..4f3656c38b27e299b2f4..28e5940d2ahttps://webrtc-review.googlesource.com/c/src/+/239600
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35455}
2021-12-01 22:27:12 +00:00
95e6b8d6f7
Roll chromium_revision abea99b512..27e299b2f4 (946947:947091)
...
Change log: abea99b512..27e299b2f4abea99b512..27e299b2f407fb44c465..f510ba5363acd04d0ee9..f7800e3695b521528b20..f3f80e3620f58d7ccc17..1018546e10f67165847e..daa9aa157070f73380a5..9296f1edfede32b0cbf7..023af79284abea99b512..27e299b2f4https://webrtc-review.googlesource.com/c/src/+/239525
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35454}
2021-12-01 18:30:51 +00:00
794cc227dc
Optimize RenderBuffer.
...
Changing to an index for-loop (instead of using std::transform) allows the compiler (clang for x86 at least) to use 3 different registers in the loop rather than just 1, resulting in less pipeline stall (I'd assume). Interestingly, the compiler unrolls the loop(s) completely in both cases.
Bug: None
Change-Id: I586773bc525e91bb6eb6638d5399928482306b9f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239364
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Christian Schuldt <cschuldt@google.com >
Cr-Commit-Position: refs/heads/main@{#35453}
2021-12-01 14:52:21 +00:00
59b8a46d3f
Fix low_bandwidth_audio_test on Windows bots.
...
Bug: b/197492097
Change-Id: I29ae4d699c3c928f9d22da8cf9026c462f3afa7e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239540
Reviewed-by: Christoffer Jansson <jansson@google.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#35452}
2021-12-01 13:04:52 +00:00
408a866cfc
Roll chromium_revision 39e73a0204..abea99b512 (946822:946947)
...
Change log: 39e73a0204..abea99b51239e73a0204..abea99b512241200489d..07fb44c4656bc4ab94a3..acd04d0ee9f3bfdf6913..b521528b20dddf6836b0..f58d7ccc1717ad36f7fb..f67165847ead7c145263..e685543855bf66d373ae..edf883ad2d3702b35757..de32b0cbf739e73a0204..abea99b512https://webrtc-review.googlesource.com/c/src/+/239522
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35451}
2021-12-01 12:58:02 +00:00
ff05f1fd89
TaskQueuePacedSender: Process packets after outstanding data update
...
Bug: webrtc:10809
Change-Id: I31785c529d331891830777c93d7067f96580ea39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238967
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35450}
2021-12-01 11:59:01 +00:00
8d89f461c9
Remove --isolated from mb.py
...
This option is not supported now.
Bug: chromium:1271841
Change-Id: I27dd1531589ac497ef345fff41897a087ace4362
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239461
Reviewed-by: Takuto Ikuta <tikuta@google.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Junji Watanabe <jwata@google.com >
Cr-Commit-Position: refs/heads/main@{#35449}
2021-12-01 06:15:41 +00:00
d4516d86d3
Roll chromium_revision 1932b16547..39e73a0204 (946682:946822)
...
Change log: 1932b16547..39e73a02041932b16547..39e73a0204dbc5f6096e..241200489dc82934398a..6bc4ab94a36d5a3ef834..f3bfdf6913f5addf91c9..dddf6836b02ea1121894..17ad36f7fbee2ad61263..0ae29c99d1https://chromium.googlesource.com/catapult.git/+log/bd8b0c2c47..5695a8426c
* src/third_party/depot_tools: 320a1caf81..ad7c145263abe1a8bc88..70f73380a50fdcc84d75..3702b357571932b16547..39e73a0204https://webrtc-review.googlesource.com/c/src/+/239480
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35448}
2021-12-01 03:00:30 +00:00
4774a9fcb8
Fix rate statistic when time window running out of samples
...
Current rate statistic tracker has assumption, the tracking window will
always be full after first filled up. This assumption looks not always
true. One example is the input_framerate_ tracker inside
video_stream_sender.cc which is used for setup frame droper and encoder.
Whenever there is a gap in video stream, like mute/unmute,
pacer pause/unpause etc. The fps detected from the rate_statistics
becomes samples_filled_partial_window / full_window_size, which could
be extremely low for a while. This creates a misalignment between the
fps we told encoder/frame dropper, and the real fps we fed into them,
which causes short-term serious overshot and very bad experience on
delay, avsync, congestion etc. This may also depends on how fast
encoder could react to the gap between set fps and real fps, but
libvpx and openh264 at least cannot handle this well.
So propose a fix to update first timestamp after tracker window
drained. This will give more accurate fps estimate similar based on
active window after sample gets drained
Bug: webrtc:13403
Change-Id: I96792c11091fe8bfa63e669f4360a3b3e95593e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237720
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35447}
2021-11-30 23:57:40 +00:00
f0290eb6fd
Roll chromium_revision b956d14f88..1932b16547 (946538:946682)
...
Change log: b956d14f88..1932b16547b956d14f88..1932b165472ade335c68..dbc5f6096ecc2a3e818b..c82934398ab4943c7220..6d5a3ef8342f3258e975..f5addf91c9368033fffc..2ea1121894https://chromium.googlesource.com/catapult.git/+log/8cf0922154..bd8b0c2c47
* src/third_party/depot_tools: 804165b445..320a1caf813b45f564e9..03380482ce9e18a83edc..abe1a8bc88fad05cbf2a..0fdcc84d75b956d14f88..1932b16547https://webrtc-review.googlesource.com/c/src/+/239434
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35446}
2021-11-30 22:51:32 +00:00
063bb384f8
sdp: temporarily raise mid limit to 32
...
to avoid breaking existing deployments. Also measure usage.
BUG=webrtc:12517
Change-Id: Ic38f1b45e79e46da9ff6fe927b0c5351443ccd96
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239188
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/main@{#35445}
2021-11-30 21:05:51 +00:00
0ce7f165fd
Roll chromium_revision add2d2ddee..b956d14f88 (946436:946538)
...
Change log: add2d2ddee..b956d14f88add2d2ddee..b956d14f8845c59f126d..2ade335c68726a5fd8ba..cc2a3e818b302ce56025..b4943c722032c8bef651..2f3258e975755e7d848a..368033fffc3dd5b80bc4..b52786888db9dad73621..9e18a83edc2128c47e06..fad05cbf2aadd2d2ddee..b956d14f88https://webrtc-review.googlesource.com/c/src/+/239432
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35444}
2021-11-30 18:47:14 +00:00
f42e00097d
Roll chromium_revision a3e750c9b0..add2d2ddee (946315:946436)
...
Change log: a3e750c9b0..add2d2ddeea3e750c9b0..add2d2ddeee6e0ee5bae..45c59f126de0d5dbffaa..726a5fd8baaf6e3bb63e..302ce5602569383604c0..32c8bef65192767b0feb..755e7d848ae2f3978937..bb9216085f0e7a87dbf5..2128c47e06a3e750c9b0..add2d2ddeehttps://webrtc-review.googlesource.com/c/src/+/239430
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35443}
2021-11-30 14:31:14 +00:00
90cc4fe0e9
Revert "Call: Deduplicate SentPacket notifications"
...
This reverts commit 61a8d9caaa31ab4ef953415882f97be5a4248774.
Reason for revert: We have identified some downstream regressions caused by this change (https://crbug.com/webrtc/13437 ).
Original change's description:
> Call: Deduplicate SentPacket notifications
>
> When bundling is in effect, multiple senders may be sharing the same
> transport. It means every |sent_packet| will be multiply notified from
> different channels, WebRtcVoiceMediaChannel or WebRtcVideoChannel.
> Record |last_sent_packet_| to deduplicate redundant notifications to
> downstream objects.
>
> This CL reduces 50% PostTask/Wakeup of Dynamic Mode Pacer.
>
> [1] https://datatracker.ietf.org/doc/html/rfc8829#section-4.1.1
> [2] https://datatracker.ietf.org/doc/html/rfc8843
>
> Bug: webrtc:13417
> Change-Id: Ib121d5af07abe208bd7d36715a234f48cdabb032
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238720
> Reviewed-by: Markus Handell <handellm@webrtc.org >
> Reviewed-by: Stefan Holmer <stefan@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Tommi <tommi@webrtc.org >
> Commit-Queue: Markus Handell <handellm@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35417}
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:13417
Change-Id: Ib1230fa07db56c33941a5b529a28f83d6d08d74d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239441
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Reviewed-by: Markus Handell <handellm@webrtc.org >
Owners-Override: Jakob Ivarsson <jakobi@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35442}
2021-11-30 11:49:51 +00:00
af5ca5af75
Fix potential use after move in RtpVideoStreamReceiver
...
When a frame is assembled `packet_infos` is moved and must be
re-initialized before potentially being used in another iteration of the
loop. Clear `packet_infos` immediately instead of relying on it being
implicitly cleared in the next iteration of the loop.
Bug: None
Change-Id: I954aaa0c6df296cc2a27b3ab496e49fac200f135
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238981
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35441}
2021-11-30 11:20:21 +00:00
d58ac5adf8
sdp: reject large number of channels
...
the maximum used in practice is multiopus with
6 or 8 channels. 24 is the maximum number of channels
supported in the audio decoder.
BUG=chromium:1265806
Change-Id: Iba8e3185a1f235b846fed9c154e66fb3983664ed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238980
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Philipp Hancke <phancke@nvidia.com >
Cr-Commit-Position: refs/heads/main@{#35440}
2021-11-30 11:01:14 +00:00
6c167d8278
Remove NetEq::Create.
...
This method is no longer useful after a previous refactoring, but it was
not removed from the interface.
Bug: webrtc:13444
Change-Id: I9c4761e8503acdec06c16cc37c2a804d4913eac8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239366
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Commit-Queue: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35439}
2021-11-30 10:31:16 +00:00
0680c4871c
Roll chromium_revision 22cbef27a6..a3e750c9b0 (946167:946315)
...
Change log: 22cbef27a6..a3e750c9b022cbef27a6..a3e750c9b0f8009dc41e..e6e0ee5bae2f9e5b5867..e0d5dbffaad11bb31289..af6e3bb63e42caab826d..69383604c017c7be145e..92767b0febhttps://chromium.googlesource.com/catapult.git/+log/75423c310e..8cf0922154
* src/third_party/depot_tools: 51d99b2f3a..804165b44525c7e11129..0e7a87dbf522cbef27a6..a3e750c9b0https://webrtc-review.googlesource.com/c/src/+/239425
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35438}
2021-11-30 04:30:11 +00:00
c56645c0cd
Roll chromium_revision 0e21474081..22cbef27a6 (946029:946167)
...
Change log: 0e21474081..22cbef27a60e21474081..22cbef27a61d1c400730..f8009dc41e245517235e..2f9e5b58675bea6e0b34..d11bb31289bebfd47d77..42caab826d51f3bc37e1..17c7be145e02f4003fdb..51d99b2f3a64e26ad3a2..3b45f564e9889d9a924c..b9dad7362169300210d4..25c7e111290e21474081..22cbef27a6https://webrtc-review.googlesource.com/c/src/+/239421
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35437}
2021-11-29 22:39:01 +00:00
6dd4997950
Fix TestTurnServer to not depend on rtc::Thread::socketserver() accessor
...
Updated all calls to constructor to pass appropriate
rtc::SocketFactory explicitly.
Bug: webrtc:13145
Change-Id: Ibaa764c7eaffbdb8dd6825fd518c54b37316ecb8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238807
Auto-Submit: Niels Moller <nisse@webrtc.org >
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org >
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35436}
2021-11-29 21:10:31 +00:00
bf7532116b
Create socket server explicitly in PeerConnectionEndToEndBaseTest
...
Bug: webrtc:13145
Change-Id: I674382b3a784d371681426848461502b711dfe6a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238430
Auto-Submit: Niels Moller <nisse@webrtc.org >
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org >
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35435}
2021-11-29 20:13:01 +00:00
7d6e34ae0b
Roll chromium_revision fe555f2e69..0e21474081 (945923:946029)
...
Change log: fe555f2e69..0e21474081fe555f2e69..0e21474081c8a98d6969..1d1c400730bc9340854d..5bea6e0b346410d12020..bebfd47d7751b895633d..51f3bc37e12ffa1bde79..02f4003fdbcff026d415..64e26ad3a27c7f2ccfb1..69300210d4fe555f2e69..0e21474081https://webrtc-review.googlesource.com/c/src/+/239400
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35434}
2021-11-29 18:46:00 +00:00
9937c32371
Roll chromium_revision 1ce7d592c3..fe555f2e69 (944520:945923)
...
This CL also adds COM_DECLSPEC_NOTHROW where needed since Windows
is compiled with -std=c++17.
Change log: 1ce7d592c3..fe555f2e691ce7d592c3..fe555f2e69a0e30222a6..c8a98d6969749ecdaeea..245517235ee504863f9e..665b74f7d1038090f742..c936d73ff7d9a982f504..bc9340854d4e888a310b..6410d120207d86ceacba..51b895633dhttps://chromium.googlesource.com/catapult.git/+log/4b9301e9c5..75423c310e
* src/third_party/depot_tools: a29f589a15..2ffa1bde793cabd142ce..cff026d4153e0e32ba30..e2f397893749836d72bd..02959c3ee1ec80f88c5d..13f984c216d5cb19a57d..889d9a924c0e9c2f5abf..7c7f2ccfb11ce7d592c3..fe555f2e69https://webrtc-review.googlesource.com/c/src/+/239355
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35433}
2021-11-29 16:23:30 +00:00
6844e51f47
VideoSendStreamTest: Fix flaky UAF.
...
This test being flaky impeded the landing of
https://webrtc-review.googlesource.com/c/src/+/239126 . Fix by
ensuring the test's OnSendRtp guts don't execute past all streams
stopped.
Bug: None
Change-Id: Ie8aefb3bb03c09d2a9514acecd162e7c079c77c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239363
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Markus Handell <handellm@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35432}
2021-11-29 15:58:40 +00:00
