Commit Graph

35273 Commits

Author SHA1 Message Date
b3ec634f79 Document function arguments in NetEq bitexactness tests
Bug: b/216736217
Change-Id: Ieaf79e17970da57e84788e2f5c91220144f4c3fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249796
Commit-Queue: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35891}
2022-02-02 17:25:50 +00:00
3202e29f72 Removing MessageHandler dependency from Connection.
Bug: webrtc:11988
Change-Id: Ic35bb5baeafbda7210012dceb0d6d5f5b3eb95c9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249941
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35890}
2022-02-02 16:32:20 +00:00
4a3e56075e Switch to universal_newlines=True.
To fix the blocking issue this CL uses universal_newlines (removing the
calls to decode('utf-8')).

Tested locally.

No-Presubmit: True
Bug: webrtc:13607
Change-Id: Ib56cf87c8f903087d0c4aa09b58c464edac649c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250222
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35889}
2022-02-02 16:05:10 +00:00
6d43d3ef62 Roll chromium_revision 8ef27bd034..db72f1f3a8 (966066:966175)
Change log: 8ef27bd034..db72f1f3a8
Full diff: 8ef27bd034..db72f1f3a8

Changed dependencies
* src/base: 6eeec2d6df..3c089129b4
* src/build: 9e5113ae7a..8a33d15967
* src/buildtools/third_party/libunwind/trunk: d0ad43c5e1..659c7d91af
* src/ios: 5409894a5f..21b79ee35b
* src/testing: 6b84bbb4dc..7454f36b7b
* src/third_party: 889b20301d..3a99e3f0d8
* src/third_party/googletest/src: 4517697675..25ad42aabe
* src/third_party/perfetto: c388978ab5..098713f362
* src/tools: 255290af6d..b587cfbd64
DEPS diff: 8ef27bd034..db72f1f3a8/DEPS

No update to Clang.

BUG=None

Change-Id: I80270b16057d6f5730c36a55b0ffd8b4c1cc1983
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250078
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35888}
2022-02-02 14:46:29 +00:00
7766ab1a2e Break out local_audio_source from peerconnection target
Bug: webrtc:13634
Change-Id: I402e5334869c69b8e7436f3402b04a93f8df7135
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250201
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35887}
2022-02-02 14:18:19 +00:00
8921fb8c51 Remove dependency dav1d_av1_jni from dav1d_java.
Bug: none
Change-Id: I32b544b2c85b0230e2637046926e13b47ce6e69d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250220
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35886}
2022-02-02 13:37:00 +00:00
d5f98ce8cf Revert Popen bufsize to Python 2.7 default value.
This might be the reason causing the process to not terminate.

This CL adds also more logging.

No-Presubmit: True
Bug: webrtc:13607
Change-Id: I9fc2cf39d2c1df92670b45dd081022ce69068836
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250181
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35885}
2022-02-02 12:55:59 +00:00
1901551b00 Reduce log amount when running stats tests.
Bug: none
Change-Id: Icd914ae909f2ea1853cc58f6217933f8d320ceb6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250162
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35884}
2022-02-02 12:17:09 +00:00
c79dc98a60 Document that BasicPortAllocator requires a NetworkManager.
And add a corresponding DCHECK.

Bug: webrtc:13145
Change-Id: I748f686763fa5c7f04c64d5b0cecaf8fc122052d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250124
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35883}
2022-02-02 09:54:35 +00:00
5423c83731 Switch to Popen and adding a timeout for PESQ measurements.
After migrating to python3, the check_output doesn't return, this
CL switches to communicate() with a timeout of 2 minutes (to avoid
to block bots for 2 hours in a deadlock).

No-Presubmit: True
Bug: None
Change-Id: I3248ab090c074bd35300ca11abc08536cd797664
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250164
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35882}
2022-02-02 09:46:19 +00:00
595f688b56 Delete legacy rtc::Thread PostTask APIs.
rtc::Thread already contains PostTask/PostDelayedTask methods that are
inherited from webrtc::TaskQueueBase which are named the same thing and
do the same thing.

Bug: webrtc:13582
Change-Id: I23d897a0079496d89564a51cbb26d214b70e132a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/248168
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35881}
2022-02-02 08:32:31 +00:00
2f122e4fe6 Break out sdp_serializer target
Bug: webrtc:13634
Change-Id: I6bf28cb8b37257800c7944b870f9d2cb83273dfb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250161
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35880}
2022-02-02 08:15:08 +00:00
cf5e4354d7 Roll chromium_revision f8504113e8..8ef27bd034 (965957:966066)
Change log: f8504113e8..8ef27bd034
Full diff: f8504113e8..8ef27bd034

Changed dependencies
* src/base: d31ddf65f0..6eeec2d6df
* src/build: 38f66e145c..9e5113ae7a
* src/ios: e97eaf2676..5409894a5f
* src/testing: 4b8c3d3074..6b84bbb4dc
* src/third_party: 05d0f82e51..889b20301d
* src/third_party/depot_tools: 6b0bdb33f9..60206c4007
* src/third_party/perfetto: 7536b8724b..c388978ab5
* src/tools: cac6570a59..255290af6d
DEPS diff: f8504113e8..8ef27bd034/DEPS

No update to Clang.

BUG=None

Change-Id: I4d9e44a225f09eb98d8758240d0911c736e3cb10
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250074
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35879}
2022-02-02 06:23:48 +00:00
ffcf7381e8 Update WebRTC code version (2022-02-02T04:05:11).
Bug: None
Change-Id: If878cc9bff66d54ad49fb5cb307d1c635cb6f7a4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250073
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35878}
2022-02-02 05:42:58 +00:00
608e381b4d Roll chromium_revision 8ac8674989..f8504113e8 (965824:965957)
Change log: 8ac8674989..f8504113e8
Full diff: 8ac8674989..f8504113e8

Changed dependencies
* src/base: 96bdfb7364..d31ddf65f0
* src/build: 39bf9ee0bf..38f66e145c
* src/ios: 2296513de9..e97eaf2676
* src/testing: 24de5fcb28..4b8c3d3074
* src/third_party: 2afaec3c56..05d0f82e51
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1c33cd6890..1e084a5277
* src/third_party/depot_tools: 8a6d00f116..6b0bdb33f9
* src/third_party/perfetto: 9839aeef62..7536b8724b
* src/tools: 712235f945..cac6570a59
DEPS diff: 8ac8674989..f8504113e8/DEPS

No update to Clang.

BUG=None

Change-Id: Ia78f057d9bc05b6c03f0f5cfeb36e92c6ad94ee3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250070
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35877}
2022-02-02 00:39:08 +00:00
a34eb03874 fix onicecandidateerror description
STUN servers don't do allocate requests, just binding requests.
Fix the description of onicecandidateerror accordingly.

BUG=None

Change-Id: I5698f23b50de46eb76175d1af5e88b605cd152f0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250142
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/main@{#35876}
2022-02-01 21:24:48 +00:00
e4804bdfc1 Roll chromium_revision d9ea320a3d..8ac8674989 (965706:965824)
Change log: d9ea320a3d..8ac8674989
Full diff: d9ea320a3d..8ac8674989

Changed dependencies
* src/base: 6f26a8783f..96bdfb7364
* src/build: 5093014eb2..39bf9ee0bf
* src/ios: 3478824c9e..2296513de9
* src/testing: a9e0ab6c95..24de5fcb28
* src/third_party: e09847d443..2afaec3c56
* src/third_party/perfetto: 00b152a26e..9839aeef62
* src/tools: 7ce390312a..712235f945
DEPS diff: d9ea320a3d..8ac8674989/DEPS

No update to Clang.

BUG=None

Change-Id: I5f2a542919c834fc13b42631b63bd104b096da3e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250068
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35875}
2022-02-01 20:44:10 +00:00
1f06508350 Update av1 video codec test threshold.
Bug: webrtc:13638
Change-Id: If17ae2519451953ac3e6054cb6cdc376594fe3d8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250040
Reviewed-by: Marco Paniconi <marpan@webrtc.org>
Reviewed-by: Fyodor Kyslov <kyslov@google.com>
Commit-Queue: Bohan Li <bohanli@google.com>
Cr-Commit-Position: refs/heads/main@{#35874}
2022-02-01 20:43:08 +00:00
c6206658e4 Add timestamp to logs.
No-Presubmit: True
Bug: None
Change-Id: I3adc0ba9f0c92c10d35833aca2698eead40a849d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250160
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35873}
2022-02-01 18:19:08 +00:00
61dbc2db2b Remove definition of WEBRTC_MOZILLA_BUILD.
This macro is not used in WebRTC code.

Bug: None
Change-Id: I5af1299594e8644ce2a9c772e29507367fd7440d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250140
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35872}
2022-02-01 16:53:48 +00:00
e39a16fa7c Roll chromium_revision 2da73dff1a..d9ea320a3d (965567:965706)
Change log: 2da73dff1a..d9ea320a3d
Full diff: 2da73dff1a..d9ea320a3d

Changed dependencies
* src/base: 22e8efc6e8..6f26a8783f
* src/build: 6b20164497..5093014eb2
* src/buildtools/third_party/libc++abi/trunk: df43e1b039..5b0a8cf88e
* src/ios: ae0c81e45a..3478824c9e
* src/testing: b17e15aa1a..a9e0ab6c95
* src/third_party: af4ad38443..e09847d443
* src/third_party/depot_tools: 98cf932814..8a6d00f116
* src/tools: 9400dbb63a..7ce390312a
DEPS diff: 2da73dff1a..d9ea320a3d/DEPS

No update to Clang.

BUG=None

Change-Id: I98977ce55c9b64e3bd297f6b0b9750be0333b6dc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250067
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35871}
2022-02-01 16:43:59 +00:00
ae940a5429 Break out ice_server_parsing from peerconnection target
Drive-by: Add empty dummy targets for all the things left in
the peerconnection target. They should all move out.

Bug: webrtc:13634
Change-Id: I93b193804668decf5feee2a8847403466330e128
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250123
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35870}
2022-02-01 15:18:16 +00:00
ce40931670 Fix metronome typo in PeerConnectionDependencies
R=hbos@webrtc.org

Bug: webrtc:13560
Change-Id: I8c3ce87f37cf4daec4e6eaafb71ee4219c103fd9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250121
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35869}
2022-02-01 14:11:18 +00:00
fe968dff86 pc: Disable flaky unit test on Android
The DataChannelIntegrationTest.SomeQueuedPacketsGetDroppedInMaxRetransmitsMode
test is flaky on Android.

Bug: None
Change-Id: Ia72081905368e405441d5518b53d03e60fac233b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250120
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35868}
2022-02-01 10:57:48 +00:00
13b62c28de Break out media_stream_observer.cc in peerconnection build
Bug: webrtc:13634
Change-Id: Ie1368217bc3735b0a747c39dbbb5afbc929c4cf3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250080
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35867}
2022-02-01 09:27:47 +00:00
1e157a9596 Remove more top-level const from parameters in function declarations
This CL removes even more top-level const from parameters in function
declarations. This change is safe because top-level const in function
declarations (not function definitions) are ignored by the compiler
and so change is just a no-op cleanup.

Bug: webrtc:13610
Change-Id: Icf6868c27b1fdb9d9915b3a7020eb34bdcf07a09
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249989
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35866}
2022-02-01 09:15:50 +00:00
b6653d9967 [python3] - Fix low_bandwidth_audio_test.py (take 3)
No-Presubmit: True
Bug: webrtc:13607
Change-Id: Iff325ad10138fe8b7e1df1fa169652f5795fa718
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250081
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35865}
2022-02-01 09:11:17 +00:00
99cb34271b Roll chromium_revision 955c4f2965..2da73dff1a (965267:965567)
Change log: 955c4f2965..2da73dff1a
Full diff: 955c4f2965..2da73dff1a

Changed dependencies
* src/base: 64fab10040..22e8efc6e8
* src/build: 472cc54e2b..6b20164497
* src/ios: 73464e2fc6..ae0c81e45a
* src/testing: e2ab60013b..b17e15aa1a
* src/third_party: 1eca7f51cc..af4ad38443
* src/third_party/androidx: Qo3oi32JKnLwAeBGQyVax5FEUu97M2omI6yz5qDiMCwC..3RcBXDFZuIJBL1I-gTWwvfRXm6fCwxFkV3tY3ZodF1YC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9a1137f8ee..1c33cd6890
* src/third_party/depot_tools: 8dd74d4f85..98cf932814
* src/third_party/freetype/src: fa226478b1..946e1353ea
* src/third_party/googletest/src: 28e1da21d8..4517697675
* src/third_party/perfetto: 045b467faf..00b152a26e
* src/tools: 8a3c99aebf..9400dbb63a
* src/tools/luci-go: git_revision:9c88febc5ab63469baf5aae05a74f8e419970ef3..git_revision:d46a9c7ad4e38935bbacb01602fc1d09a162884b
* src/tools/luci-go: git_revision:9c88febc5ab63469baf5aae05a74f8e419970ef3..git_revision:d46a9c7ad4e38935bbacb01602fc1d09a162884b
DEPS diff: 955c4f2965..2da73dff1a/DEPS

No update to Clang.

BUG=None

Change-Id: Ib52e3213924be6c3723ad6ad3d360ffccfd09fbe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250063
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35864}
2022-02-01 09:07:57 +00:00
6fba6b795a Reland "(Un/)Subscribe RtpVideoSender for feedback on the transport queue."
This is a reland of 9d230d54c7eef31ac1100f0aeef1374dd1ac62fa

Original change's description:
> (Un/)Subscribe RtpVideoSender for feedback on the transport queue.
>
> * RtpVideoSender now registers/unregisters for feedback callback
>   inside of SetActive(), which runs on the transport queue.
> * Transport feedback is given on the transport queue
> * Registration/unregistration for feedback is done on the same
> * Removed the last mutex from TransportFeedbackDemuxer.
>
> Ultimately, this work is related to moving state from the Call
> class, that's related to network configuration, but due to the code
> is currently written is attached to the worker thread, over to the
> Transport, where it's used (e.g. suspended_video_send_ssrcs_).
>
> Bug: webrtc:13517, webrtc:11993
> Change-Id: I057d0e2597e6cb746b335e0308599cd547350e56
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/248165
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#35777}

Bug: webrtc:13517, webrtc:11993
Change-Id: I766e569abea8bae96d32267a951fcdc195ced8a7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249782
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35863}
2022-02-01 06:45:17 +00:00
2195d54a5c Report an error if applying the demuxer criteria fails.
This is a follow-up to CL [1] to restore the check of whether updating
the demuxer criteria in the channel classes succeeded or failed.

[1] https://webrtc-review.googlesource.com/c/src/+/244700

Bug: webrtc:13536
Change-Id: If0e986bd4e4799e20be2b49f80abcc5a3e6825fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249940
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@google.com>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35862}
2022-02-01 06:43:58 +00:00
45a021773d Update WebRTC code version (2022-02-01T04:04:26).
Bug: None
Change-Id: I92b1164195f9e2df5724e5fec6e7170be5d18657
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250042
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35861}
2022-02-01 06:03:21 +00:00
e804e60be0 Roll chromium_revision 1062ad0828..955c4f2965 (965113:965267)
Change log: 1062ad0828..955c4f2965
Full diff: 1062ad0828..955c4f2965

Changed dependencies
* src/base: ed339713e9..64fab10040
* src/build: 520772230c..472cc54e2b
* src/ios: eb0f125ab4..73464e2fc6
* src/testing: 91b483090a..e2ab60013b
* src/third_party: 56520be402..1eca7f51cc
* src/third_party/androidx: QtHHFfyxt8FUIvIRafOQoXQ1hsclhSpNaaZ6ZHNqhx4C..Qo3oi32JKnLwAeBGQyVax5FEUu97M2omI6yz5qDiMCwC
* src/third_party/perfetto: ef9994d1a2..045b467faf
* src/third_party/turbine: RkSl7-UvBXltU55m5zi387oPTAJqTj3Oz6nIpQkOI4wC..g7lRRNWdEQAksTvScmHd-o0PUx4ts7kioIdeDtQ-ifMC
* src/tools: d40231a6f5..8a3c99aebf
DEPS diff: 1062ad0828..955c4f2965/DEPS

No update to Clang.

BUG=None

Change-Id: If70533eb28cedc8017733824591fa83456d9922a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250035
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35860}
2022-01-31 18:45:27 +00:00
4be7fbb81e Change frequently run log statements in RtcEventLog to DLOG.
This substantially reduces the amount of text logged in release
builds when running:

rtc_unittests.exe --gtest_filter=*RtcEventLog*

Bug: none
Change-Id: I7b7c7e66fa467924e4414f1d9bfc1590ff01e0c0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249981
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35859}
2022-01-31 16:42:27 +00:00
af2930a698 Avoid dangling pointers in a few Connection related classes.
Bug: webrtc:11988
Change-Id: I2db1281983396366b91666a1c2bbbcae434ed625
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249949
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35858}
2022-01-31 14:31:38 +00:00
f1053ba862 Revert "Revert "Update NetEq bitexactness tests to only run on Linux.""
This reverts commit 2d218323c84fe72341013eaf0dc24edad99ab152.

Update checksums to pass without SSE support.

Bug: webrtc:12518, b/216736217
Change-Id: I22791bfb000ad250b716f5a1a4b8b67ace8cc7d7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249988
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Commit-Queue: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35857}
2022-01-31 14:25:37 +00:00
93dd763360 Remove deprecated RemoveTrack interface
Bug: webrtc:9534
Change-Id: I970e6fd43284d9159897d5214fff9992cd26e171
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247371
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35856}
2022-01-31 14:08:57 +00:00
f564bfe82d Fix potentially dangling pointers in several Connection related tests.
Bug: webrtc:11988
Change-Id: Iba3f41ba4be8c911d6bdc5241f736831c5a74d0f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249983
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35855}
2022-01-31 14:04:47 +00:00
0bd9905dc4 [python3] - Fix low_bandwidth_audio_test.py (take 2)
No-Presubmit: True
Bug: webrtc:13607
Change-Id: I2cab05888d52e8964fddce233ad2903d540125fb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249991
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35854}
2022-01-31 13:25:08 +00:00
a7ecf110ac Add Metronome to PC dependencies
This will enable Chrome to inject its metronome for use in WebRTC for
tasks like synchronized decoding.

Bug: webrtc:13560, chromium:1253787
Change-Id: I2488d746f57152a32d3adf92a3cdfdfdb8000c06
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249381
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35853}
2022-01-31 13:11:17 +00:00
48e1b2950b Add dummy targets for candidate breakouts
Bug: webrtc:13634
Change-Id: I954e1f5b953805b55a5931a806ac71d9275be30a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249947
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35852}
2022-01-31 12:51:08 +00:00
b732bd5fb5 Add timestamps to AudioDeviceBuffer::SetRecordedBuffer
Add timestamps to the function AudioDeviceBuffer::SetRecordedBuffer. This will
be used to store audio timestaps in future changes.

This is a part of the A/V sync metric metric feature for mobile. The metric
have already launched for web clients.

Bug: webrtc:13609
Change-Id: I0031843476ff1b573b262308fca52d587fae30b7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249085
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Minyue Li <minyue@google.com>
Commit-Queue: Olov Brändström <brandstrom@google.com>
Cr-Commit-Position: refs/heads/main@{#35851}
2022-01-31 12:32:58 +00:00
9897649336 Thread checks for the Connection class.
Following [1], add many more checks for safe access to member variables.
This change is effectively a no-op, but landed separately from the
earlier change that's smaller but contains a fundamental assumption
gleaned from the implementation (and its use).

[1]: https://webrtc-review.googlesource.com/c/src/+/249942

Bug: webrtc:11988
Change-Id: I1568e2160c9faa6993c5b68044312f83d00e4815
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249943
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35850}
2022-01-31 12:11:37 +00:00
a8b63626ca Fix race when checking for field trial from the encoder queue.
Bug: webrtc:13633
Change-Id: I9eed5b849ad8b9d739261a119b8bffb3033951be
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249948
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35849}
2022-01-31 11:57:59 +00:00
dda828f707 Field trials for DSCP
Add a field trial "WebRTC-DscpFieldTrial"
that allows user to set any int value to be
used as tagging. This tag value will be used
for all packets on the PeerConnection,
whether they are audio, video, data or ICE

e.g WebRTC-DscpFieldTrial/override_dscp:40/

see https://webrtc.googlesource.com/src/+/b477fc73cfd2f4c09bb9c416b170ba4b566cecaf/rtc_base/dscp.h
for names of popular ints.

Bug: webrtc:13622
Change-Id: Iedbedd0f918100259678eb5bc083c9bf89b343b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249786
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35848}
2022-01-31 11:51:31 +00:00
9a99905301 Implement FrameBuffer3Proxy
This emulates behaviour from frame buffer 2, but does not handle stats.
In contrast to frame buffer 2, all work happens on the same task queue.
FrameBuffer3Proxy encapsulates FrameBuffer3 and scheduler behind
a field trial WebRTC-FrameBuffer3.

This separates frame scheduling behaviour into a few components,

VideoReceiveStreamTimeoutTracker
* Handles the stream timeouts.

FrameDecodeScheduler
* Manages the scheduling and cancelling of frames being sent to the
  decoder.

FrameDecodeTiming
* Handles the timing and ordering of frames to be decoded.

Other changes
* Adds CurrentSize() method to FrameBuffer3
* Move timing to a separate library
* Does a thread check for Receive statistics as this is now
on the worker thread.
* Adds `FlushImmediate` method to RunLoop so that
  video_receive_stream2_unittest can pass when scheduling is happening
  on the worker thread.

Change-Id: Ia8d2e5650d1708cdc1be3631a5214134583a0721
Bug: webrtc:13343
Tested: Ran webrtc_perf_tests, video_engine_tests, rtc_unittests forcing frame buffer3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/241603
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Markus Handell <handellm@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35847}
2022-01-31 11:40:27 +00:00
538b76a2f1 Roll chromium_revision 7888dedb89..1062ad0828 (964667:965113)
Change log: 7888dedb89..1062ad0828
Full diff: 7888dedb89..1062ad0828

Changed dependencies
* src/base: 4f9bff8b64..ed339713e9
* src/build: 94dad5d328..520772230c
* src/buildtools/third_party/libunwind/trunk: 7246413309..d0ad43c5e1
* src/ios: 4f460b99a3..eb0f125ab4
* src/testing: 8f2957ec76..91b483090a
* src/third_party: 5d325ba5c6..56520be402
* src/third_party/android_deps/libs/com_android_tools_common: version:2@30.0.0-alpha10.cr0..version:2@30.2.0-beta01.cr0
* src/third_party/android_deps/libs/com_android_tools_layoutlib_layoutlib_api: version:2@30.0.0-alpha10.cr0..version:2@30.2.0-beta01.cr0
* src/third_party/android_deps/libs/com_android_tools_sdk_common: version:2@30.0.0-alpha10.cr0..version:2@30.2.0-beta01.cr0
* src/third_party/android_deps/libs/com_google_protobuf_protobuf_javalite: version:2@3.13.0.cr0..version:2@3.19.3.cr0
* src/third_party/androidx: Q3FdPqSF5ZexcTQDGcEKnJ2SK0DiLOtp5o-8uIGd3kYC..QtHHFfyxt8FUIvIRafOQoXQ1hsclhSpNaaZ6ZHNqhx4C
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/387f82054c..123eaaef26
* src/third_party/breakpad/breakpad: 92a20b6504..08bd844599
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d90eeee993..9a1137f8ee
* src/third_party/depot_tools: 0dc69c4e79..8dd74d4f85
* src/third_party/googletest/src: 0b7798b2fb..28e1da21d8
* src/third_party/perfetto: 17ec90c1ec..ef9994d1a2
* src/tools: cb1ac0040b..d40231a6f5
DEPS diff: 7888dedb89..1062ad0828/DEPS

No update to Clang.

BUG=None

Change-Id: I808dabf78acef1982da730cd3ee78069bba0d203
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250030
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35846}
2022-01-31 11:19:07 +00:00
0d4af12cab Add back --no_fwd_decls to iwyu run
Applies IWYU to pc/peer_connection.cc as test.

Bug: webrtc:13532
Change-Id: Iec453fdf6525c6376cb73dd1199326a8e1a21ff6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249986
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35845}
2022-01-31 10:26:17 +00:00
582646342e Add metronome interface
Change-Id: Iea2f8ddb21a5d5a6880912f63a81cd4be408bb09
Bug: webrtc:13560, chromium:1253787
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249380
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35844}
2022-01-31 10:22:19 +00:00
e3bf4a67c9 Revert "Break out targets from pc/peerconnection build target."
This reverts commit c9664435944268cd5753eb238bfe9494dd2eec8b.

Reason for revert: Breaks upstream project

Original change's description:
> Break out targets from pc/peerconnection build target.
>
> This is part of a project to make sdp_offer_answer be a separate
> compile target from peerconnection.
> This CL affects sctp_data_channel and data_channel_utils.
>
> Bug: webrtc:11995
> Change-Id: I98244413b7cffdd0c70c56221f0692c2949e0549
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249799
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#35840}

TBR=mbonadei@webrtc.org,hta@webrtc.org,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: If2a898f6e573ce347b9858fe8bf29a5a2211bff0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11995
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249946
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35843}
2022-01-31 09:56:28 +00:00
cb01e5ecb2 Add checks for Connection construction/destruction.
Make sure that instances are always created+deleted on the
network thread.

Bug: webrtc:11988
Change-Id: I4fb5dd5bd14768d89ca78b348988a797fcdd130a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249942
Reviewed-by: Niels Moller <nisse@webrtc.org>
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35842}
2022-01-31 09:36:07 +00:00