af476c737f
RTC_[D]CHECK_op: Remove "u" suffix on integer constants
...
There's no longer any need to make the two arguments have the same
signedness, so we can drop the "u" suffix on literal integer
arguments.
NOPRESUBMIT=true
BUG=webrtc:6645
Review-Url: https://codereview.webrtc.org/2535593002
Cr-Commit-Position: refs/heads/master@{#15280}
2016-11-28 23:21:51 +00:00
2cb73413f4
Moved sequence number specific operations from mod_ops.h
...
to sequence_number_util.h
Also in this CL:
- Implemented a MinDiff function which finds the smallest diff of two
wrapping numbers.
- Implemented comparators for sequence numbers.
BUG=
R=mflodman@webrtc.org , tommi@webrtc.org , torbjorng@webrtc.org
Review URL: https://codereview.webrtc.org/1814753002 .
Cr-Commit-Position: refs/heads/master@{#12083}
2016-03-22 09:03:55 +00:00
7b4c9db28a
DCHECK fix for https://codereview.webrtc.org/1769113003/
...
TBR=stefan@webrtc.org
BUG=webrtc:5514
Review URL: https://codereview.webrtc.org/1770373002 .
Cr-Commit-Position: refs/heads/master@{#11905}
2016-03-08 12:06:55 +00:00
5ab4c6d7e0
Revert "Revert of Implement the NackModule as part of the new jitter buffer. (patchset #19 id:360001 of https://codereview.webrtc.org/1715673002/ )"
...
This reverts commit eb648bf0e5a9bae185bcd6b4b3be371e1da3507d.
Re-reverting to fix original CL (https://codereview.webrtc.org/1715673002/ ).
TBR=stefan@webrtc.org , tommi@webrtc.org , torbjorng@webrtc.org
BUG=webrtc:5514
Review URL: https://codereview.webrtc.org/1769113003
Cr-Commit-Position: refs/heads/master@{#11904}
2016-03-08 11:36:22 +00:00
eb648bf0e5
Revert of Implement the NackModule as part of the new jitter buffer. (patchset #19 id:360001 of https://codereview.webrtc.org/1715673002/ )
...
Reason for revert:
Unfortunately this breaks in the main waterfall: https://build.chromium.org/p/client.webrtc/builders/Android32%20Builder/builds/6362
I think it's related to dcheck_always_on=1 which is set in GYP_DEFINES only on the trybots, but not on the bots in the main waterfall.
Original issue's description:
> Implement the NackModule as part of the new jitter buffer.
>
> Things done/implemented in this CL:
> - An interface that can send Nack (VCMNackSender).
> - An interface that can request KeyFrames (VCMKeyFrameRequestSender).
> - The nack module (NackModule).
> - A set of convenience functions for modular numbers (mod_ops.h).
>
> BUG=webrtc:5514
>
> Committed: https://crrev.com/f472c5b6722dfb221f929fc4d3a2b4ca54647701
> Cr-Commit-Position: refs/heads/master@{#11882}
TBR=sprang@webrtc.org ,stefan@webrtc.org ,terelius@webrtc.org ,torbjorng@webrtc.org ,perkj@webrtc.org ,tommi@webrtc.org ,philipel@webrtc.org
BUG=webrtc:5514
NOTRY=True
Review URL: https://codereview.webrtc.org/1771883002
Cr-Commit-Position: refs/heads/master@{#11887}
2016-03-07 17:56:34 +00:00
f472c5b672
Implement the NackModule as part of the new jitter buffer.
...
Things done/implemented in this CL:
- An interface that can send Nack (VCMNackSender).
- An interface that can request KeyFrames (VCMKeyFrameRequestSender).
- The nack module (NackModule).
- A set of convenience functions for modular numbers (mod_ops.h).
BUG=webrtc:5514
Review URL: https://codereview.webrtc.org/1715673002
Cr-Commit-Position: refs/heads/master@{#11882}
2016-03-05 11:56:45 +00:00
