Commit Graph

1373 Commits

Author SHA1 Message Date
6342066974 Fix tsan failures in channel.cc regarding to the volume settings.
BUG=2461
TEST=try bots
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2377004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4992 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-17 18:28:55 +00:00
675e260ad1 Check the number of playout channels instead of the send channels in StopPlayout()
BUG=2467
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2420004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4989 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-17 16:15:34 +00:00
c11148b352 Compound/reduced-size RTCP in VideoReceiveStream.
BUG=2424
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2413004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4987 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-17 14:14:42 +00:00
d030972139 Remove unused kPowTableFrac which causes anroid clang build failure.
http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/84322/steps/compile/logs/stdio

R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2417004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4981 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 20:32:09 +00:00
25fce9adc5 Fixed issue with how MTU is calculated.
BUG=
R=holmer@google.com, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2410004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4976 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 13:29:14 +00:00
b400aa7cd4 Don't pad if only one stream is sent, except if auto muted.
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2406004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4975 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 13:03:10 +00:00
e7009f3b0d Revert "Disable tests for TSan v2"
This reverts r4787 since r4966 got us a newer Clang
version with these issues fixed.

BUG=2259,2334
TEST=test_support_unittests and system_wrappers_unittests passed execution under TSan v2 for 100 iterations:
GYP_DEFINES='tsan=1 linux_use_tcmalloc=0 release_extra_cflags="-gline-tables-only"' gclient runhooks
ninja -C out/Release test_support_unittests system_wrappers_unittests

TSAN_OPTIONS="suppressions=tools/valgrind-webrtc/tsan_v2/suppressions.txt print_suppressions=1 report_signal_unsafe=0 report_thread_leaks=0 history_size=7" out/Release/system_wrappers_unittests --gtest_repeat=100 --gtest_break_on_failure

TSAN_OPTIONS="suppressions=tools/valgrind-webrtc/tsan_v2/suppressions.txt print_suppressions=1 report_signal_unsafe=0 report_thread_leaks=0 history_size=7" out/Release/test_support_unittests --gtest_repeat=100 --gtest_break_on_failure
R=hta@webrtc.org, perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2407004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4974 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 12:26:48 +00:00
5d957e29f7 Wired up max packet size and added simple test.
BUG=2428
R=mflodman@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2384004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4973 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 11:37:54 +00:00
9401524211 Run FullStack tests without render windows.
Also disables test on valgrind platforms, it has no chance to keep up.

BUG=2278
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2159008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4972 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 11:05:37 +00:00
5ed4f46af1 Remove TSan v2 disabled test in condition_variable_unittest.cc
When we rolled our chromium_revision 226126:228675 in r4966
we picked up Clang r191856, which fixes the problem we've
seen earlier in condition_variable_unittest.cc.
Because of this, I'm now re-enabling this test.

TEST=trybots passing
BUG=2259
R=hta@webrtc.org, perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2404004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4971 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 10:50:41 +00:00
b44c2a3193 Open file in binary in CreateFromYuvFile().
BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2399005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4969 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 08:46:06 +00:00
e6e749da38 Add MouseCursorRenderer.
The new class acts as a wrapper for DesktopCapturer interface. It takes
mouse shape and position from MouseCursorCapturer and renders it on the
frames produced by underlying DesktopCapturer.

BUG=crbug.com/173265
R=wez@chromium.org
TBR=andrew@webrtc.org (modules.gyp)

Review URL: https://webrtc-codereview.appspot.com/2387004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4968 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 02:48:41 +00:00
2767b53f66 Add MouseCursorCapturer interface with implementation for X11.
The new interface will be used to capture cursor shape and position and
blend it into the image captured with desktop capturers.

BUG=crbug.com/173265
R=wez@chromium.org
TBR=andrew@webrtc.org (modules.gyp)

Review URL: https://webrtc-codereview.appspot.com/2386005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4967 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-16 02:42:38 +00:00
3555303cb0 Roll chromium_revision 226126:228675 and fix clang warnings
By request from thakis@chromium.org, I disabled the
-Wno-unused-const-variable setting that is set in Chromium's
common.gypi so we can prepare our code for it's removal.

This required some cleanup in order to get the code to compile
with Clang having the -Wunused-const-variable warning enabled.

TEST=all trybots passing
BUG=none
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2400004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4966 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-15 20:10:17 +00:00
e5021fe590 Make RtpData and RtpFeedback destructors public.
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2399004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4965 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-15 10:38:40 +00:00
266c7b330a Move ChromaGenerator to common_video/.
BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2394004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4964 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-15 09:15:47 +00:00
c2e471d8b3 Compile out unused kMinTrustedDelayMs.
TBR=niklas.enbom@webrtc.org
TESTED=trybots

Review URL: https://webrtc-codereview.appspot.com/2398004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4963 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-15 02:11:21 +00:00
901ae77618 Android: Fixes WebRTCDemo build (missing Java code).
TBR=ajm@webrtc.org

BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/2395005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4961 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-14 21:46:53 +00:00
1871dd2fb7 NetEq4: Removing templatization for AudioVector
This is the last CL for removing templates in Audio(Multi)Vector.

BUG=1363
R=turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2341004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4960 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-14 20:33:25 +00:00
30792987b8 Remove empty line in SharedXDisplay::RemoveEventHandler.
TBR=wez@chromium.org

Review URL: https://webrtc-codereview.appspot.com/2397004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4958 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-14 17:58:46 +00:00
05773e5a70 Android OpenSlDemo: remove some usages of deprecated APIs that is breaking the bots.
TBR=fischman@webrtc.org

BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/2395004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4956 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-14 16:25:11 +00:00
7419a72383 Add event handling in SharedXDisplay.
SharedXDisplay has to handle X events because the events may belong to
different clients of that class.

R=wez@chromium.org

Review URL: https://webrtc-codereview.appspot.com/2386004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4953 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-13 00:44:09 +00:00
894e6fe9ea Add DesktopCaptureOptions class.
The new class is used to pass configuration parameters to screen/window
capturers. It also allows to share X Window connection between multiple
objects.

R=wez@chromium.org

Review URL: https://webrtc-codereview.appspot.com/2374004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4952 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-12 22:40:05 +00:00
f53622d42e WebRTCDemo: Fixes warning for devices with pre-17 API level. Also fixes broken build build.xml and project.properties.
BUG=2083
R=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2375004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4951 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-11 21:28:26 +00:00
5b3b6b1784 Reorganize GYP targets to make webrtc.gyp more usable.
When WebRTC is built as a part of Chromium, some of
the stuff in webrtc.gyp will not be found. This CL
fixes this.

TEST=trybots passing. I also did some manual builds for Android with the android_builder_webrtc target in build/all_android.gyp of a Chromium checkout.
BUG=chromium:304143
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2353004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4949 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-10 08:48:16 +00:00
13b2d46593 clang-format audio_processing/aec/*
TBR=bjornv
TESTED=trybots

Review URL: https://webrtc-codereview.appspot.com/2373004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4944 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-08 23:41:42 +00:00
ca764ab22d Add a parameter to audioproc for overriding the delay.
Rename the parameter for adding to the input delay to "add_delay".

R=bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2345007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4939 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-07 16:44:32 +00:00
11e9cbc399 Updated WebRTC version to 3.44
TBR=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2365004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4937 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-07 16:18:35 +00:00
f5d7c5891c Revert r4934 "Add a tool for parsing an RTP file and outputting the BWE relevant fields."
Revert r4935 "Fix build error in r4934."

TBR=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2364004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4936 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-07 08:42:46 +00:00
611e5141cb Fix build error in r4934.
TBR=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2363004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4935 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-07 08:35:36 +00:00
bc99bcfa6f Add a tool for parsing an RTP file and outputting the BWE relevant fields.
R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2237005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4934 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-07 08:21:24 +00:00
6d5d248075 Wrap ACM2 code inside acm2 namespace. This gurantees that one ACM would not use components of others by accident.
BUG=
R=minyue@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2344004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4933 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-06 04:47:28 +00:00
f31639612d Accounting for wrap-around of timestamps.
BUG=
R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2340006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4932 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-06 02:21:24 +00:00
35e4dd3067 VPM: Fixing namespace
R=marpan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2355004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4930 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-04 20:21:30 +00:00
4598380860 Android: enable camera video stabilization when available.
R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2347005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4929 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-04 20:14:19 +00:00
7fca2ce097 Add owners to [webrtc,talk]/build and *.isolate (take 2)
After fischman@'s comments in http://review.webrtc.org/2347006/ here's another CL to clean up the redundancies and add wu@ to webrtc/build/

TEST=none
BUG=none
R=andrew@webrtc.org, fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2348006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4928 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-04 19:36:45 +00:00
495f29ef94 Remove unused Android dummy APK
This is a leftover from our initial Android efforts.
It is not used anywhere and is only confusing to keep around.

The Android precompiled tools in http://review.webrtc.org/2353004/
still have some use when testing Android devices on Mac, so we'll
keep them around by request from henrike@

TEST=none
BUG=none
R=andrew@webrtc.org, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2344008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4927 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-04 19:33:48 +00:00
3f9288f987 Add APK and isolate target for video_engine_tests
Add .isolate file and _run target for video_engine_tests.

Move tools/swarm_client to be untracked in all .isolate file,
so refactorings in swarm_client doesn't require us updating
all our .isolate files (similar to the changes for the
Chromium tests done in:
https://src.chromium.org/viewvc/chrome?view=rev&revision=218844)

Update modules_unittests.isolate with new NetEq4 reference files
needed.

TEST=trybots passing
I also setup a Chromium workspace where I patched third_party/webrtc
with the changes in this CL, followed by compiling with the settings
described in
https://code.google.com/p/webrtc/issues/detail?id=1882#c11
I then verified that the video_engine_tests_apk dir was created
in the output folder.
BUG=1916,2462
R=andrew@webrtc.org, henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2344007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4925 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-04 18:20:38 +00:00
6c264cc92e Clean up AudioProcessing defaults and errors.
- Remove unneeded #defines and switch the remainder to consts.
- All AudioProcessing components are disabled by default, so remove
explicit disables.
- AudioProcessing uses a rational 16 kHz mono default, so no need to
explictly initialize.
- Add assert(false) to real-time errors which should not occur.

TESTED=trybots
R=bjornv@webrtc.org, xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2253005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4924 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-04 17:54:09 +00:00
83b9e5b328 Add owners to [webrtc,talk]/build and *.isolate
BUG=none
R=andrew@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2347006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4923 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-04 17:35:26 +00:00
acb00505b6 Only declare kDelayDiffOffset when used.
And remove the redundant Windows block.

R=hans@chromium.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2351004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4922 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-04 16:59:17 +00:00
ad2eb6f67d Unbreaks Android build after r4915.
TBR=ajm@webrtc.org

BUG=Not filed

Review URL: https://webrtc-codereview.appspot.com/2348005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4921 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-04 14:21:23 +00:00
be9c560aab Revert r4913 that reverts r4911. Original CL description:
"Adding temporal layer strategy that keeps base layer framerate at an acceptable value."

R=holmer@google.com, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2351006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4920 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-04 13:11:31 +00:00
6c82e04cee Android standalone: remove some usages of deprecated APIs and prevent further regressions.
Also:
- Fixed WebRTCDemo UI to say "SwitchToBack" at startup since default camera is front
- Rebuild WebRTCDemo APK when resources/layout/strings change

R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2337004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4916 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-03 18:57:48 +00:00
4e65e07e41 VideoCaptureAndroid: rewrote the (standalone) implementation of video capture on Android.
Besides being ~40% the size of the previous implementation, this makes it so
that VideoCaptureAndroid can stop and restart capture, which is necessary to
support onPause/onResume reasonably on Android.

BUG=1407
R=henrike@webrtc.org, wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2334004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4915 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-03 18:23:13 +00:00
44db9d1a57 Revert 4911 "Adding temporal layer strategy that keeps base laye..."
> Adding temporal layer strategy that keeps base layer framerate at an acceptable value.
> 
> R=stefan@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/2272005

TBR=andresp@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2349004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4913 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-03 17:42:07 +00:00
b43d8078a1 Reformatting VPM: First step - No functional changes.
R=marpan@google.com, marpan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2333004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4912 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-03 16:42:41 +00:00
26f78f7ecb Adding temporal layer strategy that keeps base layer framerate at an acceptable value.
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2272005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4911 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-03 14:06:14 +00:00
70df305760 Minor fix to avoid breakage
Related to AutoMute feature. Fixed a lint nit, too.

TBR=mflodman@webrtc.org
BUG=2436

Review URL: https://webrtc-codereview.appspot.com/2347004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4910 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-03 13:38:59 +00:00
7ee3efb0d8 Disable Receiver unittests on Android.
BUG=
TBR=minyue@google.com

Review URL: https://webrtc-codereview.appspot.com/2344005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4909 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-03 00:05:15 +00:00