b6b678d0f8
Revert "Filter out NaNs before uploading to the dasboard"
...
This reverts commit 9db3ab201ec73d5bbc547ebe2701b4695d1e281f.
Reason for revert: We shouldn't delete numbers from "running", since they represent count, mean, max, min, sum, variance and meanlogs. Just removing will lead to undefined behaviur.
Original change's description:
> Filter out NaNs before uploading to the dasboard
>
> No-Presubmit: True
> Bug: webrtc:12224
> Change-Id: I48a140f08276362491650496f63a23727c56fa6e
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195320
> Commit-Queue: Andrey Logvin <landrey@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#32690}
TBR=mbonadei@webrtc.org ,landrey@webrtc.org
Change-Id: If2b0bd5046d040b8289eefd22e313ce554b98bff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:12224
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195323
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32691}
2020-11-25 10:34:14 +00:00
9db3ab201e
Filter out NaNs before uploading to the dasboard
...
No-Presubmit: True
Bug: webrtc:12224
Change-Id: I48a140f08276362491650496f63a23727c56fa6e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195320
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32690}
2020-11-25 10:16:41 +00:00
8d87e6d1de
Roll chromium_revision 10f5691657..8f4e430afe (830729:830890)
...
Change log: 10f5691657..8f4e430afe10f5691657..8f4e430afed7b600503c..66f22dbb61def37292b7..6b6c35d64209a6bc8c68..70017627a0b19108a932..c2e20c4073https://chromium.googlesource.com/catapult.git/+log/a629d81faa..ae003f552e
* src/third_party/depot_tools: 4c5dd5d863..8820ab859bb0a18bc755..11cce5c2872a1d77f099..9419fdea0610f5691657..8f4e430afeTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I3625db8439e59a588235353fc91ff645b418471d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195300
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32689}
2020-11-25 07:07:50 +00:00
bafeede2b5
Roll chromium_revision fed88f41ed..10f5691657 (830583:830729)
...
Change log: fed88f41ed..10f5691657fed88f41ed..10f5691657df7d1bcfe2..b97e8e9f670b7bec4032..d7b600503cc22e99448e..def37292b7ae656081dc..09a6bc8c681f137efbc1..b19108a932b35dd76cd5..4c5dd5d863880674d483..2a1d77f099fed88f41ed..10f5691657TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I25a5021f0f591a889d735ac22ccee4cb0f5876c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195280
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32688}
2020-11-24 22:39:24 +00:00
1620db743e
Roll chromium_revision acfa5a0113..fed88f41ed (830473:830583)
...
Change log: acfa5a0113..fed88f41edacfa5a0113..fed88f41ed67efd05620..df7d1bcfe2356ef25e24..0b7bec4032feae45c075..c22e99448e9b8961da57..1f137efbc1260eb0f662..b35dd76cd5d28bf829ec..880674d483acfa5a0113..fed88f41edTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I251b329a2677ea78a165ee3dd03949de83f090e2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195240
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32687}
2020-11-24 16:44:48 +00:00
25767f7c3f
Fix timout message while uploading to the dashboard
...
No-Presubmit: True
Bug: webrtc:12223
Change-Id: I8991962f6ec7fbf92ce6a90561e8438452ed632c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195220
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32686}
2020-11-24 15:56:08 +00:00
659d7015db
Replace all infinity values before uploading to the dashoard
...
No-Presubmit: True
Bug: webrtc:12224
Change-Id: I4a7a33bedb5449d7e36293e0c6f47e9cd4d0235a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195200
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32685}
2020-11-24 15:19:56 +00:00
a62fa7378f
Removed unused H264 specific code from RtpFrameReferenceFinder.
...
Bug: webrtc:12221
Change-Id: I238ad9c0cb53720a91e0722d61d1704586b56398
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195005
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32684}
2020-11-24 13:51:36 +00:00
3f77eb468f
fixing build for when HAVE_WEBRTC_VIDEO is not defined
...
In that configuration HAVE_WEBRTC_VIDEO is not defined so null_webrtc_video_engine.h gets included which unlike the real one does not include a required header.
Bug: webrtc:11926, webrtc:12187
Change-Id: I3f9df7a841ea6d9920dcb5b39a7386946c9e4341
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193784
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32683}
2020-11-24 11:14:26 +00:00
bce02a9467
Fix authentication error while polling for upload results
...
I'm not 100% sure that is the reason. But I think it worth trying.
No-Presubmit: True
Bug: webrtc:12223
Change-Id: Idc6a9006ce2e3c6d299ad56cd747faebfeff37ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195003
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32682}
2020-11-24 10:37:16 +00:00
47a03e8743
Default enable sending transport sequence numbers on audio packets.
...
This enables send side bandwidth estimation for audio and removes field
trial "WebRTC-Audio-SendSideBwe" which this was controlled through.
Transport-cc extension still needs to be negotiated.
Bug: webrtc:12222
Change-Id: Ie2268fad13703eeb0f0d38fcf484baaa29715b7c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194142
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32681}
2020-11-24 09:19:54 +00:00
d840c8fb5d
Roll chromium_revision d375f99a80..acfa5a0113 (830370:830473)
...
Change log: d375f99a80..acfa5a0113d375f99a80..acfa5a011302e8075499..67efd05620e0140a0715..356ef25e2475ae34f793..feae45c0754dd6336ef5..ae656081dc6b15032a46..9b8961da57a373192bc2..d28bf829ecd375f99a80..acfa5a0113TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I154f9629662690349a149e416b18ee1207d7496a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195120
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32680}
2020-11-24 07:07:06 +00:00
c1f5aaac58
Roll chromium_revision 45755197db..d375f99a80 (830233:830370)
...
Change log: 45755197db..d375f99a8045755197db..d375f99a801b2111b9c2..02e80754996d81571a4b..e0140a0715a1a49e1c65..75ae34f793b066b8030e..6b15032a46https://chromium.googlesource.com/catapult.git/+log/844c1542a1..a629d81faa
* src/third_party/depot_tools: 9c0dc3026e..260eb0f6627db579a73a..6a33b647c0df81dcc2d6..a373192bc245755197db..d375f99a80TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ie5025dbae693f57effd785a830e5a58b9de7a379
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195080
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32679}
2020-11-24 00:42:51 +00:00
2c73a92305
Roll chromium_revision ef9a6dff92..45755197db (830132:830233)
...
Change log: ef9a6dff92..45755197dbef9a6dff92..45755197db95868d5178..1b2111b9c2fe03ecff2c..6d81571a4b36e0416857..a1a49e1c655da61f6a14..4dd6336ef50eac02dab6..b066b8030ehttps://chromium.googlesource.com/catapult.git/+log/cb4bb2088a..844c1542a1
* src/tools: 28d6892464..df81dcc2d6ef9a6dff92..45755197dbTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I112aee00817ad760f030b197ab18bce031b93652
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194981
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32678}
2020-11-23 18:32:45 +00:00
db9095de83
Fix perf results upload.
...
Starting from [1], //third_party/protobuf has been updated to 3.13.0
and this introduces a breaking change which breaks WebRTC's perf results
upload (see bugs.webrtc.org/12211).
Error:
File [..]/tracing/proto/histogram_proto.py", line 9, in <module>
import histogram_pb2 # pylint:disable=relative-import
File "[..]/tracing/proto/histogram_pb2.py", line 22, in <module>
create_key=_descriptor._internal_create_key,
AttributeError: 'module' object has no attribute '_internal_create_key'
It looks like vpython is not able to load the wheel from the vpython
environment if the import happens in the "from ... import ..." form
while it works if the library is pre-imported with "import ...".
[1] - https://chromium-review.googlesource.com/c/chromium/src/+/2545204
No-Try: True
No-Presubmit: True
Bug: webrtc:12211
Change-Id: Id3e365eb9d4c4c31bcd4dcfab7db700e0e6e00b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195000
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32677}
2020-11-23 16:56:51 +00:00
19526a69c7
Add RTC_NO_UNIQUE_ADDRESS to webrtc::VideoStreamAdapter.
...
Bug: webrtc:11495
Change-Id: I32a1bc75d7c578753c158a61eb6cb5ea7565629a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194564
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32676}
2020-11-23 15:25:19 +00:00
a186f42077
p2p: Fix bug causing old candidates on ice restart
...
This patch fixes a bug where old candidates was
generated if doing GATHER_CONTINUALLY.
The problem was that the old port allocator session
was never stopped, and when the new sessio is created
it will attach to the network that will signal OnNetworkChanged().
The patch adds explicit stop of old sessions.
The problem was not possible to trigger using fake_network
as this "incorrectly" called SignalNetworkChanged directly
rather than after a Thread->Post() like network.cc does it.
Bug: webrtc:12210
Change-Id: Ief3f961bd97f06f4c4194ecbc3200c635ba63cf6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194961
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32675}
2020-11-23 14:58:39 +00:00
8d526cd5c9
Document purpose and wire format of extension http://www.webrtc.org/experiments/rtp-hdrext/video-layers-allocation00
...
Bug: webrtc:12000
Change-Id: Ia069665d7952c186fb9ba386d7e69fc7580eed7d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194960
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32674}
2020-11-23 14:55:49 +00:00
91e4156a8c
Remove dependency on MessageHandlerAutoCleanup from cricket::Port.
...
Bug: webrtc:11988
Change-Id: I15335cf49365de1274f5d3051dcb2de97e9e263b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194562
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32673}
2020-11-23 14:32:49 +00:00
fd53dd8660
Roll chromium_revision cbb40ac31a..ef9a6dff92 (830083:830132)
...
Change log: cbb40ac31a..ef9a6dff92cbb40ac31a..ef9a6dff9249ce9a35fc..fe03ecff2c728411b2a4..36e04168570fb8b4e1f3..0eac02dab6https://chromium.googlesource.com/catapult.git/+log/91c1a7c2dc..cb4bb2088a
* src/tools: ca0185b72c..28d6892464cbb40ac31a..ef9a6dff92TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Icde7ed4ef1d37cb0e19a3a24c2368ca5c4934493
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194940
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32672}
2020-11-23 12:05:28 +00:00
4b5d323d2f
Remove dependency on AsyncInvoker from BasicRegatheringController
...
Bug: webrtc:11988
Change-Id: I5ddf80d02af3bc5879c5ff299b040729206f5dba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194338
Commit-Queue: Tommi <tommi@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32671}
2020-11-23 11:50:28 +00:00
af6ea0c3ab
Delete internal getter methods from RtpRtcpInterface
...
Methods deleted: StorePackets, RtcpXrRrtrStatus. They are now private
methods on the two implementations.
Bug: None
Change-Id: If68e8f1e8ba233302e24e0cdb6bf7c1b0c9f330f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194322
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32670}
2020-11-23 11:37:41 +00:00
a28ae40ce2
Restructure format of the video layers allocaton rtp header extension
...
The newer format is byte aligned and thus faster to write and parse
It also more compact for the common target bitrate cases.
Bug: webrtc:12000
Change-Id: Id040ecb9e7d85799134a6e52f5d6d280b5161262
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193860
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32669}
2020-11-23 11:36:36 +00:00
20e4c80fbe
Reland "Introduce RTC_NO_UNIQUE_ADDRESS."
...
This is a reland of f5e261aaf65cdf2eb903cdf40d651846be44f447
This CL disables RTC_NO_UNIQUE_ADDRESS on MSan builds since
there have been some issues.
Original change's description:
> Introduce RTC_NO_UNIQUE_ADDRESS.
>
> This macro introduces the possibility to suggest the compiler that a
> data member doesn't need an address different from other non static
> data members.
>
> The usage of a macro is to maintain portability since at the moment
> the attribute [[no_unique_address]] is only supported by clang
> with at least -std=c++11 but it should be supported by all the
> compilers starting from C++20.
>
> Bug: webrtc:11495
> Change-Id: I9f12b67b4422a2749649eaa6b004a67d5fd572d8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173331
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#32246}
Bug: webrtc:11495, webrtc:12218
Change-Id: I4e6c7cc37d3daffad2407c9a2acfa897fa5b426a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/189968
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32668}
2020-11-23 11:29:36 +00:00
cf1308fddd
Ignore frame type when calculating generic frame dependencies.
...
When spatial scalability is used, both vpx and aom set key frame flag
for all spatial layers of the first frame, while rtp code expect it to
be set only on the frame without spatial dependencies.
That creates confusion for the frame dependency calculator.
Simplest solution seems to ignore that confusing signal and instead
rely encoder wrappers update frame buffer usages when key frame is generated.
Bug: webrtc:11999
Change-Id: Ica24f1d8d42d32dd24664beabf32ac24872cd15a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194002
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32667}
2020-11-23 10:52:06 +00:00
28cf2efd08
modules/bitrate_controller/include is no longer a legacy api directory
...
It was deleted in https://webrtc-review.googlesource.com/c/src/+/154346
Bug: None
Change-Id: I737bb5777fa4ef7aad70989a53405666dd9f0f64
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194329
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32666}
2020-11-23 10:43:16 +00:00
8f56dbf93e
Delete unused class CaptureResultDesktopCapturerWrapper
...
Class was introduced in 2017, see
https://webrtc-review.googlesource.com/1420 , but never taken into use.
Bug: chromium:764258
Change-Id: I5f15f25a3c1a992f8c725b78891956e7275b0e4d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194320
Reviewed-by: Jamie Walch <jamiewalch@chromium.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32665}
2020-11-23 10:22:56 +00:00
79348b55df
Roll chromium_revision 4b8443c6e6..cbb40ac31a (829974:830083)
...
Change log: 4b8443c6e6..cbb40ac31a4b8443c6e6..cbb40ac31afe4fe4d82b..95868d5178030a31295a..49ce9a35fc3419ce0791..728411b2a499180e21a6..0fb8b4e1f31286f58c29..5abd252a0addff2f9763..ca0185b72c4b8443c6e6..cbb40ac31aTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I0c2b5a92ddb616c6d3cb3a268c70aae86242a7e2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194860
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32664}
2020-11-23 04:45:34 +00:00
c5fd745672
Remove AsyncInvoker dependency from P2PTransportChannel
...
Bug: webrtc:11988
Change-Id: Ic7e1f35a18c0af7ae3f602a2d81a0b7fd45b6cf0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194337
Commit-Queue: Tommi <tommi@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32663}
2020-11-22 17:34:19 +00:00
e27f3dea82
Remove dependency on MessageHandlerAutoCleanup from BasicPortAllocatorSession and AllocationSequence
...
All Post() calls are made to the network thread which the class already
clears up explicitly. 'AutoCleanup' scans all thread instances, which is
not needed for this class.
Bug: webrtc:11988
Change-Id: Ieefbdc87683dc62b6156c5df72e87d404242170f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194339
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32662}
2020-11-22 13:46:49 +00:00
d96634781e
Remove dependency on MessageHandlerAutoCleanup from VirtualSocket
...
Bug: webrtc:11988
Change-Id: Ifeb901b110bd6c82922ae2560e4d508c6ed289d2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194560
Commit-Queue: Tommi <tommi@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32661}
2020-11-22 11:34:04 +00:00
b5fde37192
Roll chromium_revision 039670a41a..4b8443c6e6 (829870:829974)
...
Change log: 039670a41a..4b8443c6e6039670a41a..4b8443c6e600d2ad6f8d..fe4fe4d82bfe32df683b..030a31295a085210db4f..3419ce079105ab8a27ea..5da61f6a14d19cd381d0..99180e21a6https://chromium.googlesource.com/catapult.git/+log/11b4013701..91c1a7c2dc
* src/tools: 2cbcb4acb0..ddff2f9763039670a41a..4b8443c6e6TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ib27bcdbc6fce364232ed6bb373218cd5c410802c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194480
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32660}
2020-11-21 08:42:36 +00:00
7d75f2ca78
Roll chromium_revision 81ed105820..039670a41a (829759:829870)
...
Change log: 81ed105820..039670a41a81ed105820..039670a41a0997543f77..00d2ad6f8d4ec35b6842..fe32df683b54a7fdf87e..085210db4fb648a16bf4..05ab8a27eadb05ee094b..d19cd381d0https://chromium.googlesource.com/catapult.git/+log/6743d1edbf..11b4013701
* src/third_party/freetype/src: 32b14552d6..1286f58c2916973d613f..8f8e2dc7d55db0a39d3c..2cbcb4acb081ed105820..039670a41aTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: If8030f521c98249bf9b50c88a748fa1d359805ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194400
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32659}
2020-11-21 00:42:53 +00:00
4d62438ecd
Roll chromium_revision 7ffc87db5f..81ed105820 (829478:829759)
...
Change log: 7ffc87db5f..81ed1058207ffc87db5f..81ed105820c5ee3d3a66..0997543f77ee1c0017e6..4ec35b684213ac7e8c0c..54a7fdf87e43906c65e3..b648a16bf430ba6c99db..db05ee094bhttps://chromium.googlesource.com/catapult.git/+log/2ed6fc040f..6743d1edbf
* src/third_party/depot_tools: 2f8e0fa49d..9c0dc3026eb0b70752e4..5db0a39d3c7ffc87db5f..81ed1058207ffc87db5f..81ed105820TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I55ac6100bbdb09355c1bd87c7227bb2847ad2ff4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194381
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32658}
2020-11-20 22:13:51 +00:00
ce4be1e640
Revert "Enable FlexFEC as a receiver video codec by default"
...
This reverts commit f08db1be94e760c201acdc3a121e67453960c970.
Reason for revert: It looks like this breaks Chromium FYI Windows bots.
See https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win10%20Tester/6988 .
If this is not the culprit I will reland.
Original change's description:
> Enable FlexFEC as a receiver video codec by default
>
> - Add Flex FEC format as default supported receive codec
> - Disallow advertising FlexFEC as video sender codec by default until implementation is complete
> - Toggle field trial "WebRTC-FlexFEC-03-Advertised"s behavior for receiver to use as kill-switch to prevent codec advertising
>
> Bug: webrtc:8151
> Change-Id: Iff367119263496fb335500e96641669654b45834
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191947
> Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org >
> Reviewed-by: Ying Wang <yinwa@webrtc.org >
> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
> Reviewed-by: Stefan Holmer <stefan@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#32639}
TBR=brandtr@webrtc.org ,tommi@webrtc.org ,stefan@webrtc.org ,crodbro@webrtc.org ,crodbro@google.com ,yinwa@webrtc.org ,philipp.hancke@googlemail.com ,hmaniar@nvidia.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:8151
Change-Id: Ia1788a1cf34e0fc9500a081552f6ed03d0995d5b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194334
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32657}
2020-11-20 20:31:39 +00:00
b223cb60e9
Defining API result types on VoIP API
...
Bug: webrtc:12193
Change-Id: I6f5ffd82cc838e6982257781f225f9d8159e6b82
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193720
Commit-Queue: Tim Na <natim@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32656}
2020-11-20 18:02:05 +00:00
a65d78517a
Don't use VP9 specific concepts to combine spatial layer frames in FrameBuffer2.
...
The Dependency Descriptor use unique ids for every frame, meaning spatial layer frames will all have unique ids.
Bug: webrtc:10342
Change-Id: I241a8b3959e27bd918ae7a907ab5158fe9dcd7a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194327
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32655}
2020-11-20 17:59:26 +00:00
716a3c9ff2
Remove unused includes from RtpFrameReferenceFinder.
...
Bug: none
Change-Id: I4fc5f70e3e532c3735a97a9d7fd8f6f51d7d2a7f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194333
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32654}
2020-11-20 17:35:28 +00:00
08d2a703fc
AGC2 limiter stats + config ToString missing param
...
Bug: webrtc:7494
Change-Id: Icb6a164882af5c15c9400eb869dccbfda20b3da7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194324
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32653}
2020-11-20 17:03:05 +00:00
f46723c8aa
Enable initial frame drop for one active simulcast layer.
...
Bug: webrtc:12216
Change-Id: Ib2ac2fab45e560ba3eae30a926ce72667a257b07
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193840
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32652}
2020-11-20 16:21:05 +00:00
766a32c28d
dont allocate a payload type for rtp data channels when using sctp
...
BUG=webrtc:12194,webrtc:6625
Change-Id: Ifc8f0b197a536626c16ba5c3ebccbf242008c857
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193861
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/master@{#32651}
2020-11-20 15:47:45 +00:00
c45f68a026
Trigger bots for FYI waterfall.
...
TBR=titovartem@webrtc.org
No-Try: True
Bug: None
Change-Id: I68ae8f72d60cf19cf2fd7a338eb6906a0e30bbd7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194263
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32650}
2020-11-20 09:35:54 +00:00
0958ca3e31
Reland "Add protobuf-py2_py3 3.13.0 to .vpython."
...
This is a reland of 9b53c2983260a210ba4f04510759bc56d5a2285e
It looks like the idea was correct (see [1]), changes with respect to
the original at [2].
[1] - https://chromium-review.googlesource.com/c/chromium/src/+/2545204/7/tools/privacy_budget/blink_apis/generate_blink_api_db.py
[2] - https://webrtc-review.googlesource.com/c/src/+/194261/1..2
Original change's description:
> Add protobuf-py2_py3 3.13.0 to .vpython.
>
> Starting from https://webrtc-review.googlesource.com/c/src/+/194081 ,
> WebRTC's protobuf are using version 3.13.0.1+ but when running on
> bots, we see errors that are probably caused by a version mismatch, see
> https://ci.chromium.org/p/webrtc/builders/perf/Perf%20Linux%20Trusty/4597 .
>
> This CL updates WebRTC's .vpython to use protobuf 3.13.0.
>
> TBR=kwiberg@webrtc.org
>
> No-Try: True
> Bug: None
> Change-Id: I6bc5e71bacc67dbd9299a9588ddf826778451949
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194143
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Andrey Logvin <landrey@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#32642}
TBR=kwiberg@webrtc.org
No-Try: True
No-Presubmit: True
Bug: None
Change-Id: Ic61d477b7ad104d15edf4afbbfb9c51f261bc435
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194261
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32649}
2020-11-20 07:52:26 +00:00
df3fa989f2
Revert "Add protobuf-py2_py3 3.13.0 to .vpython."
...
This reverts commit 9b53c2983260a210ba4f04510759bc56d5a2285e.
Reason for revert: It hasn't fixed the issue.
Original change's description:
> Add protobuf-py2_py3 3.13.0 to .vpython.
>
> Starting from https://webrtc-review.googlesource.com/c/src/+/194081 ,
> WebRTC's protobuf are using version 3.13.0.1+ but when running on
> bots, we see errors that are probably caused by a version mismatch, see
> https://ci.chromium.org/p/webrtc/builders/perf/Perf%20Linux%20Trusty/4597 .
>
> This CL updates WebRTC's .vpython to use protobuf 3.13.0.
>
> TBR=kwiberg@webrtc.org
>
> No-Try: True
> Bug: None
> Change-Id: I6bc5e71bacc67dbd9299a9588ddf826778451949
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194143
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Andrey Logvin <landrey@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#32642}
TBR=mbonadei@webrtc.org ,kwiberg@webrtc.org ,landrey@webrtc.org
Change-Id: I8d16d30bbe922b826f4839af941168a4d9b26318
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194260
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32648}
2020-11-20 07:28:56 +00:00
715d02334b
Add feature to not discard candidates after connection is established
...
In P2PTransportChannel::OnConnectionStateChange there is
code that stop port allocation sessions if the modified
connection is stronly connected.
This means that local candidates are discarded (they are still
gathered, only not surfaced).
The implication of this is that if e.g doing a TURN allocation
slower than P2P is established, the TURN allocation will not be
added to list of local candidates => no TURN connection will be
created.
NOTE: If first connecting kRelay (only RELAY ONLY) then this
patch does matter that much...until an ICE restart happens :)
I discovered this when adding the emulated TURN server
to tests, and being surprised that the TURN allocations
never got used. These test does not (currently) use kRelay
as start.
Bug: webrtc:12210
Change-Id: I78a67201cf421b0e6fdd2ea684a00d740e063f5e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194141
Reviewed-by: Taylor <deadbeef@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32647}
2020-11-20 06:07:34 +00:00
39c172d2a5
Roll chromium_revision 98d2d3586b..7ffc87db5f (829346:829478)
...
Change log: 98d2d3586b..7ffc87db5f98d2d3586b..7ffc87db5f74286ae676..c5ee3d3a6613721f7533..ee1c0017e695cc5f773d..13ac7e8c0c6c6bbeca5d..43906c65e329c5de97fb..30ba6c99dbhttps://chromium.googlesource.com/catapult.git/+log/0c019226a9..2ed6fc040f
* src/third_party/depot_tools: 5589652282..2f8e0fa49d0bda20101d..b0b70752e498d2d3586b..7ffc87db5f98d2d3586b..7ffc87db5fTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ic40f6f24056c49b6c8574043ceedbdbc60537963
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194220
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32646}
2020-11-20 03:09:24 +00:00
bff717e4f9
Remove dependency on AsyncInvoker in SctpTransport
...
Bug: webrtc:11988
Change-Id: I996aa220a00b61fb5080803bffe7a37c6b90aaec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193866
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32645}
2020-11-19 23:25:42 +00:00
04fed3c7ea
Roll chromium_revision 3e59a75314..98d2d3586b (829209:829346)
...
Change log: 3e59a75314..98d2d3586b3e59a75314..98d2d3586b99ae374530..74286ae676f3b6660689..13721f75334e3cc0af27..95cc5f773df67483e445..6c6bbeca5d6b1b850b5a..29c5de97fb08ac55cb78..0bda20101d3e59a75314..98d2d3586bTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: If68caa32b3f771516039c51fb25c636732ccd5cb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194160
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32644}
2020-11-19 20:45:19 +00:00
ba56ea0b5d
Removed superfluous check in FrameBuffer2.
...
Since inter_layer_predicted information is not propagated by the Dependency Descriptor this block non-VP9 super frames.
Bug: webrtc:10342
Change-Id: I90fbd368e92d168560a21ff79693f07071ea6cfb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194140
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32643}
2020-11-19 17:06:14 +00:00
9b53c29832
Add protobuf-py2_py3 3.13.0 to .vpython.
...
Starting from https://webrtc-review.googlesource.com/c/src/+/194081 ,
WebRTC's protobuf are using version 3.13.0.1+ but when running on
bots, we see errors that are probably caused by a version mismatch, see
https://ci.chromium.org/p/webrtc/builders/perf/Perf%20Linux%20Trusty/4597 .
This CL updates WebRTC's .vpython to use protobuf 3.13.0.
TBR=kwiberg@webrtc.org
No-Try: True
Bug: None
Change-Id: I6bc5e71bacc67dbd9299a9588ddf826778451949
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194143
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32642}
2020-11-19 16:00:58 +00:00
