6de75ca3ed
Remove the useless dummy state parameter to WebRtcPcm16b_DecodeW16
...
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26039004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7610 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-04 13:29:24 +00:00
c78cf97ecb
Remove the useless dummy state parameter to WebRtcG711_*
...
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27029004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7609 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-04 13:23:36 +00:00
721ef633d0
Remove the codec_type_ member from AudioDecoder
...
It isn't actually required, as evidenced by the comparative ease with
which it can be removed.
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31939004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7606 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-04 11:51:46 +00:00
b0f4b3da05
Improving error message from neteq_rtpplay
...
If a packet with unknown RTP payload type is inserted, this CL
will make sure that the error message is a little more detailed
and gives a better understadning of what to do.
BUG=2692
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27909004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7603 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-04 08:53:10 +00:00
4765ca55f9
Roll chromium_revision: 28d1981..d3db2ff
...
Pick up the libvpx roll: https://codereview.chromium.org/674753002
Summary of changes (28d1981..d3db2ffR=andrew@webrtc.org
TBR=ajm@google.com
Review URL: https://webrtc-codereview.appspot.com/23229004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7598 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-03 20:10:26 +00:00
f9471807a2
Add Opus support to neteq_rtpplay
...
BUG=2416
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30859004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7595 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-03 15:19:58 +00:00
78c222bfae
Update all .isolate files for the new format.
...
R=kjellander@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/27809004
Patch from Marc-Antoine Ruel <maruel@chromium.org >.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7583 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-31 18:08:09 +00:00
508c91683c
Build fix for MIPS32R6.
...
Exclude MIPS optimizations for MIPS32R6 build since some of the instructions
are not supported. This is temporary fix, until the MIPS32R6 code is added.
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25989004
Patch from Ljubomir Papuga <lpapuga@mips.com >.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7580 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-31 16:26:17 +00:00
decd9306ae
AudioEncoder: num_10ms_frames_per_packet -> Num10MsFramesInNextPacket
...
Rename this accessor function to reflect its new, slightly changed
meaning. The reason for the change is that some codecs (iSAC) vary the
number of 10 ms frames from packet to packet, and so can't return a
truly constant value.
BUG=3926
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31849004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7556 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-29 08:38:50 +00:00
663fdd02fd
Make an AudioEncoder subclass for Opus
...
BUG=3926
R=henrik.lundin@webrtc.org , kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23239004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7552 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-29 07:28:36 +00:00
a296725d0e
audio_coding/codecs/isac/fix: Replaced macro WEBRTC_SPL_RSHIFT_W32 with >>"
...
BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23119004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7544 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-28 13:05:43 +00:00
67ca26e087
common_audio: Removed trivial macro WEBRTC_SPL_UMUL_16_16
...
The macro made a cast to uint16_t before a plain multiplication. At the few places where it was used the variables were already uint16_t.
Affected components:
* isac/fix
BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29869004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7543 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-28 13:03:10 +00:00
ff8a98e352
Use neteq_unittest_tools in audio_decoder_unittests
...
With the recent move of RtpFileReader to the rtp_test_utils target
(in r7536), it is now possible to let audio_decoder_unittests depend
on neteq_unittest_tools without breaking the Android build.
BUG=2692
TBR=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30819004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7542 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-28 09:47:13 +00:00
a37f1dd6b8
Cleaning up audio_decoder_test.cc and adding ResampleInputAudioFile
...
This CL contains some cleaning up and refactoring of
audio_decoder_test.cc. A new class ResampleInputAudioFile is created
and used in the tests.
BUG=3926
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31779004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7528 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-27 12:58:18 +00:00
0552356fda
isacfix: Refactor big-endian reading and writing
...
Make subroutines for encoding and decoding arrays of 16-bit big-endian
integers, and in the process fix a bug: When decoding an odd number of
bytes from be16, the least significant byte of the last int16 in the
array was properly taken to be zero instead of actually being read
(since it's outside the array). However, when encoding an odd number
of bytes, the least significant byte of the last int16 in the array
was written to the output as-is instead of being taken to be zero;
thus, we encoded one byte more than we should. This was probably not
harmful, and the value was dropped at decoding anyway; nevertheless,
writing a constant zero is the safe thing to do, and this patch does
so.
R=aluebs@webrtc.org , bjornv@webrtc.org , henrik.lundin@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7527 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-27 11:25:37 +00:00
580d367b14
Add macros and APIs for webrtc histograms.
...
BUG=crbug/419657
Code that links system_wrappers.gyp:system_wrappers should either:
- provide implementations for the APIs, or
- link with default implementations in system_wrappers.gyp:system_wrappers_default.
R=andresp@webrtc.org , kjellander@webrtc.org , mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22809004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7508 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-23 12:57:56 +00:00
def1e97ed2
Implement AudioEncoderPcmU/A classes and convert AudioDecoder tests
...
BUG=3926
R=kjellander@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29799004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7481 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-21 12:48:29 +00:00
78ea06dd34
audio_coding/codecs/ilbc: Replaced macro WEBRTC_SPL_RSHIFT_W32 with >>
...
Removed usage of trivial macro.
BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29789004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7480 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-21 07:17:24 +00:00
913f7b8d5e
Fix for glitches in ACM when switching desired output sample rate
...
The problem was that if the output sample rate is changed such from one
where no resampling is needed to a rate that requires resampling, the
first output from the resampler will contain an onset period. The
solution provided in this CL is to keep a copy of the last output frame
in ACM, and if the resampler is engaged, it will be primed with this
old frame before resampling the current frame.
BUG=3919
R=bjornv@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7479 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-21 06:54:23 +00:00
2abebe7baf
audio_coding/codecs/isac/main: Replaced macro WEBRTC_SPL_RSHIFT_W32 with >>
...
BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30739004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7474 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-20 08:26:41 +00:00
a5ce7bbe17
audio_coding/neteq: Replaced macro WEBRTC_SPL_RSHIFT_W32 with >>
...
BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24009004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7473 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-20 08:24:54 +00:00
264e66f7a5
Add encoded_timestamp to AudioEncoder base class
...
BUG=3926
TBR=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24029004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7464 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-16 21:16:07 +00:00
9ea6f8a84d
New interface class AudioEncoder
...
This class will be the base for new C++ wrapper classes for all
encoders.
BUG=3926
TBR=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7463 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-16 11:26:24 +00:00
99e561f6a6
Extend AcmSwitchingOutputFrequencyOldApi with more frequencies
...
Also reducing test duration, since the issue is triggered anyway.
The tests that are not failing are now enabled.
BUG=3919
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7453 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-15 08:50:00 +00:00
81a78930ee
New ACM test to trigger audio glitch when switching output sample rate
...
This CL implements a new unit test. The test is designed to trigger
a problem in ACM where switching the desired output frequency creates
a short discontinuity in the output audio. The problem itself is not
solved in this CL, but the failing test is disabled for now.
BUG=3919
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23019004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7443 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-14 10:49:58 +00:00
a57678a70e
Workarounds for a bug in VS2013.3 linker when PGO is turned on.
...
See crbug.com/421607 for more details about this. This CL solve a linker bug when the PGO is turned on, without changing the behaviour or the performances.
BUG=crbug.com/421607
R=kwiberg@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26789005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7441 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-14 09:40:04 +00:00
a3722b643d
iSAC tests: Type buffers as uint8_t[] to avoid casts
...
The iSAC interface functions now expect uint8_t arrays, so change some
arrays to be of that type instead of casting at each point of use.
R=bjornv@webrtc.org , henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31689004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7433 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-13 13:29:04 +00:00
396a5e0001
WebRtcIsac_Decode et al.: Type encoded data as uint8[], not uint16[]
...
This patch changes WebRtcIsac_Decode, WebRtcIsac_DecodeRcu, and
WebRtcIsacfix_Decode so that they read the encoded data from a uint8
array instead of a uint16 array.
BUG=909
R=aluebs@webrtc.org , bjornv@webrtc.org , henrik.lundin@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25739004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7431 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-13 11:23:24 +00:00
3f7f899a15
WebRtcIsac_UpdateBwEstimate et al.: Type byte streams as uint8, not uint16
...
This patch changes the signature of WebRtcIsac_UpdateBwEstimate,
WebRtcIsacfix_UpdateBwEstimate, and WebRtcIsacfix_UpdateBwEstimate1 so
that they expect the encoded data to be uint8 arrays, not uint16,
which is more natural. The implementations of the functions are left
unchanged for now.
BUG=909
R=aluebs@webrtc.org , bjornv@webrtc.org , henrik.lundin@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7430 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-13 11:07:06 +00:00
1172988c79
Some WebRtcIsac_* and WebRtcIsacfix_* functions: type encoded stream as uint8[]
...
The affected functions are
WebRtcIsacfix_ReadFrameLen
WebRtcIsacfix_GetNewBitStream
WebRtcIsacfix_ReadBwIndex
and
WebRtcIsac_ReadFrameLen
WebRtcIsac_GetNewBitStream
WebRtcIsac_ReadBwIndex
WebRtcIsac_GetRedPayload
BUG=909
R=aluebs@webrtc.org , henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22979004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7429 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-13 10:53:42 +00:00
4bd2db9a55
Opus wrapper: Use const for inputs and uint8[] for byte streams
...
About half of the functions already followed the desired pattern; this
patch fixes the other half.
BUG=909
R=aluebs@webrtc.org , bjornv@webrtc.org , henrik.lundin@webrtc.org , minyue@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7409 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-09 11:21:10 +00:00
c803907d87
Removing useless packets when inserting them (NetEq)
...
This is to save the buffer.
Some old code may become unnecessary, and will be removed in a separate CL.
BUG=
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27669004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7406 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-09 10:49:54 +00:00
3ea35fdb1b
common_audio: Removed macro WEBRTC_SPL_LSHIFT_W16
...
The macro was a trivial << operation and where used has been replaced by <<. Affected components are
* ilbc
* isacfix
BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22919005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7404 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-09 08:47:02 +00:00
f71785cd3b
audio_coding: Replaced macro WEBRTC_SPL_RSHIFT_W16 with >>
...
Replaced trivial shift macro with >>. The actual implementation of the macro is simply >>.
Affected codecs:
* ilbc
* isac/fix
BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org , kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23889004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7396 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-08 15:36:30 +00:00
5e3d7c78de
Change name of a NetEq internal member variable
...
In the StatisticsCalculator class, the member last_report_timestamp_
was unfortunately named. It's now been changed to
timestamps_since_last_report_, which describes it more accurately.
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25819004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7393 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-08 12:10:53 +00:00
9103953b58
Fix neteq_rtpplay so that empty SSRC is valid
...
In r7380, the command line flag --ssrc was added to neteq_rtpplay.
However, it was not possible to omit that flag, since the validation
did not accept an empty string. This CL fixes that.
TBR=kwiberg@webrtc.org
BUG=2692
Review URL: https://webrtc-codereview.appspot.com/24869004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7382 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-07 07:18:36 +00:00
7cbc4f969a
Set NetEq playout mode through the Config struct
...
This change opens up the possibility to set the playout mode when
creating the NetEq object. The old methods SetPlayoutMode and
PlayoutMode are still available, but are deprecated.
BUG=3520
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23869004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7381 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-07 06:37:39 +00:00
8b65d511a0
Add an SSRC filter to neteq_rtpplay
...
This allows the user to set the desired SSRC if the input file
contains multiple streams.
BUG=2692
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7380 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-07 05:30:04 +00:00
532ed43e85
Prevent reading outside iSAC bitstream, if the stream is corrupted.
...
BUG=chrome_373312(#24 )
R=henrik.lundin@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20089004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7379 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-07 00:21:02 +00:00
4b133da5fd
Let RtpFileSource use RtpFileReader
...
RtpFileSource used to implement it's own RTP dump file reader, but
with this change it simply uses RtpFileReader. One benefit is that
pcap files are now also supported.
All NetEq test tools that use RtpFileSource are updated.
BUG=2692
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22839004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7367 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-02 08:19:38 +00:00
c86e45d7c4
Fix parallelizability in modules_tests.
...
R=henrik.lundin@webrtc.org
BUG=3873
TEST=third_party/gtest-parallel/gtest-parallel -r 10 -w 64 out/Debug/modules_tests
Review URL: https://webrtc-codereview.appspot.com/24799004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7354 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-01 10:05:40 +00:00
b8caf6a504
GN: Enable libvpx, add link target and convert some test targets
...
Libvpx now supports GN and this CL turns on compiling it.
I also introduced an executable target 'webrtc_tests'
that depends on all in WeBRTC + tests in order to get a full
linking step executed (since we've seen link problems for GN
when rolling WebRTC into Chromium).
I also converted a few test targets and made a GN file for
third_party/gflags.
BUG=3441
TESTED=Trybots + full Chromium build with a symlinked src/third_party/webrtc
dir to a workspace wit this CL applied.
R=brettw@chromium.org
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7344 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-30 18:05:02 +00:00
7c15510f38
common_audio refactoring: Removed macro WEBRTC_SPL_LSHIFT_U32
...
The macro is a trivial shift operator including a cast before shift. There is no guard against negative shifts. Replaced with << at place and added casts when necessary.
Affects both fixed and float point versions of iSAC
BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27369004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7320 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-29 09:40:38 +00:00
f21ea918ad
GN: Add common configs to all targets.
...
This is needed to ensure we have the same build with GN
as with GYP, since GYP includes the common.gypi on a global level.
Several fixes has been needed in the past because some code have
been built without the right defines.
BUG=3441
R=brettw@chromium.org
Review URL: https://webrtc-codereview.appspot.com/28589004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7317 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-28 17:37:22 +00:00
60fbd65482
Removing error triggered for disabling FEC on non-opus
...
A failure was triggered when one sets FEC status on a codec that does not support FEC. While it is definitely logical when one wants to enable it, it makes no good sense if one tries to disable it.
BUG=
R=tina.legrand@webrtc.org , xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7298 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-25 14:36:30 +00:00
741711a861
Revert r7049/r7123, which added unnecessary "u"s to "return 0"s.
...
r7049 added some unnecessary casts ("return 0" -> "return static_cast<uint16_t>(0)"). r7123 converted these to "return 0u". The original impetus for this was to eliminate type conversion warnings. However, the 'u's are unnecessary; Visual Studio can return "0" from a function returning an unsigned value without producing a warning. The real reason for the original warnings was that the code was returning -1 from a function returning an unsigned value, which does need a cast; the -1s were eliminated before the above two revisions landed.
Also reverse the order of some conditionals to prevent possible underflow.
While the underflow wouldn't have changed the behavior of the code, it's easier
to reason about the code when such underflow can't happen, and possibly safer
against future modifications as well.
BUG=3663
TEST=none
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22599004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7296 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-25 07:38:14 +00:00
7ee24a7906
WebRtcIsac_Encode and WebRtcIsacfix_Encode: Type encoded stream as uint8_t
...
We have to fix both at once, since there's a macro that calls one of
them or the other.
BUG=909
R=andrew@webrtc.org , bjornv@webrtc.org , henrik.lundin@webrtc.org , minyue@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=7266
Review URL: https://webrtc-codereview.appspot.com/19229004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7285 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-24 10:31:02 +00:00
38344ed280
Move thread_annotations.h to webrtc/base/.
...
R=andresp@webrtc.org , mflodman@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/27579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7283 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-24 06:05:00 +00:00
0e6e4d2ff2
Reland "Converting five tests to use new AudioCoding interface" (r7258)
...
This CL reverts r7264. The problem was that iSAC-SWB and iSAC-FB are
not supported on android. These are now disabled.
BUG=3520
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23739004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7273 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-23 12:05:34 +00:00
4f6f22f0c6
Reland (rev 7259) "Convert AcmReceiverTest to new AudioCoding interface"
...
Was reverted by mistake in 7260. Actual culprit was 7258.
BUG=3520
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7272 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-23 11:37:57 +00:00
