6ff76c7404
Reduce execution time of rate control test.
...
TBR=mikhal@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1289005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3782 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-08 20:32:48 +00:00
034f004a4f
WebRtc_Word32 => int32_t in video_coding/
...
BUG=314
Review URL: https://webrtc-codereview.appspot.com/1203008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3778 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-08 11:13:29 +00:00
79b0289bfc
Adds event traces and counters for WebRTC receive side.
...
Review URL: https://webrtc-codereview.appspot.com/1279005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3766 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-04 19:43:34 +00:00
7b859cc1e9
Webrtc_Word32 => int32_t in video_coding/main/
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/1279004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3753 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-02 15:54:38 +00:00
cfc07c943f
Revert of r3747.
...
TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1277005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3752 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-02 14:55:44 +00:00
747c4cc96e
For VGA (640x360), currently 1 thread is used. This change increases it to 2 threads. For HD, 4 threads are enabled.
...
BUG=none
TEST=run a hangout and screencast high framerate, high resolution windows of youtube. Observe that 1 cpu is insufficient to maintain high framerate with complex content.
Review URL: https://webrtc-codereview.appspot.com/1203006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3747 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-01 22:16:45 +00:00
29f34b8727
Fix for issue: https://code.google.com/p/webrtc/issues/detail?id=1549
...
Review URL: https://webrtc-codereview.appspot.com/1270004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3741 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-28 18:57:46 +00:00
bfacda60be
Add interface to signal a network down event.
...
- In real-time mode encoding will be paused until the network is back up.
- In buffering mode the encoder will keep encoding, and packets will be
buffered at the sender. When the buffer grows above the target delay
encoding will be paused.
- Fixes a couple of issues related to pacing which was found with the new test.
- Introduces different max bitrates for pacing and for encoding. This allows
the pacer to faster get rid of the queue after a network down event.
(Work based on issue 1237004)
BUG=1524
TESTS=trybots,vie_auto_test
Review URL: https://webrtc-codereview.appspot.com/1258004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3730 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-27 16:36:01 +00:00
836af79f58
Remove incorrect asserts.
...
BUG=1527
Review URL: https://webrtc-codereview.appspot.com/1214006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3698 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-21 12:15:44 +00:00
8685090060
Account for header inside I420Encoder::InitEncode.
...
Also verify that the header is part of the received payload inside
I420Decoder::Decode.
BUG=
Review URL: https://webrtc-codereview.appspot.com/1211005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3690 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-19 11:39:03 +00:00
3d0b0d6902
Follow-up fix for r3681.
...
TESTS=trybots and vie_auto_test
BUG=1514
Review URL: https://webrtc-codereview.appspot.com/1216006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3689 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-19 10:04:57 +00:00
f4944d49cf
Fix framerate sent to account for actually sent frames.
...
TESTS=trybots
BUG=1481
Review URL: https://webrtc-codereview.appspot.com/1195005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3682 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-18 17:04:52 +00:00
abc9d5b6aa
Change VCM interface to take target bitrate in bits per second.
...
This also solves issue 1469.
TESTS=trybots
BUG=1469
Review URL: https://webrtc-codereview.appspot.com/1215004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3681 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-18 17:00:51 +00:00
8911ce46a4
Generic video-codec support.
...
Labels frames as key/delta, also marks the first RTP packet of a frame as such,
to allow proper reconstruction even if packets are received out of order.
BUG=1442
TBR=ajm@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1207004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3680 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-18 16:39:03 +00:00
2baf5f5fa0
Refactor webrtc specific Event implementation to an EventFactory.
...
Review URL: https://webrtc-codereview.appspot.com/1187005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3664 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-13 08:46:25 +00:00
7473f89f63
Revert "Internal clean up: removing unused include line."
...
(reverting https://webrtc-codereview.appspot.com/1177004 )
BUG=none
Review URL: https://webrtc-codereview.appspot.com/1181005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3655 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 01:43:00 +00:00
25316b2a09
Internal clean up: removing unused include line.
...
BUG=none
TESTED=passed try server
Review URL: https://webrtc-codereview.appspot.com/1177004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3654 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 01:10:02 +00:00
971278a962
Splitting out video_coding_test executable again.
...
This CL undoes the merge of the developer test tool and the gtest tests
that was merged in https://code.google.com/p/webrtc/source/detail?r=3176
Doing that, we get a pure gtest executable of
video_coding_integrationtests which can run properly on the bots.
BUG=none
TEST=Trybots passing + local execution on Linux with:
out/Debug/video_coding_integrationtests --gtest_print_time (to ensure it will be possible to run with runtest.py)
Review URL: https://webrtc-codereview.appspot.com/1171007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3638 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-08 10:20:53 +00:00
84cd8e39cf
Disable frame dropper for screenshare mode.
...
BUG=1466
Review URL: https://webrtc-codereview.appspot.com/1170004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3629 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-07 13:12:32 +00:00
7c16c3c4a1
Move video_coding OWNERS to video_coding/.
...
TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1171004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3628 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-07 13:11:32 +00:00
a64300af50
Refactor NACK list creation to build the NACK list as packets arrive.
...
Also fixes a timer bug related to NACKing in the RTP module which could cause packets to only be NACKed twice if there's frequent packet losses.
Note that I decided to remove any selective NACKing for now as I don't think the gain of doing it is big enough compared to the added complexity. The same reasoning for empty packets. None of them will be retransmitted by a smart sender since the sender would know that they aren't needed.
BUG=1420
TEST=video_coding_unittests, vie_auto_test, video_coding_integrationtests, trybots
Review URL: https://webrtc-codereview.appspot.com/1115006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3599 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-04 15:24:40 +00:00
7d052c3cb2
Turn off error concealment in videoprocessor_integration tests.
...
Review URL: https://webrtc-codereview.appspot.com/1123006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3581 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-28 16:44:28 +00:00
9e254133ad
Rewrite the jitter buffer statistics test and put make it robust under valgrind.
...
BUG=1158
Review URL: https://webrtc-codereview.appspot.com/1116008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3579 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-28 08:45:23 +00:00
ac1f877a5e
Remove unneeded libvpx path from vp8 include_dirs.
...
This is already provided by libvpx.gyp.
BUG=webrtc:1428
Review URL: https://webrtc-codereview.appspot.com/1139004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3568 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-25 17:10:38 +00:00
8a0662306d
New attempt at fixing hard-coded libvpx source.
...
TBR=ajm@webrtc.org
BUG=1428
Review URL: https://webrtc-codereview.appspot.com/1138004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3566 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-25 15:05:01 +00:00
9a6623b629
Revert "Fixing hard-coded libvpx source path."
...
This reverts commit 1c603646da11971f13d66a75da31ebbb6eff37d9.
TBR=phoglund@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/1137004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3565 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-25 14:27:14 +00:00
8571c90c7f
Fixing hard-coded libvpx source path.
...
BUG=1428
TBR=ajm@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1127006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3564 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-25 14:09:12 +00:00
95b48c3551
Update to codec unit test:
...
enable frame dropper for rate control test.
Review URL: https://webrtc-codereview.appspot.com/1099014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3536 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-19 20:02:32 +00:00
eb91792cfd
Refactoring temporal layers implementation and adding VideoCodecMode for easier control of codec settings.
...
Review URL: https://webrtc-codereview.appspot.com/1105007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3528 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-18 14:40:18 +00:00
e3d6ffede4
Increase threshold in codec unit test.
...
Review URL: https://webrtc-codereview.appspot.com/1096011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3526 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-15 23:31:17 +00:00
ef9f76a59d
Adding a receive side API for buffering mode.
...
At the same time, renaming the send side API.
Review URL: https://webrtc-codereview.appspot.com/1104004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3525 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-15 23:22:18 +00:00
9c4e662ea8
Fix Windows x64 errors in video_codecs_test_framework
...
Fixed a few size_t converted to int warnings (interpreted as errors).
Fixed cpplint warnings.
BUG=webrtc:1323
TEST=manual compile on Windows with GYP_DEFINES=target_arch=x64 and
ninja -C out\Debug_x64 (also compiled with Release_x64)
Review URL: https://webrtc-codereview.appspot.com/1097011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3507 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-13 09:35:12 +00:00
57a0049e25
VCM: Removing frame drop enable from Reset call
...
BUG = 1387
Review URL: https://webrtc-codereview.appspot.com/1097010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3500 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-11 21:23:23 +00:00
63066f7200
Set qpMax to 56 in for all VP8 tests. Fixes buildbot breakage.
...
TBR=mikhal@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1098010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3493 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-11 08:27:33 +00:00
3d305c64b4
Updates to send side streaming mode:
...
1. Disabling frame-droppers from the vie encoder and not the channel.
2. Accounting for qpMax in the VP8 wrapper.
Review URL: https://webrtc-codereview.appspot.com/1101007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3492 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-10 18:42:55 +00:00
b64732abfc
Fix Win64 build breakage
...
This is for landing https://webrtc-codereview.appspot.com/1096006/ by Justin Schuh.
Stable will be updated after this has landed.
Review URL: https://webrtc-codereview.appspot.com/1091008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3484 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-07 10:14:05 +00:00
fa53d8717c
Fixing/disabling Windows x64 warnings
...
Disabled MSVC #4267 warnings in common.gypi to enable x64 builds
for Windows.
Fixed MSVC #4267 warnings in test/testsupport.
Added third_party/directxsdk to .gitignore.
With http://review.webrtc.org/1070008 landed, this should make it possible
to build for x64 on Windows.
BUG=1348
TEST=Compiling with http://review.webrtc.org/1070008 applied:
set GYP_DEFINES="target_arch=x64"
set GYP_GENERATORS=ninja
gclient sync
ninja -C out\Debug_x64
Review URL: https://webrtc-codereview.appspot.com/1060008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3464 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-04 10:07:17 +00:00
becf9c897c
Fix mismatch between different NACK list lengths and packet buffers.
...
This is a second version of http://review.webrtc.org/1065006/ which passes the parameters via methods instead of via constructors.
BUG=1289
Review URL: https://webrtc-codereview.appspot.com/1065007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3456 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-01 15:09:57 +00:00
119c67df36
Adding a max jitter filter to the JB estimate - allowing two modes, one will return the last estimate (current setting), and another will return the max value seen, and allow setting an initial value.
...
This cl also includes tests and some clean up.
Review URL: https://webrtc-codereview.appspot.com/1019007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3445 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-31 17:18:02 +00:00
e07c661a29
VP8: Making key frame interval a tunnable parameter
...
Review URL: https://webrtc-codereview.appspot.com/1070006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3444 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-31 16:37:13 +00:00
bf535b9b6b
Optimize NACK list creation.
...
- No longer looping through all frame buffers.
- Keeping track of the current nack list index when building the list.
- Don't look for changes in the NACK list if the size has increased.
Review URL: https://webrtc-codereview.appspot.com/1076005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3420 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-28 08:48:13 +00:00
b2d7497faf
Fix Win64 warnings
...
This change fixes warnings about converting size_t to int.
BUG=webrtc:1323
TEST=trybots passing
Review URL: https://webrtc-codereview.appspot.com/1064004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3419 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-26 16:36:40 +00:00
a678a3baee
Move video_coding to new Clock interface and remove fake clock implementations from RTP module tests.
...
TEST=video_coding_unittests, video_coding_integrationtests, rtp_rtcp_unittests, trybots
Review URL: https://webrtc-codereview.appspot.com/1044004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3393 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-21 07:42:11 +00:00
a3c82bf667
Remove '<(library)' in gyp files.
...
This will remove all usage of '<(library)' in all webrtc gyp files.
Review URL: https://webrtc-codereview.appspot.com/1049005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3392 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-18 23:42:21 +00:00
a4b58860b7
Add a counter to the video rtp play output filename.
...
Review URL: https://webrtc-codereview.appspot.com/1040004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3379 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-17 09:27:17 +00:00
ef1a760446
Rounding error fix in media_opt_util.
...
Review URL: https://webrtc-codereview.appspot.com/1013006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3351 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-09 22:13:19 +00:00
658d423e81
Using Convert in lieu of ExtractBuffer: Less error prone (as we don't need to compute buffer sizes etc.). This cl is first in a series (doing all of WebRtc would make it quite a big cl). While at it, fixing a few headers.
...
BUG=988
Review URL: https://webrtc-codereview.appspot.com/995014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3343 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-08 19:19:59 +00:00
1ea4b502ef
Refactor receiver.h/.cc.
...
TEST=video_coding_unittests, vie_auto_test --automated
Review URL: https://webrtc-codereview.appspot.com/994008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3336 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-07 08:49:41 +00:00
a8544eaf03
Vp8 tests: Removing legacy unused tests and reorganization of existing ones.
...
Review URL: https://webrtc-codereview.appspot.com/972013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3276 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-13 00:37:22 +00:00
f222a00881
Use TRACE_EVENT to track time spent in VP8 encoding
...
Using the TRACE_EVENT macro to log VP8 encoding events.
Review URL: https://webrtc-codereview.appspot.com/968011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3264 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-11 22:27:55 +00:00