73276ad7ed1e70ab764cd02d7189ed5839fadc20
22 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
| 9a85f0782e |
Enhance RTCUIApplicationStatusObserver thread safety.
Add locking around waiting for initialization to finish, since calling dispatch_block_wait from multiple threads leads to undefined behavior. Initialize RTCUIApplicationStatusObserver earlier to give the initialization block more time to run on the main thread before starting to query the application state. http://www.dailymotion.com/video/x2mckmh BUG=b/65558688 Review-Url: https://codereview.webrtc.org/3009383002 Cr-Commit-Position: refs/heads/master@{#19822} |
|||
| 4090f380e5 |
Fix retain cycles in RTCUIApplicationStatusObserver.
These retain cycles are theoretical since the singleton is supposed to live for the lifetime of the application. These measures were removed earlier when the object was turned into a singleton in a previous CL, see https://chromium-review.googlesource.com/c/external/webrtc/+/527442/3..4/webrtc/sdk/objc/Framework/Classes/Common/RTCUIApplicationStatusObserver.m The weak self handling and unused dealloc method is mostly noise and can make a casual reader think that the object will have a limited life cycle, i.e. the code may initially look like something it is not, which could possibly be less readable. On the other hand, for people looking out for potential retain cycles, the code may be distracting since it looks like it may be leaking. BUG=b/65558647 Review-Url: https://codereview.webrtc.org/3013023002 Cr-Commit-Position: refs/heads/master@{#19811} |
|||
| cfab6c7c04 |
Increase timeout in RTCUIApplicationStatusObserver
Increase timeout since the wait function timed out in certain debugging circumstances. Also change the check to a DCHECK since it is not really a critical error if it would time out. BUG=None Review-Url: https://codereview.webrtc.org/3007773002 Cr-Commit-Position: refs/heads/master@{#19582} |
|||
| cca0006e33 |
ObjC: Always dispatch async in UIApplication status observer.
Fixes a possible deadlock. BUG=webrtc:8130 Review-Url: https://codereview.webrtc.org/3003633002 Cr-Commit-Position: refs/heads/master@{#19464} |
|||
| fb143127d7 |
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2980173002/ )
Reason for revert: Relanding after fixing issues with no video. Original issue's description: > Revert of Injectable Obj-C video codecs (patchset #2 id:370001 of https://codereview.webrtc.org/2979983002/ ) > > Reason for revert: > Still having problems with no video. Reverting. > Once no video is visible, no video is available from then on even if the callee app is in the foreground. > > > Original issue's description: > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2979973002/ ) > > > > Reason for revert: > > Fix the broken build file > > > > Original issue's description: > > > Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of https://codereview.webrtc.org/2981583002/ ) > > > > > > Reason for revert: > > > Breaks bots. Build file incorrect. > > > > > > Original issue's description: > > > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ ) > > > > > > > > Reason for revert: > > > > New CL for fixing the issues > > > > > > > > Original issue's description: > > > > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ ) > > > > > > > > > > Reason for revert: > > > > > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future. > > > > > > > > > > Original issue's description: > > > > > > Injectable Obj-C video codecs > > > > > > > > > > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264 > > > > > > (wrapping the VideoToolbox codec). > > > > > > > > > > > > Some notes / things left to do: > > > > > > - There are some hard-coded references to codec types that are supported by > > > > > > webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc > > > > > > since we need to convert to/from these types in ObjCVideoEncoder/Decoder. > > > > > > These types would need to be more codec agnostic to avoid this. > > > > > > - Most interfaces are borrowed from the design document for injectable > > > > > > codecs in Android. Some data in the corresponding C++ classes is discarded > > > > > > when converting to the Obj-C version, since it has fewer fields. I have not > > > > > > verified whether all data that we do keep is needed, or whether we might be > > > > > > losing anything useful in these conversions. > > > > > > - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264 > > > > > > classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder. > > > > > > Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/ > > > > > > Decoder wrapper classes. > > > > > > - List the injected codec factory's supported codecs in the list of codecs in > > > > > > AppRTCMobile. > > > > > > > > > > > > BUG=webrtc:7924 > > > > > > R=magjed@webrtc.org > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2966023002 . > > > > > > Cr-Commit-Position: refs/heads/master@{#18928} > > > > > > Committed: |
|||
| 860f729816 |
Revert of Injectable Obj-C video codecs (patchset #2 id:370001 of https://codereview.webrtc.org/2979983002/ )
Reason for revert: Still having problems with no video. Reverting. Once no video is visible, no video is available from then on even if the callee app is in the foreground. Original issue's description: > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2979973002/ ) > > Reason for revert: > Fix the broken build file > > Original issue's description: > > Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of https://codereview.webrtc.org/2981583002/ ) > > > > Reason for revert: > > Breaks bots. Build file incorrect. > > > > Original issue's description: > > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ ) > > > > > > Reason for revert: > > > New CL for fixing the issues > > > > > > Original issue's description: > > > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ ) > > > > > > > > Reason for revert: > > > > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future. > > > > > > > > Original issue's description: > > > > > Injectable Obj-C video codecs > > > > > > > > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264 > > > > > (wrapping the VideoToolbox codec). > > > > > > > > > > Some notes / things left to do: > > > > > - There are some hard-coded references to codec types that are supported by > > > > > webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc > > > > > since we need to convert to/from these types in ObjCVideoEncoder/Decoder. > > > > > These types would need to be more codec agnostic to avoid this. > > > > > - Most interfaces are borrowed from the design document for injectable > > > > > codecs in Android. Some data in the corresponding C++ classes is discarded > > > > > when converting to the Obj-C version, since it has fewer fields. I have not > > > > > verified whether all data that we do keep is needed, or whether we might be > > > > > losing anything useful in these conversions. > > > > > - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264 > > > > > classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder. > > > > > Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/ > > > > > Decoder wrapper classes. > > > > > - List the injected codec factory's supported codecs in the list of codecs in > > > > > AppRTCMobile. > > > > > > > > > > BUG=webrtc:7924 > > > > > R=magjed@webrtc.org > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2966023002 . > > > > > Cr-Commit-Position: refs/heads/master@{#18928} > > > > > Committed: |
|||
| 732a3437da |
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2979973002/ )
Reason for revert: Fix the broken build file Original issue's description: > Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of https://codereview.webrtc.org/2981583002/ ) > > Reason for revert: > Breaks bots. Build file incorrect. > > Original issue's description: > > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ ) > > > > Reason for revert: > > New CL for fixing the issues > > > > Original issue's description: > > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ ) > > > > > > Reason for revert: > > > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future. > > > > > > Original issue's description: > > > > Injectable Obj-C video codecs > > > > > > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264 > > > > (wrapping the VideoToolbox codec). > > > > > > > > Some notes / things left to do: > > > > - There are some hard-coded references to codec types that are supported by > > > > webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc > > > > since we need to convert to/from these types in ObjCVideoEncoder/Decoder. > > > > These types would need to be more codec agnostic to avoid this. > > > > - Most interfaces are borrowed from the design document for injectable > > > > codecs in Android. Some data in the corresponding C++ classes is discarded > > > > when converting to the Obj-C version, since it has fewer fields. I have not > > > > verified whether all data that we do keep is needed, or whether we might be > > > > losing anything useful in these conversions. > > > > - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264 > > > > classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder. > > > > Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/ > > > > Decoder wrapper classes. > > > > - List the injected codec factory's supported codecs in the list of codecs in > > > > AppRTCMobile. > > > > > > > > BUG=webrtc:7924 > > > > R=magjed@webrtc.org > > > > > > > > Review-Url: https://codereview.webrtc.org/2966023002 . > > > > Cr-Commit-Position: refs/heads/master@{#18928} > > > > Committed: |
|||
| 81d40ee149 |
Revert of Injectable Obj-C video codecs (patchset #3 id:400001 of https://codereview.webrtc.org/2981583002/ )
Reason for revert: Breaks bots. Build file incorrect. Original issue's description: > Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ ) > > Reason for revert: > New CL for fixing the issues > > Original issue's description: > > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ ) > > > > Reason for revert: > > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future. > > > > Original issue's description: > > > Injectable Obj-C video codecs > > > > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264 > > > (wrapping the VideoToolbox codec). > > > > > > Some notes / things left to do: > > > - There are some hard-coded references to codec types that are supported by > > > webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc > > > since we need to convert to/from these types in ObjCVideoEncoder/Decoder. > > > These types would need to be more codec agnostic to avoid this. > > > - Most interfaces are borrowed from the design document for injectable > > > codecs in Android. Some data in the corresponding C++ classes is discarded > > > when converting to the Obj-C version, since it has fewer fields. I have not > > > verified whether all data that we do keep is needed, or whether we might be > > > losing anything useful in these conversions. > > > - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264 > > > classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder. > > > Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/ > > > Decoder wrapper classes. > > > - List the injected codec factory's supported codecs in the list of codecs in > > > AppRTCMobile. > > > > > > BUG=webrtc:7924 > > > R=magjed@webrtc.org > > > > > > Review-Url: https://codereview.webrtc.org/2966023002 . > > > Cr-Commit-Position: refs/heads/master@{#18928} > > > Committed: |
|||
| a5f1de1e65 |
Reland of Injectable Obj-C video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2975963002/ )
Reason for revert: New CL for fixing the issues Original issue's description: > Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ ) > > Reason for revert: > Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future. > > Original issue's description: > > Injectable Obj-C video codecs > > > > Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264 > > (wrapping the VideoToolbox codec). > > > > Some notes / things left to do: > > - There are some hard-coded references to codec types that are supported by > > webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc > > since we need to convert to/from these types in ObjCVideoEncoder/Decoder. > > These types would need to be more codec agnostic to avoid this. > > - Most interfaces are borrowed from the design document for injectable > > codecs in Android. Some data in the corresponding C++ classes is discarded > > when converting to the Obj-C version, since it has fewer fields. I have not > > verified whether all data that we do keep is needed, or whether we might be > > losing anything useful in these conversions. > > - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264 > > classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder. > > Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/ > > Decoder wrapper classes. > > - List the injected codec factory's supported codecs in the list of codecs in > > AppRTCMobile. > > > > BUG=webrtc:7924 > > R=magjed@webrtc.org > > > > Review-Url: https://codereview.webrtc.org/2966023002 . > > Cr-Commit-Position: refs/heads/master@{#18928} > > Committed: |
|||
| 1095ada7ad |
Revert of Injectable Obj-C video codecs (patchset #8 id:140001 of https://codereview.webrtc.org/2966023002/ )
Reason for revert:
Causes no video in certain scenarios. Please come up with a test plan or unit test to prevent such problems in the future.
Original issue's description:
> Injectable Obj-C video codecs
>
> Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
> (wrapping the VideoToolbox codec).
>
> Some notes / things left to do:
> - There are some hard-coded references to codec types that are supported by
> webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
> since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
> These types would need to be more codec agnostic to avoid this.
> - Most interfaces are borrowed from the design document for injectable
> codecs in Android. Some data in the corresponding C++ classes is discarded
> when converting to the Obj-C version, since it has fewer fields. I have not
> verified whether all data that we do keep is needed, or whether we might be
> losing anything useful in these conversions.
> - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
> classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
> Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
> Decoder wrapper classes.
> - List the injected codec factory's supported codecs in the list of codecs in
> AppRTCMobile.
>
> BUG=webrtc:7924
> R=magjed@webrtc.org
>
> Review-Url: https://codereview.webrtc.org/2966023002 .
> Cr-Commit-Position: refs/heads/master@{#18928}
> Committed:
|
|||
| a0349c138d |
Injectable Obj-C video codecs
Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
(wrapping the VideoToolbox codec).
Some notes / things left to do:
- There are some hard-coded references to codec types that are supported by
webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
These types would need to be more codec agnostic to avoid this.
- Most interfaces are borrowed from the design document for injectable
codecs in Android. Some data in the corresponding C++ classes is discarded
when converting to the Obj-C version, since it has fewer fields. I have not
verified whether all data that we do keep is needed, or whether we might be
losing anything useful in these conversions.
- Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
Decoder wrapper classes.
- List the injected codec factory's supported codecs in the list of codecs in
AppRTCMobile.
BUG=webrtc:7924
R=magjed@webrtc.org
Review-Url: https://codereview.webrtc.org/2966023002 .
Cr-Commit-Position: refs/heads/master@{#18928}
|
|||
| eaaae9e91b |
base->rtc_base: Update .c, .mm and .java files.
TBR=kwiberg@webrtc.org BUG=webrtc:7634 Review-Url: https://codereview.webrtc.org/2974613003 Cr-Commit-Position: refs/heads/master@{#18926} |
|||
| fc309750a9 |
Access UIApplication on main thread
Track UIApplication applicationState changes from a C++ class. Uses NSNotificationCenter to access changes on the main thread and exposes a local variable that can be checked from any thread. This fixes a runtime warning on iOS 11 beta. My Objective-C++ is a little rusty so please check if this follows the conventions for C++ code in the project. It also changes the interface exposed by RTCUIApplication.h, not sure if that has impact on any public APIs that needs to be documented somewhere? Bug: webrtc:7773 Change-Id: I9c8ba090ef9f28d812114026a906cef742192c39 Reviewed-on: https://chromium-review.googlesource.com/527442 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Kári Tristan Helgason <kthelgason@webrtc.org> Commit-Queue: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18558} |
|||
| 6d3e866ab1 |
Fix spelling mistake in field trial key name.
TBR=peah@webrtc.org, magjed@webrtc.org Bug: None Change-Id: Id0ba96387dcaa41b8821245a067ca08d6740bf62 Notry: true Reviewed-on: https://chromium-review.googlesource.com/519388 Commit-Queue: Kári Tristan Helgason <kthelgason@webrtc.org> Reviewed-by: Kári Tristan Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18356} |
|||
| 0a0a2f12b3 |
Add back key for AGC field trial.
It seems it got lost in a rebase with this CL: https://codereview.webrtc.org/2893843003/ Bug: None Change-Id: Iaf4952593c1a1a9490d31c595b05ab155c0a809e Reviewed-on: https://chromium-review.googlesource.com/519167 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Kári Tristan Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18353} |
|||
| 2f08879fb1 |
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ )
Reason for revert: Take three of relanding this after all internal issues have been resolved. Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ ) > > Reason for revert: > Breaks downstream project. > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > > > Reason for revert: > > Take two of fixing downstream issues? > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > > > Reason for revert: > > > Still problems with downstream projects > > > > > > Original issue's description: > > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > > > Reason for revert: > > > > Fixing downstream breakages > > > > > > > > Original issue's description: > > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > > > Reason for revert: > > > > > Breaking downstream projects. > > > > > > > > > > Original issue's description: > > > > > > Split iOS sdk in to separate targets > > > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > > Committed: |
|||
| af5c05540c |
Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ )
Reason for revert: Breaks downstream project. Original issue's description: > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ ) > > Reason for revert: > Take two of fixing downstream issues? > > Original issue's description: > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > > > Reason for revert: > > Still problems with downstream projects > > > > Original issue's description: > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > > > Reason for revert: > > > Fixing downstream breakages > > > > > > Original issue's description: > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > > > Reason for revert: > > > > Breaking downstream projects. > > > > > > > > Original issue's description: > > > > > Split iOS sdk in to separate targets > > > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > > > BUG=webrtc:4867 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > > Committed: |
|||
| 580c3522d2 |
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ )
Reason for revert: Take two of fixing downstream issues? Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ ) > > Reason for revert: > Still problems with downstream projects > > Original issue's description: > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > > > Reason for revert: > > Fixing downstream breakages > > > > Original issue's description: > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > > > Reason for revert: > > > Breaking downstream projects. > > > > > > Original issue's description: > > > > Split iOS sdk in to separate targets > > > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > > audio, ui, common, and peerconnection-related code. This will in the > > > > future make it easier to compile WebRTC without unneeded components. > > > > > > > > BUG=webrtc:4867 > > > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > > Committed: |
|||
| 37144b214e |
Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ )
Reason for revert: Still problems with downstream projects Original issue's description: > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ ) > > Reason for revert: > Fixing downstream breakages > > Original issue's description: > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > > > Reason for revert: > > Breaking downstream projects. > > > > Original issue's description: > > > Split iOS sdk in to separate targets > > > > > > This CL splits the iOS sdk into separate static libraries for video, > > > audio, ui, common, and peerconnection-related code. This will in the > > > future make it easier to compile WebRTC without unneeded components. > > > > > > BUG=webrtc:4867 > > > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > > Cr-Commit-Position: refs/heads/master@{#18166} > > > Committed: |
|||
| d51e042492 |
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ )
Reason for revert: Fixing downstream breakages Original issue's description: > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ ) > > Reason for revert: > Breaking downstream projects. > > Original issue's description: > > Split iOS sdk in to separate targets > > > > This CL splits the iOS sdk into separate static libraries for video, > > audio, ui, common, and peerconnection-related code. This will in the > > future make it easier to compile WebRTC without unneeded components. > > > > BUG=webrtc:4867 > > > > Review-Url: https://codereview.webrtc.org/2862543002 > > Cr-Commit-Position: refs/heads/master@{#18166} > > Committed: |
|||
| 9756238084 |
Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ )
Reason for revert:
Breaking downstream projects.
Original issue's description:
> Split iOS sdk in to separate targets
>
> This CL splits the iOS sdk into separate static libraries for video,
> audio, ui, common, and peerconnection-related code. This will in the
> future make it easier to compile WebRTC without unneeded components.
>
> BUG=webrtc:4867
>
> Review-Url: https://codereview.webrtc.org/2862543002
> Cr-Commit-Position: refs/heads/master@{#18166}
> Committed:
|
|||
| 52c83fe710 |
Split iOS sdk in to separate targets
This CL splits the iOS sdk into separate static libraries for video, audio, ui, common, and peerconnection-related code. This will in the future make it easier to compile WebRTC without unneeded components. BUG=webrtc:4867 Review-Url: https://codereview.webrtc.org/2862543002 Cr-Commit-Position: refs/heads/master@{#18166} |
