6136fdb287
Whitespace change
...
Bug: None
TBR: mbonadei@webrtc.org
No-Try: True
Change-Id: I0a93a68610bb4837be4fff6550675759ee1f59b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167529
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30388}
2020-01-28 07:53:15 +00:00
8a6f9a03f0
Export IceParameters::Parse for use in Chrome
...
Bug: chromium:1044521
Change-Id: I7c6fb0ba5ac918858ed65f9fe503c4de6f6acce5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167683
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30387}
2020-01-28 01:46:04 +00:00
11b66cf110
Roll chromium_revision 5a8e8ca513..0168397940 (735421:735581)
...
Change log: 5a8e8ca513..0168397940
Full diff: 5a8e8ca513..0168397940
Changed dependencies
* src/base: 939b5844e6..e65cf566c2
* src/build: 83cc2ebf32..e996a848b0
* src/ios: b9ca807521..d2debbb1b0
* src/testing: f37f2d115c..c9b319f108
* src/third_party: 87b241ffe2..9d6f0a885b
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d93fde1cd5..3906f655f4
* src/third_party/depot_tools: 0aa48cc1de..f437869d41
* src/third_party/libvpx/source/libvpx: 7763c888e0..4254ecaa07
* src/tools: 5d93d4e276..d0ce076f32
DEPS diff: 5a8e8ca513..0168397940
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,marpan@webrtc.org , jianj@chromium.org ,
BUG=None
Change-Id: Ife5209fac61ef0b698ca0a54dc5cae47be711208
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167681
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30386}
2020-01-27 23:01:12 +00:00
17a6381c1c
Adds fake video codec mode to PeerScenarioClient
...
This improves execution speed by skipping the encoding step.
Bug: webrtc:10365
Change-Id: I6aef1376c157d859f05f4a44f881d1c60f353067
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167082
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30385}
2020-01-27 18:07:45 +00:00
2e4f440fde
Roll chromium_revision 08a3245b28..5a8e8ca513 (735303:735421)
...
Change log: 08a3245b28..5a8e8ca513
Full diff: 08a3245b28..5a8e8ca513
Changed dependencies
* src/base: b97b755f7b..939b5844e6
* src/build: cbcd766952..83cc2ebf32
* src/ios: e7e769c1c8..b9ca807521
* src/third_party: 4ec85c3ce8..87b241ffe2
* src/third_party/harfbuzz-ng/src: 82545c5e2b..5440313924
* src/tools: 06243dfa4f..5d93d4e276
DEPS diff: 08a3245b28..5a8e8ca513
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: If691c44d238ca18192b7b1b165d2dbc58ab8fbd6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167600
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30384}
2020-01-27 16:44:10 +00:00
c709412c76
Revert "Only include overhead if using send side bandwidth estimation."
...
This reverts commit 8c79c6e1af354c526497082c79ccbe12af03a33e.
Reason for revert: Introduced a Bug that can happen if the include overhead state changes between pushing and poping a packet from the pacer packet queue.
Original change's description:
> Only include overhead if using send side bandwidth estimation.
>
> Bug: webrtc:11298
> Change-Id: Ia2daf690461b55d394c1b964d6a7977a98be8be2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166820
> Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
> Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> Reviewed-by: Ali Tofigh <alito@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30382}
TBR=saza@webrtc.org ,ossu@webrtc.org ,sprang@webrtc.org ,srte@webrtc.org ,alito@webrtc.org
Change-Id: I0cacbc26408b7bec5bc3855a628e62407c081117
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11298
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167523
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30383}
2020-01-27 15:09:49 +00:00
8c79c6e1af
Only include overhead if using send side bandwidth estimation.
...
Bug: webrtc:11298
Change-Id: Ia2daf690461b55d394c1b964d6a7977a98be8be2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166820
Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Ali Tofigh <alito@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30382}
2020-01-27 14:19:54 +00:00
ad515a255b
[Overuse] Move GetCpuOveruseOptions() to adaption module.
...
This removes the last remaining explicit reference from
OveruseFrameDetectorResourceAdaptationModule to
VideoStreamEncoder.
VideoStreamEncoder's call to SetEncoderSettings() inside
ReconfigureEncoder() is moved a few lines down - it was discovered that
during these lines the EncoderInfo config could get modified in
response to InitEncode() - so this fixes a potential bug.
Bug: webrtc:11222
Change-Id: I9746f28a4df8e631e297669c10636bf17b39acec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167363
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Evan Shrubsole <eshr@google.com >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30381}
2020-01-27 13:51:40 +00:00
ff0e4dbd1f
Reland "Send absolute capture time through audio coding module."
...
This is a reland of 48655cfdbfd99e0b6331e59201bcb8514f8b2a0a
Original change's description:
> Send absolute capture time through audio coding module.
>
> Bug: webrtc:10739
> Change-Id: I44e0305be7c84b253172511c2977b1d700e40c1b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167067
> Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> Reviewed-by: Chen Xing <chxg@google.com >
> Commit-Queue: Minyue Li <minyue@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30363}
Bug: webrtc:10739
Change-Id: I10086d239ad3f1efb8485098bf3b0ad23110962b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167213
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Chen Xing <chxg@google.com >
Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
Commit-Queue: Minyue Li <minyue@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30380}
2020-01-27 13:18:27 +00:00
6c9bc396e9
Cleanup log formatting in modules/audio_processing
...
Bug: None
Change-Id: I47177530d8a85d7b2f143081de71f5a3bf8ec354
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166041
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30379}
2020-01-27 09:42:56 +00:00
9c0a83ea4d
Remove strip_absolute_paths_from_debug_symbols from mb.
...
Getting failures on more_configs bots, e.g.
https://ci.chromium.org/p/webrtc/builders/try/android_arm_more_configs/16421
Appears strip_absolute_paths_from_debug_symbols has changed behavior.
It's now forced on if the platform does it by default and not
configurable. Therefore our bots can't set it explictly on most
platforms.
Bug: None
Change-Id: I112dbb18f9d19ba3dc645a6ae640098afac3c408
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167520
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30378}
2020-01-27 09:17:46 +00:00
c99afa0628
Roll chromium_revision 812b6f8943..08a3245b28 (735202:735303)
...
Change log: 812b6f8943..08a3245b28
Full diff: 812b6f8943..08a3245b28
Changed dependencies
* src/build: 00863bc5a5..cbcd766952
* src/ios: 71cb14cc3a..e7e769c1c8
* src/third_party: 7ce74865ec..4ec85c3ce8
* src/third_party/depot_tools: bf4e7a722b..0aa48cc1de
* src/tools: cb743f7070..06243dfa4f
DEPS diff: 812b6f8943..08a3245b28
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Iae7818ed3ef49bffe6b27690827252ba21a34294
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167473
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30377}
2020-01-26 22:19:32 +00:00
4c4735bfcc
Roll chromium_revision c04519686a..812b6f8943 (734489:735202)
...
Change log: c04519686a..812b6f8943
Full diff: c04519686a..812b6f8943
Changed dependencies
* src/base: e1626e708d..b97b755f7b
* src/build: 08c5083ab8..00863bc5a5
* src/ios: 027fc768d4..71cb14cc3a
* src/testing: 8d8f6f0831..f37f2d115c
* src/third_party: 8966ce7713..7ce74865ec
* src/third_party/android_build_tools/bundletool: VVve-571EEzx-giwEOU0vCrIe9D9a_TjP6ka1GgeVSUC..P0-ZY8wc-hAu5TZYFH7bId8H9Ucy7mNGCg1IPzXuZpEC
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_annotation: version:2.3.3-cr0..version:2.3.4-cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_annotations: version:2.3.3-cr0..version:2.3.4-cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_check_api: version:2.3.3-cr0..version:2.3.4-cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_core: version:2.3.3-cr0..version:2.3.4-cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_type_annotations: version:2.3.3-cr0..version:2.3.4-cr0
* src/third_party/android_deps/libs/org_checkerframework_checker_qual: version:2.5.3-cr0..version:3.0.0-cr0
* src/third_party/android_deps/libs/org_checkerframework_dataflow: version:2.5.3-cr0..version:3.0.0-cr0
* src/third_party/android_deps/libs/org_checkerframework_javacutil: version:2.5.3-cr0..version:3.0.0-cr0
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/89730072b8..1cc95ac07c
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/68125d9096..d93fde1cd5
* src/third_party/depot_tools: bdd89366d3..bf4e7a722b
* src/third_party/lss: https://chromium.googlesource.com/linux-syscall-support.git/+log/7bde79cc27..f70e2f1641
* src/tools: 1a4aa4db04..cb743f7070
Added dependencies
* src/third_party/android_deps/libs/com_github_ben_manes_caffeine_caffeine
* src/third_party/android_deps/libs/org_plumelib_require_javadoc
* src/third_party/android_deps/libs/org_plumelib_reflection_util
* src/third_party/android_deps/libs/org_plumelib_plume_util
Removed dependency
* src/third_party/android_deps/libs/com_github_stephenc_jcip_jcip_annotations
DEPS diff: c04519686a..812b6f8943
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ia764fcff235a34e69432aadabe058689e4a308f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167423
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30376}
2020-01-25 02:37:26 +00:00
71ff073698
Validate ICE ufrag/pwd according to the spec
...
https://tools.ietf.org/html/draft-ietf-mmusic-ice-sip-sdp-39#section-5.4
Bug: chromium:1044521
Change-Id: Ia95718437dfc270b52cdf822e861a3da7cbbab76
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167281
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30375}
2020-01-25 01:38:50 +00:00
f3886aea86
Include cursor rects in updated_region.
...
DesktopAndCursorComposer adds the cursor image to the desktop, but does
not change the updated_region, so it generally doesn't encode correctly
unless the mouse is moving over a region that is changing. This CL
extends the updated region to include the union of the old and new
cursor rects, with an optimization for the case where the cursor has
neither moved nor changed.
Bug: chromium:1043325
Change-Id: I52076c96528820833fda6aa95f5b1fbc0f613909
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166545
Reviewed-by: Sergey Ulanov <sergeyu@google.com >
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org >
Cr-Commit-Position: refs/heads/master@{#30374}
2020-01-24 20:16:58 +00:00
a104ceb0ce
Revert "Reland "Reland "Distinguish between send and receive codecs"""
...
This reverts commit 9bac68c0cc4444b852416396f0e0f31ea66a9cfe.
Reason for revert: Breaks perf test on iOS.
Original change's description:
> Reland "Reland "Distinguish between send and receive codecs""
>
> This reverts commit 00a30873c415d717af8dcdf21c2df7fd4b6d1ed2.
>
> Reason for revert: Flaky test in Chromium fixed.
>
> Original change's description:
> > Revert "Reland "Distinguish between send and receive codecs""
> >
> > This reverts commit 133bf2bd28596aab5c7684e0ea3da99b1fece77f.
> >
> > Reason for revert: Breaks Chromium import due to flaky test in Chromium.
> >
> > Original change's description:
> > > Reland "Distinguish between send and receive codecs"
> > >
> > > This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
> > >
> > > Reason for revert: Fixed negotiation of send-only clients.
> > >
> > > Original change's description:
> > > > Revert "Distinguish between send and receive codecs"
> > > >
> > > > This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
> > > >
> > > > Reason for revert: breaks negotiation with send-only clients
> > > >
> > > > (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> > > > (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> > > > (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
> > > >
> > > > Original change's description:
> > > > > Distinguish between send and receive codecs
> > > > >
> > > > > Even though send and receive codecs may be the same, they might have
> > > > > different support in HW. Distinguish between send and receive codecs
> > > > > to be able to keep track of which codecs have HW support.
> > > > >
> > > > > Bug: chromium:1029737
> > > > > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30284}
> > > >
> > > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > > >
> > > > Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: chromium:1029737
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Commit-Queue: Steve Anton <steveanton@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30292}
> > >
> > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > >
> > >
> > > Bug: chromium:1029737
> > > Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30348}
> >
> > TBR=steveanton@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: I9f8731309749e07ce7e651e1550ecfabddb1735f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167205
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30360}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
> Change-Id: I1cc2d83bd884f10685503a9c31288f96c935d6a3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167206
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30367}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Change-Id: I0a9b0b58922ce7c558b3d31b64cc12086b2a6a55
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167364
Commit-Queue: Johannes Kron <kron@webrtc.org >
Reviewed-by: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30373}
2020-01-24 16:44:17 +00:00
b039c30157
Reland "Change log level of AEC3 buffer info to VERBOSE"
...
This is a reland of 48148dc840f66c5f6adc5e2ba01c15104e0a9bab
Original change's description:
> Change log level of AEC3 buffer info to VERBOSE
>
> Otherwise, test logs become very verbose:
> https://chrome-swarming.appspot.com/task?id=49b6fa6ac93e2310
> See linked issue.
>
> Bug: webrtc:11278
> Change-Id: I778ee4826de6c1b23d47a5d5ce302d074900ce6b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165786
> Reviewed-by: Per Åhgren <peah@webrtc.org >
> Commit-Queue: Sam Zackrisson <saza@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30233}
Bug: webrtc:11278, webrtc:11295
Change-Id: I8e6f11457e283c83cae5581adcacdc4d3b5431bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167360
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30372}
2020-01-24 12:58:08 +00:00
1e02339ea6
Add ability to set custom adapter type on emulated endpoint
...
Bug: webrtc:10138
Change-Id: I2f53b42a2c377c9c0c9d36b61eb1c6ce96da480a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167209
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30371}
2020-01-24 12:53:07 +00:00
b18c4eb0a9
Add parameterization for three multi channel AEC3 unit tests
...
Bug: webrtc:11295
Change-Id: I478aa02908c494cf9609db00021438a59a132b66
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167202
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30370}
2020-01-24 12:26:46 +00:00
159c414ff8
Detach LossNotificationController from RtpGenericFrameDescriptor
...
To allow to use the LossNotificationController with
an updated version of the frame descriptor extension
Bug: webrtc:10342
Change-Id: I5ac44dc5549dfcfc73bf81ad1e8eab8bd5dd136e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166166
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30369}
2020-01-24 11:53:28 +00:00
88636c6dac
Improvements for NetEqControllers
...
When creating a NetEqController it can be useful to have access to a
webrtc::Clock*. Also, NetEqControllers should have access to the
contents of the sync buffer when making decisions.
Bug: webrtc:11005
Change-Id: I7fdba75ce661b2ace52458620a8c1f3c990e5ac2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167208
Commit-Queue: Ivo Creusen <ivoc@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30368}
2020-01-24 11:39:52 +00:00
9bac68c0cc
Reland "Reland "Distinguish between send and receive codecs""
...
This reverts commit 00a30873c415d717af8dcdf21c2df7fd4b6d1ed2.
Reason for revert: Flaky test in Chromium fixed.
Original change's description:
> Revert "Reland "Distinguish between send and receive codecs""
>
> This reverts commit 133bf2bd28596aab5c7684e0ea3da99b1fece77f.
>
> Reason for revert: Breaks Chromium import due to flaky test in Chromium.
>
> Original change's description:
> > Reland "Distinguish between send and receive codecs"
> >
> > This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
> >
> > Reason for revert: Fixed negotiation of send-only clients.
> >
> > Original change's description:
> > > Revert "Distinguish between send and receive codecs"
> > >
> > > This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
> > >
> > > Reason for revert: breaks negotiation with send-only clients
> > >
> > > (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> > > (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> > > (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
> > >
> > > Original change's description:
> > > > Distinguish between send and receive codecs
> > > >
> > > > Even though send and receive codecs may be the same, they might have
> > > > different support in HW. Distinguish between send and receive codecs
> > > > to be able to keep track of which codecs have HW support.
> > > >
> > > > Bug: chromium:1029737
> > > > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30284}
> > >
> > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Commit-Queue: Steve Anton <steveanton@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30292}
> >
> > TBR=steveanton@webrtc.org ,kron@webrtc.org
> >
> >
> > Bug: chromium:1029737
> > Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30348}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
> Change-Id: I9f8731309749e07ce7e651e1550ecfabddb1735f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167205
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30360}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Change-Id: I1cc2d83bd884f10685503a9c31288f96c935d6a3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167206
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30367}
2020-01-23 23:02:59 +00:00
760fd52494
Replace MockAudioDeviceModule mock refcounting with real refcounting
...
Bug: webrtc:11308
Change-Id: Ic55ec2c4b45f8fc709fe1348556bdeea6202e7a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166580
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30366}
2020-01-23 19:04:58 +00:00
40899b2797
Roll chromium_revision 487ee81fa3..c04519686a (734357:734489)
...
Change log: 487ee81fa3..c04519686a
Full diff: 487ee81fa3..c04519686a
Changed dependency
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6b345995a8..68125d9096
DEPS diff: 487ee81fa3..c04519686a
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ib06e84108ad18eb8093db654eb38f090ab7673d0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167221
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30365}
2020-01-23 16:40:14 +00:00
4175914f41
Revert "Send absolute capture time through audio coding module."
...
This reverts commit 48655cfdbfd99e0b6331e59201bcb8514f8b2a0a.
Reason for revert: failing upstream tests
Original change's description:
> Send absolute capture time through audio coding module.
>
> Bug: webrtc:10739
> Change-Id: I44e0305be7c84b253172511c2977b1d700e40c1b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167067
> Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> Reviewed-by: Chen Xing <chxg@google.com >
> Commit-Queue: Minyue Li <minyue@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30363}
TBR=danilchap@webrtc.org ,ossu@webrtc.org ,minyue@webrtc.org ,chxg@google.com
Change-Id: Ia36b9ae899563c9afd8612ffd83871b8a5778a2b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10739
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167212
Reviewed-by: Minyue Li <minyue@webrtc.org >
Commit-Queue: Minyue Li <minyue@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30364}
2020-01-23 16:21:06 +00:00
48655cfdbf
Send absolute capture time through audio coding module.
...
Bug: webrtc:10739
Change-Id: I44e0305be7c84b253172511c2977b1d700e40c1b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167067
Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Chen Xing <chxg@google.com >
Commit-Queue: Minyue Li <minyue@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30363}
2020-01-23 16:06:12 +00:00
cdd73e095c
Migrate PC level tests on new video codec configuration API
...
Bug: webrtc:10138
Change-Id: I7129857724aafbfae71f36554ef79be78c442cb6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167066
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30362}
2020-01-23 13:45:33 +00:00
02d51f9fdc
Remove unused field trial WebRTC-InitialFramedrop
...
Bug: webrtc:9176, webrtc:6086
Change-Id: Ie02800963f790f07b4c60ff01a04ecd6b5e1113d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167181
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@google.com >
Cr-Commit-Position: refs/heads/master@{#30361}
2020-01-23 13:42:03 +00:00
00a30873c4
Revert "Reland "Distinguish between send and receive codecs""
...
This reverts commit 133bf2bd28596aab5c7684e0ea3da99b1fece77f.
Reason for revert: Breaks Chromium import due to flaky test in Chromium.
Original change's description:
> Reland "Distinguish between send and receive codecs"
>
> This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
>
> Reason for revert: Fixed negotiation of send-only clients.
>
> Original change's description:
> > Revert "Distinguish between send and receive codecs"
> >
> > This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
> >
> > Reason for revert: breaks negotiation with send-only clients
> >
> > (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> > (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> > (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
> >
> > Original change's description:
> > > Distinguish between send and receive codecs
> > >
> > > Even though send and receive codecs may be the same, they might have
> > > different support in HW. Distinguish between send and receive codecs
> > > to be able to keep track of which codecs have HW support.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30284}
> >
> > TBR=steveanton@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Steve Anton <steveanton@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30292}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
>
> Bug: chromium:1029737
> Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30348}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Change-Id: I9f8731309749e07ce7e651e1550ecfabddb1735f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167205
Reviewed-by: Johannes Kron <kron@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30360}
2020-01-23 13:10:53 +00:00
897776e36c
Pass SDP video parameters to encoder.
...
Bug: webrtc:11265
Change-Id: I4f3373793de697e9d89c22ba2d9be4bfe571beea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167201
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30359}
2020-01-23 12:33:10 +00:00
7aa2edf936
Adds CreateTimeControllerBasedCallFactory.
...
Bug: webrtc:11255
Change-Id: I9614823761ff5d2eb4fe03342f255a81087b6449
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166960
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30358}
2020-01-23 10:29:30 +00:00
3c7e4dd85f
Revert "Change log level of AEC3 buffer info to VERBOSE"
...
This reverts commit 48148dc840f66c5f6adc5e2ba01c15104e0a9bab.
Reason for revert: Causing tests to timeout, see bugs.webrtc.org/11295
Original change's description:
> Change log level of AEC3 buffer info to VERBOSE
>
> Otherwise, test logs become very verbose:
> https://chrome-swarming.appspot.com/task?id=49b6fa6ac93e2310
> See linked issue.
>
> Bug: webrtc:11278
> Change-Id: I778ee4826de6c1b23d47a5d5ce302d074900ce6b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165786
> Reviewed-by: Per Åhgren <peah@webrtc.org >
> Commit-Queue: Sam Zackrisson <saza@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30233}
TBR=saza@webrtc.org ,peah@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:11278
Change-Id: I283648a6d4d58cfe7af7a646d915122207883007
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167180
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30357}
2020-01-23 10:28:25 +00:00
5922fd2a5e
Roll chromium_revision ecade5b956..487ee81fa3 (734256:734357)
...
Change log: ecade5b956..487ee81fa3
Full diff: ecade5b956..487ee81fa3
Changed dependency
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/bc9b294117..6b345995a8
DEPS diff: ecade5b956..487ee81fa3
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ia04ea35305af71460d4771f7c19d91e866d0a8c9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167162
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30356}
2020-01-23 06:37:32 +00:00
6adeb21061
Roll chromium_revision 92378355b1..ecade5b956 (734133:734256)
...
Change log: 92378355b1..ecade5b956
Full diff: 92378355b1..ecade5b956
Changed dependencies
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b9cc8d75a2..bc9b294117
* src/third_party/depot_tools: 6a5aa6680c..bdd89366d3
* src/third_party/libvpx/source/libvpx: 50d1a4aa72..7763c888e0
Added dependencies
* src/third_party/android_deps/libs/org_jdom_jdom2
* src/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib
* src/third_party/android_deps/libs/commons_cli_commons_cli
* src/third_party/android_deps/libs/com_android_tools_build_jetifier_jetifier_core
* src/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib_common
* src/third_party/android_deps/libs/com_android_tools_build_jetifier_jetifier_processor
DEPS diff: 92378355b1..ecade5b956
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,marpan@webrtc.org , jianj@chromium.org ,
BUG=None
Change-Id: I28b967d603136e4d76700802f567d5c0d4008876
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167140
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30355}
2020-01-23 00:50:41 +00:00
529d886c38
Allow DTMF delay configurability
...
This commit enables developers to configure the "," delay value from
the WebRTC spec value of 2 seconds. This flexibility allows developers
to comply with existing WebRTC clients.
Bug: webrtc:11273
Change-Id: Ia94b99e041df882e2396d0926a8f4188afe55885
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165700
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30354}
2020-01-22 20:46:52 +00:00
e9ef4c853b
Roll chromium_revision a6566211cb..92378355b1 (733985:734133)
...
Change log: a6566211cb..92378355b1
Full diff: a6566211cb..92378355b1
Changed dependencies
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c8ebd366bc..b9cc8d75a2
* src/third_party/freetype/src: 50b013871c..e5038be704
DEPS diff: a6566211cb..92378355b1
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I5ca240e1de605dfdf70c6e5b93488496dbefdd16
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167100
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30353}
2020-01-22 20:38:21 +00:00
d4578ae962
[Overuse] Encoding pipeline as input signals in the abstract interface.
...
This defines the following methods:
- OnFrame(), replaces SetLastFramePixelCount().
- OnFrameDroppedDueToSize(), a rename of FrameDroppedDueToSize() to
match the other methods.
- OnEncodeStarted(), a rename of the incorrectly named FrameCaptured().
- OnEncodeCompleted(), a rename of the poorly named FrameSent().
In order to get rid of SetLastFramePixelCount(), the "we don't know the
frame size" use case - which was previously implicitly avoided by
invoking SetLastFramePixelCount() with a made-up value for
last_frame_info_ - is now avoided using ".value_or()" in
LastInputFrameSizeOrDefault(). This does mean that a constant 144p
resolution value is referenced in two places, but the fact that this is
a magic value is at least made explicit. This may help future
improvements.
Bug: webrtc:11222
Change-Id: I3b28daa8c5ecf57c6537957d4759f15e24bb2234
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166961
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Evan Shrubsole <eshr@google.com >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30352}
2020-01-22 17:11:20 +00:00
2bc91e8c6a
Avoid extra EncodedFrame copy in RunPostEncode
...
All uses of encoded_image are const, except for the copy for running on
the encoder_queue_.
Bug: None
Change-Id: I7fc8cb46f6afb42a2d27961d3d3ff8d9e63fe1b5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166442
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@google.com >
Cr-Commit-Position: refs/heads/master@{#30351}
2020-01-22 15:41:38 +00:00
3986fa8c7e
Roll chromium_revision c565cfe6eb..a6566211cb (733868:733985)
...
Change log: c565cfe6eb..a6566211cb
Full diff: c565cfe6eb..a6566211cb
Changed dependency
* src/third_party/depot_tools: d339e36642..6a5aa6680c
DEPS diff: c565cfe6eb..a6566211cb
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I3b2f2353eb8211af04eb5c84a5ad78b413631027
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167049
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30350}
2020-01-22 14:58:30 +00:00
094ce2ef83
Adds CreateTaskQueueFactory to TimeController
...
Bug: webrtc:11255
Change-Id: I02bdc944c7081590f40a77b315f64c63adbc6ff8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166921
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30349}
2020-01-22 14:19:15 +00:00
133bf2bd28
Reland "Distinguish between send and receive codecs"
...
This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
Reason for revert: Fixed negotiation of send-only clients.
Original change's description:
> Revert "Distinguish between send and receive codecs"
>
> This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
>
> Reason for revert: breaks negotiation with send-only clients
>
> (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
>
> Original change's description:
> > Distinguish between send and receive codecs
> >
> > Even though send and receive codecs may be the same, they might have
> > different support in HW. Distinguish between send and receive codecs
> > to be able to keep track of which codecs have HW support.
> >
> > Bug: chromium:1029737
> > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30284}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
> Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Steve Anton <steveanton@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30292}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Bug: chromium:1029737
Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30348}
2020-01-22 13:55:41 +00:00
ede69c0fbe
[Overuse] Setting the target bitrate through the interface.
...
The poorly named SetEncoderStartBitrate() is renamed
SetEncoderTargetBitrate() and added to the abstract resource adaptation
module interface.
The so-called "start bitrate" was updated to match the target bitrate,
so this was only ever a "start bitrate" until we had any estimates. The
variable is renamed in VideoStreamEncoder as well, and usage of optional
types are introduced to avoid magical values in a few places in the
existing code.
Bug: webrtc:11222
Change-Id: Idde92f68f34616aa3c34ab77a791fdbe7ea7af26
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166880
Reviewed-by: Evan Shrubsole <eshr@google.com >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30347}
2020-01-22 13:38:38 +00:00
ee558dcca8
Propagate multicodec support to other places of PC level framework
...
Bug: webrtc:10138
Change-Id: I9258db991053abfa40f2a5112eddfa7f3e0d41a1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167062
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30346}
2020-01-22 13:34:18 +00:00
33aaa35d54
Fix video_replay to build and actually work
...
Add it to default build target, so it won't get broken accidentally
again. Fix configuration issue with field trials (new parameter was
added recently, but wasn't set by video_replay)
Bug: webrtc:11287
Change-Id: I9c18746d899acd7ac68c1b9b3a646b862c41897a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166900
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30345}
2020-01-22 13:16:28 +00:00
5bb9adcb08
Add absolute capture time to video sender path.
...
Bug: webrtc:10739
Change-Id: I2bbef7275ae065312ad86daaecc773c0ab36a684
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167061
Commit-Queue: Minyue Li <minyue@webrtc.org >
Reviewed-by: Minyue Li <minyue@webrtc.org >
Reviewed-by: Chen Xing <chxg@google.com >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30344}
2020-01-22 13:09:28 +00:00
39c8350613
Reduce the complexity of the multichannel echo subtractor test
...
This CL reduces the complexity of the Subtractor.ConvergenceMultiChannel
test by
1. Slightly reducing the amount of tested combinations for the non-debug
mode.
2. Drastically reduce the amount of tested combinations for the debug
mode.
Bug: webrtc:11295
Change-Id: I56bfa4a1463d26e5217b6a4d7f2ef54de7aab512
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166529
Commit-Queue: Per Åhgren <peah@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30343}
2020-01-22 11:39:07 +00:00
6ce033a863
Moves ownership of time controller into NetworkEmulationManager.
...
This makes it easier to maintain consistency between real time
and simulated time modes.
The RealTimeController is updated to use an explicit main thread,
this ensures that pending destruction tasks are run as the network
emulator goes out of scope.
Bug: webrtc:11255
Change-Id: Ie73ab778c78a68d7c58c0f857f14a8d8ac027c67
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166164
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30342}
2020-01-22 11:12:27 +00:00
402379f1f3
Roll chromium_revision 3f2a66dfa6..c565cfe6eb (733758:733868)
...
Change log: 3f2a66dfa6..c565cfe6eb
Full diff: 3f2a66dfa6..c565cfe6eb
Changed dependencies
* src/base: 98c4f40a9d..e1626e708d
* src/build: 7389665667..08c5083ab8
* src/ios: 85a45ffb11..027fc768d4
* src/third_party: efbd0ee00a..8966ce7713
* src/third_party/android_build_tools/aapt2: TM6ESkOFwhdEwjsIxbY3m6j7BIhg8mpY_X9Pg0nwb1AC..LKH_DI44rZhQ4RkScMFQLGSJ4jZyuPcff0llITnq-i4C
* src/tools: 8b16967ddc..1a4aa4db04
DEPS diff: 3f2a66dfa6..c565cfe6eb
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I2bc3adba5d678752446ee625701a0a3fc592d461
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167044
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30341}
2020-01-22 04:52:34 +00:00
394761685b
Roll chromium_revision 9a18a2d9eb..3f2a66dfa6 (733613:733758)
...
Change log: 9a18a2d9eb..3f2a66dfa6
Full diff: 9a18a2d9eb..3f2a66dfa6
Changed dependencies
* src/build: a139413faf..7389665667
* src/buildtools: 73414d5226..48cce924d6
* src/ios: 908456822a..85a45ffb11
* src/testing: 1cbad3dbd2..8d8f6f0831
* src/third_party: 707d1d3ca6..efbd0ee00a
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c533f76b91..c8ebd366bc
* src/third_party/depot_tools: 8effa4d063..d339e36642
* src/tools: fd51d60b2b..8b16967ddc
DEPS diff: 9a18a2d9eb..3f2a66dfa6
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I74726d5ac8134c1c41d0b89be95ec3fab2bfb6ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167040
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30340}
2020-01-21 22:51:33 +00:00
06df1e1c46
Roll chromium_revision 4c7513580a..9a18a2d9eb (733512:733613)
...
Change log: 4c7513580a..9a18a2d9eb
Full diff: 4c7513580a..9a18a2d9eb
Changed dependencies
* src/base: 649fc86e8f..98c4f40a9d
* src/buildtools/linux64: git_revision:0c5557d173ce217cea095086a9c9610068123503..git_revision:83dad00afb232d7235dd70dff1ee90292d72a01e
* src/buildtools/mac: git_revision:0c5557d173ce217cea095086a9c9610068123503..git_revision:83dad00afb232d7235dd70dff1ee90292d72a01e
* src/buildtools/win: git_revision:0c5557d173ce217cea095086a9c9610068123503..git_revision:83dad00afb232d7235dd70dff1ee90292d72a01e
* src/ios: 4a4bccaefd..908456822a
* src/testing: a7aefb077e..1cbad3dbd2
* src/third_party: 9db3120dda..707d1d3ca6
* src/third_party/depot_tools: b24ca5ac74..8effa4d063
* src/tools: dc050c423d..fd51d60b2b
DEPS diff: 4c7513580a..9a18a2d9eb
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I7ba12792dfe88011c3072d5fb8004bff9f707dc3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166980
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30339}
2020-01-21 16:33:18 +00:00