3d687a1e3e
Add null checks in stacktrace.cc
...
We have seen crashes originating from derefencing nullptrs in this code,
for unknown reasons. This CL adds null checks to protect against this.
The stacktraces will be missing or truncated when this happens.
Bug: b/147338449
Change-Id: Ieb006f0f8dec4f9621e4df2e2c1a9641f086df86
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173593
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Magnus Jedvert <magjed@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31079}
2020-04-16 09:26:11 +00:00
8ec11b8312
Do not register generic frame descriptor v1 in integration tests
...
Bug: webrtc:11358
Change-Id: I2fb42198d760ba95c5cddc4abb73e58b427aefca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173585
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31078}
2020-04-15 18:45:43 +00:00
3c9bcc1f7a
Reland of the test portion of:
...
https://webrtc-review.googlesource.com/c/src/+/172847
------------ original description --------------
Preparation for ReceiveStatisticsProxy lock reduction.
Update tests to call VideoReceiveStream::GetStats() in the same or at
least similar way it gets called in production (construction thread,
same TQ/thread).
Mapped out threads and context for ReceiveStatisticsProxy,
VideoQualityObserver and VideoReceiveStream. Added
follow-up TODOs for webrtc:11489.
One functional change in ReceiveStatisticsProxy is that when sender
side RtcpPacketTypesCounterUpdated calls are made, the counter is
updated asynchronously since the sender calls the method on a different
thread than the receiver.
Make CallClient::SendTask public to allow tests to run tasks in the
right context. CallClient already does this internally for GetStats.
Remove 10 sec sleep in StopSendingKeyframeRequestsForInactiveStream.
Bug: webrtc:11489
Change-Id: I491e13344b9fa714de0741dd927d907de7e39e83
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173583
Commit-Queue: Tommi <tommi@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31077}
2020-04-15 16:09:44 +00:00
4a5bce96e8
Change to more idiomatic map erase.
...
Bug: webrtc:11477
Tested: JS application with early video.
Change-Id: I2733127744f6c1c32da1acb3533428e451cd65dc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173589
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31076}
2020-04-15 11:15:17 +00:00
708962bb0e
Roll chromium_revision 72d0f390b0..a775f4aeaa (758913:759199)
...
Change log: 72d0f390b0..a775f4aeaa
Full diff: 72d0f390b0..a775f4aeaa
Changed dependencies
* src/base: 22437335ef..2e2abc3c38
* src/build: 662ad1b84c..212b25dc86
* src/ios: 416c071b8b..2f8d00d1cb
* src/testing: ab4f5551cd..e5ced51413
* src/third_party: 8adf2b3818..76bcf1e499
* src/third_party/android_sdk/public: Jxtur3_L9RzY4q79K-AwIahwFW4oi5uYVD5URx9h62wC..zMVtBEihXp2Z0NYFNjLLmNrwy6252b_YWG6sh2l0QAcC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/a79a2f646d..4b4e879132
* src/third_party/depot_tools: 08f4d59e0b..e1a9c8db7e
* src/third_party/nasm: 21eb595319..4fa54ca5f7
* src/tools: 406650542a..3f15275073
* src/tools/swarming_client: cc958279ff..160b445a44
DEPS diff: 72d0f390b0..a775f4aeaa
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Icaf33e522c128db5e9a90f3aa5552b6cedee825f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173577
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31075}
2020-04-15 10:37:37 +00:00
43245c56b0
Remove excessive log spam in large conferences in downstream project.
...
Bug: chromium:1062963
Change-Id: I840382c530e016731112af890d1abe60f25c631a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173588
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Markus Handell <handellm@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31074}
2020-04-15 09:31:12 +00:00
f7f6870f1b
Mark static const class/struct members as constexpr.
...
This change fixes declarations that have initial values but are
technically not definitions by marking them constexpr (which counts as a
definition).
Bug: None
Change-Id: Icbecf8d83faffa83b9f7e1ffe4d6ef3a3f0b0c2a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173587
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31073}
2020-04-15 09:30:07 +00:00
3ebb6e93f4
Remove WebRTC-ExcludeTransportSequenceNumberFromFec.
...
Bug: webrtc:11503
Change-Id: I5e0b7038286d9501a617e002b70638f34ac556ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173580
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31072}
2020-04-15 08:11:30 +00:00
2136b569eb
Roll chromium_revision 304e175c8a..72d0f390b0 (758795:758913)
...
Change log: 304e175c8a..72d0f390b0
Full diff: 304e175c8a..72d0f390b0
Changed dependencies
* src/base: 3a71e6bd7a..22437335ef
* src/build: 01d208b21b..662ad1b84c
* src/ios: c4f3189d5d..416c071b8b
* src/testing: cf5f6a9c6e..ab4f5551cd
* src/third_party: 4ba8cc0592..8adf2b3818
* src/third_party/googletest/src: 10b1902d89..e3f0319d89
* src/tools: 8f04201278..406650542a
DEPS diff: 304e175c8a..72d0f390b0
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ibe05c8220ae968c033a7c32373f893f1967a3f47
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173568
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31071}
2020-04-14 18:39:12 +00:00
491ff3d54c
Remove AudioProcessing::UpdateHistogramsOnCallEnd.
...
Bug: webrtc:10198
Change-Id: I3e7a98f9b94c171e7f105883fc755e44b2e991ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173464
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31070}
2020-04-14 18:08:52 +00:00
f0684b5a8a
Remove NetEq::InsertPacket deprecated method.
...
Bug: webrtc:10198
Change-Id: Ia789524c459982705a5d0fc92b216e0b5a084952
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173463
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31069}
2020-04-14 18:07:47 +00:00
c4633fd861
Remove the version of Port::AddrAddress without a URL parameter.
...
This version of the method is deprecated in favor of the one that takes
an url parameter.
Bug: webrtc:10198
Change-Id: I7614b9cb98217663b0e2fbf1785ae1fb1484beec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173333
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31068}
2020-04-14 16:52:57 +00:00
b9d468573a
insertable streams: include rtp_timestamp offset for audio
...
includes the (random) rtp start offset in the timestamp passed to the frame transformer callback
Bug: chromium:1069278
Change-Id: I7d10130404d93df7cee3b8f87a0b780801a51415
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173329
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Reviewed-by: Marina Ciocea <marinaciocea@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31067}
2020-04-14 14:54:07 +00:00
fea8b94591
Reland "APM: Remove the usage of AudioFrame in the AudioProcessing interface"
...
This is a reland of 12e2d4ddb235da6ec7a5c1c3a83ac33d394920b0
Original change's description:
> APM: Remove the usage of AudioFrame in the AudioProcessing interface
>
> This CL removes the AudioFrame-based APIs from the AudioProcessing
> interface.
>
> Bug: webrtc:5298
> Change-Id: Iab470b26b10e06dcf29c543851ae0085bc5b66f0
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172939
> Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> Commit-Queue: Per Åhgren <peah@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#31016}
Bug: webrtc:5298
Change-Id: I70e6d59afc3716ee6109d8b9dc384abc71c93624
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173476
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31066}
2020-04-14 14:11:06 +00:00
43955465b4
Fix wrong unit in log in VideoStreamEncoder
...
SpatialLayer/SimulcastStream struct returns kilobits/sec for bitrates
but bps was being logged.
R=ilnik@webrtc.org
Bug: None
Change-Id: Ie581b484def229d7072057b35fe4a713480c54ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173478
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@google.com >
Cr-Commit-Position: refs/heads/master@{#31065}
2020-04-14 13:39:22 +00:00
3e2809f4f0
Drop support for receiving generic frame descriptor v1
...
Bug: webrtc:11358
Change-Id: Ia94e33fe7a66ce9fd6a9a5aecc12e244d51f8c5f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172924
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31064}
2020-04-14 13:01:08 +00:00
d2dcc580dc
Roll chromium_revision 41d2eaa40a..304e175c8a (758687:758795)
...
Change log: 41d2eaa40a..304e175c8a
Full diff: 41d2eaa40a..304e175c8a
Changed dependencies
* src/base: 266da10ef9..3a71e6bd7a
* src/ios: 8fe45a8b1e..c4f3189d5d
* src/testing: f5468074fa..cf5f6a9c6e
* src/third_party: 92fcfe2fd0..4ba8cc0592
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/297fffa498..a79a2f646d
* src/third_party/depot_tools: a01816b0ba..08f4d59e0b
* src/tools: 7d7cd9ea8d..8f04201278
DEPS diff: 41d2eaa40a..304e175c8a
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ifc37cc27537e0b6ec34436b282996f5e83afcfa9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173565
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31063}
2020-04-14 12:57:58 +00:00
f387946569
Remove WebRTC-Rfc5389StunRetransmissions.
...
Since there is no plan to follow-up on this, this CL removes the
field trial and the conditional logic based on it.
Bug: webrtc:11503, webrtc:10282
Change-Id: Iaf005eba6af0e23ea50456d75c5c53f37d488f7d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173477
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31062}
2020-04-14 12:43:26 +00:00
dce61741f6
Remove deprecated SSLAdapter::SetIdentity.
...
Bug: webrtc:10198
Change-Id: I675bc08bffa2774546357fb0b554bd52ca69c095
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173465
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31061}
2020-04-14 11:00:49 +00:00
cc34441554
Remove deprecated RtpPacketInfo::RtpPacketInfo.
...
Bug: webrtc:10739
Change-Id: Iceda881ffa0645d8e1519c2b1a62c840ffa6a93f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173468
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31060}
2020-04-14 10:59:44 +00:00
9621377730
Remove WebRTC-Audio-NewOpusPacketLossRateOptimization.
...
This field trial is unused.
Bug: webrtc:11503
Change-Id: I34262ea4ab169479ceded820c1aa309981731f1b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173338
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31059}
2020-04-14 10:02:52 +00:00
39fb817efd
[Video, Svc] Remove inactive spatial layers in codec initializer
...
This is more logical way to remove inactive lower layers.
Current way is to notify the encoder that the layer is inactive,
then renumber layers at the packatization level.
This Cl will allow to simplify libvpx vp9 encoder, svcRateAllocator and
vp9 packetizer.
Bug: webrtc:11319
Change-Id: Idf0bb30b729f5ecc97e31454b32934546b681aa2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173182
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31058}
2020-04-14 09:37:44 +00:00
9f297b5960
Remove OpenSSLIdentity::GenerateWithExpiration.
...
These static functions were marked as deprecated and since they
are not used this CL just removes them.
Bug: webrtc:10198
Change-Id: I4872e31701543c988fe71ab4e0b32bd73ff07753
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173467
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31057}
2020-04-14 09:34:04 +00:00
2d2c2947fd
Remove OpenSSLAdapter restartable_ data member.
...
Bug: webrtc:10198
Change-Id: I5beabba3837b92d600e2d7067954adf334adbdd0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173335
Reviewed-by: Justin Uberti <juberti@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31056}
2020-04-14 09:01:23 +00:00
8a948a3e2b
Roll chromium_revision edcfd61be3..41d2eaa40a (758565:758687)
...
Change log: edcfd61be3..41d2eaa40a
Full diff: edcfd61be3..41d2eaa40a
Changed dependencies
* src/base: 50ecbb4d86..266da10ef9
* src/build: 6223070693..01d208b21b
* src/ios: 2ed9c76ebd..8fe45a8b1e
* src/testing: e062d0c7b2..f5468074fa
* src/third_party: ae7b0b3bc4..92fcfe2fd0
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0780cae6bf..297fffa498
* src/third_party/depot_tools: 4f3aff5fc2..a01816b0ba
* src/tools: a261d3a6e7..7d7cd9ea8d
DEPS diff: edcfd61be3..41d2eaa40a
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ic33363bd61af0521703544b1b1c237cf22f68c21
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173560
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31055}
2020-04-14 02:46:53 +00:00
0574822f9f
Roll chromium_revision 94450aa986..edcfd61be3 (758458:758565)
...
Change log: 94450aa986..edcfd61be3
Full diff: 94450aa986..edcfd61be3
Changed dependencies
* src/build: d959231e9f..6223070693
* src/ios: 8760a4a6ac..2ed9c76ebd
* src/third_party: d0c47c45d5..ae7b0b3bc4
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/5298ef99bf..f9e0cda2d8
* src/third_party/depot_tools: e521cd14da..4f3aff5fc2
* src/tools: f7984b8616..a261d3a6e7
DEPS diff: 94450aa986..edcfd61be3
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: If73a2badc4aad5aff55b2b177eaf97284006bc5f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173499
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31054}
2020-04-13 20:40:05 +00:00
2c9926498f
Remove std::vector<BandwidthEstimationInfo> template instantiation.
...
Bug: webrtc:10198
Change-Id: Ice162176ba333599f0c3c9520c704aa3d23c694d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173336
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31053}
2020-04-13 13:33:27 +00:00
9ef32bb330
Roll chromium_revision 318b9b3c86..94450aa986 (758358:758458)
...
Change log: 318b9b3c86..94450aa986
Full diff: 318b9b3c86..94450aa986
Changed dependencies
* src/build: 7a9dc288fc..d959231e9f
* src/ios: 8903a51ed8..8760a4a6ac
* src/third_party: d7787eee0b..d0c47c45d5
* src/tools: 402296b651..f7984b8616
DEPS diff: 318b9b3c86..94450aa986
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I1e8165d59d16c14f8507e61f348188dfe35b4462
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173491
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31052}
2020-04-13 04:37:29 +00:00
adc4da30f4
[InsertableStreams] Fix video receiver simulcast.
...
Save the frame transformer set on unsignaled receivers, and set the
transformer when the ssrc becomes known.
Pass the receiver's ssrc on registering the transformed frame callback,
to associate separate frame transformer sinks for each receiver.
Bug: chromium:1065838
Bug: chromium:1065838
Change-Id: I2a214bdb6cb9a8012928a03f046f311c344370f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173201
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31051}
2020-04-11 12:04:24 +00:00
dc69fd2b80
[InsertableStreams] Fix video sender simulcast.
...
The transformer was previously moved into the config of the first stream
which resulted in incorrect behavior for simulcast. Use the transformer
in all the streams.
Pass the sender's ssrc on registring the transformed frame callback, to
associate separate transformer sinks for each sender.
Bug: chromium:1065838
Change-Id: I5c52dacb241c68268681b85f875257b24987849e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173332
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31050}
2020-04-11 10:30:32 +00:00
d37010c9b7
Roll chromium_revision 666362b2f4..318b9b3c86 (758256:758358)
...
Change log: 666362b2f4..318b9b3c86
Full diff: 666362b2f4..318b9b3c86
Changed dependencies
* src/base: 0c5b809ac7..50ecbb4d86
* src/build: 24a9e612c3..7a9dc288fc
* src/ios: 0351f3210b..8903a51ed8
* src/testing: 485bbba382..e062d0c7b2
* src/third_party: 420c918886..d7787eee0b
* src/tools: 8157852dd2..402296b651
DEPS diff: 666362b2f4..318b9b3c86
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I4ff3e3d3f56fecd28a98a02b0911ab76dd04f2b5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173401
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31049}
2020-04-11 00:37:27 +00:00
9d8cede79b
Roll chromium_revision bc4df9dd11..666362b2f4 (758140:758256)
...
Change log: bc4df9dd11..666362b2f4
Full diff: bc4df9dd11..666362b2f4
Changed dependencies
* src/base: 7c47141ac2..0c5b809ac7
* src/build: 3c05fb4405..24a9e612c3
* src/ios: 47ea087b72..0351f3210b
* src/testing: 9b4e2e1828..485bbba382
* src/third_party: 45549884a9..420c918886
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/90ff937ff6..0780cae6bf
* src/tools: d013d491c0..8157852dd2
* src/tools/luci-go: git_revision:dad957de715bbe7e8b0f382488ff7af75cf600a5..git_revision:513b1319d7d855f6c42bc01471562df910fd61b3
* src/tools/luci-go: git_revision:dad957de715bbe7e8b0f382488ff7af75cf600a5..git_revision:513b1319d7d855f6c42bc01471562df910fd61b3
* src/tools/luci-go: git_revision:dad957de715bbe7e8b0f382488ff7af75cf600a5..git_revision:513b1319d7d855f6c42bc01471562df910fd61b3
DEPS diff: bc4df9dd11..666362b2f4
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I077111f09c3ce4b325ebbf9035f6c917150d1454
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173352
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31048}
2020-04-10 20:38:08 +00:00
fdabfbc334
[InsertableStreams] Pass ssrc on TransformedFrameCallback registration.
...
Add new methods in the FrameTransformerInterfaces, passing the ssrc on
registering the transformed frame callback, to associate separate frame
transformer sinks for each ssrc. Same for unregister.
Bug: chromium:1065838
Change-Id: I8a406815e9d0cce5199f9df06c286d8b10d75b4d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173183
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31047}
2020-04-10 18:00:26 +00:00
9f0b36c461
Roll chromium_revision 407aa3d664..bc4df9dd11 (758038:758140)
...
Change log: 407aa3d664..bc4df9dd11
Full diff: 407aa3d664..bc4df9dd11
Changed dependencies
* src/base: f336b75408..7c47141ac2
* src/build: 670c801549..3c05fb4405
* src/ios: 6c6a2d6653..47ea087b72
* src/testing: 3b24ca9ded..9b4e2e1828
* src/third_party: 8def2539d9..45549884a9
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e9a5bd1297..90ff937ff6
* src/tools: c53efa33fd..d013d491c0
DEPS diff: 407aa3d664..bc4df9dd11
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I1303969671fcc2b6309d13c86e692d56cc083853
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173345
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31046}
2020-04-10 07:15:17 +00:00
966a1b2ad9
[automerger skipped] DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp into stag-aosp-master am: 66a1e930d1 -s ours am: 2a8a8833e2 am: 1a41ff0fa2 am: 18cbea3c0a -s ours
...
am skip reason: subject contains skip directive
Change-Id: I77a241c9b63a5b2241dbddc0780b095827df2d00
2020-04-10 04:43:55 +00:00
18cbea3c0a
[automerger skipped] DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp into stag-aosp-master am: 66a1e930d1 -s ours am: 2a8a8833e2 am: 1a41ff0fa2
...
Change-Id: I0c40b28961ebeea85d9f25228b1d62d17269ac08
2020-04-10 04:08:05 +00:00
1a41ff0fa2
[automerger skipped] DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp into stag-aosp-master am: 66a1e930d1 -s ours am: 2a8a8833e2
...
Change-Id: I59e6436f7fac67569ad5bcacd17dfefaa88a2d06
2020-04-10 03:36:52 +00:00
2a8a8833e2
[automerger skipped] DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp into stag-aosp-master am: 66a1e930d1 -s ours
...
am skip reason: subject contains skip directive
Change-Id: I768d83c1831d91af26843f4c9a6429f1d915c8c9
2020-04-10 03:12:47 +00:00
66a1e930d1
DO NOT MERGE - Empty merge qt-qpr1-dev-plus-aosp into stag-aosp-master
...
Bug: 151763422
Change-Id: Ida26188ce6956f1276fd24ad19e0a598d3fa2e26
2020-04-09 17:51:00 -07:00
c242d12da2
Roll chromium_revision ca551bc6c0..407aa3d664 (757925:758038)
...
Change log: ca551bc6c0..407aa3d664
Full diff: ca551bc6c0..407aa3d664
Changed dependencies
* src/base: 2e77bcfa24..f336b75408
* src/build: 896bf0603d..670c801549
* src/ios: 3c562ab19c..6c6a2d6653
* src/testing: ace718049c..3b24ca9ded
* src/third_party: 71665461cc..8def2539d9
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c72a211d00..e9a5bd1297
* src/tools: 67dc293003..c53efa33fd
DEPS diff: ca551bc6c0..407aa3d664
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Icf019ccbb346823be9d913a3f22b1a05e5e3c05e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173342
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31045}
2020-04-09 22:33:24 +00:00
059c1b75eb
Roll chromium_revision 9fa8abd9f4..ca551bc6c0 (757716:757925)
...
Change log: 9fa8abd9f4..ca551bc6c0
Full diff: 9fa8abd9f4..ca551bc6c0
Changed dependencies
* src/base: 7bdaa7c90a..2e77bcfa24
* src/build: c7f2c4cffe..896bf0603d
* src/ios: fb82ee9b26..3c562ab19c
* src/testing: 6dd170edd2..ace718049c
* src/third_party: 4a44366257..71665461cc
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5d56a75005..c72a211d00
* src/tools: 9c37207796..67dc293003
DEPS diff: 9fa8abd9f4..ca551bc6c0
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I69cd26e00928fbc17c3fc1ffd2b418c738b5638b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173360
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31044}
2020-04-09 19:15:22 +00:00
f0dc5c52be
Adds tiny rtc::StringFormat utility
...
Bug: webrtc:11493
Change-Id: If11a0362dfa820e4464129d0ea58ff8bc4ce86bc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173323
Commit-Queue: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31043}
2020-04-09 18:13:11 +00:00
e156287855
AEC3: Remove deprecated parameter
...
Bug: webrtc:8671
Change-Id: Ia9bcfef9d626729b79fdcce5e8df82bf020dc9af
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173321
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31042}
2020-04-09 12:25:05 +00:00
9f6ff832d9
Do not trigger -Wimplicit-int-float-conversion
...
This is mentioned in bug 10893 (comment 5).
clang 10.0.0 compiler triggered a warning pointing to the
changed lines. The issue there is the implicit conversion
that takes place in the comparison between 'result' and the max value,
which will result in a change of value for the cast operand.
This is expected, therefore explicitly cast the said constants
in order to make clear the intent and prevent such warnings from
popping up in the future.
Bug: webrtc:10893
Change-Id: Icb5cde84d1a5c7b5e4f4cd4b7b923de894cede87
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173140
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31041}
2020-04-09 11:43:14 +00:00
7db1491a85
Restore call's final stats collection in PC level framework
...
Bug: webrtc:11479
Change-Id: I763e13315250519f391e3c9dc0f36fe84569844f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173320
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31040}
2020-04-09 11:21:04 +00:00
25eeda1872
Fix socket not getting registered for epoll events
...
When epoll is enabled in the PhysicalSocketServer, a socket may
not get registered for its epoll events. If an AsyncSocket is
closed and re-created during one of its signal callbacks, its
old epoll events and new epolls events bitmasks may be the same,
even though the fd has changed. This causes the epoll implementation
to not register the new fd for any events.
Fix this by resetting the saved events bitmask when the socket is
closed. This ensures the new fd, if any, is registered if needed.
Bug: webrtc:11497
Change-Id: Idea499e09aefdf292430d1a774a046f963603b95
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173103
Reviewed-by: Taylor <deadbeef@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31039}
2020-04-09 10:17:47 +00:00
46d2d5e4c4
Roll chromium_revision 6c7769b542..9fa8abd9f4 (757605:757716)
...
Change log: 6c7769b542..9fa8abd9f4
Full diff: 6c7769b542..9fa8abd9f4
Changed dependencies
* src/base: 58e4a7bb90..7bdaa7c90a
* src/build: 621778e0d3..c7f2c4cffe
* src/ios: 0408b5e19f..fb82ee9b26
* src/testing: ac38c8496b..6dd170edd2
* src/third_party: ca6699ff64..4a44366257
* src/third_party/depot_tools: c440b23d50..e521cd14da
* src/tools: 5f252017e2..9c37207796
DEPS diff: 6c7769b542..9fa8abd9f4
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I7911fad72816897e17a7ff36382d4c807b2ed32d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173261
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31038}
2020-04-09 05:02:17 +00:00
15398905e2
Roll chromium_revision e20438c506..6c7769b542 (757496:757605)
...
Change log: e20438c506..6c7769b542
Full diff: e20438c506..6c7769b542
Changed dependencies
* src/base: a1eb20b603..58e4a7bb90
* src/build: db737ddcac..621778e0d3
* src/ios: 5c19231c94..0408b5e19f
* src/testing: 79716353eb..ac38c8496b
* src/third_party: a23853c7f5..ca6699ff64
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/475c8941a1..5d56a75005
* src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/c25910f6d2..611c58e511
* src/tools: fb0b784bef..5f252017e2
DEPS diff: e20438c506..6c7769b542
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I91f88141fab7096581ea4d4c7beb6aab0cfddd94
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173223
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31037}
2020-04-08 22:39:10 +00:00
8d8bae65e6
Migrate to modern selector syntax for ObjcVideoEncoderFactory.
...
Bug: None
Change-Id: I610056b881022bb9408184d1ded4d80eedc410ab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173200
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31036}
2020-04-08 19:04:49 +00:00
5185df5cad
Roll chromium_revision 32ec1c1ce5..e20438c506 (757394:757496)
...
Change log: 32ec1c1ce5..e20438c506
Full diff: 32ec1c1ce5..e20438c506
Changed dependencies
* src/base: 2dd2827634..a1eb20b603
* src/build: e5ebf1e343..db737ddcac
* src/ios: b696de9f53..5c19231c94
* src/testing: 58e15e7408..79716353eb
* src/third_party: a63982b55f..a23853c7f5
* src/tools: 890c51b56f..fb0b784bef
DEPS diff: 32ec1c1ce5..e20438c506
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I94ecd66ede0aa7b29d806b76d490d075969e01a6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173221
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31035}
2020-04-08 18:44:19 +00:00