Commit Graph

31419 Commits

Author SHA1 Message Date
9b35da880b Revert "Implement packets_(sent | received) for RTCTransportStats"
This reverts commit fb6f975401972635a644c0db06c135b4c0aaef4a.

Reason for revert: Looks like this breaks chromium.webrtc.fyi:
https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Mac%20Tester/6000
https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win10%20Tester/6209
https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win7%20Tester/6177
https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win8%20Tester/6299

Original change's description:
> Implement packets_(sent | received) for RTCTransportStats
> 
> Bug: webrtc:11756
> Change-Id: Ic0caad6d4675969ef3ae886f50326e4a2e1cbfe7
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178741
> Reviewed-by: Tommi <tommi@webrtc.org>
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Commit-Queue: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31643}

TBR=hbos@webrtc.org,tommi@webrtc.org,titovartem@webrtc.org

Change-Id: Icbb0974ba29cbddb614f1f37f8a2de1a7c56b571
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11756
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178868
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31665}
2020-07-08 09:42:41 +00:00
5f61282687 Migrate modules/audio_device to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: I6d1a7145aaaae2e4cd0c8658fa31a673f857dbd6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178814
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31664}
2020-07-08 09:32:12 +00:00
adbfd1d985 VideoAnalyzer: remove lock recursions.
This change adds thread annotations and fixes lock recursions discovered when trying to land https://webrtc-review.googlesource.com/c/src/+/178813.

Bug: webrtc:11567
Change-Id: Ib6b6dcdade063af2579664536db23d40a5949031
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178860
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31663}
2020-07-08 09:14:22 +00:00
6cc893ad77 Migrate test/pc/e2e to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: Iaec1d2f5112deed96abc8cf8c5d0a89e5d5a260d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178817
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31662}
2020-07-08 09:05:32 +00:00
bfb6124a73 Add possibility to expand strings in the autoroller.
Starting from crrev.com/c/2265498, the Chromium DEPS file has a new
function Str(), which seems to just expand to the string it wraps.

This causes the following error:

  NameError: name 'Str' is not defined

In //tools_webrtc/autoroller/roll_deps.py.

This CL adds a way to expand the string.

No-Try: True
Bug: None
Change-Id: I4cdb43410edeed72b393f200314c0ee7eea9cb2a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178865
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31661}
2020-07-08 08:37:52 +00:00
52fd96fb73 Migrate test/time_controller to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: I26fb07bf84ed197ce667290aa0bf4816bc9c5c06
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178818
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31660}
2020-07-08 08:36:47 +00:00
9c96250dd5 Migrate modules/congestion_controller to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: I284eaebf863e0c63d2aa162a5df56380f9cf4838
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178841
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31659}
2020-07-08 08:35:42 +00:00
656efbee6f Fix thread usage in PC level tests for getting to the IceConnected state
Bug: webrtc:11743
Change-Id: I18a6318c35b350b3d729bbd5ac1d25f035e6ad9d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178809
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31658}
2020-07-08 08:15:32 +00:00
ce1ff6f8a7 Logging: reduce locking frequency by fixing TODO.
Bug: webrtc:11567
Change-Id: I0cd5062c3a088e3781d009242db32069193fbe82
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176902
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31657}
2020-07-08 07:59:03 +00:00
a827a30bb7 Revert "Migrate video/ except video/end_to_end_tests and video/adaptation to webrtc::Mutex."
This reverts commit 0eba415fb40cc4e3958546a8ee53c698940df0a1.

Reason for revert: previously unknown lock recursion occurring downstream.

Original change's description:
> Migrate video/ except video/end_to_end_tests and video/adaptation to webrtc::Mutex.
> 
> Also migrates test/ partly.
> 
> Bug: webrtc:11567
> Change-Id: I4203919615c087e5faca3b2fa1d54cba9f171e07
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178813
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Commit-Queue: Markus Handell <handellm@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31653}

TBR=sprang@webrtc.org,handellm@webrtc.org

Change-Id: I13f337e0de5b8f0eb19deb57cb5623444460ec4d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11567
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178842
Reviewed-by: Markus Handell <handellm@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31656}
2020-07-07 20:46:48 +00:00
462b5a65a1 Roll chromium_revision fa6a961223..b5359525fc (785707:785857)
Change log: fa6a961223..b5359525fc
Full diff: fa6a961223..b5359525fc

Changed dependencies
* src/base: 92109190e6..bec643a43e
* src/build: 3bd002c3db..111571fbf8
* src/ios: d40932a520..34cd3a9610
* src/testing: 8933687c5e..93eb285f57
* src/third_party: f955149bca..3e5507bb0c
* src/third_party/perfetto: 3039024ba5..5098126470
* src/tools: d09ab91c2a..c4831b8507
DEPS diff: fa6a961223..b5359525fc/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I49d1a030decea51884a3784ed1d9c496cf792383
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178774
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31655}
2020-07-07 18:41:39 +00:00
6fcd0f8031 Migrate pc/ to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: I1adc22d2998966958750138e66108cf39a8c3d57
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178840
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31654}
2020-07-07 18:25:09 +00:00
0eba415fb4 Migrate video/ except video/end_to_end_tests and video/adaptation to webrtc::Mutex.
Also migrates test/ partly.

Bug: webrtc:11567
Change-Id: I4203919615c087e5faca3b2fa1d54cba9f171e07
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178813
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31653}
2020-07-07 18:01:44 +00:00
edcb90755a Migrate modules/remote_bitrate_estimator to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: Ib3c8f73459088434a70ee86b044dbbbe14db1777
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178810
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31652}
2020-07-07 18:00:39 +00:00
9bbff07b20 Migrate video/adaptation and video/end_to_end_tests to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: I6c2d0c7e3e8fac85cf4d19223c4ef3d144598fda
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178812
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31651}
2020-07-07 15:34:16 +00:00
101750ac5b Roll chromium_revision 5f083e73a6..fa6a961223 (785559:785707)
Change log: 5f083e73a6..fa6a961223
Full diff: 5f083e73a6..fa6a961223

Changed dependencies
* src/base: 8aeffef0ee..92109190e6
* src/build: 729634b87d..3bd002c3db
* src/ios: d3245aa303..d40932a520
* src/testing: a711b11325..8933687c5e
* src/third_party: f8c6d72cc0..f955149bca
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9ef36d0c0f..1b843e7903
* src/third_party/depot_tools: 81923d6d2c..ce1375c5f0
* src/third_party/ffmpeg: 388ba367aa..15f6cfec63
* src/tools: ee10cd4775..d09ab91c2a
DEPS diff: 5f083e73a6..fa6a961223/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ia073e02e55a7980c154adc7ff12784c929d43746
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178772
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31650}
2020-07-07 15:27:46 +00:00
0df0faefd5 Migrate modules/audio_coding, audio_mixer/ and audio_processing/ to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: I03b78bd2e411e9bcca199f85e4457511826cd17e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176745
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31649}
2020-07-07 14:35:58 +00:00
1e257cacbf Migrate media/ to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: I69e4a1b37737ac8dd852a032612623c4c4f3a30b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176744
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31648}
2020-07-07 13:46:47 +00:00
06d034fe40 Migrate common_video/ and examples/ to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: I8e01c8adf1e5a0326e7956bdc635cfd3679a0d1a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176743
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31647}
2020-07-07 13:33:27 +00:00
9030994e91 Update default max nr of packets to 200.
In production code, the maximum number of packets is by default set to
200, so we should adopt the same behavior in tests.

Bug: None
Change-Id: I415790b7cd9fb170ea7ac94685cc6bbe14efac4d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178744
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31646}
2020-07-07 13:07:26 +00:00
e7c015e112 Migrate modules/rtp_rtcp to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: I4c71f3a28ef875af2c232b1b553840d6e21649d3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178804
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31645}
2020-07-07 12:13:47 +00:00
6deec38ede Migrate modules/video_coding to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: I8023fbe7595f7ba8ae7c7db3583fc2e560ec3df2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178803
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31644}
2020-07-07 11:41:21 +00:00
fb6f975401 Implement packets_(sent | received) for RTCTransportStats
Bug: webrtc:11756
Change-Id: Ic0caad6d4675969ef3ae886f50326e4a2e1cbfe7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178741
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31643}
2020-07-07 10:45:05 +00:00
3444a49d77 [Adaptation] Remove deg.prefs from ResourceAdaptationProcessor
Changes in effective degradation preference is now done directly
on the VideoStreamAdapter. This means that the
DegradationPreferenceListener class can be removed.

Bug: webrtc:11700
Change-Id: I9ce4b627de0279df5ef2e5a38435a6d352fbb135
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178609
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@google.com>
Cr-Commit-Position: refs/heads/master@{#31642}
2020-07-07 08:37:05 +00:00
c2128738a8 Relanding: Fix data channel message integrity violation
Patch originally submitted by Lennart Grahl:
https://webrtc-review.googlesource.com/c/src/+/177527

SCTP message chunks and notifications are being delivered interleaved.
However, the way the code was structured previously, a notification
would interrupt reassembly of a message chunk and hand out the partial
message, thereby violating message integrity. This patch separates the
handling of notifications and reassembly of messages.

Additional changes:

- Remove illegal cast from non-validated u32 to enum (PPID)
- Drop partial messages if the SID has been changed but EOR not yet
  received instead of delivering them. (This should never happen
  anyway.)
- Don't treat TSN as timestamp (wat)
- Replace "usrsctplib/usrsctp.h" with <usrsctp.h>, allowing a hack
  to be removed from media/BUILD.gn

Bug: webrtc:11708
Change-Id: I29733b03f67a3d840104b8608a7f0083466c2d0f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178469
Commit-Queue: Taylor <deadbeef@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31641}
2020-07-07 03:06:24 +00:00
48f20f849f Roll chromium_revision 31d34f548e..5f083e73a6 (785408:785559)
Change log: 31d34f548e..5f083e73a6
Full diff: 31d34f548e..5f083e73a6

Changed dependencies
* src/base: f2a563ac13..8aeffef0ee
* src/build: 1a541c1582..729634b87d
* src/buildtools: 6b951673d1..eb3987ec70
* src/buildtools/linux64: git_revision:b6203d186bff6b39ac25af6c1e80e1d3f96c949a..git_revision:d585128cdaf3e6ff7bfd58641965e60c12618eb1
* src/buildtools/mac: git_revision:b6203d186bff6b39ac25af6c1e80e1d3f96c949a..git_revision:d585128cdaf3e6ff7bfd58641965e60c12618eb1
* src/buildtools/win: git_revision:b6203d186bff6b39ac25af6c1e80e1d3f96c949a..git_revision:d585128cdaf3e6ff7bfd58641965e60c12618eb1
* src/ios: 3dfe063f28..d3245aa303
* src/third_party: 38a4b81800..f8c6d72cc0
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5f3007bf80..9ef36d0c0f
* src/third_party/depot_tools: 49735e227c..81923d6d2c
* src/third_party/freetype/src: a443474755..3bb512bc9f
* src/third_party/gtest-parallel: df0b4e476f..aabba21acd
* src/third_party/perfetto: 1783b3bd55..3039024ba5
* src/third_party/r8: B467c9t23JiW_6XGqhvHvtEKWSkrPS2xG_gho_gbAI4C..vvymFSkKtWKWNmfz0PL_0H8MD8V40P--A9aUfxfpF6QC
* src/tools: ac38d0f35a..ee10cd4775
DEPS diff: 31d34f548e..5f083e73a6/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ic55f8e4c840de1686ef823ddd42f30d19107fde5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178820
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31640}
2020-07-06 22:37:46 +00:00
0ef4a2488a Add simulated time support for PC level test.
Bug: webrtc:11743
Change-Id: If69ab07618a30ec1a66dd5f36b3198486bee55fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178608
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31639}
2020-07-06 21:18:00 +00:00
a166a353fb webrtc::AudioSendStream: Add lock annotation to audio_level_
This is a follow-up CL to https://webrtc-review.googlesource.com/c/src/+/176741

Bug: webrtc:11567
Change-Id: Ic64aec56534efc3229a1d9fa61552db4b83cae4c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178780
Reviewed-by: Markus Handell <handellm@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31638}
2020-07-06 17:05:25 +00:00
b3a6816b3e Roll chromium_revision a9cc4f4732..31d34f548e (785286:785408)
Change log: a9cc4f4732..31d34f548e
Full diff: a9cc4f4732..31d34f548e

Changed dependencies
* src/base: e802438166..f2a563ac13
* src/build: 96a67839bb..1a541c1582
* src/ios: 420c8e8e9c..3dfe063f28
* src/testing: 0822b567ee..a711b11325
* src/third_party: d26a020617..38a4b81800
* src/third_party/android_deps/libs/com_github_ben_manes_caffeine_caffeine: version:2.7.0-cr0..version:2.8.0-cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_annotation: version:2.3.4-cr0..version:2.4.0-cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_annotations: version:2.3.4-cr0..version:2.4.0-cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_check_api: version:2.3.4-cr0..version:2.4.0-cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_core: version:2.3.4-cr0..version:2.4.0-cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_type_annotations: version:2.3.4-cr0..version:2.4.0-cr0
* src/third_party/android_deps/libs/org_checkerframework_checker_qual: version:3.0.0-cr0..version:2.10.0-cr0
* src/third_party/perfetto: 350be7ea72..1783b3bd55
* src/tools: 04c9d66f3e..ac38d0f35a
Added dependencies
* src/third_party/android_deps/libs/org_checkerframework_dataflow_shaded
* src/third_party/android_deps/libs/org_threeten_threeten_extra
* src/third_party/android_deps/libs/com_google_auto_value_auto_value_annotations
Removed dependencies
* src/third_party/android_deps/libs/org_plumelib_reflection_util
* src/third_party/android_deps/libs/org_plumelib_require_javadoc
* src/third_party/android_deps/libs/org_checkerframework_dataflow
* src/third_party/android_deps/libs/org_checkerframework_javacutil
* src/third_party/android_deps/libs/org_plumelib_plume_util
DEPS diff: a9cc4f4732..31d34f548e/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ia8554431c9898fccdf0a6fc74ded8f9487fb5ce7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178763
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31637}
2020-07-06 16:47:05 +00:00
8fe932a5a3 Migrate call/ to webrtc::Mutex.
Bug: webrtc:11567
Change-Id: Iab7142c77bc0c1a026cf5121b756094e05bccefe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176742
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31636}
2020-07-06 15:48:30 +00:00
6287280d64 Migrate audio/ to use webrtc::Mutex
Bug: webrtc:11567
Change-Id: Ic6a753f09aafb508690f4b8dadd4c99433fcfeb6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176741
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31635}
2020-07-06 14:21:38 +00:00
afd1dcbde0 [Adaptation] Move TriggerAdaptationDueToFrameDroppedDueToSize
It has no relevance in ResourceAdaptationProcessorInterface.
The logic moves to an interaction directly on the VideoStreamAdapter.

Bug: webrtc:11700
Change-Id: I4c7b3e1e1361722a69b71e8f9bde33f5909c011a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178380
Commit-Queue: Evan Shrubsole <eshr@google.com>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31634}
2020-07-06 11:45:30 +00:00
c3efe1abfa Inclusive language in //rtc_base.
Bug: webrtc:11680
Change-Id: I498199afb5e52fd9047afff96b45fa5dfa356606
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178393
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31633}
2020-07-06 10:39:39 +00:00
c7f0dff191 Convert GN libs lists to frameworks
GN recently added support for Apple frameworks to link, rather than
overloading the libs lists. This pulls .frameworks out of the libs
lists, so that GN can stop supporting .frameworks in libs in the
future.

Bug: chromium:1052560
Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#31632}
2020-07-06 10:08:09 +00:00
d7d2f27b1b [Adaptation] Adaptation holds restrictions
This refactoring enables us to do multi-step adaptations
instead of the normal single step adaptations.

This work is required pre-requisite work to remove the
DropDueToSize methods from the ResourceAdaptationProcessorInterface.

This work also gives a path to fixing webrtc:11719, since double
adaptations can be done in a controlled manner with this API.


Bug: webrtc:11700,webrtc:11719
Change-Id: Ic7d27a49c82d0cf7ebaf79d7bdf0bc6f382770ed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178200
Commit-Queue: Evan Shrubsole <eshr@google.com>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31631}
2020-07-06 09:12:23 +00:00
9b79ad33af Roll chromium_revision 33c9ff5246..a9cc4f4732 (785166:785286)
Change log: 33c9ff5246..a9cc4f4732
Full diff: 33c9ff5246..a9cc4f4732

Changed dependencies
* src/base: 428533a222..e802438166
* src/build: b8da41191e..96a67839bb
* src/testing: 69b258add7..0822b567ee
* src/third_party: 6f084ad07b..d26a020617
* src/third_party/depot_tools: 95099f4754..49735e227c
* src/third_party/perfetto: f5fe9513c1..350be7ea72
* src/tools: 16490e089d..04c9d66f3e
DEPS diff: 33c9ff5246..a9cc4f4732/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I2bc35cbfa3f44d24637380513276fe37dc29872c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178701
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31630}
2020-07-06 06:19:46 +00:00
595652ddbd Roll chromium_revision a245a04732..33c9ff5246 (785063:785166)
Change log: a245a04732..33c9ff5246
Full diff: a245a04732..33c9ff5246

Changed dependencies
* src/build: 5d9e2e29b7..b8da41191e
* src/ios: 9280e2e2a9..420c8e8e9c
* src/testing: 23e8737008..69b258add7
* src/third_party: 04fe18fd6f..6f084ad07b
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/447d8353e0..5f3007bf80
* src/third_party/perfetto: 3fccb1b8f5..f5fe9513c1
* src/tools: ff9590b9f7..16490e089d
DEPS diff: a245a04732..33c9ff5246/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Icc2b1929872d5e71fca04b41e433a1566056d663
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178660
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31629}
2020-07-04 08:37:46 +00:00
62032d4592 Updates rtp_sender_unitests to use separate thread for pacer calls.
Some classes such as RtpSenderEgress makes assumptions about which
threads (e.g. paced sender vs worker thread) call specific methods.
Unit tests currently are single threaded so these checks are
essentially noops.

This change uses a separate task queue for calls epected to be called
by the pacer, so that inconsistencies in thread can be detected early.

Bug: None
Change-Id: Ic0904304a67eb034033524e62306da34b9eab8b4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178602
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31628}
2020-07-03 19:51:58 +00:00
2a8932020e Rename sanitizers suppression files.
Bug: webrtc:11680
Change-Id: Idc5b0644ecf1368c5e070d92120c66487855cf31
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178382
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31627}
2020-07-03 18:29:58 +00:00
54d7e1f6f3 Roll chromium_revision a6259aec3c..a245a04732 (784160:785063)
Change log: a6259aec3c..a245a04732
Full diff: a6259aec3c..a245a04732

Changed dependencies
* src/base: f948b83ee4..428533a222
* src/build: 29bc352305..5d9e2e29b7
* src/buildtools: 6099f10184..6b951673d1
* src/buildtools/linux64: git_revision:7d7e8deea36d126397bda2cf924682504271f0e1..git_revision:b6203d186bff6b39ac25af6c1e80e1d3f96c949a
* src/buildtools/mac: git_revision:7d7e8deea36d126397bda2cf924682504271f0e1..git_revision:b6203d186bff6b39ac25af6c1e80e1d3f96c949a
* src/buildtools/win: git_revision:7d7e8deea36d126397bda2cf924682504271f0e1..git_revision:b6203d186bff6b39ac25af6c1e80e1d3f96c949a
* src/ios: 0eef4fd128..9280e2e2a9
* src/testing: 3443315067..23e8737008
* src/third_party: c3156faac6..04fe18fd6f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4f894cfb70..447d8353e0
* src/third_party/depot_tools: 9056401df0..95099f4754
* src/third_party/ffmpeg: 23b2a15c25..388ba367aa
* src/third_party/perfetto: 7ec6f400ea..3fccb1b8f5
* src/tools: 81fc449000..ff9590b9f7
DEPS diff: a6259aec3c..a245a04732/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Icf8aea210b33762399c19b890528e404ae65f88d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178631
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31626}
2020-07-03 16:43:51 +00:00
41525d0cc0 red: implement RED with distance 2
Extends the RED implementation to support a distance of two, i.e. two
packets redundancy.

BUG=webrtc:11640

Change-Id: I5113a97a4e3d45d836d7952a0c19c5381069c158
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178565
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31625}
2020-07-03 13:53:28 +00:00
a018919bf6 Remove old method for creating PC test fixture
Bug: webrtc:11743
Change-Id: Ia57681c8ddf1b352be275fa22198c4d671f90efe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178604
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31624}
2020-07-03 13:38:47 +00:00
9492d500dd [Adaptation] Move deg.pref. out of ResourceAdaptationProcessor
This patch creates a new class which provides the DegradationPreference
thread safe to all classes that need if (BalancedConstraint and
QpScalerResource). It also broadcasts to all listeners when the
preferences are updated, so the ResourceAdaptationProcessor can update
the video if needed.

In future work, this could be used to remove the need for two task
queues for the VideoStreamEncoder resources.

Bug: webrtc:11700
Change-Id: I05480db8b7157b5643f6f86ec9c64850839b3e76
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177522
Commit-Queue: Evan Shrubsole <eshr@google.com>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31623}
2020-07-03 13:10:27 +00:00
db1c81d45b Prepare for migration of TestPeer and TestPeerFactory on TimeController
Bug: webrtc:11743
Change-Id: I99a9746830a1c6abae753d33cf61890f7a372608
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178605
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31622}
2020-07-03 12:08:07 +00:00
dfc5f0d19d Reland "Add rtc::Thread invoke policy."
This is a reland of 26d4f9cd398fa4d98408daccd54246c9af59a624

Original change's description:
> Add rtc::Thread invoke policy.
> 
> Policy will allow explicitly specify thread between which invokes are
> allowed, or explicitly forbid any invokes.
> 
> Change-Id: I360e7cba3ce1c21abd5047c6f175d8c4e0e99c6f
> Bug: webrtc:11728
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177526
> Reviewed-by: Tommi <tommi@webrtc.org>
> Commit-Queue: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31604}

Bug: webrtc:11728
Change-Id: Id700b870d8c8dd6fa97380422e568dfb69de131f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178564
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31621}
2020-07-03 11:33:17 +00:00
c07e904a25 Fix missing local and remote ids in RtpStreamStats
Bug: chromium:1098266
Change-Id: I536464541c5971ea173bd7ed83d523fa50b43d0b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178486
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31620}
2020-07-03 09:27:52 +00:00
1d50cb61d8 Reland "Reland "Allows FEC generation after pacer step.""
This is a reland of 19df870d924662e3b6efb86078d31a8e086b38b5
Patchset 1 is the original.
Subsequent patchset changes threadchecker that crashed with downstream
code.

Original change's description:
> Reland "Allows FEC generation after pacer step."
>
> This is a reland of 75fd127640bdf1729af6b4a25875e6d01f1570e0
>
> Patchset 2 contains a fix. Old code can in factor call
> RtpRtcpImpl::FetchFec(). It should only be a noop since deferred fec
> is not supported there - we shouldn't crash.
>
> Original change's description:
> > Allows FEC generation after pacer step.
> >
> > Split out from https://webrtc-review.googlesource.com/c/src/+/173708
> > This CL enables FEC packets to be generated as media packets are sent,
> > rather than generated, i.e. media packets are inserted into the fec
> > generator after the pacing stage rather than at packetization time.
> >
> > This may have some small impact of performance. FEC packets are
> > typically only generated when a new packet with a marker bit is added,
> > which means FEC packets protecting a frame will now be sent after all
> > of the media packets, rather than (potentially) interleaved with them.
> > Therefore this feature is currently behind a flag so we can examine the
> > impact. Once we are comfortable with the behavior we'll make it default
> > and remove the old code.
> >
> > Note that this change does not include the "protect all header
> > extensions" part of the original CL - that will be a follow-up.
> >
> > Bug: webrtc:11340
> > Change-Id: I3fe139c5d53968579b75b91e2612075451ff0f5d
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177760
> > Commit-Queue: Erik Språng <sprang@webrtc.org>
> > Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#31558}
>
> Bug: webrtc:11340
> Change-Id: I2ea49ee87ee9ff409044e34a777a7dd0ae0a077f
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177984
> Commit-Queue: Erik Språng <sprang@webrtc.org>
> Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31613}

Bug: webrtc:11340
Change-Id: Ib741c8c284f523c959f8aca454088d9eee7b17f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178600
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31619}
2020-07-03 07:20:06 +00:00
d154e36d96 Remove unused QualityMetricsReporter::Start method from pc test api
Bug: webrtc:11381
Change-Id: I254aef4f0c218fe1ee70499f405449f8a226b44b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178567
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31618}
2020-07-03 07:11:36 +00:00
1e10a61564 In av1 add structure with custom spatial scalability factor
Bug: webrtc:11042
Change-Id: I93f125fba1fa21d060de47c96435798525f6b374
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178566
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31617}
2020-07-02 14:52:08 +00:00
34b1a42de8 [Adaptation] Move input state into VideoStreamAdapter
Bug: webrtc:11700
Change-Id: I81a060b914f91f6724f13a9b672234c9c4a65fae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177104
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@google.com>
Cr-Commit-Position: refs/heads/master@{#31616}
2020-07-02 14:01:58 +00:00