Commit Graph

37788 Commits

Author SHA1 Message Date
7d4116855a AgcManagerDirect unit tests refactoring
Stop using TEST_F; that will make it easier to switch to parametric
tests that are needed to correctly test `AgcManagerDirect`.

"Avoid fixtures where reasonable."
Source: https://abseil.io/tips/122

Bug: chromium:1275566
Change-Id: I2d73a0913eb2349144f63bd17ab4d6efa245e472
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268766
Reviewed-by: Hanna Silen <silen@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37556}
2022-07-19 12:46:42 +00:00
99465b1395 Add missing header to fix build error when using linux system libraries
Change-Id: I4fc04563c2cfe36fa2352f72f2ae61d47972f025
Bug: webrtc:11226
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268194
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Auto-Submit: Bruno Pitrus <brunopitrus@hotmail.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37555}
2022-07-19 12:25:42 +00:00
5ed127e9af Clobber win bots
Bug: None
Change-Id: I8e57ee9e8bf6b4681f3a00efee352eb499e6cd81
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268861
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37554}
2022-07-19 11:34:02 +00:00
5286dcfab6 Migrate rtc_base and rtc_tools to absl::AnyInvocable based TaskQueueBase interface
Bug: webrtc:14245
Change-Id: I71abe3db7a23ad33bd175297e23fa8e927fa9628
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268768
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37553}
2022-07-19 10:57:42 +00:00
049dde6c8e Roll chromium_revision 5695b2c377..3f8fc6e359 (1025266:1025382)
Change log: 5695b2c377..3f8fc6e359
Full diff: 5695b2c377..3f8fc6e359

Changed dependencies
* src/base: fb3ebaf860..d28c12571a
* src/build: 9c1be2c8e6..55fee0e565
* src/buildtools/third_party/libunwind/trunk: 49191c55bb..955e2ff5fb
* src/ios: e73edfcb1e..ec94f41124
* src/testing: 5ebeb35b96..4a2ba06460
* src/third_party: cad0ef7a7d..2fa6453891
* src/tools: a8e81b2b7d..2cfda2e9bf
DEPS diff: 5695b2c377..3f8fc6e359/DEPS

No update to Clang.

BUG=None

Change-Id: Idedbdf07dc6897d67c81fa48209e2253fb0aecd9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268800
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37552}
2022-07-18 21:11:32 +00:00
07e8336c7e Roll chromium_revision add3adc6ef..5695b2c377 (1025088:1025266)
Change log: add3adc6ef..5695b2c377
Full diff: add3adc6ef..5695b2c377

Changed dependencies
* src/base: d4b5cb4bf4..fb3ebaf860
* src/build: 662b56d3bf..9c1be2c8e6
* src/ios: 7f23991c90..e73edfcb1e
* src/testing: b2094e8934..5ebeb35b96
* src/third_party: 7a861a1ab4..cad0ef7a7d
* src/third_party/perfetto: 9882c50ee9..761031a428
* src/tools: 094a0e9120..a8e81b2b7d
DEPS diff: add3adc6ef..5695b2c377/DEPS

No update to Clang.

BUG=None

Change-Id: I3c44d95358d4cc0f2fc3fe33b9014d5a43662ff1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268750
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37551}
2022-07-18 16:27:02 +00:00
253f36f88e Delete rtp_sender_ check in ModuleRtpRtcpImpl2::SetSendingMediaStatus
Analogous to https://webrtc-review.googlesource.com/c/src/+/267845/

Bug: webrtc:10198
Change-Id: Ib7d5e9b2a456486a419c61e7b2ce36df8960c67a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268762
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37550}
2022-07-18 14:28:31 +00:00
03f8b8a241 In video replace non-owning pointer to rtc::TaskQueue with non-owning pointer to TaskQueueBase
rtc::TaskQueue is a simple wrapper over TaskQueueBase and adds no
extra features when task queue is used without passing ownership.

Reducing usage of the internal rtc::TaskQueue wrapper gives users more flexibility how TaskQueueBase* is stored.

Bug: webrtc:14169
Change-Id: If5c8827544c843502c7dfcef775ac558de79ec3a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268189
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37549}
2022-07-18 13:59:32 +00:00
ee3ad9f2ce Make ChannelSend::OnUplinkPacketLossRate public
And delete a friend declaration.

Bug: webrtc:10198
Change-Id: Ie3a79418602ec078f68e70c17ef37bb4d79fb36a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268765
Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Auto-Submit: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37548}
2022-07-18 13:42:01 +00:00
208129fb53 [PCLF] Add ability to use fixed frame reate for video dump
Bug: b/237997865
Change-Id: I4e93db1f8a0ac84d8d1c014073cbcd0f58482203
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268763
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37547}
2022-07-18 13:28:41 +00:00
bfe9f5c5b1 [PCLF] Remove old VideoQualityAnalyzerInjectionHelper ctor without clock
Bug: b/237997865
Change-Id: I7ac5e086d29801cfc0617731c51076e38d365274
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268764
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37546}
2022-07-18 13:00:31 +00:00
f2d090a0de Add temporary method SimulcastStream::SetNumberOfTemporalLayers
Similar to https://webrtc-review.googlesource.com/c/src/+/267843, it
turns out we need the setter method too to transition downstream code.

Bug: webrtc:11607
Change-Id: I50df5e9c5d9301717d527089de61fcf783267ee1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268760
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37545}
2022-07-18 12:19:52 +00:00
d78789eee2 Delete old TODOs.
Bug: webrtc:10198
Change-Id: I7ea6ddedd97db17a9fc8caf6434cf72f6cd0d6ef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268761
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org>
Auto-Submit: Niels Moller <nisse@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37544}
2022-07-18 12:09:31 +00:00
e4bda7d008 [PCLF] Add video writer which accounts for freezes
Bug: b/237997865
Change-Id: I6d6e3faa48e6bddbe298ead7b1350dd3c70481b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268545
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37543}
2022-07-18 11:48:16 +00:00
3e378d7efa Refactor AecDump not to rely on QueuedTask
Bug: webrtc:14245
Change-Id: Ib41765652745a247da2ae6c2ca6be714de927ca7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268185
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37542}
2022-07-18 11:07:51 +00:00
e740b34c06 Delete VideoFrame::transport_frame_id() (an alias for timestamp())
Bug: webrtc:10198
Change-Id: Iaf40bf2c0d4d2f1d6dd19b9c6ff81f28e2812490
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267823
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37541}
2022-07-18 10:48:03 +00:00
ae65b0e0d9 Fuzz APM sample rates
This CL adds a fuzzer for the audio processing module that exercises the handling of all user input sample rates logged by the UMA histogram WebAudio.AudioContext.HardwareSampleRate.

The fuzzer inherits a lot of structure from the audio_processing_configs_fuzzer, but is greatly simplified and therefore the only shared code is test::FuzzDataHelper.

Tested: Modified the build to explicitly trigger resampling issue and verified it exercises the code, then let an unmodified fuzzer run locally over the weekend without finding issues.
Bug: webrtc:14263
Change-Id: Id3f19adee53c8842e92b6bf31cd2f360e19244d5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268192
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37540}
2022-07-18 09:29:31 +00:00
e40b1cbef7 Update WebRTC code version (2022-07-18T04:02:25).
Bug: None
Change-Id: I09e271223e2c6a43ba30542906ec352e9127849c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268743
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37539}
2022-07-18 05:31:21 +00:00
557c89cdd8 Roll chromium_revision be73da7e4f..add3adc6ef (1024987:1025088)
Change log: be73da7e4f..add3adc6ef
Full diff: be73da7e4f..add3adc6ef

Changed dependencies
* src/base: 38fc4cc4ff..d4b5cb4bf4
* src/build: 84a5cd06ae..662b56d3bf
* src/ios: c2ce321d54..7f23991c90
* src/testing: f34425fd09..b2094e8934
* src/third_party: fb57d65ed8..7a861a1ab4
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/788dd53c40..1240e973d5
* src/third_party/perfetto: 9277dbf0aa..9882c50ee9
* src/tools: cfe25b955a..094a0e9120
DEPS diff: be73da7e4f..add3adc6ef/DEPS

No update to Clang.

BUG=None

Change-Id: I223012878522d80ed32be3c2585d72f9764adacc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268700
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37538}
2022-07-17 16:39:51 +00:00
5262fd80f0 Update WebRTC code version (2022-07-17T04:04:52).
Bug: None
Change-Id: Iecc64edfba9f3f061985a25498c261b99304fbe0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268645
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37537}
2022-07-17 05:48:20 +00:00
62ec04dccc Roll chromium_revision a7aed2e185..be73da7e4f (1024832:1024987)
Change log: a7aed2e185..be73da7e4f
Full diff: a7aed2e185..be73da7e4f

Changed dependencies
* src/base: 14735f9d6d..38fc4cc4ff
* src/build: 2b7ed0b5a4..84a5cd06ae
* src/ios: e18dabeaa4..c2ce321d54
* src/testing: 64df6f84c4..f34425fd09
* src/third_party: 12b13f7d21..fb57d65ed8
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/880567709d..788dd53c40
* src/third_party/depot_tools: 26bc518eae..8168f76753
* src/third_party/perfetto: 16075d13d0..9277dbf0aa
* src/tools: 25201bbda0..cfe25b955a
DEPS diff: a7aed2e185..be73da7e4f/DEPS

No update to Clang.

BUG=None

Change-Id: I46e4c74779af0035275f6bf6ef929cec7c67634a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268602
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37536}
2022-07-16 02:47:59 +00:00
8faaa584f8 [PCLF] Add ctor for VideoQualityAnalyzerInjectionHelper with Clock
Add ctor for VideoQualityAnalyzerInjectionHelper with Clock to enable
future usage of FixedFpsVideoFrameWriterAdaptor from
https://webrtc-review.googlesource.com/c/src/+/268545

Bug: b/237997865
Change-Id: Id77d7377869c318af106d6c657ce6dd6599016e6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268546
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37535}
2022-07-15 22:10:29 +00:00
5137ceffa7 Roll chromium_revision 2eff916528..a7aed2e185 (1024687:1024832)
Change log: 2eff916528..a7aed2e185
Full diff: 2eff916528..a7aed2e185

Changed dependencies
* src/base: 1b7140c82f..14735f9d6d
* src/build: 62186a2b91..2b7ed0b5a4
* src/ios: 95b142ee7b..e18dabeaa4
* src/testing: b3d0035931..64df6f84c4
* src/third_party: 8b336d7d46..12b13f7d21
* src/third_party/perfetto: b781e1fdec..16075d13d0
* src/tools: 18c798f8d5..25201bbda0
DEPS diff: 2eff916528..a7aed2e185/DEPS

No update to Clang.

BUG=None

Change-Id: Ibe040a1739415f3145fcf1c896a808f043783c31
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268600
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37534}
2022-07-15 18:21:49 +00:00
277766f55e adopt absl::string_view in logging/
Bug: webrtc:13579
Change-Id: Ibc5fa7842d52321d61cc4cdd4770635af737ddff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267170
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37533}
2022-07-15 16:08:39 +00:00
90133b3d3f Minor event log parser cleanup
Bug: None
Change-Id: I8d46b834ac40b8e5ed1dee009c0890bb4cfdad95
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268543
Reviewed-by: Diep Bui <diepbp@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37532}
2022-07-15 12:43:49 +00:00
91b4e21422 Roll chromium_revision f38f7e51cb..2eff916528 (1024572:1024687)
Change log: f38f7e51cb..2eff916528
Full diff: f38f7e51cb..2eff916528

Changed dependencies
* src/base: a4c43832cb..1b7140c82f
* src/build: 39eb47bf26..62186a2b91
* src/testing: 866e5a3d6a..b3d0035931
* src/third_party: 154cdbc835..8b336d7d46
* src/third_party/perfetto: bed4b810cd..b781e1fdec
* src/tools: aef5bae2a3..18c798f8d5
DEPS diff: f38f7e51cb..2eff916528/DEPS

No update to Clang.

BUG=None

Change-Id: I5b6c60625e8feef6b35c67f6e10ef34fb0194af5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268570
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37531}
2022-07-15 12:40:39 +00:00
08480a599d Reland "AgcManagerDirect: stop enforcing min mic level override with 0 level"
This reverts commit d0a6fd239cef0d9fd5fdd5a41df389a696bff017.

Reason for revert: reland the bug fix

Original change's description:
> Revert "`AgcManagerDirect`: stop enforcing min mic level override with 0 level"
>
> This reverts commit e76daab8b36f8c2a16d59a116425a3a2f98022f6.
>
> Reason for revert: revert required to revert the parent CL
>
> Original change's description:
> > `AgcManagerDirect`: stop enforcing min mic level override with 0 level
> >
> > https://webrtc-review.googlesource.com/c/src/+/250141 introduced a bug
> > due to which the min mic level override is always enforced, if specified
> > even if the user manually adjusts the mic level to zero.
> >
> > This CL fixes that bug, the changes run behind a kill switch.
> >
> > TESTED=Test video call on Chromium on Mac; input volume not adjusted after zeroing it from the system preferences UI
> >
> > Bug: chromium:1275566
> > Change-Id: I18ce2e5970d3002b301f51f84544583c64982d57
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267844
> > Reviewed-by: Hanna Silen <silen@webrtc.org>
> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#37460}
>
> Bug: chromium:1275566
> Change-Id: I6d22d8f3fafdc7da3814827b9b69146a506595db
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268468
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#37515}

Bug: chromium:1275566
Change-Id: I7198587dec2a153270e8beb714e9dacccdaae806
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268544
Reviewed-by: Hanna Silen <silen@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37530}
2022-07-15 09:43:22 +00:00
591ea38cdc Update WebRTC code version (2022-07-15T04:04:23).
Bug: None
Change-Id: If64df4e7b1b1eba546ac1eeb7bf2b78811c0699e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268566
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37529}
2022-07-15 06:44:31 +00:00
e997a248b1 Roll chromium_revision 9d89596b9d..f38f7e51cb (1024444:1024572)
Change log: 9d89596b9d..f38f7e51cb
Full diff: 9d89596b9d..f38f7e51cb

Changed dependencies
* src/base: a540e37773..a4c43832cb
* src/build: ce4e9848fb..39eb47bf26
* src/ios: 3f573e9532..95b142ee7b
* src/testing: 19f2f17a9c..866e5a3d6a
* src/third_party: db830b3ef5..154cdbc835
* src/third_party/perfetto: da6e55d8b2..bed4b810cd
* src/tools: 6b0a879fea..aef5bae2a3
DEPS diff: 9d89596b9d..f38f7e51cb/DEPS

No update to Clang.

BUG=None

Change-Id: Idb120dbe6b5fabb35dd732a8817ca7fbc6cb2629
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268565
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37528}
2022-07-15 05:06:29 +00:00
b4c0e30942 Roll chromium_revision a98ee8b153..9d89596b9d (1024314:1024444)
Change log: a98ee8b153..9d89596b9d
Full diff: a98ee8b153..9d89596b9d

Changed dependencies
* src/base: d0f2b4413e..a540e37773
* src/build: 7919f2752d..ce4e9848fb
* src/buildtools/third_party/libc++abi/trunk: 3007992fc7..b954e3e656
* src/ios: 70f99f7794..3f573e9532
* src/testing: 93d2c55ecc..19f2f17a9c
* src/third_party: 1400eebf18..db830b3ef5
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e8f62ffda8..880567709d
* src/tools: 7f1d382749..6b0a879fea
DEPS diff: a98ee8b153..9d89596b9d/DEPS

No update to Clang.

BUG=None

Change-Id: Ia3d3dd7a88ab112e241674bd8e11e9ed4d08e664
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268563
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37527}
2022-07-14 22:34:38 +00:00
aeb4412e09 Video and flexfec receive stream config changes without recreate.
SetFeedbackParameters no longer recreates the embedded streams for:
- transport cc flag
- rtcp status

Bug: none
Change-Id: If6117a1ae760ca9a02f06bbfa2b46c6e0f448cfc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268281
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37526}
2022-07-14 20:51:08 +00:00
f6221058d3 Roll chromium_revision 12013b696a..a98ee8b153 (1024190:1024314)
Change log: 12013b696a..a98ee8b153
Full diff: 12013b696a..a98ee8b153

Changed dependencies
* src/base: d4cde9c6c6..d0f2b4413e
* src/build: 28a8ee254d..7919f2752d
* src/ios: 923f1b83fa..70f99f7794
* src/testing: 9644116925..93d2c55ecc
* src/third_party: 1d8e4d44b0..1400eebf18
* src/third_party/perfetto: ed613a2e0f..da6e55d8b2
* src/tools: eb5577bdf5..7f1d382749
DEPS diff: 12013b696a..a98ee8b153/DEPS

No update to Clang.

BUG=None

Change-Id: I98ae5f42e6d6c3321517a29430371eeb55c8e46e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268580
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37525}
2022-07-14 19:03:08 +00:00
98c78cdd20 VideoEncoderFactoryTemplate cleanup.
Bug: webrtc:13573
Change-Id: Id70e64adba6c5d76132dc0edb0c93937e3e894f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268542
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37524}
2022-07-14 16:16:47 +00:00
f0232f31fb New VideoDecoderFactoryTemplate.
The VideoDecoderFactoryTemplate takes decoder implementations as template arguments, making it possible to easily implement a VideoDecoderFactory only using the implementations required for the particular application. This will replace the BuiltinVideoDecoderFactory.

Bug: webrtc:13573
Change-Id: I0213acd20b69dacf06fc6934851b73bd19b1afc8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268470
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37523}
2022-07-14 15:38:20 +00:00
6f22eb55b3 peerconnection: measure invalid ice-chars in remote description
in order to deprecate the non-spec usage

BUG=chromium:1053756

Change-Id: I2588aba64a6e7ff05b39c5505504579a5f58a75f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268380
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37522}
2022-07-14 15:29:47 +00:00
f3c86154d4 Revert "Min mic analog level: override minimum and behavior on Mac"
This reverts commit c9cad23274a837b135db98c6ce96f85bbbc81604.

Reason for revert: add back field trial

Original change's description:
> Min mic analog level: override minimum and behavior on Mac
>
> This CL removes the `WebRTC-Audio-AgcMinMicLevelExperiment` field trial
> and always enables the code path behind that flag on Mac. In summary,
> the analog AGC behaves as follows on Mac:
> 1. the minimum level is overridden to 20
> 2. the minimum is applied even when clipping is detected
> 3. when the level is manually adjusted to 0, the minimum level is
>   enforced - i.e., 20
>
> Note that the 3rd property had been unintentionally added when the
> changes were added behind the aforementioned field trial. This will
> be fixed in a follow-up CL.
>
> Bug: chromium:1275566
> Change-Id: If184c4455a0780fcd94f55141af34460c152e3c3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266488
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
> Reviewed-by: Hanna Silen <silen@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#37459}

Bug: chromium:1275566
Change-Id: I00a37ad9e16efc49f721558d25af16efd5f3db8c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268540
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Hanna Silen <silen@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37521}
2022-07-14 11:44:47 +00:00
9dcbfd8614 Revert "In bitrate estimator Improve handing send time of out of order packets"
This reverts commit 2295ddbff978b9954688ee6163c9f3f554a7a85e.

Reason for revert: Investigation required because it breaks some downstream tests.

Original change's description:
> In bitrate estimator Improve handing send time of out of order packets
>
> Bug: None
> Change-Id: I74da3b616fb9419de8f7d9d28326354cee1c178d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268061
> Reviewed-by: Philip Eliasson <philipel@webrtc.org>
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#37494}

Bug: None
Change-Id: Ib8ab916b9eedb93aac5fc35c5d291b1f4ed16de0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268541
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37520}
2022-07-14 11:35:47 +00:00
ffd2241eda Roll chromium_revision d0810c09a2..12013b696a (1024069:1024190)
Change log: d0810c09a2..12013b696a
Full diff: d0810c09a2..12013b696a

Changed dependencies
* src/base: abf6ba1ea2..d4cde9c6c6
* src/build: e24845d55b..28a8ee254d
* src/buildtools: 34f9ff8fd5..5cee6a2f1c
* src/ios: b97a09d143..923f1b83fa
* src/testing: 51a95278f9..9644116925
* src/third_party: c67a1c5e25..1d8e4d44b0
* src/third_party/depot_tools: c8fadda5a4..26bc518eae
* src/third_party/fuchsia-sdk/sdk: version:8.20220713.2.1..version:8.20220713.3.1
* src/third_party/perfetto: 29a81e33e6..ed613a2e0f
* src/tools: e1b5790e44..eb5577bdf5
* src/tools/luci-go: git_revision:be5d9aacf8987c0826223264f0427cd0b530b6a4..git_revision:a0ba80649473055bae3d789eec28c9967adb5e45
* src/tools/luci-go: git_revision:be5d9aacf8987c0826223264f0427cd0b530b6a4..git_revision:a0ba80649473055bae3d789eec28c9967adb5e45
DEPS diff: d0810c09a2..12013b696a/DEPS

No update to Clang.

BUG=None

Change-Id: I259aada52717eb305521e73539e6364486f33b17
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268524
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37519}
2022-07-14 10:54:37 +00:00
70d6f2ed63 Update WebRTC code version (2022-07-14T04:06:31).
Bug: None
Change-Id: I10997c70090a3d90e530257c684e8ed7489fcdad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268521
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37518}
2022-07-14 06:02:57 +00:00
84ef31f908 Roll chromium_revision ef902d1658..d0810c09a2 (1023960:1024069)
Change log: ef902d1658..d0810c09a2
Full diff: ef902d1658..d0810c09a2

Changed dependencies
* src/build: dc2ab03404..e24845d55b
* src/ios: feccebf89f..b97a09d143
* src/testing: 54a2b17279..51a95278f9
* src/third_party: 19e3565577..c67a1c5e25
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c49cba8235..e8f62ffda8
* src/third_party/depot_tools: 6757d46962..c8fadda5a4
* src/tools: 3c30b667e7..e1b5790e44
DEPS diff: ef902d1658..d0810c09a2/DEPS

No update to Clang.

BUG=None

Change-Id: Id3824a9d129b5d43ea76fba6a7a826ced3c3c366
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268456
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37517}
2022-07-14 02:45:28 +00:00
09196e44af Roll chromium_revision 0f2fa982fe..ef902d1658 (1023827:1023960)
Change log: 0f2fa982fe..ef902d1658
Full diff: 0f2fa982fe..ef902d1658

Changed dependencies
* src/base: eea0d5913b..abf6ba1ea2
* src/build: a900a40416..dc2ab03404
* src/ios: 1b5251bfea..feccebf89f
* src/testing: 7871ca2750..54a2b17279
* src/third_party: 3b5cd729ed..19e3565577
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8e958343e5..c49cba8235
* src/third_party/fuchsia-sdk/sdk: version:8.20220713.1.1..version:8.20220713.2.1
* src/third_party/perfetto: 00a6e13924..29a81e33e6
* src/tools: 7746775e79..3c30b667e7
DEPS diff: 0f2fa982fe..ef902d1658/DEPS

No update to Clang.

BUG=None

Change-Id: Ic90d10f1e5d3c197d7a88ddb7dddf739666f1cf3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268500
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37516}
2022-07-13 22:39:30 +00:00
d0a6fd239c Revert "AgcManagerDirect: stop enforcing min mic level override with 0 level"
This reverts commit e76daab8b36f8c2a16d59a116425a3a2f98022f6.

Reason for revert: revert required to revert the parent CL

Original change's description:
> `AgcManagerDirect`: stop enforcing min mic level override with 0 level
>
> https://webrtc-review.googlesource.com/c/src/+/250141 introduced a bug
> due to which the min mic level override is always enforced, if specified
> even if the user manually adjusts the mic level to zero.
>
> This CL fixes that bug, the changes run behind a kill switch.
>
> TESTED=Test video call on Chromium on Mac; input volume not adjusted after zeroing it from the system preferences UI
>
> Bug: chromium:1275566
> Change-Id: I18ce2e5970d3002b301f51f84544583c64982d57
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267844
> Reviewed-by: Hanna Silen <silen@webrtc.org>
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#37460}

Bug: chromium:1275566
Change-Id: I6d22d8f3fafdc7da3814827b9b69146a506595db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268468
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37515}
2022-07-13 20:58:07 +00:00
94d259c7af Roll chromium_revision d05b59b211..0f2fa982fe (1023693:1023827)
Change log: d05b59b211..0f2fa982fe
Full diff: d05b59b211..0f2fa982fe

Changed dependencies
* src/base: a8aabb6cbc..eea0d5913b
* src/build: 68ac9cd9b0..a900a40416
* src/ios: 4585098453..1b5251bfea
* src/testing: 743229fa49..7871ca2750
* src/third_party: 1aac14b2e0..3b5cd729ed
* src/third_party/perfetto: 7a33ae4f5f..00a6e13924
* src/tools: 9ad57e0f47..7746775e79
DEPS diff: d05b59b211..0f2fa982fe/DEPS

No update to Clang.

BUG=None

Change-Id: I266701056a3cac3b197c5e96856df4e7270e755c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268480
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37514}
2022-07-13 18:44:57 +00:00
b5d77a0c84 webrtc: Blank desktop capturer regards empty frame as a blank frame
There is a AV where GDI capturer sends empty frame to the
blank detector. It is fine operation from the GDI capturer
to pass an empty to the next handler. So, blank capturer
filter it and send it as blank frame to next handler.

Bug: webrtc:14265
Change-Id: Ifc90a210703e14fa6d0dc7fb2ae2942ae4e8125f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268444
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#37513}
2022-07-13 18:03:07 +00:00
edd8c257f4 Roll chromium_revision 3fcc05638a..d05b59b211 (1023689:1023693)
Manually add jdk/extras

Change log: 3fcc05638a..d05b59b211
Full diff: 3fcc05638a..d05b59b211

Changed dependencies
* src/ios: e77b8a18a1..4585098453
* src/third_party/fuchsia-sdk/sdk: version:8.20220712.1.1..version:8.20220713.1.1
* src/third_party/libyuv: 6900494d90..d248929c05
* src/third_party/perfetto: 8fe494f32e..7a33ae4f5f
* src/tools: c662ee8ae6..9ad57e0f47
DEPS diff: 3fcc05638a..d05b59b211/DEPS

No update to Clang.

BUG=None

Change-Id: I37fd06ab7e6ca743d7b5c5e31f9d014d30b1d1d5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268465
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37512}
2022-07-13 14:30:37 +00:00
2b1f509f3a Disallow invalid arguments in RestoreEncodingLayers.
Changing DCHECK into CHECK for good measure.

Bug: chromium:1343889
Change-Id: I2cede85dc2d2a4238739f73afe25275047f4aa50
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268460
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37511}
2022-07-13 10:55:03 +00:00
02bfcf5132 Compare only SdpVideoFormat::name and SdpVideoFormat::parameters in the VideoEncoderFactoryTemplate.
Since https://webrtc-review.googlesource.com/c/src/+/267780 supported scalability modes are also used to compare for equality between SdpVideoFormats(?).

Bug: webrtc:14267, webrtc:13573
Change-Id: I2f3c2fca93bac6fadd222f776f672c9bd3f1de0a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268304
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37510}
2022-07-13 10:54:00 +00:00
046e6d14c2 Update WebRTC code version (2022-07-13T04:05:07).
Bug: None
Change-Id: Ic2c546424eb69731c453dc0c32f620ac7685f0dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268447
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37509}
2022-07-13 05:47:31 +00:00
b7821cea6b Remove unnecessary overload in RtcEventLogOutput
Bug: webrtc:13579
Change-Id: I3ea4b8ce8d111ae6b9ce7e92f75bd4196bc9656b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268420
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37508}
2022-07-12 22:09:36 +00:00
c8f9c56bc8 Roll chromium_revision ab0e768796..93fe9a662b (1023140:1023242)
Change log: ab0e768796..93fe9a662b
Full diff: ab0e768796..93fe9a662b

Changed dependencies
* src/base: fd85983f83..dac3821a53
* src/build: 2101e0d8a5..a33473f5b5
* src/ios: 7e47301f96..e744b922dc
* src/testing: e0e5a664f9..4137b59a49
* src/third_party: e980a80458..19b2c5f7c4
* src/third_party/fuchsia-sdk/sdk: version:8.20220712.0.1..version:8.20220712.1.1
* src/third_party/perfetto: 16cf103dc6..8fe494f32e
* src/tools: 7349389010..c662ee8ae6
DEPS diff: ab0e768796..93fe9a662b/DEPS

No update to Clang.

BUG=None

Change-Id: Ie40974bc7727f83b484c75229d79192b4d9bf144
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268440
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37507}
2022-07-12 16:34:29 +00:00