zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
37,788 Commits 1 Branch 0 Tags
7a399641078c60526ca709a2877216fd36421ccd
Commit Graph

37788 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Niels Möller
79d566b0cf New enum ScalabilityMode. 
Used instead of string representation in lower-levels of encoder configuration, to avoid string comparisons (with risk of misspelling) in lots of places.

Bug: webrtc:11607
Change-Id: I4d51c2265aac297c29976d2aa601d8ffb33b7326
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259870
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36706}
 2022-04-29 12:16:42 +00:00
Björn Terelius
cbf07f70e2 Revert "Fork //base/test/google_test_runner" 
This reverts commit 166650ada7ce6aa503bfab77dcbd7f0835b238b2.

Reason for revert: Seems to break downstream on-device ios tests.

Original change's description:
> Fork //base/test/google_test_runner
>
> (Used to run gtests on iOS, but we don't want to depend on //base.)
>
> Optimistically try to use the existing partial fork
>
> Bug: webrtc:13402
> Change-Id: I10528670862f2db67e77adb73b8a71b19642666d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260328
> Commit-Queue: Björn Terelius <terelius@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36703}

Bug: webrtc:13402
Change-Id: I5bef679e95693b7a6942375801daf9273d260e1d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260462
Auto-Submit: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Owners-Override: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36705}
 2022-04-29 11:52:22 +00:00
Niels Möller
6228d870dc Reland "Delete deprecated versions of MergeNetworkList" 
This is a reland of commit 7679e9bf071250e8e98ef6ef58962ddcc73cd498

Breakage in chrome/services/sharing/ (not built as part of webrtc
presubmit) should be fixed with
https://chromium-review.googlesource.com/c/chromium/src/+/3604642

Original change's description:
> Delete deprecated versions of MergeNetworkList
>
> Bug: webrtc:13869
> Change-Id: I6b888ba14ca664a1f28de2fb59b7d1343cb18bd8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259300
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36611}

Bug: webrtc:13869
Change-Id: I4cf0fe0f2310eabb2d0b32c6dec5f8aef64c7712
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259869
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36704}
 2022-04-29 11:19:02 +00:00
Björn Terelius
166650ada7 Fork //base/test/google_test_runner 
(Used to run gtests on iOS, but we don't want to depend on //base.)

Optimistically try to use the existing partial fork

Bug: webrtc:13402
Change-Id: I10528670862f2db67e77adb73b8a71b19642666d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260328
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36703}
 2022-04-29 10:21:42 +00:00
Christoffer Jansson
b45d4deb3b Rename MacOS perf bot to 11 to reflect OS version 
Bug: b/227442116
Change-Id: I80cf745a3a38d08c833864d2f8e4533776be2585
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260460
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36702}
 2022-04-29 09:24:13 +00:00
Gustaf Ullberg
8b8d0b5eac Check for BMI2 support before enabling AVX2 code paths 
With MSVC, compiling with AVX2 support will also result in the
generation of BMI2 instructions. Some early Haswell CPUs reportedly support AVX2 but not BMI2. We have seen crashes (illegal instruction)
on these CPUs in our AVX2 code paths on MULX instructions (part of BMI2).

Including a check for BMI2 when checking for AVX2 support is
expected to solve the issue.

Please see the bug referenced below for more background on this issue.

Bug: chromium:1315519
Change-Id: I3a0a9838f1f632704ba505ecbb81a6f8b1889319
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260323
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Henrik Andreasson <henrika@google.com>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36701}
 2022-04-29 08:41:52 +00:00
Philipp Hancke
9c83d9d99e DTLS: fail the connection if DTLSv1_handle_timeout returns an error 
which signals a permanent connection failure to the application

BUG=webrtc:13999

Change-Id: I7ba25db4aa9035583558a613db97561c48796c76
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260100
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/main@{#36700}
 2022-04-29 05:44:42 +00:00
Jeremy Leconte
2dad0a1668 Re-enable XCTests sdk_unittests on simulators. 
Bug: webrtc:12244
Change-Id: Id5cd44e93cd0221e09380d05da510b05c22e143f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259773
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36699}
 2022-04-28 19:58:31 +00:00
Jeremy Leconte
49ad2d787a Disable tests with 'method was not invoked' error on simulator 
https://chromium-swarm.appspot.com/task?id=5a663a0bbd1e4210

Bug: webrtc:13990
Change-Id: I8f6cc03e4ef4de389fa44f580be22649660c0524
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259770
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36698}
 2022-04-28 18:57:01 +00:00
Ying Wang
db0d586172 Enable variable_start_scale_factor_ by default. 
Bug: webrtc:14007
Change-Id: I1c803b4a530209ae9b47a9bd91379621f17fe685
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260186
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Ying Wang <yinwa@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36697}
 2022-04-28 18:46:41 +00:00
Harald Alvestrand
832657f162 Recommend using [[deprecated]] over ABSL_DEPRECATED 
Bug: none
Change-Id: I6018fc75d347d610d078077e7b34131efaaef0db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260160
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36696}
 2022-04-28 15:27:18 +00:00
Harald Alvestrand
19ebabc904 Separate setting a cricket::Channel from clearing the channel. 
This makes it clearer which modules set the channel.
Also remove GetChannel() from PeerConnection public API

This was only used once, internally, and can better be inlined.
Part of reducing the exposure of Channel.

Bug: webrtc:13931
Change-Id: I5f44865230a0d8314d269c85afb91d4b503e8de0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260187
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36695}
 2022-04-28 14:19:16 +00:00
philipel
90623e1a91 Check if packet in PacketBuffer was cleared before the frame was fully received. 
Bug: none
Change-Id: Iaa5702a8da93462ba80f72821f075a6673eeb0e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260324
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36694}
 2022-04-28 13:48:54 +00:00
Niels Möller
9432768024 Prepare for deletion of implicit conversion from rtc::scoped_refptr<T> to T* 
Bug: webrtc:13464
Change-Id: I4c7095d3a1c7c1a9ab609f5f1595545f6cad18db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249087
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36693}
 2022-04-28 12:58:56 +00:00
Evan Shrubsole
3801604bc7 Delete unused video_stream_decoder 
video_stream_decoder2 is the only one used.

Change-Id: Iabee3521b2946f097296cf2b02025aa6e41e87a4
Bug: webrtc:11489
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260282
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36692}
 2022-04-28 12:57:54 +00:00
Evan Shrubsole
14ee8037b0 Combine VideoReceiveStream2TestWithFakeDecoder into the main test suite 
This is achieved by wrapping a fake decoder inside the mock decoder, in
a sort of spy pattern.

This is preperation for moving the FrameBufferProxy tests into the main
VideoReceiveStream2 suite.

Bug: webrtc:14003
Change-Id: I7b9691cc5a1a8a3fadfb7aa6981752b647d5c73f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260113
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36691}
 2022-04-28 12:43:14 +00:00
Evan Shrubsole
1c18477070 Merge VideoReceiveStream2TestWithLazyDecoderCreation into main suite. 
Bug: webrtc:13997
Change-Id: I74078c07ac4a5def231a0b3339715466ea4fe542
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260112
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Reviewed-by: Johannes Kron <kron@google.com>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36690}
 2022-04-28 12:28:24 +00:00
Tommi
b44a794bd3 Remove sigslot inheritance from Connection 
...and add to TCPConnection as it's still needed there.

Bug: webrtc:11943
Change-Id: Id66b890677d7e0b03a4a700414f574abd6e3af58
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260320
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36689}
 2022-04-28 11:40:44 +00:00
Christoffer Jansson
69edcaf47b relax dimensions for mac perf bot to allow MacOS 11 upgrade 
Bug: b/227442116
Change-Id: I30d8002997519f348988e2867c9a5f4935a265de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260281
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36688}
 2022-04-28 10:17:34 +00:00
Florent Castelli
87b6e7beff An rtc_library with no source file should be an rtc_source_set 
Bug: webrtc:9838
Change-Id: I9b8db581e3e180aff11ffc38b1c9155b2bd3671c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260060
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36687}
 2022-04-28 10:03:23 +00:00
Rasmus Brandt
e890e36c99 PCLF: Reserve vector before pushing. 
Bug: None
Change-Id: I961f555085032330028b426e46a2c4ac576a2b03
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260283
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36686}
 2022-04-28 09:49:34 +00:00
Evan Shrubsole
d425f506ad Switch VideoReceiveStream2 internals to Time units 
Change-Id: Ifcee6372120e968499acbdf3bf2c0d002d1c4724
Bug: webrtc:13756
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259777
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Johannes Kron <kron@google.com>
Cr-Commit-Position: refs/heads/main@{#36685}
 2022-04-28 09:38:54 +00:00
Jeremy Leconte
72efd91d1f Re-enable XCTests apprtcmobile_tests on simulators. 
Bug: webrtc:12244
Change-Id: Idca6bcc1505b0b9ceadfafbe128d64d53800f34a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260280
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36684}
 2022-04-28 08:31:03 +00:00
Victor Boivie
01a0db2e74 dcsctp: Don't re-nack a fragment until sent again 
This is mainly an issue when sending items with partial reliability,
with high bandwidth on a link with packet loss.

In SCTP, when a fragment isn't included in the SACK a number of times,
it's scheduled to be retransmitted or abandoned, if it has been
retransmitted too many times already (depending configuration). Before
this CL, if a fragment was NACKed and scheduled for retransmission, but
couldn't be retransmitted immediately (due to congestion window not
allowing it), future received SACKs - that would still indicate that the
fragment hasn't been received yet - would still increment the
retransmission counter. Which wasn't fair, because this fragment hasn't
had a chance to be retransmitted yet.

With this CL, the fragment will only have its retransmission counter
increased when it is not already scheduled to be retransmitted, but
actually sent on the wire and considered in-flight again.

Bug: webrtc:12943
Change-Id: I2af08255650221c044cc14591a5835c885e94c58
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259825
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36683}
 2022-04-28 08:28:33 +00:00
Niels Möller
03486fc197 Update sdk/ to not use implicit conversion from scoped_refptr<T> to T*. 
Bug: webrtc:13464
Change-Id: I6944106ddc99c043825fad077bfcedc051c67d8f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259772
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36682}
 2022-04-28 08:10:15 +00:00
Jeremy Leconte
3ba35c3fe2 Disable ARDAppClientTest testSession on simulator. 
https://chromium-swarm.appspot.com/task?id=5a6639e482cef910

Bug: webrtc:13991
Change-Id: I82a7cc0f6b37a199731b1bc87500e7daf48ac1fc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259824
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36681}
 2022-04-28 07:39:23 +00:00
webrtc-version-updater
c61c9783f5 Update WebRTC code version (2022-04-28T04:04:23). 
Bug: None
Change-Id: Iffe5715813f546971b26f8fe95f384a7134c7b29
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260206
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36680}
 2022-04-28 05:53:03 +00:00
chromium-webrtc-autoroll
d2cd1effb8 Roll chromium_revision 54022bd20c..6d7878cb33 (996901:997007) 
Change log: 54022bd20c..6d7878cb33
Full diff: 54022bd20c..6d7878cb33

Changed dependencies
* src/base: 1dfa35a61e..8261266302
* src/ios: 30b255ab27..ac2b722342
* src/testing: 5441c96431..b926234b2f
* src/third_party: 60ab194b65..9bef587db2
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/46b602cdaf..ef89d1327c
* src/third_party/depot_tools: 41c57603f9..381db68adc
* src/tools: e3eb6453c8..8ca1cca79e
DEPS diff: 54022bd20c..6d7878cb33/DEPS

No update to Clang.

BUG=None

Change-Id: Iaca47727de4c05e22015f390f02ae320ad9133c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260261
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36679}
 2022-04-28 02:43:41 +00:00
chromium-webrtc-autoroll
f175a06e0a Roll chromium_revision d99fb1b634..54022bd20c (996791:996901) 
Change log: d99fb1b634..54022bd20c
Full diff: d99fb1b634..54022bd20c

Changed dependencies
* src/base: e195c45eee..1dfa35a61e
* src/build: db4af2b106..87b04ad665
* src/buildtools/linux64: git_revision:d18426e45644d2024370c389725b8334d43b85c7..git_revision:ecec350e71ea4600f7bde967854e083fbc53a37f
* src/buildtools/mac: git_revision:d18426e45644d2024370c389725b8334d43b85c7..git_revision:ecec350e71ea4600f7bde967854e083fbc53a37f
* src/buildtools/win: git_revision:d18426e45644d2024370c389725b8334d43b85c7..git_revision:ecec350e71ea4600f7bde967854e083fbc53a37f
* src/ios: 00a62f142a..30b255ab27
* src/testing: 3e2b87734e..5441c96431
* src/third_party: 5961ddc264..60ab194b65
* src/third_party/depot_tools: ff14b61068..41c57603f9
* src/third_party/freetype/src: ed4d0710f1..6fb7b7a09d
* src/tools: 80693fbb67..e3eb6453c8
DEPS diff: d99fb1b634..54022bd20c/DEPS

No update to Clang.

BUG=None

Change-Id: Ie1a0d862782330ed0c6d22c66ddc3022a091c730
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260240
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36678}
 2022-04-27 23:06:41 +00:00
Tommi
76d9c18c3a Minor tweaks to the stdlib TQ implementation. 
Remove the `started_` member variable and some other minor updates to
follow conventions elsewhere in the code.

Bug: none
Change-Id: I4cbb914b39cb2e2787719b906ca937931dc3dad7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258360
Reviewed-by: Markus Handell <handellm@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36677}
 2022-04-27 22:42:16 +00:00
Tommi
942cac2e9e Make deletion of Connection objects more deterministic. 
This changes most deletion paths of Connection objects to go through
the owner class of the Connection instances, Port.

In situations where Connection objects still need to be deleted
asynchronously, `async = true` can be passed to
`Port::DestroyConnection` and get the same behavior as
`Connection::Destroy` formerly gave.

The `Destroy()` method still exists for downstream compatibility, but
instead of deleting connection objects asynchronously, the deletion
now happens synchronously via the Port class.

Bug: webrtc:13892, webrtc:13865
Change-Id: I07edb7bb5e5d93b33542581b4b09def548de9e12
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259826
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36676}
 2022-04-27 21:52:31 +00:00
chromium-webrtc-autoroll
720aa9d5c7 Roll chromium_revision 22462f9b4d..d99fb1b634 (996643:996791) 
Change log: 22462f9b4d..d99fb1b634
Full diff: 22462f9b4d..d99fb1b634

Changed dependencies
* src/base: 460afaf51f..e195c45eee
* src/build: c15c075ba6..db4af2b106
* src/ios: 2622210e0e..00a62f142a
* src/testing: 960cc298af..3e2b87734e
* src/third_party: c0d8105792..5961ddc264
* src/third_party/depot_tools: 564f1eee96..ff14b61068
* src/tools: 8c1b825845..80693fbb67
DEPS diff: 22462f9b4d..d99fb1b634/DEPS

No update to Clang.

BUG=None

Change-Id: I9637b5be68a7cbe3e76876b1068e1ab66cb32039
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260203
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36675}
 2022-04-27 18:52:41 +00:00
Harald Alvestrand
65685a65f2 Move pc/channel.h to only be used in .cc files 
This is an implementation API, user classes should in principle
only use the channel_interface.h

Bug: webrtc:13931
Change-Id: I85c285217858dc087c90a50792e980f731f4439f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260185
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36674}
 2022-04-27 17:13:11 +00:00
Niels Möller
df209e797b Avoid more usage of implicit conversion from scoped_refptr<T> to T* 
Update api/, call/, examples/ and rtc_tools/.

Bug: webrtc:13464
Change-Id: I7b0008cca68c579e89b45527a45300d1e67c3483
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260000
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36673}
 2022-04-27 13:18:30 +00:00
chromium-webrtc-autoroll
e7d998cb64 Roll chromium_revision d72fd4a488..22462f9b4d (996483:996643) 
Change log: d72fd4a488..22462f9b4d
Full diff: d72fd4a488..22462f9b4d

Changed dependencies
* src/base: 5e69a10028..460afaf51f
* src/build: 50e14eb904..c15c075ba6
* src/buildtools/linux64: git_revision:ced9fbfe6943854e65ada4ac1849d1fa4cb19348..git_revision:d18426e45644d2024370c389725b8334d43b85c7
* src/buildtools/mac: git_revision:ced9fbfe6943854e65ada4ac1849d1fa4cb19348..git_revision:d18426e45644d2024370c389725b8334d43b85c7
* src/buildtools/third_party/libc++abi/trunk: 7d9bbeb389..a53022fa7e
* src/buildtools/third_party/libunwind/trunk: fe26c4b100..43a7a256a0
* src/buildtools/win: git_revision:ced9fbfe6943854e65ada4ac1849d1fa4cb19348..git_revision:d18426e45644d2024370c389725b8334d43b85c7
* src/ios: 3788a5cbc7..2622210e0e
* src/testing: 6c9a6f9eea..960cc298af
* src/third_party: 4c5c0dca47..c0d8105792
* src/third_party/depot_tools: 87172073a6..564f1eee96
* src/third_party/perfetto: 0b75597e27..2f647cd610
* src/tools: 831b397d17..8c1b825845
DEPS diff: d72fd4a488..22462f9b4d/DEPS

No update to Clang.

BUG=None

Change-Id: I5e0abc6f9bb3790835bd231f822f92bfec2e21d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260123
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36672}
 2022-04-27 13:13:52 +00:00
Artem Titov
d8e84b1ab1 [PCLF] Remove video_configs and video_subscription from Params 
Bug: b/213863770
Change-Id: I0b6758dd52ebe5c2543a8423cff7c6820d9c5320
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260183
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36671}
 2022-04-27 13:03:03 +00:00
Erik Språng
cb56827c55 Abstract the pacer queue behind an interface. 
This will make it easier to extend testing, implement new features (e.g.
packet culling) and experiment with new variants.

Bug: webrtc:11340
Change-Id: I747f5f6cff61e11a420e43b06ffe0c4aba438c7b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260116
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36670}
 2022-04-27 11:58:55 +00:00
Henrik Boström
a8ad11de82 [Rollback] Don't end tracks when transceiver is still in use. 
Prior to this CL, calling RtpTransceiver::SetChannel() with null
arguments would cause the receiver's track to end. This is wrong,
because the channel can be nulled for other reasons than the transceiver
being stopped/removed - such as when the transceiver is rolled back but
still in use. Also, stopping a transceiver will end the track, so we
should simply ensure to always stop the transceiver when that is needed.

This CL makes sure that the transceiver is stopped or stopping in all
appropriate places, allowing us to remove the ability to end the source
for any other reason. A side-effect of this is that:
- The track never ends prematurely, fixing https://crbug.com/1315611.
- Removed transceivers are always stopped, fixing
  https://crbug.com/webrtc/14005.

This CL fixes the issue of track being ended in the ontrack event when
running https://jsfiddle.net/henbos/nxebusjm/.
- We don't have WPT test coverage for this, so I'll add that separately.

With SetSourceEnded() removed, some stopping/stop in response to
rejecting locally SDP munged content had to be added in order not to
regress the existing test coverage for this:
*PeerConnectionInterfaceTest.RejectMediaContent/1

Bug: chromium:1315611, webrtc:14005.
Change-Id: I21f30a1259e51324066dc84f72a72485b9e0fadc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260180
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36669}
 2022-04-27 11:57:52 +00:00
Artem Titov
a92d051e0f [PCLF] Introduce API to safely mutate ConfigurableParams in TestPeer 
Bug: b/213863770
Change-Id: I90b7b5cd55ac5a8ebee5d790205a4fa6700dfff4
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260117
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36668}
 2022-04-27 11:00:11 +00:00
Jeremy Leconte
24eb595587 Switch iOS bots to xcode 13. 
Bug: b/228171822
Change-Id: I03bf0283d86d3c8a8ba2e04ea1469579bb15bf4a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260181
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36667}
 2022-04-27 10:09:21 +00:00
webrtc-version-updater
0f6d406d84 Update WebRTC code version (2022-04-27T04:03:53). 
Bug: None
Change-Id: I890088b0f16c7640ba630a069f02b015960b51df
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260121
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36666}
 2022-04-27 08:51:40 +00:00
Jeremy Leconte
225c308af0 Upgrade iOS simulator bots from Mac-10.15 to Mac-11. 
Bug: chromium:1263538
No-Try: true
Change-Id: I2d20360e5daf1f3907364b51859f7f90d216d58a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260118
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36665}
 2022-04-27 07:52:45 +00:00
chromium-webrtc-autoroll
95e089aa35 Roll chromium_revision d4a5c8a861..d72fd4a488 (996345:996483) 
Change log: d4a5c8a861..d72fd4a488
Full diff: d4a5c8a861..d72fd4a488

Changed dependencies
* src/base: dadaf304ed..5e69a10028
* src/build: b19012d7f1..50e14eb904
* src/ios: 2bac82fefa..3788a5cbc7
* src/testing: 85b5a22589..6c9a6f9eea
* src/third_party: 8e307392aa..4c5c0dca47
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/74c0bf3d68..46b602cdaf
* src/third_party/depot_tools: 7feb245cf5..87172073a6
* src/tools: 23cf0027de..831b397d17
DEPS diff: d4a5c8a861..d72fd4a488/DEPS

No update to Clang.

BUG=None

Change-Id: I2a2e884efbd3060a24c31c0df0b428bf32bcb799
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260120
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36664}
 2022-04-27 05:23:32 +00:00
chromium-webrtc-autoroll
f590261a68 Roll chromium_revision 8e406e0040..d4a5c8a861 (996209:996345) 
Change log: 8e406e0040..d4a5c8a861
Full diff: 8e406e0040..d4a5c8a861

Changed dependencies
* src/base: cd81686c6b..dadaf304ed
* src/build: 1323d36646..b19012d7f1
* src/buildtools/linux64: git_revision:d0f8bc99e0584cd33ea8030441d58ee875af7842..git_revision:ced9fbfe6943854e65ada4ac1849d1fa4cb19348
* src/buildtools/mac: git_revision:d0f8bc99e0584cd33ea8030441d58ee875af7842..git_revision:ced9fbfe6943854e65ada4ac1849d1fa4cb19348
* src/buildtools/win: git_revision:d0f8bc99e0584cd33ea8030441d58ee875af7842..git_revision:ced9fbfe6943854e65ada4ac1849d1fa4cb19348
* src/ios: 422dabc9a2..2bac82fefa
* src/testing: 43db41dac7..85b5a22589
* src/third_party: 9e96655fe4..8e307392aa
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/820618f8e6..74c0bf3d68
* src/tools: afc9923655..23cf0027de
DEPS diff: 8e406e0040..d4a5c8a861/DEPS

No update to Clang.

BUG=None

Change-Id: Id58621ba392663135a2c5744487ad16d797a69d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260086
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36663}
 2022-04-26 20:48:46 +00:00
Artem Titov
82caafd607 [PCLF] Make PeerParamsPreprocessor C++ style compliant 
Bug: b/213863770
Change-Id: I9749ac9fdc5561c1bc145b199a2e39633615938b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260111
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36662}
 2022-04-26 19:14:15 +00:00
Artem Titov
10f42a3b62 [PCLF] Remove TestPeer::params2() 
Bug: b/213863770
Change-Id: Id11e7a7693c29077a333f017b2080e69877149db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260110
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36661}
 2022-04-26 18:15:35 +00:00
Harald Alvestrand
e2c780ea24 Reland "Add canonical mock for MediaStreamInterface" 
This reverts commit fc61750523120d0d7d7b02e4f6af7fb607a6b824.

Reason for revert: Fixed downstream project.

Original change's description:
> Revert "Add canonical mock for MediaStreamInterface"
>
> This reverts commit e217217bf3782dbd3ea27be33d5ebd26ae0500ca.
>
> Reason for revert: break upstream project (name collision)
>
> Original change's description:
> > Add canonical mock for MediaStreamInterface
> >
> > Needed to let upstream APIs integrate changes more easily.
> >
> > Bug: webrtc:13980
> > Change-Id: I6cd46f75d56597c10e08d0d66e16089516f5129c
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259821
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> > Reviewed-by: Niels Moller <nisse@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#36613}
>
> Bug: webrtc:13980
> Change-Id: I18b91327225e0f844af5dd86c9b4ca8d6301d03e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259860
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36614}

Bug: webrtc:13980
Change-Id: I84dbe5ec754389d30e5d22f9f9553fd9e9ee5bd5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260115
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36660}
 2022-04-26 17:23:45 +00:00
chromium-webrtc-autoroll
b767350e48 Roll chromium_revision 2fafc86d5a..8e406e0040 (996031:996209) 
Change log: 2fafc86d5a..8e406e0040
Full diff: 2fafc86d5a..8e406e0040

Changed dependencies
* src/base: ad6a819bf0..cd81686c6b
* src/build: 13e929691f..1323d36646
* src/ios: 741fa9bbdb..422dabc9a2
* src/testing: 338ce53949..43db41dac7
* src/third_party: fddac3310a..9e96655fe4
* src/third_party/freetype/src: 581dd06405..ed4d0710f1
* src/third_party/perfetto: bbe5831b28..0b75597e27
* src/tools: 9e0d2003d8..afc9923655
DEPS diff: 2fafc86d5a..8e406e0040/DEPS

No update to Clang.

BUG=None

Change-Id: Ib6ff9ec9f9c66858cf617efb46d23c6bf1825108
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260084
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36659}
 2022-04-26 16:49:45 +00:00
Artem Titov
b2ed905eb3 [PCLF] Extract configurable params from params 
Bug: b/213863770
Change-Id: I6d4f5f3910c315da7fe5dfa7088da769b9f87212
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260109
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36658}
 2022-04-26 15:10:15 +00:00
Artem Titov
e92378eb71 [PCLF] update old TestPeer::params to new signature 
Step 2 for https://webrtc-review.googlesource.com/c/src/+/260003

Bug: b/213863770
Change-Id: I04e9cd890aad1a3fbdd881b259cd9a95007d79ec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260042
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36657}
 2022-04-26 10:32:25 +00:00