b93e2240f1
Roll chromium_revision 3c219c13d3..7c22988b10 (976297:976475)
...
Change log: 3c219c13d3..7c22988b103c219c13d3..7c22988b102c3f10d296..e87c822a9d2a53b6c0cd..aabb6b9fdd03ed7e4bd5..b28def56aa912f58bd45..cd7ad61e12566a36179b..942a7273f7https://chromium.googlesource.com/catapult.git/+log/2cfdaa8ce0..d62cc7b294
* src/third_party/depot_tools: ca9706d139..a255e4064ad580756862..eafb007f403c219c13d3..7c22988b10https://webrtc-review.googlesource.com/c/src/+/253202
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36106}
2022-03-02 00:51:27 +00:00
c1ed7ef491
Roll chromium_revision 6e70e8eefd..3c219c13d3 (976191:976297)
...
Change log: 6e70e8eefd..3c219c13d36e70e8eefd..3c219c13d36b6ba00571..2a53b6c0cd2ea265b95a..d1c7f92b8bd487126e91..03ed7e4bd59d8d8b3e7e..912f58bd45d14b82e7e2..566a36179be18670641d..d5807568626e70e8eefd..3c219c13d3https://webrtc-review.googlesource.com/c/src/+/253180
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36105}
2022-03-01 18:14:58 +00:00
7619b7c078
Add tests for FrameBuffer3 and SyncDecoding in PC Integration Tests
...
Change-Id: I04ae6a694599a535347c29706e5ad40cba58155b
Bug: webrtc:13672
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251721
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36104}
2022-03-01 15:22:48 +00:00
42da5a9a10
Keep RTCTransportStats on P2PTransportChannel.
...
This cl/ changes so that the RTCTransportStats bytes/packets
sent/recevied is computed in P2PTransportChannel. Previously
they were computed by aggregating over the Connections, but that
does not work when Connections are created and destroyed.
Bug: webrtc:13769
Change-Id: Ia97dfae70b5aced897d4813ec007ba61bc032f87
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253100
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36103}
2022-03-01 14:31:29 +00:00
4d278e2caf
Adopt absl::string_view in function parameters under audio/
...
This is part of a large-scale effort to adopt absl::string_view
throughout the WebRTC code base. As a first step, function parameters
of type 'const std::string&' are being converted to absl::string_view.
Bug: webrtc:13579
Change-Id: Ib4618fad3bff2902cd3a4730506aca300949d76c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252982
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Ali Tofigh <alito@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36102}
2022-03-01 13:11:08 +00:00
8290040848
Roll chromium_revision cfa2b8c65a..6e70e8eefd (976087:976191)
...
Change log: cfa2b8c65a..6e70e8eefdcfa2b8c65a..6e70e8eefd78ef4ca402..2c3f10d29615cbd56453..6b6ba005718215caa039..d487126e9114ff931d6b..9d8d8b3e7e2ded82c42c..d14b82e7e271ce93cbdb..e18670641dcfa2b8c65a..6e70e8eefdhttps://webrtc-review.googlesource.com/c/src/+/253086
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36101}
2022-03-01 12:58:22 +00:00
d4ff12f219
Increment frame count once for duplicate frame with FrameBuffer3
...
R=philipel@webrtc.org
Change-Id: I9a961417f86fd1f968a42730249d479e3ebd4784
Bug: webrtc:13343, webrtc:13755
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252583
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36100}
2022-03-01 10:42:29 +00:00
c6d3a7a691
Ensure returned delay based estimate from probe can be clamped by
...
AimdRateControl
AimdRateControl can potentially clamp bitrate in SetEstimate.
DelayBasedBwe::MaybeUpdateEstimate should therefore check the result before using the probe bitrate.
Otherwise, BWE may drop on next update.
Bug: none
Change-Id: I8b1b3549a2bcd981e941b1cc802c984828d68261
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252444
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36099}
2022-03-01 09:45:30 +00:00
7601fd7677
Roll chromium_revision e7e24761b3..cfa2b8c65a (975961:976087)
...
Change log: e7e24761b3..cfa2b8c65ae7e24761b3..cfa2b8c65a8b8ac0f913..78ef4ca40223792fc6dd..15cbd564533857cf82d1..8215caa039a19dd7d755..14ff931d6b87a4c1f6ca..2ded82c42chttps://chromium.googlesource.com/catapult.git/+log/666eff907b..2cfdaa8ce0
* src/third_party/depot_tools: c9a747c5ed..ca9706d139134b9ef223..54ba566cddc1d5031d2a..71ce93cbdbe7e24761b3..cfa2b8c65ahttps://webrtc-review.googlesource.com/c/src/+/253082
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36098}
2022-03-01 04:50:10 +00:00
07e021c780
Roll chromium_revision 49eada12dd..e7e24761b3 (975776:975961)
...
Change log: 49eada12dd..e7e24761b349eada12dd..e7e24761b3e15c62baac..8b8ac0f91308f54b6250..23792fc6dd6e5f66b2b7..3857cf82d1f6930e6ad1..a19dd7d755fbde1dab6d..87a4c1f6cacce2b0564d..b010080fea6b28c1ddef..c9a747c5ed5bc4f42913..134b9ef223087435a449..c1d5031d2a49eada12dd..e7e24761b3https://webrtc-review.googlesource.com/c/src/+/253060
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36097}
2022-02-28 22:51:27 +00:00
141007668c
Add field trial for limiting probes and delay based estimates to link
...
capacity.
Allow delay based estimate to increase up to 85% of the current NetworkStateEstimate
even if in ALR. The estimate may not increase higher than that.
WebRTC-Bwe-EstimateBoundedIncrease/ratio:0.85,ignore_acked:true
Bug: none
Change-Id: I6f34af7fab03082ca168e624ddea06f216790fbc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252442
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36096}
2022-02-28 17:29:37 +00:00
5a5a775a88
Roll chromium_revision 45ec87b29f..49eada12dd (975667:975776)
...
Change log: 45ec87b29f..49eada12dd45ec87b29f..49eada12dd402f200100..e15c62baac3651f40a5d..08f54b62509f0a2dddd9..6e5f66b2b78bf5b5b5e9..f6930e6ad116c2bd0c52..fbde1dab6d5b5f79bbdb..5bc4f42913d82d1d5395..087435a44945ec87b29f..49eada12ddhttps://webrtc-review.googlesource.com/c/src/+/253001
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36095}
2022-02-28 16:52:37 +00:00
c2b1bad4c8
In RtcpTransceiver use TimeDelta instead of raw int to represent time
...
Bug: webrtc:8239, webrtc:13757
Change-Id: Idda3fe5761665b4b3fedaf2dd1a28bb0119ae1f1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252287
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36094}
2022-02-28 11:21:17 +00:00
9af4aa7cf4
Reland "Represent RtpPacketToSend::capture_time with Timestamp"
...
This reverts commit 56db8d09529d5ba92d24954a1d78a90c8ea2cd85.
Reason for revert: downstream problem addressed
Original change's description:
> Revert "Represent RtpPacketToSend::capture_time with Timestamp"
>
> This reverts commit 385eb9714daa80306d2f92d36678c42892dab555.
>
> Reason for revert: Causes problems downstream:
>
> #
> # Fatal error in: rtc_base/units/unit_base.h, line 122
> # last system error: 0
> # Check failed: value >= 0 (-234 vs. 0)
>
> Original change's description:
> > Represent RtpPacketToSend::capture_time with Timestamp
> >
> > Bug: webrtc:13757
> > Change-Id: I0ede22cd34e3a59afe1477d8edd495dce64e3242
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252586
> > Reviewed-by: Erik Språng <sprang@webrtc.org >
> > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> > Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#36083}
>
> Bug: webrtc:13757
> Change-Id: I8442abd438be8726cf671d0f372d50ecfac6847e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252720
> Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org >
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36087}
Bug: webrtc:13757
Change-Id: I1fa852757480116f35deb2b6c3c27800bdf5e197
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252781
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36093}
2022-02-28 10:04:37 +00:00
6ccd74816a
Roll chromium_revision b566a7ee01..45ec87b29f (975563:975667)
...
Change log: b566a7ee01..45ec87b29fb566a7ee01..45ec87b29f6f29f6c02a..3651f40a5dd3d38e3db5..9f0a2dddd9d607f42a01..8bf5b5b5e98b03c87b78..16c2bd0c52b5781f6627..d82d1d5395b566a7ee01..45ec87b29fhttps://webrtc-review.googlesource.com/c/src/+/252921
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36092}
2022-02-28 06:39:55 +00:00
c5f6201131
Update WebRTC code version (2022-02-28T04:03:34).
...
Bug: None
Change-Id: I9a9770fff882ecd0b1d0a7c4dc3e26b110fbee1c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252886
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36091}
2022-02-28 05:30:05 +00:00
8e5a64ae7e
Roll chromium_revision 5688012168..b566a7ee01 (975461:975563)
...
Change log: 5688012168..b566a7ee015688012168..b566a7ee0148b4cff6a5..6f29f6c02a5969559967..d3d38e3db5e5a7a6719a..d607f42a01dd5821349b..8b03c87b7821f13c8e61..b5781f66275688012168..b566a7ee01https://webrtc-review.googlesource.com/c/src/+/252881
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36090}
2022-02-27 14:35:55 +00:00
52d6c57c6f
Update WebRTC code version (2022-02-27T04:02:16).
...
Bug: None
Change-Id: I224b7dfb956c9455b5730e0b41dd450a202756bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252842
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36089}
2022-02-27 05:20:35 +00:00
1dddc7f7f9
Roll chromium_revision d418bb1e88..5688012168 (975168:975461)
...
Change log: d418bb1e88..5688012168d418bb1e88..56880121682dfd7c2422..402f2001001825abc1e5..48b4cff6a58cd7191937..2ea265b95a603214b04e..5969559967e867c867ab..e5a7a6719ad4b6f1bfd0..dd5821349bhttps://chromium.googlesource.com/catapult.git/+log/392c66f379..666eff907b
* src/third_party/perfetto: 7a29efcb91..5b5f79bbdbeeb2fef42d..21f13c8e61d418bb1e88..5688012168https://webrtc-review.googlesource.com/c/src/+/252740
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36088}
2022-02-26 12:50:23 +00:00
56db8d0952
Revert "Represent RtpPacketToSend::capture_time with Timestamp"
...
This reverts commit 385eb9714daa80306d2f92d36678c42892dab555.
Reason for revert: Causes problems downstream:
#
# Fatal error in: rtc_base/units/unit_base.h, line 122
# last system error: 0
# Check failed: value >= 0 (-234 vs. 0)
Original change's description:
> Represent RtpPacketToSend::capture_time with Timestamp
>
> Bug: webrtc:13757
> Change-Id: I0ede22cd34e3a59afe1477d8edd495dce64e3242
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252586
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36083}
Bug: webrtc:13757
Change-Id: I8442abd438be8726cf671d0f372d50ecfac6847e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252720
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36087}
2022-02-26 10:35:13 +00:00
1db3c7435e
Update WebRTC code version (2022-02-26T04:02:50).
...
Bug: None
Change-Id: I891285668308f55a7c96115e1e74e8922229f193
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252628
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36086}
2022-02-26 05:20:43 +00:00
7c2e958711
Add a guard against double delete to Connection::Destroy
...
Bug: webrtc:13752
Change-Id: I80345fe2e560773f9f98f850def386ec53ae798f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252660
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36085}
2022-02-25 23:43:03 +00:00
a33a28f360
Roll chromium_revision 0e95c9b57e..d418bb1e88 (975060:975168)
...
Change log: 0e95c9b57e..d418bb1e880e95c9b57e..d418bb1e8842d67a004d..2dfd7c24229e7c4ed752..1825abc1e5eac958fe5e..603214b04eaea4a23ebb..d4b6f1bfd0dfc6cffca9..7a29efcb91d6bfa6aaf0..eeb2fef42d0e95c9b57e..d418bb1e88https://webrtc-review.googlesource.com/c/src/+/252640
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36084}
2022-02-25 18:29:52 +00:00
385eb9714d
Represent RtpPacketToSend::capture_time with Timestamp
...
Bug: webrtc:13757
Change-Id: I0ede22cd34e3a59afe1477d8edd495dce64e3242
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252586
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36083}
2022-02-25 16:44:07 +00:00
8382968781
Reland "Remove workaround in AutoSocketServerThread that isn't needed anymore."
...
This reverts commit e4d3952bf0b05b825992f1023a106f3bcf34946e.
Reason for revert: Speculative revert.
Original change's description:
> Revert "Remove workaround in AutoSocketServerThread that isn't needed anymore."
>
> This reverts commit 44156fa024cbf12f052a35571ac91bc9907be6c3.
>
> Reason for revert: Needed in order to revert https://webrtc-review.googlesource.com/c/src/+/249941 , which introduced a crash
>
> Original change's description:
> > Remove workaround in AutoSocketServerThread that isn't needed anymore.
> >
> > Cleanup steps for the Connection class have changed as of:
> > https://webrtc-review.googlesource.com/c/src/+/249941
> >
> > However, it turns out that the PortTest suite still needs it, so the
> > workaround has migrated to there.
> >
> > Bug: none
> > Change-Id: Ia68f47b6c65b3a8fd5e8c04d70a43d15ba1a6422
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250223
> > Reviewed-by: Niels Moller <nisse@webrtc.org >
> > Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#35894}
>
> Bug: none
> Change-Id: I13a4a79ebcb864054d14c1ba7726e18e044e3bd4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252542
> Auto-Submit: Taylor Brandstetter <deadbeef@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36076}
No-Try: True
Bug: none
Change-Id: If39bb2f26349c42c2377ed9f80c26eb18d90869f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252585
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36082}
2022-02-25 11:33:32 +00:00
0cb1cfa69e
Reland "Removing MessageHandler dependency from Connection."
...
This reverts commit 05ea12e5136493a8977e0bb4a81a6ff8d06ec92f.
Reason for revert: Speculative revert.
Original change's description:
> Revert "Removing MessageHandler dependency from Connection."
>
> This reverts commit 3202e29f72b4f511fcf6e92ef9b0dcbfee6089ff.
>
> Reason for revert: Introduced a crash in the task posted by Destroy()
>
> Original change's description:
> > Removing MessageHandler dependency from Connection.
> >
> > Bug: webrtc:11988
> > Change-Id: Ic35bb5baeafbda7210012dceb0d6d5f5b3eb95c9
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249941
> > Reviewed-by: Niels Moller <nisse@webrtc.org >
> > Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#35890}
>
> No-Try: True
> Bug: webrtc:11988
> Change-Id: Ie70ee145fde75b8cf76b02784176970e7a78e001
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252541
> Auto-Submit: Taylor Brandstetter <deadbeef@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36078}
No-Try: True
Bug: webrtc:11988
Change-Id: Idfd42d016e81d4352839c33dcb4ea3b0dafea08b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252584
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36081}
2022-02-25 11:01:54 +00:00
1e98e7bf92
p2p: Add field trial WebRTC-SetSocketReceiveBuffer
...
This field trial sets a non-zero receive buffer on the media UDP socket
with the intention to result in less packet loss in situations when the
application can't read packets fast enough from the socket. This can be
due to e.g. external factors, e.g. operating system not scheduling the
application for a longer time, or due to internal factors, e.g. slow
processing, a long running garbage collector, and more.
The size as set as the field trial parameter, as e.g.
WebRTC-SetSocketReceiveBuffer/Enabled-250/ to set it to 250kb.
Bug: webrtc:13753
Change-Id: Iae38d0db0c595d6e0148a2fdeb85ee8895e90560
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252581
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36080}
2022-02-25 11:00:12 +00:00
cb24158698
Reland "Reland "Refactor AnalyzerConfig to use Timestamps instead of microseconds.""
...
This reverts commit 7306c75c12e6dd70e1f1a0904b6bda347423a556.
Reason for revert: Downstream updated
Original change's description:
> Revert "Reland "Refactor AnalyzerConfig to use Timestamps instead of microseconds.""
>
> This reverts commit 7a992e21b9c3ff03aa34488a9c91fa580ca4faa6.
>
> Reason for revert: Breaks downstream build due to type change.
>
> Original change's description:
> > Reland "Refactor AnalyzerConfig to use Timestamps instead of microseconds."
> >
> > This is a reland of 43fb16921b29ecd3a2d87876dda75c575e05f66a
> >
> > Original change's description:
> > > Refactor AnalyzerConfig to use Timestamps instead of microseconds.
> > >
> > > Add optional offset-to-UTC parameter to output. This allows aligning
> > > the x-axis in the generated charts to other UTC-based logs.
> > >
> > > Bug: b/215140373
> > > Change-Id: I65bcd295718acbb8c94e363907c1abc458067bfd
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250203
> > > Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
> > > Commit-Queue: Björn Terelius <terelius@webrtc.org >
> > > Cr-Commit-Position: refs/heads/main@{#35992}
> >
> > Bug: b/215140373
> > Change-Id: Id2b88cc4b8078a97275d49a617581cbbd02d2c6f
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252380
> > Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
> > Commit-Queue: Björn Terelius <terelius@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#36066}
>
> Bug: b/215140373
> Change-Id: I951ac26b8176e58da18e93835f13f6b9deb6d4fa
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252443
> Auto-Submit: Björn Terelius <terelius@webrtc.org >
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Commit-Queue: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36068}
Bug: b/215140373
Change-Id: Ie2b9a961d1e09dbeabeb6bfb02b43c047df69515
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252582
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
Cr-Commit-Position: refs/heads/main@{#36079}
2022-02-25 10:48:32 +00:00
05ea12e513
Revert "Removing MessageHandler dependency from Connection."
...
This reverts commit 3202e29f72b4f511fcf6e92ef9b0dcbfee6089ff.
Reason for revert: Introduced a crash in the task posted by Destroy()
Original change's description:
> Removing MessageHandler dependency from Connection.
>
> Bug: webrtc:11988
> Change-Id: Ic35bb5baeafbda7210012dceb0d6d5f5b3eb95c9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249941
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35890}
No-Try: True
Bug: webrtc:11988
Change-Id: Ie70ee145fde75b8cf76b02784176970e7a78e001
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252541
Auto-Submit: Taylor Brandstetter <deadbeef@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36078}
2022-02-25 10:41:13 +00:00
9aa4aebee5
Roll chromium_revision 2136e05894..0e95c9b57e (974952:975060)
...
Change log: 2136e05894..0e95c9b57e2136e05894..0e95c9b57ef982200c74..9e7c4ed75214c5557274..eac958fe5ef039863bab..e867c867ab84f3d6bf8f..aea4a23ebbhttps://chromium.googlesource.com/catapult.git/+log/62a74cf243..392c66f379
* src/tools: ebe914c964..d6bfa6aaf02136e05894..0e95c9b57ehttps://webrtc-review.googlesource.com/c/src/+/252601
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36077}
2022-02-25 10:38:42 +00:00
e4d3952bf0
Revert "Remove workaround in AutoSocketServerThread that isn't needed anymore."
...
This reverts commit 44156fa024cbf12f052a35571ac91bc9907be6c3.
Reason for revert: Needed in order to revert https://webrtc-review.googlesource.com/c/src/+/249941 , which introduced a crash
Original change's description:
> Remove workaround in AutoSocketServerThread that isn't needed anymore.
>
> Cleanup steps for the Connection class have changed as of:
> https://webrtc-review.googlesource.com/c/src/+/249941
>
> However, it turns out that the PortTest suite still needs it, so the
> workaround has migrated to there.
>
> Bug: none
> Change-Id: Ia68f47b6c65b3a8fd5e8c04d70a43d15ba1a6422
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250223
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35894}
Bug: none
Change-Id: I13a4a79ebcb864054d14c1ba7726e18e044e3bd4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252542
Auto-Submit: Taylor Brandstetter <deadbeef@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36076}
2022-02-25 10:14:38 +00:00
a23acdde9d
Update WebRTC code version (2022-02-25T04:02:04).
...
Bug: None
Change-Id: I5ea00667b5f3a253dc42e67aed9487990b9502d9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252543
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36075}
2022-02-25 05:03:33 +00:00
c5200da92e
Roll chromium_revision ec76cb664e..2136e05894 (974851:974952)
...
Change log: ec76cb664e..2136e05894ec76cb664e..2136e05894f7134a07e7..42d67a004d1182250c7c..f982200c74cc97f3073d..14c55572742db17150ca..f039863bab192c0c6ca7..84f3d6bf8fc1ab734908..6b28c1ddef901474b180..1fa4e3959e5834f7f7df..ebe914c964ec76cb664e..2136e05894https://webrtc-review.googlesource.com/c/src/+/252540
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36074}
2022-02-25 02:51:13 +00:00
0825daf2ed
PipeWire capturer: search for epoxy headers
...
We actually use headers from libepoxy (it's part of the sysroot) so this
was removed accicentally in one of previous changes and it just
magically worked as we include those headers with their full path
Bug: webrtc:13429
Change-Id: I4f5684521a76287a725272ce3833daae673d9332
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252002
Reviewed-by: Alexander Cooper <alcooper@chromium.org >
Commit-Queue: Alexander Cooper <alcooper@chromium.org >
Cr-Commit-Position: refs/heads/main@{#36073}
2022-02-25 01:20:32 +00:00
48cda468aa
Roll chromium_revision c5c3b957ca..ec76cb664e (974718:974851)
...
Change log: c5c3b957ca..ec76cb664ec5c3b957ca..ec76cb664e8c7254d87b..f7134a07e7b6b7a3eb65..1182250c7c2a2fe25738..cc97f3073d04b71a078a..2db17150ca502712994d..192c0c6ca7https://chromium.googlesource.com/catapult.git/+log/08a8050c47..62a74cf243
* src/third_party/depot_tools: 2c668c866d..c1ab734908cf4922dea8..dfc6cffca97264b97e2c..5834f7f7dfc5c3b957ca..ec76cb664ehttps://webrtc-review.googlesource.com/c/src/+/252501
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36072}
2022-02-24 22:41:32 +00:00
1535b0a34b
Add I444Buffer tests in video_frame_unittest.cc
...
@nisse suggested to add test for I444Buffer to VideoFrameBuffer test
in https://webrtc-review.googlesource.com/c/src/+/251303 and I agree that
they should exist.
Didn't get the time to add them before the change was merged, so here
they are.
I took the liberty of reworking the tests to extend support to any buffer
type based on PlanarYuvBuffer (only limited by interface method
implementations) but still retain the same functionality.
Bug: webrtc:13669
Change-Id: I67998b635e05e1403e2dc6cfe3483590a5788453
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251460
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36071}
2022-02-24 21:10:12 +00:00
ecd5ba15cb
Fix missing include of rtc_base/system/no_unique_address.h
...
Bug: None
Change-Id: I047c456cde647282824e8c51122ae53bef7cb7b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252440
Auto-Submit: Niels Moller <nisse@webrtc.org >
Reviewed-by: Mark Foltz <mfoltz@chromium.org >
Commit-Queue: Mark Foltz <mfoltz@chromium.org >
Cr-Commit-Position: refs/heads/main@{#36070}
2022-02-24 19:25:12 +00:00
a8c0d789ee
Roll chromium_revision b4562c8dc8..c5c3b957ca (974583:974718)
...
Change log: b4562c8dc8..c5c3b957cab4562c8dc8..c5c3b957ca187616c5fc..8c7254d87bbcfb6fca6d..b6b7a3eb654eaa194b8b..2a2fe25738629e78f5b3..04b71a078ad2f57fb779..502712994dhttps://boringssl.googlesource.com/boringssl.git/+log/68addd2f71..4d955d20d2
* src/third_party/perfetto: dfc6cffca9..cf4922dea8bc929d3e94..7264b97e2cb4562c8dc8..c5c3b957cahttps://webrtc-review.googlesource.com/c/src/+/252480
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36069}
2022-02-24 18:47:52 +00:00
7306c75c12
Revert "Reland "Refactor AnalyzerConfig to use Timestamps instead of microseconds.""
...
This reverts commit 7a992e21b9c3ff03aa34488a9c91fa580ca4faa6.
Reason for revert: Breaks downstream build due to type change.
Original change's description:
> Reland "Refactor AnalyzerConfig to use Timestamps instead of microseconds."
>
> This is a reland of 43fb16921b29ecd3a2d87876dda75c575e05f66a
>
> Original change's description:
> > Refactor AnalyzerConfig to use Timestamps instead of microseconds.
> >
> > Add optional offset-to-UTC parameter to output. This allows aligning
> > the x-axis in the generated charts to other UTC-based logs.
> >
> > Bug: b/215140373
> > Change-Id: I65bcd295718acbb8c94e363907c1abc458067bfd
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250203
> > Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
> > Commit-Queue: Björn Terelius <terelius@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#35992}
>
> Bug: b/215140373
> Change-Id: Id2b88cc4b8078a97275d49a617581cbbd02d2c6f
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252380
> Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
> Commit-Queue: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36066}
Bug: b/215140373
Change-Id: I951ac26b8176e58da18e93835f13f6b9deb6d4fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252443
Auto-Submit: Björn Terelius <terelius@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36068}
2022-02-24 17:14:23 +00:00
3ed1dbb56e
In RtpPacketReceived delete deprecated accessors for handling time in ms
...
Bug: None
Change-Id: I02a43a16e8d9bf3a1e2c9f6442a1c119620e1288
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252286
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36067}
2022-02-24 15:37:51 +00:00
7a992e21b9
Reland "Refactor AnalyzerConfig to use Timestamps instead of microseconds."
...
This is a reland of 43fb16921b29ecd3a2d87876dda75c575e05f66a
Original change's description:
> Refactor AnalyzerConfig to use Timestamps instead of microseconds.
>
> Add optional offset-to-UTC parameter to output. This allows aligning
> the x-axis in the generated charts to other UTC-based logs.
>
> Bug: b/215140373
> Change-Id: I65bcd295718acbb8c94e363907c1abc458067bfd
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250203
> Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
> Commit-Queue: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35992}
Bug: b/215140373
Change-Id: Id2b88cc4b8078a97275d49a617581cbbd02d2c6f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252380
Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36066}
2022-02-24 14:56:53 +00:00
caf2063a9e
Roll chromium_revision 47fab10a5d..b4562c8dc8 (974582:974583)
...
The third_party/android_deps/libs/org_robolectric_shadows_multidex dependency had to be moved manually.
Change log: 47fab10a5d..b4562c8dc847fab10a5d..b4562c8dc81ccd6b651d..187616c5fce3b729952d..bcfb6fca6d93c15529c3..893aa038dd469142ebf2..4eaa194b8bbede1d9398..629e78f5b30c497a1ac6..d2f57fb779https://chromium.googlesource.com/catapult.git/+log/8f3c4ef866..08a8050c47
* src/third_party/depot_tools: 306b03b191..2c668c866dbcdfa38692..034e5dbf92b867f209e4..901474b18001862032d8..bc929d3e9447fab10a5d..b4562c8dc8https://webrtc-review.googlesource.com/c/src/+/252420
Auto-Submit: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36065}
2022-02-24 12:14:11 +00:00
c24a2189d7
Update IWYU tool with a mapping file
...
Also apply IWYU to all .cc files in pc/, and correct BUILD file to match.
Note: Some files came out wrong when iwyu was applied. These are not included.
Bug: none
Change-Id: Ib5ea46b8fcc505414d0447cca7218ad3afc2e321
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252280
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36064}
2022-02-24 11:05:06 +00:00
3be0c39f91
Update WebRTC code version (2022-02-24T04:05:39).
...
Bug: None
Change-Id: I52834e964bda1509e5cc33bca3c44e4ddc8a2700
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252360
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36063}
2022-02-24 05:49:51 +00:00
b50cfc9fbb
Roll chromium_revision a52f3ba050..0b2f63dc4b (974149:974286)
...
Change log: a52f3ba050..0b2f63dc4ba52f3ba050..0b2f63dc4bd9e6daa144..1ccd6b651ddf888d519a..e3b729952d90f3bddf86..469142ebf2f6ece9fd76..bede1d939857414e84d2..0c497a1ac6https://chromium.googlesource.com/catapult.git/+log/58ce6f9e68..8f3c4ef866
* src/tools: 68fd7a7434..01862032d8a52f3ba050..0b2f63dc4bhttps://webrtc-review.googlesource.com/c/src/+/252288
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36062}
2022-02-23 20:47:22 +00:00
54f3be5c37
Deflake VideoSendStreamTest::TestNackRetransmission.
...
This test method previously didn't account for retransmissions that can
fail for valid reasons e.g. retransmitting too soon or overusing the
retransmission bandwidth budget.
Now, we keep periodically requesting retransmissions until the packets
we seek have been received.
Bug: webrtc:13480
Change-Id: Ica620049b2c6c123117f5fa270dae0a08b320948
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252283
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36061}
2022-02-23 16:02:31 +00:00
003e6e99b3
[PCLF] Add ability to specify custom PortAllocator flags
...
Bug: b/196034093
Change-Id: Ia1838c5c9ace096d7e77e31f7f2ad6b6352fd1ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252100
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Jonas Oreland <jonaso@google.com >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36060}
2022-02-23 15:27:27 +00:00
286664c381
Roll chromium_revision 4ad0798dfd..a52f3ba050 (974045:974149)
...
Change log: 4ad0798dfd..a52f3ba0504ad0798dfd..a52f3ba05051ff1c607b..df888d519a329b18ceb3..90f3bddf86064ccfc12b..f6ece9fd763c02c2fa5e..57414e84d2https://chromium.googlesource.com/catapult.git/+log/4ac0eac51b..58ce6f9e68
* src/third_party/depot_tools: 64f5f26f1a..306b03b1915561a9ea21..68fd7a74344ad0798dfd..a52f3ba050https://webrtc-review.googlesource.com/c/src/+/252302
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#36059}
2022-02-23 15:19:41 +00:00
42abc13d17
Run degraded fake network on Call's network thread.
...
This avoids creating a dedicated task queue that potentially contends
with the network thread.
Bug: webrtc:251043
Change-Id: I2d54486c4235dac44b79f89d4f3d81b4d3de4026
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252282
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36058}
2022-02-23 12:10:21 +00:00
6589def397
Align sender/receiver teardown in RtpTransceiver.
...
This makes SetChannel() consistently make 2 invokes instead of a
multiple of senders+receivers (previous minimum was 4 but could be
larger).
* Stop() doesn't hop to the worker thread.
* SetMediaChannel(), an already-required step on the worker thread for
senders and *sometimes* for receivers[1], is now consistently required
for both. This simplifies transceiver teardown and enables the next
bullet.
* Transceiver stops all senders and receivers in one go rather than
ping ponging between threads.
[1] When not required, it was done implicitly inside of Stop().
See changes in `RtpTransceiver::SetChannel`
Bug: webrtc:13540
Change-Id: Ied61636c8ef09d782bf519524fff2a31e15219a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249797
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36057}
2022-02-23 11:10:32 +00:00
