Commit Graph

35565 Commits

Author SHA1 Message Date
6b667a8fe2 Clean up expreiment WebRTC-Bwe-NewInterArrivalDelta
The experiment has been per default enabled since
https://webrtc.googlesource.com/src/+/62b340545f80baaa449c2159a8e44052c74116c9
submitted 20210914.

Bug: webrtc:12269
Change-Id: I730b603f4d0e382758fd4a6df6ccef9d8b76ea82
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246105
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35683}
2022-01-13 13:32:24 +00:00
9512910e6e Update rtc_base to not use implicit T* --> scoped_refptr<T> conversion
Also updated the OperationsChain and CallbackHandle classes to not use
any virtual methods.

Bug: webrtc:13464
Change-Id: I3437d1b7b043339e66411f5a46c226624b7ff9a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246102
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35682}
2022-01-13 12:01:30 +00:00
70fe704588 Remove support for obsolete histogram KeyProtocolByMedia
Bug: chromium:1274679
Change-Id: I076e52d42f2e7f3d69c600ec8960150715ce4c05
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246103
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35681}
2022-01-13 11:45:18 +00:00
4024f64cff Update rtc_tools to not use implicit T* --> scoped_refptr<T> conversion
Bug: webrtc:13464
Change-Id: Ieb7747eaf466254c6feaf5670846b897d700ad07
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246101
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35680}
2022-01-13 10:45:41 +00:00
8e64e2ddb4 add thread check in DcSctpTransport::OnTransportReadPacket
Bug: None
Change-Id: I1e5e28674617e9ebb322831f95f6f6b88daa7be6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245600
Reviewed-by: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35679}
2022-01-13 10:37:39 +00:00
766c80b256 [ObjC] Change default sdpSemantics to NotSpecified.
The default value of sdpSemantics is about to change from PlanB to
UnifiedPlan. In order not to cause subtle bugs by applications that
depend on the default value being PlanB, we are temporarily making the
default NotSpecified. Constructing with NotSpecified causes the C++
layer to crash (https://webrtc-review.googlesource.com/c/src/+/242968).
This is in accordance to the publically announced plans:
https://groups.google.com/u/1/g/discuss-webrtc/c/SdoVP02eUIk

Bug: webrtc:11121
Change-Id: Idbb8fd0f5c224311cf1f25ac2832800124ed14d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246060
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35678}
2022-01-13 09:06:38 +00:00
26cf22af46 Roll chromium_revision 96b3f6fe6e..d4e29009ed (958357:958468)
Change log: 96b3f6fe6e..d4e29009ed
Full diff: 96b3f6fe6e..d4e29009ed

Changed dependencies
* src/base: c2d83a39e5..6326d1418d
* src/build: 21d8bd5b30..923a9e5984
* src/buildtools/third_party/libc++abi/trunk: 8829496cf6..0c34f74b2c
* src/ios: f62201bbcf..37ff980b65
* src/testing: e9a87de306..305f9af1e7
* src/third_party: 551f734933..5fe63ad360
* src/third_party/androidx: kbDXkyz0Cat6aywgnFl4onZ4E8LXiWFZPcSwBSi4ip4C..bebl7HT6pBH_Y5G5q4holx3hZg80BJB9yRxLViJOONEC
* src/third_party/depot_tools: 9fa0cb7230..42afe9a2d3
* src/third_party/icu: fbc6faf1c2..b9f6d0a5c5
* src/tools: 083e71f7fd..f13586d614
DEPS diff: 96b3f6fe6e..d4e29009ed/DEPS

No update to Clang.

BUG=None

Change-Id: Id4d2e0140f1c141f6a1881ed03308b9f4826c445
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246164
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35677}
2022-01-13 08:43:28 +00:00
36aaaf331d Update WebRTC code version (2022-01-13T04:04:17).
Bug: None
Change-Id: Ie6e6540f5c108c4bc6754297e614103c1f2423f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246162
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35676}
2022-01-13 05:07:25 +00:00
4be9da34f4 Roll chromium_revision 6f6d42e1df..96b3f6fe6e (958232:958357)
Change log: 6f6d42e1df..96b3f6fe6e
Full diff: 6f6d42e1df..96b3f6fe6e

Changed dependencies
* src/base: 94f5ba8cd5..c2d83a39e5
* src/build: fdb3611477..21d8bd5b30
* src/ios: d5c8012cf5..f62201bbcf
* src/testing: a78ed44be9..e9a87de306
* src/third_party: 112a990ec1..551f734933
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/486f67f3ec..17bc902374
* src/tools: a35a477395..083e71f7fd
DEPS diff: 6f6d42e1df..96b3f6fe6e/DEPS

No update to Clang.

BUG=None

Change-Id: I01dff159e266fc1d4187fc63e0b76b8062bb1540
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246140
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35675}
2022-01-13 00:31:11 +00:00
e286a7bbf7 Modify apply-iwyu to utilize compile_commands.json
Bug: webrtc:13532
Change-Id: I06e5987469e732296deb1eefd317e2478add98b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246040
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com>
Cr-Commit-Position: refs/heads/main@{#35674}
2022-01-12 23:08:22 +00:00
5e05369cb2 Roll chromium_revision 30d0edac75..6f6d42e1df (958099:958232)
Change log: 30d0edac75..6f6d42e1df
Full diff: 30d0edac75..6f6d42e1df

Changed dependencies
* src/base: 78f2e2150b..94f5ba8cd5
* src/build: beda32040e..fdb3611477
* src/ios: 0213de3876..d5c8012cf5
* src/testing: ba40f25dfc..a78ed44be9
* src/third_party: 08b92f779b..112a990ec1
* src/third_party/androidx: yFvftcNOlZZJaFm5vRn6OVKPs5whEChqCg3ESP47ycIC..kbDXkyz0Cat6aywgnFl4onZ4E8LXiWFZPcSwBSi4ip4C
* src/third_party/harfbuzz-ng/src: 77507a1d8d..b8c2c1ab37
* src/tools: d005da4982..a35a477395
DEPS diff: 30d0edac75..6f6d42e1df/DEPS

No update to Clang.

BUG=None

Change-Id: Ifc4fff0c2611680eea363554af9c73c73d0a892f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246121
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35673}
2022-01-12 20:22:28 +00:00
0a72b412e1 Add field trial flag forcing VP9 flexible mode for testing
Bug: chromium:949536
Change-Id: Idb12a2be18cdec8313a74d35fe79c0235f66e393
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246100
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35672}
2022-01-12 19:11:43 +00:00
f92de01f11 Roll chromium_revision 10ad737e1a..30d0edac75 (957995:958099)
Change log: 10ad737e1a..30d0edac75
Full diff: 10ad737e1a..30d0edac75

Changed dependencies
* src/base: 988da7eca7..78f2e2150b
* src/build: 609d71d15f..beda32040e
* src/ios: 0925956b8b..0213de3876
* src/testing: e6176d3f66..ba40f25dfc
* src/third_party: db1c99c09d..08b92f779b
* src/third_party/freetype/src: e838c37c2c..b647dbdeb8
* src/tools: 5f2ecac827..d005da4982
DEPS diff: 10ad737e1a..30d0edac75/DEPS

No update to Clang.

BUG=None

Change-Id: Ida4f769b03cac817912e8751359c0898d909e5fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246080
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35671}
2022-01-12 16:59:48 +00:00
31bd9fadb6 Disable Vp9ImplTest.DisableEnableBaseLayerWithSvcControllerTriggersKeyFrame
- Enable once a forward fix has landed in WebRTC

Bug: webrtc:13442
Change-Id: I0493fbbfbcf96e643d604406b350a3d315b24779
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245601
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35670}
2022-01-12 16:43:38 +00:00
1c7c09bcfa Introduce SdpOfferAnswerHandler::RemoteDescriptionOperation.
This is an operation specific subclass of SdpOfferAnswerHandler that in
this first step, takes over the implementation details that before this
CL were implemented in SdpOfferAnswerHandler::DoSetRemoteDescription.

This CL does not change the behavior of the implementation but it does
break up DoSetRemoteDescription into smaller methods and moves the state
related to the SRD operation, into a class that in upcoming steps can
be passed around asynchronously as needed, which will allow us to avoid
blocking threads.

Bug: webrtc:13540
Change-Id: Id2002d2390a4a13725f5967df5b82064b37c7490
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244980
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35669}
2022-01-12 14:38:25 +00:00
f5770a0198 Replace RTC_DCHECK_NOT_REACHED in framegenerator implementations of
ChangeResolution

Instead a warning is logged.

This effect tests only, and allows us to write screen share tests that may try to trigger the capturers to change resolution.

Bug: none
Change-Id: I4740fc4ed0bcf75e1c9df332fa610c24ed14973a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245981
Auto-Submit: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35668}
2022-01-12 13:25:25 +00:00
961f382458 Update api/ to not use implicit T* --> scoped_refptr<T> conversion
Bug: webrtc:13464
Change-Id: I5dc292fefd27bfd43574f3e0c63c0e1da6dddcae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244091
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35667}
2022-01-12 11:26:05 +00:00
994bf454ec Revert of flag simplification.
In order to unify WebRTC recipes with Chromium recipes this CL tries to revert the old CL https://webrtc-review.googlesource.com/c/src/+/171681.
This CL was already partially reverted (https://webrtc-review.googlesource.com/c/src/+/171809).
In upcoming CLs, the added flag dump_json_test_results will be removed in order to use isolated-script-test-output instead.

Bug: webrtc:13556
Change-Id: I3144498b9a5cbaa56c23b3b8adbac2229ad63c37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245602
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35666}
2022-01-12 10:53:12 +00:00
ba38934771 Roll chromium_revision bddc47156d..10ad737e1a (957876:957995)
Change log: bddc47156d..10ad737e1a
Full diff: bddc47156d..10ad737e1a

Changed dependencies
* src/base: 26ecd10144..988da7eca7
* src/build: acafc906b9..609d71d15f
* src/ios: a0467ae27d..0925956b8b
* src/testing: 825b1e43f2..e6176d3f66
* src/third_party: 9ca13b5441..db1c99c09d
* src/third_party/androidx: B9rhutyqLDhWWNhiyH6A1gC63mYwYyQfnP4O5533VnwC..yFvftcNOlZZJaFm5vRn6OVKPs5whEChqCg3ESP47ycIC
* src/third_party/depot_tools: c3e25c828d..9fa0cb7230
* src/third_party/googletest/src: 1d9f7c5fb2..aea0874c42
* src/tools: 52851c34aa..5f2ecac827
DEPS diff: bddc47156d..10ad737e1a/DEPS

No update to Clang.

BUG=None

Change-Id: I8bd86b04886ad52aa65a126cec1876724e9f5a72
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245940
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35665}
2022-01-12 10:50:26 +00:00
f490d6f818 Update WebRTC code version (2022-01-12T04:04:26).
Bug: None
Change-Id: I541bae6e84f4609fb274358a9104bc5a7acacdaf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245901
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35664}
2022-01-12 05:57:56 +00:00
acd2af9183 Roll chromium_revision 009ef0607e..bddc47156d (957263:957876)
Change log: 009ef0607e..bddc47156d
Full diff: 009ef0607e..bddc47156d

Changed dependencies
* src/base: 6aa2f94267..26ecd10144
* src/build: 3803b801b5..acafc906b9
* src/buildtools/third_party/libc++abi/trunk: a0ace9923e..8829496cf6
* src/buildtools/third_party/libunwind/trunk: 58d1647360..834e4a3c86
* src/ios: 8d2e6d58a9..a0467ae27d
* src/testing: 281b598c1a..825b1e43f2
* src/third_party: 6b754d731d..9ca13b5441
* src/third_party/android_build_tools/aapt2: ZHiDoiurxMLwajQq_CwBH9zaDW5xwYWYGbedxIslTm8C..0yR8wK_fSMgdVKwnx4nRPi-amaLV7Kcr4Os6mg_DGI4C
* src/third_party/androidx: A2SRkmLGieck6AyFqq-ZI_WZV5i32fH-eIfxK5dytRIC..B9rhutyqLDhWWNhiyH6A1gC63mYwYyQfnP4O5533VnwC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/dc1213869e..486f67f3ec
* src/third_party/depot_tools: d3cc7ad85e..c3e25c828d
* src/third_party/freetype/src: a25e85ed95..e838c37c2c
* src/third_party/googletest/src: 6b74da4757..1d9f7c5fb2
* src/third_party/libvpx/source/libvpx: ab35ee100a..51415c4076
* src/tools: 32e9ed40ea..52851c34aa
DEPS diff: 009ef0607e..bddc47156d/DEPS

Clang version changed llvmorg-14-init-12719-gc4b45eeb:llvmorg-14-init-14241-ged3a4a49
Details: 009ef0607e..bddc47156d/tools/clang/scripts/update.py

BUG=None

Change-Id: I2429247e81c0a1c853498bfe405c89b2cce0b8b7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245880
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35663}
2022-01-12 02:40:15 +00:00
cb87ec9557 Remove unnecessary imports from //build
rtc_base/BUILD.gn imports //build/config/{crypto,ui}.gni but uses no
flags from them. Since they aren't needed anymore, remove them to
loosen build system coupling.

Blocking https://chromium-review.googlesource.com/c/chromium/src/+/3379123

Bug: chromium:961767
Change-Id: I006163f510a3fa1da88f7cc3e3109f240684457c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245820
Auto-Submit: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35662}
2022-01-11 21:43:16 +00:00
c811ab54eb Invalidate the legacy stats cache instead of updating.
This changes SetLocalDescription/SetRemoteDescription to just resetting
the internal cache timestamp for the legacy stats handler instead of
performing a full update, which can be costly.

Bug: webrtc:13557
Change-Id: I93971dbd7abf33c0d0f2836f9c17ba4550f41a00
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245645
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35661}
2022-01-11 20:45:16 +00:00
bb57de2959 Extend make_ref_counted to interoperate with RefCountedNonVirtual
Update RtpPacketInfos internals to use rtc::make_ref_counted, and a
Data class with no virtual methods.

Bug: webrtc:13464, webrtc:12701
Change-Id: I03f6bee69a9f060dcf287284fc779268d5eb433e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244505
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35660}
2022-01-11 16:06:34 +00:00
b82193cec8 Disable DisableEnableBaseLayerTriggersKeyFrame
- Enable once a forward fix has landed in WebRTC.

Bug: webrtc:13442
Change-Id: I295383b84a753e8e1f65006cc6a3c00b78033aa4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245643
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35659}
2022-01-11 14:59:24 +00:00
21e97f9b9d Add unary operator- to units
This will be used in the frame buffer 3 scheduler.

Bug: webrtc:13343
Change-Id: Ib699072021da30022a34aabe24e36a37e89ddf41
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245642
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35658}
2022-01-11 14:12:54 +00:00
3fd9cbc7a0 stats: convert qualitylimitationdurations to seconds
the internal value is defined milliseconds
  https://webrtc.googlesource.com/src/+/refs/heads/main/video/g3doc/stats.md
while the specification defines it in seconds
  https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-qualitylimitationdurations

BUG=webrtc:13548,webrtc:10686

Change-Id: I901c84214c77dd5a6e59f6556a029c8e20cb7672
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245482
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/main@{#35657}
2022-01-11 10:58:35 +00:00
cf00059db6 Remove Win8
Bug: chromium:1281336
Change-Id: I490ec704d8f006301ab41dc3380983075032285e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245483
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35656}
2022-01-11 10:27:54 +00:00
0d1e7500fa Roll chromium_revision 18d61d1673..009ef0607e (957156:957263)
Change log: 18d61d1673..009ef0607e
Full diff: 18d61d1673..009ef0607e

Changed dependencies
* src/base: 7caae1b5e3..6aa2f94267
* src/build: d2934323c1..3803b801b5
* src/buildtools/linux64: git_revision:f1b1412521b41e47118b29863224171e434a27a2..git_revision:80a40b07305373617eba2d5878d353532af77da3
* src/buildtools/mac: git_revision:f1b1412521b41e47118b29863224171e434a27a2..git_revision:80a40b07305373617eba2d5878d353532af77da3
* src/buildtools/win: git_revision:f1b1412521b41e47118b29863224171e434a27a2..git_revision:80a40b07305373617eba2d5878d353532af77da3
* src/ios: 0367bb1768..8d2e6d58a9
* src/testing: ee36306ac2..281b598c1a
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/aa0e8d0564..dc1213869e
* src/tools: cafbb706ae..32e9ed40ea
DEPS diff: 18d61d1673..009ef0607e/DEPS

No update to Clang.

BUG=None

Change-Id: I88eb84a2d23767805abe1b823c5c6c2b3109c2e6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245620
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35655}
2022-01-10 22:45:44 +00:00
91f55e4dec Avoid container-overflow in WgcCaptureSession::GetFrame
ASAN is throwing a container-overflow because we are accessing a region
in the vector that is valid but does not have an element. We can avoid
this by using resize instead of reserve.

See the documentation for container-overflow for more details:
https://github.com/google/sanitizers/wiki/AddressSanitizerContainerOverflow#:~:text=One%20kind%20of%20bugs%20that%20AddressSanitizer%20can%20find,outside%20of%20the%20current%20container%20bounds.%20Simplest%20example%3A

Bug: webrtc:13541
Change-Id: Id11def90ef8c2cfec9c20f38384547ce6c37b980
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244861
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Austin Orion <auorion@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#35654}
2022-01-10 20:52:24 +00:00
b7fb538abb Roll chromium_revision 707a3884d2..18d61d1673 (957044:957156)
Change log: 707a3884d2..18d61d1673
Full diff: 707a3884d2..18d61d1673

Changed dependencies
* src/base: 0e6190bb08..7caae1b5e3
* src/ios: 5a364356e2..0367bb1768
* src/testing: 3def6a0243..ee36306ac2
* src/third_party: 39c66ea636..6b754d731d
* src/third_party/androidx: 72KhrVPMAimIlLbSf4qfoMjnvI2FmvCxSBB-rUtxn8UC..A2SRkmLGieck6AyFqq-ZI_WZV5i32fH-eIfxK5dytRIC
* src/tools: a95eedec4e..cafbb706ae
DEPS diff: 707a3884d2..18d61d1673/DEPS

No update to Clang.

BUG=None

Change-Id: Id3af101433eb49c600402602c1d4a0c4ca7b6654
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245580
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35653}
2022-01-10 20:31:34 +00:00
400d8bdd60 Remove PacedSender inheritance on Module
Bug: webrtc:10937
Change-Id: If9a94f9e49fefa844db215c91425a107fefb3581
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245481
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35652}
2022-01-10 15:56:33 +00:00
62995db2fc Change default sdp_semantics to kNotSpecified.
In preparation for switching the default from kPlanB to kUnifiedPlan,
which could cause subtle bugs for those not prepared for it, we change
the default to kNotSpecified. The only purpose of kNotSpecified is to
crash, forcing any dependencies to explicitly set their sdp_semantics
value.

Tests are updated to explicitly set sdp_semantics when necessary, and
where the test does not care we update to kUnifiedPlan.

If this change lands without getting reverted we can let it sit for a
few weeks, after which we should change the default to kUnifiedPlan and
delete kNotSpecified.

Bug: webrtc:11121
Change-Id: I19b669b0735d78e269e19eaae86c2d7d95a91141
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242968
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35651}
2022-01-10 14:56:03 +00:00
8d49d6f0e6 Roll chromium_revision 98a09f4466..707a3884d2 (956937:957044)
Change log: 98a09f4466..707a3884d2
Full diff: 98a09f4466..707a3884d2

Changed dependencies
* src/build: dd60a99813..d2934323c1
* src/ios: 11f4f76549..5a364356e2
* src/testing: 85cca6c8d9..3def6a0243
* src/third_party: 2cd2b5274d..39c66ea636
* src/third_party/freetype/src: bf9b1ef905..a25e85ed95
* src/tools: ed8b1b4f4c..a95eedec4e
DEPS diff: 98a09f4466..707a3884d2/DEPS

No update to Clang.

BUG=None

Change-Id: I421d535257a4a2a7a6e76626f013aef32f5e84eb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245520
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35650}
2022-01-10 14:17:20 +00:00
e68d874cf1 Update SetPayloadTypeDemuxingEnabled_w to avoid an unnecessary Invoke.
If a call to BaseChannel::SetPayloadTypeDemuxingEnabled does not result
in a demuxer criteria configuration change, we can avoid an Invoke
and speed up negotiations.

Bug: webrtc:11993
Change-Id: I80c894d7cc2a733ab84c1f4978f0c58c09a123a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244920
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35649}
2022-01-10 14:16:04 +00:00
47ff35db61 Delete some unneeded references to module.h and module_api target.
Bug: None
Change-Id: Iad983efa8666ca29b5e1ac22b3ade8987dbb2841
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242371
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35648}
2022-01-10 13:40:24 +00:00
6d113eae03 Add ImproveDirection to RampupTests
Bug: None
Change-Id: I386e992f33d21f20b0965e6d88a222cbb76d00a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244099
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35647}
2022-01-10 12:34:23 +00:00
c58adb753a Update WebRTC code version (2022-01-10T04:03:02).
Bug: None
Change-Id: I99e75bdb6c5c55b33249d7183e5dd755c67cb93c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245365
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35646}
2022-01-10 04:54:49 +00:00
bb350bd941 Roll chromium_revision 2b9ea1db52..98a09f4466 (956835:956937)
Change log: 2b9ea1db52..98a09f4466
Full diff: 2b9ea1db52..98a09f4466

Changed dependencies
* src/base: 9f6a4078ec..0e6190bb08
* src/build: 89f390ec51..dd60a99813
* src/ios: 81c7a212b0..11f4f76549
* src/testing: fb4620a72b..85cca6c8d9
* src/third_party: 28dc7c124f..2cd2b5274d
* src/third_party/androidx: mZDSnVEjFdMnVisTPg2aMOV97laQRf6q3babg8f7KQgC..72KhrVPMAimIlLbSf4qfoMjnvI2FmvCxSBB-rUtxn8UC
* src/tools: 15752f6471..ed8b1b4f4c
DEPS diff: 2b9ea1db52..98a09f4466/DEPS

No update to Clang.

BUG=None

Change-Id: Iab1452484d18a288842e3237f7f0c2c481bbce79
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245363
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35645}
2022-01-10 02:40:39 +00:00
cc8f127ed9 Roll chromium_revision bb5b8614b9..2b9ea1db52 (956732:956835)
Change log: bb5b8614b9..2b9ea1db52
Full diff: bb5b8614b9..2b9ea1db52

Changed dependencies
* src/base: d4529b6853..9f6a4078ec
* src/build: a2a78b6610..89f390ec51
* src/buildtools/third_party/libc++abi/trunk: c884e7a7ce..a0ace9923e
* src/buildtools/third_party/libunwind/trunk: 4bf418ebaf..58d1647360
* src/ios: e9a5433ee3..81c7a212b0
* src/testing: 3ea6a8123d..fb4620a72b
* src/third_party: 318b87065d..28dc7c124f
* src/third_party/androidx: hyrO0XEiBqf22_8YM-FkRhjqAyxUWeSZ_9LZqPJDkYIC..mZDSnVEjFdMnVisTPg2aMOV97laQRf6q3babg8f7KQgC
* src/third_party/depot_tools: 59e6796cd2..d3cc7ad85e
* src/tools: cdc23c442a..15752f6471
DEPS diff: bb5b8614b9..2b9ea1db52/DEPS

No update to Clang.

BUG=None

Change-Id: I9904c0241e33957b452533e7436150a18c5be653
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245200
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35644}
2022-01-08 14:46:27 +00:00
2bc667fdd7 Roll chromium_revision c96a4e7a82..bb5b8614b9 (956529:956732)
Change log: c96a4e7a82..bb5b8614b9
Full diff: c96a4e7a82..bb5b8614b9

Changed dependencies
* src/base: 46aa1022f8..d4529b6853
* src/build: 2c1ec5abff..a2a78b6610
* src/buildtools/linux64: git_revision:54284c12607e2818293157cd76d29d03a36bfd68..git_revision:f1b1412521b41e47118b29863224171e434a27a2
* src/buildtools/mac: git_revision:54284c12607e2818293157cd76d29d03a36bfd68..git_revision:f1b1412521b41e47118b29863224171e434a27a2
* src/buildtools/win: git_revision:54284c12607e2818293157cd76d29d03a36bfd68..git_revision:f1b1412521b41e47118b29863224171e434a27a2
* src/ios: fd5365d254..e9a5433ee3
* src/testing: b1bf58701e..3ea6a8123d
* src/third_party: 083d35c008..318b87065d
* src/third_party/androidx: SBd1_afac7GmjsqtDzNI7TUwKr4KVbHuX3oqnduAW9EC..hyrO0XEiBqf22_8YM-FkRhjqAyxUWeSZ_9LZqPJDkYIC
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/3a667d10e9..295b31324f
* src/third_party/depot_tools: 44dda9648c..59e6796cd2
* src/tools: 4a5dcf9f08..cdc23c442a
DEPS diff: c96a4e7a82..bb5b8614b9/DEPS

No update to Clang.

BUG=None

Change-Id: Ia2aadc2dc179f6b448dc38d23f9097e4d71a4768
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245122
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35643}
2022-01-08 01:04:06 +00:00
651586c4e1 Move a part of ApplyRemoteDescription() into a separate function.
This part is specific to unified plan and doesn't need most of
the state related to the remote description (and doesn't return an
error).

Bug: none
Change-Id: I0de66bdb2e925072a6d9010e4444e75d4574ae04
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245102
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35642}
2022-01-07 19:50:46 +00:00
b625edfa47 Move one part of ApplyRemoteDescription out to a separate function.
This is just a step to reduce the size of ApplyRemoteDescription to make
refactoring it easier (and ultimately support async operations).

Bug: none
Change-Id: Idb950c35f585a887d6640278b6edfdd0c7cec3fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245101
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35641}
2022-01-07 18:23:06 +00:00
7ac11436c0 Roll chromium_revision 3aef64d992..c96a4e7a82 (956401:956529)
Change log: 3aef64d992..c96a4e7a82
Full diff: 3aef64d992..c96a4e7a82

Changed dependencies
* src/base: 6c873591bb..46aa1022f8
* src/build: 3fd1fd51c3..2c1ec5abff
* src/buildtools/linux64: git_revision:387b368dfe63fec317f8e609d90c634807f2764e..git_revision:54284c12607e2818293157cd76d29d03a36bfd68
* src/buildtools/mac: git_revision:387b368dfe63fec317f8e609d90c634807f2764e..git_revision:54284c12607e2818293157cd76d29d03a36bfd68
* src/buildtools/win: git_revision:387b368dfe63fec317f8e609d90c634807f2764e..git_revision:54284c12607e2818293157cd76d29d03a36bfd68
* src/ios: 33c85bc0a7..fd5365d254
* src/third_party: 4492f8d852..083d35c008
* src/third_party/freetype/src: afb4ca0151..bf9b1ef905
* src/tools: 0cfc61dead..4a5dcf9f08
DEPS diff: 3aef64d992..c96a4e7a82/DEPS

No update to Clang.

BUG=None

Change-Id: I5236dd73ea06ded139c8f1684814834230d93fbd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245062
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35640}
2022-01-07 16:22:56 +00:00
e11a4f5018 Roll chromium_revision cbd0ac46b5..3aef64d992 (955688:956401)
This CL also suppresses UseNetworkAnnotations in the AppRTC
Android example app since they are not actionable and Chromium
related.

Change log: cbd0ac46b5..3aef64d992
Full diff: cbd0ac46b5..3aef64d992

Changed dependencies
* src/base: a83346828c..6c873591bb
* src/build: 6593a28f30..3fd1fd51c3
* src/buildtools/linux64: git_revision:281ba2c91861b10fec7407c4b6172ec3d4661243..git_revision:387b368dfe63fec317f8e609d90c634807f2764e
* src/buildtools/mac: git_revision:281ba2c91861b10fec7407c4b6172ec3d4661243..git_revision:387b368dfe63fec317f8e609d90c634807f2764e
* src/buildtools/third_party/libunwind/trunk: 6a10e3e97c..4bf418ebaf
* src/buildtools/win: git_revision:281ba2c91861b10fec7407c4b6172ec3d4661243..git_revision:387b368dfe63fec317f8e609d90c634807f2764e
* src/ios: eafe83e727..33c85bc0a7
* src/testing: ae85d6c117..b1bf58701e
* src/third_party: 6d924d92e5..4492f8d852
* src/third_party/androidx: rHl7WLfujPiSrBBRroGr68FcsXWIPHzpsXUuSYZ6r-kC..SBd1_afac7GmjsqtDzNI7TUwKr4KVbHuX3oqnduAW9EC
* src/third_party/breakpad/breakpad: 3846f6d297..bbf740148d
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5d00ad2e9a..aa0e8d0564
* src/third_party/depot_tools: aae6725ff0..44dda9648c
* src/third_party/freetype/src: 2b672e7210..afb4ca0151
* src/tools: 4d0b131d0a..0cfc61dead
* src/tools/luci-go: git_revision:89429843eb2dedb599a6c7c7754343b97d95943d..git_revision:d1e877e2b3e5a05a5cd34c4a340fedba14a16c2b
* src/tools/luci-go: git_revision:89429843eb2dedb599a6c7c7754343b97d95943d..git_revision:d1e877e2b3e5a05a5cd34c4a340fedba14a16c2b
DEPS diff: cbd0ac46b5..3aef64d992/DEPS

No update to Clang.

BUG=None

Change-Id: I6a7eb9a21c4720fba7854aee42571b40049699a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245003
Commit-Queue: Björn Sundman <bsundman@google.com>
Reviewed-by: Björn Sundman <bsundman@google.com>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35639}
2022-01-07 08:51:46 +00:00
c69453d93b Change SetLocalContent in channel classes to avoid Invoke.
With these changes, we now often have 0 invokes and at most 1 when
calling SetLocalContent on a channel. Before we had at least 1 and
typically 2.

Summary of changes.
* Updating RtpExtension::DeduplicateHeaderExtensions to return a sorted
  vector (+test) for easy detection of changes.
* Before updating the transport on the network thread, detect if
  actual changes to the demuxer criteria or changes to the rtp header
  extensions have been made.
* Consolidate both transport updates to a single call instead of two.
* Added DCHECK guards to catch regressions in number of invokes.

A possible upcoming improvement is to update the transport
asynchronously.

Bug: webrtc:13536
Change-Id: I71ef7b181635a796ffa1e3a02a0f661d28a4870c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244700
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35638}
2022-01-06 12:52:35 +00:00
ac72dda645 Code consolidation in BaseChannel and derived classes.
This is a bit of refactoring to clear the way for some more upcoming
changes and fix little oddities here and there that are basically
artifacts of many small incremental changes throughout the years.

* Remove the CryptoOptions member variable and instead only keep around
  the filter for rtp header extensions.
* Remove several member methods that only forwarded calls to
  media_channel() and effectively reduced readability.
* Consolidated quite a bit of code related to UpdateRemoteStreams_w
  and the copy/pasted code in the Video/Voice classes around calling it.
* UpdateRemoteStreams_w now returns an error when it's encountered.
  Before, an error would still be returned in those cases but all
  operations were unnecessarily performed.

Bug: none
Change-Id: I85a37b9e8f00584aa794abef11abfe89dec5d0a6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244098
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35637}
2022-01-06 12:10:45 +00:00
b463ae1ac7 Add a sanity check of RTCVideoFrame in RTCMTLVideoView
Bug: webrtc:13490
Change-Id: I6cca1966c660b2fa36d2d77a816cdd734cce7cf2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244420
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35636}
2022-01-06 10:43:05 +00:00
9467daeea5 Update WebRTC code version (2022-01-06T04:03:19).
Bug: None
Change-Id: I581850ec30a9a1639e9898a1a5faae9b6f1e45ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244800
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35635}
2022-01-06 05:21:08 +00:00
0e56787d63 remove legacy datachannel code
BUG=webrtc:6625

Change-Id: Ic869c28fe9a24147338b5cd2c830a86b008212f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244506
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/main@{#35634}
2022-01-05 20:36:54 +00:00