7d9f0dc40f
Downgrade go runtime to 1.16 for macOS AppRTC tests.
...
Starting from Go 1.17, modules are the default and cannot be disabled.
This requires a change in the GitHub repositury [1].
As a stopgap solution, this CL moves Go back to 1.16 and disables
modules [2].
[1] - https://github.com/webrtc/apprtc/tree/master/src/collider
[2] - https://go.dev/blog/go116-module-changes
No-Presubmit: True
Bug: webrtc:14342
Change-Id: Idd03639588bc03497a78f0cef350daebf3b2f1d9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271481
Reviewed-by: Evan Shrubsole <eshr@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37760}
2022-08-12 07:13:52 +00:00
c06c0cfa52
Update go runtime to 1.19 for macOS AppRTC tests.
...
Bug: webrtc:14342
Change-Id: I34ef63dba16582bcb613c4f25c3c61b460c03047
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271280
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37743}
2022-08-11 08:25:02 +00:00
38b3cf0223
Add lower/upper link capacity to the outgoing bitrate graph.
...
Bug: webrtc:14273
Change-Id: I8d9f1ac0d41b74a226abdff00f420d6b0624b73c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250442
Commit-Queue: Diep Bui <diepbp@google.com >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37557}
2022-07-19 13:22:32 +00:00
5286dcfab6
Migrate rtc_base and rtc_tools to absl::AnyInvocable based TaskQueueBase interface
...
Bug: webrtc:14245
Change-Id: I71abe3db7a23ad33bd175297e23fa8e927fa9628
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268768
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37553}
2022-07-19 10:57:42 +00:00
6183a0fe9a
Add default conversational speech file to the .rodata section.
...
This allow to remove the testonly from the rtc_event_log_visualizer
binary and the implicit dependency on the path of the default
conversational speech file.
The binary size of event_log_visualizer passes from 2.1 MB to 4.0 MB.
Bug: b/237526033
Change-Id: I71cf647f039f26f30c792c49c752cff5c5b329a2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267663
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37453}
2022-07-06 07:30:43 +00:00
2ad75b3956
Remove testonly from unpack_aecdump.
...
This CL duplicates a few lines of utility code from
//modules/audio_processing:audioproc_test_utils (which contains more
testonly things) and allows the possibility to remove testonly from
the unpack_aecdump tool.
Bug: b/237526033
Change-Id: If2e1dd4cc825429c496091cf8640c67069fb6e6f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267701
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37437}
2022-07-05 10:23:53 +00:00
c931f70896
network_tester: Remove usage of rtc::Thread::socketserver() and cleanup
...
Instead of creating a TaskQueue from packet_sender, create a rtc::Thread
in test_controller so that test_controller instantiates a SocketServer,
eliminating the use of rtc::Thread::socketserver().
Also did various cleanups, such as adding threading annotations, and
ensuring that all network operations are done in dedicated threads.
Bug: webrtc:13145
Test: Unittest, and manually verified using Android clients and Linux servers
Change-Id: I05ebe5e29bd80f14a193c9ee8b0bf63a1b6b94d7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263321
Commit-Queue: Daniel.l Lee <daniel.l@hpcnt.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37411}
2022-07-03 08:44:52 +00:00
1c951ecb32
video_replay: add flexfec support
...
which is useful for validating flexfec recovers frames correctly.
This can be tested by passing a keyframe covered by flexfec along
with the fec packets and removing one packet from the frame.
BUG=None
Change-Id: Icd73eca138f62b9387bf850a6efbd7db03b4b569
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261956
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37392}
2022-07-01 09:42:24 +00:00
de7fcffe0c
video_replay: add AV1 support to IVF filewriter
...
which is already supported in modules/video_coding/utility/ivf_file_reader.cc
BUG=None
Change-Id: I7b00659dc460d372312dff2eb53837a321ab16af
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262246
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37390}
2022-07-01 08:55:44 +00:00
978cb6762f
Remove //test:field_trials from RTCEventLogs viewer.
...
This dependency is not needed.
Bug: b/237526033
Change-Id: Ief983a7cd08e919b0b120809f1aa1ec5bde8a8d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267168
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37379}
2022-06-30 12:01:48 +00:00
eefae3b7b7
Revert "Make the test library for field trials testonly."
...
This reverts commit c33f1a828c31412e7422e7bf11db7c9b61fab339.
Reason for revert: Breaks downstream project.
Original change's description:
> Make the test library for field trials testonly.
>
> Bug: None
> Change-Id: I703a82e0ca10908bdc56c0d4f1455e042ce74ac1
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267163
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37371}
Bug: None
Change-Id: I1d6d88ed9f32d5f1aab3159bbd1f279f164a079d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267164
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37372}
2022-06-29 15:53:48 +00:00
c33f1a828c
Make the test library for field trials testonly.
...
Bug: None
Change-Id: I703a82e0ca10908bdc56c0d4f1455e042ce74ac1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267163
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37371}
2022-06-29 15:43:08 +00:00
22ca4fb44a
Remove public_deps usage in neteq build targets.
...
Bug: b/36882554
Change-Id: I9a020e534a9f2c93de09684865a5bdddc60bd55d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266762
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@google.com >
Cr-Commit-Position: refs/heads/main@{#37323}
2022-06-24 14:05:19 +00:00
105711e9ad
Move rtc::make_ref_counted to api/
...
Bug: webrtc:12701
Change-Id: If49095b101c1a1763c2a44a0284c0d670cce953f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265390
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37219}
2022-06-15 09:47:38 +00:00
5a3732cc8c
Disable tests depending on libyuv upscale filtering
...
Bug: NONE
Change-Id: I6e8147428b3dba3849a9835d2686083e8aec6d6b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264828
Commit-Queue: Magnus Jedvert <magjed@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37097}
2022-06-02 13:24:46 +00:00
83e34eed87
Migrate some scripts to python3
...
python-modernize, format and some manual lint fixes
No-Try: True
Bug: None
Change-Id: I89d9f97f238be887962c67e18cc6480a8f6f3ac4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264551
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37071}
2022-06-01 10:09:36 +00:00
bc07d40eeb
event log analyzer: log rtp timestamps in question
...
and fix a typo
BUG=None
Change-Id: Ie286c52cbdfbc0269d92503c46b805bfdf5bb556
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264151
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/main@{#37042}
2022-05-30 14:46:14 +00:00
4a7883f442
Update event_log_visualizer tool to avoid matplotlib 3.4 deprecation warnings.
...
Bug: None
Change-Id: I973f7b460d0a86aa249e3539b8a5d5fdbc76ae1a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263441
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37040}
2022-05-30 14:24:14 +00:00
f6f4543304
Rename VideoReceiveStream to VideoReceiveStreamInterface
...
Bug: webrtc:7484
Change-Id: I653cfe46486e0396897dd333069a894d67e3c07b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262769
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36958}
2022-05-22 10:54:38 +00:00
65b2d8ad21
Move RunLoop test class to its own build target
...
To make it usable in tests without depending on all of CallTest.
Bug: None
Change-Id: Ie3102ab71bcfe3862dd6c35d3285098e961e54df
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262807
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36932}
2022-05-19 15:51:39 +00:00
cf2c8915f4
Delete H264EncoderSpecificSettings
...
Production code always use the default settings.
Bug: webrtc:6883
Change-Id: I213fc6433bb1cd0a6623ad523fee2df1506588e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261903
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36926}
2022-05-18 13:53:20 +00:00
807328fec7
Move frame drop config to VideoCodec and VideoEncoderConfig.
...
Intend to delete corresponding codec-specific settings in a followup.
Bug: webrtc:6883
Change-Id: I78ab07729a5aee1055f80d39d8f7289beb6721e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262244
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36882}
2022-05-13 13:40:14 +00:00
eb9af84a55
Improved RobustThroughputEstimator
...
- Filter out very old packets (to ensure that the estimate doesn't drop to zero if sending is paused and later resumed).
- Discard packets older than previously discarded packets (to avoid the estimate dropping after deep reordering.)
- Add tests cases for high loss, deep reordering and paused/resumed streams to unittest.
- Remove some field trial settings that have very minor effect and rename some of the others.
- Change analyzer.cc to only draw data points if the estimators have valid estimates.
Bug: webrtc:13402
Change-Id: I47ead8aa4454cced5134d10895ca061d2c3e32f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/236347
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36849}
2022-05-11 08:45:53 +00:00
ea1e6f44f8
Delete rtc_base/format_macros.h
...
It defined RTC_PRIuS, which was needed for compatibility with MSVC
prior to version 2015.
Bug: webrtc:6424
Change-Id: I5668d473376201cad3e8da65927c967fc397804b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261314
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36814}
2022-05-09 12:03:21 +00:00
df209e797b
Avoid more usage of implicit conversion from scoped_refptr<T> to T*
...
Update api/, call/, examples/ and rtc_tools/.
Bug: webrtc:13464
Change-Id: I7b0008cca68c579e89b45527a45300d1e67c3483
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260000
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36673}
2022-04-27 13:18:30 +00:00
c3e6e3a3e8
Remove dependency on rtc_base_approved from most targets
...
Bug: webrtc:9838
Change-Id: Ibd0199803597eff48ca139a5cecdc3209c62c5d2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259873
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36643}
2022-04-25 12:15:30 +00:00
6bb1fd358b
Move rate_statistics out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: Ia5a45291a403097c0527d50ced85c3881653fa37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259306
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36627}
2022-04-22 15:39:48 +00:00
10b34852a6
Remove public_deps from //p2p
...
Bug: webrtc:8603
Change-Id: I4e6a02c398f37effa2d16577f97677b8221209ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258941
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36563}
2022-04-18 18:23:51 +00:00
dd837e28fa
Remove //rtc_base:timeutils from public deps
...
Bug: webrtc:8603
Change-Id: Iaca9356d16275a02e8842c783f259131d72ef010
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257914
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36460}
2022-04-06 11:23:21 +00:00
57aa81bce7
Remove //rtc_base:stringutils from public deps
...
Bug: webrtc:8603
Change-Id: Ic2dfbe28d310cb4b35983b73e895fc95e8439669
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257913
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36453}
2022-04-05 22:42:19 +00:00
33d31fbc48
Remove //rtc_base:rtc_event from public deps
...
Bug: webrtc:8603
Change-Id: Ib99f43043da17723c939b0fe2aa9f3e515462c93
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257911
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36450}
2022-04-05 17:34:09 +00:00
f86f6f9afd
Remove //rtc_base:refcount from public deps
...
Bug: webrtc:8603
Change-Id: Ib27a107ae809df739492846175f0e9c4af40d21a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257910
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36447}
2022-04-05 15:32:29 +00:00
4467ad7835
Remove //rtc_base:macromagic from public deps
...
Bug: webrtc:8603
Change-Id: I9708df48c9bde9f86ba2d1a92a278bb0d09f3865
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257909
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36444}
2022-04-05 12:36:12 +00:00
0af55ba60d
Remove //rtc_base:logging from public deps
...
Bug: webrtc:8603
Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-05 10:31:19 +00:00
ca32793187
Make requesting SDES available only on Fuchsia builds
...
Bug: webrtc:11066
Change-Id: I0707cf63064830a55db31e883dc7b15aa675950b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257900
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36438}
2022-04-05 06:12:50 +00:00
7ab3ecd4c2
Use TimeDelta to convert to to/from compact ntp time
...
Bug: webrtc:13757
Change-Id: I1c5f0a666da8e6b30291763d110ff049df573490
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256103
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36333}
2022-03-25 10:41:39 +00:00
0c28820dcd
Fix FRAME delimiter is not handled properly in yuv/y4m reader
...
Note that sdk/android/api/org/webrtc/FileVideoCapturer.java is handling
correctly.
Bug: None
Change-Id: I3a9783d75bd0a4b3a454b87a01039154200c4d29
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256581
Auto-Submit: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36315}
2022-03-24 10:14:17 +00:00
be74b8058b
Fix spelling of receiver and transceiver.
...
Bug: None
Change-Id: I439e217d67283b182833e48da15af9ae367ac14e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256015
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36257}
2022-03-18 14:54:10 +00:00
023be3c977
Data Channel Benchmarking tool
...
Create a server using:
./data_channel_benchmark --server --port 12345
Start the flow of data from the server to a client using:
./data_channel_benchmark --port 12345 --transfer_size 100
The throughput is reported on the server console.
The negotiation does not require a 3rd party server and is done over a
gRPC transport. No TURN server is configured, so both peers need to be
reachable using STUN only.
Bug: webrtc:13288
Change-Id: Iac9a96cf390ab465ea45a46bf0b40950c56dfceb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235661
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36206}
2022-03-15 16:18:16 +00:00
e486a7bdf7
Make KeyValueConfig mandatory in the pacer.
...
This CL also removes dependency on the legacy field trial methods.
Bug: webrtc:11926
Change-Id: I53feeee86b92878cf0f2b8ebdce3d101f9e04014
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255381
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Auto-Submit: Erik Språng <sprang@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36205}
2022-03-15 15:07:46 +00:00
cb24158698
Reland "Reland "Refactor AnalyzerConfig to use Timestamps instead of microseconds.""
...
This reverts commit 7306c75c12e6dd70e1f1a0904b6bda347423a556.
Reason for revert: Downstream updated
Original change's description:
> Revert "Reland "Refactor AnalyzerConfig to use Timestamps instead of microseconds.""
>
> This reverts commit 7a992e21b9c3ff03aa34488a9c91fa580ca4faa6.
>
> Reason for revert: Breaks downstream build due to type change.
>
> Original change's description:
> > Reland "Refactor AnalyzerConfig to use Timestamps instead of microseconds."
> >
> > This is a reland of 43fb16921b29ecd3a2d87876dda75c575e05f66a
> >
> > Original change's description:
> > > Refactor AnalyzerConfig to use Timestamps instead of microseconds.
> > >
> > > Add optional offset-to-UTC parameter to output. This allows aligning
> > > the x-axis in the generated charts to other UTC-based logs.
> > >
> > > Bug: b/215140373
> > > Change-Id: I65bcd295718acbb8c94e363907c1abc458067bfd
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250203
> > > Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
> > > Commit-Queue: Björn Terelius <terelius@webrtc.org >
> > > Cr-Commit-Position: refs/heads/main@{#35992}
> >
> > Bug: b/215140373
> > Change-Id: Id2b88cc4b8078a97275d49a617581cbbd02d2c6f
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252380
> > Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
> > Commit-Queue: Björn Terelius <terelius@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#36066}
>
> Bug: b/215140373
> Change-Id: I951ac26b8176e58da18e93835f13f6b9deb6d4fa
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252443
> Auto-Submit: Björn Terelius <terelius@webrtc.org >
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Commit-Queue: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36068}
Bug: b/215140373
Change-Id: Ie2b9a961d1e09dbeabeb6bfb02b43c047df69515
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252582
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
Cr-Commit-Position: refs/heads/main@{#36079}
2022-02-25 10:48:32 +00:00
7306c75c12
Revert "Reland "Refactor AnalyzerConfig to use Timestamps instead of microseconds.""
...
This reverts commit 7a992e21b9c3ff03aa34488a9c91fa580ca4faa6.
Reason for revert: Breaks downstream build due to type change.
Original change's description:
> Reland "Refactor AnalyzerConfig to use Timestamps instead of microseconds."
>
> This is a reland of 43fb16921b29ecd3a2d87876dda75c575e05f66a
>
> Original change's description:
> > Refactor AnalyzerConfig to use Timestamps instead of microseconds.
> >
> > Add optional offset-to-UTC parameter to output. This allows aligning
> > the x-axis in the generated charts to other UTC-based logs.
> >
> > Bug: b/215140373
> > Change-Id: I65bcd295718acbb8c94e363907c1abc458067bfd
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250203
> > Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
> > Commit-Queue: Björn Terelius <terelius@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#35992}
>
> Bug: b/215140373
> Change-Id: Id2b88cc4b8078a97275d49a617581cbbd02d2c6f
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252380
> Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
> Commit-Queue: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36066}
Bug: b/215140373
Change-Id: I951ac26b8176e58da18e93835f13f6b9deb6d4fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252443
Auto-Submit: Björn Terelius <terelius@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36068}
2022-02-24 17:14:23 +00:00
7a992e21b9
Reland "Refactor AnalyzerConfig to use Timestamps instead of microseconds."
...
This is a reland of 43fb16921b29ecd3a2d87876dda75c575e05f66a
Original change's description:
> Refactor AnalyzerConfig to use Timestamps instead of microseconds.
>
> Add optional offset-to-UTC parameter to output. This allows aligning
> the x-axis in the generated charts to other UTC-based logs.
>
> Bug: b/215140373
> Change-Id: I65bcd295718acbb8c94e363907c1abc458067bfd
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250203
> Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
> Commit-Queue: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35992}
Bug: b/215140373
Change-Id: Id2b88cc4b8078a97275d49a617581cbbd02d2c6f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252380
Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36066}
2022-02-24 14:56:53 +00:00
66bfd6f57d
Revert "Refactor AnalyzerConfig to use Timestamps instead of microseconds."
...
This reverts commit 43fb16921b29ecd3a2d87876dda75c575e05f66a.
Reason for revert: New type breaks downstream projects.
Original change's description:
> Refactor AnalyzerConfig to use Timestamps instead of microseconds.
>
> Add optional offset-to-UTC parameter to output. This allows aligning
> the x-axis in the generated charts to other UTC-based logs.
>
> Bug: b/215140373
> Change-Id: I65bcd295718acbb8c94e363907c1abc458067bfd
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250203
> Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
> Commit-Queue: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35992}
TBR=terelius@webrtc.org ,kerl@google.com ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: If4f2330b9731f26a0e55c9ce9a500322a111b783
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/215140373
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251691
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Evan Shrubsole <eshr@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@google.com >
Cr-Commit-Position: refs/heads/main@{#35994}
2022-02-14 15:01:51 +00:00
43fb16921b
Refactor AnalyzerConfig to use Timestamps instead of microseconds.
...
Add optional offset-to-UTC parameter to output. This allows aligning
the x-axis in the generated charts to other UTC-based logs.
Bug: b/215140373
Change-Id: I65bcd295718acbb8c94e363907c1abc458067bfd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250203
Reviewed-by: Kristoffer Erlandsson <kerl@google.com >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35992}
2022-02-14 13:48:40 +00:00
6cae2d5513
Reland "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
...
This reverts commit 3f87250a4f0e6c69002fbcdfb995b0dfcd7bf710.
Reason for revert: Downstream is fixed
Original change's description:
> Revert "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
>
> This reverts commit 5f0eb93d2a44cec2102fc8c3757d5bb814bd145f.
>
> Reason for revert: Breaks downstream project. I'm going to fix that one and create a reland of this CL after.
>
> Original change's description:
> > Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely
> >
> > Bug: webrtc:13555, webrtc:13082
> > Change-Id: Iff2cda6f516739419e97e975e03f77a98f74be03
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249260
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Reviewed-by: Artem Titov <titovartem@webrtc.org >
> > Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com >
> > Cr-Commit-Position: refs/heads/main@{#35805}
>
> TBR=hta@webrtc.org ,titovartem@webrtc.org ,daniel.l@hpcnt.com ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: I33d497f1132adfe6d151023195a388d9b7d548f9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:13555, webrtc:13082
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249364
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Owners-Override: Artem Titov <titovartem@webrtc.org >
> Reviewed-by: Andrey Logvin <landrey@webrtc.org >
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35807}
# Not skipping CQ checks because this is a reland.
Bug: webrtc:13555, webrtc:13082
Change-Id: I7ef1ef3b6e3c41b1a96014aa75f003c0fcf33949
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249365
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35814}
2022-01-27 12:55:44 +00:00
3f87250a4f
Revert "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
...
This reverts commit 5f0eb93d2a44cec2102fc8c3757d5bb814bd145f.
Reason for revert: Breaks downstream project. I'm going to fix that one and create a reland of this CL after.
Original change's description:
> Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely
>
> Bug: webrtc:13555, webrtc:13082
> Change-Id: Iff2cda6f516739419e97e975e03f77a98f74be03
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249260
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com >
> Cr-Commit-Position: refs/heads/main@{#35805}
TBR=hta@webrtc.org ,titovartem@webrtc.org ,daniel.l@hpcnt.com ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: I33d497f1132adfe6d151023195a388d9b7d548f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:13555, webrtc:13082
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249364
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Owners-Override: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35807}
2022-01-26 14:56:14 +00:00
5f0eb93d2a
Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely
...
Bug: webrtc:13555, webrtc:13082
Change-Id: Iff2cda6f516739419e97e975e03f77a98f74be03
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249260
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com >
Cr-Commit-Position: refs/heads/main@{#35805}
2022-01-26 14:22:16 +00:00
c1ccc821bb
remove loopback test
...
which relies on no-longer existing apprtc infrastructure
BUG=None
Change-Id: I1cecc039c69dff5923b5f57c872e74155c46ed05
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247662
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/main@{#35747}
2022-01-20 08:18:39 +00:00
14af7622a7
Remove RTC_DISALLOW_COPY_AND_ASSIGN from rtc_base/
...
Bug: webrtc:13555, webrtc:13082
Change-Id: I406b7f04497562866ea3329e97c5adc96e927b6f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245680
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com >
Cr-Commit-Position: refs/heads/main@{#35691}
2022-01-13 20:42:15 +00:00
