It can be computed from other members, notably the current encoder's
number of channels.
BUG=webrtc:5028
Review URL: https://codereview.webrtc.org/1423803007
Cr-Commit-Position: refs/heads/master@{#10585}
In https://codereview.webrtc.org/1430023005 all the code
references to ICU were removed. This actually removes the
library from being referenced.
TESTED=git cl try -c --bot=win_compile_rel --bot=linux_compile_rel --bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m tryserver.webrtc
R=phoglund@webrtc.org
Review URL: https://codereview.webrtc.org/1417563006 .
Cr-Commit-Position: refs/heads/master@{#10584}
Receiving RTCP often caused the worker thread to stall for >20 ms
(>100ms observed) due to contention on VideoSender's send_crit_ (used to
protect encoding).
This change removes an unnecessary acquire of send_crit_ and caches
encoder settings in ViEEncoder instead of acquiring them through
::SendCodec() in VCM (which is blocking).
BUG=webrtc:5106
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1433703002 .
Cr-Commit-Position: refs/heads/master@{#10582}
Future CLs will move it even further down the stack.
BUG=webrtc:5028
Review URL: https://codereview.webrtc.org/1431103002
Cr-Commit-Position: refs/heads/master@{#10580}
VP9 is put as second codec in supported codec list.
BUG=chromium:500602
Review URL: https://codereview.webrtc.org/1432673002
Cr-Commit-Position: refs/heads/master@{#10577}
On Android, we would like to use MediaCodec output buffers to hold decoded frames until they can be rendered to a texture. There can only be one texture buffer used at the same time and therefore the calculated decode time in VCMTiming will be wrong since that calculation will also include the time where the decoder waited for the upper layers (that depend on network jitter and actual render time) to release the frame.
This new method will be used in
https://codereview.webrtc.org/1422963003/
BUG=webrtc:4993
R=stefan@webrtc.orgTBR=mflodman@webrtc.org
Review URL: https://codereview.webrtc.org/1414693006 .
Cr-Commit-Position: refs/heads/master@{#10576}
minyue@ (myself) works on multiple audio projects and it is good to keep track of audio related changes. e.g., VOE, ACM, APM and NetEq.
TBR=tina.legrand@webrtc.org
BUG=
Review URL: https://codereview.webrtc.org/1413723012
Cr-Commit-Position: refs/heads/master@{#10573}
-Made the component error messages generic to be an unspecified error message.
BUG=webrtc:5099
Review URL: https://codereview.webrtc.org/1404743003
Cr-Commit-Position: refs/heads/master@{#10570}
When converting from void* to unsigned long long it is dangerous to go
through unsigned long because for VC++ 64-bit builds this will be 32
bits. When casting a pointer to an integral type the safest type to
choose for the integral cast is always intptr_t or uintptr_t.
BUG=440500
NOPRESUBMIT=true
Review URL: https://codereview.webrtc.org/1437433002
Cr-Commit-Position: refs/heads/master@{#10569}
Opus may have an internal error that causes this. Here we make a workaround by adding some small disturbance to the input signals to break a long sequence of zeros.
BUG=webrtc:5127
Review URL: https://codereview.webrtc.org/1415173005
Cr-Commit-Position: refs/heads/master@{#10565}
The test is currently disabled as it takes too long to run in a coffe-cup manner
BUG=webrtc:5099
Review URL: https://codereview.webrtc.org/1394803002
Cr-Commit-Position: refs/heads/master@{#10560}
This change VideoCapturerAndroid to attempt 3 times with a period of 300ms to open the camera if it fails.
This is so that if another application have it already opened, it would have more time to release it.
BUG=b/25190234
Review URL: https://codereview.webrtc.org/1422023007
Cr-Commit-Position: refs/heads/master@{#10559}
If SurfaceViewRenderer can't keep up with the stream of incoming frames it has to drop frames. Currently, new frames are dropped until the old pending frame is rendered. This CL drops the old pending frame instead.
Review URL: https://codereview.webrtc.org/1417063005
Cr-Commit-Position: refs/heads/master@{#10558}
Also distinguish between camera failures and failures due to that buffers has not been returned.
Adds unit tests for making sure CameraEventHandler.onError is triggered if frames are not returned.
BUG=b/25514149
Review URL: https://codereview.webrtc.org/1415013006
Cr-Commit-Position: refs/heads/master@{#10555}
This is a follow-up CL for https://codereview.webrtc.org/1417683006
now that downstream code has been updated to use the 'include' directories
for header files instead.
BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel -m tryserver.webrtc --bot=ios_rel
Review URL: https://codereview.webrtc.org/1414793020
Cr-Commit-Position: refs/heads/master@{#10547}
JNI already has jstring<->UTF8 string conversion, so using that should
save ~1mb off android binaries (ICU is *large*), probably around
300-400k after compression.
BUG=
Review URL: https://codereview.webrtc.org/1430023005
Cr-Commit-Position: refs/heads/master@{#10545}
Removed Rand(int low, int high) since that function outputs results that are non-random and/or outside the interval if low is negative.
Added new Uniform(uint32_t, uint32_t) function to replace Rand(int low, int high).
Changed various unit tests to use the new functions.
BUG=
Review URL: https://codereview.webrtc.org/1413053002
Cr-Commit-Position: refs/heads/master@{#10541}
The defines still in use was only used in single files, so they were
moved to these specific cc-files.
Review URL: https://codereview.webrtc.org/1411573007
Cr-Commit-Position: refs/heads/master@{#10539}
