Commit Graph

28611 Commits

Author SHA1 Message Date
19a1d50ccf Refactor WavWriter to use FileWrapper rather than PlatformFile
Bug: webrtc:6463
Change-Id: I4c80995481ed7d5c1079450d04ed7958fa137e84
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141662
Reviewed-by: Henrik Grunell <henrikg@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28279}
2019-06-14 10:18:28 +00:00
04e129ab1d Revert "Populate the GFD-00 for H264 and generic codecs."
This reverts commit d3c6f9ccffe88749fde8bc1320baa1fe2db15b6b.

Reason for revert: Break downstream perf tests.

Original change's description:
> Populate the GFD-00 for H264 and generic codecs.
> 
> Bug: none
> Change-Id: I368eb38740314280db87aaf8e179e9bd0fc20c3c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/103502
> Commit-Queue: Philip Eliasson <philipel@webrtc.org>
> Reviewed-by: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28272}

TBR=nisse@webrtc.org,philipel@webrtc.org

Change-Id: I8582099dfca3a2acbf434214a3cf29572d7ad647
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142163
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28278}
2019-06-14 09:04:21 +00:00
1a285e081d Roll chromium_revision 96eca2d491..f165a6d5de (668951:669076)
Change log: 96eca2d491..f165a6d5de
Full diff: 96eca2d491..f165a6d5de

Changed dependencies
* src/base: 0a5b5a0b3c..bf8f8970a8
* src/build: 6b14af32fd..be4d13ba95
* src/ios: 0d988ccf0e..39a7f18090
* src/testing: 84fae89f8b..f9ca2dafb6
* src/third_party: dc5f8d5261..5fbfb27850
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/727d7ca273..e502dbcca0
* src/third_party/depot_tools: a74bd78e9c..bc23ca13f1
* src/tools: 3c454539c9..27a538e9e1
DEPS diff: 96eca2d491..f165a6d5de/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I648efe89357646b85353e655ff6d00fa1fdd3fe4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142100
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28277}
2019-06-14 01:40:37 +00:00
a9a2a753e1 Roll chromium_revision 22f062d604..96eca2d491 (668845:668951)
Change log: 22f062d604..96eca2d491
Full diff: 22f062d604..96eca2d491

Changed dependencies
* src/base: 6f056dd3eb..0a5b5a0b3c
* src/build: 377edc00fe..6b14af32fd
* src/ios: da70dae394..0d988ccf0e
* src/testing: 1b0ab755f1..84fae89f8b
* src/third_party: 1741116d91..dc5f8d5261
* src/third_party/depot_tools: 374a128977..a74bd78e9c
* src/tools: 20ba638055..3c454539c9
DEPS diff: 22f062d604..96eca2d491/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ifb08ed476e3c8668560e98c389f55b3c3db4ba5b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142040
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28276}
2019-06-13 22:19:25 +00:00
c5effc2453 Remove DataContentDescription shim
Bug: webrtc:10597
Change-Id: Id0cbb78846d2b248bc2ab650eb7c06b50bc825bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140100
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28275}
2019-06-13 18:33:40 +00:00
ef3fd9c8ad Add support for simulcast with Vp8 from caller into PC level quality tests.
Add support of negotiating simulcast offer/answer. Also fix some minor
issues around to make it finally work.

Bug: webrtc:10138
Change-Id: I382f5df04ca6ac04d8ed1e030e7b2ae5706dd10c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137425
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Amit Hilbuch <amithi@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28274}
2019-06-13 17:27:09 +00:00
6751260241 Roll chromium_revision b08bd9b643..22f062d604 (668716:668845)
Change log: b08bd9b643..22f062d604
Full diff: b08bd9b643..22f062d604

Changed dependencies
* src/base: 68f52403e3..6f056dd3eb
* src/build: afe9cbd54d..377edc00fe
* src/buildtools: 5b97b40654..09893e534d
* src/buildtools/third_party/libc++/trunk: 78822a6853..5938e0582b
* src/ios: 0e29396fe5..da70dae394
* src/third_party: e832ae1894..1741116d91
* src/third_party/android_deps/libs/com_google_ar_core: version:1.8.0-cr0..4_5y1Cw_L1MHu3UedmkavqbZ7H7sYPBTdpcAOJQvlXkC
* src/third_party/freetype/src: d1b16325e2..e7ac9288ac
* src/tools: 4ae0c7f02a..20ba638055
DEPS diff: b08bd9b643..22f062d604/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I655b638d21314f80ac886c9786d0766f3e12d544
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141960
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28273}
2019-06-13 16:42:12 +00:00
d3c6f9ccff Populate the GFD-00 for H264 and generic codecs.
Bug: none
Change-Id: I368eb38740314280db87aaf8e179e9bd0fc20c3c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/103502
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28272}
2019-06-13 16:40:32 +00:00
9e25f74faa Update visibility for JNI targets in sdk/android.
Bug: webrtc:9048
Change-Id: I16f77f3bf77e3fdfa8fd9792a6ab13aa872c32f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141869
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Paulina Hensman <phensman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28271}
2019-06-13 16:05:23 +00:00
5894b6aad4 Add kPayloadTypeGeneric to CallTest and use it in VideoQualityTest.
- Add CallTest::kPayloadTypeGeneric
- Allow for unrecognized codec names in VideoQualityTest.
  Generic packetization is implicitly enabled for these codecs.

Tested: autoninja -C out/Debug && out/Debug/video_loopback
Bug: webrtc:10738
Change-Id: I57001be997db2f0eed9197eb40801b5ad936d222
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141864
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Michael Horowitz <mhoro@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28270}
2019-06-13 15:45:00 +00:00
5740afa0a4 Removes SimulatedTimeClient
Bug: webrtc:9883
Change-Id: Id6e760b37360e7dafc67ded99e06128be20797d1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141417
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28269}
2019-06-13 15:37:10 +00:00
6fd67f086c Pass java EncodedImage over jni to VideoEncoderWrapper::OnEncodedFrame
Preparation for adding a release() method on java's EncodedImage, and
call that from C++.

Bug: webrtc:9378
Change-Id: I301f64b16684c535f45a3fc9cd9ae1543df59d92
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141861
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28268}
2019-06-13 15:19:10 +00:00
f3f57700a8 Using full scenario test client for loss based control test.
Bug: webrtc:9883
Change-Id: I7c3b2561ddba846e4cdde05e1067679ada14ad80
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141405
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28267}
2019-06-13 14:44:09 +00:00
4284828887 Remove deprecated version of RtpPacket::SetPadding that used to randomize padding
was deprecated in
https://webrtc-review.googlesource.com/c/src/+/103983

Bug: None
Change-Id: I617b7b5112446deaa9be983978cabdb247638266
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141865
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28266}
2019-06-13 14:38:38 +00:00
5a8f860a01 Prepare for deletion of the NO_MAIN_THREAD_WRAPPING preprocessor define
This is a partial reland of
https://webrtc-review.googlesource.com/c/src/+/39680,
including only the (hopefully) non-problematic parts of it, but
postponing actual deletion of automatic thread wrapping.

Bug: webrtc:9714
Change-Id: I9b79dd073f0e945cbb62f3b54cff05eaaea9b06c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141664
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28265}
2019-06-13 13:51:17 +00:00
50dd80b96f Remove data channel only .so-file.
Bug: webrtc:10733
Change-Id: Ia08b9a03e41442f1b0407df575fc9f7d0a1bc86a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141415
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Paulina Hensman <phensman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28264}
2019-06-13 13:37:55 +00:00
3c396e52da Add injectable video encoder and decoder to video quality test.
Bug: webrtc:10738
Change-Id: Ia5180cf0252ecd1c58a2080e3954fcb886b066e3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141667
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28263}
2019-06-13 13:03:05 +00:00
54374a07ef Delete unused C functions wrapping the WavWriter class
Bug: None
Change-Id: Iea766c76e99f066a4cdad0d5039e266a6bba7664
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141660
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28262}
2019-06-13 11:03:32 +00:00
79890ef91f Remove sync buffer length from FilteredCurrentDelayMs.
The sync buffer length is already added when the buffer level filter is updated.

Bug: webrtc:10736
Change-Id: Icbd411d4fd7b16f31b800142d1b6a8de79365d91
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140950
Reviewed-by: Minyue Li <minyue@webrtc.org>
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28261}
2019-06-13 09:38:22 +00:00
35c26284a9 Roll chromium_revision 7bd802608f..b08bd9b643 (668611:668716)
Change log: 7bd802608f..b08bd9b643
Full diff: 7bd802608f..b08bd9b643

Changed dependencies
* src/ios: 37a97f04ee..0e29396fe5
* src/testing: 90c4434fd8..1b0ab755f1
* src/third_party: 09e15b4525..e832ae1894
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/86a9e51b7a..727d7ca273
* src/tools: e2cc580e74..4ae0c7f02a
DEPS diff: 7bd802608f..b08bd9b643/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I4bcb8a17ca4a0092a1cfd36eca27891bf794a7d9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141800
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28260}
2019-06-13 06:35:15 +00:00
a7acc4dd8d Roll chromium_revision 3ae19953a9..7bd802608f (668510:668611)
Change log: 3ae19953a9..7bd802608f
Full diff: 3ae19953a9..7bd802608f

Changed dependencies
* src/build: ca4e2155f5..afe9cbd54d
* src/buildtools: 2e18a95798..5b97b40654
* src/buildtools/third_party/libc++/trunk: 5938e0582b..78822a6853
* src/ios: b888fc82ae..37a97f04ee
* src/testing: 56e3163469..90c4434fd8
* src/third_party: 9368f4073f..09e15b4525
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b64faff265..86a9e51b7a
* src/third_party/libjpeg_turbo: 2de84a43e6..2a34770be9
* src/tools: 782cea2ab0..e2cc580e74
DEPS diff: 3ae19953a9..7bd802608f/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: If01daa68eb3b20f53fb5feb71ea9d2467b33a4ff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141700
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28259}
2019-06-13 00:53:13 +00:00
38c8cc8cc9 Roll chromium_revision b2cb08aba4..3ae19953a9 (668407:668510)
Change log: b2cb08aba4..3ae19953a9
Full diff: b2cb08aba4..3ae19953a9

Changed dependencies
* src/base: eb50f0bc42..68f52403e3
* src/build: 776240e5ce..ca4e2155f5
* src/ios: 30f3b17c51..b888fc82ae
* src/testing: 4e8cebbfe6..56e3163469
* src/third_party: 54c69cf370..9368f4073f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1750292dc4..b64faff265
* src/tools: c1b027f72b..782cea2ab0
DEPS diff: b2cb08aba4..3ae19953a9/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: If93539097b0fdd52c9b93b8204b77252320feecb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141680
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28258}
2019-06-12 19:36:20 +00:00
f2a88eb158 Roll chromium_revision 8c7df39d6b..b2cb08aba4 (668283:668407)
Change log: 8c7df39d6b..b2cb08aba4
Full diff: 8c7df39d6b..b2cb08aba4

Changed dependencies
* src/base: 79864edc82..eb50f0bc42
* src/build: 4b9a126822..776240e5ce
* src/ios: 6e4139b8a6..30f3b17c51
* src/testing: 4d28b59f71..4e8cebbfe6
* src/third_party: 43ed6dfdba..54c69cf370
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4d6b614ed2..1750292dc4
* src/third_party/freetype/src: 78c02bc110..d1b16325e2
* src/tools: c68e576c5c..c1b027f72b
DEPS diff: 8c7df39d6b..b2cb08aba4/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I68b0b39ac2f4d38bd12750813da407e87675a75d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141649
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28257}
2019-06-12 16:17:21 +00:00
51db421682 Skip cropping for frames that can't be converted to i420.
Some downstream clients have custom frame types that can't be converted.
The rest of EncodeVideoFrame is protected against these frames, but the
crop code assumes ToI420 always succeeds.

Bug: None
Change-Id: I8f4279e3975d3ae8cd1da59f7e84fafe0404fd15
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141646
Commit-Queue: Noah Richards <noahric@chromium.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28256}
2019-06-12 15:33:01 +00:00
44bc19b0f8 Delete TestAudioDeviceModule methods using rtc::PlatformFile
Bug: webrtc:6463
Change-Id: I5d1d9e9036b5e745d5b37c971de91b1b38fdd368
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141666
Reviewed-by: Henrik Grunell <henrikg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28255}
2019-06-12 15:28:41 +00:00
08fa953711 Reland "Delete TestAudioDeviceModule factory which uses GlobalTaskQueueFactory"
This reverts commit fd5166c305068772d00ad7edf50151bba215400b.

Reason for revert: Stop using CreateTestAudioDeviceModule in downstream

Original change's description:
> Revert "Delete TestAudioDeviceModule factory which uses GlobalTaskQueueFactory"
> 
> This reverts commit fc961357a721cd87dcd45ed409c66cb8cda6f4a2.
> 
> Reason for revert: Breaks downstream importer.
> 
> Original change's description:
> > Delete TestAudioDeviceModule factory which uses GlobalTaskQueueFactory
> > 
> > Bug: webrtc:10284
> > Change-Id: Ic92f6ff31b40c48a3362745a0a81179af0595fe0
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141409
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#28227}
> 
> TBR=danilchap@webrtc.org,kwiberg@webrtc.org
> 
> Change-Id: Id6d7571f48771646ddce0f05139a7ea0107759fb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10284
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141414
> Reviewed-by: Philip Eliasson <philipel@webrtc.org>
> Commit-Queue: Philip Eliasson <philipel@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28228}

TBR=danilchap@webrtc.org,kwiberg@webrtc.org,philipel@webrtc.org

Change-Id: I42bc19793d48350ca45b751d7e1b26124ac7fbb9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10284
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141670
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28254}
2019-06-12 14:44:01 +00:00
65d9c4d761 Create rate allocator after codec bitrates are set.
Before this change the max bitrate could be updated after it was passed
to rate allocator.

Bug: none
Change-Id: I742fca0f122bef3e95c1a768d6e844f8c28b6279
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141661
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28253}
2019-06-12 13:34:24 +00:00
f53cfa9ebe Add new RtpPacketPacer interface, with callback.
This CL just adds the new interfaces, follow-ups will add implementation
in various parts of the code, and then do cleanup once usage of old
interface is gone.

Bug: webrtc:10633
Change-Id: Icd916f4220065c0d0e4f3f0bfaaed248f8c70d08
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140891
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28252}
2019-06-12 13:21:54 +00:00
e794243650 Remove PacedSender::PacketSender interface and use PacketRouter directly
This interface makes future refactoring difficult and is now in practice
only implemented by PacketRouter.

Bug: webrtc:10633
Change-Id: I3fcb8940781aa7431119649bde7594592a8c8851
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141669
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28251}
2019-06-12 13:09:04 +00:00
6e9c2fd08e Delete StartRtcEventLog and StopRtcEventLog methods from FakeVoiceEngine
Bug: webrtc:6463
Change-Id: I52a49932334cbf9b5a1aeb17412983c57cb65186
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141671
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28250}
2019-06-12 12:47:26 +00:00
9c16af7eb7 Add a tracker for RTCRtpContributingSource and RTCRtpSynchronizationSource.
This change adds a new SourceTracker class that can do spec-compliant tracking of RTCRtpContributingSource and RTCRtpSynchronizationSource when frames are delivered to the RTCRtpReceiver's MediaStreamTrack for playout. It will replace the existing spec-incompliant ContributingSources.

Bug: webrtc:10545 webrtc:10668
Change-Id: I961adaba09d6337f2f36b301a4fabcd20de65271
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140948
Commit-Queue: Chen Xing <chxg@google.com>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28249}
2019-06-12 12:11:55 +00:00
da1c65fb53 Change reporting of time_between_freezes.
Report time_between_freezes as test duration when there were no freezes
in the call.

Bug: webrtc:10138
Change-Id: I3d99be4b714f1b1d13e7b8b7055b368a20859490
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141665
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28248}
2019-06-12 11:57:03 +00:00
5cf390386b Allow Vp8FrameBufferController::UpdateConfiguration to reset set of overrides
Bug: webrtc:10737
Change-Id: Ifdf82f140465d114300eda1e3ba1a26c70aaef76
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141663
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28247}
2019-06-12 10:12:44 +00:00
a9952cb0c4 Uncomment "override" in simulcast_encoder_adapter_unittest.cc
Bug: None
Change-Id: I4f07bb27d08ccac43adb59c90823e487fa0cced3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140951
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28246}
2019-06-12 08:18:28 +00:00
47ae30358e Delete deprecated method VideoCodingModule::SetReceiverRobustnessMode
Bug: webrtc:7408
Change-Id: Ie0eb5b4b1522948bc215cab6e3aaaa745f4b3698
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141401
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28245}
2019-06-12 06:39:38 +00:00
71af422e75 Roll chromium_revision 3f2b27ad87..8c7df39d6b (668132:668283)
Change log: 3f2b27ad87..8c7df39d6b
Full diff: 3f2b27ad87..8c7df39d6b

Changed dependencies
* src/build: 8fb9a22eff..4b9a126822
* src/ios: 31f46415d6..6e4139b8a6
* src/testing: a5eca0117d..4d28b59f71
* src/third_party: 2a2fd52389..43ed6dfdba
* src/third_party/depot_tools: fd919c8d3d..374a128977
* src/tools: 5435ca197d..c68e576c5c
DEPS diff: 3f2b27ad87..8c7df39d6b/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ib276178d6aabcb75a08ab87c851b703cf83e8b14
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141640
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28244}
2019-06-12 05:30:47 +00:00
9409fbbd56 Roll chromium_revision 49f304eb89..3f2b27ad87 (667988:668132)
Change log: 49f304eb89..3f2b27ad87
Full diff: 49f304eb89..3f2b27ad87

Changed dependencies
* src/base: 9f4a495489..79864edc82
* src/build: 99f1fb6113..8fb9a22eff
* src/ios: ad44a50e6a..31f46415d6
* src/testing: af7a13f5e4..a5eca0117d
* src/third_party: 522f5229b7..2a2fd52389
* src/tools: 028ba41ccf..5435ca197d
DEPS diff: 49f304eb89..3f2b27ad87/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ibaf37d7840fafeb3d1db1f216063119722d7ec50
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141520
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28243}
2019-06-11 21:57:07 +00:00
a27958421c Inform FrameBufferController of encoder capabilities
Bug: webrtc:10720
Change-Id: I958b83e29e8e87252e08419b8e16d554983a1a63
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140941
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28242}
2019-06-11 19:26:23 +00:00
00e71ef49e Fix TaskQueueLibevent::PostTask when used on the same TaskQueue
Stop using event_base_once because it doesn't guarantee to free QueuedTask when task not run and thus may break TaskQueue guarantee all posted tasks are eventually deleted

Bug: webrtc:10731, webrtc:10278
Change-Id: Id073a6092cf603cac5768da7a0770371053b20cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141420
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28241}
2019-06-11 18:08:18 +00:00
eceb537086 Add RtpPacketHistory::SetSendTime()
This method will be used instead of GetPacketAndSetSendTime() when the
new pacer code path is used, where the packet isn't stored in the
history during pacing.

Bug: webrtc:10633
Change-Id: Ie168125d949cef617ade3868a1858ed1dffe909c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140892
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28240}
2019-06-11 17:49:51 +00:00
ef10a4ceb6 Remove deprecated JsepSession initializer
Also removes SessionDescription::Copy.

Bug: webrtc:10612
Change-Id: Ib652d717531738c3ed5d1054e32a03961e16dba9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139903
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28239}
2019-06-11 17:35:30 +00:00
f2b813a951 Roll chromium_revision d40bd8bb36..49f304eb89 (667853:667988)
Change log: d40bd8bb36..49f304eb89
Full diff: d40bd8bb36..49f304eb89

Changed dependencies
* src/base: da47bc1e98..9f4a495489
* src/build: aeede42d82..99f1fb6113
* src/ios: 6db103ffc0..ad44a50e6a
* src/testing: 689eb2b4c1..af7a13f5e4
* src/third_party: a0e0efb156..522f5229b7
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ace1f8b4d2..4d6b614ed2
* src/third_party/freetype/src: 7fde521bd9..78c02bc110
* src/tools: 1b9dd4610e..028ba41ccf
DEPS diff: d40bd8bb36..49f304eb89/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Iedbf95719c301053b6bf40f14edec83d6223a9e4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141440
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#28238}
2019-06-11 16:42:55 +00:00
1aa9ee92f8 Add string-based IDs for event log visualizer graphs and update command line flags.
The IDs be more stable than the plot titles and could be used to identify specific graphs in scripts.

Change event_log_visualizer command line interface to control which plots are generated.
Old interface had one command line flag per plot as well as a set of 'profiles' that enabled
of disabled sets of plots. New interface has a command line flag
which takes a string of all the plot names or profiles that should be enabled.
In some cases, there are also slight naming changes for the plots.

For example, the former command
event_log_visualizer --plot_profile=sendside_bwe --plot_incoming_packet_sizes <filename> | python
is now
event_log_visualizer --plot=sendside_bwe,incoming_packet_sizes <filename> | python

The former command
event_log_visualizer --plot_profile=none --plot_incoming_packet_sizes <filename> | python
is now
event_log_visualizer --plot=incoming_packet_sizes <filename> | python

The former command
event_log_visualizer --plot_profile=all <filename> | python
is now
event_log_visualizer --plot=all <filename> | python


Bug: webrtc:10623
Change-Id: Ife432c1e51edfce64af565a769f1764a16655bb6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140886
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28237}
2019-06-11 16:41:50 +00:00
370f93a34a Reland "Inform VideoEncoder of negotiated capabilities"
This is a reland of 11dfff0878c949f2e19d95a0ddc209cdad94b3b4

Now that I am sure that WebRTC code is not calling the obsolete
versions, I will just remove the NOT_REACHED and call the
new version from the old ones, so as not to trip up downstream
projects.

Original change's description:
> Inform VideoEncoder of negotiated capabilities
>
> After this CL lands, an announcement will be made to
> discuss-webrtc about the deprecation of one version
> of InitEncode().
>
> Bug: webrtc:10720
> Change-Id: Ib992af0272bbb16ae16ef7e69491f365702d179e
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140884
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Commit-Queue: Elad Alon <eladalon@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28224}

TBR=sakal@webrtc.org,kwiberg@webrtc.org,sprang@webrtc.org

Bug: webrtc:10720
Change-Id: I46c69e45c190805c07f7e51acbe277d7eebd1600
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141412
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28236}
2019-06-11 14:49:37 +00:00
95e0a607f6 Increase TaskQueueTest.PostALot timeouts
recent changed decreased timeout from forever to 1s which is not enough on some platforms
Increase timeout to forever for posting 65k tasks.
Also increase timeout for eventual destruction of the tasks to reduce change it would flake.

Bug: chromium:972917
Change-Id: I4948d49c1514833ab190856fdd25a47a5bad91eb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141410
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28235}
2019-06-11 14:42:18 +00:00
5b2eda4895 Sanity-check field trial string at initialization.
It's easy to make small errors when building field trial strings, and
those errors can cause all sorts of weird problems. This CL checks if
the FT string has an odd number of delimiters, duplicate
names or any trailing chars.

If so we'll log a error message. On debug builds we'll also crash.

Bug: webrtc:10729
Change-Id: Iebf7155d9b117a02d1e9cfe7f64408e11df2aec5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140866
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28234}
2019-06-11 14:11:06 +00:00
e8e4dc4c8b Change StartAecDump methods to work with FILE* and FileWrapper
Bug: webrtc:6463
Change-Id: Id275975decb9b2876021ced19ee9f279b07bea53
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140283
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28233}
2019-06-11 13:43:36 +00:00
7742b21839 Removes legacy bitrate controller.
Bug: webrtc:9883
Change-Id: I66af2597059fc1f38c78682f6884361a4d16c4a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141408
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28232}
2019-06-11 13:16:05 +00:00
171bd2644d Delete unused MacOS code related to ERRCTX_OSSTATUS
Bug: webrtc:6424
Change-Id: I3f98d31677201fcc52e492a463945fb9f6f2e883
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138831
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28231}
2019-06-11 13:11:56 +00:00
28aced5c3c Adds debug logs for loss based controller.
Bug: webrtc:9883
Change-Id: I525d88b1eba22f6198da04b1e18c26ec4a15c42d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141406
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28230}
2019-06-11 13:08:55 +00:00