772066bf16
Reland "Split peer_connection_integrationtest.cc into pieces"
...
This reverts commit 8644f2b7632cff5e46560c2f5cf7c0dc071aa32d.
Reason for revert: Fixed the bugs
Original change's description:
> Revert "Split peer_connection_integrationtest.cc into pieces"
>
> This reverts commit cae4656d4a7439e25160ff4d94e50949ff87cebe.
>
> Reason for revert: Breaks downstream build (missing INSTANTIATE_TEST_SUITE_P in pc/data_channel_integrationtest.cc).
>
> Original change's description:
> > Split peer_connection_integrationtest.cc into pieces
> >
> > This creates two integration tests: One for datachannel, the other
> > for every test that is not datachannel.
> >
> > It separates out the common framework to a new file in pc/test.
> > Also applies some fixes to IWYU.
> >
> > Bug: None
> > Change-Id: I919def1c360ffce205c20bec2d864aad9b179c3a
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207060
> > Reviewed-by: Henrik Boström <hbos@webrtc.org >
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#33244}
>
> TBR=hbos@webrtc.org ,hta@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> No-Try: True
> Bug: None
> Change-Id: I7dbedd3256cb7ff47eb5f8cd46c7c044ed0aa1e0
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207283
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#33255}
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: None
Change-Id: I1bb6186d7f898de82d26f4cd3d8a88014140c518
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207864
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33283}
2021-02-16 18:53:18 +00:00
3562318bde
Delete unused functions in RtpSender, RtcpSender and RtcpReceiver
...
These functions are not longer used by the RtpRtcp implementations.
Bug: None
Change-Id: Ibc36433b253b264de4cdcdf380f5ec1df201b17a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207862
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33282}
2021-02-16 14:16:22 +00:00
f4e3e2b83f
Delete rtc::Callback0 and friends.
...
Replaced with std::function.
Bug: webrtc:6424
Change-Id: Iacc43822cb854ddde3cb1e5ddd863676cb07510a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205005
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33281}
2021-02-16 12:41:35 +00:00
d6c81dbc20
Replace VideoLayerFrameId with int64_t.
...
Bug: webrtc:12206
Change-Id: I7e141806e417c4d98ce795d898f0d820e482113e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207860
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33280}
2021-02-16 11:43:04 +00:00
bdf78cb5bb
Bug fixes to EglBase10Impl.getNativeEglContext.
...
- Use matching config to avoid EGL_BAD_MATCH.
- Use the same display in both eglMakeCurrent calls to avoid
EGL_BAD_ACCESS on subsequent calls because the context was not
successfully unbound.
Bug: webrtc:12471
Change-Id: Ifdf4bd94cdfd14b683959b8703d75a2a46ec1226
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207861
Reviewed-by: Paulina Hensman <phensman@webrtc.org >
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33279}
2021-02-16 11:41:24 +00:00
067b050213
Delete deprecated unused functions from RtpRtcp interface
...
Bug: None
Change-Id: Iceb59d726c328974c3ccbf52a782ac9e25bd57c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205581
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33278}
2021-02-16 10:23:41 +00:00
2c8d9299c8
QualityScalingTests: Add tests for VP9.
...
Bug: none
Change-Id: Ic6e8539dfd1a43581eb4bfc26a2b04b9cd6a4cab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207435
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33277}
2021-02-16 09:53:44 +00:00
c79bd433a1
Delete friendship between VirtualSocket and VirtualSocketServer
...
Bug: webrtc:11567
Change-Id: I07d01b9eed798a69ba798e899b2bae57409ce332
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207181
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33276}
2021-02-16 09:10:16 +00:00
686ad4ff06
Resolve relative paths in sdk build scripts.
...
E.g. such command:
./src/tools_webrtc/ios/build_ios_libs.sh --build_config debug \
--arch arm64 --output-dir ./out/ios_debug/
Failed before this CL, because build files actually saved into different
location and when attempted to copy to destinatoin dir error occurred.
No-Presubmit: True
Bug: None
Change-Id: Ib7dd23a95cc81873c0eb61cc3c6bf51573936f78
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206810
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33275}
2021-02-16 08:06:01 +00:00
d1bbec3120
Update WebRTC code version (2021-02-16T04:03:42).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I7f6a4b16064f65553e7755f464c430a19a7a6e9d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207806
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33274}
2021-02-16 05:16:44 +00:00
b73c9f0bc3
Extract SystemTimeNanos to its own file
...
Prepare for this function to be overridden when WebRTC is included
into other applications such as chromium. This will make it
possible to remove code that keeps track of the difference between
WebRTC and chromium time.
Bug: chromium:516700
Change-Id: I73133804f945cc439f9827ec68a8e67b96d8560f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/204304
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33273}
2021-02-15 22:38:46 +00:00
8408c9938c
Remove 'secondary sink' concept from webrtc::VideoReceiveStream.
...
In practice, support for multiple sinks is not needed and supporting
the API that allows for dynamically adding/removing sinks at runtime,
adds to the complexity of the implementation.
This CL removes that Add/Remove methods for secondary sinks as well
as vectors of callback pointers (which were either of size 0 or 1).
Instead, an optional callback pointer is added to the config struct
for VideoReceiveStream, that an implementation can consider to be
const and there's not a need to do thread synchronization for that
pointer for every network packet.
As part of webrtc:11993, this simplifies the work towards keeping
the processing of network packets on the network thread. The secondary
sinks, currently operate on the worker thread.
Bug: webrtc:11993
Change-Id: I10c473e57d3809527a1b689f4352e903a4c78168
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207421
Commit-Queue: Tommi <tommi@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33272}
2021-02-15 18:08:17 +00:00
a33f41bf58
Support getNativeEglContext in EglBase10Impl.
...
Bug: webrtc:12471
Change-Id: Iac969b4985b4db02c18f07c4b5ec2a787e312560
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207434
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Paulina Hensman <phensman@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33271}
2021-02-15 16:52:40 +00:00
8623c75cc5
Remove ctor for BuiltInNetworkBehaviorConfig
...
The purpose is to allow parameterized construction.
Ex,
const webrtc::BuiltInNetworkBehaviorConfig good_network_config = {
.queue_length_packets = 50,
.queue_delay_ms = 10,
.link_capacity_kbps = 5000};
Bug: None
Change-Id: I36b216eea8d1fd69d37f2f9f67a9645a7de2a467
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207426
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33270}
2021-02-15 15:47:50 +00:00
453a125438
Remove no longer needed FrameDroppingOn setting in QualityScalingTests.
...
Bug: none
Change-Id: Id3868f947584616a7027a3985155a79c01e6dbb8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207422
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33269}
2021-02-15 15:10:49 +00:00
51746ce3fe
Revert "Replace RecursiveCriticalSection with Mutex in RTCAudioSession."
...
This reverts commit f8da43d179043f1df2e1c3e2c49494bc23f4ec28.
Reason for revert: Appears to break downstream app.
Original change's description:
> Replace RecursiveCriticalSection with Mutex in RTCAudioSession.
>
> Bug: webrtc:11567
> Change-Id: I2a2ddbce57d070d6cbad5a64defb4c27be77a665
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206472
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#33259}
TBR=nisse@webrtc.org ,kthelgason@webrtc.org ,hta@webrtc.org ,handellm@webrtc.org
Change-Id: Id9a97068722c7c72fc5d21102298249fd7a7cd9a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11567
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207431
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33268}
2021-02-15 14:52:03 +00:00
17ec2fc443
Remove log line that states that FlexFEC is disabled.
...
This log line adds no value, since the enable state of the feature can
already be deduced from the list of field trials. Instead, this log
line only contributes log spam in calls where `SetRemoteContent` is
called often.
Bug: chromium:1177690
Change-Id: Icafb537de9388df5475919432b3c99f28170e7de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207428
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33267}
2021-02-15 14:44:12 +00:00
6e35ecec1b
Destroy PC properly to stop input video before closing video writer
...
Bug: None
Change-Id: Ib0683ee1d2313371240ca85f4984eec5311ef695
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207281
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33266}
2021-02-15 14:43:07 +00:00
9aa9b8dbbe
Prepare to replace VideoLayerFrameId with int64_t.
...
Bug: webrtc:12206
Change-Id: I10bfdefbc95a79e0595956c1a0e688051da6d2b9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207180
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33265}
2021-02-15 14:42:02 +00:00
563fbc1dc5
Replace RecursiveCriticalSection with Mutex in DxgiDuplicatorController
...
Bug: webrtc:11567
Change-Id: I6d59de7ca60b69765118787fff023c485b1f405e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207160
Reviewed-by: Jamie Walch <jamiewalch@chromium.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33264}
2021-02-15 14:40:57 +00:00
410c99847b
Const correct NetworkEmulationManager::GetStats
...
This make it easier to create parameters from a single endpoint ptr.
Bug: None
Change-Id: Id64757353505a21c7731655e1b7a3178fa2e5ef8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207425
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33263}
2021-02-15 14:39:52 +00:00
21347458ad
Simplify PhysicalSocketServer
...
Merge OnPreEvent and OnEvent methods.
Merge EventDispatcher class into Signaler class.
Bug: None
Change-Id: I3c07613c76a32a628926569aab0e1076e48a0a79
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206983
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Taylor <deadbeef@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33262}
2021-02-15 14:38:47 +00:00
2afff37ba0
Update field trial for allowing cropped resolution when limiting max layers.
...
Make max_ratio:0.1 default.
BUG: webrtc:12459
Change-Id: Ia938836f2b95467fce66a38f2525b1d2be1a352b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206803
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33261}
2021-02-15 14:37:42 +00:00
58f29b0534
Roll chromium_revision b5988d40c8..e1b9354ff4 (853388:854007)
...
Change log: b5988d40c8..e1b9354ff4
Full diff: b5988d40c8..e1b9354ff4
Changed dependencies
* src/base: 8914659f46..242517a010
* src/build: d1fa78cb85..251bfc5101
* src/buildtools: 7e85fef7d9..228b1c1883
* src/buildtools/linux64: git_revision:55ad154c961d8326315b1c8147f4e504cd95e9e6..git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3
* src/buildtools/mac: git_revision:55ad154c961d8326315b1c8147f4e504cd95e9e6..git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3
* src/buildtools/win: git_revision:55ad154c961d8326315b1c8147f4e504cd95e9e6..git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3
* src/ios: ba0d254e6d..d365fb8897
* src/testing: f71ab6246f..7dee089ce5
* src/third_party: 4583d1a51a..d15b5c89b3
* src/third_party/androidx: hF9dL0GeFAftrouf8BezMHHVnB3KIDD1V1YgH3_c6IwC..09Q7fX-z4zxVsv_sl0K_cenKEZASVgwYe4goJB_KaIsC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d2aa56920c..35976bfcac
* src/third_party/depot_tools: 398091b193..7386a1e04f
* src/third_party/freetype/src: 54c5ad5c92..7849316ccf
* src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/648c6507f1..e72d81ffbc
* src/third_party/perfetto: d5c3eb6a5f..7945040041
* src/tools: 4858c5936c..bd77bcca0d
DEPS diff: b5988d40c8..e1b9354ff4
/DEPS
Clang version changed llvmorg-13-init-794-g83e2710e:llvmorg-13-init-1559-g01b87444
Details: b5988d40c8..e1b9354ff4
/tools/clang/scripts/update.py
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Id34de6fe850696aeb9a5825ad6eef37951451ed4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207741
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33260}
2021-02-15 14:36:39 +00:00
f8da43d179
Replace RecursiveCriticalSection with Mutex in RTCAudioSession.
...
Bug: webrtc:11567
Change-Id: I2a2ddbce57d070d6cbad5a64defb4c27be77a665
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206472
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33259}
2021-02-15 14:35:38 +00:00
a24f3d035f
Whitespace update
...
Rolling the dice once more. Hoping to roll three green Mac x64
builds to unblock the roll (last roll was several days ago).
TBR=mbonadei@webrtc.org ,alessiob@webrtc.org ,tommi@webrtc.org
Change-Id: I2fdbb87f0cda1a2c5c3a9ac50e1af1297cf9f2f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207424
Commit-Queue: Tommi <tommi@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33258}
2021-02-14 19:14:44 +00:00
f3ccab4e3f
Reland "Just adding my message in whitespace."
...
This reverts commit 130ff4974b8ef840c30be8c04d6da4a5a942cd4b.
Reason for revert: Another noop roll attempt. Looks like the builders are simply out of disk space though.
Original change's description:
> Revert "Just adding my message in whitespace."
>
> This reverts commit ad99c81da465f45dd28ad5ffbd05151b6274c461.
>
> Reason for revert: Triggering build to unblock roll.
>
> Original change's description:
> > Just adding my message in whitespace.
> >
> > Change-Id: I30556ce2cde868d55edbaa16a61b8c7cfaaacf53
> > Bug: None
> > TBR: mbonadei@webrtc.org
> > No-Try: True
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205624
> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> > Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#33163}
>
> TBR=mbonadei@webrtc.org ,alessiob@webrtc.org
>
> No-Try: True
> Bug: None
> Change-Id: Ica3444383c0212bc5a414d9cad7ee42ee7f323d8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207420
> Commit-Queue: Tommi <tommi@webrtc.org >
> Reviewed-by: Tommi <tommi@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#33254}
TBR=mbonadei@webrtc.org ,alessiob@webrtc.org ,tommi@webrtc.org
No-Try: True
Bug: None
Change-Id: I2b822452778d027638c0244b5e1d8ba7f1e45968
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207423
Commit-Queue: Tommi <tommi@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33257}
2021-02-14 14:20:04 +00:00
f91f8b517a
Consolidate full svc structures in one source file
...
Keeping structures in the same file makes it clearer which are missing
and makes it easier to see if structures are consistent with one another.
No-Try: True
Bug: None
Change-Id: I4e5e6971054dd28dd326c68369ee57b6df62725e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206987
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33256}
2021-02-13 16:17:54 +00:00
8644f2b763
Revert "Split peer_connection_integrationtest.cc into pieces"
...
This reverts commit cae4656d4a7439e25160ff4d94e50949ff87cebe.
Reason for revert: Breaks downstream build (missing INSTANTIATE_TEST_SUITE_P in pc/data_channel_integrationtest.cc).
Original change's description:
> Split peer_connection_integrationtest.cc into pieces
>
> This creates two integration tests: One for datachannel, the other
> for every test that is not datachannel.
>
> It separates out the common framework to a new file in pc/test.
> Also applies some fixes to IWYU.
>
> Bug: None
> Change-Id: I919def1c360ffce205c20bec2d864aad9b179c3a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207060
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#33244}
TBR=hbos@webrtc.org ,hta@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
No-Try: True
Bug: None
Change-Id: I7dbedd3256cb7ff47eb5f8cd46c7c044ed0aa1e0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207283
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33255}
2021-02-13 16:16:35 +00:00
130ff4974b
Revert "Just adding my message in whitespace."
...
This reverts commit ad99c81da465f45dd28ad5ffbd05151b6274c461.
Reason for revert: Triggering build to unblock roll.
Original change's description:
> Just adding my message in whitespace.
>
> Change-Id: I30556ce2cde868d55edbaa16a61b8c7cfaaacf53
> Bug: None
> TBR: mbonadei@webrtc.org
> No-Try: True
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205624
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#33163}
TBR=mbonadei@webrtc.org ,alessiob@webrtc.org
No-Try: True
Bug: None
Change-Id: Ica3444383c0212bc5a414d9cad7ee42ee7f323d8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207420
Commit-Queue: Tommi <tommi@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33254}
2021-02-13 16:08:32 +00:00
6603ca3b9a
Revert "Forward fix for BUILD file error"
...
This reverts commit df8baf6a8e989dff78730ea7a6556e562e6cb50f.
Reason for revert: Breaks downstream build (missing INSTANTIATE_TEST_SUITE_P in pc/data_channel_integrationtest.cc).
Original change's description:
> Forward fix for BUILD file error
>
> Fixes a problem with a downstream importer.
>
> No-Try: True
> Bug: none
> Change-Id: Ia2525087755add1df8e96990655f1ec6ec4bd5b6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207165
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#33251}
TBR=mbonadei@webrtc.org ,hta@webrtc.org
Change-Id: I25ba744a1e056dd5a1845da3835d59e5c6dbfd36
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207282
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33253}
2021-02-13 10:17:19 +00:00
8eea117dea
Make PostRuntimeSetting pure virtual
...
Bug: b/177830919
Change-Id: I92e30e9b65c8f851444268f0824a676044504814
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206640
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Commit-Queue: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33252}
2021-02-12 22:49:43 +00:00
df8baf6a8e
Forward fix for BUILD file error
...
Fixes a problem with a downstream importer.
No-Try: True
Bug: none
Change-Id: Ia2525087755add1df8e96990655f1ec6ec4bd5b6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207165
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33251}
2021-02-12 17:22:33 +00:00
76d30a507d
Improve documentation of PendingTaskSafety
...
Bug: none
Change-Id: Iff9bf0e1965663581ba34f45f71b9cf23032af7a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207164
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33250}
2021-02-12 15:28:20 +00:00
bc1cdef4e8
EncoderInfoSettings: Add common string which applies to all encoders.
...
Change "-LibvpxVp9Encoder-" to "-VP9-" for consistency.
Bug: none
Change-Id: I7a73759db00e92286fe9a4bbed8512baf91decdb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206982
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33249}
2021-02-12 14:49:28 +00:00
27bc6e2246
Reverting to previous behavior due to a downstream test expectation.
...
This reverts the change in behavior for setRemoteDescription,
introduced here:
https://webrtc-review.googlesource.com/c/src/+/206063
And disables the associated test.
Bug: webrtc:9987
Change-Id: I39a5664032a967a0a9cd336fa585d4d3880c88c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207162
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33248}
2021-02-12 13:35:03 +00:00
1ba1fc9598
Remove old sequence checker header
...
Bug: webrtc:12419
Change-Id: I5f43e33ab0c23e79d7fcc8e2f8081dd4b5f350e8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206807
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33247}
2021-02-12 11:53:16 +00:00
e71b55fb27
build: merge media_constants and engine_constants
...
no functional changes
BUG=None
Change-Id: I994cf7de6fdbf5505ed3359e08700cac5ea9fe3f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/202022
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33246}
2021-02-12 11:20:45 +00:00
f109193fba
Remove VideoLayerFrameId::spatial_layer, use EncodedImage::SpatialIndex instead.
...
Next step is to replace VideoLayerFrameId with int64_t.
Bug: webrtc:12206
Change-Id: I414f491e383acf7f8efd97f7bf93dc55a5194fbf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206804
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33245}
2021-02-12 11:16:23 +00:00
cae4656d4a
Split peer_connection_integrationtest.cc into pieces
...
This creates two integration tests: One for datachannel, the other
for every test that is not datachannel.
It separates out the common framework to a new file in pc/test.
Also applies some fixes to IWYU.
Bug: None
Change-Id: I919def1c360ffce205c20bec2d864aad9b179c3a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207060
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33244}
2021-02-12 10:06:43 +00:00
aee2c6a532
In android video encoder wrapper fill codec-agnostic frame dependencies
...
These structures are needed to populate dependency descritpor rtp header
extension.
Bug: webrtc:10342
Change-Id: If6bb533544ae3aa718d0e8506bb6d1fa43df345f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206985
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33243}
2021-02-12 09:51:56 +00:00
590b1bad08
Add lock annotations to DxgiDuplicatorController
...
Bug: webrtc:11567
Change-Id: I34b9138cc15cd534059dd64bb990d41174eeef21
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206471
Reviewed-by: Markus Handell <handellm@webrtc.org >
Reviewed-by: Jamie Walch <jamiewalch@chromium.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33242}
2021-02-12 07:51:19 +00:00
8f8bd4da82
Roll chromium_revision 2f598fb8a8..b5988d40c8 (853215:853388)
...
Change log: 2f598fb8a8..b5988d40c8
Full diff: 2f598fb8a8..b5988d40c8
Changed dependencies
* src/base: e7bab59f02..8914659f46
* src/build: db1010d4b4..d1fa78cb85
* src/ios: 42ecc836ad..ba0d254e6d
* src/testing: 71976942f3..f71ab6246f
* src/third_party: adba398171..4583d1a51a
* src/third_party/androidx: zXeCxmhPbNT770qhdvfCQxK-TvzbsmCTISBgo4ahJXUC..hF9dL0GeFAftrouf8BezMHHVnB3KIDD1V1YgH3_c6IwC
* src/third_party/depot_tools: 6551036772..398091b193
* src/third_party/perfetto: c0182a5003..d5c3eb6a5f
* src/tools: 32e0406f56..4858c5936c
DEPS diff: 2f598fb8a8..b5988d40c8
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I85b43600e12edea346d1378e93ae34fbfe6a5976
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207101
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33241}
2021-02-12 05:04:25 +00:00
80d661cb7a
Use monotonic clock for legacy stats caching.
...
Fixes a bug where, if the wall clock goes backwards (from changing time
zone, daylight savings, manual change by user, etc.), the stats
collector stops updating stats.
Bug: webrtc:12439
Change-Id: Ie45f484110d43444aea6d6b1a218b05d0f8b6a0c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206622
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Taylor <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33240}
2021-02-11 21:45:30 +00:00
95c8f0da59
Roll chromium_revision 11a94c709b..2f598fb8a8 (853086:853215)
...
Change log: 11a94c709b..2f598fb8a8
Full diff: 11a94c709b..2f598fb8a8
Changed dependencies
* src/base: 685647d389..e7bab59f02
* src/build: 2697ef39ae..db1010d4b4
* src/ios: b870bdc4fe..42ecc836ad
* src/testing: c9a2320aee..71976942f3
* src/third_party: 249440e09c..adba398171
* src/third_party/androidx: QK9_suyla0iK8oMKDoZtiMGi1EY1hODwvOSLcJ0LSUUC..zXeCxmhPbNT770qhdvfCQxK-TvzbsmCTISBgo4ahJXUC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1549e0ea92..d2aa56920c
* src/third_party/freetype/src: c8dede7b1c..54c5ad5c92
* src/tools: 7d0eb2c46f..32e0406f56
DEPS diff: 11a94c709b..2f598fb8a8
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I4a45248949389ad421ee2e1b62b22129dd8c7adc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207020
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33239}
2021-02-11 20:55:29 +00:00
5a585952da
Update AGC2 tuning
...
Bug: webrtc:7494
Change-Id: Ifcc5b6c846476ce7d6862fba2cb53e426b5855dc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206800
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33238}
2021-02-11 18:14:34 +00:00
45d2234a5c
Test and fix unscalable video structure.
...
Bug: webrtc:11999
Change-Id: I94e3a97ebadbf92ca741d750f67fbea5cbd2b66f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206984
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33237}
2021-02-11 17:23:56 +00:00
dea374a467
Deliver packet info to source listeners when audio playout is disabled.
...
Normally, packet/frame info is delivered to AudioReceiveStream's
source_tracker_ when an audio frame is pulled out of the stream (as a
side-effect of GetAudioFrameWithInfo). When playout is muted, though,
packets are thrown away in ChannelReceive::OnReceivedPayloadData, so
AudioRtpReceiver stops seeing updates to its RtpSources and any related
information (e.g. CSRCs and associated timestamps, levels).
Skipping the playout path here has a downside of being misaligned with
whatever playout delay would normally be, but it allows clients that
want to consume RtpSource information to be able to do so while playout
is muted.
Bug: None
Change-Id: Id00566b645de4196c2341611cd9e8b94b35aa157
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/203500
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Reviewed-by: Noah Richards <noahric@chromium.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Ranveer Aggarwal <ranvr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33236}
2021-02-11 13:48:49 +00:00
0710b401b1
Migrate perf tests result writing API to absl::string_view
...
Bug: b/179986638
Change-Id: Ida160c1c596e77545dc991f5b9198263234181f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206981
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33235}
2021-02-11 12:56:12 +00:00
7666d89190
Roll chromium_revision 897c000738..11a94c709b (852985:853086)
...
Change log: 897c000738..11a94c709b
Full diff: 897c000738..11a94c709b
Changed dependencies
* src/base: 02773b96b2..685647d389
* src/build: 5088ad39f5..2697ef39ae
* src/ios: 64f3085aac..b870bdc4fe
* src/testing: 75bb06ffcb..c9a2320aee
* src/third_party: 78bc5bf388..249440e09c
* src/third_party/androidx: CUNayWpb4JErvQkdCk8cchP0sY4xV9vBv35PWhtW4bcC..QK9_suyla0iK8oMKDoZtiMGi1EY1hODwvOSLcJ0LSUUC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b013189435..1549e0ea92
* src/third_party/depot_tools: b0763b2c57..6551036772
* src/third_party/freetype/src: 2c40559609..c8dede7b1c
* src/tools: 2e6da6d116..7d0eb2c46f
DEPS diff: 897c000738..11a94c709b
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I32df23ac5aad6ec7e04a2057ed4529096374588e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206963
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33234}
2021-02-11 12:47:53 +00:00