Commit Graph

34346 Commits

Author SHA1 Message Date
7d7afc6468 dcsctp: Fix accidental re-use of variable
This was caused by change 231229 and was later caught when reviewing the
code. The rtt variable was accidentally re-used for another purpose, and
then assumed to still be used to represent the rtt.

There have been no issues found with this re-use, but it was wrong.

Bug: webrtc:12614
Change-Id: If1a180315cf833e293f78c54c3c3b29394a19a20
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232610
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35064}
2021-09-22 13:27:37 +00:00
9def99487e Delete BasicPacketSocketFactory constructor with thread argument
In callers where it's non-trivial to explicitly pass the right
SocketFactory, pull the call to rtc::Thread::socketserver() into the
caller, with a TODO comment.

Bug: webrtc:13145
Change-Id: I029d3adca385d822180e089f016c3778e0d4fd0c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231227
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35063}
2021-09-22 12:15:06 +00:00
070dbe13d1 Roll chromium_revision a9952c3d0b..39bb5dc28c (923654:923768)
Change log: a9952c3d0b..39bb5dc28c
Full diff: a9952c3d0b..39bb5dc28c

Changed dependencies
* src/build: e6cc67acf1..66bad00683
* src/ios: 44f36b544f..5df67de82e
* src/testing: f0b4c80438..f34057a8e4
* src/third_party: 509acb7e61..a8bb9c2622
* src/third_party/depot_tools: 392672524f..eff810e93d
* src/tools: 80f6241c34..6ce89b222b
DEPS diff: a9952c3d0b..39bb5dc28c/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I137f64f46ace12ded88814c2c9a80fbd54a09e53
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232700
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35062}
2021-09-22 08:48:37 +00:00
f72c06419f sctp: dcsctp: Manage lifecycle explicitly
Prior to this commit, the SCTP association could terminate due to too
many retransmission attempts when there is a long duration of packet
loss. The RTCPeerConnection wouldn't terminate, and when the network
later recovers (possibly using a different ICE candidate), it would be a
RTCPeerConnection with media, but without DataChannels.

This commit will make the dcSCTP library never abort by itself when
there are too many retransmissions. It will also put a cap on the retry
duration so that it will do a retry every three seconds (or lower).

Bug: webrtc:13129
Change-Id: I08162ea20d6a60aa0eae2717966d9a2ddba8fc22
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232540
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35061}
2021-09-22 07:17:29 +00:00
7a9aa356d3 Update WebRTC code version (2021-09-22T04:04:23).
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com,mbonadei@webrtc.org

Bug: None
Change-Id: Id84559a2ae5ea5795368143432d66f3f9695f571
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232681
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35060}
2021-09-22 05:58:49 +00:00
c724fbaf1d Roll chromium_revision a6f6c26471..a9952c3d0b (923534:923654)
Change log: a6f6c26471..a9952c3d0b
Full diff: a6f6c26471..a9952c3d0b

Changed dependencies
* src/build: 0f30102466..e6cc67acf1
* src/ios: a3315d26ff..44f36b544f
* src/testing: c813a08086..f0b4c80438
* src/third_party: c186ba7183..509acb7e61
* src/third_party/androidx: YgWnxUif6qH20WBJzC3-BkcOdU0bKj8rK8Doh6F642sC..9NWqy0Mwybr2-UnSDAVpZ77TLsWo0E6-CKkEfwzylNYC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/eb1238e9b6..25814bb53d
* src/third_party/depot_tools: c70750b73e..392672524f
* src/tools: 977a6216c1..80f6241c34
DEPS diff: a6f6c26471..a9952c3d0b/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I30b749da853635e0c158ed536e2e40fd7a50eecb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232665
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35059}
2021-09-22 01:13:04 +00:00
f96bac9d93 Roll chromium_revision e682171528..a6f6c26471 (923422:923534)
Change log: e682171528..a6f6c26471
Full diff: e682171528..a6f6c26471

Changed dependencies
* src/base: 03b25e9941..63b2301926
* src/ios: e92a74ddbd..a3315d26ff
* src/testing: e4d8700715..c813a08086
* src/third_party: 665effa44a..c186ba7183
* src/third_party/android_sdk/public: yODElY4RdHopNEfpOnqjRcrpa6JMzbhYYqGD53-DjJwC..AuYa11pULKT8AI14_owabJrkZoRGuovL-nvwmiONlYEC
* src/third_party/androidx: H5UatMk-9sW2bGNyADlJGlpCPtfMgXteCSHjEHq1w9UC..YgWnxUif6qH20WBJzC3-BkcOdU0bKj8rK8Doh6F642sC
* src/third_party/depot_tools: 9a76798c9e..c70750b73e
* src/third_party/perfetto: 485b177f00..df2e9fecdf
* src/tools: c0b1ae8923..977a6216c1
DEPS diff: e682171528..a6f6c26471/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ib53c494b473d2eba03921091a6c074ce14034972
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232662
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35058}
2021-09-21 20:53:50 +00:00
2d0e82e4cf Roll chromium_revision 3416746b88..e682171528 (923281:923422)
Change log: 3416746b88..e682171528
Full diff: 3416746b88..e682171528

Changed dependencies
* src/base: 0edb16fd68..03b25e9941
* src/build: b4be3eb78f..0f30102466
* src/ios: d11c980c8a..e92a74ddbd
* src/testing: 2d497d93e4..e4d8700715
* src/third_party: b82e1dc3f4..665effa44a
* src/third_party/androidx: -p7HUEhWbHNpHzWMFxgf5JMct4Dp0DHUeY6Ybtni3IwC..H5UatMk-9sW2bGNyADlJGlpCPtfMgXteCSHjEHq1w9UC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8ec776f0d7..eb1238e9b6
* src/third_party/freetype/src: 71969d1edf..6190360967
* src/third_party/perfetto: e311098b41..485b177f00
* src/tools: b92dee658b..c0b1ae8923
DEPS diff: 3416746b88..e682171528/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I40bcc7e42770520826e25901a772353dc993f7e8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232640
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35057}
2021-09-21 16:54:08 +00:00
48f9525078 Delete BitBuffer
All BitBuffer usage was replaced with BitstreamReader

Bug: None
Change-Id: Ia91826cea2561679709c0c22767958de596a282c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232125
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35056}
2021-09-21 16:28:38 +00:00
b918230640 Move StrongAlias to rtc_base
It's useful for other parts of WebRTC and there is no real reason why
it should be located in net/dcsctp.

Bug: None
Change-Id: Iccaed4e943e21ddaea8603182d693114b2da9f6b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232606
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35055}
2021-09-21 15:17:26 +00:00
68dc02b32f rtp_rtcp: use webrtc::flat_map for remote_senders
This one is frequently accessed - Mainly by ::CreateReportBlocks and
is visible in performance profiles (although not very much).

By using webrtc::flat_map, better data cache locality is expected.

Bug: webrtc:12689
Change-Id: Ic2ebcad806788074b2b4cb244a25395a48df1852
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232541
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35054}
2021-09-21 13:20:16 +00:00
72435325c6 dcsctp: hand over RRSendQueue streams state
Bug: webrtc:13154
Change-Id: I560b59ad2f5bcd2deafc3a37e3af853108b572b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232605
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org>
Reviewed-by: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35053}
2021-09-21 12:59:46 +00:00
9d2b3cb595 dcsctp: enabled handover in test SendManyFragmentedMessagesWithLimitedRtx
Bug: webrtc:13154
Change-Id: I192d5093de9b7596208d44f4868b413602db473a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232543
Reviewed-by: Victor Boivie <boivie@webrtc.org>
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35052}
2021-09-21 11:55:43 +00:00
e7c77ecd32 Add rtc:SocketFactory as member of jni OwnedFactoryAndThreads
Bug: webrtc:13145
Change-Id: Iff1b59d291b1a36d474cf3fb6fafa4e9ff007aa0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232060
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35051}
2021-09-21 11:15:30 +00:00
f7a7698aaf Mark toI420 as Nullable
Bug: webrtc:12877
Change-Id: I1b52b46bc9208d20f1887bdc87497e4eb227ecaf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232330
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Fabian Bergmark <fabianbergmark@google.com>
Cr-Commit-Position: refs/heads/main@{#35050}
2021-09-21 10:05:09 +00:00
7b35b44b52 Zero initialize heap allocations in LibvpxVp9{Decoder,Encoder}
Bug: chromium:1251010
Change-Id: Iffefdc8bee3752f89b0201f56fd06a2253b53200
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232602
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35049}
2021-09-21 09:24:09 +00:00
50decc6bd0 Roll chromium_revision c4e2cd0641..3416746b88 (923181:923281)
Change log: c4e2cd0641..3416746b88
Full diff: c4e2cd0641..3416746b88

Changed dependencies
* src/build: 103712808f..b4be3eb78f
* src/ios: 0ff547a875..d11c980c8a
* src/testing: cb7a980fa7..2d497d93e4
* src/third_party: d4e588bc54..b82e1dc3f4
* src/third_party/androidx: jagpxzoq8SusfDjtewx558yIOnyvOSm2eGzxQc7-n7EC..-p7HUEhWbHNpHzWMFxgf5JMct4Dp0DHUeY6Ybtni3IwC
* src/third_party/depot_tools: c1fd44b01a..9a76798c9e
* src/tools: 3102a8e728..b92dee658b
DEPS diff: c4e2cd0641..3416746b88/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I0eb0ad7ddf80521ad7f4185024bd20a74045a6d5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232586
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35048}
2021-09-21 08:52:19 +00:00
6da016ff71 Delete unused listen-mode of AsyncStunTCPSocket
Small step towards using separate classes for TCP server sockets.
Added a new test-only class AsyncStunServerTCPSocket needed
for unit tests of AsyncStunTCPSocket.

Bug: webrtc:13065
Change-Id: I7d9713983d8f6b30aa3d3e7442bb34ea48b815eb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232324
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35047}
2021-09-21 08:01:15 +00:00
a37fa66463 Update WebRTC code version (2021-09-21T04:02:15).
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com,mbonadei@webrtc.org

Bug: None
Change-Id: I70cc13d8235696205e375cdc52869c2ceac3f078
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232583
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35046}
2021-09-21 05:22:29 +00:00
c9c10102f1 Roll chromium_revision 58be06fa61..c4e2cd0641 (923080:923181)
Change log: 58be06fa61..c4e2cd0641
Full diff: 58be06fa61..c4e2cd0641

Changed dependencies
* src/base: 272d549d08..0edb16fd68
* src/ios: 00ac1cbc1f..0ff547a875
* src/testing: 84c05d76bc..cb7a980fa7
* src/third_party: be0f31168b..d4e588bc54
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/fb6990454d..8ec776f0d7
* src/third_party/depot_tools: eb28118b7a..c1fd44b01a
* src/third_party/freetype/src: 5b626281f1..71969d1edf
* src/tools: 6a16edeb57..3102a8e728
DEPS diff: 58be06fa61..c4e2cd0641/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Icd91442607a7752c3b3cc18eb9c5bf6e4b1d6f96
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232582
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35045}
2021-09-21 02:56:49 +00:00
ba995a98a5 Roll chromium_revision 35a3026fcf..58be06fa61 (922957:923080)
Change log: 35a3026fcf..58be06fa61
Full diff: 35a3026fcf..58be06fa61

Changed dependencies
* src/base: c9776ba59e..272d549d08
* src/build: 6b775cc1b3..103712808f
* src/ios: 3526986c9b..00ac1cbc1f
* src/testing: b8f96c0110..84c05d76bc
* src/third_party: 27cc664ab2..be0f31168b
* src/third_party/android_sdk/public: ZT3JmI6GMG4YVcZ1OtECRVMOLLJAWAdPbi-OclubJLMC..yODElY4RdHopNEfpOnqjRcrpa6JMzbhYYqGD53-DjJwC
* src/third_party/android_sdk/public: qi_k82nm6j9nz4dQosOoqXew4_TFAy8rcGOHDLptx1sC..g7n_-r6yJd_SGRklujGB1wEt8iyr77FZTUJVS9w6O34C
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2c91d8f11c..fb6990454d
* src/third_party/depot_tools: cf9d64363b..eb28118b7a
* src/tools: 824e997513..6a16edeb57
DEPS diff: 35a3026fcf..58be06fa61/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I8ac39f6b87495f5022d185f8875f3a0a98088103
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232580
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35044}
2021-09-20 23:36:09 +00:00
9cd326c0cf Update missed link to chromium C++11 styleguide
Follow-up to https://webrtc-review.googlesource.com/c/src/+/232260:
there's a second link to the obsolete chromium-cpp.appspot.com in the
same file that was missed.

Also updates the link to be more precise: the new markdown file has
anchors on individual entries, not just the section headers.

R=danilchap@webrtc.org

Bug: chromium:1243839
Change-Id: I17918d155aacf3465a46fd674a598139a0870165
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232560
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35043}
2021-09-20 21:05:39 +00:00
1ce585953c Fix integer underflow in BitstreamReader::ConsumeBits
Unlike ReadBits, ConsumeBits doesn't limit number of bits it may advance,
and thus should work when that number is close to the integer limit

Bug: chromium:1250730
Change-Id: Ia7847869ef9d3fc16450d572c9e2be6e1aa36741
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232332
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35042}
2021-09-20 19:37:49 +00:00
b3b102cdb8 Roll chromium_revision d2004ccb64..35a3026fcf (922852:922957)
Change log: d2004ccb64..35a3026fcf
Full diff: d2004ccb64..35a3026fcf

Changed dependencies
* src/base: d632224756..c9776ba59e
* src/build: ae8cb5d4ef..6b775cc1b3
* src/ios: 582c6d5fd0..3526986c9b
* src/testing: fb01508eb9..b8f96c0110
* src/third_party: 07464bd1dd..27cc664ab2
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/bb0675d848..2c91d8f11c
* src/third_party/perfetto: 62ae508a04..e311098b41
* src/tools: edbfb2c705..824e997513
DEPS diff: d2004ccb64..35a3026fcf/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Icb1d98dfe3f90f063b5ce67377b6d679a3a3622d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232520
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35041}
2021-09-20 18:31:12 +00:00
ef4d0b6c7a rename use_x11 to ozone_platform_x11
Ozone is default now in Chromium and non-Ozone/X11 (aka use_x11) is
deprecated. During the transition period use_x11 == ozone_platform_x11.

Bug: chromium:1096425
Change-Id: Ie3643360ec6607796533054bdedf8e2bb8e7e749
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231650
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35040}
2021-09-20 15:13:55 +00:00
afc237751a Allow CopyOnWriteBuffer to accept vector-like types.
Bug: none
Change-Id: I03ee91be151e10d6b0385b462158ecd0bd9ad4ed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232129
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35039}
2021-09-20 14:02:05 +00:00
bc7666be51 use_lld=false for xcode bot.
lld requires llvm-ar which is not present in the xcode toolchain.

Bug: b/200179635
Change-Id: I3fb23d2ba9e03d9cc6f595f0c5d1ed410afae9f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232328
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35038}
2021-09-20 13:29:48 +00:00
d92f8a86b3 dcsctp: move HandoverReadinessStatus::ToString definition to build target public:socket
This allows build targets that need only HandoverReadinessStatus
to depend only on public:socket, and not on socket:dcsctp_socket.

Bug: webrtc:13154
Change-Id: I29f41910cdb5baed96b57fd7284b96fc50a56ba4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232331
Reviewed-by: Victor Boivie <boivie@webrtc.org>
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35037}
2021-09-20 12:25:15 +00:00
057f90b7cb Fix integer overflow in h264 pps parser
Bug: chromium:1250730
Change-Id: Idda8e92262af7c3190698e1fb5ba001f6de55c47
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232327
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35036}
2021-09-20 11:28:36 +00:00
3852698ad9 dcsctp: support handover state serialization testing
dcSCTP library users can set their custom
g_handover_state_transformer_for_test that can serialize and
deserialize the state. All dcSCTP handover tests call
g_handover_state_transformer_for_test. If some part of the state is
serialized incorrectly or is forgotten, high chance that it will
fail the tests.

Bug: webrtc:13154
Change-Id: I251a099be04dda7611e9df868d36e3a76dc7d1e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232325
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35035}
2021-09-20 10:08:58 +00:00
ffb6d7812d Roll chromium_revision e355563bce..d2004ccb64 (922741:922852)
Change log: e355563bce..d2004ccb64
Full diff: e355563bce..d2004ccb64

Changed dependencies
* src/build: 67d9786cde..ae8cb5d4ef
* src/ios: fba9465d9b..582c6d5fd0
* src/testing: 7c2699b123..fb01508eb9
* src/third_party: 3082261eb3..07464bd1dd
* src/third_party/androidx: HoRt7lhvtWPJ6Dq388HPGC34ymlvXafBdnrSvb_XaIgC..jagpxzoq8SusfDjtewx558yIOnyvOSm2eGzxQc7-n7EC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7d0db1cb9e..bb0675d848
* src/third_party/depot_tools: 4e0cca2a31..cf9d64363b
* src/third_party/ffmpeg: 1f33e234be..731bf2abeb
* src/tools: 7cab6725ec..edbfb2c705
DEPS diff: e355563bce..d2004ccb64/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I4bf5e47dc5d40e8f67f1bfac22581517a42edef3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232460
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35034}
2021-09-20 08:28:18 +00:00
fe4ff30ae1 Update WebRTC code version (2021-09-19T04:02:28).
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com,mbonadei@webrtc.org

Bug: None
Change-Id: I77a3892d6deae079a25286ca5901175d3b8c7be0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232408
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35033}
2021-09-19 05:46:52 +00:00
abd2ed0911 Update WebRTC code version (2021-09-18T04:02:37).
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com,mbonadei@webrtc.org

Bug: None
Change-Id: I3a7e3b5137b0b29202295dba11e0d6437150ab55
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232364
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35032}
2021-09-18 05:41:19 +00:00
3bb3e4ecb3 Roll chromium_revision 991c09e243..e355563bce (922552:922741)
Change log: 991c09e243..e355563bce
Full diff: 991c09e243..e355563bce

Changed dependencies
* src/base: 74c3937fa4..d632224756
* src/build: 11ee2b49e0..67d9786cde
* src/ios: 9ddd8a846f..fba9465d9b
* src/testing: 4a78839643..7c2699b123
* src/third_party: 2425c9743f..3082261eb3
* src/third_party/androidx: VfpXiVfbJgXKD03viqELXHcjvBvx22iMSUlxHnRT-vIC..HoRt7lhvtWPJ6Dq388HPGC34ymlvXafBdnrSvb_XaIgC
* src/third_party/breakpad/breakpad: 7933ec0a69..1147c2fcf0
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/57c353ca10..7d0db1cb9e
* src/third_party/depot_tools: 5a0f43aebe..4e0cca2a31
* src/third_party/perfetto: a9118d7690..62ae508a04
* src/tools: 3cbcc67ae2..7cab6725ec
DEPS diff: 991c09e243..e355563bce/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I3b6d63c1ea42f51f9dacb06d13546ab2b34b3970
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232362
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35031}
2021-09-18 01:03:25 +00:00
edce7b3a24 Roll chromium_revision a098e1265b..991c09e243 (921682:922552)
Change log: a098e1265b..991c09e243
Full diff: a098e1265b..991c09e243

Changed dependencies
* src/base: ecf6ff89bf..74c3937fa4
* src/build: fabb3638a7..11ee2b49e0
* src/buildtools/third_party/libc++abi/trunk: a5b6419452..c883cb129d
* src/buildtools/third_party/libunwind/trunk: 44ea7aba6a..a7e4ce09ec
* src/ios: e8d5d843cf..9ddd8a846f
* src/testing: 7adcb6a6bf..4a78839643
* src/third_party: 21d7875bec..2425c9743f
* src/third_party/androidx: QRXHawrfyCC8nr_u3VCPoilYsqHO01yv1EiduoQUPcgC..VfpXiVfbJgXKD03viqELXHcjvBvx22iMSUlxHnRT-vIC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6b072fac88..57c353ca10
* src/third_party/depot_tools: 9c67b23020..5a0f43aebe
* src/third_party/perfetto: de98afcd4a..a9118d7690
* src/third_party/r8: j4P6kTwiJeMkYRbaOqRCB-ZrYyISP0NrcyNNAd8MRM0C..ntKr-aGawyw4goIV50HidiUHTHey-mwhwgLiD3Th8jUC
* src/third_party/turbine: Om6yIEXgJxuqghErK29h9RcMH6VaymMbxwScwXmcN6EC..n2quuVAecebwosy5EPRjDGSO5EQU94aFRBg_EdrYtpsC
* src/tools: a27c09f45b..3cbcc67ae2
* src/tools/luci-go: git_revision:dc21267f89df3981e809fe9566591d6916ae758b..git_revision:028cd41e0f4b2bec99d94c780caf2f978e09b182
* src/tools/luci-go: git_revision:dc21267f89df3981e809fe9566591d6916ae758b..git_revision:028cd41e0f4b2bec99d94c780caf2f978e09b182
* src/tools/luci-go: git_revision:dc21267f89df3981e809fe9566591d6916ae758b..git_revision:028cd41e0f4b2bec99d94c780caf2f978e09b182
DEPS diff: a098e1265b..991c09e243/DEPS

Clang version changed llvmorg-14-init-3710-gd11a0c5d:llvmorg-14-init-3940-gafc45ff0
Details: a098e1265b..991c09e243/tools/clang/scripts/update.py

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I365777bb670246c421a75662740808f1dee54fb6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232344
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35030}
2021-09-17 17:23:03 +00:00
4397281f38 dcsctp: implement socket handover in the DcSctpSocket class and expose the functionality in the API
Bug: webrtc:13154
Change-Id: Idf4f4028c8e65943cb6b41fab0baef1b3584205d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232126
Reviewed-by: Victor Boivie <boivie@webrtc.org>
Commit-Queue: Sergey Sukhanov <sergeysu@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35029}
2021-09-17 15:19:01 +00:00
4893dbe7f1 Update link to Chromium Modern C++ style guide
Bug: chromium:1243839
Change-Id: I4a914eec78c919347a65be4d5b5fc6447408bc39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232260
Commit-Queue: Joe Mason <joenotcharles@google.com>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35028}
2021-09-17 14:06:01 +00:00
62b340545f Default the safetyped calculation of packet interarrival times.
This defaults the calculation landed in cl 196502. The less readable legacy calculation method will be deleted in a future CL.


Bug: none
Change-Id: Ida02a5208e354835b964c69355ad1e9d5bba18aa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231956
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35027}
2021-09-17 13:58:55 +00:00
1b200b93d5 APM: remove webrtc::Config
Remove the deprecated way of configuring APM.

Bug: webrtc:5298
Change-Id: Idcedf1fe4a121adfcf2881003579cd58ac42a2b9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232302
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35026}
2021-09-17 11:21:32 +00:00
be1b8989d1 ExperimentalNs removed + APM not depending anymore on webrtc::Config
Thanks to the elimination of `ExperimentalNs`, there is no need anymore
to pass `webrtc::Config` to build APM.
Hence, `AudioProcessingBuilder::Create(const webrtc::Config&)` is also
removed.

Bug: webrtc:5298
Change-Id: I0a3482376a7753434486fe564681f7b9f83939c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232128
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35025}
2021-09-17 10:53:43 +00:00
25b5e08094 dcsctp: implement congestion control errata
When re-reading through the errata for RFC4960 in RFC8540, it was found
that two erratas were not applied to dcSCTP:

https://datatracker.ietf.org/doc/html/rfc8540#section-3.11
https://datatracker.ietf.org/doc/html/rfc8540#section-3.12

They are now applied. Re-running throughput tests show no difference.

Bug: webrtc:12943
Change-Id: I9d73d0d257eab8442954924dc414d8efa2c41e8b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232221
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35024}
2021-09-17 10:49:13 +00:00
d67e75a45d Update m1 arm64 audio bitexactness tests hashes. Followup.
Update hashes that weren't updated at
https://webrtc-review.googlesource.com/c/src/+/232220

Bug: b/199885455
Change-Id: I4f9327fa48a9d5656f57c5dcbc6438f20f919acd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232320
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35023}
2021-09-17 10:19:01 +00:00
4420380f38 Use string_view as input type for internal string utilities
Bug: None
Change-Id: I2bfdaf4e7fac109842cc9fde8dfa28ab4961c3fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232127
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35022}
2021-09-17 09:11:21 +00:00
d14f98f635 Update m1 arm64 audio bitexactness tests hashes
Follow up for https://webrtc-review.googlesource.com/c/src/+/232061/5. Updated mac M1 tests that was missed because they are not part of CQ

Bug: b/199885455
Change-Id: I77618ac2869ba601f322857f4391b63220d20252
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232220
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35021}
2021-09-17 08:59:05 +00:00
5068820dd0 Rename "TcpFairness" in LossBasedBweV2 to "InstantUpperBound"
The new name more accurately reflects the intent of the actual implementation.


Bug: none
Change-Id: I3d2aeb561104165f9f9879854a4a210730e02ff5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232130
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org>
Reviewed-by: Fanny Linderborg <linderborg@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35020}
2021-09-17 07:28:41 +00:00
e28c38d7fb Update WebRTC code version (2021-09-17T04:04:12).
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com,mbonadei@webrtc.org

Bug: None
Change-Id: Iadab8056f9b14796e86451b672e1753790d8f125
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232282
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#35019}
2021-09-17 05:57:39 +00:00
0a54e7a101 Verify that locks are handled correctly on RTCAudioSession
This CL is for the same behavior as before [1], to emit the NSError
when an application is not using the RTCAudioSession lock correctly.

[1] https://webrtc-review.googlesource.com/c/src/+/207432

Bug: webrtc:13091
Change-Id: I031b0e963d33c92ce1af7a306edfa6be005e043d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/229461
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Byoungchan Lee <daniel.l@hpcnt.com>
Cr-Commit-Position: refs/heads/main@{#35018}
2021-09-17 01:41:42 +00:00
702f2a44ba [ScreenCapturerX11] Fix update-region for monitors with offsets.
This CL ensures that each DesktopFrame's updated-region is expressed in
the frame's own coordinates, where the top-left is always (0, 0).
For example, DesktopFrame::GetFrameDataAtPos() and its callers use
this coordinate system.

Previously, whenever a RANDR monitor with a non-zero offset was
selected, ScreenCapturerX11 would hit some DCHECKs when trying to
copy pixels from previous frames, or when capturing new pixels into
them from XDAMAGE regions.

Bug: None
Change-Id: I7b2e8d0449359ee7b263ad60af193e2bf89aa1f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232085
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#35017}
2021-09-16 17:12:26 +00:00
80e96de5ba dcsctp: Add more consistency checks
When there is no outstanding data, then next TSN to allocate should
always be one more than what the client has last ACKed.

Bug: None
Change-Id: Ieb8b5b23912d77d96fe3749fb53fd53652d97066
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232002
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35016}
2021-09-16 13:31:51 +00:00
ff7e1bad1f APM config: remove ExperimentalAgc
Bug: webrtc:5298,webrtc:7494
Change-Id: Ic9bcb702603ec7900fbe9ae38ab49dff8fe99318
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219463
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35015}
2021-09-16 13:28:51 +00:00