2af5dcbe9e
Reland "Refactor FrameDecryptorInterface::Decrypt to use new API."
...
This reverts commit 7dd83e2bf73a7f1746c5ee976939bf52e19fa8be.
Reason for revert: This wasn't the cause of the break.
Original change's description:
> Revert "Refactor FrameDecryptorInterface::Decrypt to use new API."
>
> This reverts commit 642aa81f7d5cc55d5b99e2abc51327eed9d40195.
>
> Reason for revert: Speculative revert. The chromium roll is failing:
> https://ci.chromium.org/p/chromium/builders/try/linux-rel/64388
> But I can't figure out exactly what is failing, this looks suspecious.
>
> Original change's description:
> > Refactor FrameDecryptorInterface::Decrypt to use new API.
> >
> > This change refactors the FrameDecryptorInterface to use the new API. The new
> > API surface simply moves bytes_written to the return type and implements a
> > simple Status type.
> >
> > Bug: webrtc:10512
> > Change-Id: I622c5d344d58e618853c94c2f691cf7c8fb73a36
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131460
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
> > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> > Reviewed-by: Stefan Holmer <stefan@webrtc.org >
> > Commit-Queue: Benjamin Wright <benwright@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#27497}
>
> TBR=brandtr@webrtc.org ,steveanton@webrtc.org ,solenberg@webrtc.org ,ossu@webrtc.org ,stefan@webrtc.org ,benwright@webrtc.org
>
> Change-Id: Ia9ec70263762c34671af13f0d519e636eb8473cd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10512
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132013
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Commit-Queue: Henrik Boström <hbos@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27510}
TBR=brandtr@webrtc.org ,steveanton@webrtc.org ,solenberg@webrtc.org ,hbos@webrtc.org ,ossu@webrtc.org ,stefan@webrtc.org ,benwright@webrtc.org
Change-Id: I8e4b7965cf1d1a1554c3b46e6245f5ad0d2dcbb4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10512
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131982
Reviewed-by: Benjamin Wright <benwright@webrtc.org >
Commit-Queue: Benjamin Wright <benwright@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27529}
2019-04-09 20:08:56 +00:00
7dd83e2bf7
Revert "Refactor FrameDecryptorInterface::Decrypt to use new API."
...
This reverts commit 642aa81f7d5cc55d5b99e2abc51327eed9d40195.
Reason for revert: Speculative revert. The chromium roll is failing:
https://ci.chromium.org/p/chromium/builders/try/linux-rel/64388
But I can't figure out exactly what is failing, this looks suspecious.
Original change's description:
> Refactor FrameDecryptorInterface::Decrypt to use new API.
>
> This change refactors the FrameDecryptorInterface to use the new API. The new
> API surface simply moves bytes_written to the return type and implements a
> simple Status type.
>
> Bug: webrtc:10512
> Change-Id: I622c5d344d58e618853c94c2f691cf7c8fb73a36
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131460
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
> Reviewed-by: Stefan Holmer <stefan@webrtc.org >
> Commit-Queue: Benjamin Wright <benwright@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27497}
TBR=brandtr@webrtc.org ,steveanton@webrtc.org ,solenberg@webrtc.org ,ossu@webrtc.org ,stefan@webrtc.org ,benwright@webrtc.org
Change-Id: Ia9ec70263762c34671af13f0d519e636eb8473cd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10512
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132013
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27510}
2019-04-09 10:36:48 +00:00
642aa81f7d
Refactor FrameDecryptorInterface::Decrypt to use new API.
...
This change refactors the FrameDecryptorInterface to use the new API. The new
API surface simply moves bytes_written to the return type and implements a
simple Status type.
Bug: webrtc:10512
Change-Id: I622c5d344d58e618853c94c2f691cf7c8fb73a36
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131460
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Benjamin Wright <benwright@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27497}
2019-04-08 20:45:09 +00:00
d1c6085cb3
Added FrameDecryptorInterface::Result constructor and IsOk() member function.
...
Bug: webrtc:10512
Change-Id: I48bdaad57739382b5c1040d94f4e3657e2054e4b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131364
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Benjamin Wright <benwright@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27475}
2019-04-08 07:04:07 +00:00
72e977135c
Add Result FrameDecryptorInterface::Decrypt
...
This change adds FrameDecryptorInterface::Result to the FrameDecryptorInterface
API. Result contains a Status and bytes_written. This removes requiring out
parameters from the API and provides a simpler status return code for the
function. This is in response to comments suggested here:
https://webrtc-review.googlesource.com/c/src/+/131358
int FrameDecryptorInterface::Decrypt() will be removed in a follow up CL.
Bug: webrtc:10512
Change-Id: I47f19f154d1d8430acd6e4a6f433ab24c455fd51
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131362
Commit-Queue: Benjamin Wright <benwright@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27470}
2019-04-05 21:07:16 +00:00
10542f21c8
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
...
Mechanically generated by running this command:
tools_webrtc/do-renames.sh update all-renames.txt && git cl format
Then manually updating:
tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833
Reviewed-on: https://webrtc-review.googlesource.com/c/115653
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 17:11:39 +00:00
1c05765831
(3) Rename files to snake_case: move the files
...
Mechanically generated with this command:
tools_webrtc/do-rename.sh move all-renames.txt
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I8b05b6eab9b9d18b29c2199bbea239e9add1e690
Reviewed-on: https://webrtc-review.googlesource.com/c/115481
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26225}
2019-01-11 17:05:20 +00:00
