6baec0351a
Port::GetStunMessage: Write to scoped_ptr instead of raw pointer
...
This is a good idea in general, because it makes ownership clearer,
but will also be very convenient when scoped_ptr is gone, since
unique_ptr doesn't have an .accept() method.
BUG=webrtc:5520
Review URL: https://codereview.webrtc.org/1800753003
Cr-Commit-Position: refs/heads/master@{#12002}
2016-03-15 18:09:59 +00:00
0540242452
Add more conditions for CPU detection in denoiser filter.
...
Add WEBRTC_HAS_NEON and __SSE2__, otherwise, CPU detection fails in some cases.
Review URL: https://codereview.webrtc.org/1784323005
Cr-Commit-Position: refs/heads/master@{#12001}
2016-03-15 17:57:31 +00:00
88dec83778
Fixing flaky "TestExpireTime" test.
...
It failed any time the clock ticked in between getting "now" and calling
Generate.
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1800833002 .
Cr-Commit-Position: refs/heads/master@{#12000}
2016-03-15 16:58:04 +00:00
7021b92525
introduced rtcp::CommonHeader class
...
this class replace and extend RTCPUtility::RtcpCommonHeader structure and RTCPUtility::RtcpParseCommonHeader function.
In addition to header fields, payload pointer is stored because rtcp header without payload is rarely useful.
Sample usage can be checked in 'RTCP Parser sketched' CL: https://codereview.webrtc.org/1555683002/
BUG=webrtc:5260
R=asapersson@webrtc.org , sprang@webrtc.org
Review URL: https://codereview.webrtc.org/1575413002 .
Cr-Commit-Position: refs/heads/master@{#11999}
2016-03-15 16:39:45 +00:00
b58a158fce
Removed the AudioProcessing dependency in EchoCancellerImpl.
...
This CL removes the dependency of AudioProcessing in
EchoCancellerImpl. It is breaking the public APM API by
having a different error code behavior so please review it
carefully. I made a comment about the API breaking change
in the code section of this CL.
BUG=webrtc:5337
Review URL: https://codereview.webrtc.org/1770823002
Cr-Commit-Position: refs/heads/master@{#11998}
2016-03-15 16:34:28 +00:00
8e3949ce24
Roll chromium_revision 1a84b14..e1a2958 (381152:381201)
...
Change log: 1a84b14..e1a2958
Full diff: 1a84b14..e1a2958
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1802913002
Cr-Commit-Position: refs/heads/master@{#11997}
2016-03-15 12:36:53 +00:00
80c2cd973d
Android: Add more info for createPbufferSurface() exceptions
...
This CL adds the width and height to the createPbufferSurface exception
message. Also, when a Callable.call() fails in
ThreadUtils.invokeUninterruptibly() we rethrow a new exception, but that
excludes the callstack from Callable.call(). This CL adds the callstack
from Callable.call() to make debugging easier.
BUG=b/27581640,b/27516991
Review URL: https://codereview.webrtc.org/1780183005
Cr-Commit-Position: refs/heads/master@{#11996}
2016-03-15 11:43:16 +00:00
253534d1bd
Removed the dependency on AudioProcessingImpl in EchoControlMobileImpl
...
BUG=webrtc:5351
Review URL: https://codereview.webrtc.org/1803433003
Cr-Commit-Position: refs/heads/master@{#11995}
2016-03-15 11:32:37 +00:00
b8fbb54291
Removed the dependency on AudioProcessingImpl in GainControlImpl
...
BUG=webrtc:5353
Review URL: https://codereview.webrtc.org/1801003002
Cr-Commit-Position: refs/heads/master@{#11994}
2016-03-15 09:28:12 +00:00
f8cdd184d5
Add histogram stats for AV sync stream offset:
...
"WebRTC.Video.AVSyncOffsetInMs"
The absolute value of the sync offset between a rendered video frame and the latest played audio frame is measured per video frame. The average offset per received video stream is recorded when a stream is removed.
Updated sync tests in call_perf_tests.cc to use this implementation.
BUG=webrtc:5493
Review URL: https://codereview.webrtc.org/1756193005
Cr-Commit-Position: refs/heads/master@{#11993}
2016-03-15 08:00:54 +00:00
a1cf366ea9
Handle iOS devices with no rear-facing camera
...
Devices exist (specifically the 16GB 5th generation iPod Touch) that do not have
a rear-facing camera.
This CL:
- Adjusts RTCAVFoundationVideoCapturerInternal so initialization doesn't fail
because a rear-facing camera doesn't exist, but still logs a warning
- Provides a check for whether or not a rear-facing camera can be used (useful
for toggling UI elements)
- Turns an attempt to switch to the rear-facing camera into a no-op with a
warning.
BUG=
Review URL: https://codereview.webrtc.org/1416303003
Cr-Commit-Position: refs/heads/master@{#11992}
2016-03-15 03:55:25 +00:00
e5d5e51a82
Roll chromium_revision 390847b..1a84b14 (381002:381152)
...
Change log: 390847b..1a84b14
Full diff: 390847b..1a84b14
Changed dependencies:
* src/third_party/ffmpeg: 60fc535..beef685
DEPS diff: 390847b..1a84b14 /DEPS
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1800023002
Cr-Commit-Position: refs/heads/master@{#11991}
2016-03-15 03:10:33 +00:00
e50872be13
Remove unused method OutputMixer::PlayDtmfTone() and infrastructure.
...
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1796183002
Cr-Commit-Position: refs/heads/master@{#11990}
2016-03-14 22:32:53 +00:00
c4ec4a2e51
Add breaks in switch statement to fix AppRTCDemo crash
...
BUG=
Review URL: https://codereview.webrtc.org/1796953002
Cr-Commit-Position: refs/heads/master@{#11989}
2016-03-14 21:56:55 +00:00
a9635b83e0
Use the right mirroring state when switching cameras in AppRTCDemo.
...
BUG=
Review URL: https://codereview.webrtc.org/1799103002
Cr-Commit-Position: refs/heads/master@{#11988}
2016-03-14 20:43:41 +00:00
8bbbf2c3da
Rename RTCIceConnectionStateMax to RTCIceConnectionStateCount in Objective-C API.
...
BUG=
Review URL: https://codereview.webrtc.org/1799443006
Cr-Commit-Position: refs/heads/master@{#11987}
2016-03-14 20:15:52 +00:00
5ad6bf112a
Roll chromium_revision 6a56b54..390847b (380836:381002)
...
Change log: 6a56b54..390847b
Full diff: 6a56b54..390847b
No dependencies changed.
Clang version changed 262839:263324
Details: 6a56b54..390847b /tools/clang/scripts/update.py
TBR=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1802663002
Cr-Commit-Position: refs/heads/master@{#11986}
2016-03-14 20:08:26 +00:00
7fb69db670
Reland the CL to remove candidates when doing continual gathering
...
When doing candidate re-gathering in the same ICE generation, signal the remote side to remove its remote candidates.
Fixed the pure virtual method in jsep.h
BUG=
R=glaznev@webrtc.org , pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1788703003 .
Cr-Commit-Position: refs/heads/master@{#11985}
2016-03-14 18:59:34 +00:00
1122dc0d9b
Relanding https://codereview.webrtc.org/1715883002/ in pieces.
...
- Remove unused callback OnPlayTelephoneEvent from voe::Channel.
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1804523002
Cr-Commit-Position: refs/heads/master@{#11984}
2016-03-14 18:52:33 +00:00
fb647a67be
Initialize/configure video encoders asychronously.
...
Greatly speeds up setRemoteDescription() by moving encoder initialization
off the main worker thread, which is free to move onto gathering ICE
candidates and other tasks while InitEncode() is performed. It also
un-blocks PeerConnection GetStats() which is no longer blocked on
encoder initialization.
BUG=webrtc:5410
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1757313002 .
Cr-Commit-Position: refs/heads/master@{#11983}
2016-03-14 15:59:03 +00:00
4c83c05b48
Implemented more general version of ForwardDiff/RevereseDiff.
...
In this CL:
- Added more general version of ForwardDiff/RevereseDiff.
- Replaced macro for testing if type T is of unsiged int with
std::is_unsigned<T> instead.
- Changed from EXPECT_XXX to ASSERT_XXX in the unittests since a lot of
the test contains loops that would otherwise just spam the terminal.
BUG=
Review URL: https://codereview.webrtc.org/1786043004
Cr-Commit-Position: refs/heads/master@{#11982}
2016-03-14 15:43:40 +00:00
7a4116aa54
[rtp_rtcp] Append functionality moved from base RtcpPacket class to CompoundPacket
...
BUG=webrtc:5260
Review URL: https://codereview.webrtc.org/1582323005
Cr-Commit-Position: refs/heads/master@{#11981}
2016-03-14 15:19:31 +00:00
31642aa8f9
Relanding https://codereview.webrtc.org/1715883002/ in pieces.
...
- Change argument type to int for SetSendTelephoneEventPayloadType()
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1798903002
Cr-Commit-Position: refs/heads/master@{#11980}
2016-03-14 15:00:40 +00:00
d67717f9ad
Make opus memcheck suppression more generic
...
TBR=kjellander@webrtc.org
BUG=webrtc:5651
Review URL: https://codereview.webrtc.org/1799093002 .
Cr-Commit-Position: refs/heads/master@{#11979}
2016-03-14 15:00:12 +00:00
3b411701a5
Remove sparse macros (RTC_HISTOGRAM_*_SPARSE_*) that are no longer used.
...
BUG=webrtc:5283
Review URL: https://codereview.webrtc.org/1766313002
Cr-Commit-Position: refs/heads/master@{#11978}
2016-03-14 11:34:50 +00:00
0dc2316e8b
VideoCapturer: Update interface
...
This CL changes the interface by adding a SurfaceTextureHelper argument
to VideoCapturer.startCapture(). This removes the need for the
VideoCapturer to create the SurfaceTextureHelper itself. This also means
that it is no longer necessary to send an EGLContext to the
VideoCapturerAndroid.create() function.
The SurfaceTextureHelper is now created in AndroidVideoCapturerJni, and
the EGLContext is passed from PeerConnectionFactory in
nativeCreateVideoSource().
Another change in this CL is that the C++ SurfaceTextureHelper creates
the Java SurfaceTextureHelper instead of getting it passed as an
argument in the ctor.
BUG=webrtc:5519
Review URL: https://codereview.webrtc.org/1783793002
Cr-Commit-Position: refs/heads/master@{#11977}
2016-03-14 10:59:42 +00:00
b2a24ecf44
Relanding https://codereview.webrtc.org/1715883002/ in pieces.
...
- Clean up unused methods in voe::Channel following removal of VoEDtmf APIs.
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1785643006
Cr-Commit-Position: refs/heads/master@{#11976}
2016-03-14 10:25:17 +00:00
479a04cbb7
Suppress invalid read in Opus.
...
TBR=kjellander@webrtc.org
BUG=webrtc:5651
Review URL: https://codereview.webrtc.org/1803533002 .
Cr-Commit-Position: refs/heads/master@{#11975}
2016-03-14 09:23:08 +00:00
2875077458
Roll chromium_revision db8316d..6a56b54 (380688:380836): MSVS 2015 switch
...
This CL switches over to using Microsoft Visual Studio 2015 by default
on Windows. This large effort is described in more detail in
https://crbug.com/440500 .
Change log: db8316d..6a56b54
Full diff: db8316d..6a56b54
No dependencies changed.
No update to Clang.
TBR=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1792633002 .
Cr-Commit-Position: refs/heads/master@{#11974}
2016-03-14 05:49:17 +00:00
79858f8e9a
Update iOS AppRTCDemo to use the updated Objective-C API.
...
BUG=
Review URL: https://codereview.webrtc.org/1690313002
Cr-Commit-Position: refs/heads/master@{#11973}
2016-03-14 05:08:35 +00:00
9f987d3200
Refactor AVAudioSession intialization code.
...
BUG=
Review URL: https://codereview.webrtc.org/1778793005
Cr-Commit-Position: refs/heads/master@{#11972}
2016-03-13 04:06:34 +00:00
0ce3bf9cc4
Fix lock behavior on RTCAudioSession.
...
In addition:
- Introduces RTCAudioSessionTest
- iOS/Mac gtests now have an autoreleasepool
- Moves ScopedAutoreleasePool to rtc_base_approved
- Introduces route change button in AppRTCDemo
BUG=webrtc:5649
Review URL: https://codereview.webrtc.org/1782363002
Cr-Commit-Position: refs/heads/master@{#11971}
2016-03-13 00:52:13 +00:00
b25345ee3f
Replace scoped_ptr with unique_ptr in webrtc/call/
...
BUG=webrtc:5520
Review URL: https://codereview.webrtc.org/1789903003
Cr-Commit-Position: refs/heads/master@{#11970}
2016-03-12 14:10:53 +00:00
83f831a919
Experiment for the nack module.
...
Testing the nack module by implementing it into the current jitter buffer
under the experiment WebRTC-NewVideoJitterBuffer.
BUG=webrtc:5514
Review URL: https://codereview.webrtc.org/1778503002
Cr-Commit-Position: refs/heads/master@{#11969}
2016-03-12 11:30:31 +00:00
84cc9189fb
Replace scoped_ptr with unique_ptr in talk/
...
BUG=webrtc:5520
Review URL: https://codereview.webrtc.org/1785353003
Cr-Commit-Position: refs/heads/master@{#11968}
2016-03-12 06:13:01 +00:00
2db1dbb2ca
Remove references to build_with_libjingle and libjingle_java GYP variables.
...
These were removed a while back in https://codereview.webrtc.org/1457053003
TBR=tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1790753004 .
Cr-Commit-Position: refs/heads/master@{#11967}
2016-03-12 05:34:35 +00:00
bad7b091af
Update examples GYP to avoid rtc_base_approved warning.
...
Updated peerconnection_server to not need stuff from rtc_base.
BUG=
Review URL: https://codereview.webrtc.org/1789463002
Cr-Commit-Position: refs/heads/master@{#11966}
2016-03-12 04:45:25 +00:00
d44c077dce
Revert of Safe numeric library: base/numerics (copied from Chromium) (patchset #11 id:250001 of https://codereview.webrtc.org/1753293002/ )
...
Reason for revert:
Looks like the Chrome iOS build is broken because of these two changes. So I'm going to have to revert. Here's the error:
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/185624/steps/compile/logs/stdio
FAILED: rm -f arch/libsafe_numerics.arm64.a && ./gyp-mac-tool filter-libtool libtool -static -o arch/libsafe_numerics.arm64.a
error: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: no files specified
Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols]
Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load]
FAILED: rm -f arch/libsafe_numerics.armv7.a && ./gyp-mac-tool filter-libtool libtool -static -o arch/libsafe_numerics.armv7.a
error: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: no files specified
Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols]
Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load]
ninja: build stopped: subcommand failed.
Original issue's description:
> Safe numeric library added: base/numerics (copied from Chromium)
>
> This copies the contents (unittest excluded) of base/numerics in
> chromium to base/numerics in webrtc. Files added:
> - safe_conversions.h
> - safe_conversions_impl.h
> - safe_math.h
> - safe_math_impl.h
>
> A really old version of safe_conversions[_impl].h previously existed in
> base/, this has been deleted and sources using it have been updated
> to include the new base/numerics/safe_converions.h.
>
> This CL also adds a DEPS file to webrtc/base.
>
> NOPRESUBMIT=True
> BUG=webrtc:5548, webrtc:5623
>
> Committed: https://crrev.com/de1c81b2d2196be611674aa6019b9db3a9329042
> Cr-Commit-Position: refs/heads/master@{#11907}
TBR=kjellander@webrtc.org ,kwiberg@webrtc.org ,tina.legrand@webrtc.org ,hbos@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5548, webrtc:5623
Review URL: https://codereview.webrtc.org/1792613002 .
Cr-Commit-Position: refs/heads/master@{#11965}
2016-03-12 01:12:40 +00:00
35c5336e60
Revert of Added webrtc/base/safe_conversions.h as a pseudonym (patchset #1 id:20001 of https://codereview.webrtc.org/1774933003/ )
...
Reason for revert:
Looks like the Chrome iOS build is broken because of these two changes. So I'm going to have to revert. Here's the error:
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/185624/steps/compile/logs/stdio
FAILED: rm -f arch/libsafe_numerics.arm64.a && ./gyp-mac-tool filter-libtool libtool -static -o arch/libsafe_numerics.arm64.a
error: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: no files specified
Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols]
Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load]
FAILED: rm -f arch/libsafe_numerics.armv7.a && ./gyp-mac-tool filter-libtool libtool -static -o arch/libsafe_numerics.armv7.a
error: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: no files specified
Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols]
Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load]
ninja: build stopped: subcommand failed.
Original issue's description:
> Added webrtc/base/safe_conversions.h as a pseudonym
> for webrtc/base/numerics/safe_conversions.h.
>
> This prevents downstream projects from breaking that have not yet been
> updated to use the new file path. As soon as they have this file should
> be removed.
>
> This is a follow-up to https://codereview.webrtc.org/1753293002/ .
>
> TBR=hta@webrtc.org
> NOPRESUBMIT=True
> NOTRY=True
> BUG=webrtc:5548
>
> Committed: https://crrev.com/b8f78858619c676955e1098ecc24f2612e55c84f
> Cr-Commit-Position: refs/heads/master@{#11912}
TBR=hta@webrtc.org ,hbos@webrtc.org
NOTRY=True
BUG=webrtc:5548
Review URL: https://codereview.webrtc.org/1787953002 .
Cr-Commit-Position: refs/heads/master@{#11964}
2016-03-12 00:59:34 +00:00
e7ba08695c
Reconfigure video encoders even when not sending.
...
Permits sending faster when having an attached track before actually
sending since the configured stream is ready to encode as soon as a call
is accepted.
BUG=webrtc:5410
R=deadbeef@webrtc.org
Review URL: https://codereview.webrtc.org/1790703002 .
Cr-Commit-Position: refs/heads/master@{#11963}
2016-03-11 23:02:37 +00:00
0149e7595e
Remove the (previosly deprecated) Pass methods
...
Everyone should be using std::move instead.
BUG=webrtc:5373
Review URL: https://codereview.webrtc.org/1778243006
Cr-Commit-Position: refs/heads/master@{#11962}
2016-03-11 22:40:59 +00:00
3102294fc0
Replace scoped_ptr with unique_ptr in webrtc/pc/
...
BUG=webrtc:5520
Review URL: https://codereview.webrtc.org/1783263002
Cr-Commit-Position: refs/heads/master@{#11961}
2016-03-11 22:18:26 +00:00
6f59a4fc4f
Revert of Remove candidates when doing continual gathering (patchset #15 id:560001 of https://codereview.webrtc.org/1648813004/ )
...
Reason for revert:
Breaks the build. Suggest we reland with a default implementation of the new method, update Chrome, land a change that changes |{}| -> |= 0;|
Here's the error:
FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/content/renderer/media/webrtc/test_support_content.mock_peer_connection_dependency_factory.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=262839-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DOSX -DWEBRTC_MAC -DWEBRTC_POSIX -DXML_STATIC -DWEBRTC_CHROMIUM_BUILD -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -I../../third_party/khronos -I../../gpu -I../../skia/config -Igen/angle -I../../third_party/WebKit/Source -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../skia/ext -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -Igen/ui/resources -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -I../../third_party/WebKit -I../../ipc -I../../third_party/opus/src/include -I../../third_party/WebKit -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/libwebp -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/iccjpeg -I../../third_party/libjpeg_turbo -I../../v8/include -I../../third_party/webrtc_overrides -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../third_party -I../../third_party/expat/files/lib -I../../third_party/libvpx/source/libvpx -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O2 -gdwarf-2 -fvisibility=hidden -Werror -mmacosx-version-min=10.6 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/Mac_Builder/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -fcolor-diagnostics -fno-strict-aliasing -c ../../content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc -o obj/content/renderer/media/webrtc/test_support_content.mock_peer_connection_dependency_factory.o
../../content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc:404:14: error: allocating an object of abstract class type 'content::MockSessionDescription'
return new MockSessionDescription(type, sdp);
^
../../third_party/webrtc/api/jsep.h💯 18: note: unimplemented pure virtual method 'RemoveCandidates' in 'MockSessionDescription'
virtual size_t RemoveCandidates(
^
1 error generated.
ninja: build stopped: subcommand failed.
Original issue's description:
> When doing candidate re-gathering in the same generation, Remove the existing local candidate on the same network
> and signaling the remote side to remove its remote candidate by setting the candidate priority to 0.
>
> BUG=
>
> Committed: https://crrev.com/84430da6817ce69c53bfad088be5c9df8b420f01
> Cr-Commit-Position: refs/heads/master@{#11958}
TBR=pthatcher@webrtc.org ,deadbeef@webrtc.org ,glaznev@webrtc.org ,honghaiz@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.webrtc.org/1785613011
Cr-Commit-Position: refs/heads/master@{#11960}
2016-03-11 22:05:15 +00:00
916c76eaad
Add new files for VideoSourceBase to roll into Chrome in preparation for implementatin.
...
TBR=pthatcher@webrtc.org
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1794483003 .
Cr-Commit-Position: refs/heads/master@{#11959}
2016-03-11 21:54:37 +00:00
84430da681
When doing candidate re-gathering in the same generation, Remove the existing local candidate on the same network
...
and signaling the remote side to remove its remote candidate by setting the candidate priority to 0.
BUG=
Review URL: https://codereview.webrtc.org/1648813004
Cr-Commit-Position: refs/heads/master@{#11958}
2016-03-11 21:28:12 +00:00
44d7392d13
Roll chromium_revision 5778d35..db8316d (380596:380688)
...
Change log: 5778d35..db8316d
Full diff: 5778d35..db8316d
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1781273005
Cr-Commit-Position: refs/heads/master@{#11957}
2016-03-11 20:52:12 +00:00
3ad4bd31cc
Skinmap improvement.
...
Use a flag to switch between original skinmap model and an
experimental model(use original skinmap by default).
BUG=
Review URL: https://codereview.webrtc.org/1776993004
Cr-Commit-Position: refs/heads/master@{#11956}
2016-03-11 19:57:12 +00:00
86aabb288d
Move BitrateAllocator reference from ViEEncoder to VideoSendStream.
...
This CL will be followed up with a CL adding AudioSendStream to
BitrateAllocator, so this is a small CL to have the video connection to
BitrateAllocator "at the same level" as for audio.
BUG=webrtc:5079
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1785283002 .
Cr-Commit-Position: refs/heads/master@{#11955}
2016-03-11 14:44:44 +00:00
a590605d5c
Roll chromium_revision 1ff3458..5778d35 (380437:380596)
...
Change log: 1ff3458..5778d35
Full diff: 1ff3458..5778d35
Changed dependencies:
* src/buildtools: 14288a0..7274f1c
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/ba70118..a857159
DEPS diff: 1ff3458..5778d35 /DEPS
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1778133008
Cr-Commit-Position: refs/heads/master@{#11954}
2016-03-11 12:20:06 +00:00
8842c3e41b
Relanding https://codereview.webrtc.org/1715883002/ in pieces.
...
- Use better types in AudioSendStream::SendTelephoneEvent() and related methods.
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1782053002
Cr-Commit-Position: refs/heads/master@{#11953}
2016-03-11 11:06:48 +00:00