aef8a21a69
Reland "Switch from rtc_ios_xctest_test to rtc_test".
...
This is a reland of https://webrtc-review.googlesource.com/c/src/+/182680 ,
and it is based on https://chromium-review.googlesource.com/c/chromium/src/+/2414169
which allows to force a "test" to be executed as an XCtest on a build target
basis instead of on a GN args basis like it was happening in
https://webrtc-review.googlesource.com/c/src/+/182680 because that was
causing issues when launching tests on real devices.
Bug: webrtc:11881, webrtc:11937
Change-Id: I4bec7f471cd0f878b6050f266cd0cca3b518d415
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184360
Reviewed-by: Dirk Pranke <dpranke@google.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32126}
2020-09-17 09:14:15 +00:00
4f55233cf7
Add possibility to override mac_toolchain via .gclient custom_vars.
...
This will allow "gclient sync" to pick up a new version of the mac
toolchain as documented at [1].
[1] - https://source.chromium.org/chromium/chromium/src/+/master:docs/mac_arm64.md
TBR=peah@webrtc.org
Bug: webrtc:11946
Change-Id: I2265f27a206fb1e1cbff6216a4d083c0c4817f8e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184364
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32125}
2020-09-17 07:35:46 +00:00
525f11b4c5
Roll chromium_revision 3f2f2acf90..9d25386ec1 (807625:807774)
...
Change log: 3f2f2acf90..9d25386ec13f2f2acf90..9d25386ec114412b27f8..f1b4682ab7e16c6beb06..55fc88f81d1ed0ad631f..bdbe315b9bd8570cd663..5b99869e594addd083f3..15acfdb7f7https://chromium.googlesource.com/catapult.git/+log/cb190dce08..d03abd8af7
* src/third_party/depot_tools: 5c4c28f111..a787cd5e153504e85b74..a2ba0ce189d3ac111a70..cf582c5b8d3f2f2acf90..9d25386ec1TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: If8e940b3719fd2c4a3880bca937090697c84a994
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184442
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32124}
2020-09-17 06:48:16 +00:00
f229127551
Roll chromium_revision a6c88d8953..3f2f2acf90 (807489:807625)
...
Change log: a6c88d8953..3f2f2acf90a6c88d8953..3f2f2acf90afe0957b59..14412b27f8bd89e4805c..1ed0ad631f59b5c1f4b7..d8570cd6636d26c263c0..4addd083f3https://chromium.googlesource.com/catapult.git/+log/511a82c95f..cb190dce08
* src/third_party/perfetto: d1382ae74f..3504e85b749239268ebf..d3ac111a70a6c88d8953..3f2f2acf90TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I0870812a961d3bbe680230e5c45b130c1dadf447
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184381
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32123}
2020-09-16 21:11:42 +00:00
3e98280633
Add unit tests for cancer stick castle library
...
- Fix the minor issues with the initial library implementation.
- Add unit tests to cover basic scenarios.
Bug: none
Change-Id: Ibf28b4e20f74792fce2fe11d4780fd375a4ad3a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183343
Commit-Queue: Lahiru Ginnaliya Gamathige <glahiru@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32122}
2020-09-16 19:04:29 +00:00
bb25c561dc
Roll chromium_revision 1519d2c44a..a6c88d8953 (807375:807489)
...
Change log: 1519d2c44a..a6c88d89531519d2c44a..a6c88d895367e53b567b..afe0957b5942cbd32cfb..e16c6beb06d02f11314c..bd89e4805c1d2f486547..59b5c1f4b735a847848c..6d26c263c08e500174f4..5c4c28f11179326efe26..d7eebbfb278ca19625de..d5148db386d48ef5f7dd..d1382ae74fc680fe1f81..9239268ebf1519d2c44a..a6c88d8953TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I0c0dec043c943a3bc746919a02f56b9f0c90ddad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184380
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32121}
2020-09-16 16:54:20 +00:00
804db2dde3
UntypedFunction: Eliminate an unnecessary indirection in the implementation
...
Bug: webrtc:11943
Change-Id: Ib57b13977910ede430e4228a9d382fb765bf1d84
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184261
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32120}
2020-09-16 14:47:45 +00:00
198cd73011
Test for negotiating pre-stopped M-sections.
...
Fix for issue is in https://webrtc-review.googlesource.com/c/src/+/184343
Bug: chromium:1127625
Change-Id: I11bcde82b7e03a160b5ee078a9c5edf7f2e31902
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184344
Reviewed-by: Philipp Hancke <philipp.hancke@googlemail.com >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32119}
2020-09-16 14:35:06 +00:00
c8b3183711
Allow the SwapQueue to utilize user-define swap capability
...
The SwapQueue class provides efficient and thread-safe queueing of objects that
have swap capabilities. However, the current implementation does not utilize the
user-defined swap capabilites. This CL addresses that.
Bug: b/168693942
Change-Id: Id5c97c8c9cc04579b3c26c7f1dc5f8b3362126c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184361
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32118}
2020-09-16 14:08:55 +00:00
fe132e6bd9
Don't expect a transceiver for stopped m-sections
...
After implementing transceiver.stop and associated logic with regard
to stopped media sections, there might not be a transceiver for every
media section. Allow this case.
There is a test ready for submission in Chrome:
https://chromium-review.googlesource.com/c/chromium/src/+/2410407
Bug: chromium:1127625
Change-Id: I150ea5f0da4a0cbd2bf214bc659ea0df93b607de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184343
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Philipp Hancke <philipp.hancke@googlemail.com >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32117}
2020-09-16 13:49:51 +00:00
78e9acd967
UntypedFunction: Add unit tests and fix a few issues
...
Bug: webrtc:11943
Change-Id: I1f3c0495612148546ec399a800f97fe88b439c83
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184260
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32116}
2020-09-16 13:30:01 +00:00
818be15e4d
Clobber iOS builders.
...
TBR=titovartem@webrtc.org
Bug: webrtc:11937
Change-Id: Ic3ad56df532fac0ccf254e3e98d003ae0fefbf3c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184342
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32115}
2020-09-16 11:43:54 +00:00
7d73c6cf9d
Explicitly enable CDEF
...
It should already be enabled by default in libaom, but explicitly enable
it here in case that changes.
Bug: None
Change-Id: I93a1dfc92f9c02bc5ec823c326d8cf6ff163bceb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184262
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32114}
2020-09-16 11:39:44 +00:00
fa54364cea
Update STUN attributes with latest IANA registrations
...
https://www.iana.org/assignments/stun-parameters/stun-parameters.xhtml
Bug: webrtc:0
Change-Id: Id3addf432abdfe0b5c236dc5b080e64744c18114
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184341
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32113}
2020-09-16 11:13:14 +00:00
08574aeb44
Revert "Reland "Switch from "rtc_ios_xctest_test" to "rtc_test".""
...
This reverts commit 60c25a303fac85dccb2ccdd9e8d6d71be13b7541.
Reason for revert: Breaks downstream iOS testers.
From an offline discussion, the GN argument is not needed and only
the 3 xctest needs the behavior of that argument. So I am reverting
this one and preparing 2 CLs to properly fix.
Original change's description:
> Reland "Switch from "rtc_ios_xctest_test" to "rtc_test"."
>
> This is a reland of 7a73c772e21983857e46cb4fcedc6cfa3f42c03e
>
> The change to fix the downstream issue is just the switch from
> "test" to "rtc_test" which is a GN template that expands to
> "test".
>
> Original change's description:
> > Switch from "rtc_ios_xctest_test" to "test".
> >
> > Using the "test" GN template instead of the "ios_xctest_test" one we
> > will get iOS support for isolates via MB and GN for free, making it
> > easier to migrate the iOS recipe and fix bugs.webrtc.org/11604.
> >
> > Bug: webrtc:11881
> > Change-Id: I72b90f8494c473fa567e6296caf7a771e4caba92
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/182680
> > Reviewed-by: Dirk Pranke <dpranke@google.com >
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#32064}
>
> Bug: webrtc:11881
> Change-Id: Ia5338859f4e893b9f19bcca6b26b8cf66d5984e8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183766
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Dirk Pranke <dpranke@google.com >
> Cr-Commit-Position: refs/heads/master@{#32075}
TBR=mbonadei@webrtc.org ,dpranke@google.com ,jeffyoon@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:11881, webrtc:11937
Change-Id: Ie6eea6b2a8ba5c46af40b115c6db4fd0a38a25b0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184340
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32112}
2020-09-16 09:17:42 +00:00
d47d6de8a7
Roll chromium_revision dfb9023b74..1519d2c44a (807259:807375)
...
Change log: dfb9023b74..1519d2c44adfb9023b74..1519d2c44afaa02f24d9..67e53b567bbe363dca53..42cbd32cfb69f4b0847d..d02f11314c8ce5d48cf1..1d2f4865476b16cb17c1..35a847848chttps://chromium.googlesource.com/catapult.git/+log/3f01e83f96..511a82c95f
* src/third_party/depot_tools: 52fdd1ffce..8e500174f453747dfe65..97356acb50b189aac831..d48ef5f7dd8d6ecc0f6c..c680fe1f81dfb9023b74..1519d2c44aTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,marpan@webrtc.org , jianj@chromium.org ,
BUG=None
Change-Id: Ied152b0f7513a25e6ed65e9fa930f45d847fe891
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184323
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32111}
2020-09-16 09:03:20 +00:00
b10d4a612b
Roll chromium_revision 235f74189d..dfb9023b74 (807145:807259)
...
Change log: 235f74189d..dfb9023b74235f74189d..dfb9023b74d7463849c7..faa02f24d97b43f4ded4..be363dca5358de4223af..69f4b0847dafd548c6f5..8ce5d48cf10ee732e170..6b16cb17c1https://chromium.googlesource.com/catapult.git/+log/93d0ecf3d4..3f01e83f96
* src/third_party/depot_tools: f57e64e375..52fdd1ffceafb055b203..8d6ecc0f6c235f74189d..dfb9023b74TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I73f54319fbeff98b33aa9e8bd2e422cbf9858332
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184286
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32110}
2020-09-16 00:51:38 +00:00
e4642dac6c
Updating the OWNERS file for desktop capture
...
Change-Id: If5ddad06f0c5ce306e919de1f3a182986abaa0fe
Bug: webrtc:11938
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184281
Commit-Queue: Joe Downing <joedow@google.com >
Reviewed-by: Jamie Walch <jamiewalch@chromium.org >
Cr-Commit-Position: refs/heads/master@{#32109}
2020-09-15 21:34:24 +00:00
9bb8401a6c
Roll chromium_revision 5aa7e23974..235f74189d (807011:807145)
...
Change log: 5aa7e23974..235f74189d5aa7e23974..235f74189dea9d15525e..d7463849c760f89634b9..7b43f4ded4f3c442d839..58de4223af56572a88df..afd548c6f59e2844b24a..0ee732e170https://chromium.googlesource.com/catapult.git/+log/534924ed9e..93d0ecf3d4
* src/third_party/perfetto: b0a548c7e6..b189aac831dfa91dac01..afb055b2035aa7e23974..235f74189dTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ida942dfd1f865d91a80fff1e81f990f4ddd34916
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184284
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32108}
2020-09-15 20:51:04 +00:00
ae073e4433
Clobber iOS builders.
...
TBR=titovartem@webrtc.org
Bug: webrtc:11937
Change-Id: Ifca722d2e033b4a058f4e912535e622183a1165a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184265
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32107}
2020-09-15 20:22:24 +00:00
986e745106
Fix for unbounded increase in audio delay when no audio packets are flowing in
...
WebRTC’s Audio Video sync can go in unbounded loop and keep on increasing audio delay if audio packets stop coming in.
The issue happens, if StreamSynchronization::ComputeDelays has:
1. relative_delay_ms = some positive value which causes avg_diff_ms_ > 30ms
2. current_audio_delay_ms < current_video_delay_ms
3. audio_delay_.extra_ms > 0 and video_delay_.extra_ms = 0
To compensate for relative delay, audio_delay_.extra_ms gets incremented every time StreamSynchronization::ComputeDelays is called by RtpStreamsSynchronizer::Process(), which happens every 1sec
RtpStreamsSynchronizer::Process() will try to set the new delay to audio stream by calling syncable_audio_->SetMinimumPlayoutDelay(target_audio_delay_ms);
This ends up calling DelayManager::SetMinimumDelay and update minimum_delay_ms_
But this update has no impact on the value returned by NetEqImpl::FilteredCurrentDelayMs (as there are no audio packets flowing in, hence neteq is not running) which is called next time RtpStreamsSynchronizer::Process(), runs and tried to compute the new audio delay (audio_info→current_delay_ms)
This causes audio delay to be increased in every iteration and it grows unbounded. I guess it will stop growing above 10sec as that is hardcoded max delay in NetEQ.
To avoid this added a check to not adjust delays when no new audio stream has come in.
Bug: webrtc:11894
Change-Id: If648f9227e43c351f887d054876cb119cc1a917e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183340
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Shyam Sadhwani <shyamsadhwani@fb.com >
Cr-Commit-Position: refs/heads/master@{#32106}
2020-09-15 15:54:54 +00:00
c6dbc5ee80
Roll chromium_revision 2c970cbe2f..5aa7e23974 (806885:807011)
...
Change log: 2c970cbe2f..5aa7e239742c970cbe2f..5aa7e239749f51c92f5c..60f89634b9ac90fd0782..f3c442d83949c4639b9a..56572a88dffb6ac2eca4..9e2844b24a0547fb2917..f57e64e375cfda0b2aaf..b0a548c7e6084749d9cb..dfa91dac012c970cbe2f..5aa7e23974TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ia10f88c2af648dcac18b85aabead0ff3f833b7ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184245
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32105}
2020-09-15 14:37:34 +00:00
daec488749
objc: fix rollback
...
and add a unit test
BUG=webrtc:11796
Change-Id: I8e73b22f007c15c862faad7ca881d93c14a3a46f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184160
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/master@{#32104}
2020-09-15 09:27:08 +00:00
6e046668d1
Adding field trials to control additional quality scaler settings
...
Bug: webrtc:11924
Change-Id: I98c7aa4bd4536770500fec7e8e8da9629fddd20f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183342
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32103}
2020-09-15 08:58:36 +00:00
34f5ab82fe
Roll chromium_revision b0398ace4b..2c970cbe2f (806731:806885)
...
Change log: b0398ace4b..2c970cbe2fb0398ace4b..2c970cbe2f2bc64ef15e..ea9d15525e73be302438..9f51c92f5c7ecdca2225..ac90fd07822444860bdd..49c4639b9a533fbd1f56..fb6ac2eca4a1e15498cd..0547fb2917bef393a5a3..cfda0b2aafa8c51df76c..995c0b844181ed796261..084749d9cb4c095d0417..44c13d7315b0398ace4b..2c970cbe2fTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I96ae6acdf60dd2fb802721ba0e4ee6e4cca94562
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184221
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32102}
2020-09-15 05:11:45 +00:00
7703f23b60
Adds ability to delay pacer start until media is added.
...
This avoids the pacer thread waking up at 5ms interval if a
PeerConnection is created without actually using media.
The TaskQueuePacedSender solves the problem too, this CL is mostly a
safeguard in case we still find issues when turning it on...
Can be turned off by setting field trial "WebRTC-LazyPacerStart" to
"Disabled".
Bug: webrtc:10809
Change-Id: I8501106e608eccb14487576f24bdceaf3f324d80
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183982
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32101}
2020-09-14 21:42:55 +00:00
352e9daef6
Roll chromium_revision e645bb4cda..b0398ace4b (806687:806731)
...
Change log: e645bb4cda..b0398ace4be645bb4cda..b0398ace4b38d8562d3a..2bc64ef15e8ef1ccddd4..73be3024389d2c35e634..7ecdca22256af3f7480a..2444860bdd20df2251ef..533fbd1f56f95de1d32e..81ed796261e645bb4cda..b0398ace4bTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I22daba040e78cffbc3cafc1007d8ebbf062db2ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184182
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32100}
2020-09-14 21:11:05 +00:00
634df6cf07
Roll chromium_revision ff96bd0744..e645bb4cda (806570:806687)
...
Change log: ff96bd0744..e645bb4cdaff96bd0744..e645bb4cda7c00d9e621..38d8562d3ab190443087..8ef1ccddd4a90362b4fc..3ff4f5027bcd9cd902d6..9d2c35e634598b9bd5a4..6af3f7480aa4df3b8110..20df2251ef9edd1a906f..bef393a5a3dfc31b1737..f95de1d32eff96bd0744..e645bb4cdaff96bd0744..e645bb4cdaTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I70544e902df9e3dbe7a4a94b515bb429745945c0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184181
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32099}
2020-09-14 18:37:29 +00:00
295570eb33
Use PostTask instead of MessageHandler for cert generation.
...
Bug: webrtc:11908
Change-Id: Iaad4f0e398980eeae77187a32dfade0c26eb4cc8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184061
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32098}
2020-09-14 14:48:39 +00:00
4d76a13b33
Make StunRequest not use auto cleanup.
...
The class already clears the thread that's used in its dtor
and consistently uses the same thread.
Bug: webrtc:11908
Change-Id: I5ea8d00c2e59bf46c5b369be5b23cf1d8e1875c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184060
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32097}
2020-09-14 14:46:49 +00:00
6da271844c
Avoid deallocating the async invoker when clearing the transport.
...
Deallocating the async invoker is a costly operation
but it's also unnecessary and could cause us to miss signal
events.
The data_channel_transport and data_channel_transport_invoker
are (despite the name) not related, since the latter is
used to signal events on the signaling thread whereas the
former deals with the data.
Bug: webrtc:11908
Change-Id: I37b345476a6381aef5d87807877ec1e05b380137
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184062
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32096}
2020-09-14 12:51:12 +00:00
8452ea86c5
Synchronize modifications to frame_extra_info_ in jni::VideoEncoderWrapper.
...
Since https://webrtc-review.googlesource.com/c/src/+/161447 ,
frame_extra_info_ is modified from both the encoder thread and the
callback thread.
Bug: None
Change-Id: Idece4d19cae6d8363428234721616f6ca6f85832
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184121
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32095}
2020-09-14 11:15:32 +00:00
e7b19c2d7f
Roll chromium_revision 1b3e75b818..ff96bd0744 (806461:806570)
...
Change log: 1b3e75b818..ff96bd07441b3e75b818..ff96bd0744ffc67a078f..7c00d9e621b4fd3f736f..b190443087547db2a22b..cd9cd902d6b933295dc0..598b9bd5a4c1010ec39d..a4df3b8110https://chromium.googlesource.com/catapult.git/+log/e53ee0c931..534924ed9e
* src/tools: 3a1c9b0ce8..dfc31b17371b3e75b818..ff96bd0744TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I157d3e0114e455385b169622e607c182ef68e4be
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184102
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32094}
2020-09-14 10:36:42 +00:00
a028a1a0f7
Removed old OnDecodedFrame callback.
...
Bug: webrtc:9106
Change-Id: Idb13ca9984f1e74585640e78da60a291218f4ade
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183981
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32093}
2020-09-14 09:58:21 +00:00
6b4d962947
Fix standard GetStats to not modify NetEq state.
...
Add a get_and_clear_legacy_stats flag to AudioReceiveStream::GetStats,
to distinguish calls from standard GetStats and legacy GetStats.
Add const method NetEq::CurrentNetworkStatistics to get current
values of stateless NetEq stats. Standard GetStats will then call this
method instead of NetEq::NetworkStatistics.
Bug: webrtc:11622
Change-Id: I3833a246a9e39b18c99657a738da22c6e2bd5f5e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183600
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32092}
2020-09-14 09:51:21 +00:00
71d7c8e3cd
Roll chromium_revision 9d73c26fe1..1b3e75b818 (806356:806461)
...
Change log: 9d73c26fe1..1b3e75b8189d73c26fe1..1b3e75b818c06c2790fb..ffc67a078ff2a02d7466..b4fd3f736fad2af3b032..547db2a22b108a4cd7ea..b933295dc0532cae6a5b..c1010ec39d970bf5ad2c..a1e15498cd790f103831..3a1c9b0ce89d73c26fe1..1b3e75b818TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I37607228f6a5ab0e58d211bcfc1bf50bf281a8c6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184080
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32091}
2020-09-12 18:39:19 +00:00
123594114f
Make MessageHandler ctor explicitly require 'false'.
...
This is the next step towards making MessageHandler a pure virtual
interface. All dependencies that require automatic cleanup
should be depending on the MessageHandlerAutoCleanup class.
Next step will be to remove the ctor from MessageHandler and make
it a pure virtual interface.
Bug: webrtc:11908
Change-Id: I9321b6d9e57c167868f8b896a5345fbfe19af0e9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183984
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32090}
2020-09-12 11:04:43 +00:00
5c8aa5cd05
Roll chromium_revision 86121ae296..9d73c26fe1 (806200:806356)
...
Change log: 86121ae296..9d73c26fe186121ae296..9d73c26fe173944f028a..c06c2790fb70c88ee24c..f2a02d7466f2002b3a38..ad2af3b032be60d05e59..108a4cd7eabfc6d375e0..532cae6a5bhttps://chromium.googlesource.com/catapult.git/+log/9f91f3564a..e53ee0c931
* src/third_party/depot_tools: b686cc0063..970bf5ad2c9d4f8005bc..8ca19625dee4c4eb613f..790f10383186121ae296..9d73c26fe1TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ifc5321fc4eb5666816e6e80c670c88dfd9d388db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183972
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32089}
2020-09-11 22:46:22 +00:00
4100d55e2c
Remove uppercase after number on gtest names.
...
This is a follow up fix for webrtc-review.googlesource.com/c/src/+/183763.
Bug: webrtc:11084
Change-Id: Iebdfe8a3c0aeb418cbdc128b4876c329788532d0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183983
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32088}
2020-09-11 18:23:54 +00:00
32eb03a1fb
Get rid of NetworkMonitorBase helper class.
...
All it provides is a method to call a signal on the network thread,
so it's not worth the added complexity. Implementations of
NetworkMonitorInterface must hop to the network thread anyway to
guard their members.
Also added some thread annotations to AndroidNetworkMonitor.
Bug: webrtc:9883
Change-Id: I64bb82ea593433f3a52871dbb75eb2ac4f47d69c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/181420
Commit-Queue: Taylor <deadbeef@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32087}
2020-09-11 18:22:14 +00:00
ef8507d106
Roll chromium_revision 55b6d72896..86121ae296 (806095:806200)
...
Change log: 55b6d72896..86121ae29655b6d72896..86121ae2966f96cef0ab..73944f028a41b95e3b54..70c88ee24c36c78ae2e8..f2002b3a3864f2e1cf55..be60d05e59748f78adff..bfc6d375e0https://chromium.googlesource.com/catapult.git/+log/13bf125482..9f91f3564a
* src/third_party/depot_tools: fb6d901df7..b686cc0063617d3f67c3..9edd1a906f33d4e3e6dd..e4c4eb613f55b6d72896..86121ae296TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ib8cb0dedda1c851f4bb2bcb78879377173ad09a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183970
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32086}
2020-09-11 16:41:31 +00:00
3d452cf710
Proof of concept: Cancer Stick Castle, a sigslot replacement
...
This needs to be followed immediately by a CL that adds unit tests for
CancerStickCastle and UntypedFunction.
Bug: none
Change-Id: I5ade68cc4721d7442db7695f218ecd9be1d639ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/182460
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Lahiru Ginnaliya Gamathige <glahiru@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32085}
2020-09-11 15:31:51 +00:00
de5507d31b
Updates rtcp::CompoundPacket to contain unique pointers to packets.
...
Currently test code passes pointer to temporary objects, while
RtcpSender passes raw pointers to objects that are then seen as owned,
and will be manually deleted by a overloaded destructor, which is scary
and fragile.
This CL moves all usage to std::unique_ptr<RtcpPacket> instead, which
may create some heap churn in unit tests but that should be fine.
Bug: webrtc:11925
Change-Id: I981bc7ccd6a74115c5a3de64b8427adbf3f16cc7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183920
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32084}
2020-09-11 14:34:07 +00:00
1b06876a52
Delete kHEVCCodecName
...
It's currently unused and H265X is not a standardized payload type.
Bug: webrtc:11627
Change-Id: I92e8c7a9eac59ff6d158ed75ae51615c6811cde9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183601
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32083}
2020-09-11 14:21:27 +00:00
c8850cbf55
Change gtest name to allow filtering based on the story name.
...
It is meant for Pinpoint to run only the relevant tests when running a bisection.
The Pinpoint side of this change can be found here:
https://crrev.com/c/2404161
Bug: webrtc:11084
Change-Id: I466f39816b83e2f83a3a49845c99605f4d5a857b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183763
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32082}
2020-09-11 14:11:27 +00:00
aeac9f8859
build: move rtc_prefer_fixed_point
...
making it more visible where fixed point is preferred
BUG=None
Change-Id: I72c135ebea9c67739fc9c1747433f1a574319d39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183980
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/master@{#32081}
2020-09-11 12:38:24 +00:00
dd68063976
rename "sdp" to description in a few places
...
renames the RTCSessionDescription object from "ѕdp" to "desc" in a few places.
The term SDP should generally refer to the blob of text described in
RFC 4566 while the RTCSessionDescription specified in
https://w3c.github.io/webrtc-pc/#rtcsessiondescription-class
contains both a type and a sdp.
BUG=None
Change-Id: Iacf332d02b03134e49c2b4147dc5725affa89741
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183882
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32080}
2020-09-11 12:36:54 +00:00
3dc4780d8e
Added VideoContentType to OnDecodedFrame callback.
...
Also added a FrameInfo struct to propagate various meta information along side it.
Bug: webrtc:9106
Change-Id: I1feb9f94c662c367f7c6e0a50d33705fdd5346bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183880
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32079}
2020-09-11 10:22:05 +00:00
673027b4a5
Make NetEqController::TargetLevelMs const, part 2
...
Followup to https://webrtc-review.googlesource.com/c/src/+/183881 .
Bug: webrtc:11622
Change-Id: I8d76bf082e81ba1217d20e57c6ae6555eca2fc7b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183883
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32078}
2020-09-11 09:34:55 +00:00
f5c373b5fb
Roll chromium_revision 4bbb1de363..55b6d72896 (805973:806095)
...
Change log: 4bbb1de363..55b6d728964bbb1de363..55b6d728963a6759e899..6f96cef0abb3e63d3c2a..41b95e3b54224d11e961..36c78ae2e806b66d558d..64f2e1cf55515bfb84d5..748f78adff3b19b9d334..617d3f67c3ca442606f9..33d4e3e6dd4bbb1de363..55b6d72896TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I6ec35b062215612c9ce980142280266ef9482129
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183966
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32077}
2020-09-11 08:47:50 +00:00
