4461f059d1
Delete unused NetEq stats currentPacketLossRate, currentDiscardRate and addedSamples
...
Bug: webrtc:11622
Change-Id: I097bb7284d952ada41f4f38dd7adf3536bd040ee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183620
Reviewed-by: Minyue Li <minyue@google.com >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32148}
2020-09-21 12:19:16 +00:00
3f94fc53d4
Migrate android_resources targets to not create R.java files
...
R.java file creation responsibilities will be moved to android_library
and android_apk targets and creating R.java files in the
android_resources targets is now deprecated. This cl migrates webrtc
targets to the new way.
Bug: chromium:1073476
Change-Id: I0a2fa759d3ff1d8e201e5719c9238701a58171e9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183060
Commit-Queue: Mohamed Heikal <mheikal@chromium.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32026}
2020-09-01 20:29:36 +00:00
b742e2e048
Use non-deprecated EncodedImageCallback::OnEncodedImage in rtc_tools
...
Bug: webrtc:6471
Change-Id: Iee52f3fb46f0b1c7146d906dcd545f017cbdb06e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/181365
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31918}
2020-08-12 09:17:15 +00:00
07b7dece9a
video_replay: wrap main thread
...
Fix for the DCHECK described in
from https://bugs.chromium.org/p/webrtc/issues/detail?id=11800#c3
BUG=None
Change-Id: I18e6e12431c1d1c033f5e219156afde00b9ae1e9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180420
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/master@{#31908}
2020-08-11 11:28:09 +00:00
2b068ce1b8
Reland "Moved VideoReceiveStream::Decoder::decoder_factory to VideoReceiveStream::Config::decoder_factory."
...
This reverts commit a4f23ad0ce4382e3a11bc6a8c1f9f6183e722fd8.
Reason for revert: Downstream fix landed.
TBR=mflodman@webrtc.org
Original change's description:
> Revert "Moved VideoReceiveStream::Decoder::decoder_factory to VideoReceiveStream::Config::decoder_factory."
>
> This reverts commit acb9d8365a5f9eb1e2a9e9902690d62dab1e5759.
>
> Reason for revert: Break downstream stuff.
>
> Original change's description:
> > Moved VideoReceiveStream::Decoder::decoder_factory to VideoReceiveStream::Config::decoder_factory.
> >
> > Bug: webrtc:9106
> > Change-Id: I85712f3ab6a734d3fad7819491d3b8e3388b47e7
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180342
> > Reviewed-by: Niels Moller <nisse@webrtc.org >
> > Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
> > Commit-Queue: Philip Eliasson <philipel@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#31834}
>
> TBR=nisse@webrtc.org ,philipel@webrtc.org ,mflodman@webrtc.org
>
> Change-Id: I6cfdb85a154a78135839f84edf5f69673d5ab715
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:9106
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180807
> Reviewed-by: Philip Eliasson <philipel@webrtc.org >
> Commit-Queue: Philip Eliasson <philipel@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#31835}
TBR=nisse@webrtc.org ,philipel@webrtc.org ,mflodman@webrtc.org
# Not skipping CQ checks because this is a reland.
Bug: webrtc:9106
Change-Id: I03b3e68532107bec37bcc6e47a5489c84fe91ef9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180808
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31866}
2020-08-06 11:50:08 +00:00
a4f23ad0ce
Revert "Moved VideoReceiveStream::Decoder::decoder_factory to VideoReceiveStream::Config::decoder_factory."
...
This reverts commit acb9d8365a5f9eb1e2a9e9902690d62dab1e5759.
Reason for revert: Break downstream stuff.
Original change's description:
> Moved VideoReceiveStream::Decoder::decoder_factory to VideoReceiveStream::Config::decoder_factory.
>
> Bug: webrtc:9106
> Change-Id: I85712f3ab6a734d3fad7819491d3b8e3388b47e7
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180342
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
> Commit-Queue: Philip Eliasson <philipel@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#31834}
TBR=nisse@webrtc.org ,philipel@webrtc.org ,mflodman@webrtc.org
Change-Id: I6cfdb85a154a78135839f84edf5f69673d5ab715
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9106
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180807
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31835}
2020-08-03 15:45:41 +00:00
acb9d8365a
Moved VideoReceiveStream::Decoder::decoder_factory to VideoReceiveStream::Config::decoder_factory.
...
Bug: webrtc:9106
Change-Id: I85712f3ab6a734d3fad7819491d3b8e3388b47e7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180342
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31834}
2020-08-03 14:10:37 +00:00
85585f4a52
Migrate rtc_tools/, sdk/, and system_wrappers/ to webrtc::Mutex.
...
Bug: webrtc:11567
Change-Id: Ia85cf457ac16ebec0a70d319506415e4dec46f30
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178903
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Commit-Queue: Markus Handell <handellm@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31693}
2020-07-10 08:02:05 +00:00
b19cfeeb5c
Roll chromium_revision 4d95e6c77b..71a0e1904e (776481:782339)
...
Change log: 4d95e6c77b..71a0e1904e4d95e6c77b..71a0e1904e2df7267880..736d9fb42ca03951acb9..876a7806001b066f0216..1ed99573d59200aad36b..73c8bcb1b1502600d41a..77ba7104d5e0df6e10ad..1908162da7https://boringssl.googlesource.com/boringssl.git/+log/88024df121..430a742303
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2ad47493f8..e0658a4adf
* src/third_party/depot_tools: 37e562110f..87c8b91639be66dc5fd0..23b2a15c2562fea391fa..a443474755630b884f84..79326efe26https://aomedia.googlesource.com/aom.git/+log/2aa13c436e..e1ebb418eb
* src/third_party/libunwindstack: 046920fc49..11659d420ac176557314..769129fb2960cf022c02..44e38c464395f6fb6f1e..1c98ea6854050a4a5e26..d6998993f94d95e6c77b..71a0e1904e4d95e6c77b..71a0e1904eTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,marpan@webrtc.org , jianj@chromium.org ,
BUG=None
Change-Id: Idb4a2ccc6eab502ecf78b34247a479ff5726b50a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178084
Reviewed-by: Jeremy Leconte <jleconte@google.com >
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#31569}
2020-06-26 05:33:14 +00:00
ae1892d4e4
Add simulation of robust throughput estimator to the event log analyzer
...
Bug: webrtc:11566
Change-Id: I873d1c1bd6682a973b3a130289390e09ef47cc37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177017
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31538}
2020-06-17 10:33:02 +00:00
08ce986fda
Switch to absl single target when building with Chromium.
...
The //third_party/abseil-cpp:absl target is currently a group that
depends on all the targets needed by WebRTC in Chromium.
It will be switched to a component starting from
https://chromium-review.googlesource.com/c/chromium/src/+/2174434 .
Bug: chromium:1046390
Change-Id: I70d450fdbfa895084b481c9884b6361d2fb9580d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176901
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31498}
2020-06-11 11:53:48 +00:00
8a89b5bc0d
Deprecate inheritance hierachy of plot formats in event_log_visualizer.
...
Instead add separate printing functions for each plot format in the base class.
Bug: webrtc:11566
Change-Id: I8adfc983b4e8a66c477de4022c2d97b6975d7e5c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176563
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31496}
2020-06-11 09:54:52 +00:00
c186e1498b
Move NetEq and ANA plotting to a separate file.
...
Bug: webrtc:11566
Change-Id: I6d6176ff72a158a1629e14b539de2e928e7d02a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176510
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@google.com >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31472}
2020-06-09 10:05:31 +00:00
571e130ce2
Fix nondeterministic behavior in rtc_event_log_visualizer caused by uninitialized variables.
...
Bug: webrtc:11566
Change-Id: I10dcb84c8e7e231fe24dc322a0359742dded05bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176515
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31471}
2020-06-09 09:26:41 +00:00
2dcf348011
Use absl_deps in order to preapre to the Abseil component build release.
...
Bug: webrtc:1046390
Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31463}
2020-06-08 12:59:40 +00:00
f25761d798
Remove dependency from RtpRtcp on the Module interface.
...
The 'Module' part of the implementation must not be
called via the RtpRtcp interface, but is rather a part of
the contract with ProcessThread. That in turn is an
implementation detail for how timers are currently implemented
in the default implementation.
Along the way I'm deprecating away the factory function which
was inside the interface and tied it to one specific implementation.
Instead, I'm moving that to the implementation itself and down the
line, we don't have to go through it if we just want to create an
instance of the class.
The key change is in rtp_rtcp.h and the new rtp_rtcp_interface.h
header file (things moved from rtp_rtcp.h), the rest falls from that.
Change-Id: I294f13e947b9e3e4e649400ee94a11a81e8071ce
Bug: webrtc:11581
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176419
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31440}
2020-06-04 08:11:21 +00:00
0d1b28cf09
Replace inconsistent log_segments() function in RTC event log parser
...
Bug: webrtc:11566
Change-Id: I739bbc29ae5423f3fedcc08e991e27fa0af840c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176081
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31371}
2020-05-27 20:05:13 +00:00
adef79808a
Enable triage alerts in rtc_event_log_visualizer by default.
...
Bug: webrtc:11566
Change-Id: Idaed887f07cb867d7ec77379a359c96fa9bdc4cb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175650
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31356}
2020-05-26 16:23:37 +00:00
35c87b6ada
Remove android_manifest_for_lint from BUILD.gn files
...
Remove android_manifest_for_lint from BUILD.gn files
The Chromium Roll into WebRTC isn't flowing
The first CL that caused the problem is https://webrtc-review.googlesource.com/c/src/+/175140/
The error is: ERROR at //examples/BUILD.gn:104:33: Assignment had no effect. android_manifest_for_lint = "androidapp/AndroidManifest.xml"
android_manifest_for_lint has ben removed so update BUILD files that use that feature to reflect this.
BUG=None
Change-Id: If526d9a4dd80cddca7f2c9dd7f67ba9efe3f1a84
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175661
Commit-Queue: Courtney Edwards <courtneyfe@google.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31325}
2020-05-19 13:23:25 +00:00
b914819944
Reduce alert spam in rtc_event_log_visualizer
...
Bug: webrtc:11564
Change-Id: I4fdd6284b35cedded4d8b623dc0b7f8e1534c495
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175649
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31324}
2020-05-19 13:22:20 +00:00
48b8279813
Refactor/reimplement RTC event log triage alerts.
...
- Moves AnalyzerConfig and helper functions IsAudioSsrc, IsVideoSsrc, IsRtxSsrc, GetStreamNam and GetLayerName to analyzer_common.h
- Moves log_segments() code to rtc_event_log_parser.h
- Moves TriageAlert/Notification code to a new file with a couple of minor fixes to make it less spammy.
Bug: webrtc:11566
Change-Id: Ib33941d8185f7382fc72ed65768e46015e0320de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174824
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31318}
2020-05-19 09:45:16 +00:00
c50976ace9
Revert "Remove android_manifest_for_lint from BUILD.gn files"
...
This reverts commit 340106ad4659faca563509016097a091bfb5289f.
Reason for revert: Broke internal project.
Original change's description:
> Remove android_manifest_for_lint from BUILD.gn files
>
> The Chromium Roll into WebRTC isn't flowing
> The first CL that caused the problem is https://webrtc-review.googlesource.com/c/src/+/175140/
> The error is: ERROR at //examples/BUILD.gn:104:33: Assignment had no effect. android_manifest_for_lint = "androidapp/AndroidManifest.xml"
> android_manifest_for_lint has ben removed so update BUILD files that use that feature to reflect this.
>
> BUG=None
>
> Change-Id: Ic3eb16eab8e4a4ab87daac9998d7a07373fec493
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175569
> Commit-Queue: Courtney Edwards <courtneyfe@google.com >
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#31299}
TBR=mbonadei@webrtc.org ,titovartem@webrtc.org ,courtneyfe@google.com ,courtneyfe@chromium.org
Change-Id: I6055b4363254d353d116805aac4ec63d7c5c7c59
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175622
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31303}
2020-05-18 13:23:09 +00:00
340106ad46
Remove android_manifest_for_lint from BUILD.gn files
...
The Chromium Roll into WebRTC isn't flowing
The first CL that caused the problem is https://webrtc-review.googlesource.com/c/src/+/175140/
The error is: ERROR at //examples/BUILD.gn:104:33: Assignment had no effect. android_manifest_for_lint = "androidapp/AndroidManifest.xml"
android_manifest_for_lint has ben removed so update BUILD files that use that feature to reflect this.
BUG=None
Change-Id: Ic3eb16eab8e4a4ab87daac9998d7a07373fec493
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175569
Commit-Queue: Courtney Edwards <courtneyfe@google.com >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31299}
2020-05-18 12:36:06 +00:00
e50c979811
Exclude frame_analyzer_host build on iOS.
...
Bug: webrtc:11474
Change-Id: I6d5bc2e079330e371e8199d5602b62a0e36fe75a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173721
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31112}
2020-04-20 21:53:54 +00:00
a2ce423efb
Total packet rate plots for event_log_visualizer.
...
Bug: b/152399961
Change-Id: I9fcd2e234f229cefc972149ab22ccd845a8e90ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172440
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Kristoffer Erlandsson <kerl@google.com >
Cr-Commit-Position: refs/heads/master@{#30963}
2020-04-01 13:14:24 +00:00
647968f7c9
Exclude frame_analyzer_host build on win.
...
No-Try: True
Bug: webrtc:11474
Change-Id: If8393410ff0d781c3aa4d5fceebdcc399f77f9e5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172585
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30962}
2020-04-01 11:43:37 +00:00
283c106c28
Add packet rate plots to event_log_visualizer.
...
Bug: b/152399961
Change-Id: I8dbc0166ed537c197f26a80275100fb3faa338f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172094
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Kristoffer Erlandsson <kerl@google.com >
Cr-Commit-Position: refs/heads/master@{#30942}
2020-03-30 14:46:41 +00:00
d4262dffa0
Chromium refactor: Replace "resources_dirs" with "sources"
...
Bug: chromium:1062263
Change-Id: I4b7b06cfeaf4cb655a0b3533dba25a77756bdcd0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171741
Commit-Queue: Andrew Grieve <agrieve@google.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30889}
2020-03-25 19:32:15 +00:00
2028a772df
Remove RtpPacketSendInfo.has_rtp_sequence_number
...
As far as I can tell, every call site already populates this field, so
we can now remove it.
Bug: webrtc:8975
Change-Id: I58515dd16d4ad8bf8872077b67a67f6e92e7b542
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171222
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30857}
2020-03-23 18:34:43 +00:00
b8e69efcee
Write protos as binary.
...
We need to write protos as "wb" and not "w", otherwise we get CRLF
on Windows which corrupts the proto.
Bug: chromium:1029452
Change-Id: Iabf841405134d7bc2523ac48219ca7cb9d8214c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170320
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30772}
2020-03-12 09:43:57 +00:00
0759249370
Fix 'all' build on Android platforms.
...
Example of failures when trying to build "all":
https://ci.chromium.org/p/webrtc/builders/try/android_arm64_rel/35549
Bug: webrtc:11411
Change-Id: Idf462c39eb499e5f6f7c971bce78c54d071f9871
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170113
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30753}
2020-03-11 08:29:06 +00:00
afa2e5f18c
Purge phoglund from most OWNERS files.
...
I'll hold on to the root OWNER for a bit longer for convenience.
Bug: None
Change-Id: I13303ba726fed612adc74008eeaaeadf9595e084
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170047
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30727}
2020-03-09 14:08:30 +00:00
8041b651a3
Add YUV to IVF video converter util
...
Bug: webrtc:10138
Change-Id: I79ca08c45a664c66b15a1ed0c1322719c9f5574d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161449
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30559}
2020-02-19 14:44:21 +00:00
4a14f4997c
Remove wildcard ownership for build files.
...
No-Try: True
Bug: webrtc:10381
Change-Id: I852d9a2da7e0c5c12f508a1c788b0b5753503aba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168769
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30558}
2020-02-19 14:05:46 +00:00
e52115a33e
Remove inactive OWNERS.
...
No-Try: True
Bug: webrtc:10381
Change-Id: I3b56c74d913a47e4297518005b0cb19de8fafbff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168421
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30556}
2020-02-19 13:37:36 +00:00
cad3e0e2fa
Replace DataSize and DataRate factories with newer versions
...
This is search and replace change:
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataSize::Bytes<\(.*\)>()/DataSize::Bytes(\1)/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataSize::bytes/DataSize::Bytes/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::BitsPerSec<\(.*\)>()/DataRate::BitsPerSec(\1)/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::BytesPerSec<\(.*\)>()/DataRate::BytesPerSec(\1)/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::KilobitsPerSec<\(.*\)>()/DataRate::KilobitsPerSec(\1)/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::bps/DataRate::BitsPerSec/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/DataRate::kbps/DataRate::KilobitsPerSec/g"
git cl format
Bug: webrtc:9709
Change-Id: I65aaca69474ba038c1fe2dd8dc30d3f8e7b94c29
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168647
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30545}
2020-02-18 16:09:50 +00:00
0c626afcf3
Use newer version of TimeDelta and TimeStamp factories in webrtc
...
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/TimeDelta::Micros<\(.*\)>()/TimeDelta::Micros(\1)/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/TimeDelta::Millis<\(.*\)>()/TimeDelta::Millis(\1)/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/TimeDelta::Seconds<\(.*\)>()/TimeDelta::Seconds(\1)/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/TimeDelta::us/TimeDelta::Micros/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/TimeDelta::ms/TimeDelta::Millis/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/TimeDelta::seconds/TimeDelta::Seconds/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/Timestamp::Micros<\(.*\)>()/Timestamp::Micros(\1)/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/Timestamp::Millis<\(.*\)>()/Timestamp::Millis(\1)/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/Timestamp::Seconds<\(.*\)>()/Timestamp::Seconds(\1)/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/Timestamp::us/Timestamp::Micros/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/Timestamp::ms/Timestamp::Millis/g"
find . -type f \( -name "*.h" -o -name "*.cc" \) | xargs sed -i -e "s/Timestamp::seconds/Timestamp::Seconds/g"
git cl format
Bug: None
Change-Id: I87469d2e4a38369654da839ab7c838215a7911e7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168402
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30491}
2020-02-10 12:21:17 +00:00
d4c3c3a454
Move video_replay under rtc_tools/.
...
As pointed out in [1], RTC public tools should live in rtc_tools.
[1] - https://webrtc-review.googlesource.com/c/src/+/168320/2#message-1f40103105ecb077aeec153c5270575138349a50
Bug: chromium:942546
Change-Id: Ic827d9b31ade9a32bf4ef24d020ef8c81d2c9a5b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168308
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30486}
2020-02-07 17:57:30 +00:00
a5cec55434
Make rtp_generator buildable from Chromium.
...
Bug: chromium:942546
Change-Id: I90d077eca55f6cbae119c576d1ba1ec456858377
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168245
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30470}
2020-02-06 12:47:14 +00:00
ccbe95fd8a
Reformat GN files.
...
`gn format` recently [1] changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.
Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.
CL generated with:
$ git ls-files | grep BUILD.gn | xargs gn format
$ gn format build_overrides/build.gni
$ gn format build_overrides/gtest.gni
$ gn format modules/audio_coding/audio_coding.gni
$ gn format webrtc.gni
$ gn format .gn
Plus a few manual changes to add exceptions for
"public_deps" (after changing these lines the presubmit
started to complain).
[1] - https://gn-review.googlesource.com/c/gn/+/6860
Bug: webrtc:11302
Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21 12:13:11 +00:00
cee751abff
Reland "Enable using a custom NetEqFactory in simulations"
...
This is a reland of 2a11b2451a4068746fa0c55fa210efd4a15e4423
There are no changes compared to the first attempt.
Original change's description:
> Enable using a custom NetEqFactory in simulations
>
> Bug: webrtc:11005
> Change-Id: I8a15f77953cbd3c29a75c7cfc77f926b138994b9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165580
> Commit-Queue: Ivo Creusen <ivoc@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30286}
TBR=kwiberg
Bug: webrtc:11005
Change-Id: I4aa377e05916bd23f8f63aece9d0e27731c80d3e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166465
Commit-Queue: Ivo Creusen <ivoc@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30319}
2020-01-20 12:46:34 +00:00
3f0bc2c176
Revert "Enable using a custom NetEqFactory in simulations"
...
This reverts commit 2a11b2451a4068746fa0c55fa210efd4a15e4423.
Reason for revert: Causes b/147826709
Original change's description:
> Enable using a custom NetEqFactory in simulations
>
> Bug: webrtc:11005
> Change-Id: I8a15f77953cbd3c29a75c7cfc77f926b138994b9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165580
> Commit-Queue: Ivo Creusen <ivoc@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30286}
TBR=kwiberg@webrtc.org ,ivoc@webrtc.org
Change-Id: I14a0bd6ad2a90f1686b8b1a78f18aea9325871fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11005
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166403
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Commit-Queue: Sandeep Siddhartha <sansid@google.com >
Cr-Commit-Position: refs/heads/master@{#30288}
2020-01-16 22:56:21 +00:00
2a11b2451a
Enable using a custom NetEqFactory in simulations
...
Bug: webrtc:11005
Change-Id: I8a15f77953cbd3c29a75c7cfc77f926b138994b9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165580
Commit-Queue: Ivo Creusen <ivoc@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30286}
2020-01-16 18:26:44 +00:00
71574f7f3b
Add data dependency to event_log_visualizer.
...
This .wav file is an implicit data dependency, this CL adds this
information to the build system.
Bug: None
Change-Id: Ia953e63d4658debce3cecb93bb1f3e749fe52f54
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166044
Reviewed-by: Ali Tofigh <alito@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30257}
2020-01-15 09:21:10 +00:00
2ea27968d3
Extract an interface from the perf results logger.
...
The new interface is called PerfTestResultWriter and is currently
implemented by PerfResultsLogger (renamed PerfTestGraphJsonWriter).
I plan to introduce a second implementation of the perf logger that
uses the new Histogram C++ API. I add a flag that chooses
between the two implementations so I can try it out (perhaps by
setting up a second, limited run of webrtc_perf_tests on the perf
bots that uses the new implementation). The histogram C++
implementation will come in the next patch.
As a side effect, I disentangled the plottable counter printer from
the perf result printer so it will work for both implementations.
The only thing they had in common was that both wrote JSON anyway.
See the bug for details on the new API.
Bug: chromium:1029452
Change-Id: Icb21b25ced08ea73aeecd221e9d51f2adf3dab1b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165389
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30243}
2020-01-14 06:05:02 +00:00
65bbcabe2f
[Android] Replace java_files with sources
...
Replace all usages of java_files with sources in gn files, and
automatically format.
This is in preparation for java_files being completely removed upstream
in favor of sources.
NOPRESUBMIT=true
Bug: chromium:1035074
Change-Id: Ib9a698740b7ad26a127031d90321c7ae2feb59bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/163161
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Natalie Chouinard <chouinard@google.com >
Cr-Commit-Position: refs/heads/master@{#30135}
2020-01-02 20:08:20 +00:00
89aaedac12
Move audioproc_f to rtc_tools.
...
The motivation in https://webrtc-review.googlesource.com/c/src/+/32340/3 applies here as well. We
would like to use this tool downstream.
Bug: None
Change-Id: Id5b23f792679ab9c07294bfb8e53119c423044b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161681
Commit-Queue: Daniel Johansson <dajo@webrtc.org >
Reviewed-by: Daniel Johansson <dajo@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30051}
2019-12-10 12:08:56 +00:00
33f9d2b383
Migrate WebRTC on FrameGeneratorInterface and remove FrameGenerator class
...
Bug: webrtc:10138
Change-Id: If85290581a72f81cf60181de7a7134cc9db7716e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161327
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30033}
2019-12-07 00:54:26 +00:00
c7a3b08f07
Prefix ENABLE_RTC_EVENT_LOG with WEBRTC_.
...
Since this macro can be considered public, it makes sense to prefix it
with WEBRTC_ (also to avoid potential conflicts with client code).
This CL also removes some definitions of this macro in order to define
it only where it is strictly needed (it is only used in a .cc file).
Bug: webrtc:11142
Change-Id: Idce7389301e71d8434e238b3cf4ceaa9cf97cd87
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161008
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29957}
2019-11-29 09:45:50 +00:00
3574d05360
EventLogVisualizer pacer delay plot fix.
...
Bug: none
Change-Id: I86bcad68e522b2a18937cc92c051d3d0feb46a07
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159960
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29828}
2019-11-19 10:23:31 +00:00
