zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
33,325 Commits 1 Branch 0 Tags
93faab1b51a11cf997260c84a57565001cf9c9c6
Commit Graph

22 Commits

Author SHA1 Message Date
Björn Terelius
00c12f6779 Add logging of decoded video frames. 
This CL adds the possibility to log metainformation about
decoded frames in RTC event log, including encoding parsing
and tests. It will be wired up in a followup CL.


Bug: webrtc:8802
Change-Id: Ied598b266513d0f63fce0484d741af1782607e74
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/181061
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31873}
 2020-08-06 17:33:24 +00:00
Sebastian Jansson
0a5ed896e2 Adds remote estimates to rtc event log. 
Bug: webrtc:10742
Change-Id: I0db998a05492603fcdeedca780d9ee3d64aa00d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151651
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29233}
 2019-09-19 09:22:37 +00:00
Sebastian Jansson
166b45db26 Adds route changes in event logs. 
Bug: webrtc:10614
Change-Id: Ifd859c977fc66cb606914ddb38a3fb3618e3ad90
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135952
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27924}
 2019-05-13 10:41:40 +00:00
Piotr (Peter) Slatala
5e2aad1c95 Support GenericPacketReceived/Sent/AckReceived event logs. 
This change does not include receive_timestamps for ACKs, because there is 1 problem.
That problem will be resolved in a separate change.

I am getting receive_timestamp errors that have to do with delta compression with optional fields.
Two failure modes that I noticed:
1) the base event does not have the timestamp: it crashes with length validation
# Check failed: base <= MaxUnsignedValueOfBitWidth(params_.value_width_bits()) (1820716 vs. 131071)
2) all events are null, it crashes with assert that X events were expected, but no events were deserialized.


Bug: webrtc:9719
Change-Id: I5d1bbb95dfd15ca7321667aad5e4d89c085e9c06
Reviewed-on: https://webrtc-review.googlesource.com/c/122360
Commit-Queue: Peter Slatala <psla@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26668}
 2019-02-13 17:06:22 +00:00
Zach Stein
b3033c448f Add transaction id to candidate pair event log parser and encoder. 
Covered by these tests:
RandomSeeds/RtcEventLogEncoderTest.RtcEventIceCandidatePair/*
RtcEventLogTest/RtcEventLogSession.*

Bug: webrtc:9972
Change-Id: I05473176357804e7ad0dedb51a659ab9481a4e4a
Reviewed-on: https://webrtc-review.googlesource.com/c/110103
Commit-Queue: Zach Stein <zstein@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25867}
 2018-12-01 01:15:29 +00:00
Zach Stein
846dfdfd01 Log DTLS writable changes to RtcEventLog 
Bug: webrtc:9972
Change-Id: I8d29dcbc200bd0aad7f4c2600459c4d344c61bbb
Reviewed-on: https://webrtc-review.googlesource.com/c/111453
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Zach Stein <zstein@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25866}
 2018-12-01 01:00:28 +00:00
Zach Stein
c64078fdc0 Log DTLS state changes to RtcEventLog 
Bug: webrtc:9972
Change-Id: Icb2cdda87c1c42607ed06653e053699532f25e84
Reviewed-on: https://webrtc-review.googlesource.com/c/111023
Commit-Queue: Zach Stein <zstein@webrtc.org>
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25832}
 2018-11-28 19:49:29 +00:00
Bjorn Terelius
2c977b4cc5 Remove RSID from stream configs in new event log format. 
RSID is only useful if we store the RSID header extension.
Since we don't do that at the moment, there is no need to
store RSID in the stream configs.

Bug: webrtc:8111
Change-Id: I978f335d05984346f225c4781a8bfaa228f3f4c8
Reviewed-on: https://webrtc-review.googlesource.com/c/111759
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25763}
 2018-11-22 17:54:06 +00:00
Bjorn Terelius
e78b465d45 Add version and UTC time fields to RTC event log. 
Bug: webrtc:8111
Change-Id: I843e1f8e50e4d4faf74819e0104aeb4fb869b834
Reviewed-on: https://webrtc-review.googlesource.com/c/110721
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25658}
 2018-11-15 14:32:43 +00:00
Elad Alon
eb809f30d1 Event logs - separate audio_level and voice_activity 
Bug: webrtc:8111
Change-Id: I44d81c5b4f5b854e8accd84521fbbd7b50228903
Reviewed-on: https://webrtc-review.googlesource.com/c/109571
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25589}
 2018-11-10 01:41:28 +00:00
Elad Alon
56a4b32398 Rename fields in rtc_event_log2.proto 
1. s/deltas_ms/ms-deltas
2. s/deltas_bps/bps_deltas
3. s/raw_packet_deltas/raw_packet_blobs

Bug: webrtc:8111
Change-Id: Ib2f7457275e0b930a6aa73d628a707676c74a2a4
Reviewed-on: https://webrtc-review.googlesource.com/c/109142
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25587}
 2018-11-09 22:29:43 +00:00
Elad Alon
d95b0a2fbd Use delta-encoding in new WebRTC event logs 
The new event log format makes use of delta encoding to compress
parts of the log.

Bug: webrtc:8111
Change-Id: I7bec839555323a7537dcec831d4ac1d5eb109932
Reviewed-on: https://webrtc-review.googlesource.com/c/109161
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25584}
 2018-11-09 16:39:16 +00:00
Bjorn Terelius
c35096d975 Reland "Encode RTC event logs in new format." 
This is a reland of ece3c228a2cbd1c1b05eee3a7f55dbb6f020acbc

Original change's description:
> Encode RTC event logs in new format.
> 
> This CL adds the encoder and wires it up to the event log.
> Parser and unit tests are uploaded in a separate CL.
> 
> Bug: webrtc:8111
> Change-Id: I6470003e55c2c4006cd8349a2c4bdc3f9491d869
> Reviewed-on: https://webrtc-review.googlesource.com/c/106708
> Commit-Queue: Björn Terelius <terelius@webrtc.org>
> Reviewed-by: Elad Alon <eladalon@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#25333}

Bug: webrtc:8111
Change-Id: I22eeca36d6b1f7cfa1ac65347571ebe33cecc1fc
Reviewed-on: https://webrtc-review.googlesource.com/c/108082
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25382}
 2018-10-26 09:20:02 +00:00
Mirko Bonadei
825f83b99e Revert "Encode RTC event logs in new format." 
This reverts commit ece3c228a2cbd1c1b05eee3a7f55dbb6f020acbc.

Reason: Breaks downstream project.

Bug: webrtc:8111
Change-Id: Ia264802b35a576d74b8a249ed742a8177e5cbe24
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/107721
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25340}
 2018-10-24 13:18:03 +00:00
Bjorn Terelius
ece3c228a2 Encode RTC event logs in new format. 
This CL adds the encoder and wires it up to the event log.
Parser and unit tests are uploaded in a separate CL.

Bug: webrtc:8111
Change-Id: I6470003e55c2c4006cd8349a2c4bdc3f9491d869
Reviewed-on: https://webrtc-review.googlesource.com/c/106708
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25333}
 2018-10-24 12:21:43 +00:00
Bjorn Terelius
d932fba3bc Track padding and header size in log event. 
Padding size and header size are not part of the header, but we still
want to log them. Add the values as separate fields to the log events.

Bug: webrtc:8111
Change-Id: I8dfa2ccafe679f96b8911b538a8512b0170bc642
Reviewed-on: https://webrtc-review.googlesource.com/c/106321
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25237}
 2018-10-17 15:52:17 +00:00
Bjorn Terelius
a1c9312616 Update proto for new event log format. 
Bug: webrtc:8111
Change-Id: I4c62ca56fb93a741361c337ef681da39d504d7ec
Reviewed-on: https://webrtc-review.googlesource.com/c/106342
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25211}
 2018-10-16 14:22:31 +00:00
Mirko Bonadei
b3c210fa56 Reland "New protobuf format for event log."""" 
This reverts commit 6cfbc35ad7e6c64874c1e2dbd58b8d7c4ab3a679.

Reason for revert: Fixing downstream projects.

Original change's description:
> Revert "Revert "Revert "New protobuf format for event log."""
> 
> This reverts commit ef8f42040367b3809295a007d7eeeff4526e1b39.
> 
> Reason for revert: New problems with downstream project.
> 
> Original change's description:
> > Revert "Revert "New protobuf format for event log.""
> > 
> > This reverts commit 546373fc66e24d041e8eb8ffd2fc522847d841d1.
> > 
> > Reason for revert: Downstream project fixed.
> > 
> > Original change's description:
> > > Revert "New protobuf format for event log."
> > > 
> > > This reverts commit 99463c14dbbc88732f0991cb30e7bbfcdaeb3cdc.
> > > 
> > > Reason for revert: Speculative revert for downstream project breakage.
> > > 
> > > Original change's description:
> > > > New protobuf format for event log.
> > > > 
> > > > Bug: webrtc:6295
> > > > Change-Id: Ie20a2808a4f076b05fb6195f4fed73215f6fd3b2
> > > > Reviewed-on: https://webrtc-review.googlesource.com/8880
> > > > Commit-Queue: Björn Terelius <terelius@webrtc.org>
> > > > Reviewed-by: Per Kjellander <perkj@webrtc.org>
> > > > Reviewed-by: Dino Radaković <dinor@webrtc.org>
> > > > Cr-Commit-Position: refs/heads/master@{#21291}
> > > 
> > > TBR=terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org
> > > 
> > > Change-Id: Ic319170a7a777002ca29248d102cb4e26966d5ae
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: webrtc:6295
> > > Reviewed-on: https://webrtc-review.googlesource.com/33400
> > > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> > > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> > > Cr-Commit-Position: refs/heads/master@{#21292}
> > 
> > TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org
> > 
> > Change-Id: I9e96e5007d0447e63178d47c7330488b2a8f2b6f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:6295
> > Reviewed-on: https://webrtc-review.googlesource.com/33440
> > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#21296}
> 
> TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org
> 
> Change-Id: I4eb15c809f67af13ffa7b7df6eb06088af21f63f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:6295
> Reviewed-on: https://webrtc-review.googlesource.com/33480
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21297}

TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org

Change-Id: I7895575f2b6e4ec2c36296fe81a7596147158601
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:6295
Reviewed-on: https://webrtc-review.googlesource.com/33520
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21299}
 2017-12-15 16:13:48 +00:00
Rasmus Brandt
6cfbc35ad7 Revert "Revert "Revert "New protobuf format for event log.""" 
This reverts commit ef8f42040367b3809295a007d7eeeff4526e1b39.

Reason for revert: New problems with downstream project.

Original change's description:
> Revert "Revert "New protobuf format for event log.""
> 
> This reverts commit 546373fc66e24d041e8eb8ffd2fc522847d841d1.
> 
> Reason for revert: Downstream project fixed.
> 
> Original change's description:
> > Revert "New protobuf format for event log."
> > 
> > This reverts commit 99463c14dbbc88732f0991cb30e7bbfcdaeb3cdc.
> > 
> > Reason for revert: Speculative revert for downstream project breakage.
> > 
> > Original change's description:
> > > New protobuf format for event log.
> > > 
> > > Bug: webrtc:6295
> > > Change-Id: Ie20a2808a4f076b05fb6195f4fed73215f6fd3b2
> > > Reviewed-on: https://webrtc-review.googlesource.com/8880
> > > Commit-Queue: Björn Terelius <terelius@webrtc.org>
> > > Reviewed-by: Per Kjellander <perkj@webrtc.org>
> > > Reviewed-by: Dino Radaković <dinor@webrtc.org>
> > > Cr-Commit-Position: refs/heads/master@{#21291}
> > 
> > TBR=terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org
> > 
> > Change-Id: Ic319170a7a777002ca29248d102cb4e26966d5ae
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:6295
> > Reviewed-on: https://webrtc-review.googlesource.com/33400
> > Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> > Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#21292}
> 
> TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org
> 
> Change-Id: I9e96e5007d0447e63178d47c7330488b2a8f2b6f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:6295
> Reviewed-on: https://webrtc-review.googlesource.com/33440
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21296}

TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org

Change-Id: I4eb15c809f67af13ffa7b7df6eb06088af21f63f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:6295
Reviewed-on: https://webrtc-review.googlesource.com/33480
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21297}
 2017-12-15 15:25:59 +00:00
Rasmus Brandt
ef8f420403 Revert "Revert "New protobuf format for event log."" 
This reverts commit 546373fc66e24d041e8eb8ffd2fc522847d841d1.

Reason for revert: Downstream project fixed.

Original change's description:
> Revert "New protobuf format for event log."
> 
> This reverts commit 99463c14dbbc88732f0991cb30e7bbfcdaeb3cdc.
> 
> Reason for revert: Speculative revert for downstream project breakage.
> 
> Original change's description:
> > New protobuf format for event log.
> > 
> > Bug: webrtc:6295
> > Change-Id: Ie20a2808a4f076b05fb6195f4fed73215f6fd3b2
> > Reviewed-on: https://webrtc-review.googlesource.com/8880
> > Commit-Queue: Björn Terelius <terelius@webrtc.org>
> > Reviewed-by: Per Kjellander <perkj@webrtc.org>
> > Reviewed-by: Dino Radaković <dinor@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#21291}
> 
> TBR=terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org
> 
> Change-Id: Ic319170a7a777002ca29248d102cb4e26966d5ae
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:6295
> Reviewed-on: https://webrtc-review.googlesource.com/33400
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21292}

TBR=brandtr@webrtc.org,terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org

Change-Id: I9e96e5007d0447e63178d47c7330488b2a8f2b6f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:6295
Reviewed-on: https://webrtc-review.googlesource.com/33440
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21296}
 2017-12-15 14:37:07 +00:00
Rasmus Brandt
546373fc66 Revert "New protobuf format for event log." 
This reverts commit 99463c14dbbc88732f0991cb30e7bbfcdaeb3cdc.

Reason for revert: Speculative revert for downstream project breakage.

Original change's description:
> New protobuf format for event log.
> 
> Bug: webrtc:6295
> Change-Id: Ie20a2808a4f076b05fb6195f4fed73215f6fd3b2
> Reviewed-on: https://webrtc-review.googlesource.com/8880
> Commit-Queue: Björn Terelius <terelius@webrtc.org>
> Reviewed-by: Per Kjellander <perkj@webrtc.org>
> Reviewed-by: Dino Radaković <dinor@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21291}

TBR=terelius@webrtc.org,perkj@webrtc.org,dinor@webrtc.org

Change-Id: Ic319170a7a777002ca29248d102cb4e26966d5ae
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:6295
Reviewed-on: https://webrtc-review.googlesource.com/33400
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21292}
 2017-12-15 13:47:17 +00:00
Bjorn Terelius
99463c14db New protobuf format for event log. 
Bug: webrtc:6295
Change-Id: Ie20a2808a4f076b05fb6195f4fed73215f6fd3b2
Reviewed-on: https://webrtc-review.googlesource.com/8880
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Dino Radaković <dinor@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21291}
 2017-12-15 12:42:06 +00:00