Commit Graph

6 Commits

Author SHA1 Message Date
402ceffff1 sctp: Reduce logging level for common calls
Reduced the level so that the library can be run with INFO level without
a lot of spam. VERBOSE is still reserved for frequent logs.

Also, using WARNING for logs that are not fatal and which can easily
be triggered by the user.

Bug: webrtc:12614
Change-Id: If09c302b2b5bfc002471f86a8aeb74ba1172c705
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/219465
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34054}
2021-05-19 13:22:43 +00:00
6174173f81 sctp: dcsctp: Print SCTP packets to logs
When verbose logs are enabled, SCTP packets will be dumped to debug
logs, allowing text2pcap to be used to generate PCAP files.

First start Chrome with verbose logs, and write those to file:

  /path/to/chrome --enable-logging=stderr --v=4 2> out.log

Then extract the SCTP_PACKET traces and run text2pcap:

  grep SCTP_PACKET out.log > sctp.log

  text2pcap -n -i 132 -D -t '%H:%M:%S.' sctp.log sctp.pcapng

You may have to cut away more from the beginning if the debug logs
contain additional timestamps and more, e.g. like:

  grep SCTP_PACKET out.log | cut -d ' ' -f 2- > sctp.log

Note that if there are multiple RTCPeerConnection objects created, each
will print out their packets to log, so to filter for a specific one:

  grep "SCTP_PACKET DcSctpTransport0" out.log > sctp.log

Bug: webrtc:12614
Change-Id: Ibbceaf33719d09e7606247cb0496ddd827ea58bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218200
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33999}
2021-05-12 15:17:17 +00:00
78d5859bde sctp: dcsctp: Remove log statement
This log statement is quite spammy and isn't of any help, so remove it.

Bug: webrtc:12614
Change-Id: Ia087228e0a3f602d558fcb7cbd9ec5295f35dcb9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218202
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33981}
2021-05-11 14:36:25 +00:00
d95b149141 datachannel: Merge SendDataParams and DMT types with webrtc equivalent
cricket::SendDataParams is replaced by webrtc::SendDataParams.
cricket::DataMessageType is replaced by webrtc::DataMessageType.
The sid member from cricket::SendDataParams is now passed as an argument
to functions that used one when necessary.

Bug: webrtc:7484
Change-Id: Ia4a89c9651fb54ab9a084a6098d49130b6319e1b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217761
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33966}
2021-05-10 10:31:48 +00:00
5183f00d3a datachannel: Make SendDataParams reliability fields optional<int>
It doesn't make sense to use negative values or 0 to disable the
feature, so we use an optional int value.
Values bigger than 65535 are clamped down.

Bug: webrtc:12730
Change-Id: I6bd9cd92f7d0a70a78cf5a7c91dca52c28d08ba1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217760
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33954}
2021-05-07 17:09:54 +00:00
a6983c6ea2 sctp: Add DcsctpTransport based on dcSCTP
Bug: webrtc:12614
Change-Id: Ie710621610fff9f8bb6c7d800419675892d6a70c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215680
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33935}
2021-05-06 09:38:49 +00:00