61a7b141eb
Removing conditional visibility.
...
Conditional visibility is complex to maintain and it is not well
supported by other build systems.
This CL removes it and falls back on the more relaxed visibility value
("*" in this case).
It is not a problem because the targets that are using conditional
visibility are all marked as "testonly" and this is probably enough to
keep the build graph clean.
Bug: None
Change-Id: I2d2b5ac9a02d08c2863950116db455976ee1459c
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/14902
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20658}
2017-11-13 15:39:11 +00:00
fbb3b7d004
Reland: "Make javac warnings errors for WebRTC targets."
...
This reverts commit 2bad72a27329ff30ceb9479253f5eb3d21888d25.
Reason for revert: Fixing downstream projects (take 2).
Original change's description:
> Reland "Revert "Make javac warnings errors for WebRTC targets.""
>
> This is a reland of 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74
> Original change's description:
> > Revert "Make javac warnings errors for WebRTC targets."
> >
> > This reverts commit 19b761403c3522902d69d61179f4d184e3632f79.
> >
> > Reason for revert: Breaking internal builds
> >
> > Original change's description:
> > > Make javac warnings errors for WebRTC targets.
> > >
> > > Adds new rtc_* templates for Android targets to allow specifying
> > > default values that affect WebRTC targets.
> > >
> > > Bug: webrtc:6597
> > > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1
> > > Reviewed-on: https://webrtc-review.googlesource.com/15103
> > > Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
> > > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#20567}
> >
> TBR=phoglund@webrtc.org ,sakal@webrtc.org
> >
> > Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:6597
> > Reviewed-on: https://webrtc-review.googlesource.com/20740
> > Reviewed-by: Lu Liu <lliuu@webrtc.org >
> > Commit-Queue: Lu Liu <lliuu@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#20571}
>
> Bug: webrtc:6597
> Change-Id: Icfb5ded46ce76b674bae67bfa02054b4ec52bb0f
> Reviewed-on: https://webrtc-review.googlesource.com/20800
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20577}
TBR=phoglund@webrtc.org ,ehmaldonado@webrtc.org ,mbonadei@webrtc.org ,sakal@webrtc.org ,lliuu@webrtc.org
Change-Id: Id3713c1885318741711987ae642a269a9ca5bb85
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:6597
Reviewed-on: https://webrtc-review.googlesource.com/18441
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20588}
2017-11-07 15:36:46 +00:00
2bad72a273
Reland "Revert "Make javac warnings errors for WebRTC targets.""
...
This is a reland of 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74
Original change's description:
> Revert "Make javac warnings errors for WebRTC targets."
>
> This reverts commit 19b761403c3522902d69d61179f4d184e3632f79.
>
> Reason for revert: Breaking internal builds
>
> Original change's description:
> > Make javac warnings errors for WebRTC targets.
> >
> > Adds new rtc_* templates for Android targets to allow specifying
> > default values that affect WebRTC targets.
> >
> > Bug: webrtc:6597
> > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1
> > Reviewed-on: https://webrtc-review.googlesource.com/15103
> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
> > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#20567}
>
TBR=phoglund@webrtc.org ,sakal@webrtc.org
>
> Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:6597
> Reviewed-on: https://webrtc-review.googlesource.com/20740
> Reviewed-by: Lu Liu <lliuu@webrtc.org >
> Commit-Queue: Lu Liu <lliuu@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20571}
Bug: webrtc:6597
Change-Id: Icfb5ded46ce76b674bae67bfa02054b4ec52bb0f
Reviewed-on: https://webrtc-review.googlesource.com/20800
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20577}
2017-11-07 01:31:45 +00:00
a1a475a5b6
Revert "Revert "Make javac warnings errors for WebRTC targets.""
...
This reverts commit 098d24c3c18f4b1fd043d7ba716d7601f0ce2b74.
Reason for revert: Fixing downstream projects.
Original change's description:
> Revert "Make javac warnings errors for WebRTC targets."
>
> This reverts commit 19b761403c3522902d69d61179f4d184e3632f79.
>
> Reason for revert: Breaking internal builds
>
> Original change's description:
> > Make javac warnings errors for WebRTC targets.
> >
> > Adds new rtc_* templates for Android targets to allow specifying
> > default values that affect WebRTC targets.
> >
> > Bug: webrtc:6597
> > Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1
> > Reviewed-on: https://webrtc-review.googlesource.com/15103
> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
> > Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#20567}
>
> TBR=phoglund@webrtc.org ,sakal@webrtc.org
>
> Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:6597
> Reviewed-on: https://webrtc-review.googlesource.com/20740
> Reviewed-by: Lu Liu <lliuu@webrtc.org >
> Commit-Queue: Lu Liu <lliuu@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20571}
TBR=phoglund@webrtc.org ,sakal@webrtc.org ,lliuu@webrtc.org
Change-Id: I3f0289c6ddc1930b1c92f653a61eff3f6a2bba30
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:6597
Reviewed-on: https://webrtc-review.googlesource.com/20741
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20572}
2017-11-06 20:30:58 +00:00
098d24c3c1
Revert "Make javac warnings errors for WebRTC targets."
...
This reverts commit 19b761403c3522902d69d61179f4d184e3632f79.
Reason for revert: Breaking internal builds
Original change's description:
> Make javac warnings errors for WebRTC targets.
>
> Adds new rtc_* templates for Android targets to allow specifying
> default values that affect WebRTC targets.
>
> Bug: webrtc:6597
> Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1
> Reviewed-on: https://webrtc-review.googlesource.com/15103
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
> Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20567}
TBR=phoglund@webrtc.org ,sakal@webrtc.org
Change-Id: I6d3ff5604b3d4307765d3a65adb783f89fcc974c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:6597
Reviewed-on: https://webrtc-review.googlesource.com/20740
Reviewed-by: Lu Liu <lliuu@webrtc.org >
Commit-Queue: Lu Liu <lliuu@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20571}
2017-11-06 19:58:38 +00:00
19b761403c
Make javac warnings errors for WebRTC targets.
...
Adds new rtc_* templates for Android targets to allow specifying
default values that affect WebRTC targets.
Bug: webrtc:6597
Change-Id: Ie529bfc8500d1e785b8a59dba7078b5f88ccfcd1
Reviewed-on: https://webrtc-review.googlesource.com/15103
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20567}
2017-11-06 15:59:06 +00:00
bb547203bf
Moving src/webrtc into src/.
...
In order to eliminate the WebRTC Subtree mirror in Chromium,
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00