86314cfb5d
Cleaning up C++14 move into lambda TODOs.
...
Bug: webrtc:10945
Change-Id: I4d2f358b0e33b37e4b4f7bfcf3f6cd55e8d46bf9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153240
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29212}
2019-09-17 19:18:26 +00:00
317a1f09ed
Use std::make_unique instead of absl::make_unique.
...
WebRTC is now using C++14 so there is no need to use the Abseil version
of std::make_unique.
This CL has been created with the following steps:
git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt
git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt
git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt
diff --new-line-format="" --unchanged-line-format="" \
/tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \
uniq > /tmp/only_make_unique.txt
diff --new-line-format="" --unchanged-line-format="" \
/tmp/only_make_unique.txt /tmp/memory.txt | \
xargs grep -l "absl/memory" > /tmp/add-memory.txt
git grep -l "\babsl::make_unique\b" | \
xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g"
git checkout PRESUBMIT.py abseil-in-webrtc.md
cat /tmp/add-memory.txt | \
xargs sed -i \
's/#include "absl\/memory\/memory.h"/#include <memory>/g'
git cl format
# Manual fix order of the new inserted #include <memory>
cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \
xargs sed -i '/#include "absl\/memory\/memory.h"/d'
git ls-files | grep BUILD.gn | \
xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d'
python tools_webrtc/gn_check_autofix.py \
-m tryserver.webrtc -b linux_rel
# Repead the gn_check_autofix step for other platforms
git ls-files | grep BUILD.gn | \
xargs sed -i 's/absl\/memory:memory/absl\/memory/g'
git cl format
Bug: webrtc:10945
Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29209}
2019-09-17 15:47:29 +00:00
6fcdbc1d8d
Store timestamp for each sample to be able to plot them in future
...
Bug: webrtc:10138
Change-Id: Ifde909ac4f92e5d0f089e5d2f6fc544c9ae97db1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151652
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29154}
2019-09-11 11:13:49 +00:00
29ab487ea7
Revert "Removes string support in field trial parser."
...
This reverts commit e74156f7d05cf3c9858e554789b3f4bb3b93cc19.
Reason for revert: This turned out to be useful :)
Original change's description:
> Removes string support in field trial parser.
>
> This prepares for simplifying the behavior of optionals so that
> an empty parameter value resets the optional.
>
> Bug: webrtc:9883
> Change-Id: I8ef8fe9698235044cac66bc4a587abe874c8f854
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150883
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29061}
TBR=terelius@webrtc.org ,srte@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:9883
Change-Id: Idbb4061f4b423987e62f3a9ad9bee2410e2cec96
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152383
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29137}
2019-09-10 14:39:55 +00:00
2b9dba3d9c
Implement stable rate support in SimulcastRateAllocator
...
Bug: webrtc:10126
Change-Id: I2ea8d27b0bd6f7ffd1ebbba451bd1ce1f2eee3d9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151121
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29097}
2019-09-06 11:17:30 +00:00
50b0baf510
[tsan] Guard TestStatictics against concurrent access.
...
This CL quiets ThreadSanitizer for EventTracerTest.ScopedTraceEvent unit test.
Bug: webrtc:10943
Change-Id: Ifaec1ab37b85f091872f55e630189387f8df4401
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151309
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Yves Gerey <yvesg@google.com >
Cr-Commit-Position: refs/heads/master@{#29090}
2019-09-06 09:00:51 +00:00
c2accf2de5
[tsan] Guard OwnerThread against concurrent access.
...
Prevent potential concurrent access of OwnerThread::has_run_ from:
* Main thread via HasRun()
* Signal thread via Run()
when running SignalThreadTest.OwnerThreadGoesAway.
Bug: webrtc:9855
Change-Id: I8951026a64794c085b4ac799ed4b74521b97f42a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151760
Commit-Queue: Yves Gerey <yvesg@google.com >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29087}
2019-09-06 03:03:39 +00:00
cf9cbf5edb
Add support for stable bitrate target in SvcRateAllocator
...
Bug: webrtc:10126
Change-Id: I1362d183bb91510db4e2763a779bcdf681d855ef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149069
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29066}
2019-09-04 14:22:43 +00:00
e74156f7d0
Removes string support in field trial parser.
...
This prepares for simplifying the behavior of optionals so that
an empty parameter value resets the optional.
Bug: webrtc:9883
Change-Id: I8ef8fe9698235044cac66bc4a587abe874c8f854
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150883
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29061}
2019-09-04 11:26:24 +00:00
9f00f0e533
Add support for unsigned parameters in FieldTrialParser
...
Bug: webrtc:10932
Change-Id: I3f56244a6be532065e4096cf1a289e27a032bc44
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150886
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29018}
2019-08-30 08:23:37 +00:00
022a7c8d49
Fix HexEncodeTest.TestZeroLengthNoDelimiter with enable_iterator_debugging=true
...
Fix HexEncodeTest.TestZeroLengthNoDelimiter with enable_iterator_debugging=true,
use_custom_libcxx=false on Windows.
When passed empty string, hex_encode_with_delimiter would dereference
std::string::end() iterator in expression &*s.begin();
Bug: webrtc:10927
Change-Id: I27ce5fecf1f2a5c49a1b85bb94e1dcc92c4c3697
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150651
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Yves Gerey <yvesg@google.com >
Commit-Queue: Kimmo Kinnunen FI <kkinnunen@nvidia.com >
Cr-Commit-Position: refs/heads/master@{#29009}
2019-08-29 14:16:23 +00:00
da2f4a3e0d
Remove stale TODO from rtc_base/checks.h.
...
No-Try: True
Bug: webrtc:10198
Change-Id: I8dee808c399c2a4a4922ec23a42bc0916dd32f52
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150796
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29006}
2019-08-29 13:19:26 +00:00
5e8ddc360b
Reland "Delete mac_utils.h and mac_utils.cc"
...
This is a reland of ada8e17125d2124f5bcdc1558182ce95d6311d93
Original change's description:
> Delete mac_utils.h and mac_utils.cc
>
> They defined two functions: ToUtf16 and ToUtf8. The former was unused,
> and the latter is moved to
> modules/desktop_capture/mac/window_list_utils.cc, the only user.
>
> Tbr: sergeyu@chromium.org
> Bug: None
> Change-Id: Ib8a513da42e43ba8d41a2de4c1645b3f48448dc9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148531
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Reviewed-by: Sergey Ulanov <sergeyu@google.com >
> Cr-Commit-Position: refs/heads/master@{#28913}
Tbr: kthelgason@webrtc.org
Bug: None
Change-Id: Icda3a2d6e98cfcaf8618035c248104c234e809ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150109
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28979}
2019-08-28 09:30:32 +00:00
30ab015fc9
BalancedDegradationSettings: add min bitrate configuration for resolution.
...
Add separate setting for configuring min bitrate that only applies when
adapting up in resolution.
Bug: none
Change-Id: I83d33ac3110a22602065b8d83130e3f619cb1eba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150329
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Mirta Dvornicic <mirtad@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28970}
2019-08-27 11:05:10 +00:00
adfb4f7938
Add ability to parse stable bwe experiment settings
...
Bug: webrtc:10126
Change-Id: If90aa2303b19d1ba9f9c53060e423ab1e6677ceb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149174
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28960}
2019-08-26 15:31:19 +00:00
4869bd6309
Add method CanAdaptUp based on bitrate to BalancedDegradationSettings.
...
Bug: none
Change-Id: Ibeded1f7193384a8ae5bd3f2ce4ccaa4c7db7290
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150333
Reviewed-by: Mirta Dvornicic <mirtad@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28957}
2019-08-26 12:48:35 +00:00
b6b4deee49
Fix flake in SamplesStatsCounterTest.FullSimpleTest
...
Bug: webrtc:10138
Change-Id: Ide99513bda6098fffe373467125bfdacd85cee54
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150112
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28946}
2019-08-23 11:56:02 +00:00
a2dae38ee7
Revert "Reland "Delete mac_utils.h and mac_utils.cc""
...
This reverts commit df578330b8a0b1a003a37ca34253e7344caf17f4.
Reason for revert: Still results in link errors for chromium on mac.
Original change's description:
> Reland "Delete mac_utils.h and mac_utils.cc"
>
> This is a reland of ada8e17125d2124f5bcdc1558182ce95d6311d93
>
> Chromium link error should be fixed with
> https://chromium-review.googlesource.com/c/chromium/src/+/1762071
>
> Original change's description:
> > Delete mac_utils.h and mac_utils.cc
> >
> > They defined two functions: ToUtf16 and ToUtf8. The former was unused,
> > and the latter is moved to
> > modules/desktop_capture/mac/window_list_utils.cc, the only user.
> >
> > Tbr: sergeyu@chromium.org
> > Bug: None
> > Change-Id: Ib8a513da42e43ba8d41a2de4c1645b3f48448dc9
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148531
> > Commit-Queue: Niels Moller <nisse@webrtc.org >
> > Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> > Reviewed-by: Sergey Ulanov <sergeyu@google.com >
> > Cr-Commit-Position: refs/heads/master@{#28913}
>
> Tbr: kthelgason@webrtc.org
> Bug: None
> Change-Id: If6d186d565c73e36ddb81b3ff05f6de6c9201326
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149831
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28934}
TBR=zijiehe@chromium.org ,nisse@webrtc.org ,kthelgason@webrtc.org ,sergeyu@chromium.org
Change-Id: I295cd23e63e17186f4c3c857ac0242467b7a68bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150107
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28937}
2019-08-22 09:58:31 +00:00
df578330b8
Reland "Delete mac_utils.h and mac_utils.cc"
...
This is a reland of ada8e17125d2124f5bcdc1558182ce95d6311d93
Chromium link error should be fixed with
https://chromium-review.googlesource.com/c/chromium/src/+/1762071
Original change's description:
> Delete mac_utils.h and mac_utils.cc
>
> They defined two functions: ToUtf16 and ToUtf8. The former was unused,
> and the latter is moved to
> modules/desktop_capture/mac/window_list_utils.cc, the only user.
>
> Tbr: sergeyu@chromium.org
> Bug: None
> Change-Id: Ib8a513da42e43ba8d41a2de4c1645b3f48448dc9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148531
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Reviewed-by: Sergey Ulanov <sergeyu@google.com >
> Cr-Commit-Position: refs/heads/master@{#28913}
Tbr: kthelgason@webrtc.org
Bug: None
Change-Id: If6d186d565c73e36ddb81b3ff05f6de6c9201326
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149831
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28934}
2019-08-22 08:30:57 +00:00
728a0ee459
Reland "Introduce ability to test echo in PC level test framework"
...
This is a reland of 77acb015b6ba886da3e7adb9c2106cf873fa8497
Original change's description:
> Introduce ability to test echo in PC level test framework
>
> Bug: webrtc:10138
> Change-Id: Ie638eaec5a46e37dc0eb52e9432fdebd0e4a1c4d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147866
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28892}
Bug: webrtc:10138
Change-Id: I0358239500ffadbdbae8090bf39535386fbfd40c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149805
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28917}
2019-08-20 12:18:28 +00:00
e21f3f574b
Revert "Delete mac_utils.h and mac_utils.cc"
...
This reverts commit ada8e17125d2124f5bcdc1558182ce95d6311d93.
Reason for revert: Breaks chromium, due to undeclared dependency on SystemConfiguration.framework
Original change's description:
> Delete mac_utils.h and mac_utils.cc
>
> They defined two functions: ToUtf16 and ToUtf8. The former was unused,
> and the latter is moved to
> modules/desktop_capture/mac/window_list_utils.cc, the only user.
>
> Tbr: sergeyu@chromium.org
> Bug: None
> Change-Id: Ib8a513da42e43ba8d41a2de4c1645b3f48448dc9
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148531
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Reviewed-by: Sergey Ulanov <sergeyu@google.com >
> Cr-Commit-Position: refs/heads/master@{#28913}
TBR=zijiehe@chromium.org ,nisse@webrtc.org ,kthelgason@webrtc.org ,sergeyu@google.com ,sergeyu@chromium.org
Change-Id: I9d6a2f63b3acde0eefab92d034529b800d6adcab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149811
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28915}
2019-08-20 09:58:37 +00:00
ada8e17125
Delete mac_utils.h and mac_utils.cc
...
They defined two functions: ToUtf16 and ToUtf8. The former was unused,
and the latter is moved to
modules/desktop_capture/mac/window_list_utils.cc, the only user.
Tbr: sergeyu@chromium.org
Bug: None
Change-Id: Ib8a513da42e43ba8d41a2de4c1645b3f48448dc9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148531
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Sergey Ulanov <sergeyu@google.com >
Cr-Commit-Position: refs/heads/master@{#28913}
2019-08-20 08:52:28 +00:00
5870503d5e
Revert "Introduce ability to test echo in PC level test framework"
...
This reverts commit 77acb015b6ba886da3e7adb9c2106cf873fa8497.
Reason for revert: Downstream tests are failing.
Original change's description:
> Introduce ability to test echo in PC level test framework
>
> Bug: webrtc:10138
> Change-Id: Ie638eaec5a46e37dc0eb52e9432fdebd0e4a1c4d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147866
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Sam Zackrisson <saza@webrtc.org >
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28892}
TBR=mbonadei@webrtc.org ,saza@webrtc.org ,kwiberg@webrtc.org ,titovartem@webrtc.org
Change-Id: Idc87c1cb679712d701d30902bcae4e2c698cf1cd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10138
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149804
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28896}
2019-08-19 11:46:04 +00:00
77acb015b6
Introduce ability to test echo in PC level test framework
...
Bug: webrtc:10138
Change-Id: Ie638eaec5a46e37dc0eb52e9432fdebd0e4a1c4d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147866
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28892}
2019-08-19 10:19:41 +00:00
f5e5d250bc
BalancedDegradationSettings: add option to configure a min framerate diff.
...
If a framerate reduction (input fps - restricted fps) is less than the
configured diff, shorten interval to next qp check.
Bug: none
Change-Id: Ia0b9e0638e5ba75cdc20a1bb45bfcb7d858c5f89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149040
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28880}
2019-08-16 16:13:46 +00:00
1b247f1e6e
BalancedDegradationSettings: add option to configure min bitrate.
...
Add possibility to configure min bitrate based on resolution.
Only adapt up if bw estimate is above the min bitrate for next higher resolution.
Bug: none
Change-Id: Ie38faae07d23336675ec33697ace6f6fed322efa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148598
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28863}
2019-08-15 07:16:33 +00:00
0ee8008a0d
Use struct parser for rate control trial.
...
Bug: webrtc:9883
Change-Id: I9ec7988da2e4d88bedd9b71cae00452f531980d6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148581
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28856}
2019-08-14 11:47:12 +00:00
0c38a86533
BalancedDegradationSettings: add option to configure no fps limit.
...
If configuring max valid framerate (100), no framerate restriction is
used (std::numeric_limits<int>::max()).
E.g. pixels:1000|2000,fps:5|10 is same as pixels:1000|2000|3000,fps:5|10|100
Bug: none
Change-Id: Ie981841ee8e23cb73c0ef55738ca69055916d902
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148980
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28854}
2019-08-14 08:56:38 +00:00
e4ba4ee837
Delete placeholder file rtc_base/function_view.h
...
Bug: None
Change-Id: If2d35a9745f1de6cc4d26814e8b7567a8466d831
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148527
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28820}
2019-08-09 09:39:32 +00:00
6685b328b9
Delete rtc_base/gunit_prod.h
...
Bug: None
Change-Id: I0d6e6536490758a102aec5362b89baf04353e570
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148524
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28818}
2019-08-09 08:44:30 +00:00
55251c3d49
Adds struct parameters parser/encoder.
...
This is similar to the field trial parser but it uses a normal struct
with normal fields as underlying storage. This makes it easier to
understand and use as only the encoding and parsing uses non-
standard constructs. Additionally, it makes it easier to use the
struct as a regular config struct when the values are not set
using field trials.
Bug: webrtc:9883
Change-Id: I5b16c2a71875b6f478383decff18fbaa62bc404a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145203
Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28810}
2019-08-08 15:21:35 +00:00
383adc025a
Delete shim of PRId64 et al. on Windows
...
It should be present since MSVC 2013.
This is a port of 08e78a4733https://webrtc-review.googlesource.com/c/src/+/148443
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28805}
2019-08-08 08:29:18 +00:00
b1686786e8
Add RTC_ prefix to non-standard format specifier macro "PRIdNS"
...
Some of the macros in format_macros.h follow the C standard and try to fill holes in it (on Windows). But this one has no direct equivalent in the standard and is just mimicking the naming convention. That's not nice.
References:
https://devblogs.microsoft.com/cppblog/c99-library-support-in-visual-studio-2013/
https://stackoverflow.com/a/2524673
Change-Id: I53f3faca2976a5b5d4b04a67ffb56ae0f4e930b2
Bug: webrtc:10852
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147862
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28794}
2019-08-07 13:36:05 +00:00
b6685420c4
Delete unused format specifier macros for NSInteger and NSUInteger
...
Bug: webrtc:10852
Change-Id: I0f8ba32b3f22ebd1bb85602daeebd34fb3d8c544
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148441
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28792}
2019-08-07 12:25:16 +00:00
a22cab8a65
Calling DebugBreak() on Windows during fatal checks instead of relying on abort().
...
Bug: webrtc:10846
Change-Id: Ie701f47b9b7c9d88ea983540dce3f429903a18f7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147879
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28771}
2019-08-06 09:19:00 +00:00
7ba3b81ff5
Delete class PlatformFile.
...
Add seek methods to FileWrapper, and refactor WavReader to use that
class instead.
Bug: webrtc:6463
Change-Id: Ifbb1989a072da6280ea5fc04b4beff991614dd53
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147265
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28770}
2019-08-06 09:07:50 +00:00
d7ee76cadd
Wire up field trials for some experimental screenshare settings
...
Bug: b/132074409
Change-Id: I83d5334255bad4fcf585b9850506bbfe1914ba57
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147868
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28758}
2019-08-05 13:47:01 +00:00
139f4dc7ac
QualityScaler: Add option to try fast adapt down at start up based on initial bw estimates.
...
optional<int> initial_bitrate_interval_ms: time interval since start of call
where fast adapt down is allowed.
optional<double> initial_bitrate_factor: try fast adapt down if bw estimate is
below initial bitrate * factor.
Bug: none
Change-Id: I63e1fdaac6556d8e9a961a42e11c925f9ecb9771
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147725
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28753}
2019-08-05 09:43:19 +00:00
b3f78deb78
Reland "Don't use all_dependent_configs for sdk frameworks"
...
This is a reland of 63741c7fa1aa55a38af11ac8cc04498722f9407d
It's possible to reland after the downstream fix in
https://chromium-review.googlesource.com/1730415
Original change's description:
> Don't use all_dependent_configs for sdk frameworks
>
> libs should be propagated to the final binary even without that:
> https://gn.googlesource.com/gn/+/master/docs/reference.md#var_libs
>
> But add some missing SDK framework dependencies:
>
> * RTCNativeI420Buffer.mm uses CGBitmapContextGetBytesPerRow.
> * socketrocket uses SecCertificateCopyData.
>
> Bug: None
> Change-Id: Iba38a5dfaf470a5a790d494cbec8ade44b1d16ba
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146082
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28605}
Bug: None
Change-Id: I6a1cd80c5177ef3a3b92ee55fc91e187b202d864
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147720
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28740}
2019-08-02 06:09:39 +00:00
4ed5b087f5
Skip empty strings in ToUtf(8|16).
...
We've observed a crash on Windows when the strings are empty, skipping the conversion seems reasonable in that case.
Bug: None
Change-Id: I3acf3060a88741fb750d7a0cc02e9422713c59cd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147380
Commit-Queue: Noah Richards <noahric@chromium.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28709}
2019-07-30 19:35:37 +00:00
ec3580361e
Revert "Don't use all_dependent_configs for sdk frameworks"
...
This reverts commit 63741c7fa1aa55a38af11ac8cc04498722f9407d.
Reason for revert: It breaks a chromium.fyi bot (https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Mac%20Builder%20(dbg)/3974 )
Original change's description:
> Don't use all_dependent_configs for sdk frameworks
>
> libs should be propagated to the final binary even without that:
> https://gn.googlesource.com/gn/+/master/docs/reference.md#var_libs
>
> But add some missing SDK framework dependencies:
>
> * RTCNativeI420Buffer.mm uses CGBitmapContextGetBytesPerRow.
> * socketrocket uses SecCertificateCopyData.
>
> Bug: None
> Change-Id: Iba38a5dfaf470a5a790d494cbec8ade44b1d16ba
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146082
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28605}
TBR=mbonadei@webrtc.org ,oprypin@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: None
Change-Id: I9e2fdb5753905cb4bf04820a8077feba78f463e6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146542
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28628}
2019-07-22 08:46:36 +00:00
fefa77c426
Add pthread thread-local storage support for ScopedYieldPolicy
...
Emscripten does not support C++11 thread_local but does support
the pthread TLS API.
Bug: None
Change-Id: Ia21895148d1df7652579d086d9e1c0c53d7a85f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145441
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28621}
2019-07-19 14:33:53 +00:00
836ab13f1c
Remove rtc::Flag.
...
WebRTC has been migrated to Abseil Flags.
Bug: webrtc:10616
Change-Id: Id4a363429ccd2dd55c0dff00c9490c15124fdccc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144631
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28620}
2019-07-19 14:05:01 +00:00
63741c7fa1
Don't use all_dependent_configs for sdk frameworks
...
libs should be propagated to the final binary even without that:
https://gn.googlesource.com/gn/+/master/docs/reference.md#var_libs
But add some missing SDK framework dependencies:
* RTCNativeI420Buffer.mm uses CGBitmapContextGetBytesPerRow.
* socketrocket uses SecCertificateCopyData.
Bug: None
Change-Id: Iba38a5dfaf470a5a790d494cbec8ade44b1d16ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146082
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28605}
2019-07-19 06:30:54 +00:00
7f8dbe18ea
Add config to specify raw audio priority bitrate including overhead.
...
Bug: webrtc:10815
Change-Id: I6a498d6c6bcd4fe4ba6ccc4d6f407d686528d946
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145333
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28590}
2019-07-17 15:28:46 +00:00
0182a0300f
Reland "Remove the injectable bitrate allocation strategy API."
...
This is a reland of 80cb3f6db622442b6360e67851e8903aa0d06d03
Original change's description:
> Remove the injectable bitrate allocation strategy API.
>
> This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
> plus a ton of now-dead code.
>
> Bug: webrtc:10556
> Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28523}
TBR=kwiberg@webrtc.org
Bug: webrtc:10556
Change-Id: Ic17a7a7cc447292306876ee9582ad62fd2499765
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145900
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28585}
2019-07-17 10:20:45 +00:00
1cd6f3224a
Fix typo in comment.
...
TBR=artit@webrtc.org
No-Try: True
Bug: None
Change-Id: I96bdc4788b58f3e7f45da5e8ba383d991382079a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145404
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28566}
2019-07-12 19:51:23 +00:00
e95b57cdfc
Revert "Remove the injectable bitrate allocation strategy API."
...
This reverts commit 80cb3f6db622442b6360e67851e8903aa0d06d03.
Reason for revert: Performance regression on downstream project.
Original change's description:
> Remove the injectable bitrate allocation strategy API.
>
> This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
> plus a ton of now-dead code.
>
> Bug: webrtc:10556
> Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28523}
TBR=henrika@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org ,srte@webrtc.org ,alexnarest@webrtc.org ,jonasolsson@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:10556
Change-Id: Ife905d661e7b1a227662395c729a9336c62fd2d7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145338
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28560}
2019-07-12 15:27:19 +00:00
6564366f75
Use -Wno-undef to compile jsoncpp.
...
This should fix this error:
In file included from ../../api/audio/echo_canceller3_config_json.cc:19:
In file included from ../..\rtc_base/strings/json.h:18:
In file included from ../../third_party/jsoncpp/source/include\json/json.h:9:
In file included from ../../third_party/jsoncpp/source/include\json/autolink.h:9:
../../third_party/jsoncpp/source/include\json/config.h(126,5): error: '__GNUC__' is not defined, evaluates to 0 [-Werror,-Wundef]
Maybe we could also fix it upstream.
Bug: webrtc:10770
Change-Id: I68434c6957189f680625bd2f2b85422965a89785
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145322
Reviewed-by: Artem Titarenko <artit@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28558}
2019-07-12 13:13:46 +00:00
80cb3f6db6
Remove the injectable bitrate allocation strategy API.
...
This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
plus a ton of now-dead code.
Bug: webrtc:10556
Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28523}
2019-07-10 13:13:25 +00:00
