9d77762023
Move SampleStatsCounter to public API
...
Bug: None
Change-Id: I8956f6febbb1caf71e951d212d57746fe1ec5eb2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184506
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32142}
2020-09-18 17:42:53 +00:00
979c13f565
Fix flag parsing for lazy pacer starting
...
Bug: webrtc:10809
Change-Id: I6340d356e59b3fd06d4f252ba3adb09723ebc2b6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184540
Reviewed-by: Tommi <tommi@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32141}
2020-09-18 17:07:33 +00:00
788480dcff
Roll chromium_revision 86ce521c55..4ed1b07147 (808263:808365)
...
Change log: 86ce521c55..4ed1b0714786ce521c55..4ed1b0714771cde1dc16..6161e18c7a153ad0bf09..305287c38c606d10ee0c..92a8839729612704c89a..2c9653cb1b1a8e13dbda..150f00873afafc133a2c..cd098a15ee86ce521c55..4ed1b07147TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I0d5f99bad190fb46bb3c21cb36750fb5f1564c7b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184560
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32140}
2020-09-18 16:34:43 +00:00
03fd7930c6
Allow more than 2 encoders in RtcEventLogEncoderTest
...
Bug: webrtc:11933
Change-Id: Iabec44eecbd41b0834a1a7105d344ea52fa1aeae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184513
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32139}
2020-09-18 13:59:01 +00:00
bd8409b70f
Minor fixes to avoid crash on some traces that have unexpected data.
...
Bug: webrtc:0
Change-Id: I6950004be2c725c1d13889f37e4a6208ca41f47e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178909
Commit-Queue: Ying Wang <yinwa@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32138}
2020-09-18 11:54:24 +00:00
70026f9d14
Put UntypedFunction in untyped_function.h, not function.h
...
This will make it easier to find stuff...
Bug: webrtc:11943
Change-Id: I4f1ae80b40b4966cb2d8db36701bbc02ac148df6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184512
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32137}
2020-09-18 09:43:07 +00:00
9996352602
Roll chromium_revision 9cee95fc18..86ce521c55 (808139:808263)
...
Change log: 9cee95fc18..86ce521c559cee95fc18..86ce521c551d662473ed..71cde1dc1681ea1d14de..153ad0bf094a768a1f3e..606d10ee0c667c317d25..612704c89aade44aa2a0..1a8e13dbda8d7201bc3c..d949c910de8a0ccb42d4..fafc133a2c9cee95fc18..86ce521c55TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ifb8d0b1690ae002ae97810969fe570c0db2b7679
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184488
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32136}
2020-09-18 09:16:57 +00:00
8d875587d5
Cancer Stick Castle: Clarify copyability and movability
...
Because the style guide wants it:
https://google.github.io/styleguide/cppguide.html#Copyable_Movable_Types
Bug: webrtc:11943
Change-Id: I17373f870496c6411b5edd80e7d50dbb15a7fbc0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184511
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32135}
2020-09-18 09:08:37 +00:00
1eb3e4c9ba
Roll chromium_revision eeb9e4d54c..9cee95fc18 (808031:808139)
...
Change log: eeb9e4d54c..9cee95fc18eeb9e4d54c..9cee95fc18ff7b48da95..81ea1d14de9fe7adf0c9..4a768a1f3ef2a394c808..667c317d25dad971ce9f..ade44aa2a0https://chromium.googlesource.com/catapult.git/+log/249019878c..0de9874718
* src/third_party/depot_tools: a787cd5e15..8d7201bc3ca01f8aca60..8a0ccb42d4eeb9e4d54c..9cee95fc18TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I18a0ad6c836d64ad4da9870e52a059577b7176c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184486
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32134}
2020-09-18 00:50:54 +00:00
ae5e4fd899
Roll chromium_revision 303ad9b228..eeb9e4d54c (807890:808031)
...
Change log: 303ad9b228..eeb9e4d54c303ad9b228..eeb9e4d54c1b0f4ed356..1d662473ed0ad7911146..ff7b48da95d7a11fd35f..9fe7adf0c93cd2795fcc..f2a394c8080a5d6145f1..dad971ce9fhttps://chromium.googlesource.com/catapult.git/+log/1d8e2d5aca..249019878c
* src/third_party/icu: d7eebbfb27..79326efe26a2ba0ce189..d62add52c62252904851..a01f8aca60303ad9b228..eeb9e4d54cTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I9f4861e0073e34118972e407fa3b0e017aa1347e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184484
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32133}
2020-09-17 21:08:14 +00:00
5956a17ed6
Revert "Wires up WebrtcKeyValueBasedConfig in media engines."
...
This reverts commit 591b2ab82ead157b5f5a85d5082bd15fe8c51809.
Reason for revert: Breaks downstream project
Original change's description:
> Wires up WebrtcKeyValueBasedConfig in media engines.
>
> This replaces field_trial:: -based functions from system_wrappers.
> Field trials are still used as fallback, but injectable trials are now
> possible.
>
> Bug: webrtc:11926
> Change-Id: I70f28c4fbabf6d9e55052342000e38612b46682c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174261
> Reviewed-by: Per Kjellander <perkj@webrtc.org >
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Stefan Holmer <stefan@webrtc.org >
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#32129}
TBR=mbonadei@webrtc.org ,kthelgason@webrtc.org ,sprang@webrtc.org ,stefan@webrtc.org ,srte@webrtc.org ,perkj@webrtc.org
Change-Id: I3e169149a8b787aa6366bb357abb71794534c63a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11926
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184507
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32132}
2020-09-17 20:17:38 +00:00
467b7c0ab2
Removing logic forcing AEC within VoIP core
...
Bug: None
Change-Id: Ie4afe984ff3b2f1d9d2ea906b2f64b7b7e1aa06e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184421
Commit-Queue: Tim Na <natim@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32131}
2020-09-17 19:39:07 +00:00
e95ebda562
build: document that aaudio was experimental
...
and make git blame point to a public description
NOTRY=true
BUG=webrtc:11947
Change-Id: Ic914c30243be8fd301140bc9d9489ff5869c6461
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184502
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/master@{#32130}
2020-09-17 18:20:15 +00:00
591b2ab82e
Wires up WebrtcKeyValueBasedConfig in media engines.
...
This replaces field_trial:: -based functions from system_wrappers.
Field trials are still used as fallback, but injectable trials are now
possible.
Bug: webrtc:11926
Change-Id: I70f28c4fbabf6d9e55052342000e38612b46682c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174261
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32129}
2020-09-17 16:24:10 +00:00
d55a10e8f2
Roll chromium_revision 9d25386ec1..303ad9b228 (807774:807890)
...
Change log: 9d25386ec1..303ad9b2289d25386ec1..303ad9b228f1b4682ab7..1b0f4ed35655fc88f81d..0ad7911146bdbe315b9b..d7a11fd35f5b99869e59..3cd2795fcc15acfdb7f7..0a5d6145f1https://chromium.googlesource.com/catapult.git/+log/d03abd8af7..1d8e2d5aca
* src/tools: cf582c5b8d..22529048519d25386ec1..303ad9b228TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ib7f70576416948d2b77765b8c2147db32562ade8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184481
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32128}
2020-09-17 15:20:56 +00:00
646109f379
Delete rtc::LeftPad
...
Single use replaced with snprintf (old code also uses snprintf, but
twice, via rtc::ToString).
Bug: webrtc:6424
Change-Id: Iedb30aacb351428974067141e166cbc53fdda180
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184365
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32127}
2020-09-17 13:18:25 +00:00
aef8a21a69
Reland "Switch from rtc_ios_xctest_test to rtc_test".
...
This is a reland of https://webrtc-review.googlesource.com/c/src/+/182680 ,
and it is based on https://chromium-review.googlesource.com/c/chromium/src/+/2414169
which allows to force a "test" to be executed as an XCtest on a build target
basis instead of on a GN args basis like it was happening in
https://webrtc-review.googlesource.com/c/src/+/182680 because that was
causing issues when launching tests on real devices.
Bug: webrtc:11881, webrtc:11937
Change-Id: I4bec7f471cd0f878b6050f266cd0cca3b518d415
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184360
Reviewed-by: Dirk Pranke <dpranke@google.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32126}
2020-09-17 09:14:15 +00:00
4f55233cf7
Add possibility to override mac_toolchain via .gclient custom_vars.
...
This will allow "gclient sync" to pick up a new version of the mac
toolchain as documented at [1].
[1] - https://source.chromium.org/chromium/chromium/src/+/master:docs/mac_arm64.md
TBR=peah@webrtc.org
Bug: webrtc:11946
Change-Id: I2265f27a206fb1e1cbff6216a4d083c0c4817f8e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184364
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32125}
2020-09-17 07:35:46 +00:00
525f11b4c5
Roll chromium_revision 3f2f2acf90..9d25386ec1 (807625:807774)
...
Change log: 3f2f2acf90..9d25386ec13f2f2acf90..9d25386ec114412b27f8..f1b4682ab7e16c6beb06..55fc88f81d1ed0ad631f..bdbe315b9bd8570cd663..5b99869e594addd083f3..15acfdb7f7https://chromium.googlesource.com/catapult.git/+log/cb190dce08..d03abd8af7
* src/third_party/depot_tools: 5c4c28f111..a787cd5e153504e85b74..a2ba0ce189d3ac111a70..cf582c5b8d3f2f2acf90..9d25386ec1TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: If8e940b3719fd2c4a3880bca937090697c84a994
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184442
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32124}
2020-09-17 06:48:16 +00:00
f229127551
Roll chromium_revision a6c88d8953..3f2f2acf90 (807489:807625)
...
Change log: a6c88d8953..3f2f2acf90a6c88d8953..3f2f2acf90afe0957b59..14412b27f8bd89e4805c..1ed0ad631f59b5c1f4b7..d8570cd6636d26c263c0..4addd083f3https://chromium.googlesource.com/catapult.git/+log/511a82c95f..cb190dce08
* src/third_party/perfetto: d1382ae74f..3504e85b749239268ebf..d3ac111a70a6c88d8953..3f2f2acf90TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I0870812a961d3bbe680230e5c45b130c1dadf447
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184381
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32123}
2020-09-16 21:11:42 +00:00
3e98280633
Add unit tests for cancer stick castle library
...
- Fix the minor issues with the initial library implementation.
- Add unit tests to cover basic scenarios.
Bug: none
Change-Id: Ibf28b4e20f74792fce2fe11d4780fd375a4ad3a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183343
Commit-Queue: Lahiru Ginnaliya Gamathige <glahiru@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32122}
2020-09-16 19:04:29 +00:00
bb25c561dc
Roll chromium_revision 1519d2c44a..a6c88d8953 (807375:807489)
...
Change log: 1519d2c44a..a6c88d89531519d2c44a..a6c88d895367e53b567b..afe0957b5942cbd32cfb..e16c6beb06d02f11314c..bd89e4805c1d2f486547..59b5c1f4b735a847848c..6d26c263c08e500174f4..5c4c28f11179326efe26..d7eebbfb278ca19625de..d5148db386d48ef5f7dd..d1382ae74fc680fe1f81..9239268ebf1519d2c44a..a6c88d8953TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I0c0dec043c943a3bc746919a02f56b9f0c90ddad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184380
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32121}
2020-09-16 16:54:20 +00:00
804db2dde3
UntypedFunction: Eliminate an unnecessary indirection in the implementation
...
Bug: webrtc:11943
Change-Id: Ib57b13977910ede430e4228a9d382fb765bf1d84
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184261
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32120}
2020-09-16 14:47:45 +00:00
198cd73011
Test for negotiating pre-stopped M-sections.
...
Fix for issue is in https://webrtc-review.googlesource.com/c/src/+/184343
Bug: chromium:1127625
Change-Id: I11bcde82b7e03a160b5ee078a9c5edf7f2e31902
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184344
Reviewed-by: Philipp Hancke <philipp.hancke@googlemail.com >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32119}
2020-09-16 14:35:06 +00:00
c8b3183711
Allow the SwapQueue to utilize user-define swap capability
...
The SwapQueue class provides efficient and thread-safe queueing of objects that
have swap capabilities. However, the current implementation does not utilize the
user-defined swap capabilites. This CL addresses that.
Bug: b/168693942
Change-Id: Id5c97c8c9cc04579b3c26c7f1dc5f8b3362126c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184361
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32118}
2020-09-16 14:08:55 +00:00
fe132e6bd9
Don't expect a transceiver for stopped m-sections
...
After implementing transceiver.stop and associated logic with regard
to stopped media sections, there might not be a transceiver for every
media section. Allow this case.
There is a test ready for submission in Chrome:
https://chromium-review.googlesource.com/c/chromium/src/+/2410407
Bug: chromium:1127625
Change-Id: I150ea5f0da4a0cbd2bf214bc659ea0df93b607de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184343
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Philipp Hancke <philipp.hancke@googlemail.com >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32117}
2020-09-16 13:49:51 +00:00
78e9acd967
UntypedFunction: Add unit tests and fix a few issues
...
Bug: webrtc:11943
Change-Id: I1f3c0495612148546ec399a800f97fe88b439c83
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184260
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32116}
2020-09-16 13:30:01 +00:00
818be15e4d
Clobber iOS builders.
...
TBR=titovartem@webrtc.org
Bug: webrtc:11937
Change-Id: Ic3ad56df532fac0ccf254e3e98d003ae0fefbf3c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184342
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32115}
2020-09-16 11:43:54 +00:00
7d73c6cf9d
Explicitly enable CDEF
...
It should already be enabled by default in libaom, but explicitly enable
it here in case that changes.
Bug: None
Change-Id: I93a1dfc92f9c02bc5ec823c326d8cf6ff163bceb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184262
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32114}
2020-09-16 11:39:44 +00:00
fa54364cea
Update STUN attributes with latest IANA registrations
...
https://www.iana.org/assignments/stun-parameters/stun-parameters.xhtml
Bug: webrtc:0
Change-Id: Id3addf432abdfe0b5c236dc5b080e64744c18114
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184341
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32113}
2020-09-16 11:13:14 +00:00
08574aeb44
Revert "Reland "Switch from "rtc_ios_xctest_test" to "rtc_test".""
...
This reverts commit 60c25a303fac85dccb2ccdd9e8d6d71be13b7541.
Reason for revert: Breaks downstream iOS testers.
From an offline discussion, the GN argument is not needed and only
the 3 xctest needs the behavior of that argument. So I am reverting
this one and preparing 2 CLs to properly fix.
Original change's description:
> Reland "Switch from "rtc_ios_xctest_test" to "rtc_test"."
>
> This is a reland of 7a73c772e21983857e46cb4fcedc6cfa3f42c03e
>
> The change to fix the downstream issue is just the switch from
> "test" to "rtc_test" which is a GN template that expands to
> "test".
>
> Original change's description:
> > Switch from "rtc_ios_xctest_test" to "test".
> >
> > Using the "test" GN template instead of the "ios_xctest_test" one we
> > will get iOS support for isolates via MB and GN for free, making it
> > easier to migrate the iOS recipe and fix bugs.webrtc.org/11604.
> >
> > Bug: webrtc:11881
> > Change-Id: I72b90f8494c473fa567e6296caf7a771e4caba92
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/182680
> > Reviewed-by: Dirk Pranke <dpranke@google.com >
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#32064}
>
> Bug: webrtc:11881
> Change-Id: Ia5338859f4e893b9f19bcca6b26b8cf66d5984e8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183766
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Dirk Pranke <dpranke@google.com >
> Cr-Commit-Position: refs/heads/master@{#32075}
TBR=mbonadei@webrtc.org ,dpranke@google.com ,jeffyoon@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:11881, webrtc:11937
Change-Id: Ie6eea6b2a8ba5c46af40b115c6db4fd0a38a25b0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184340
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32112}
2020-09-16 09:17:42 +00:00
d47d6de8a7
Roll chromium_revision dfb9023b74..1519d2c44a (807259:807375)
...
Change log: dfb9023b74..1519d2c44adfb9023b74..1519d2c44afaa02f24d9..67e53b567bbe363dca53..42cbd32cfb69f4b0847d..d02f11314c8ce5d48cf1..1d2f4865476b16cb17c1..35a847848chttps://chromium.googlesource.com/catapult.git/+log/3f01e83f96..511a82c95f
* src/third_party/depot_tools: 52fdd1ffce..8e500174f453747dfe65..97356acb50b189aac831..d48ef5f7dd8d6ecc0f6c..c680fe1f81dfb9023b74..1519d2c44aTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,marpan@webrtc.org , jianj@chromium.org ,
BUG=None
Change-Id: Ied152b0f7513a25e6ed65e9fa930f45d847fe891
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184323
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32111}
2020-09-16 09:03:20 +00:00
b10d4a612b
Roll chromium_revision 235f74189d..dfb9023b74 (807145:807259)
...
Change log: 235f74189d..dfb9023b74235f74189d..dfb9023b74d7463849c7..faa02f24d97b43f4ded4..be363dca5358de4223af..69f4b0847dafd548c6f5..8ce5d48cf10ee732e170..6b16cb17c1https://chromium.googlesource.com/catapult.git/+log/93d0ecf3d4..3f01e83f96
* src/third_party/depot_tools: f57e64e375..52fdd1ffceafb055b203..8d6ecc0f6c235f74189d..dfb9023b74TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I73f54319fbeff98b33aa9e8bd2e422cbf9858332
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184286
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32110}
2020-09-16 00:51:38 +00:00
e4642dac6c
Updating the OWNERS file for desktop capture
...
Change-Id: If5ddad06f0c5ce306e919de1f3a182986abaa0fe
Bug: webrtc:11938
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184281
Commit-Queue: Joe Downing <joedow@google.com >
Reviewed-by: Jamie Walch <jamiewalch@chromium.org >
Cr-Commit-Position: refs/heads/master@{#32109}
2020-09-15 21:34:24 +00:00
9bb8401a6c
Roll chromium_revision 5aa7e23974..235f74189d (807011:807145)
...
Change log: 5aa7e23974..235f74189d5aa7e23974..235f74189dea9d15525e..d7463849c760f89634b9..7b43f4ded4f3c442d839..58de4223af56572a88df..afd548c6f59e2844b24a..0ee732e170https://chromium.googlesource.com/catapult.git/+log/534924ed9e..93d0ecf3d4
* src/third_party/perfetto: b0a548c7e6..b189aac831dfa91dac01..afb055b2035aa7e23974..235f74189dTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ida942dfd1f865d91a80fff1e81f990f4ddd34916
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184284
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32108}
2020-09-15 20:51:04 +00:00
ae073e4433
Clobber iOS builders.
...
TBR=titovartem@webrtc.org
Bug: webrtc:11937
Change-Id: Ifca722d2e033b4a058f4e912535e622183a1165a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184265
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32107}
2020-09-15 20:22:24 +00:00
986e745106
Fix for unbounded increase in audio delay when no audio packets are flowing in
...
WebRTC’s Audio Video sync can go in unbounded loop and keep on increasing audio delay if audio packets stop coming in.
The issue happens, if StreamSynchronization::ComputeDelays has:
1. relative_delay_ms = some positive value which causes avg_diff_ms_ > 30ms
2. current_audio_delay_ms < current_video_delay_ms
3. audio_delay_.extra_ms > 0 and video_delay_.extra_ms = 0
To compensate for relative delay, audio_delay_.extra_ms gets incremented every time StreamSynchronization::ComputeDelays is called by RtpStreamsSynchronizer::Process(), which happens every 1sec
RtpStreamsSynchronizer::Process() will try to set the new delay to audio stream by calling syncable_audio_->SetMinimumPlayoutDelay(target_audio_delay_ms);
This ends up calling DelayManager::SetMinimumDelay and update minimum_delay_ms_
But this update has no impact on the value returned by NetEqImpl::FilteredCurrentDelayMs (as there are no audio packets flowing in, hence neteq is not running) which is called next time RtpStreamsSynchronizer::Process(), runs and tried to compute the new audio delay (audio_info→current_delay_ms)
This causes audio delay to be increased in every iteration and it grows unbounded. I guess it will stop growing above 10sec as that is hardcoded max delay in NetEQ.
To avoid this added a check to not adjust delays when no new audio stream has come in.
Bug: webrtc:11894
Change-Id: If648f9227e43c351f887d054876cb119cc1a917e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183340
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Shyam Sadhwani <shyamsadhwani@fb.com >
Cr-Commit-Position: refs/heads/master@{#32106}
2020-09-15 15:54:54 +00:00
c6dbc5ee80
Roll chromium_revision 2c970cbe2f..5aa7e23974 (806885:807011)
...
Change log: 2c970cbe2f..5aa7e239742c970cbe2f..5aa7e239749f51c92f5c..60f89634b9ac90fd0782..f3c442d83949c4639b9a..56572a88dffb6ac2eca4..9e2844b24a0547fb2917..f57e64e375cfda0b2aaf..b0a548c7e6084749d9cb..dfa91dac012c970cbe2f..5aa7e23974TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ia10f88c2af648dcac18b85aabead0ff3f833b7ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184245
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32105}
2020-09-15 14:37:34 +00:00
daec488749
objc: fix rollback
...
and add a unit test
BUG=webrtc:11796
Change-Id: I8e73b22f007c15c862faad7ca881d93c14a3a46f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184160
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/master@{#32104}
2020-09-15 09:27:08 +00:00
6e046668d1
Adding field trials to control additional quality scaler settings
...
Bug: webrtc:11924
Change-Id: I98c7aa4bd4536770500fec7e8e8da9629fddd20f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183342
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32103}
2020-09-15 08:58:36 +00:00
34f5ab82fe
Roll chromium_revision b0398ace4b..2c970cbe2f (806731:806885)
...
Change log: b0398ace4b..2c970cbe2fb0398ace4b..2c970cbe2f2bc64ef15e..ea9d15525e73be302438..9f51c92f5c7ecdca2225..ac90fd07822444860bdd..49c4639b9a533fbd1f56..fb6ac2eca4a1e15498cd..0547fb2917bef393a5a3..cfda0b2aafa8c51df76c..995c0b844181ed796261..084749d9cb4c095d0417..44c13d7315b0398ace4b..2c970cbe2fTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I96ae6acdf60dd2fb802721ba0e4ee6e4cca94562
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184221
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32102}
2020-09-15 05:11:45 +00:00
7703f23b60
Adds ability to delay pacer start until media is added.
...
This avoids the pacer thread waking up at 5ms interval if a
PeerConnection is created without actually using media.
The TaskQueuePacedSender solves the problem too, this CL is mostly a
safeguard in case we still find issues when turning it on...
Can be turned off by setting field trial "WebRTC-LazyPacerStart" to
"Disabled".
Bug: webrtc:10809
Change-Id: I8501106e608eccb14487576f24bdceaf3f324d80
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183982
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32101}
2020-09-14 21:42:55 +00:00
352e9daef6
Roll chromium_revision e645bb4cda..b0398ace4b (806687:806731)
...
Change log: e645bb4cda..b0398ace4be645bb4cda..b0398ace4b38d8562d3a..2bc64ef15e8ef1ccddd4..73be3024389d2c35e634..7ecdca22256af3f7480a..2444860bdd20df2251ef..533fbd1f56f95de1d32e..81ed796261e645bb4cda..b0398ace4bTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I22daba040e78cffbc3cafc1007d8ebbf062db2ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184182
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32100}
2020-09-14 21:11:05 +00:00
634df6cf07
Roll chromium_revision ff96bd0744..e645bb4cda (806570:806687)
...
Change log: ff96bd0744..e645bb4cdaff96bd0744..e645bb4cda7c00d9e621..38d8562d3ab190443087..8ef1ccddd4a90362b4fc..3ff4f5027bcd9cd902d6..9d2c35e634598b9bd5a4..6af3f7480aa4df3b8110..20df2251ef9edd1a906f..bef393a5a3dfc31b1737..f95de1d32eff96bd0744..e645bb4cdaff96bd0744..e645bb4cdaTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I70544e902df9e3dbe7a4a94b515bb429745945c0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184181
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32099}
2020-09-14 18:37:29 +00:00
295570eb33
Use PostTask instead of MessageHandler for cert generation.
...
Bug: webrtc:11908
Change-Id: Iaad4f0e398980eeae77187a32dfade0c26eb4cc8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184061
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32098}
2020-09-14 14:48:39 +00:00
4d76a13b33
Make StunRequest not use auto cleanup.
...
The class already clears the thread that's used in its dtor
and consistently uses the same thread.
Bug: webrtc:11908
Change-Id: I5ea8d00c2e59bf46c5b369be5b23cf1d8e1875c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184060
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32097}
2020-09-14 14:46:49 +00:00
6da271844c
Avoid deallocating the async invoker when clearing the transport.
...
Deallocating the async invoker is a costly operation
but it's also unnecessary and could cause us to miss signal
events.
The data_channel_transport and data_channel_transport_invoker
are (despite the name) not related, since the latter is
used to signal events on the signaling thread whereas the
former deals with the data.
Bug: webrtc:11908
Change-Id: I37b345476a6381aef5d87807877ec1e05b380137
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184062
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32096}
2020-09-14 12:51:12 +00:00
8452ea86c5
Synchronize modifications to frame_extra_info_ in jni::VideoEncoderWrapper.
...
Since https://webrtc-review.googlesource.com/c/src/+/161447 ,
frame_extra_info_ is modified from both the encoder thread and the
callback thread.
Bug: None
Change-Id: Idece4d19cae6d8363428234721616f6ca6f85832
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184121
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32095}
2020-09-14 11:15:32 +00:00
e7b19c2d7f
Roll chromium_revision 1b3e75b818..ff96bd0744 (806461:806570)
...
Change log: 1b3e75b818..ff96bd07441b3e75b818..ff96bd0744ffc67a078f..7c00d9e621b4fd3f736f..b190443087547db2a22b..cd9cd902d6b933295dc0..598b9bd5a4c1010ec39d..a4df3b8110https://chromium.googlesource.com/catapult.git/+log/e53ee0c931..534924ed9e
* src/tools: 3a1c9b0ce8..dfc31b17371b3e75b818..ff96bd0744TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I157d3e0114e455385b169622e607c182ef68e4be
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184102
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32094}
2020-09-14 10:36:42 +00:00
a028a1a0f7
Removed old OnDecodedFrame callback.
...
Bug: webrtc:9106
Change-Id: Idb13ca9984f1e74585640e78da60a291218f4ade
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183981
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32093}
2020-09-14 09:58:21 +00:00
