zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
30,862 Commits 1 Branch 0 Tags
9b79ad33af747f0df3297a9c171341c2ca50fe23
Commit Graph

30862 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jakob Ivarsson
7649006692 Remove packet loss rate optimization and minimum field trial. 
Bug: webrtc:11664
Change-Id: I63fab70e5ae85e2971bed4998ab3b15f61f9e1c0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176752
Reviewed-by: Minyue Li <minyue@webrtc.org>
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31480}
 2020-06-10 08:37:30 +00:00
Markus Handell
2d27b1ab0c Mutex: Temporarily add re-entry CHECK. 
Bug: webrtc:11567
Change-Id: I8f9f2f8d2f4961fd82ef50de9f4b486056bc7c1e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176701
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31479}
 2020-06-10 07:45:50 +00:00
Danil Chapovalov
0e2dd1271e Add av1 structures for 3 spatial and/or 3 temporal layers 
Bug: webrtc:11404
Change-Id: I2a2a40202b1dc8bec66baffc8883e59b9be9bade
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176518
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31478}
 2020-06-09 14:50:21 +00:00
Andrey Logvin
0c3062efcb Roll chromium_revision 5177dd5686..4d95e6c77b (776000:776481) 
Change log: 5177dd5686..4d95e6c77b
Full diff: 5177dd5686..4d95e6c77b

Changed dependencies
* src/base: 12aafbd23b..2df7267880
* src/build: 45f27c5e79..a03951acb9
* src/ios: 6d0f4efc06..9200aad36b
* src/testing: a67f60963b..502600d41a
* src/third_party: b81d3c846f..e0df6e10ad
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/03e7ff4035..2ad47493f8
* src/third_party/depot_tools: a85d58e50e..37e562110f
* src/tools: d018c278d3..050a4a5e26
DEPS diff: 5177dd5686..4d95e6c77b/DEPS

Clang version changed a6ae333a0c23fc9b0783ca45e2676abac00c6723:f7f1abdb8893af4a606ca1a8f5347a426e9c7f9e
Details: 5177dd5686..4d95e6c77b/tools/clang/scripts/update.py

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I55bb359cd525252ea0c46035d0f27447cd7fe010
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176821
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31477}
 2020-06-09 14:24:01 +00:00
Danil Chapovalov
5ad16a50fc suppress 'Paramaterized test suite never instantiated' warning 
for TaskQueueTest.
This suit is instantiated in the different binary targets by design.

Bug: None
Change-Id: I99a38e2461ee9bd06dfe68758490afe75c2475ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176750
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31476}
 2020-06-09 13:31:49 +00:00
Tomas Gunnarsson
dffa944e07 Reland "Remove dead code from ModuleRtpRtcpImpl2" 
This reverts commit f8311a1aa2887a2f01751424b948a1c20088e773.

Reason for revert: Relanding with a different approach

Original change's description:
> Revert "Remove dead code from ModuleRtpRtcpImpl2"
> 
> This reverts commit 8d4d671e9be98a090921006cc988cc1fc4fe1947.
> 
> Reason for revert: Breaks wasm builds.
> 
> 
> 
> Original change's description:
> > Remove dead code from ModuleRtpRtcpImpl2
> > 
> > Bug: webrtc:11581
> > Change-Id: I70e1df2724801c1bc7fb5cfb52cb6d1d44920b0d
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176570
> > Commit-Queue: Tommi <tommi@webrtc.org>
> > Reviewed-by: Erik Språng <sprang@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#31467}
> 
> TBR=tommi@webrtc.org,sprang@webrtc.org
> 
> Change-Id: I790374f7fa93147824e6fa2779a0bbaf5987924f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:11581
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176746
> Reviewed-by: Tommi <tommi@webrtc.org>
> Commit-Queue: Tommi <tommi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31468}

TBR=tommi@webrtc.org,sprang@webrtc.org

# Not skipping CQ checks because this is a reland.

Bug: webrtc:11581
Change-Id: I6086548f1c3527ee96ebd1c97be7a5be2a9a5429
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176748
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31475}
 2020-06-09 11:22:16 +00:00
Tomas Gunnarsson
6434864c3f Deprecate a few unused methods in RtpRtcpInterface 
Bug: none
Change-Id: Ifbf2040f3ce03a1381f6fbf59cb752c7bc2dc1aa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176571
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31474}
 2020-06-09 11:04:59 +00:00
Danil Chapovalov
a48dd43fe1 Add builder setters for ScalableVideoStructure::LayerFrameConfig 
Bug: None
Change-Id: I19721f87b9f4641e093dc51f9c023b0493adcf97
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176702
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31473}
 2020-06-09 10:31:35 +00:00
Bjorn Terelius
c186e1498b Move NetEq and ANA plotting to a separate file. 
Bug: webrtc:11566
Change-Id: I6d6176ff72a158a1629e14b539de2e928e7d02a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176510
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@google.com>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31472}
 2020-06-09 10:05:31 +00:00
Bjorn Terelius
571e130ce2 Fix nondeterministic behavior in rtc_event_log_visualizer caused by uninitialized variables. 
Bug: webrtc:11566
Change-Id: I10dcb84c8e7e231fe24dc322a0359742dded05bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176515
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31471}
 2020-06-09 09:26:41 +00:00
Magnus Flodman
bf3f65815f Adding brandtr as api/video owner 
Bug: None
Change-Id: Idacd6442d014e610aba363519c7159564ef80a45
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176700
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Magnus Flodman <mflodman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31470}
 2020-06-09 08:30:19 +00:00
Mirko Bonadei
1bf9c15535 Trigger bots. 
Testing if goma revert fixed the issue with CI bots.

TBR=tommi@webrtc.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11658
Change-Id: I99a8f7fb8360faec9464ddcaf21e7ddadf553110
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176747
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31469}
 2020-06-09 08:11:07 +00:00
Tommi
f8311a1aa2 Revert "Remove dead code from ModuleRtpRtcpImpl2" 
This reverts commit 8d4d671e9be98a090921006cc988cc1fc4fe1947.

Reason for revert: Breaks wasm builds.



Original change's description:
> Remove dead code from ModuleRtpRtcpImpl2
> 
> Bug: webrtc:11581
> Change-Id: I70e1df2724801c1bc7fb5cfb52cb6d1d44920b0d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176570
> Commit-Queue: Tommi <tommi@webrtc.org>
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31467}

TBR=tommi@webrtc.org,sprang@webrtc.org

Change-Id: I790374f7fa93147824e6fa2779a0bbaf5987924f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11581
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176746
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31468}
 2020-06-09 07:33:08 +00:00
Tomas Gunnarsson
8d4d671e9b Remove dead code from ModuleRtpRtcpImpl2 
Bug: webrtc:11581
Change-Id: I70e1df2724801c1bc7fb5cfb52cb6d1d44920b0d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176570
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31467}
 2020-06-09 05:41:12 +00:00
Tomas Gunnarsson
4d177eb1bd Add diagnostic printout to RTC_DCHECK_RUN_ON. 
When using a SequenceChecker, this adds a bit more information
about why the check failed.

Example (The "Expects" line is new):

# Fatal error in: foo.cc, line 380
# last system error: 0
# Check failed: (&thread_checker_)->IsCurrent()
# Expects: System queue: 0x7fff69541330, TaskQueue: 0x101804370 (not current), Thread: 0x10053cdc0

Bug: none
Change-Id: I3743e1d80f369f15219de5946e9e081f998b9b17
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176569
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31466}
 2020-06-08 22:29:14 +00:00
Ilya Nikolaevskiy
09eb6e249d [VP9 SVC] Round spatial layers dimensions to ensure integer scaling factors are used 
Bug: webrtc:11652
Change-Id: Id3642d607f62b72a567d521d9874b8588c2ce429
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176517
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31465}
 2020-06-08 19:00:30 +00:00
Tomas Gunnarsson
9766b890a8 Remove SetRTCPApplicationSpecificData. 
Also removing some related code that appears to be unused.
This is a part of simplifying the RtpRtcpInterface implementation.

Bug: webrtc:11581
Change-Id: I580bfdc1b821d571cb7437d7713a49ee4de2d19a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176568
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31464}
 2020-06-08 17:16:43 +00:00
Mirko Bonadei
2dcf348011 Use absl_deps in order to preapre to the Abseil component build release. 
Bug: webrtc:1046390
Change-Id: Ia35545599de23b1a2c2d8be2d53469af7ac16f1d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176502
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31463}
 2020-06-08 12:59:40 +00:00
Erik Språng
576db1bf60 Fixes incorrect padding setting for VP9 SVC. 
Unit test added to verify root cause is fixed.
Scenario test added to verify high-level behavior.

Bug: webrtc:11654
Change-Id: I1ad6e2750f5272e86b4198749edbbf5dfd8315c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176564
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31462}
 2020-06-08 12:56:10 +00:00
chromium-webrtc-autoroll
08a16c09bc Roll chromium_revision d96e9f16ae..5177dd5686 (775897:776000) 
Change log: d96e9f16ae..5177dd5686
Full diff: d96e9f16ae..5177dd5686

Changed dependencies
* src/base: 6e5def0362..12aafbd23b
* src/build: 036a45efe6..45f27c5e79
* src/ios: bd2e1fa1d2..6d0f4efc06
* src/testing: 4e6ae93982..a67f60963b
* src/third_party: 32f94c7405..b81d3c846f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/69b4144bb1..03e7ff4035
* src/tools: 50780ad561..d018c278d3
DEPS diff: d96e9f16ae..5177dd5686/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ic9e386d76012995baa78b7704d46cc9e9a751ff1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176640
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31461}
 2020-06-08 12:39:40 +00:00
Danil Chapovalov
4091d34171 Add av1 scalability structures for 2 spatial and 2 temporal layers. 
Bug: webrtc:11404
Change-Id: I0a2257b88666a0158a85162974430c2c08d61b40
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176501
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31460}
 2020-06-08 10:23:23 +00:00
Tomas Gunnarsson
593e6a4238 Fork RtpSenderEgress. 
The forked and deprecated implementation is used by the
deprecated ModuleRtpRtcpImpl implementation.

Change-Id: If67ca1181f40969791cf9c8903c0e49679c86834
Bug: webrtc:11581, webrtc:11611
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176566
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31459}
 2020-06-08 08:02:50 +00:00
Jonas Oreland
49864b7f0d Add forget_learned_state to IceControllerInterface 
This patch enables an IceController to use
Connection::ForgetLearnedState by returning it
in a SwitchResult, that will cause P2PTransportChannel
to call the method.

BUG: webrtc:11463
Change-Id: I098bbbd2fb2961822b165770189ac0c2225d1cb0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176511
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31458}
 2020-06-08 07:46:54 +00:00
Harald Alvestrand
10ef847289 Correct name of DC.dataChannelIdentifier stats member 
Bug: webrtc:8787
Change-Id: Ie32b38f0671e89e94017f439de7614142328642f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176509
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31457}
 2020-06-07 21:57:50 +00:00
Markus Handell
4a4f162f71 Mutex, CriticalSection: Switch Mac to _PTHREAD_MUTEX_POLICY_FIRSTFIT. 
Fairshare mutexes performed really badly during a Catalina
performance test. This change switches them to use
the _PTHREAD_MUTEX_POLICY_FIRSTFIT policy instead.

Bug: webrtc:11567, webrtc:11648
Change-Id: I2b8fbe3183beefc26f8d4ff3d63dc6958174605f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176504
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31456}
 2020-06-07 15:06:51 +00:00
chromium-webrtc-autoroll
17f85b8415 Roll chromium_revision b773bad891..d96e9f16ae (775651:775897) 
Change log: b773bad891..d96e9f16ae
Full diff: b773bad891..d96e9f16ae

Changed dependencies
* src/base: ed3eb73a47..6e5def0362
* src/build: ffdbae83d5..036a45efe6
* src/ios: 82256b5031..bd2e1fa1d2
* src/testing: 07b3988813..4e6ae93982
* src/third_party: 5983d3f9d1..32f94c7405
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/2309f645e5..88024df121
* src/third_party/depot_tools: d27e40cf55..a85d58e50e
* src/third_party/googletest/src: cb44c86c1a..4fe018038f
* src/tools: b6c8d850fc..50780ad561
DEPS diff: b773bad891..d96e9f16ae/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: If1f130d57263e0a5dbff3488c176e29d560381c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176610
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31455}
 2020-06-07 05:12:30 +00:00
chromium-webrtc-autoroll
73d7917802 Roll chromium_revision ff30c92f13..b773bad891 (775354:775651) 
Change log: ff30c92f13..b773bad891
Full diff: ff30c92f13..b773bad891

Changed dependencies
* src/base: f6b65186c7..ed3eb73a47
* src/build: 68335d574e..ffdbae83d5
* src/ios: b761b74046..82256b5031
* src/testing: a0c0f35125..07b3988813
* src/third_party: dfa6287194..5983d3f9d1
* src/third_party/android_deps/libs/com_google_protobuf_protobuf_javalite: version:3.11.4-cr0..version:3.12.2-cr0
* src/third_party/breakpad/breakpad: 2ffe116322..2757a2c9c8
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/92c6c3ec3b..69b4144bb1
* src/third_party/depot_tools: 88b4a168c3..d27e40cf55
* src/tools: 119a416071..b6c8d850fc
DEPS diff: ff30c92f13..b773bad891/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: If6829eefe003145e8077beeb6c4256f8a150c304
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176494
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31454}
 2020-06-05 19:51:16 +00:00
Artem Titov
506d4eb7e4 Add missing headers to fix chromium roll 
Bug: None
Change-Id: If28819bbeebe739f07fcd8d6ea8ab841efc20f75
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176562
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31453}
 2020-06-05 17:49:04 +00:00
Artem Titov
3685605b52 Remove old Start method from VideoQualityAnalyzerInjectionHelper 
Bug: webrtc:11631
Change-Id: I029e83fe6f50bb4f5ab0a56c9089271702f3cf34
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176561
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31452}
 2020-06-05 15:56:33 +00:00
Markus Handell
8e75bd40e0 Mutex: remove Abseil static initializer. 
The change adds conditional inclusion of mutex_abseil.h from mutex.h
and conditional referencing of
//third_party/abseil-cpp/absl/synchronization
which introduces a static initializer.

https://webrtc-review.googlesource.com/c/src/+/176230 introduced a
static initializer which broke the Chromium autoroll,
https://chromium-review.googlesource.com/c/chromium/src/+/2230887.
Example failure:
https://ci.chromium.org/p/chromium/builders/try/android-lollipop-arm-rel/34133

TBR=karl@webrtc.org

No-Try: True
Bug: webrtc:11567
Change-Id: Id78af798f34d5d6beaf9f6e0150e6b3ddd31ff4f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176513
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Olga Sharonova <olka@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31451}
 2020-06-05 10:26:28 +00:00
Mirko Bonadei
b2f73040fc Fix -Wunused-variable error. 
Bug: None
Change-Id: I13ca43b15f1519e5ce5c17b6eb0b6611dbd20c39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176505
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Markus Handell <handellm@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31450}
 2020-06-05 08:58:05 +00:00
Taylor Brandstetter
301eb5370b Prevent pointer from being sent in the clear over SCTP. 
We were using the address of the SctpTransport object as
the sconn_addr field in usrsctp, which is used to get access to
the SctpTransport object in various callbacks.

However, this address is sent in the clear in the SCTP cookie,
which is undesirable.

This change uses a monotonically increasing id instead, which
is mapped back to a SctpTransport using a SctpTransportMap helper
class.

Bug: chromium:1076703
Change-Id: Iffb23fdbfa13625e921a9fd5500fe772b4d4015f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176422
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Taylor <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31449}
 2020-06-05 02:13:06 +00:00
chromium-webrtc-autoroll
b35695e4c0 Roll chromium_revision 7051d3aa50..ff30c92f13 (775236:775354) 
Change log: 7051d3aa50..ff30c92f13
Full diff: 7051d3aa50..ff30c92f13

Changed dependencies
* src/base: 74087b0433..f6b65186c7
* src/build: f794b3d4af..68335d574e
* src/ios: edc17de953..b761b74046
* src/testing: 8e2983cde0..a0c0f35125
* src/third_party: be2a8da376..dfa6287194
* src/third_party/depot_tools: e65444f91d..88b4a168c3
* src/tools: f882470ad3..119a416071
DEPS diff: 7051d3aa50..ff30c92f13/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ibe23659bd29aa98660015e377931e9c8bec6b0bc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176520
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31448}
 2020-06-05 00:50:07 +00:00
chromium-webrtc-autoroll
5008ba02d3 Roll chromium_revision 7100fe3f3e..7051d3aa50 (775078:775236) 
Change log: 7100fe3f3e..7051d3aa50
Full diff: 7100fe3f3e..7051d3aa50

Changed dependencies
* src/base: 7ca560de63..74087b0433
* src/build: 439d91cf49..f794b3d4af
* src/ios: 0efbc367ac..edc17de953
* src/testing: 32baa7e2f5..8e2983cde0
* src/third_party: e7b7d70ddf..be2a8da376
* src/tools: f9938a9591..f882470ad3
* src/tools/swarming_client: 90c5e17a82..4c095d0417
DEPS diff: 7100fe3f3e..7051d3aa50/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I9a4201b5515abedab4bdfeff04ad2a545aa2ce25
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176486
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31447}
 2020-06-04 20:44:26 +00:00
chromium-webrtc-autoroll
0a55c2f6cd Roll chromium_revision 43c8771f89..7100fe3f3e (774929:775078) 
Change log: 43c8771f89..7100fe3f3e
Full diff: 43c8771f89..7100fe3f3e

Changed dependencies
* src/base: cf5969c394..7ca560de63
* src/build: 932b84b103..439d91cf49
* src/ios: 03956cbc88..0efbc367ac
* src/testing: 0ffd841e81..32baa7e2f5
* src/third_party: 4a37c7d618..e7b7d70ddf
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/15d5f65efa..92c6c3ec3b
* src/third_party/depot_tools: 84620d395a..e65444f91d
* src/third_party/google_benchmark/src: 6746c65bcf..367119482f
* src/tools: b561482b1c..f9938a9591
DEPS diff: 43c8771f89..7100fe3f3e/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Iab0b338eaeb869641001922da6cb2bef26479c09
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176482
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31446}
 2020-06-04 12:49:53 +00:00
Yura Yaroshevich
bc1f910456 Reland "Added mid to error messages reported during SDP apply." 
This reverts commit 341434e4da2c193b8842917d73afed6eea3a4332.

Reason for revert: another attempt to land with Chromium
test updated to accept both error messages by CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2228545

Original change's description:
> Revert "Added mid to error messages reported during SDP apply."
>
> This reverts commit d2890e8833796f13c4a1243769be966bebdfcaa7.
>
> Reason for revert: speculative: WebRtcBrowserTest.NegotiateUnsupportedVideoCodec broken on all FYI bots, example: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Linux%20Tester/6659
>
> Original change's description:
> > Added mid to error messages reported during SDP apply.
> >
> > Bug: webrtc:10139
> > Change-Id: I7462b632e00a2da7b189b63022d30f594700b68a
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176400
> > Reviewed-by: Tommi <tommi@webrtc.org>
> > Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com>
> > Cr-Commit-Position: refs/heads/master@{#31421}
>
> TBR=tommi@webrtc.org,yura.yaroshevich@gmail.com
>
> Change-Id: I18972815df10e2bd7b914ad82df9596009c2fecc
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10139
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176418
> Reviewed-by: Olga Sharonova <olka@webrtc.org>
> Commit-Queue: Olga Sharonova <olka@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31425}

TBR=tommi@webrtc.org,olka@webrtc.org,yura.yaroshevich@gmail.com

# Not skipping CQ checks because this is a reland.

Bug: webrtc:10139
Change-Id: I603d3891c43ac396bf0ba98c6de189663235c8af
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176448
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com>
Cr-Commit-Position: refs/heads/master@{#31445}
 2020-06-04 11:16:46 +00:00
Artem Titov
10594c3c46 Add multi head queue implementation. 
Queue with multiple heads is planned to be used in
DefaultVideoQualityAnalyzer to store stream state. Stream state contains
ordered sequence of frame ids that were send for this video stream.
When frame is received by one receiver it should be removed from state
for that receiver and kept for others.

How it is used can be found in this CL:
https://webrtc-review.googlesource.com/c/src/+/176411

Bug: webrtc:11631
Change-Id: Ic7fabf4d77131805a91f08a2ccfffc73c08d3e2d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176402
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31444}
 2020-06-04 10:37:05 +00:00
Markus Handell
f70fbc8411 Introduces rtc_base/synchronization/mutex.h. 
This change introduces a new non-reentrant mutex to WebRTC. It
enables eventual migration to Abseil's mutex.

The mutex types supportable by webrtc::Mutex are

- absl::Mutex
- CriticalSection (Windows only)
- pthread_mutex (POSIX only)

In addition to introducing the mutexes, the CL also changes
PacketBuffer to use the new mutex instead of rtc::CriticalSection.

The method of yielding from critical_section.cc was given a
mini-cleanup and YieldCurrentThread() was added to
rtc_base/synchronization/yield.h/cc.

Additionally, google_benchmark benchmarks for the mutexes were added
(test courtesy of danilchap@), and some results from a pthread/Abseil
shootout were added showing Abseil has the advantage in higher
contention.

Bug: webrtc:11567, webrtc:11634
Change-Id: Iaec324ccb32ec3851bf6db3fd290f5ea5dee4c81
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176230
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31443}
 2020-06-04 09:55:12 +00:00
Henrik Boström
e917379c5b [Stats] Don't attempt to aggregate empty VideoSenderInfos. 
This fixes a crash that could happen if substreams exist but there is
no kMedia substream yet. There was an assumption that we either had no
substreams or at least one kMedia substream, but this was not true.
The correct thing to do is to ignore substream stats that are not
associated with any kMedia substream, because we only produce
"outbound-rtp" stats objects for existing kMedia substreams.

A test is added to make sure no stats are returned. Prior to the fix,
this test would crash.

Bug: chromium:1090712
Change-Id: Ib1f8494a162542ae56bdd2df7618775a3473419b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176446
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31442}
 2020-06-04 09:03:52 +00:00
Mirko Bonadei
8b7cfa16aa Introduce absl_deps in rtc_* C++ templates. 
Since dependencies on Abseil need to be statically linked in case
Chromium is built with is_component_build=true, this CL introduces a new
parameter for C++ library rtc_* templates (rtc_library, rtc_source_set
and rtc_static_library). This parameter (called "absl_deps") will result
in a dependency on the Abseil component (//third_party/abseil-cpp:absl)
when is_component_build=true or on the normal granular Abseil target
when is_component_build=false.

Bug: chromium:1046390
Change-Id: Iddca886926a7874488701bc9d79affb00cca72d0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176447
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31441}
 2020-06-04 08:41:32 +00:00
Tomas Gunnarsson
f25761d798 Remove dependency from RtpRtcp on the Module interface. 
The 'Module' part of the implementation must not be
called via the RtpRtcp interface, but is rather a part of
the contract with ProcessThread. That in turn is an
implementation detail for how timers are currently implemented
in the default implementation.

Along the way I'm deprecating away the factory function which
was inside the interface and tied it to one specific implementation.
Instead, I'm moving that to the implementation itself and down the
line, we don't have to go through it if we just want to create an
instance of the class.

The key change is in rtp_rtcp.h and the new rtp_rtcp_interface.h
header file (things moved from rtp_rtcp.h), the rest falls from that.

Change-Id: I294f13e947b9e3e4e649400ee94a11a81e8071ce
Bug: webrtc:11581
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176419
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31440}
 2020-06-04 08:11:21 +00:00
Evan Shrubsole
4d75d9c04c Clean resource_adaptation_processor_unittest use of TaskQueueForTest 
Use the current task queue in the test instead.

R=hbos@webrtc.org

Bug: None
Change-Id: I266796df3de675a808bcf2da08901411fadc86ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176414
Commit-Queue: Evan Shrubsole <eshr@google.com>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31439}
 2020-06-04 07:36:16 +00:00
Danil Chapovalov
aa40b89006 Add Scalability structure tests for individual frame configurations 
Bug: webrtc:10342
Change-Id: Ia768f6b37a4e9b0ce66139e799833746054e3a4e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176443
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31438}
 2020-06-04 07:32:06 +00:00
Jerome Jiang
7f7fb830ba Reland "Add av1 test running real video clips." 
This reverts commit 6958d2c6f0ce5267bdc4120d88680a4be9ed5e59.

Disable the test on iOS.

Bug: None
Change-Id: Ie42fada10a92bd4a802c6c79caeb4965410ddf6a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176461
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#31437}
 2020-06-04 06:32:46 +00:00
Jerome Jiang
6813767e52 Av1 wrapper: only use speed 6 on cores > 2 
Bug: None
Change-Id: Iacddfbca1d2579c3a397339a1c18008a10238348
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176463
Reviewed-by: Marco Paniconi <marpan@webrtc.org>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#31436}
 2020-06-04 03:23:54 +00:00
chromium-webrtc-autoroll
0fd55cc715 Roll chromium_revision 8c883b89af..43c8771f89 (774827:774929) 
Change log: 8c883b89af..43c8771f89
Full diff: 8c883b89af..43c8771f89

Changed dependencies
* src/ios: b0040c02f9..03956cbc88
* src/testing: 45c0f8fe6e..0ffd841e81
* src/third_party: e80904120b..4a37c7d618
* src/third_party/depot_tools: cf77d6e387..84620d395a
* src/tools: 399edfdda2..b561482b1c
DEPS diff: 8c883b89af..43c8771f89/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I07b828b15fbbe7ce64f6a16310507138377703fb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176386
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31435}
 2020-06-04 03:13:54 +00:00
chromium-webrtc-autoroll
21544ba0be Roll chromium_revision e728aee5f1..8c883b89af (774589:774827) 
Change log: e728aee5f1..8c883b89af
Full diff: e728aee5f1..8c883b89af

Changed dependencies
* src/base: e2680ca915..cf5969c394
* src/build: 3706c78319..932b84b103
* src/buildtools: 7a0ebcc840..1b066f0216
* src/ios: 9cb0749680..b0040c02f9
* src/testing: f5f2b604a8..45c0f8fe6e
* src/third_party: b9df2cbf82..e80904120b
* src/third_party/libvpx/source/libvpx: f80e888723..c176557314
* src/tools: ea65b4f041..399edfdda2
DEPS diff: e728aee5f1..8c883b89af/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,marpan@webrtc.org, jianj@chromium.org,
BUG=None

Change-Id: I25543efc93a5959473bc4d1e4c3bf83dd853764e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176384
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31434}
 2020-06-03 23:04:39 +00:00
Mirko Bonadei
5d511a5c0b Include correct ABSL_DECLARE_FLAG header. 
The absl/flags/flag.h header is not #including absl/flags/declare.h
starting from [1] so this transitive #include needs to be removed.

[1] - https://chromium-review.googlesource.com/c/chromium/src/+/2228841

Bug: None
Change-Id: I06e78ed05e0fb570a9ecc8621ec3ae5298fffd1a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176444
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31433}
 2020-06-03 22:08:46 +00:00
Mirko Bonadei
447cd3e623 Roll chromium_revision 0cd53b97fa..e728aee5f1 (770251:774589) 
Change log: 0cd53b97fa..e728aee5f1
Full diff: 0cd53b97fa..e728aee5f1

Changed dependencies
* src/base: 234742ffa0..e2680ca915
* src/build: 814cd0c441..3706c78319
* src/buildtools: 64ebbe62e1..7a0ebcc840
* src/buildtools/linux64: git_revision:ab32747ae7a399c57b04280f38e49b8fdf237a8a..git_revision:d0a6f072070988e7b038496c4e7d6c562b649732
* src/buildtools/mac: git_revision:ab32747ae7a399c57b04280f38e49b8fdf237a8a..git_revision:d0a6f072070988e7b038496c4e7d6c562b649732
* src/buildtools/win: git_revision:ab32747ae7a399c57b04280f38e49b8fdf237a8a..git_revision:d0a6f072070988e7b038496c4e7d6c562b649732
* src/ios: c3b92e2864..9cb0749680
* src/testing: 6bd825eb6a..f5f2b604a8
* src/third_party: 52a7c4e5e0..b9df2cbf82
* src/third_party/android_deps/libs/androidx_coordinatorlayout_coordinatorlayout: version:1.0.0-cr0..version:1.1.0-cr0
* src/third_party/android_deps/libs/androidx_recyclerview_recyclerview: version:1.0.0-cr0..version:1.1.0-cr0
* src/third_party/android_deps/libs/androidx_test_espresso_espresso_core: version:3.1.0-cr0..version:3.2.0-cr0
* src/third_party/android_deps/libs/androidx_test_espresso_espresso_idling_resource: version:3.1.0-cr0..version:3.2.0-cr0
* src/third_party/android_deps/libs/androidx_transition_transition: version:1.0.0-rc02-cr0..version:1.2.0-cr0
* src/third_party/android_deps/libs/com_google_android_material_material: version:1.0.0-rc02-cr0..version:1.2.0-alpha06-cr0
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/78b3337a10..2309f645e5
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/503f81b8fe..15d5f65efa
* src/third_party/depot_tools: 5a7be3da21..cf77d6e387
* src/third_party/googletest/src: a09ea700d3..cb44c86c1a
* src/third_party/harfbuzz-ng/src: 100d40c827..e3af529e51
* src/third_party/icu: f222396170..630b884f84
* src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/c810066815..2aa13c436e
* src/third_party/libunwindstack: dfd3f3d84c..046920fc49
* src/third_party/libvpx/source/libvpx: 1243d2fc27..f80e888723
* src/third_party/r8: UAycWqc5QfELtJhhnoU4jQHjsyxPjRNyZ0EfvlojaY4C..gobCh01BNwJNyLHHNFUmLWSMaAbe4x3izuzBFzxQpDoC
* src/tools: 5a602c7ac7..ea65b4f041
* src/tools/swarming_client: 7e8636295f..90c5e17a82
Added dependencies
* src/third_party/android_deps/libs/androidx_test_espresso_espresso_contrib
* src/third_party/android_deps/libs/androidx_annotation_annotation_experimental
* src/third_party/android_deps/libs/org_robolectric_shadows_multidex
* src/third_party/android_deps/libs/androidx_test_espresso_espresso_web
* src/third_party/android_deps/libs/androidx_test_espresso_espresso_intents
* src/third_party/android_deps/libs/androidx_viewpager2_viewpager2
* src/third_party/android_deps/libs/org_ccil_cowan_tagsoup_tagsoup
* src/third_party/android_deps/libs/org_robolectric_shadows_playservices
DEPS diff: 0cd53b97fa..e728aee5f1/DEPS

Clang version changed 99ac9ce7016d701b43b8f0c308dc3463da57d983:a6ae333a0c23fc9b0783ca45e2676abac00c6723
Details: 0cd53b97fa..e728aee5f1/tools/clang/scripts/update.py

TBR=titovartem@webrtc.org,marpan@webrtc.org, jianj@chromium.org,
BUG=None

Remove src/third_party/robolectric/robolectric

Change-Id: Id6d50ce671fd4f0f2b23e3a06829846f2cbeeb6f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176417
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31432}
 2020-06-03 21:19:55 +00:00
Jerome Jiang
1220c39953 av1: add a few controls to wrapper 
this will speed up realtime encoding.

Change-Id: I39d42f3c195d2f520f04f7357e72b0903905ea81
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176383
Reviewed-by: Marco Paniconi <marpan@webrtc.org>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#31431}
 2020-06-03 20:56:00 +00:00