5e05369cb2
Roll chromium_revision 30d0edac75..6f6d42e1df (958099:958232)
...
Change log: 30d0edac75..6f6d42e1df30d0edac75..6f6d42e1df78f2e2150b..94f5ba8cd5beda32040e..fdb36114770213de3876..d5c8012cf5ba40f25dfc..a78ed44be908b92f779b..112a990ec177507a1d8d..b8c2c1ab37d005da4982..a35a47739530d0edac75..6f6d42e1dfhttps://webrtc-review.googlesource.com/c/src/+/246121
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35673}
2022-01-12 20:22:28 +00:00
0a72b412e1
Add field trial flag forcing VP9 flexible mode for testing
...
Bug: chromium:949536
Change-Id: Idb12a2be18cdec8313a74d35fe79c0235f66e393
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246100
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35672}
2022-01-12 19:11:43 +00:00
f92de01f11
Roll chromium_revision 10ad737e1a..30d0edac75 (957995:958099)
...
Change log: 10ad737e1a..30d0edac7510ad737e1a..30d0edac75988da7eca7..78f2e2150b609d71d15f..beda32040e0925956b8b..0213de3876e6176d3f66..ba40f25dfcdb1c99c09d..08b92f779be838c37c2c..b647dbdeb85f2ecac827..d005da498210ad737e1a..30d0edac75https://webrtc-review.googlesource.com/c/src/+/246080
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35671}
2022-01-12 16:59:48 +00:00
31bd9fadb6
Disable Vp9ImplTest.DisableEnableBaseLayerWithSvcControllerTriggersKeyFrame
...
- Enable once a forward fix has landed in WebRTC
Bug: webrtc:13442
Change-Id: I0493fbbfbcf96e643d604406b350a3d315b24779
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245601
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@google.com >
Cr-Commit-Position: refs/heads/main@{#35670}
2022-01-12 16:43:38 +00:00
1c7c09bcfa
Introduce SdpOfferAnswerHandler::RemoteDescriptionOperation.
...
This is an operation specific subclass of SdpOfferAnswerHandler that in
this first step, takes over the implementation details that before this
CL were implemented in SdpOfferAnswerHandler::DoSetRemoteDescription.
This CL does not change the behavior of the implementation but it does
break up DoSetRemoteDescription into smaller methods and moves the state
related to the SRD operation, into a class that in upcoming steps can
be passed around asynchronously as needed, which will allow us to avoid
blocking threads.
Bug: webrtc:13540
Change-Id: Id2002d2390a4a13725f5967df5b82064b37c7490
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244980
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35669}
2022-01-12 14:38:25 +00:00
f5770a0198
Replace RTC_DCHECK_NOT_REACHED in framegenerator implementations of
...
ChangeResolution
Instead a warning is logged.
This effect tests only, and allows us to write screen share tests that may try to trigger the capturers to change resolution.
Bug: none
Change-Id: I4740fc4ed0bcf75e1c9df332fa610c24ed14973a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245981
Auto-Submit: Per Kjellander <perkj@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35668}
2022-01-12 13:25:25 +00:00
961f382458
Update api/ to not use implicit T* --> scoped_refptr<T> conversion
...
Bug: webrtc:13464
Change-Id: I5dc292fefd27bfd43574f3e0c63c0e1da6dddcae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244091
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35667}
2022-01-12 11:26:05 +00:00
994bf454ec
Revert of flag simplification.
...
In order to unify WebRTC recipes with Chromium recipes this CL tries to revert the old CL https://webrtc-review.googlesource.com/c/src/+/171681 .
This CL was already partially reverted (https://webrtc-review.googlesource.com/c/src/+/171809 ).
In upcoming CLs, the added flag dump_json_test_results will be removed in order to use isolated-script-test-output instead.
Bug: webrtc:13556
Change-Id: I3144498b9a5cbaa56c23b3b8adbac2229ad63c37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245602
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@google.com >
Cr-Commit-Position: refs/heads/main@{#35666}
2022-01-12 10:53:12 +00:00
ba38934771
Roll chromium_revision bddc47156d..10ad737e1a (957876:957995)
...
Change log: bddc47156d..10ad737e1abddc47156d..10ad737e1a26ecd10144..988da7eca7acafc906b9..609d71d15fa0467ae27d..0925956b8b825b1e43f2..e6176d3f669ca13b5441..db1c99c09dc3e25c828d..9fa0cb72301d9f7c5fb2..aea0874c4252851c34aa..5f2ecac827bddc47156d..10ad737e1ahttps://webrtc-review.googlesource.com/c/src/+/245940
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35665}
2022-01-12 10:50:26 +00:00
f490d6f818
Update WebRTC code version (2022-01-12T04:04:26).
...
Bug: None
Change-Id: I541bae6e84f4609fb274358a9104bc5a7acacdaf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245901
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35664}
2022-01-12 05:57:56 +00:00
acd2af9183
Roll chromium_revision 009ef0607e..bddc47156d (957263:957876)
...
Change log: 009ef0607e..bddc47156d009ef0607e..bddc47156d6aa2f94267..26ecd101443803b801b5..acafc906b9a0ace9923e..8829496cf658d1647360..834e4a3c868d2e6d58a9..a0467ae27d281b598c1a..825b1e43f26b754d731d..9ca13b5441https://chromium.googlesource.com/catapult.git/+log/dc1213869e..486f67f3ec
* src/third_party/depot_tools: d3cc7ad85e..c3e25c828da25e85ed95..e838c37c2c6b74da4757..1d9f7c5fb2ab35ee100a..51415c407632e9ed40ea..52851c34aa009ef0607e..bddc47156d009ef0607e..bddc47156dhttps://webrtc-review.googlesource.com/c/src/+/245880
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35663}
2022-01-12 02:40:15 +00:00
cb87ec9557
Remove unnecessary imports from //build
...
rtc_base/BUILD.gn imports //build/config/{crypto,ui}.gni but uses no
flags from them. Since they aren't needed anymore, remove them to
loosen build system coupling.
Blocking https://chromium-review.googlesource.com/c/chromium/src/+/3379123
Bug: chromium:961767
Change-Id: I006163f510a3fa1da88f7cc3e3109f240684457c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245820
Auto-Submit: Collin Baker <collinbaker@chromium.org >
Commit-Queue: Collin Baker <collinbaker@chromium.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35662}
2022-01-11 21:43:16 +00:00
c811ab54eb
Invalidate the legacy stats cache instead of updating.
...
This changes SetLocalDescription/SetRemoteDescription to just resetting
the internal cache timestamp for the legacy stats handler instead of
performing a full update, which can be costly.
Bug: webrtc:13557
Change-Id: I93971dbd7abf33c0d0f2836f9c17ba4550f41a00
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245645
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35661}
2022-01-11 20:45:16 +00:00
bb57de2959
Extend make_ref_counted to interoperate with RefCountedNonVirtual
...
Update RtpPacketInfos internals to use rtc::make_ref_counted, and a
Data class with no virtual methods.
Bug: webrtc:13464, webrtc:12701
Change-Id: I03f6bee69a9f060dcf287284fc779268d5eb433e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244505
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35660}
2022-01-11 16:06:34 +00:00
b82193cec8
Disable DisableEnableBaseLayerTriggersKeyFrame
...
- Enable once a forward fix has landed in WebRTC.
Bug: webrtc:13442
Change-Id: I295383b84a753e8e1f65006cc6a3c00b78033aa4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245643
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@google.com >
Cr-Commit-Position: refs/heads/main@{#35659}
2022-01-11 14:59:24 +00:00
21e97f9b9d
Add unary operator- to units
...
This will be used in the frame buffer 3 scheduler.
Bug: webrtc:13343
Change-Id: Ib699072021da30022a34aabe24e36a37e89ddf41
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245642
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35658}
2022-01-11 14:12:54 +00:00
3fd9cbc7a0
stats: convert qualitylimitationdurations to seconds
...
the internal value is defined milliseconds
https://webrtc.googlesource.com/src/+/refs/heads/main/video/g3doc/stats.md
while the specification defines it in seconds
https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-qualitylimitationdurations
BUG=webrtc:13548,webrtc:10686
Change-Id: I901c84214c77dd5a6e59f6556a029c8e20cb7672
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245482
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/main@{#35657}
2022-01-11 10:58:35 +00:00
cf00059db6
Remove Win8
...
Bug: chromium:1281336
Change-Id: I490ec704d8f006301ab41dc3380983075032285e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245483
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@google.com >
Cr-Commit-Position: refs/heads/main@{#35656}
2022-01-11 10:27:54 +00:00
0d1e7500fa
Roll chromium_revision 18d61d1673..009ef0607e (957156:957263)
...
Change log: 18d61d1673..009ef0607e18d61d1673..009ef0607e7caae1b5e3..6aa2f94267d2934323c1..3803b801b50367bb1768..8d2e6d58a9ee36306ac2..281b598c1ahttps://chromium.googlesource.com/catapult.git/+log/aa0e8d0564..dc1213869e
* src/tools: cafbb706ae..32e9ed40ea18d61d1673..009ef0607ehttps://webrtc-review.googlesource.com/c/src/+/245620
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35655}
2022-01-10 22:45:44 +00:00
91f55e4dec
Avoid container-overflow in WgcCaptureSession::GetFrame
...
ASAN is throwing a container-overflow because we are accessing a region
in the vector that is valid but does not have an element. We can avoid
this by using resize instead of reserve.
See the documentation for container-overflow for more details:
https://github.com/google/sanitizers/wiki/AddressSanitizerContainerOverflow#:~:text=One%20kind%20of%20bugs%20that%20AddressSanitizer%20can%20find,outside%20of%20the%20current%20container%20bounds.%20Simplest%20example%3A
Bug: webrtc:13541
Change-Id: Id11def90ef8c2cfec9c20f38384547ce6c37b980
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244861
Reviewed-by: Alexander Cooper <alcooper@chromium.org >
Commit-Queue: Austin Orion <auorion@microsoft.com >
Cr-Commit-Position: refs/heads/main@{#35654}
2022-01-10 20:52:24 +00:00
b7fb538abb
Roll chromium_revision 707a3884d2..18d61d1673 (957044:957156)
...
Change log: 707a3884d2..18d61d1673707a3884d2..18d61d16730e6190bb08..7caae1b5e35a364356e2..0367bb17683def6a0243..ee36306ac239c66ea636..6b754d731da95eedec4e..cafbb706ae707a3884d2..18d61d1673https://webrtc-review.googlesource.com/c/src/+/245580
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35653}
2022-01-10 20:31:34 +00:00
400d8bdd60
Remove PacedSender inheritance on Module
...
Bug: webrtc:10937
Change-Id: If9a94f9e49fefa844db215c91425a107fefb3581
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245481
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35652}
2022-01-10 15:56:33 +00:00
62995db2fc
Change default sdp_semantics to kNotSpecified.
...
In preparation for switching the default from kPlanB to kUnifiedPlan,
which could cause subtle bugs for those not prepared for it, we change
the default to kNotSpecified. The only purpose of kNotSpecified is to
crash, forcing any dependencies to explicitly set their sdp_semantics
value.
Tests are updated to explicitly set sdp_semantics when necessary, and
where the test does not care we update to kUnifiedPlan.
If this change lands without getting reverted we can let it sit for a
few weeks, after which we should change the default to kUnifiedPlan and
delete kNotSpecified.
Bug: webrtc:11121
Change-Id: I19b669b0735d78e269e19eaae86c2d7d95a91141
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242968
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35651}
2022-01-10 14:56:03 +00:00
8d49d6f0e6
Roll chromium_revision 98a09f4466..707a3884d2 (956937:957044)
...
Change log: 98a09f4466..707a3884d298a09f4466..707a3884d2dd60a99813..d2934323c111f4f76549..5a364356e285cca6c8d9..3def6a02432cd2b5274d..39c66ea636bf9b1ef905..a25e85ed95ed8b1b4f4c..a95eedec4e98a09f4466..707a3884d2https://webrtc-review.googlesource.com/c/src/+/245520
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35650}
2022-01-10 14:17:20 +00:00
e68d874cf1
Update SetPayloadTypeDemuxingEnabled_w to avoid an unnecessary Invoke.
...
If a call to BaseChannel::SetPayloadTypeDemuxingEnabled does not result
in a demuxer criteria configuration change, we can avoid an Invoke
and speed up negotiations.
Bug: webrtc:11993
Change-Id: I80c894d7cc2a733ab84c1f4978f0c58c09a123a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244920
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35649}
2022-01-10 14:16:04 +00:00
47ff35db61
Delete some unneeded references to module.h and module_api target.
...
Bug: None
Change-Id: Iad983efa8666ca29b5e1ac22b3ade8987dbb2841
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242371
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35648}
2022-01-10 13:40:24 +00:00
6d113eae03
Add ImproveDirection to RampupTests
...
Bug: None
Change-Id: I386e992f33d21f20b0965e6d88a222cbb76d00a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244099
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Stefan Holmer <stefan@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35647}
2022-01-10 12:34:23 +00:00
c58adb753a
Update WebRTC code version (2022-01-10T04:03:02).
...
Bug: None
Change-Id: I99e75bdb6c5c55b33249d7183e5dd755c67cb93c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245365
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35646}
2022-01-10 04:54:49 +00:00
bb350bd941
Roll chromium_revision 2b9ea1db52..98a09f4466 (956835:956937)
...
Change log: 2b9ea1db52..98a09f44662b9ea1db52..98a09f44669f6a4078ec..0e6190bb0889f390ec51..dd60a9981381c7a212b0..11f4f76549fb4620a72b..85cca6c8d928dc7c124f..2cd2b5274d15752f6471..ed8b1b4f4c2b9ea1db52..98a09f4466https://webrtc-review.googlesource.com/c/src/+/245363
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35645}
2022-01-10 02:40:39 +00:00
cc8f127ed9
Roll chromium_revision bb5b8614b9..2b9ea1db52 (956732:956835)
...
Change log: bb5b8614b9..2b9ea1db52bb5b8614b9..2b9ea1db52d4529b6853..9f6a4078eca2a78b6610..89f390ec51c884e7a7ce..a0ace9923e4bf418ebaf..58d1647360e9a5433ee3..81c7a212b03ea6a8123d..fb4620a72b318b87065d..28dc7c124f59e6796cd2..d3cc7ad85ecdc23c442a..15752f6471bb5b8614b9..2b9ea1db52https://webrtc-review.googlesource.com/c/src/+/245200
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35644}
2022-01-08 14:46:27 +00:00
2bc667fdd7
Roll chromium_revision c96a4e7a82..bb5b8614b9 (956529:956732)
...
Change log: c96a4e7a82..bb5b8614b9c96a4e7a82..bb5b8614b946aa1022f8..d4529b68532c1ec5abff..a2a78b6610fd5365d254..e9a5433ee3b1bf58701e..3ea6a8123d083d35c008..318b87065dhttps://boringssl.googlesource.com/boringssl.git/+log/3a667d10e9..295b31324f
* src/third_party/depot_tools: 44dda9648c..59e6796cd24a5dcf9f08..cdc23c442ac96a4e7a82..bb5b8614b9https://webrtc-review.googlesource.com/c/src/+/245122
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35643}
2022-01-08 01:04:06 +00:00
651586c4e1
Move a part of ApplyRemoteDescription() into a separate function.
...
This part is specific to unified plan and doesn't need most of
the state related to the remote description (and doesn't return an
error).
Bug: none
Change-Id: I0de66bdb2e925072a6d9010e4444e75d4574ae04
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245102
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35642}
2022-01-07 19:50:46 +00:00
b625edfa47
Move one part of ApplyRemoteDescription out to a separate function.
...
This is just a step to reduce the size of ApplyRemoteDescription to make
refactoring it easier (and ultimately support async operations).
Bug: none
Change-Id: Idb950c35f585a887d6640278b6edfdd0c7cec3fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245101
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35641}
2022-01-07 18:23:06 +00:00
7ac11436c0
Roll chromium_revision 3aef64d992..c96a4e7a82 (956401:956529)
...
Change log: 3aef64d992..c96a4e7a823aef64d992..c96a4e7a826c873591bb..46aa1022f83fd1fd51c3..2c1ec5abff33c85bc0a7..fd5365d2544492f8d852..083d35c008afb4ca0151..bf9b1ef9050cfc61dead..4a5dcf9f083aef64d992..c96a4e7a82https://webrtc-review.googlesource.com/c/src/+/245062
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35640}
2022-01-07 16:22:56 +00:00
e11a4f5018
Roll chromium_revision cbd0ac46b5..3aef64d992 (955688:956401)
...
This CL also suppresses UseNetworkAnnotations in the AppRTC
Android example app since they are not actionable and Chromium
related.
Change log: cbd0ac46b5..3aef64d992cbd0ac46b5..3aef64d992a83346828c..6c873591bb6593a28f30..3fd1fd51c36a10e3e97c..4bf418ebafeafe83e727..33c85bc0a7ae85d6c117..b1bf58701e6d924d92e5..4492f8d8523846f6d297..bbf740148dhttps://chromium.googlesource.com/catapult.git/+log/5d00ad2e9a..aa0e8d0564
* src/third_party/depot_tools: aae6725ff0..44dda9648c2b672e7210..afb4ca01514d0b131d0a..0cfc61deadcbd0ac46b5..3aef64d992https://webrtc-review.googlesource.com/c/src/+/245003
Commit-Queue: Björn Sundman <bsundman@google.com >
Reviewed-by: Björn Sundman <bsundman@google.com >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35639}
2022-01-07 08:51:46 +00:00
c69453d93b
Change SetLocalContent in channel classes to avoid Invoke.
...
With these changes, we now often have 0 invokes and at most 1 when
calling SetLocalContent on a channel. Before we had at least 1 and
typically 2.
Summary of changes.
* Updating RtpExtension::DeduplicateHeaderExtensions to return a sorted
vector (+test) for easy detection of changes.
* Before updating the transport on the network thread, detect if
actual changes to the demuxer criteria or changes to the rtp header
extensions have been made.
* Consolidate both transport updates to a single call instead of two.
* Added DCHECK guards to catch regressions in number of invokes.
A possible upcoming improvement is to update the transport
asynchronously.
Bug: webrtc:13536
Change-Id: I71ef7b181635a796ffa1e3a02a0f661d28a4870c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244700
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35638}
2022-01-06 12:52:35 +00:00
ac72dda645
Code consolidation in BaseChannel and derived classes.
...
This is a bit of refactoring to clear the way for some more upcoming
changes and fix little oddities here and there that are basically
artifacts of many small incremental changes throughout the years.
* Remove the CryptoOptions member variable and instead only keep around
the filter for rtp header extensions.
* Remove several member methods that only forwarded calls to
media_channel() and effectively reduced readability.
* Consolidated quite a bit of code related to UpdateRemoteStreams_w
and the copy/pasted code in the Video/Voice classes around calling it.
* UpdateRemoteStreams_w now returns an error when it's encountered.
Before, an error would still be returned in those cases but all
operations were unnecessarily performed.
Bug: none
Change-Id: I85a37b9e8f00584aa794abef11abfe89dec5d0a6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244098
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35637}
2022-01-06 12:10:45 +00:00
b463ae1ac7
Add a sanity check of RTCVideoFrame in RTCMTLVideoView
...
Bug: webrtc:13490
Change-Id: I6cca1966c660b2fa36d2d77a816cdd734cce7cf2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244420
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org >
Commit-Queue: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35636}
2022-01-06 10:43:05 +00:00
9467daeea5
Update WebRTC code version (2022-01-06T04:03:19).
...
Bug: None
Change-Id: I581850ec30a9a1639e9898a1a5faae9b6f1e45ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244800
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35635}
2022-01-06 05:21:08 +00:00
0e56787d63
remove legacy datachannel code
...
BUG=webrtc:6625
Change-Id: Ic869c28fe9a24147338b5cd2c830a86b008212f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244506
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/main@{#35634}
2022-01-05 20:36:54 +00:00
fdcef908c2
Roll chromium_revision 5865fbf638..cbd0ac46b5 (955571:955688)
...
Change log: 5865fbf638..cbd0ac46b55865fbf638..cbd0ac46b53ee8bd9270..a83346828cccde4c8b1d..6593a28f30cae0ee8937..eafe83e727da52a284be..6d924d92e5https://chromium.googlesource.com/catapult.git/+log/ec88714291..5d00ad2e9a
* src/tools: 79fd0ff647..4d0b131d0a5865fbf638..cbd0ac46b5https://webrtc-review.googlesource.com/c/src/+/244660
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35633}
2022-01-05 14:26:04 +00:00
d908d74fac
Make error param non-optional when setting local/remote content.
...
This is a slight refactoring while doing some other changes, so not
strictly necessary, but the error param is always supplied in practice
so it made sense to update the tests to reflect that, test that error
values are reported in (at least) some cases and remove the additional
code that checks for whether or not error information is requested.
Bug: none
Change-Id: Ia5739a18ea2beb6970eabf9d809c24dfa43466b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244097
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35632}
2022-01-05 11:59:14 +00:00
9e1386095b
Make the code conform to the code style.
...
Make the jsep_transport.cc code conform to WebRTC code style.
Bug: None
Change-Id: I9142c1e83d4006988e206aeb0bbe52dfffafda60
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244600
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35631}
2022-01-05 11:28:25 +00:00
b496c32901
Enhance thread checks in BaseChannel classes.
...
Improve consistency between using DCHECK checkers and compile time.
For virtual methods, we were sometimes using both and in other cases
we could be using compile time checks but were using runtime.
Added annotation for last_send_params_, last_recv_params_ in
audio/video channel classes.
Also removing redundant logging for when registration with the
transport fails. This is already being logged in the demuxer.
Bug: webrtc:12230
Change-Id: I48e156c9996dec26a990151301dabc06673541d0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244095
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35630}
2022-01-05 10:35:44 +00:00
a89432f94b
Fix explicit ref pointer conversion of MediaStream::AddTrack
...
Previous cl https://webrtc-review.googlesource.com/c/src/+/244090
incorrectly updated the RemoveTrack instead of the AddTrack method,
for audio tracks.
Bug: webrtc:13464
Change-Id: If1c7688c88c4712a3bc9533aa9c7a9b22e87ac8d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244502
Commit-Queue: Niels Moller <nisse@webrtc.org >
Auto-Submit: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35629}
2022-01-05 09:56:53 +00:00
9abd74dc1e
Make RtpDemuxerCriteria's mid_ and rsid_ const.
...
Remove unnecessary optimization from BaseChannel,
previous_demuxer_criteria_, that I'm not seeing as providing value.
Previously it was used to avoid a thread hop if a reconfiguration
wasn't needed, but the way that was done, wasn't thread safe. So after
addressing that issue, the variable more represents increased complexity
in the code than runtime efficiency.
Bug: webrtc:11993, webrtc:12230
Change-Id: Ic8e3e1d2f57e669a168cc7b5cf5d407133976e3c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244093
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35628}
2022-01-05 08:51:44 +00:00
61f70780a3
Roll chromium_revision 68d0813078..5865fbf638 (955449:955571)
...
Change log: 68d0813078..5865fbf63868d0813078..5865fbf638a2971c3d33..3ee8bd92703fecbce0ba..ccde4c8b1d16324f46c6..cae0ee8937d966eedf87..ae85d6c11730cddbaa71..da52a284behttps://chromium.googlesource.com/catapult.git/+log/4311fd4f16..ec88714291
* src/third_party/depot_tools: 4f141d10c1..aae6725ff0cd3621d1d1..79fd0ff64768d0813078..5865fbf638https://webrtc-review.googlesource.com/c/src/+/244580
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35627}
2022-01-05 06:21:23 +00:00
4ef6aaff42
Roll chromium_revision 78c5271178..68d0813078 (955305:955449)
...
Change log: 78c5271178..68d081307878c5271178..68d081307874478d47f5..a2971c3d33f96740745f..3fecbce0bae1335c920e..16324f46c685eacdd9f6..d966eedf87ccbc20e5cf..30cddbaa71https://chromium.googlesource.com/catapult.git/+log/1227b26f32..4311fd4f16
* src/third_party/depot_tools: 92c05b07e4..4f141d10c1b9f6d0a5c5..fbc6faf1c26303738528..123bcd603d8e0c2d7bae..cd3621d1d178c5271178..68d0813078https://webrtc-review.googlesource.com/c/src/+/244520
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35626}
2022-01-05 00:50:53 +00:00
aa81c6bcbe
Roll chromium_revision 66ba4ea647..78c5271178 (955068:955305)
...
Change log: 66ba4ea647..78c527117866ba4ea647..78c52711784f0a4f4661..74478d47f544c14db3f9..f96740745ff87146c860..e1335c920e3f0eed23e1..85eacdd9f6a250a5e753..ccbc20e5cf30ae637731..92c05b07e4fbc6faf1c2..b9f6d0a5c5e780c370b9..6303738528cdac2ec6a3..8e0c2d7bae66ba4ea647..78c5271178https://webrtc-review.googlesource.com/c/src/+/244460
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35625}
2022-01-04 21:08:53 +00:00
09a0d0171c
Deprecate RemoveTrack (old signature)
...
This also removes all internal usage of RemoveTrack, and changes
the replacement function to RemoveTrackOrError rather than RemoveTrackNew.
Bug: webrtc:9534
Change-Id: Idf7bb17495686de77c70428dcbfb12278328ce59
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244094
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35624}
2022-01-04 20:44:07 +00:00
