ee4c930b4e
ice: fix comment about relay preference
...
BUG=webrtc:13195
Change-Id: I86b0ff259cec7d2dc95ba5d7ae1022aca4dcb01c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233260
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35123}
2021-09-30 07:45:19 +00:00
d4aa3a3196
Use absl::string_view in SDP-related utilities
...
A step towards reduced copying in SDP parsing.
Bug: None
Change-Id: I3a5d89f483c1809929b7160b563c67b040c9df41
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233080
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35122}
2021-09-30 07:44:09 +00:00
8afd22f286
Update WebRTC code version (2021-09-30T04:03:50).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I2167226951b7b3f858052847066785091f1c20ed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233386
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35121}
2021-09-30 05:59:18 +00:00
f270770679
video: Implement bandwidth based scaler
...
The |slice_qp_detla| reported by the hardware is not credible, which
causing the quality scaler cannot work properly,the resolution cannot
be adjusted correctly.
To fix this issue, this CL implements a bandwidth scaler which is used
for adjust resolution, this scaler will be used when QP based quality
scaler is not working due to untrusted QP reported by HW AVC encoder.
Bug: webrtc:12942
Change-Id: I2fc5f07a5400ec7e5ead2c2c502faee84d7f2a76
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228860
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Evan Shrubsole <eshr@google.com >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35120}
2021-09-29 10:39:27 +00:00
23bfff3383
Change default parameters for the low-latency video pipeline
...
min_pacing:8ms, to avoid the situation where bursts of frames are sent
to the decoder at once due to network jitter. The bursts of frames
caused the queues further down in the processing to be full and
therefore drop all frames.
max_decode_queue_size:8, in the event that too many frames have piled
up, do as before and send all frames to the decoder to avoid building
up any latency.
These setting only affect the low-latency video pipeline that is enabled
by setting the playout RTP header extension to min=0ms, max>0ms.
Bug: chromium:1138888
Change-Id: I8154bf3efe7450b770da8387f8fb6b23f6be26bd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233220
Commit-Queue: Johannes Kron <kron@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35119}
2021-09-29 09:53:17 +00:00
aa373166f7
Pass a SocketFactory to BasicNetworkManager constructor
...
Used by QueryDefaultLocalAddress, instead of relying on the update
thread's associated socket server.
This is not the only use of rtc::Thread::socketserver() in the
BasicNetworkManager class. It also interacts with the thread's
socket server to call set_network_binder. That is unchanged by this cl,
perhaps those calls can be moved to the caller of StartNetworkMonitor and
StopNetworkMonitor.
Bug: webrtc:13145
Change-Id: If109c2dcb0e74b183e10bb3db7a5aefcc95d1a8c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232613
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35118}
2021-09-29 08:59:37 +00:00
15a0c880cf
dcsctp: Ensure callbacks are always triggered
...
The previous manual way of triggering the deferred callbacks was very
error-prone, and this was also forgotten at a few places.
We can do better.
Using the RAII programming idiom, the callbacks are now ensured to be
called before returning from public methods.
Also added additional debug checks to ensure that there is a
ScopedDeferrer active whenever callbacks are deferred.
Bug: webrtc:13217
Change-Id: I16a8343b52c00fb30acb018d3846acd0a64318e0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233242
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35117}
2021-09-29 08:17:27 +00:00
0081f1c331
dcsctp: Refactor CallbackDeferrer
...
Moving the implementation to a source file.
Bug: webrtc:13217
Change-Id: I2929f4af96a9d01d3adfa49b36b021e4b229a025
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233241
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35116}
2021-09-29 07:13:57 +00:00
43651f502c
AdaptiveDigitalGainApplierTest parametric test fixed
...
Removing an unwanted change introduced by mistake in
https://webrtc-review.googlesource.com/c/src/+/232905 .
Bug: webrtc:7494
Change-Id: Icc01952850f5e20debb42f8a5822fcef49769a6b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233240
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35115}
2021-09-29 06:56:07 +00:00
8581f3d3c6
Update WebRTC code version (2021-09-29T04:04:04).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ic65ea08c6def4c276b1b7505d6e8a4608f10dd18
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233281
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35114}
2021-09-29 05:27:39 +00:00
79326eaca7
Implement missing candidate pair packets/bytes sent/received stats.
...
Specifically:
* packetsSent
* packetsReceived
* packetsDiscardedOnSend
* bytesDiscardedOnSend
Bug: webrtc:10569
Change-Id: Id92c20b93dea57637239a6321bd8aa644867f272
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232961
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35113}
2021-09-28 23:27:05 +00:00
cc4deae951
Roll chromium_revision 6c17347f8a..e2c8b6114c (925841:925965)
...
Change log: 6c17347f8a..e2c8b6114c6c17347f8a..e2c8b6114cdd97a7c912..f03432908f53233d5c4f..b2dbce6eed05e6a5f05e..3c447291ef29637455d9..65fe96e36164904b57c9..11fcbd5f43f5b6ddf39b..d2fe58c115a6ae1e8324..7e14c9353a6c17347f8a..e2c8b6114c6c17347f8a..e2c8b6114cTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Id3725bab534d8610bea1af05edd443fccf86a678
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233192
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35112}
2021-09-28 22:45:25 +00:00
2eef9c98ea
Roll chromium_revision 232a45ecaf..6c17347f8a (925740:925841)
...
Change log: 232a45ecaf..6c17347f8a232a45ecaf..6c17347f8a860dc04ec7..dd97a7c912b471b61fd6..53233d5c4f87a107937c..05e6a5f05e178d9e0060..29637455d99624dc5338..64904b57c945ca14d5ec..f5b6ddf39b6602cbb706..a52c6df38a1ca3e3aad7..76a8111c0cb91099db5f..a6ae1e8324232a45ecaf..6c17347f8a232a45ecaf..6c17347f8aTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I018544009b76b5abbc29751b678a3561ff06cbce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233190
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35111}
2021-09-28 18:39:05 +00:00
47126fa536
Force -Wno-shadow to avoid variable shadowing warnings.
...
Long term, ideally, these would be fixed and this flag can be removed.
For now, this is an expedient way to allow enabling -Wshadow in
Chromium.
Bug: chromium:794619
Change-Id: I7aba1c7bb7dfe0598cdb077cb97def752b8bac79
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232660
Commit-Queue: Peter Kasting <pkasting@chromium.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35110}
2021-09-28 17:53:24 +00:00
5da581b564
AGC2: use only one headroom parameter
...
Instead of using two different headroom parameters, namely
`kHeadroomDbfs` and `kSaturationProtectorExtraHeadroomDb`, only use
the former that now also accounts for the deleted one - i.e., it equals
the sum of the two headrooms. In this way, tuning AGC2 will be easier.
This CL does *not* change the behavior of the AGC2 adaptive digital
controller - bitexactness verified with audioproc_f on a collection of
AEC dumps and Wav files (42 recordings in total).
The unit tests changes in agc2/saturation_protector_unittest.cc are
required since `extra_headroom_db` is removed and the changes in
agc2/adaptive_digital_gain_applier_unittest.cc are required because
`AdaptiveDigitalGainApplier` depends on `kHeadroomDbfs` which has been
updated as stated above.
Bug: webrtc:7494
Change-Id: I0a2a710bbede0caa53938090a004d185fdefaeb9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232905
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35109}
2021-09-28 16:52:16 +00:00
355495a0f2
Roll chromium_revision cb9ab6b9e1..232a45ecaf (925640:925740)
...
Change log: cb9ab6b9e1..232a45ecafcb9ab6b9e1..232a45ecaf4fe659e875..860dc04ec7a76920d402..b471b61fd6fc7f0a187e..87a107937c7c7b5a9283..178d9e0060dc943a63d6..9624dc5338ce514ad38e..45ca14d5ecbcc8151d09..b91099db5fcb9ab6b9e1..232a45ecafTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ie2c0d640cfd013a9c83951c86f64c6a39f3c2cc9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233188
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35108}
2021-09-28 14:25:14 +00:00
7145a1421b
red: fix fmtp payload type collision handling
...
along the lines of RTX handling but with limited support for missing
fmtp lines because of video/red.
BUG=webrtc:13178
Change-Id: Ia866c0e857da6da2ef1e4b81b51f90f534c7bb83
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231948
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35107}
2021-09-28 10:29:54 +00:00
4a1c2c4754
Delete wiring of SignalAddressReady for TCP ports
...
This feature is used only by chromium, and only for UDP sockets.
Bug: webrtc:13065
Change-Id: I207ea643aa57cf23bdd36266895f65f1ee251aaa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232860
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35106}
2021-09-28 10:05:05 +00:00
2f4098830c
Roll chromium_revision ac131c0a6e..cb9ab6b9e1 (925516:925640)
...
Change log: ac131c0a6e..cb9ab6b9e1ac131c0a6e..cb9ab6b9e1ae585d48f4..4fe659e8751e892be46a..a76920d4027578a6a701..fc7f0a187e1743613279..7c7b5a9283f935fb0b37..dc943a63d6https://chromium.googlesource.com/catapult.git/+log/1d51e702a8..2146b04faf
* src/third_party/depot_tools: c11a583b20..ce514ad38e81e324d175..bcc8151d09ac131c0a6e..cb9ab6b9e1TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I02925804c152efe79a1b4feacacfd108d59a5579
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233184
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35105}
2021-09-28 07:06:15 +00:00
5377267367
Update WebRTC code version (2021-09-28T04:02:20).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: If7bdeb9652192614a58537a9d17a5aecd12fd7ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233182
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35104}
2021-09-28 05:37:35 +00:00
f4fa166cc5
dcsctp: Detect the peer SCTP implementation
...
It's to be used for clients to record metrics and to e.g. attribute
metrics to which SCTP implementation the peer was using.
This is not explicitly signaled, so heuristics are used. These are not
guaranteed to come to the correct conclusion, and the data is not always
available.
Note: The behavior of dcSCTP will not change depending on the assumed
implementation - only by explicitly signaled capabilities.
Bug: webrtc:13216
Change-Id: I2f58054d17d53d947ed5845df7a08f974d42f918
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233100
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35103}
2021-09-28 05:10:45 +00:00
11806896bb
Roll chromium_revision f1f05ac6a6..ac131c0a6e (925390:925516)
...
Change log: f1f05ac6a6..ac131c0a6ef1f05ac6a6..ac131c0a6e1c4cd4838a..ae585d48f406577d934b..7578a6a701d1541d5f94..17436132799ac87cbce9..f935fb0b374a17839cda..c11a583b2077083582a8..1ca3e3aad75ee6d4d0bd..81e324d175f1f05ac6a6..ac131c0a6eTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ic8f4fd3e52d3627a303303e3894dc1a7c30c43c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233181
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35102}
2021-09-28 00:44:24 +00:00
3efea37309
Roll chromium_revision 714d043f97..f1f05ac6a6 (925247:925390)
...
Change log: 714d043f97..f1f05ac6a6714d043f97..f1f05ac6a62af195b180..1c4cd4838ae78aad4687..1e892be46ad991e2f05c..06577d934b4770a3e467..d1541d5f946d43d07bfe..9ac87cbce9https://chromium.googlesource.com/catapult.git/+log/444aba89e1..1d51e702a8
* src/third_party/freetype/src: a29e020059..12ef831fc318d0bcdb5c..77083582a880faeb11cc..5ee6d4d0bd714d043f97..f1f05ac6a6TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I60e58bd94c6a1ae4c08ec0f21ab56bbf1c4b7536
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233162
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35101}
2021-09-27 20:35:05 +00:00
8fb41a39e1
Add Direction indicator to TransformableFrames
...
Currently the implementation of FrameTransformers uses distinct,
incompatible types for recevied vs about-to-be-sent frames. This adds a
flag in the interface so we can at least check that we are being given
the correct type. crbug.com/1250638 tracks removing the need for this.
Chrome will be updated after this to check the direction flag and provide
a javascript error if the wrong type of frame is written into the
encoded insertable streams writable stream, rather than crashing.
Bug: chromium:1247260
Change-Id: I9cbb66962ea0718ed47c5e5dba19a8ff9635b0b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232301
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Tony Herre <toprice@chromium.org >
Cr-Commit-Position: refs/heads/main@{#35100}
2021-09-27 17:40:36 +00:00
6ee9734887
AGC2: update adaptive digital test
...
This CL improves `GainController2::CheckGainAdaptiveDigital`, namely:
- correctly initialize AGC2 with the correct number of channels
- attenuate the input signal in order to avoid that the target gain is
set to zero (which was the case before)
- run AG2 adaptive digital for a longer period to allow time to trigger
the adaptive behavior (namely, from 2s to 10s)
- minor code style improvements
Bug: webrtc:7494
Change-Id: Ib41de088b341bb30460238b83e306a507b2bc5af
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233101
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35099}
2021-09-27 16:05:25 +00:00
8d9395d30b
Roll chromium_revision efa07aa310..714d043f97 (925137:925247)
...
Change log: efa07aa310..714d043f97efa07aa310..714d043f97760f85923d..2af195b1806476f40242..e78aad46879d33a71117..a9bc3e2831c883cb129d..50e90b8650a7e4ce09ec..a002c725cfd9721ba040..d991e2f05c8645e2fe04..4770a3e467a146f28025..6d43d07bfe6a1f244444..80faeb11ccefa07aa310..714d043f97TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ia458abeeaf3fab549871cdaefcdeec5cc8dd0b8f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233140
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35098}
2021-09-27 14:36:56 +00:00
acf4f55df3
Delete unused FifoBuffer methods
...
Unused since https://webrtc-review.googlesource.com/c/src/+/186665
Bug: webrtc:11988, webrtc:6424
Change-Id: Ib09e6b862f7550d07d5adf8ce82b74698419730a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233081
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35097}
2021-09-27 14:32:47 +00:00
1ac4f2a29e
AGC2: Remove unused parameters
...
- `NoiseEstimator` and `LevelEstimator` enums
- `vad_probability_attack`
- `level_estimator_adjacent_speech_frames_threshold`
- `use_saturation_protector`
- `gain_applier_adjacent_speech_frames_threshold`
- `initial_saturation_margin_db`
- `extra_saturation_margin_db`
Bug: webrtc:7494
Change-Id: I12e40c8efe2d2126d7597ec18a78cf9d5d39baf2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232903
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35096}
2021-09-27 11:14:35 +00:00
f75f9c2b29
dcsctp: Avoid integer overflow in HEARTBEAT-ACK
...
When a HEARTBEAT is sent out, the current timestamp is stored in the
parameter that will be returned by the HEARTBEAT-ACK. If the timestamp
from the HEARTBEAT-ACK would be from the future (either by jumping
clocks, bit errors, exploiting peer or a fuzzer), the measured RTT would
become really large, and when it was calculated, it would result in an
integer overflow; a wrapping subtraction.
This isn't a problem, as RetransmissionTimeout::ObserveRTT method would
discard measurements that were negative or too large, but it would
trigger an UBSAN violation.
Adding an additional check so that the subtraction doesn't ever wrap.
Bug: chromium:1252515
Change-Id: I1f97b1e773a4639b8193a528716ebd6a27fcb740
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232904
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35095}
2021-09-27 10:52:46 +00:00
29b4049abc
VideoStreamEncoder: Remove check for zero VideoCodec.maxBitrate.
...
maxBitrate is set to a minimum of kEncoderMinBitrateKbps in VideoCodecInitializer::SetupCodec and cannot be zero at this point.
Bug: none
Change-Id: I4e062b054d99fabc1a9650260db03dd45b033c3c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/230142
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35094}
2021-09-27 10:44:36 +00:00
be4b792f76
Update WebRTC code version (2021-09-27T04:05:06).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I732edcf95e15f92df896f62900003f2302879ff2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233069
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35093}
2021-09-27 05:44:35 +00:00
adf6a9a9ed
Roll chromium_revision bd339cd24d..efa07aa310 (925034:925137)
...
Change log: bd339cd24d..efa07aa310bd339cd24d..efa07aa3108a6b825d60..760f85923d9538ba47e9..6476f40242cef991f1f0..d9721ba0408dc9edabb6..8645e2fe04e855bdf6e0..a146f28025f35d3508eb..4a17839cda2506f5177f..6a1f244444bd339cd24d..efa07aa310bd339cd24d..efa07aa310TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I530ed69e09ff36fc5d7d5db0115cfa529244f876
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233068
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35092}
2021-09-27 04:46:15 +00:00
96168abfb7
Update WebRTC code version (2021-09-26T04:03:45).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: If77d0b24a51c03562c1920a3b3e530e4b166b7a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233043
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35091}
2021-09-26 05:42:33 +00:00
b6a73b6923
Roll chromium_revision e0a13a7aa6..bd339cd24d (924934:925034)
...
Change log: e0a13a7aa6..bd339cd24de0a13a7aa6..bd339cd24df5130275ed..8a6b825d60f1655477ae..9538ba47e98be56fc6cf..cef991f1f0e4b537507d..8dc9edabb63be687d501..e855bdf6e0495fe34b48..2506f5177fe0a13a7aa6..bd339cd24dTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ib5e3134b4b00a6657f8a9c0a5a75ad915a3274a4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232983
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35090}
2021-09-25 10:36:24 +00:00
e86431bbd7
Update WebRTC code version (2021-09-25T04:04:40).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I9d6c4ad34cb27b55d1b4573d1b3a718586aa10d9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232980
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35089}
2021-09-25 05:40:22 +00:00
96f2069dce
Roll chromium_revision 716ac22917..e0a13a7aa6 (924783:924934)
...
Change log: 716ac22917..e0a13a7aa6716ac22917..e0a13a7aa66eb36e29ff..f1655477ae5d480199d2..8be56fc6cf2f65f83c1f..e4b537507dbdb0dafe78..3be687d501https://chromium.googlesource.com/catapult.git/+log/3d49e1ccfd..444aba89e1
* src/third_party/depot_tools: a6baf70a45..f35d3508eb159c9ad23e..e4717df71aa450830c30..495fe34b48716ac22917..e0a13a7aa6TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ic7853af84041c5ccb4c93d7978b79571fe16fff5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232925
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35088}
2021-09-24 22:57:13 +00:00
9f0b333076
Test LKGR finder.
...
TBR=tommi@webrtc.org
No-Try: True
Bug: None
Change-Id: Id46ebe08a212843b5a7109b63cd32d40cf3c5a5c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232940
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35087}
2021-09-24 20:09:34 +00:00
889ffa4d26
Roll chromium_revision ca31e240dc..716ac22917 (924631:924783)
...
Change log: ca31e240dc..716ac22917ca31e240dc..716ac22917ba52e9ee09..f5130275edc4acc0edbe..6eb36e29ffa6f9b99b15..5d480199d25082722587..2f65f83c1f229606a187..bdb0dafe786d19b29fbc..a29e0200590174defc3c..a450830c30ca31e240dc..716ac22917TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I615546d2c4b2e3093501aa7306facaadd50a21ee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232922
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35086}
2021-09-24 16:44:52 +00:00
f95f534e7b
Delete deprecated kUri constants for rtp header extensions
...
Bug: webrtc:7472
Change-Id: Ib1af94cc434d93be254370f0d9b6ebaafe8817d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232902
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35085}
2021-09-24 13:18:51 +00:00
29386949a2
AudioProcessing: Add use_predicted_step in GainController1 comparison and string conversion
...
Bug: webrtc:12774
Change-Id: I8d268b343420108a715698ad45fec3c54f0962fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231644
Commit-Queue: Hanna Silen <silen@webrtc.org >
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35084}
2021-09-24 12:46:41 +00:00
8970b49c75
AgcManagerDirect: Add histograms for clipping prediction precision and recall
...
Add histograms WebRTC.Audio.Agc.ClippingPredictor.Precision and WebRTC.Audio.Agc.ClippingPredictor.Recall. The histograms are defined in https://chromium-review.googlesource.com/c/chromium/src/+/3150271 .
Bug: webrtc:12774
Change-Id: I1561ec7a61377c262f636d7aa3a5d5fd60a8839d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231460
Commit-Queue: Hanna Silen <silen@webrtc.org >
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35083}
2021-09-24 12:42:13 +00:00
4275448cbc
Use new CopyOnWriteBuffer ctor/append function in H264PacketBuffer.
...
Bug: none
Change-Id: I02aace124f3f5a578a52348675b346ff890d8d82
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232900
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35082}
2021-09-24 11:18:42 +00:00
fdea8e6244
Roll chromium_revision 05ebbf1d76..ca31e240dc (924489:924631)
...
Change log: 05ebbf1d76..ca31e240dc05ebbf1d76..ca31e240dc419c7d216f..ba52e9ee0930597e8646..c4acc0edbe2f49a48102..a6f9b99b158623b58020..50827225874dcfc0f387..229606a187https://chromium.googlesource.com/catapult.git/+log/818a24d7ba..3d49e1ccfd
* src/third_party/depot_tools: 04d9c83459..a6baf70a455fa6bde05d..0174defc3c05ebbf1d76..ca31e240dcTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I70945aa2aacd2c04fd2a83404c132ed64e647ae5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232885
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35081}
2021-09-24 05:03:03 +00:00
ec56775590
Roll chromium_revision e1ce489c98..05ebbf1d76 (924380:924489)
...
Change log: e1ce489c98..05ebbf1d76e1ce489c98..05ebbf1d765cc18abf20..419c7d216fa3d09a5389..30597e86468eb06c3a14..2f49a48102378b5e510c..8623b580200df8e8353d..4dcfc0f387https://chromium.googlesource.com/catapult.git/+log/e155ea5c89..818a24d7ba
* src/third_party/libyuv: 33a68ec779..b92a60320f3faff3bf6c..5fa6bde05de1ce489c98..05ebbf1d76TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Iaf438e9e720de7c67e2c84876f805e813685b936
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232883
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35080}
2021-09-23 23:29:32 +00:00
f0514d6c24
Roll chromium_revision 11b911b535..e1ce489c98 (924239:924380)
...
Change log: 11b911b535..e1ce489c9811b911b535..e1ce489c98fb08dc04ac..5cc18abf20c2c1dc6ddc..a3d09a53897ea3a871db..9d33a7111770ad47ff1f..8eb06c3a14d7cd466bd1..378b5e510ca6ff92bf7f..0df8e8353db4dddd8244..6d19b29fbc7095880cdb..18d0bcdb5c57de1358e4..3faff3bf6c11b911b535..e1ce489c98TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Iab5d7c6378db4d1c8cf856ebb6bd3aba10c2ce48
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232881
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35079}
2021-09-23 18:41:39 +00:00
a3d8c61313
Do not use UI thread as signaling thread.
...
peerconnection_client sample on Windows is using the current UI thread
as signaling thread. Create a dedicated thread for that purpose.
Bug: webrtc:13104
Change-Id: Iccff8165373101996913c4389cf134a60051462c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/230729
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35078}
2021-09-23 14:42:39 +00:00
7e01b85526
Roll chromium_revision 0ef713da3c..11b911b535 (924112:924239)
...
Change log: 0ef713da3c..11b911b5350ef713da3c..11b911b535bd08169bcd..fb08dc04ac66bad00683..c2c1dc6ddc7c1f1a27db..70ad47ff1f539b2d74c0..d7cd466bd1f94a05a053..a6ff92bf7fhttps://chromium.googlesource.com/catapult.git/+log/4e1760d182..e155ea5c89
* src/third_party/perfetto: 09e840c057..7095880cdb96e83ce704..57de1358e40ef713da3c..11b911b535TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I9003ae8cb0b14e4d1781626322153b1b6127c825
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232840
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35077}
2021-09-23 10:57:50 +00:00
c339142981
LossBweV2: Base ramp up speed on time passed since last backoff.
...
By initialization, time since backoff is unlimited at startup.
Bug: none
Change-Id: I9693cd09b7201606374a8bf9a0a03e6ee83191d3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232611
Commit-Queue: Fanny Linderborg <linderborg@webrtc.org >
Reviewed-by: Fanny Linderborg <linderborg@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35076}
2021-09-23 09:03:59 +00:00
adfe54c965
dcsctp: Remove the TCP style cwnd doubling
...
It wasn't correct and not enabled by default, so just remove it.
Bug: webrtc:12943
Change-Id: Idd426abd0da4ae259e519dd01239b4303296756a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232609
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35075}
2021-09-23 08:06:46 +00:00
3ded8ae88f
Update WebRTC code version (2021-09-23T04:03:48).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Iab41b6f36018601957f3ea96cc9d8a796fae40d5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232782
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#35074}
2021-09-23 05:22:09 +00:00
