24c1778651
Revert r6358 "AppRTCDemo(Android): only stop the cameraThread's looper after stopping the camera."
...
Makes stopping flakier for some reason :/
BUG=
R=glaznev@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6361 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-06 22:24:40 +00:00
171d94177b
AppRTCDemo(Android): only stop the cameraThread's looper after stopping the camera.
...
R=glaznev@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6358 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-06 21:22:37 +00:00
b464618c84
Unbreak NDEBUG compile by RTC_UNUSED()ing an assert()d variable.
...
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19659004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6357 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-06 20:13:49 +00:00
9512719569
AppRTCDemo(android): support app (UI) & capture rotation.
...
Now app UI rotates as the device orientation changes, and the captured stream
tries to maintain real-world-up, matching Chrome/Android and Hangouts/Android
behavior.
BUG=2432
R=glaznev@webrtc.org , henrike@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15689005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6354 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-06 18:40:44 +00:00
42694c5937
VideoCaptureImpl::IncomingFrame(): avoid deadlock by acquiring _apiCs.
...
Since VCI::IF() fires a callback it risks a call back into VCI on the same
stack. Failing to acquire _apiCs before _callbackCs means this is a lock
inversion and deadlock results. By acquiring _apiCs first no lock inversion
occurs and the deadlock is removed.
BUG=3434
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14629004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6353 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-06 18:28:28 +00:00
e6e139159f
Android: cleanup gtest_target_type conditions.
...
Ever since crrev.com/133053 OS==android implies:
gtest_target_type=shared_library
Similar to Chromium's crrev.com/271222 where base.gyp's conditions are changed
(which the affected conditions in this cl comes from).
R=henrike@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13539004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6332 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-04 20:46:50 +00:00
360507b12b
VideoCaptureAndroid: don't synchronized on camera thread.
...
BUG=3421
R=glaznev@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12669004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6295 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-30 23:17:38 +00:00
d6a0efdc86
VideoCaptureAndroid: quit & join the camera thread on stopCapture.
...
Also fix latent bug where setPreviewRotation() wouldn't hold
the lock while its delegate setPreviewRotationOnCameraThread()
was running, allowing the camera to be freed between the
null-check and the use.
BUG=3389
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17619007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6266 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-28 18:37:07 +00:00
637c55f45b
Add support of texture frames for video capturer.
...
This is a reland of r6252. The video_capture_tests failure on
builder Android Chromium-APK Tests should be flaky.
- Add ViECapturer unittest.
- Add CloneFrame function in I420VideoFrame.
- Encoders do not support texture yet and texture frames
are dropped in ViEEncoder for now.
Corresponding CLs:
https://codereview.chromium.org/277943002
http://cl/66620352
BUG=chromium:362437
TEST=WebRTC video stream forwarding, video_engine_core_unittests,
common_video_unittests and video_capture_tests_apk.
TBR=fischman@webrtc.org , perkj@webrtc.org , stefan@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6258 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-28 07:00:51 +00:00
89e8ffb395
Revert "Add support of texture frames for video capturer."
...
This reverts commit 83c89cd003be75d7d06ef9a2b139588f08d280ca.
Reason: The Buildbot has detected a new failure on builder
Android Chromium-APK Tests.
BUG=chromium:362437
TBR=fischman@webrtc.org , perkj@webrtc.org , stefan@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12599004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6253 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-27 14:12:58 +00:00
efe15355ee
Add support of texture frames for video capturer.
...
- Add ViECapturer unittest.
- Add CloneFrame function in I420VideoFrame.
- Encoders do not support texture yet and texture frames
are dropped in ViEEncoder for now.
Corresponding CLs:
https://codereview.chromium.org/277943002
http://cl/66620352
BUG=chromium:362437
TEST=WebRTC video stream forwarding. Run video_engine_core_unittests and common_video_unittests.
R=fischman@webrtc.org , perkj@webrtc.org , stefan@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12499004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6252 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-27 12:40:27 +00:00
7cb4752184
WebRTCDemo: couldn't run a second time. The reason is voe could register/unregister for each run, but vie would expect initialization only once per process.
...
This cl is to teach videocapture android how to deinitialize and allow it to be re-initializable.
BUG=3284
TEST=ManualTest
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6167 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-15 03:18:15 +00:00
3d5cb33da4
Remove WEBRTC_TRACE use in video_capture/
...
Does not touch platform-specific code.
BUG=3153
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11089004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6137 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 08:42:07 +00:00
94f1d4cd55
Fix odd codes in video_capture on Mac.
...
BUG=3272
TEST=vie_auto_test
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6070 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-07 02:57:13 +00:00
8dfe8ff590
Disable capture test for FrameRate on Windows.
...
Flaky on Windows, has been for a while.
R=kjellander@webrtc.org
TBR=mflodman@webrtc.org
BUG=3270
Review URL: https://webrtc-codereview.appspot.com/19389004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5994 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-28 11:27:36 +00:00
8f69330310
Replace scoped_array<T> with scoped_ptr<T[]>.
...
scoped_array is deprecated. This was done using a Chromium clang tool:
http://src.chromium.org/viewvc/chrome/trunk/src/tools/clang/rewrite_scoped_ar ...
except for the few not-built-on-Linux files which were updated manually.
TESTED=trybots
BUG=2515
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5985 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-25 23:10:28 +00:00
c18729165a
Set include_internal_video_capture=1 for video_capture_tests
...
Having this override in the .gypi file avoids having to set it for the bots, which I think is best if we can avoid.
This CL also reverts r5869 so video_capture_tests are compiled for Android again.
BUG=2974,3152
TEST=Successfully ran:
git try -t compile
git try --bot=win_baremetal,mac_baremetal,linux_baremetal -t video_capture_tests
git try --bot=android_apk,android_apk_rel
Verified the change in webrtc/build/apk_tests.gyp makes the build compile successfully from a Chromium+WebRTC configured checkout for Android APK tests.
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11939004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5919 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-16 12:59:49 +00:00
2c89b5cb27
Make everyone an OWNER for .gyp/.gypi add/delete purposes, non-talk/ edition.
...
This CL brought to you by:
$ for d in $(for f in $(git ls-files '*gyp' '*gypi'); do dirname $f; done|sort|uniq|grep -v '^\.$'); do echo -e "\n# These are for the common case of adding or renaming files. If you're doing\n# structural changes, please get a review from a reviewer in this file.\nper-file *.gyp=*\nper-file *.gypi=*" >> $d/OWNERS; done
$ for d in $(for f in $(git ls-files '*gyp' '*gypi'); do dirname $f; done|sort|uniq|grep -v '^\.$'); do git add $d/OWNERS; done
(and then removed the talk/ impact)
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11969004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5903 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-14 20:08:03 +00:00
5cf73962e6
Fix gyp for video_capture/ensure_initialized.cc.
...
This is a follow-up to
https://webrtc-codereview.appspot.com/11359004
which introduced an invalid dependency in the
chromium build when building without linker GC.
BUG=2974,3152,chromium:354405
R=andrew@webrtc.org , fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11789005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5898 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-14 17:26:31 +00:00
f93021430d
Remove self-assignment hacks that were added to avoid unused variable warnings.
...
Instead, appear to use the variables.
BUG=3152
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5877 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-09 21:19:55 +00:00
f4357f3530
Make Android-APK compile in release again.
...
BUG=3152
R=kjellander@webrtc.org
TBR=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11519004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5874 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-09 14:21:37 +00:00
b0b135e4c2
VideoCaptureAndroid: support multiple frame-rates per resolution.
...
Also enables running video_capture_tests_apk on the WebRTC/Chromium APK bots,
assuming GYP_DEFINES includes include_tests=1 and
include_internal_video_capture=1.
This required running VideoCaptureAndroid's camera capture on a dedicated thread, matching other platform's video_capture impls.
BUG=2974,3152
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11359004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5868 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-09 01:18:32 +00:00
f4c9444c65
VideoCaptureAndroid: stop referencing ViERenderer
...
To facilitate building video_capture's java code without video_render's java
code this reorganizes the local-preview hack to be driven by MediaEngine.
This is the "first step" in the linked bug.
BUG=3175
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11349004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5865 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-08 22:55:07 +00:00
984e4fbaaa
video_capture(iOS): move stopCapture to background thread
...
Also suspend frame delivery on stopCapture() to avoid pause+onVideoError
during hangup.
BUG=3162
R=noahric@google.com
Review URL: https://webrtc-codereview.appspot.com/11389004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5863 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-08 21:06:52 +00:00
790385fee4
sink_filter_ds.cc: add lock to Receive procedure to Pause().
...
BUG=2233
TEST=AUTO Test
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/10969004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5827 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-02 02:14:55 +00:00
e52b3b9c95
iOS video_capture: move @private vars to impl.
...
Promised change from https://webrtc-codereview.appspot.com/10539005/ that got
dropped accidentally.
R=noahric@google.com
Review URL: https://webrtc-codereview.appspot.com/10639004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5781 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 18:15:07 +00:00
b64d52c292
iOS video_capture: start camera in the background.
...
Camera start is a blocking operation so never a good idea to do on a main
thread, but worse than that is that the guts of WebView appear to be
interacting with capture start in a bad way causing startup to pause for 10s
while a timeout expires. This change eliminates that 10s delay.
R=noahric@google.com
Review URL: https://webrtc-codereview.appspot.com/10449004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5772 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 05:23:32 +00:00
e68102e046
iOS VideoEngine: move video_{capture,render} to ARC.
...
Replaces ye olde timey explicit release with teh hotness of automatic
reference counting.
This is the webrtc/ half; the talk/ half is in https://webrtc-codereview.appspot.com/10499005/
BUG=3054,3055
R=noahric@google.com
Review URL: https://webrtc-codereview.appspot.com/10539005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5770 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-25 05:15:44 +00:00
f792d17870
AppRTCDemo(iOS): video support; part 1 of 2: webrtc/.
...
(needs to land separately from the rest because PRESUBMIT)
Original review URL: https://webrtc-codereview.appspot.com/9229004
BUG=2168
TESTED=trybots
RISK=P3 (code is unused ATM)
Patch from Sajid Hussain <shussain@temasys.com.sg >.
R=noahric@google.com
Review URL: https://webrtc-codereview.appspot.com/9619004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5671 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-10 17:12:08 +00:00
7bd4a27502
VideoCaptureAndroid: don't deliver frames after stopCapture().
...
Because stopCapture() and onPreviewFrame() are called on different threads, and
are both synchronized, it's possible for onPreviewFrame() to commence execution
after stopCapture() has completed, causing a SEGV because the native code is no
longer prepared to accept frames.
Clarify the contract around synchronized methods in this class to hopefully
avoid similar bugs in future.
BUG=2947
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9339004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5639 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-04 18:17:55 +00:00
8685af7ea0
Remove "Too long processing time of Incoming frame" logspam.
...
This isn't indicative of anything actionable and spams android logcat with times
in the 10-30ms range several times per second.
BUG=2732
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8419004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5527 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-11 17:48:11 +00:00
7433a088d2
Revert 5444 "Revert 5421 "Fix deadlock on register/unregister ob..."
...
We reverted the r5421 to allow us roll webrtc to chrome without any modifications
to libjingle. Since webrtc is rolled with r5444, we can add back the original CL
and changes to libjingle will be upstreamed in the next roll.
TBR=andresp@webrtc.org
> Revert 5421 "Fix deadlock on register/unregister observer while ..."
>
> Failure to compile on Chromium Internal bots, because of API changes.
>
> http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Mac/builds/2805/steps/compile/logs/stdio
>
> You need to follow the steps mentioned in
> https://docs.google.com/a/google.com/document/d/1aHrmXECnu3-Jovc2-zYI267EaQCYz-IclYyBp9iA9Fc/edit that of a API changer.
>
> Since I will be rolling the libjingle this week, I can push your changes along with libjingle roll, if you prepare the CLs
> as mentioned in the doc.
>
> > Fix deadlock on register/unregister observer while there is a an going callback.
> >
> > BUG=2835
> > R=mallinath@webrtc.org
> >
> > Review URL: https://webrtc-codereview.appspot.com/7119005
>
> TBR=andresp@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/7679004
TBR=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7729005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5453 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-29 00:56:02 +00:00
932b0193e7
VideoCaptureAndroid: stop preview in opposite order of starting.
...
While the SDK documentation doesn't prescribe a required shutdown order, good
hygiene suggests stopping should happen in reverse order of starting. It also
seems to relieve a crash in the system capturer on at least the Galaxy Note 10.
BUG=2793
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7549004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5445 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-27 22:32:05 +00:00
18586d38bc
Revert 5421 "Fix deadlock on register/unregister observer while ..."
...
Failure to compile on Chromium Internal bots, because of API changes.
http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Mac/builds/2805/steps/compile/logs/stdio
You need to follow the steps mentioned in
https://docs.google.com/a/google.com/document/d/1aHrmXECnu3-Jovc2-zYI267EaQCYz-IclYyBp9iA9Fc/edit that of a API changer.
Since I will be rolling the libjingle this week, I can push your changes along with libjingle roll, if you prepare the CLs
as mentioned in the doc.
> Fix deadlock on register/unregister observer while there is a an going callback.
>
> BUG=2835
> R=mallinath@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/7119005
TBR=andresp@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7679004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5444 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-27 22:00:57 +00:00
8d375c95b7
Fix deadlock on register/unregister observer while there is a an going callback.
...
BUG=2835
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7119005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5421 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-23 23:09:25 +00:00
f9bdbe3619
Roll chromium_revision 232627:238260
...
This brings us the updated swarming_client
that has moved out from Chromium into a standalone
project.
Because of this, all .isolate files needed to be
updated as well, similar to the changes in
https://codereview.chromium.org/29993003
TEST=trybots passing
BUG=none
R=andrew@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4859004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5260 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-11 13:37:12 +00:00
2ffb149c2c
Replace VideoFrameI420 with I420VideoFrame.
...
Gives one less struct/class for I420 video frames.
BUG=2657
R=mflodman@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4149004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5160 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-22 13:10:13 +00:00
5dd2ecb32d
Revert "Remove extra copy in VideoCaptureImpl::IncomingFrameI420"
...
This reverts commit f4ca3808bd9ec2293ec205f2f4a7d9739ce1f2df.
TBR=niklas.emblom@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/3269004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5071 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-31 23:41:04 +00:00
74e6e8458e
Remove extra copy in VideoCaptureImpl::IncomingFrameI420
...
Add support for aliasing a I420VideoFrame (and internally, a Plane) to an
existing memory buffer without taking ownership. Use this to remove an extra
copy in VideoCaptureImpl::IncomingFrameI420.
BUG=1128
BUG=chromium:310271
TEST=local build, run Chromium on ARM, build, run Chromium/unittests on Linux
TBR=fischman@webrtc.org , mflodman@webrtc.org , mikhal@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3239005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5070 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-31 21:48:16 +00:00
d705649edf
Revert "Remove extra copy in VideoCaptureImpl::IncomingFrameI420"
...
This reverts commit 99f9743fe39066ba93b41f2b0a417696cbbd06fb.
Revert while build breakage is fixed.
BUG=None
TBR=niklas.emblom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3249004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5069 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-31 21:20:15 +00:00
1a4ed0d70c
Remove extra copy in VideoCaptureImpl::IncomingFrameI420
...
Add support for aliasing a I420VideoFrame (and internally, a Plane) to an
existing memory buffer without taking ownership. Use this to remove an extra
copy in VideoCaptureImpl::IncomingFrameI420.
BUG=1128
TEST=local build, run Chromium on ARM, build, run Chromium/unittests on Linux
R=fischman@webrtc.org , mflodman@webrtc.org , mikhal@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3179004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5068 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-31 20:32:28 +00:00
e05362916c
Make sure the first frame isn't dropped.
...
If frames were delivered within the same millisecond as VideoCaptureImpl
was created, or the timestamp weren't granular enough then the first
frame would be mistakenly dropped because of having the same timestamp
as a previous one, even though there was no previous one.
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2599004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5004 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-21 09:02:30 +00:00
4598380860
Android: enable camera video stabilization when available.
...
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2347005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4929 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-04 20:14:19 +00:00
3f9288f987
Add APK and isolate target for video_engine_tests
...
Add .isolate file and _run target for video_engine_tests.
Move tools/swarm_client to be untracked in all .isolate file,
so refactorings in swarm_client doesn't require us updating
all our .isolate files (similar to the changes for the
Chromium tests done in:
https://src.chromium.org/viewvc/chrome?view=rev&revision=218844 )
Update modules_unittests.isolate with new NetEq4 reference files
needed.
TEST=trybots passing
I also setup a Chromium workspace where I patched third_party/webrtc
with the changes in this CL, followed by compiling with the settings
described in
https://code.google.com/p/webrtc/issues/detail?id=1882#c11
I then verified that the video_engine_tests_apk dir was created
in the output folder.
BUG=1916,2462
R=andrew@webrtc.org , henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2344007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4925 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-04 18:20:38 +00:00
4e65e07e41
VideoCaptureAndroid: rewrote the (standalone) implementation of video capture on Android.
...
Besides being ~40% the size of the previous implementation, this makes it so
that VideoCaptureAndroid can stop and restart capture, which is necessary to
support onPause/onResume reasonably on Android.
BUG=1407
R=henrike@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2334004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4915 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-03 18:23:13 +00:00
2a97317953
Fix include of isolate.gypi
...
Recent changes in GYP seem to have broken our previous
"hack" for getting the GYP rule for .isolate files
imported from the Chromium build/isolate.gypi.
The best solution for now is to remove the hack
and check in a copy of Chromium's src/build/isolate.gypi
in WebRTC's build/ dir instead. A similar approach is
used for our build/protoc.gypi file.
TEST=On Linux, I successfully ran:
gclient runhooks
ninja -C out/Release
and verified a bunch of .isolated files were created in
out/Release (which didn't happen before this patch).
I also renamed the build/isolate.gypi from Chromium to
ensure that our own is used and not that one (in case any
paths would be incorrect).
I also ran build/gyp_chromium in a Chromium checkout
with WebRTC in third_party/webrtc having this patch applied
to ensure GYP processing was still working.
Finally, I verified that the same project generation and
compilation from a Chromium checkout worked the way we build
our Android native tests, using:
. build/android/envsetup.sh
GYP_DEFINES="$GYP_DEFINES include_tests=1 enable_tracing=1" gclient runhooks
ninja -C out/Release android_builder_webrtc
BUG=1916
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2338004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4907 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-02 19:31:16 +00:00
1c974ef5e3
Remove include_dirs from video_capture.
...
BUG=1662
TEST=compile on trybots
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2303005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4880 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-30 15:32:10 +00:00
69fc315fd9
Convert DeviceInfoImpl::_captureCapabilities from a map to a vector.
...
The map was just mapping an index to a pointer of a POD, so the code is easily
simplified by using a vector (with implicit index key) and the POD as a value.
(also fixes a leak in the windows code, which lacked a virtual dtor for
VideoCaptureCapabilityWindows but was deleting through a base pointer).
R=perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2298004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4840 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-25 17:01:42 +00:00
334865e2a1
Re-enable VideoCaptureTest.CreateDelete
...
Previously the test insisted on non-zero delay, but 0 is not a crazy delay value
(esp. on a fake camera device!). Instead we now test for delay>=0 being set at
all.
BUG=2405
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2267004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4813 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-23 17:58:45 +00:00
9c74be7bd1
Disable flaky video capture test.
...
BUG=2405
TBR=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2265005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4801 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-20 08:52:31 +00:00
