82c29716c0
Adopt absl::string_view in modules/audio_device/
...
Bug: webrtc:13579
Change-Id: I6e8a90281a9d70a40364b6df5fee4f0a55b4a797
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269060
Commit-Queue: Ali Tofigh <alito@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37607}
2022-07-25 10:35:17 +00:00
6cae2d5513
Reland "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
...
This reverts commit 3f87250a4f0e6c69002fbcdfb995b0dfcd7bf710.
Reason for revert: Downstream is fixed
Original change's description:
> Revert "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
>
> This reverts commit 5f0eb93d2a44cec2102fc8c3757d5bb814bd145f.
>
> Reason for revert: Breaks downstream project. I'm going to fix that one and create a reland of this CL after.
>
> Original change's description:
> > Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely
> >
> > Bug: webrtc:13555, webrtc:13082
> > Change-Id: Iff2cda6f516739419e97e975e03f77a98f74be03
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249260
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Reviewed-by: Artem Titov <titovartem@webrtc.org >
> > Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com >
> > Cr-Commit-Position: refs/heads/main@{#35805}
>
> TBR=hta@webrtc.org ,titovartem@webrtc.org ,daniel.l@hpcnt.com ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: I33d497f1132adfe6d151023195a388d9b7d548f9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:13555, webrtc:13082
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249364
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Owners-Override: Artem Titov <titovartem@webrtc.org >
> Reviewed-by: Andrey Logvin <landrey@webrtc.org >
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35807}
# Not skipping CQ checks because this is a reland.
Bug: webrtc:13555, webrtc:13082
Change-Id: I7ef1ef3b6e3c41b1a96014aa75f003c0fcf33949
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249365
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35814}
2022-01-27 12:55:44 +00:00
3f87250a4f
Revert "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
...
This reverts commit 5f0eb93d2a44cec2102fc8c3757d5bb814bd145f.
Reason for revert: Breaks downstream project. I'm going to fix that one and create a reland of this CL after.
Original change's description:
> Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely
>
> Bug: webrtc:13555, webrtc:13082
> Change-Id: Iff2cda6f516739419e97e975e03f77a98f74be03
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249260
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com >
> Cr-Commit-Position: refs/heads/main@{#35805}
TBR=hta@webrtc.org ,titovartem@webrtc.org ,daniel.l@hpcnt.com ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: I33d497f1132adfe6d151023195a388d9b7d548f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:13555, webrtc:13082
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249364
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Owners-Override: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35807}
2022-01-26 14:56:14 +00:00
5f0eb93d2a
Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely
...
Bug: webrtc:13555, webrtc:13082
Change-Id: Iff2cda6f516739419e97e975e03f77a98f74be03
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249260
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com >
Cr-Commit-Position: refs/heads/main@{#35805}
2022-01-26 14:22:16 +00:00
25ab3228f3
Replace assert() with RTC_DCHECK().
...
CL partially auto-generated with:
git grep -l "\bassert(" | grep "\.[c|h]" | \
xargs sed -i 's/\bassert(/RTC_DCHECK(/g'
And with:
git grep -l "RTC_DCHECK(false)" | \
xargs sed -i 's/RTC_DCHECK(false)/RTC_NOTREACHED()/g'
With some manual changes to include "rtc_base/checks.h" where
needed.
A follow-up CL will remove assert() from Obj-C code as well
and remove the #include of <assert.h>.
The choice to replace with RTC_DCHECK is because assert()
is because RTC_DCHECK has similar behavior as assert()
based on NDEBUG.
This CL also contains manual changes to switch from
basic RTC_DCHECK to other (preferred) versions like
RTC_DCHECK_GT (and similar).
Bug: webrtc:6779
Change-Id: I00bed8886e03d685a2f42324e34aef2c9b7a63b0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224846
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34442}
2021-07-09 07:49:43 +00:00
10542f21c8
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
...
Mechanically generated by running this command:
tools_webrtc/do-renames.sh update all-renames.txt && git cl format
Then manually updating:
tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833
Reviewed-on: https://webrtc-review.googlesource.com/c/115653
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 17:11:39 +00:00
1c0cf3101d
Stop using typeof() GNU extension
...
6009a54aabhttps://webrtc-review.googlesource.com/94779
Commit-Queue: Oleh Prypin <oprypin@google.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#24337}
2018-08-20 08:15:13 +00:00
665174fdbb
Reformat the WebRTC code base
...
Running clang-format with chromium's style guide.
The goal is n-fold:
* providing consistency and readability (that's what code guidelines are for)
* preventing noise with presubmit checks and git cl format
* building on the previous point: making it easier to automatically fix format issues
* you name it
Please consider using git-hyper-blame to ignore this commit.
Bug: webrtc:9340
Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87
Reviewed-on: https://webrtc-review.googlesource.com/81185
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 14:00:39 +00:00
92ea95e34a
Fixing WebRTC after moving from src/webrtc to src/
...
In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC
from src/webrtc to src/ (in order to preserve an healthy git history).
This CL takes care of fixing header guards, #include paths, etc...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578
Reviewed-on: https://webrtc-review.googlesource.com/1561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 05:02:56 +00:00
bb547203bf
Moving src/webrtc into src/.
...
In order to eliminate the WebRTC Subtree mirror in Chromium,
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00
