808a8fc29e
TrackMediaInfoMap: Use rtc::ArrayView in Initialize.
...
Drive-by improvement as suggested in
https://webrtc-review.googlesource.com/c/src/+/269404 .
Bug: webrtc:14289
Change-Id: Ib6579916cb4ab1076c1522275b318859400b731e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269202
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37625}
2022-07-27 11:28:25 +00:00
fc67b455e6
[ModernStats] Replace uses of std::unique_ptr<> with absl::optional<>.
...
Optional better describes "optionality" so let's do it for the sake of
style. But a side-effect of switching to optional may be better memory
locality than std::unique_ptr<>. (Anecdotally I saw a pprof suggesting a
significant amount of time being spent allocating/reading these maps.
This CL is unlikely to make the difference but it can't hurt.)
Bug: webrtc:14289
Change-Id: I7dcea9625b95c2f1a23e7d9595d27b58883570e2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269404
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37624}
2022-07-27 11:18:41 +00:00
afb246b5a9
Update pc/ to not use implicit conversion from scoped_refptr<T> to T*.
...
Bug: webrtc:13464
Change-Id: I768646af8ded6338ef51486b8d69db1ad71e9a2c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259500
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36588}
2022-04-20 13:18:33 +00:00
c24a2189d7
Update IWYU tool with a mapping file
...
Also apply IWYU to all .cc files in pc/, and correct BUILD file to match.
Note: Some files came out wrong when iwyu was applied. These are not included.
Bug: none
Change-Id: Ib5ea46b8fcc505414d0447cca7218ad3afc2e321
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252280
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36064}
2022-02-24 11:05:06 +00:00
880fa8169b
Reland "Use backticks not vertical bars to denote variables in comments for /pc"
...
Original change's description:
> Revert "Use backticks not vertical bars to denote variables in comments for /pc"
>
> This reverts commit 37ee0f5e594dd772ec6d620b5e5ea8a751b684f0.
>
> Reason for revert: Revert in order to be able to revert https://webrtc-review.googlesource.com/c/src/+/225642
>
> Original change's description:
> > Use backticks not vertical bars to denote variables in comments for /pc
> >
> > Bug: webrtc:12338
> > Change-Id: I88cf10afa5fc810b95d2a585ab2e895dcc163b63
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226953
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Commit-Queue: Artem Titov <titovartem@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#34575}
>
> TBR=hta@webrtc.org ,titovartem@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: I5eddd3a14e1f664bf831e5c294fbc4de5f6a88af
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:12338
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227082
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Commit-Queue: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34577}
Bug: webrtc:12338
Change-Id: I96bd229b73613c162d11d75fa4f5934e1b4295c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227087
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34611}
2021-07-30 22:13:59 +00:00
fd05d6f504
Revert "Use backticks not vertical bars to denote variables in comments for /pc"
...
This reverts commit 37ee0f5e594dd772ec6d620b5e5ea8a751b684f0.
Reason for revert: Revert in order to be able to revert https://webrtc-review.googlesource.com/c/src/+/225642
Original change's description:
> Use backticks not vertical bars to denote variables in comments for /pc
>
> Bug: webrtc:12338
> Change-Id: I88cf10afa5fc810b95d2a585ab2e895dcc163b63
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226953
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#34575}
TBR=hta@webrtc.org ,titovartem@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: I5eddd3a14e1f664bf831e5c294fbc4de5f6a88af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:12338
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227082
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34577}
2021-07-27 22:10:24 +00:00
37ee0f5e59
Use backticks not vertical bars to denote variables in comments for /pc
...
Bug: webrtc:12338
Change-Id: I88cf10afa5fc810b95d2a585ab2e895dcc163b63
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226953
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34575}
2021-07-27 20:52:02 +00:00
5761e7b3ff
Running apply-iwyu on ~all files in pc/
...
Bug: none
Change-Id: Ieebdfb743e691f7ae35e1aa354f68ce9e771064d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/204381
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33105}
2021-01-29 16:14:10 +00:00
6fafbe3cee
[Stats] Optimization: Minimize number of thread-invokes in getStats().
...
TrackMediaInfoMap was previously constructed on the signaling thread. It
would iterate all the senders and receivers and perform GetParameters(),
which internally would invoke on the worker thread. This resulted in as
many thread-invokes as number of receivers.
With this CL we piggyback on an existing thread-invoke, performing a
single blocking invoke for all transceivers. This is good for
performance when there is a lot of thread contention.
The code is already exercised by unit tests and integration tests.
rtc::Thread::ScopedDisallowBlockingCalls is added to DCHECK that we
don't accidentally do any other blocking invokes.
A couple of unnecessary DCHECKs had to be removed to avoid PROXY
invokes back to the signaling thread (deadlock). These DCHECKs won't be
missed.
Bug: webrtc:11716
Change-Id: I139c7434682ff627bb88351b5752320dd322d9eb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178816
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31666}
2020-07-08 10:12:59 +00:00
a0ff50c031
Reland "Improve outbound-rtp statistics for simulcast"
...
This reverts commit 9a925c9ce33a6ccdd11b545b11ba68e985c2a65d.
Reason for revert: The original CL is updated in PS #2 to
fix the googRtt issue which was that when the legacy sender
stats were put in "aggregated_senders" we forgot to update
rtt_ms the same way that we do it for "senders".
Original change's description:
> Revert "Improve outbound-rtp statistics for simulcast"
>
> This reverts commit da6cda839dac7d9d18eba8d365188fa94831e0b1.
>
> Reason for revert: Breaks googRtt in legacy getStats API
>
> Original change's description:
> > Improve outbound-rtp statistics for simulcast
> >
> > Bug: webrtc:9547
> > Change-Id: Iec4eb976aa11ee743805425bedb77dcea7c2c9be
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168120
> > Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> > Reviewed-by: Erik Språng <sprang@webrtc.org >
> > Reviewed-by: Henrik Boström <hbos@webrtc.org >
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Commit-Queue: Eldar Rello <elrello@microsoft.com >
> > Cr-Commit-Position: refs/heads/master@{#31097}
>
> TBR=hbos@webrtc.org ,sprang@webrtc.org ,stefan@webrtc.org ,srte@webrtc.org ,hta@webrtc.org ,elrello@microsoft.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: webrtc:9547
> Change-Id: I06673328c2a5293a7eef03b3aaf2ded9d13df1b3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174443
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Commit-Queue: Henrik Boström <hbos@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#31165}
TBR=hbos@webrtc.org ,sprang@webrtc.org ,stefan@webrtc.org ,srte@webrtc.org ,hta@webrtc.org ,elrello@microsoft.com
# Not skipping CQ checks because this is a reland.
Bug: webrtc:9547
Change-Id: I723744c496c3c65f95ab6a8940862c8b9f544338
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174480
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31169}
2020-05-05 20:22:19 +00:00
9a925c9ce3
Revert "Improve outbound-rtp statistics for simulcast"
...
This reverts commit da6cda839dac7d9d18eba8d365188fa94831e0b1.
Reason for revert: Breaks googRtt in legacy getStats API
Original change's description:
> Improve outbound-rtp statistics for simulcast
>
> Bug: webrtc:9547
> Change-Id: Iec4eb976aa11ee743805425bedb77dcea7c2c9be
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168120
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Eldar Rello <elrello@microsoft.com >
> Cr-Commit-Position: refs/heads/master@{#31097}
TBR=hbos@webrtc.org ,sprang@webrtc.org ,stefan@webrtc.org ,srte@webrtc.org ,hta@webrtc.org ,elrello@microsoft.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:9547
Change-Id: I06673328c2a5293a7eef03b3aaf2ded9d13df1b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174443
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31165}
2020-05-05 13:38:51 +00:00
da6cda839d
Improve outbound-rtp statistics for simulcast
...
Bug: webrtc:9547
Change-Id: Iec4eb976aa11ee743805425bedb77dcea7c2c9be
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168120
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Eldar Rello <elrello@microsoft.com >
Cr-Commit-Position: refs/heads/master@{#31097}
2020-04-17 11:28:00 +00:00
739baf097b
[clang-tidy] Apply performance-for-range-copy fixes.
...
This CL applies clang-tidy's performance-for-range-copy [1] on the
WebRTC codebase.
All changes in this CL are automatically generated by both clang-tidy
and 'git cl format'.
[1] - https://clang.llvm.org/extra/clang-tidy/checks/performance-for-range-copy.html
Bug: webrtc:10215
Change-Id: I7c83290b8866d76129bbec4e24e6701f5014102e
Reviewed-on: https://webrtc-review.googlesource.com/c/120043
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26420}
2019-01-28 09:53:50 +00:00
10542f21c8
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
...
Mechanically generated by running this command:
tools_webrtc/do-renames.sh update all-renames.txt && git cl format
Then manually updating:
tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833
Reviewed-on: https://webrtc-review.googlesource.com/c/115653
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 17:11:39 +00:00
1c05765831
(3) Rename files to snake_case: move the files
...
Mechanically generated with this command:
tools_webrtc/do-rename.sh move all-renames.txt
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I8b05b6eab9b9d18b29c2199bbea239e9add1e690
Reviewed-on: https://webrtc-review.googlesource.com/c/115481
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26225}
2019-01-11 17:05:20 +00:00
