b468616a69
Reland "Reland "Improving robustness of feedback matching code in event log parser.""
...
This is a reland of 0870c70b0471c3bae16ad9a6732d812ee25446dd
Original change's description:
> Reland "Improving robustness of feedback matching code in event log parser."
>
> This is a reland of a1e4fbb25371867349a0c2ed6ba62224735a2ec7
>
> Original change's description:
> > Improving robustness of feedback matching code in event log parser.
> >
> > Removes the dependency on TransportFeedbackAdapter thereby removing
> > some of the complexity that came with it, in particular, we don't fill
> > in missing packets. This makes the code easier to debug and avoids some
> > confusing logging that's not relevant for the parser.
> >
> > Bug: webrtc:9883
> > Change-Id: I6df8425e8ab410514727c51a5e8d4981d6561f03
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133347
> > Reviewed-by: Stefan Holmer <stefan@webrtc.org >
> > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#27739}
>
> Bug: webrtc:9883
> Change-Id: I460d0c576626614fb4ce2c3d5e3ddbb5d1c122cf
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134106
> Reviewed-by: Stefan Holmer <stefan@webrtc.org >
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27763}
Bug: webrtc:9883
Change-Id: I1f80ed1f63ad75fbb97f5f401fe486d19c057f75
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134462
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27829}
2019-05-02 16:10:37 +00:00
4fb12b0cae
Reland "Copy video frames metadata between encoded and plain frames in one place"
...
Reland with fixes.
Currently some video frames metadata like rotation or ntp timestamps are
copied in every encoder and decoder separately. This CL makes copying to
happen at a single place for send or receive side. This will make it
easier to add new metadata in the future.
Also, added some missing tests.
Original Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133346
Bug: webrtc:10460
Change-Id: Ia71198685de7fbd990704b575231cdce94dc0645
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134961
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27828}
2019-05-02 13:29:14 +00:00
cd936fdba5
Wait for keyframe after decoding error.
...
Bug: chromium:936715
Change-Id: I0a51c8fa0025cb0f8e9afcbe8d8e4a84c2709ecf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134960
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27827}
2019-05-02 12:52:55 +00:00
7e03b43a00
Roll chromium_revision 449727e860..b510663a62 (655859:655963)
...
Change log: 449727e860..b510663a62
Full diff: 449727e860..b510663a62
Changed dependencies
* src/base: ee68bb78b0..bddb038ee2
* src/build: a74a0f2344..d6fe3ed558
* src/ios: 8d191b35b9..3960720019
* src/testing: 856011735a..2108976644
* src/third_party: ce2873b79a..92a0f7d8e9
* src/third_party/depot_tools: 020b429fbf..fe1dbe120c
* src/third_party/ffmpeg: 1b9f48f542..4500d7f55f
* src/third_party/nasm: 076332ea7c..c8b248039e
* src/tools: 7aa01c80e2..4650a49d48
DEPS diff: 449727e860..b510663a62
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I7ddc2c8c3ecc66b67ab973a27534bafab52edaea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134947
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27826}
2019-05-02 12:30:45 +00:00
d42a4490fb
Reland "Add more adaptation text logs for VideoSendStream."
...
This is a reland of d0298f4b161fe2afd4c6b334da31218c115a7eeb
Original change's description:
> Add more adaptation text logs for VideoSendStream.
>
> Tested: Manual tests in app.
> Bug: None
> Change-Id: I2739a23d37c05cbe1ba9be5c788d1c647265a895
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133186
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27644}
Bug: None
Change-Id: Ieb0b0a686e4e892ef154a63b796463f5fb95df77
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133172
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27825}
2019-05-02 11:44:06 +00:00
2db5fc00c0
Deprecating injection of event log into GoogCC factory.
...
Bug: webrtc:9883
Change-Id: I6087b4a0a2c934e6a9ab435fffaf2eb1fc2a29e4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134644
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27824}
2019-05-02 11:05:17 +00:00
d9c2d94620
Move ownership of VCMJitterEstimator to FrameBuffer
...
Bug: webrtc:7408
Change-Id: I8b33ead80abff1e84ae0b223e108266f71f03e2f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134180
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27823}
2019-05-02 10:57:04 +00:00
b93c4e622f
Add propagation of test duration to PC framework user.
...
Add method to get real test execution time, where test execution time is
time from call setup to call terminated.
Bug: webrtc:10138
Change-Id: I7ae3995c0051ecb4fc796b895be1180c8aab77cf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134302
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Bjorn Mellem <mellem@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27822}
2019-05-02 10:20:26 +00:00
e82266836b
Adds control of active layers in scenario tests.
...
Bug: webrtc:9510
Change-Id: I889633650885d8ceb529c879febee811e4934b47
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134647
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27821}
2019-05-02 10:13:26 +00:00
bc7f41b231
ManageFrameH264 for temporal layers (PART 3/3)
...
Bug: webrtc:10579
Change-Id: Iec54f6b1231d34c2018f22841c3614ddd0b05612
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/86200
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27820}
2019-05-02 09:26:25 +00:00
c80e4d756e
Roll chromium_revision 45d077a570..449727e860 (655737:655859)
...
Change log: 45d077a570..449727e860
Full diff: 45d077a570..449727e860
Changed dependencies
* src/base: 695b663445..ee68bb78b0
* src/build: fa8c3cb895..a74a0f2344
* src/ios: 5c1e95e0fa..8d191b35b9
* src/testing: 5723392f30..856011735a
* src/third_party: 0d970f9502..ce2873b79a
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b931deacdf..5a34ef7bda
* src/third_party/depot_tools: 867e3c9511..020b429fbf
* src/tools: 4339ed2534..7aa01c80e2
DEPS diff: 45d077a570..449727e860
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ibcd629f0f43398c248203c5999e409cea0a4dda8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134917
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27819}
2019-05-02 01:34:45 +00:00
a0421d3d0c
Roll chromium_revision b893403b98..45d077a570 (655617:655737)
...
Change log: b893403b98..45d077a570
Full diff: b893403b98..45d077a570
Changed dependencies
* src/base: bc54bf21f3..695b663445
* src/build: 8dda7d4393..fa8c3cb895
* src/ios: 32bde7e092..5c1e95e0fa
* src/testing: 8969614b5d..5723392f30
* src/third_party: 036cfdbff3..0d970f9502
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/178118d233..b931deacdf
* src/third_party/depot_tools: b3aca437d0..867e3c9511
* src/tools: 3ec5c2eb43..4339ed2534
DEPS diff: b893403b98..45d077a570
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I39987af0bfb76b01076873c2359604866f0f7fe5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134913
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27818}
2019-05-01 20:29:59 +00:00
2d9d82ecef
Implement RTCRtpTransceiver.setCodecPreferences
...
SetCodecPreferences allows clients to filter and reorder codecs in their
SDP offer and answer.
Bug: webrtc:9777
Change-Id: I716bed9b06496629b45210883b286f599c875239
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129727
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Seth Hampson <shampson@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27817}
2019-05-01 20:14:59 +00:00
2ad2fabdcf
Determine if it's HDR color space based on VUI or RTP header extension
...
The color space can either be specified in the VUI of the H264 bitstream
or using an RTP header extension. The color space set through the RTP
header extension overrides the color space in the VUI. The check for
HDR should look at the resulting color space.
Bug: webrtc:10575
Change-Id: I0ca6262d76d56dea938de169f55ad3894e6c4f8f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134860
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27816}
2019-05-01 17:22:52 +00:00
3c4a69f103
Roll chromium_revision 257605a269..b893403b98 (655514:655617)
...
Change log: 257605a269..b893403b98
Full diff: 257605a269..b893403b98
Changed dependencies
* src/base: ffcfa2d196..bc54bf21f3
* src/build: 01e48f95c8..8dda7d4393
* src/ios: a8376c6dd5..32bde7e092
* src/testing: 61ec1e361c..8969614b5d
* src/third_party: 90d336f53b..036cfdbff3
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c86b091be0..178118d233
* src/tools: f9e14633df..3ec5c2eb43
DEPS diff: 257605a269..b893403b98
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I695bd2ff1db5456d08bbe0f0a8a1bdebca8a8129
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134909
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27815}
2019-05-01 16:30:52 +00:00
37346ed36d
Roll chromium_revision 56b471e0c7..257605a269 (655404:655514)
...
Change log: 56b471e0c7..257605a269
Full diff: 56b471e0c7..257605a269
Changed dependencies
* src/base: c596770dde..ffcfa2d196
* src/build: bfd7655c15..01e48f95c8
* src/ios: 0e1b573e4b..a8376c6dd5
* src/third_party: ca5ee9b5cc..90d336f53b
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f88be3bdf9..c86b091be0
* src/third_party/depot_tools: f61af56950..b3aca437d0
* src/third_party/googletest/src: a53e931dcd..9997a830ee
* src/third_party/libFuzzer/src: ff7e2bdf49..e9b95bcfe2
* src/tools: d76c32ab8a..f9e14633df
DEPS diff: 56b471e0c7..257605a269
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ie84b5ffeb09bc134a952eeee73827ac630e664ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134843
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27814}
2019-05-01 02:39:33 +00:00
2bb3e4315d
Roll chromium_revision 6fce3ce354..56b471e0c7 (655242:655404)
...
Change log: 6fce3ce354..56b471e0c7
Full diff: 6fce3ce354..56b471e0c7
Changed dependencies
* src/base: c29ce44d64..c596770dde
* src/build: 54ea0e7fd1..bfd7655c15
* src/ios: 576e549463..0e1b573e4b
* src/testing: 32e614b7ec..61ec1e361c
* src/third_party: 2ef58d1822..ca5ee9b5cc
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2dd550aaf0..f88be3bdf9
* src/third_party/depot_tools: 4ef3221c5d..f61af56950
* src/third_party/icu: 35f7e139f3..ae4b77dc89
* src/tools: 233b8fcedf..d76c32ab8a
DEPS diff: 6fce3ce354..56b471e0c7
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Id0f78c41d612dac86e62fc7532322f29c3080926
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134820
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27813}
2019-04-30 22:48:38 +00:00
756391a4c2
Roll chromium_revision 97b3163085..6fce3ce354 (655135:655242)
...
Change log: 97b3163085..6fce3ce354
Full diff: 97b3163085..6fce3ce354
Changed dependencies
* src/base: 39779483a3..c29ce44d64
* src/build: 4087d634b4..54ea0e7fd1
* src/ios: 24bf03d009..576e549463
* src/testing: f9d4b00f41..32e614b7ec
* src/third_party: b2df83936f..2ef58d1822
* src/tools: c1eff67810..233b8fcedf
DEPS diff: 97b3163085..6fce3ce354
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I3b9b21842314186af0a92c7170c95a041bdda998
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134720
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27812}
2019-04-30 16:31:36 +00:00
b1070353ad
Prevent memory over-consumption by DefaultTemporalLayers
...
Erase pending frames after they had been used.
Bug: chromium:956510
Change-Id: I55eec75dab9bbe350dd1b089953bdc2979d989fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134641
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27811}
2019-04-30 11:44:21 +00:00
b67bea1258
Roll chromium_revision 97c11a4d77..97b3163085 (655030:655135)
...
Change log: 97c11a4d77..97b3163085
Full diff: 97c11a4d77..97b3163085
Changed dependencies
* src/base: 2bad9f2843..39779483a3
* src/build: a9246b2250..4087d634b4
* src/ios: 8740703f61..24bf03d009
* src/testing: 2b754d5dd2..f9d4b00f41
* src/third_party: d7605f4460..b2df83936f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3e4feb80ae..2dd550aaf0
* src/third_party/depot_tools: 8fac969edd..4ef3221c5d
* src/tools: fceae10783..c1eff67810
DEPS diff: 97c11a4d77..97b3163085
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I571176b5c8c9fb1ed4297080de685b3e1d1d3a74
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134623
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27810}
2019-04-30 06:30:53 +00:00
333114658d
Roll chromium_revision 1fb8a450ee..97c11a4d77 (654920:655030)
...
Change log: 1fb8a450ee..97c11a4d77
Full diff: 1fb8a450ee..97c11a4d77
Changed dependencies
* src/base: 2af8bebee4..2bad9f2843
* src/build: 2027c297de..a9246b2250
* src/ios: 5879416393..8740703f61
* src/testing: c609abba43..2b754d5dd2
* src/third_party: 858db5eede..d7605f4460
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/72493839e6..3e4feb80ae
* src/third_party/depot_tools: 6837707f80..8fac969edd
* src/tools: 83dc6f6218..fceae10783
DEPS diff: 1fb8a450ee..97c11a4d77
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ic953e73cd1591fa54633e589f31729b8578bed6e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134562
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27809}
2019-04-29 21:52:35 +00:00
bc6a4d094f
Roll chromium_revision 8ce20eb94f..1fb8a450ee (654807:654920)
...
Change log: 8ce20eb94f..1fb8a450ee
Full diff: 8ce20eb94f..1fb8a450ee
Changed dependencies
* src/base: 283a7cc0bd..2af8bebee4
* src/build: d54bb94b63..2027c297de
* src/ios: 5673ce57ca..5879416393
* src/testing: 842b6f5d4f..c609abba43
* src/third_party: fa02d7d92e..858db5eede
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d235eb2365..72493839e6
* src/third_party/libFuzzer/src: e847d8a9b4..ff7e2bdf49
* src/tools: f19ce6ce3c..83dc6f6218
DEPS diff: 8ce20eb94f..1fb8a450ee
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I660ad97e45c8d8606e5974ccb5e472ce09a71d7c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134542
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27808}
2019-04-29 18:40:09 +00:00
c1187ab34b
Partially revert https://webrtc-review.googlesource.com/c/src/+/110461 .
...
X11 returns the image data in a |long|, and CL [1] broke the captured
on 32-bit builds.
[1] - https://webrtc-review.googlesource.com/c/src/+/110461
Bug: chromium:954762
Change-Id: I2620e977ed0dd7ae355b9acd938cfcbeaaa9bfb3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134541
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Wez <wez@google.com >
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org >
Cr-Commit-Position: refs/heads/master@{#27807}
2019-04-29 18:26:49 +00:00
44125faba5
Reland "Piping audio interruption metrics to API layer"
...
The metrics are now added as RTCNonStandardStatsMember objects in
RTCMediaStreamTrackStats. Unit tests are updated.
This is a reland of https://webrtc-review.googlesource.com/c/src/+/134303 ,
with fixes.
TBR=kwiberg@webrtc.org
Bug: webrtc:10549
Change-Id: I29dcc6fbfc69156715664e71acfa054c1b2d9038
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134500
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27806}
2019-04-29 15:39:50 +00:00
7cca042dd4
Refactor FrameBuffer2 tests, without mocking the jitter estimator
...
Bug: webrtc:7408
Change-Id: Ibded415aefebb9b922ec88c8f5f7fb7ff23cf28d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134467
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27805}
2019-04-29 14:41:45 +00:00
a7caaf07a1
Change AlrDetector to be able to set field trials that only affect AlrDetector
...
Bug: webrtc:10542
Change-Id: If7cb4086dfcfb313c6ffc0b8f662b8eae5bd4355
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134200
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27804}
2019-04-29 13:46:35 +00:00
c0c7d36e80
RNN VAD: clean-up unit tests
...
- add test that checks that the computed VAD probability is within
tolerance *1
- speed-up some tests by reducing the input length and skipping frames
- remove unused code in test_utils
- fix some comments
*1: RnnVadTest::RnnBitExactness is replaced by
RnnVadTest::RnnVadProbabilityWithinTolerance
Bug: webrtc:10480
Change-Id: I19332d06eacffbbe671bf7749ff4c92798bdc55c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133910
Reviewed-by: Alex Loiko <aleloi@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27803}
2019-04-29 12:55:02 +00:00
fc02a793c2
Revert "Piping audio interruption metrics to API layer"
...
This reverts commit 299c4e68461f1c4428b2a919913b161115025dff.
Reason for revert: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win10%20Tester/2753
../../chrome/browser/media/webrtc/webrtc_browsertest_base.cc(539): error: Expected equality of these values:
"ok-got-stats"
ExecuteJavascript("verifyLegacyStatsGenerated()", tab)
Which is: "Test failed: Error: \"googInterruptionCount\" is not a whitelisted stat. Exposing new metrics in the legacy getStats() API is not allowed. Please follow the standardization process: https://docs.google.com/document/d/1q1CJVUqJ6YW9NNRc0tENkLNny8AHrKZfqjy3SL89zjc/edit?usp=sharing\n at failTest (http://127.0.0.1:50650/webrtc/test_functions.js:46:15 )\n at http://127.0.0.1:50650/webrtc/peerconnection.js:481:19 "
With diff:
@@ -1,1 +1,3 @@
-ok-got-stats
+Test failed: Error: \"googInterruptionCount\" is not a whitelisted stat. Exposing new metrics in the legacy getStats() API is not allowed. Please follow the standardization process: https://docs.google.com/document/d/1q1CJVUqJ6YW9NNRc0tENkLNny8AHrKZfqjy3SL89zjc/edit?usp=sharing
+ at failTest (http://127.0.0.1:50650/webrtc/test_functions.js:46:15 )
+ at http://127.0.0.1:50650/webrtc/peerconnection.js:481:19
Original change's description:
> Piping audio interruption metrics to API layer
>
> Bug: webrtc:10549
> Change-Id: Ie6abe5819c5b73dc5f5f89bdc375bad77f44ce97
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134303
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
> Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27788}
TBR=henrik.lundin@webrtc.org ,kwiberg@webrtc.org ,ivoc@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:10549
Change-Id: I345306ba9758c0a3b1597724fa860d3e3fdb8995
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134464
Commit-Queue: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27802}
2019-04-29 11:23:16 +00:00
98499d5a20
Remove deprecated AudioDeviceModule factory
...
Bug: webrtc:10284
Change-Id: If1c732b113c5d340dfc800f55f4d567576e82ce3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132222
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27801}
2019-04-29 11:22:11 +00:00
b6e24d7f35
Only create AECm when needed
...
This CL ensures that the AECm is only created when needed.
The changes in the CL are bitexact when running AECm via
audioproc_f
The CL also corrects an issue where there is a risk for
AEC2 to not be correctly setup when the sample rate
changes inbetween activations.
Bug: webrtc:8671
Change-Id: Id3b33e20969b1543e28c885d47495246cfbe549d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134216
Commit-Queue: Per Åhgren <peah@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27800}
2019-04-29 10:51:51 +00:00
8a9778efa4
Delete unused StartAecDump method with filename argument
...
Bug: None
Change-Id: Ia52e9730aa22ef89e350ffcf5a6608a0d273c027
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134461
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27799}
2019-04-29 10:16:26 +00:00
ade0dc9860
Make FrameBuffer be able to signal if it's trivially convertible to I420
...
Bug: chromium:930186,webrtc:10310
Change-Id: I7857c33d3616ac58738b22816f9c78fe9e6d1d3c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134206
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27798}
2019-04-29 09:55:47 +00:00
4babc68eee
Delete deprecated version of AudioPacketizationCallback::SendData.
...
Followup to https://webrtc-review.googlesource.com/c/src/+/134212
Bug: webrtc:6471
Change-Id: I5f2be134bddf8aada2b9c94b6d986c26a6fd23ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134309
Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27797}
2019-04-29 09:18:19 +00:00
3dd8bd7b5f
Roll chromium_revision 982e2994fa..8ce20eb94f (654706:654807)
...
Change log: 982e2994fa..8ce20eb94f
Full diff: 982e2994fa..8ce20eb94f
Changed dependencies
* src/build: 70dcfa3e46..d54bb94b63
* src/testing: 4d94e96af5..842b6f5d4f
* src/third_party: b390765a28..fa02d7d92e
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ffa3433a8c..d235eb2365
* src/tools: 9a5275459c..f19ce6ce3c
DEPS diff: 982e2994fa..8ce20eb94f
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I31d8d7cd8fdd5b0388b62ef262300d58fac7d77e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134445
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27796}
2019-04-29 08:25:43 +00:00
40409c141a
Crash with error message if failed to allocate memory via AlignedMalloc
...
Bug: webrtc:10573
Change-Id: I26d443a0422e7bad7148d2acf422f0dfdf4dcb8e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134218
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27795}
2019-04-28 11:16:40 +00:00
9656a2e5d6
Roll chromium_revision 59aee65d9c..982e2994fa (654597:654706)
...
Change log: 59aee65d9c..982e2994fa
Full diff: 59aee65d9c..982e2994fa
Changed dependencies
* src/base: bd84564627..283a7cc0bd
* src/build: 24a58de6ef..70dcfa3e46
* src/ios: a942be6a31..5673ce57ca
* src/testing: 0d88a19d4f..4d94e96af5
* src/third_party: 549ff7b625..b390765a28
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/bbeee6d77f..ffa3433a8c
* src/third_party/depot_tools: 99d965d911..6837707f80
* src/tools: 1b25e0a8f5..9a5275459c
DEPS diff: 59aee65d9c..982e2994fa
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I737cba329bb6152f079883091cf744bf33742ac6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134340
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27794}
2019-04-27 02:44:15 +00:00
413ccc49ec
Stop DCHECK which occurs in ANA BitrateController when overhead is zero.
...
https://webrtc-review.googlesource.com/c/src/+/119121 added two calls to set the observed overhead. Both SetupSendCodec() and ReconfigureSendCodec() update the encoder's overhead. However, these calls happen before RTP has issued any callbacks to set the overhead, so they tell the encoder that the overhead is zero.
This change checks whether the overhead has been set to a non-zero value before each of the new calls and adds a DCHECK to quickly catch future cases which attempt to set overhead to zero.
Bug: webrtc:10150
Change-Id: Ieb3345ecfcda1cf25538d5d424383df17a71b4a2
TBR: solenberg@webrtc.org
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134260
Commit-Queue: Bjorn Mellem <mellem@webrtc.org >
Reviewed-by: Anton Sukhanov <sukhanov@webrtc.org >
Reviewed-by: Minyue Li <minyue@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27793}
2019-04-27 00:20:37 +00:00
f36f5e8806
Roll chromium_revision 9e7b598af3..59aee65d9c (654486:654597)
...
Change log: 9e7b598af3..59aee65d9c
Full diff: 9e7b598af3..59aee65d9c
Changed dependencies
* src/base: 37cae4b286..bd84564627
* src/build: a62977721d..24a58de6ef
* src/ios: 13955a49ca..a942be6a31
* src/testing: 51dc53bd1e..0d88a19d4f
* src/third_party: d388ce3fc6..549ff7b625
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d7f22e29c4..bbeee6d77f
* src/third_party/depot_tools: 7a2205ca50..99d965d911
* src/third_party/libvpx/source/libvpx: da5be113f3..e50f4e4112
* src/tools: 0739739ce9..1b25e0a8f5
DEPS diff: 9e7b598af3..59aee65d9c
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,marpan@webrtc.org , jianj@chromium.org ,
BUG=None
Change-Id: Ic1d25f22c7e66b7215689820351f82101fb36417
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134329
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27792}
2019-04-26 21:45:19 +00:00
7d1eaa8ff7
Roll chromium_revision 1922754937..9e7b598af3 (654383:654486)
...
Change log: 1922754937..9e7b598af3
Full diff: 1922754937..9e7b598af3
Changed dependencies
* src/base: 3eed79aeda..37cae4b286
* src/build: 6c977eaea4..a62977721d
* src/ios: 5fec5aac5c..13955a49ca
* src/testing: 1fa6051c03..51dc53bd1e
* src/third_party: 904f37164f..d388ce3fc6
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ed5998919f..d7f22e29c4
* src/tools: e438fd4055..0739739ce9
DEPS diff: 1922754937..9e7b598af3
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I1d2834333fcee993e75e616c341ad5da56c8e4bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134325
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27791}
2019-04-26 17:30:14 +00:00
b27ddc626b
Revert "Reland "Improving robustness of feedback matching code in event log parser.""
...
This reverts commit 0870c70b0471c3bae16ad9a6732d812ee25446dd.
Reason for revert: Failed to handle lost packets.
Original change's description:
> Reland "Improving robustness of feedback matching code in event log parser."
>
> This is a reland of a1e4fbb25371867349a0c2ed6ba62224735a2ec7
>
> Original change's description:
> > Improving robustness of feedback matching code in event log parser.
> >
> > Removes the dependency on TransportFeedbackAdapter thereby removing
> > some of the complexity that came with it, in particular, we don't fill
> > in missing packets. This makes the code easier to debug and avoids some
> > confusing logging that's not relevant for the parser.
> >
> > Bug: webrtc:9883
> > Change-Id: I6df8425e8ab410514727c51a5e8d4981d6561f03
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133347
> > Reviewed-by: Stefan Holmer <stefan@webrtc.org >
> > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#27739}
>
> Bug: webrtc:9883
> Change-Id: I460d0c576626614fb4ce2c3d5e3ddbb5d1c122cf
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134106
> Reviewed-by: Stefan Holmer <stefan@webrtc.org >
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27763}
TBR=terelius@webrtc.org ,stefan@webrtc.org ,srte@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:9883
Change-Id: Ibcfc4f7425fe202d86f0c3a33de51e605dc17c04
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134312
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27790}
2019-04-26 16:10:11 +00:00
c5ba5e9572
Delete unused methods of VCMJitterEstimator
...
ResetNackCount and UpdateMaxFrameSize were unused.
Bug: None
Change-Id: I314b3edce368ee3230bc3510e1bba520806d1493
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134201
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27789}
2019-04-26 15:21:09 +00:00
299c4e6846
Piping audio interruption metrics to API layer
...
Bug: webrtc:10549
Change-Id: Ie6abe5819c5b73dc5f5f89bdc375bad77f44ce97
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134303
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27788}
2019-04-26 13:32:34 +00:00
c35b6e675a
Deprecate RTPFragmentationHeader argument to AudioPacketizationCallback::SendData
...
It appears unused everywhere. It will be deleted in a followup cl.
Bug: webrtc:6471
Change-Id: Ief992db6e52aee3cf1bc77ffd659ffbc072672ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134212
Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27787}
2019-04-26 12:58:14 +00:00
e670fd9795
Adds getter for FieldTrialParameter keys.
...
This is useful in test tooling.
Bug: webrtc:9346
Change-Id: I4a2ac52927cfe72f392f8748d3bada1e88db1b6a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134209
Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27786}
2019-04-26 12:53:24 +00:00
eb37b13943
Add peah to more audio watchlists
...
Bug: none
Change-Id: I46c7c16e9e717a234990c44ce51a97436744f861
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134301
Commit-Queue: Per Åhgren <peah@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27785}
2019-04-26 12:45:06 +00:00
da5aa4ddf5
Use CodecBufferUsage to determine dependencies.
...
In this CL:
- Assign frame IDs so that simulcast streams share one frame ID space.
- Added a CodecBufferUsage class that represent how a particular buffer
was used (updated, referenced or both).
- Calculate frame dependencies based on the CodecBufferUsage information.
Bug: webrtc:10342
Change-Id: I4ed5ad703f9376a7d995c04bb757c7d214865ddb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131287
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27784}
2019-04-26 12:13:28 +00:00
584744d390
Reduce watchlist spam for myself.
...
Bug: none
Change-Id: I9b3fb26ed0e0f75ff3cae2f5fd26aafacb1df216
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134217
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org >
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27783}
2019-04-26 10:25:15 +00:00
6ee75fdfcb
Allow setting the AGC2 fixed gain during runtime
...
This CL extends the supported runtime settings in
APM to also comprise the AGC2 fixed gain.
The CL was originally created by Adam Whiteside.
Bug: webrtc:10574
Change-Id: I79b3d6501f1e202b66a9b6018f8a493a56b01f62
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134101
Commit-Queue: Per Åhgren <peah@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27782}
2019-04-26 10:05:45 +00:00
2a8bd090a3
NetEq: Create an audio interruption metric
...
This CL adds a new metric to NetEq, which logs whenever a loss
concealment event has lasted longer than 150 ms (an "interruption").
The number of such events, as well as the sum length of them, is kept
in a SampleCounter, which can be queried at any time.
Any initial PLC at the beginning of a call, before the first packet is
decoded, is ignored.
Unit tests and piping to neteq_rtpplay are included.
Bug: webrtc:10549
Change-Id: I8a224a34254c47c74317617f420f6de997232d88
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132796
Reviewed-by: Minyue Li <minyue@webrtc.org >
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27781}
2019-04-26 09:48:05 +00:00
42fa30fdac
Roll chromium_revision ad14b36f44..1922754937 (654160:654383)
...
Change log: ad14b36f44..1922754937
Full diff: ad14b36f44..1922754937
Changed dependencies
* src/base: 9cf86767d1..3eed79aeda
* src/build: 6ff84bb755..6c977eaea4
* src/ios: 293b2c6111..5fec5aac5c
* src/testing: 25200655b2..1fa6051c03
* src/third_party: a8d4c2522b..904f37164f
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/e55c64fdd3..777a239175
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/dfc385d7c6..ed5998919f
* src/third_party/depot_tools: 97654081c7..7a2205ca50
* src/tools: 5af9e9e31e..e438fd4055
DEPS diff: ad14b36f44..1922754937
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ic368f663387edad22f5980e780a59c5ca72d6071
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134281
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#27780}
2019-04-26 09:37:45 +00:00