Commit Graph

31325 Commits

Author SHA1 Message Date
321396fcd5 Roll chromium_revision 577fe5ff7c..be02bd1a23 (794277:794377)
Change log: 577fe5ff7c..be02bd1a23
Full diff: 577fe5ff7c..be02bd1a23

Changed dependencies
* src/base: 7ea015fa5b..f12220a487
* src/build: 6d2b212669..b2c431caf0
* src/ios: 26d6651c6e..83eb788e14
* src/testing: d662dd5636..e1aff6168a
* src/third_party: bb5dd22804..3c9bc346d0
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f80ffe3279..ce6a663ce5
* src/tools: 98792a380f..0351baceed
DEPS diff: 577fe5ff7c..be02bd1a23/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ic50d8d3628e582db42a45e5096c7720c76a8b2a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180778
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31843}
2020-08-04 04:40:42 +00:00
7e30909bf4 Roll chromium_revision 5963c7d69a..577fe5ff7c (794142:794277)
Change log: 5963c7d69a..577fe5ff7c
Full diff: 5963c7d69a..577fe5ff7c

Changed dependencies
* src/base: bdf691693c..7ea015fa5b
* src/build: edf75c7295..6d2b212669
* src/ios: aadb08b0e6..26d6651c6e
* src/testing: e7d0644589..d662dd5636
* src/third_party: aa574c831b..bb5dd22804
* src/third_party/breakpad/breakpad: 2757a2c9c8..a6218eb66d
* src/third_party/depot_tools: 98b332f2db..6c7b829e54
* src/third_party/perfetto: 4b656a010b..9a482652ab
* src/tools: 3469aa4447..98792a380f
DEPS diff: 5963c7d69a..577fe5ff7c/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Id821cb1744deb2391d91a670c2a02a61a12ac126
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180775
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31842}
2020-08-03 22:39:05 +00:00
048a1885b4 Refactor PC level smoke test for adding new network stats reporter
New network stats reporter will require peer name to be passed into
constructor. Because peer name can be set inside PeerConfigurer adding
of the reporter have to be moved to PeerConfigurer creation.

Bug: webrtc:11756
Change-Id: I4840566a3cd2c73fbb1d186aa1c40ebf889fd830
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180805
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31841}
2020-08-03 20:06:24 +00:00
c85990cadd Revert "Stop using RTPFragmentationHeader in sdk/android as unneeded"
This reverts commit 0d000c0530fcd8b0c0b0b46d60d5b39878fdef6f.

Reason for revert: CL that added API with 2 params callback was reverter: https://webrtc-review.googlesource.com/c/src/+/180821

Original change's description:
> Stop using RTPFragmentationHeader in sdk/android as unneeded
> 
> Bug: webrtc:6471
> Change-Id: I81bbea4b7fd6e0325791456bb521e9dd0a64487d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180806
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31836}

TBR=danilchap@webrtc.org,sakal@webrtc.org

Change-Id: I15809f663fd365ab11c0667e3705314fdbb38024
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:6471
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180822
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31840}
2020-08-03 19:30:36 +00:00
65e3044b40 Revert "Add EncodedImageCallback::OnEncodedImage without RTPFragmentationHeader"
This reverts commit fdd41ecf6b05b02a1ee12583e537f1cdb5922919.

Reason for revert: Breaks WebRTC roll into Chrome: 
https://crrev.com/c/2335265

Sample failure:
https://ci.chromium.org/p/chromium/builders/try/linux_chromium_compile_dbg_ng/688153?


Original change's description:
> Add EncodedImageCallback::OnEncodedImage without RTPFragmentationHeader
> 
> RTPFragmentationHeader is no longer used by any webrtc code.
> 
> Bug: webrtc:6471
> Change-Id: I1362d58465c550f5c8e0a5b292dc0abcd6251431
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180120
> Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> Reviewed-by: Niels Moller <nisse@webrtc.org>
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31833}

TBR=danilchap@webrtc.org,brandtr@webrtc.org,nisse@webrtc.org,srte@webrtc.org

Change-Id: I6bd021637b0c140f6625612caebdb5829decdfb0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:6471
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180821
Reviewed-by: Marina Ciocea <marinaciocea@webrtc.org>
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31839}
2020-08-03 18:31:07 +00:00
fbbfc02698 sdp: reject sdp with malformed b= lines
BUG=webrtc:3782

Change-Id: I3d137b0b74565f7e85bbc6b453e73731a94c2b04
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179360
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Taylor <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31838}
2020-08-03 18:21:14 +00:00
358df5fb4d Roll chromium_revision adcdc4730c..5963c7d69a (794031:794142)
Change log: adcdc4730c..5963c7d69a
Full diff: adcdc4730c..5963c7d69a

Changed dependencies
* src/base: d531067a81..bdf691693c
* src/build: ae943e3e61..edf75c7295
* src/buildtools: 42e9461958..6139217878
* src/ios: 88d7ebbdb0..aadb08b0e6
* src/testing: 596969c21e..e7d0644589
* src/third_party: a0c94917b3..aa574c831b
* src/third_party/perfetto: fce06b2000..4b656a010b
* src/tools: 61751efb0a..3469aa4447
DEPS diff: adcdc4730c..5963c7d69a/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Idbd586672de96bfea43b61b6ecc56b123f7a1aef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180771
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31837}
2020-08-03 16:48:13 +00:00
0d000c0530 Stop using RTPFragmentationHeader in sdk/android as unneeded
Bug: webrtc:6471
Change-Id: I81bbea4b7fd6e0325791456bb521e9dd0a64487d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180806
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31836}
2020-08-03 15:57:43 +00:00
a4f23ad0ce Revert "Moved VideoReceiveStream::Decoder::decoder_factory to VideoReceiveStream::Config::decoder_factory."
This reverts commit acb9d8365a5f9eb1e2a9e9902690d62dab1e5759.

Reason for revert: Break downstream stuff.

Original change's description:
> Moved VideoReceiveStream::Decoder::decoder_factory to VideoReceiveStream::Config::decoder_factory.
> 
> Bug: webrtc:9106
> Change-Id: I85712f3ab6a734d3fad7819491d3b8e3388b47e7
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180342
> Reviewed-by: Niels Moller <nisse@webrtc.org>
> Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
> Commit-Queue: Philip Eliasson <philipel@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31834}

TBR=nisse@webrtc.org,philipel@webrtc.org,mflodman@webrtc.org

Change-Id: I6cfdb85a154a78135839f84edf5f69673d5ab715
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9106
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180807
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31835}
2020-08-03 15:45:41 +00:00
acb9d8365a Moved VideoReceiveStream::Decoder::decoder_factory to VideoReceiveStream::Config::decoder_factory.
Bug: webrtc:9106
Change-Id: I85712f3ab6a734d3fad7819491d3b8e3388b47e7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180342
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31834}
2020-08-03 14:10:37 +00:00
fdd41ecf6b Add EncodedImageCallback::OnEncodedImage without RTPFragmentationHeader
RTPFragmentationHeader is no longer used by any webrtc code.

Bug: webrtc:6471
Change-Id: I1362d58465c550f5c8e0a5b292dc0abcd6251431
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180120
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31833}
2020-08-03 13:58:17 +00:00
f29fdfc5cb Delete old name ProcessAllMessageQueues
Bug: webrtc:10198
Change-Id: I5aca69101e6f70080b3209ebabf0007d82114632
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179482
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31832}
2020-08-03 11:24:17 +00:00
6b7d25eed3 AudioDeviceMac: fix mutex re-entry.
This change fixes two cases of encountered mutex re-entries.

Bug: webrtc:11821
Change-Id: Iaef730e4233a79b0d1b2bf6a17fe3f14e2558e98
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180800
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31831}
2020-08-03 10:54:56 +00:00
e48851d910 red: only enable RED if its preferred as send codec
only enables RFC 2198 redundancy if it has a higher preference
than Opus. This means it not used by default but can be
chosen with setCodecPreferences.

BUG=webrtc:11640

Change-Id: I84ff2ca518da70440297a667dedba5cf4484eed7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178742
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31830}
2020-08-03 10:52:07 +00:00
834dc9cfa1 Revert "Only enable conference mode simulcast allocations with flag enabled"
This reverts commit 32ca95145c4636374266f5b5d4d1ac43658bc758.

Reason for revert: Internal test failure

Original change's description:
> Only enable conference mode simulcast allocations with flag enabled
> 
> Non-conference mode simulcast screenshares were mistakenly using the
> conference mode semantics in the simulcast rate allocator, which broke
> spec compliant usage in some situation.
> 
> This behavior should only be used when explicitly using the SDP entry
> "a=x-google-flag:conference" in both offer and answer.
> 
> Bug: webrtc:11310, chromium:1093819
> Change-Id: Ibcba75c88a8405d60467546b33977a782e04e469
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179081
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Commit-Queue: Florent Castelli <orphis@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31828}

TBR=ilnik@webrtc.org,hta@webrtc.org,orphis@webrtc.org

Change-Id: I5ccb6e87594f491ba09fe6b837ee24d63db878ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11310
Bug: chromium:1093819
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180801
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31829}
2020-08-03 10:31:21 +00:00
32ca95145c Only enable conference mode simulcast allocations with flag enabled
Non-conference mode simulcast screenshares were mistakenly using the
conference mode semantics in the simulcast rate allocator, which broke
spec compliant usage in some situation.

This behavior should only be used when explicitly using the SDP entry
"a=x-google-flag:conference" in both offer and answer.

Bug: webrtc:11310, chromium:1093819
Change-Id: Ibcba75c88a8405d60467546b33977a782e04e469
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179081
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31828}
2020-08-03 10:09:46 +00:00
c878d68282 Roll chromium_revision d0bcff98cd..adcdc4730c (793926:794031)
Change log: d0bcff98cd..adcdc4730c
Full diff: d0bcff98cd..adcdc4730c

Changed dependencies
* src/base: d232d78c40..d531067a81
* src/build: 3715f86546..ae943e3e61
* src/ios: 34cda12091..88d7ebbdb0
* src/testing: 72a0696998..596969c21e
* src/third_party: 960cae503b..a0c94917b3
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2cd291aae8..f80ffe3279
* src/tools: 361be1db85..61751efb0a
DEPS diff: d0bcff98cd..adcdc4730c/DEPS

Clang version changed 7e8d5a90f2c101388d3b0bbce8555e871c670232:1bd7046e4ce0102adef6096a12a289d7f94b8c73
Details: d0bcff98cd..adcdc4730c/tools/clang/scripts/update.py

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ieb47a35d1bc5e9f27bd443b7cf9ed4c2a725f46e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180767
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31827}
2020-08-03 08:41:33 +00:00
3fec3e323d Roll chromium_revision 35bcb2fa0c..d0bcff98cd (793825:793926)
Change log: 35bcb2fa0c..d0bcff98cd
Full diff: 35bcb2fa0c..d0bcff98cd

Changed dependencies
* src/base: 59d2b95746..d232d78c40
* src/build: d9e2078223..3715f86546
* src/ios: dc76ecfe14..34cda12091
* src/testing: c0291e2fd3..72a0696998
* src/third_party: f0a9c3cc80..960cae503b
* src/tools: 65a4f45923..361be1db85
DEPS diff: 35bcb2fa0c..d0bcff98cd/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I4bfb44e54f3d52632716459499a8dc980a3d4182
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180751
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31826}
2020-08-01 22:41:32 +00:00
353dcec4c1 Roll chromium_revision 48a5523b6b..35bcb2fa0c (793691:793825)
Change log: 48a5523b6b..35bcb2fa0c
Full diff: 48a5523b6b..35bcb2fa0c

Changed dependencies
* src/base: e9d3f1bba4..59d2b95746
* src/build: bd123e3940..d9e2078223
* src/ios: 90a83d2868..dc76ecfe14
* src/testing: 558db657f2..c0291e2fd3
* src/third_party: 4e862e1f25..f0a9c3cc80
* src/third_party/breakpad/breakpad: a740aa2625..2757a2c9c8
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/26d2e8aa28..2cd291aae8
* src/third_party/depot_tools: 343f63643b..98b332f2db
* src/third_party/libjpeg_turbo: 7e3ad79800..0241a1304f
* src/third_party/perfetto: 22b8657a55..fce06b2000
* src/tools: 5a5284b260..65a4f45923
DEPS diff: 48a5523b6b..35bcb2fa0c/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ifda34c264d10f0978fbb7979eb52b0a2b566278c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180723
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31825}
2020-08-01 00:45:07 +00:00
239ac8a4e2 Reland "Pass NetworkMonitorFactory through PeerConnectionFactory."
This is a reland of 003c9be817817ed0e3aef3f50c78ae5cb31bc0ff

Found some downstream code that relies on
NetworkMonitorFactory::SetFactory, so I'm adding those methods back
temporarily. BasicNetworkManager will fall back to the static factory
if the one passed into PeerConnectionFactory is null.

Original change's description:
> Pass NetworkMonitorFactory through PeerConnectionFactory.
>
> Previously the instance was set through a static method, which was
> really only done because it was difficult to add new
> PeerConnectionFactory construction arguments at the time.
>
> Now that we have PeerConnectionFactoryDependencies it's easy to clean
> this up.
>
> I'm doing this because I plan to add a NetworkMonitor implementation
> for iOS, and don't want to inherit this ugliness.
>
> Bug: webrtc:9883
> Change-Id: Id94dc061ab1c7186b81af8547393a6e336ff04c2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180241
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
> Commit-Queue: Taylor <deadbeef@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31815}

TBR=hta@webrtc.org, sakal@webrtc.org

Bug: webrtc:9883
Change-Id: I2e817c423f21936f87532a9694eb9a0a1b70c212
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180722
Reviewed-by: Taylor <deadbeef@webrtc.org>
Commit-Queue: Taylor <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31824}
2020-08-01 00:36:27 +00:00
cfba4ffe31 Revert "Reland "Pass NetworkMonitorFactory through PeerConnectionFactory.""
This reverts commit 7ded73351870bfb45160fa6b9db71a94fe49397b.

Reason for revert: Found more code calling NetworkMonitorFactory::SetFactory...

Original change's description:
> Reland "Pass NetworkMonitorFactory through PeerConnectionFactory."
> 
> This is a reland of 003c9be817817ed0e3aef3f50c78ae5cb31bc0ff
> 
> Original change's description:
> > Pass NetworkMonitorFactory through PeerConnectionFactory.
> >
> > Previously the instance was set through a static method, which was
> > really only done because it was difficult to add new
> > PeerConnectionFactory construction arguments at the time.
> >
> > Now that we have PeerConnectionFactoryDependencies it's easy to clean
> > this up.
> >
> > I'm doing this because I plan to add a NetworkMonitor implementation
> > for iOS, and don't want to inherit this ugliness.
> >
> > Bug: webrtc:9883
> > Change-Id: Id94dc061ab1c7186b81af8547393a6e336ff04c2
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180241
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> > Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
> > Commit-Queue: Taylor <deadbeef@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#31815}
> 
> TBR=hta@webrtc.org, sakal@webrtc.org
> 
> Bug: webrtc:9883
> Change-Id: Ibf69a22e8f94226908636c7d50ff9eda65bd4129
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180720
> Reviewed-by: Taylor <deadbeef@webrtc.org>
> Commit-Queue: Taylor <deadbeef@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31822}

TBR=deadbeef@webrtc.org,sakal@webrtc.org,hta@webrtc.org

Change-Id: Iae51b94072cec9abc021eed4e51d1fbeee998adc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9883
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180721
Reviewed-by: Taylor <deadbeef@webrtc.org>
Commit-Queue: Taylor <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31823}
2020-07-31 22:44:39 +00:00
7ded733518 Reland "Pass NetworkMonitorFactory through PeerConnectionFactory."
This is a reland of 003c9be817817ed0e3aef3f50c78ae5cb31bc0ff

Original change's description:
> Pass NetworkMonitorFactory through PeerConnectionFactory.
>
> Previously the instance was set through a static method, which was
> really only done because it was difficult to add new
> PeerConnectionFactory construction arguments at the time.
>
> Now that we have PeerConnectionFactoryDependencies it's easy to clean
> this up.
>
> I'm doing this because I plan to add a NetworkMonitor implementation
> for iOS, and don't want to inherit this ugliness.
>
> Bug: webrtc:9883
> Change-Id: Id94dc061ab1c7186b81af8547393a6e336ff04c2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180241
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
> Commit-Queue: Taylor <deadbeef@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31815}

TBR=hta@webrtc.org, sakal@webrtc.org

Bug: webrtc:9883
Change-Id: Ibf69a22e8f94226908636c7d50ff9eda65bd4129
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180720
Reviewed-by: Taylor <deadbeef@webrtc.org>
Commit-Queue: Taylor <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31822}
2020-07-31 22:05:02 +00:00
1c100e5e78 Roll chromium_revision 4d0815dcb4..48a5523b6b (793545:793691)
Change log: 4d0815dcb4..48a5523b6b
Full diff: 4d0815dcb4..48a5523b6b

Changed dependencies
* src/base: 143f2bf322..e9d3f1bba4
* src/build: af38c5df81..bd123e3940
* src/ios: 52cafcd064..90a83d2868
* src/testing: 5501fd11e6..558db657f2
* src/third_party: cbac85ebcf..4e862e1f25
* src/third_party/perfetto: f6c424bb59..22b8657a55
* src/tools: 1e881a2fda..5a5284b260
DEPS diff: 4d0815dcb4..48a5523b6b/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ic17ea83c6dca27995ff186b947af207c4fd766f7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180701
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31821}
2020-07-31 18:46:19 +00:00
14b46a77b2 Provide per destination statistic for network outgoing stats
Network emulation layer provides per source split for incoming stats for
endpoint. Do the same for outgoing stats per destination.

Bug: webrtc:11756
Change-Id: I2369ae8906546c27133273b1be17ce74c253c6e8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180500
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31820}
2020-07-31 11:52:13 +00:00
81bbd7199a Roll chromium_revision 88f89d7a7d..4d0815dcb4 (793251:793545)
Remove (unused) androidx dependency

Change log: 88f89d7a7d..4d0815dcb4
Full diff: 88f89d7a7d..4d0815dcb4

Changed dependencies
* src/base: c560562564..143f2bf322
* src/build: f1439400c6..af38c5df81
* src/buildtools: 9e121212d4..42e9461958
* src/ios: 6f6045fc51..52cafcd064
* src/testing: c0f4b658c2..5501fd11e6
* src/third_party: 280bd1b343..cbac85ebcf
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/70fee17204..74161f485b
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0138877b75..26d2e8aa28
* src/third_party/perfetto: 23b75a4d65..f6c424bb59
* src/tools: 63b96f52fa..1e881a2fda
DEPS diff: 88f89d7a7d..4d0815dcb4/DEPS

No update to Clang.

BUG=None

Change-Id: I65b2f55d56dd20a06e1889325591994aab6996fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180660
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31819}
2020-07-31 10:44:13 +00:00
7d627545cb Revert "Pass NetworkMonitorFactory through PeerConnectionFactory."
This reverts commit 003c9be817817ed0e3aef3f50c78ae5cb31bc0ff.

Reason for revert: Breaks downstream build which is still using
SetFactory/ReleaseFactory. Probably will need to update this in lockstep.

Original change's description:
> Pass NetworkMonitorFactory through PeerConnectionFactory.
> 
> Previously the instance was set through a static method, which was
> really only done because it was difficult to add new
> PeerConnectionFactory construction arguments at the time.
> 
> Now that we have PeerConnectionFactoryDependencies it's easy to clean
> this up.
> 
> I'm doing this because I plan to add a NetworkMonitor implementation
> for iOS, and don't want to inherit this ugliness.
> 
> Bug: webrtc:9883
> Change-Id: Id94dc061ab1c7186b81af8547393a6e336ff04c2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180241
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
> Commit-Queue: Taylor <deadbeef@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31815}

TBR=deadbeef@webrtc.org,sakal@webrtc.org,hta@webrtc.org

Change-Id: I1f09df7be9c860017d515e5a87488340afa6eda6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9883
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180640
Reviewed-by: Taylor <deadbeef@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31818}
2020-07-31 07:34:42 +00:00
b33b12d4fb frame encryptor: remove note about not being production ready
as it has been used in production for a while already.

BUG=None

Change-Id: Idd466f3ad02129a8125e54122e77036959e67aa4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175131
Reviewed-by: Justin Uberti <juberti@webrtc.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#31817}
2020-07-31 06:49:29 +00:00
ee8c246be7 Reland "sdp: parse and serialize b=TIAS"
This reverts commit 20b701f3d79c499b0981f03fbf3a9b0fe531ac5d.

Reason for reland: Reverting did not affect the test regression.

Original change's description:
> Revert "sdp: parse and serialize b=TIAS"
>
> This reverts commit c6801d4522ab94f965e258e68259fde312023654.
>
> Reason for revert: Speculatively reverting since it possibly breaks downstream performance test.
>
> One issue I noticed is that the correct SDP won't be produced if set_bandwidth_type hasn't been called. Probably should default to b=AS in that case.
>
> Original change's description:
> > sdp: parse and serialize b=TIAS
> >
> > BUG=webrtc:5788
> >
> > Change-Id: I063c756004e4c224fffa36d2800603c7b7e50dce
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179223
> > Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
> > Reviewed-by: Taylor <deadbeef@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#31729}
>
> TBR=deadbeef@webrtc.org,hta@webrtc.org,minyue@webrtc.org,philipp.hancke@googlemail.com,jleconte@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: webrtc:5788
> Change-Id: I2a3f676b4359834e511dffd5adedc9388e0ea0f8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179620
> Reviewed-by: Taylor <deadbeef@webrtc.org>
> Commit-Queue: Taylor <deadbeef@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31762}

TBR=nisse@webrtc.org

Bug: webrtc:5788
Change-Id: I5c0ef29d275bb2264d9b706b085f7933d59e2801
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179760
Commit-Queue: Taylor <deadbeef@webrtc.org>
Reviewed-by: Taylor <deadbeef@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31816}
2020-07-30 21:16:08 +00:00
003c9be817 Pass NetworkMonitorFactory through PeerConnectionFactory.
Previously the instance was set through a static method, which was
really only done because it was difficult to add new
PeerConnectionFactory construction arguments at the time.

Now that we have PeerConnectionFactoryDependencies it's easy to clean
this up.

I'm doing this because I plan to add a NetworkMonitor implementation
for iOS, and don't want to inherit this ugliness.

Bug: webrtc:9883
Change-Id: Id94dc061ab1c7186b81af8547393a6e336ff04c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180241
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Taylor <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31815}
2020-07-30 20:52:28 +00:00
9a1acec95b Roll chromium_revision f4c74ea1a4..88f89d7a7d (792888:793251)
Change log: f4c74ea1a4..88f89d7a7d
Full diff: f4c74ea1a4..88f89d7a7d

Changed dependencies
* src/base: 77a7bb4ce7..c560562564
* src/build: c92da04791..f1439400c6
* src/ios: 8c16225770..6f6045fc51
* src/testing: 8c2ec4e948..c0f4b658c2
* src/third_party: 8dadff6762..280bd1b343
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/eda849d2e6..70fee17204
* src/third_party/breakpad/breakpad: 2757a2c9c8..a740aa2625
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/14ca9390e3..0138877b75
* src/third_party/depot_tools: 7291750ae2..343f63643b
* src/third_party/freetype/src: 3273521f40..986a340dd5
* src/third_party/perfetto: a307488e38..23b75a4d65
* src/tools: 6f9fee879f..63b96f52fa
DEPS diff: f4c74ea1a4..88f89d7a7d/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I2a0ff93f3f5f2db72aca879e5563ce96a6340061
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180601
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31814}
2020-07-30 18:49:31 +00:00
0c9204c183 Revert "Support AVX2/FMA intrinsics in Audio Resampler module"
This reverts commit 1ca8d87239f1209031bbc77a6443bc7ac2dcee8c.

Reason for revert: breaks downstream project

Original change's description:
> Support AVX2/FMA intrinsics in Audio Resampler module
> 
> From the test result, using AVX2/FMA is 1.60x faster than SSE on atlas.
> 
> Bug: webrtc:11663
> Test: common_audio_unittests on atlas and octopus.
> Change-Id: Ibd45ea46aa97d5790a24e5116f741592b95f6416
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176382
> Reviewed-by: Per Åhgren <peah@webrtc.org>
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Sam Zackrisson <saza@webrtc.org>
> Commit-Queue: Sam Zackrisson <saza@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31810}

TBR=mbonadei@webrtc.org,henrika@webrtc.org,henrik.lundin@webrtc.org,saza@webrtc.org,peah@webrtc.org,mflodman@webrtc.org,zhaoliang.ma@intel.com

Change-Id: I1dad31df446e336dacb29ff637bd66f809376458
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11663
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180622
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31813}
2020-07-30 17:35:30 +00:00
378a948e0d Roll chromium_revision 7228039446..f4c74ea1a4 (791192:792888)
Change log: 7228039446..f4c74ea1a4
Full diff: 7228039446..f4c74ea1a4

Changed dependencies
* src/base: 4a519036e9..77a7bb4ce7
* src/build: 644d679a75..c92da04791
* src/ios: d87af1c689..8c16225770
* src/testing: 07e1f60f4d..8c2ec4e948
* src/third_party: c9edd06161..8dadff6762
* src/third_party/android_sdk/public: n-b1Qd7iFb8qzHlr1C_jIeu070UDgO_BwePtH42UqGcC..8LZujEmLjSh0g3JciDA3cslSptxKs9HOa_iUPXkOeYQC
* src/third_party/android_sdk/public: uM0XtAW9BHh8phcbhBDA9GfzP3bku2SP7AiMahhimnoC..ijpIFSitwBfaEdO9VXBGPqDHUVzPimXy_whw3aHTN9oC
* src/third_party/android_sdk/public: f4WdgkPvDdVCE8zBWPzcSIj4N9WFhKp3CSKDWylXuLEC..A4EvXZUIuQho0QRDJopMUpgyp6NA3aiDQjGKPUKbowMC
* src/third_party/android_sdk/public: zMVtBEihXp2Z0NYFNjLLmNrwy6252b_YWG6sh2l0QAcC..8tF0AOj7Dwlv4j7_nfkhxWB0jzrvWWYjEIpirt8FIWYC
* src/third_party/android_sdk/public: yb33klKQV9UzzB-lDSsq36vzhTXOUZ2aRONBvPGwvdcC..YMUu9EHNZ__2Xcxl-KsaSf-dI5TMt_P62IseUVsxktMC
* src/third_party/android_system_sdk: 4IAlMU4jo15KjMPF3EUnrPZs0RYoPW8n9jSJ4dvHDWUC..no8ss5nRg6uYDM08HboypuIQuix7bS1kVqRGyWmwP-YC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b2282feee0..14ca9390e3
* src/third_party/depot_tools: cebfb4e614..7291750ae2
* src/third_party/freetype/src: b7c467b6ef..3273521f40
* src/third_party/openh264/src: a5473711f3..3dd5b80bc4
* src/third_party/perfetto: f9803e14b0..a307488e38
* src/third_party/requests/src: https://chromium.googlesource.com/external/github.com/kennethreitz/requests.git/+log/f172b30356..refs/tags/
* src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/9f90ab0509..6f9fee879f
DEPS diff: https://chromium.googlesource.com/chromium/src/+/7228039446..f4c74ea1a4/DEPS

Clang version changed 04b9a46c842f793a2baedcad64de35fcbd3e93b7:7e8d5a90f2c101388d3b0bbce8555e871c670232
Details: https://chromium.googlesource.com/chromium/src/+/7228039446..f4c74ea1a4/tools/clang/scripts/update.py

TBR=titovartem@google.com,
BUG=None

Change-Id: Icee3e04e36a5f705fa248f02ddc7226b7258db8d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180560
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31812}
2020-07-30 13:36:04 +00:00
55fc6cf193 Fix "Assignment had no effect." error during chromium roll.
Remove custom android warning suppression file because looks like it
is not used anymore.

Bug: None
Change-Id: I09f8936a5e82e42f3d0c1e21f20ff4812ce1b8ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180582
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31811}
2020-07-30 12:57:20 +00:00
1ca8d87239 Support AVX2/FMA intrinsics in Audio Resampler module
From the test result, using AVX2/FMA is 1.60x faster than SSE on atlas.

Bug: webrtc:11663
Test: common_audio_unittests on atlas and octopus.
Change-Id: Ibd45ea46aa97d5790a24e5116f741592b95f6416
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176382
Reviewed-by: Per Åhgren <peah@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31810}
2020-07-30 11:39:38 +00:00
6f148566dc Removed FrameBuffer::Start function.
Bug: webrtc:9106
Change-Id: I98cbc6d89b01e7c49b0595da5d5e446652418897
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180581
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31809}
2020-07-30 11:15:56 +00:00
c6cf902034 Improves logging in MediaChannel
This CL changes the style of logging for an API which is essential when
WebRTC is used in Chrome. By changing the format, we can more easily
tie in (search for tags etc.) logs from WebRTC with logs in Chrome.
See e.g.
https://chromium-review.googlesource.com/c/chromium/src/+/2093443
for more details.

I decided to use a new private method to avoid using rtc::StringBuilder.
The idea was to make the log statements less complex and more condensed.

Tbr: mbonadei
Bug: webrtc:11493
Change-Id: I46b4a933ad62ac1db376743b4a41b62c5f8c6ac6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172841
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31808}
2020-07-30 08:10:03 +00:00
3ea3e0c345 Fix potential deadlock in VideoAnalyzer
Bug: webrtc:11809
Change-Id: I9b037f7bc06ff8e5b5b6abf3467d7a3825c212e8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180520
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31807}
2020-07-29 17:26:07 +00:00
81d2bbf96e Add a missing Windows library
"oleaut32.lib" is required for VariantInit: https://docs.microsoft.com/en-us/windows/win32/api/oleauto/nf-oleauto-variantinit

Bug: webrtc:11807
Change-Id: If0511571340e14407ad9402636a4a64d328fabca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180440
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Eric Astor <epastor@google.com>
Cr-Commit-Position: refs/heads/master@{#31806}
2020-07-29 14:06:35 +00:00
397cd82eaf Create port allocator on signaling thread and init on network
Port allocator can be created on one thread and then initialized and
used on another. So we can avoid sync invoke to network thread to create
port allocator.

Bug: webrtc:11799
Change-Id: I5020093a41acbf7e372f2e4970e016ce14a7f406
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180122
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31805}
2020-07-29 11:31:43 +00:00
831ae4ef65 Reland "[Perfect Negotiation] Implement non-racy version of SetLocalDescription."
This is a reland of d4089cae47334a4228b69d6bb23f2e49ebb7496e
with the following fix:

Invoke MaybeStartGathering as the last step of DoSetLocalDescription.
This ensures that candidates and onicegatheringstatechange does not
happen before SLD is resolved. This is important for passing
external/wpt/webrtc/RTCPeerConnection-iceGatheringState.html.

Original change's description:
> [Perfect Negotiation] Implement non-racy version of SetLocalDescription.
>
> BACKGROUND
>
> When SLD is invoked with SetSessionDescriptionObserver, the observer is
> called by posting a message back to the execution thread, delaying the
> call. This delay is "artificial" - it's not necessary; the operation is
> already complete. It's a post from the signaling thread to the signaling
> thread. The rationale for the post was to avoid the observer making
> recursive calls back into the PeerConnection. The problem with this is
> that by the time the observer is called, the PeerConnection could
> already have executed other operations and modified its states.
>
> This causes the referenced bug: one can have a race where SLD is
> resolved "too late" (after a pending SRD is executed) and the signaling
> state observed when SLD resolves doesn't make sense.
>
> When implementing Unified Plan, we fixed similar issues for SRD by
> adding a version that takes SetRemoteDescriptionObserverInterface as
> argument instead of SetSessionDescriptionObserver. The new version did
> not have the delay. The old version had to be kept around not to break
> downstream projects that had dependencies both on he delay and on
> allowing the PC to be destroyed midst-operation without informing its
> observers.
>
> THIS CL
>
> This does the old SRD fix for SLD as well: A new observer interface is
> added, SetLocalDescriptionObserverInterface, and
> PeerConnection::SetLocalDescription() is overloaded. If you call it with
> the old observer, you get the delay, but if you call it with the new
> observer, you don't get a delay.
>
> - SetLocalDescriptionObserverInterface is added.
> - SetLocalDescription is overloaded.
> - The adapter for SetSessionDescriptionObserver that causes the delay
>   previously only used for SRD is updated to handle both SLD and SRD.
> - FakeSetLocalDescriptionObserver is added and
>   MockSetRemoteDescriptionObserver is renamed "Fake...".
>
> Bug: chromium:1071733
> Change-Id: I920368e648bede481058ac22f5b8794752a220b3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179100
> Commit-Queue: Henrik Boström <hbos@webrtc.org>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31798}

TBR=hta@webrtc.org

Bug: chromium:1071733
Change-Id: Ic6e8d96afa1c19604762f373716c08dbfa9d178c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180481
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31804}
2020-07-29 11:27:43 +00:00
3872873889 Reduce log level in BaseChannel::SendPacket.
This log line is causing test failures due to excessive logging (see
referenced bug); reducing log level.

Bug: chromium:984879
Change-Id: Ic94ba0a39b91b4253a58ad54de0cba1ca49882e2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175913
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31803}
2020-07-29 09:57:24 +00:00
4c9c75a2a6 Revert "[Perfect Negotiation] Implement non-racy version of SetLocalDescription."
This reverts commit d4089cae47334a4228b69d6bb23f2e49ebb7496e.

Reason for revert: Breaks chromium WPT that is timing sensitive to onicegatheringstatechanges.
This CL accidentally moved the MaybeStartGatheringIceCandidates to after completing the SLD call. The fix is to move it back. I'll do that in a re-land.

Original change's description:
> [Perfect Negotiation] Implement non-racy version of SetLocalDescription.
> 
> BACKGROUND
> 
> When SLD is invoked with SetSessionDescriptionObserver, the observer is
> called by posting a message back to the execution thread, delaying the
> call. This delay is "artificial" - it's not necessary; the operation is
> already complete. It's a post from the signaling thread to the signaling
> thread. The rationale for the post was to avoid the observer making
> recursive calls back into the PeerConnection. The problem with this is
> that by the time the observer is called, the PeerConnection could
> already have executed other operations and modified its states.
> 
> This causes the referenced bug: one can have a race where SLD is
> resolved "too late" (after a pending SRD is executed) and the signaling
> state observed when SLD resolves doesn't make sense.
> 
> When implementing Unified Plan, we fixed similar issues for SRD by
> adding a version that takes SetRemoteDescriptionObserverInterface as
> argument instead of SetSessionDescriptionObserver. The new version did
> not have the delay. The old version had to be kept around not to break
> downstream projects that had dependencies both on he delay and on
> allowing the PC to be destroyed midst-operation without informing its
> observers.
> 
> THIS CL
> 
> This does the old SRD fix for SLD as well: A new observer interface is
> added, SetLocalDescriptionObserverInterface, and
> PeerConnection::SetLocalDescription() is overloaded. If you call it with
> the old observer, you get the delay, but if you call it with the new
> observer, you don't get a delay.
> 
> - SetLocalDescriptionObserverInterface is added.
> - SetLocalDescription is overloaded.
> - The adapter for SetSessionDescriptionObserver that causes the delay
>   previously only used for SRD is updated to handle both SLD and SRD.
> - FakeSetLocalDescriptionObserver is added and
>   MockSetRemoteDescriptionObserver is renamed "Fake...".
> 
> Bug: chromium:1071733
> Change-Id: I920368e648bede481058ac22f5b8794752a220b3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179100
> Commit-Queue: Henrik Boström <hbos@webrtc.org>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31798}

TBR=hbos@webrtc.org,hta@webrtc.org

Change-Id: Ie1e1ecc49f3b1d7a7e230db6d36decbc4cbe8c86
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1071733
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180480
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31802}
2020-07-29 09:46:56 +00:00
cf781282f1 Add ability to get network stats from endpoint instance
Bug: webrtc:11756
Change-Id: Ic232304d037a8f8bc9dc293af23c9a89d4b8cb37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180360
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31801}
2020-07-29 08:18:04 +00:00
6c5f787741 Remove dependency from audio_jni to built in codecs.
This will allow clients to build peerconnection_jni without
built-in audio codecs.

Bug: webrtc:9048
Change-Id: I0d327debccac1ec7f7d0f4d994ca4e712e994f91
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180422
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31800}
2020-07-28 15:07:14 +00:00
24a53a05a5 Fix division by zero in I420Buffer::CropAndScaleFrom
Bug: webrtc:11741
Change-Id: I5ad495084573e55adb77696e6f61880c1378d0c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178440
Commit-Queue: Dan Minor <dminor@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31799}
2020-07-28 13:17:24 +00:00
d4089cae47 [Perfect Negotiation] Implement non-racy version of SetLocalDescription.
BACKGROUND

When SLD is invoked with SetSessionDescriptionObserver, the observer is
called by posting a message back to the execution thread, delaying the
call. This delay is "artificial" - it's not necessary; the operation is
already complete. It's a post from the signaling thread to the signaling
thread. The rationale for the post was to avoid the observer making
recursive calls back into the PeerConnection. The problem with this is
that by the time the observer is called, the PeerConnection could
already have executed other operations and modified its states.

This causes the referenced bug: one can have a race where SLD is
resolved "too late" (after a pending SRD is executed) and the signaling
state observed when SLD resolves doesn't make sense.

When implementing Unified Plan, we fixed similar issues for SRD by
adding a version that takes SetRemoteDescriptionObserverInterface as
argument instead of SetSessionDescriptionObserver. The new version did
not have the delay. The old version had to be kept around not to break
downstream projects that had dependencies both on he delay and on
allowing the PC to be destroyed midst-operation without informing its
observers.

THIS CL

This does the old SRD fix for SLD as well: A new observer interface is
added, SetLocalDescriptionObserverInterface, and
PeerConnection::SetLocalDescription() is overloaded. If you call it with
the old observer, you get the delay, but if you call it with the new
observer, you don't get a delay.

- SetLocalDescriptionObserverInterface is added.
- SetLocalDescription is overloaded.
- The adapter for SetSessionDescriptionObserver that causes the delay
  previously only used for SRD is updated to handle both SLD and SRD.
- FakeSetLocalDescriptionObserver is added and
  MockSetRemoteDescriptionObserver is renamed "Fake...".

Bug: chromium:1071733
Change-Id: I920368e648bede481058ac22f5b8794752a220b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179100
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31798}
2020-07-28 10:05:57 +00:00
b2b6cd3af9 Delete dead code from JNI audio header.
Bug: webrtc:9048
Change-Id: I912a50f84a3afbb7cd13357ba8b134323fd53ed9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180343
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31797}
2020-07-28 09:50:07 +00:00
0bb2639060 Add heavy metrics tests for default VQ analyzer
Bug: webrtc:11801
Change-Id: I35c80deeacd553eea62d9449e77c3a2a61188130
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180341
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31796}
2020-07-27 15:56:38 +00:00
ff571c60a9 AEC3: Fix render delay buffer alignment issue at call start
Internal counters in the RenderDelayBuffer can slip out of sync with external counters, leading to buffer misalignment.
This CL gives the RenderDelayBuffer an opportunity to update its counters.

Tested:
Passes: modules_unittests --gtest_filter=BlockProcessor.*
Fails as expected due to new unit test: modules_unittests --gtest_filter=BlockProcessor.* --force_fieldtrials="WebRTC-Aec3RenderBufferCallCounterUpdateKillSwitch/Enabled/"

audioproc_f with default AEC settings has been verified to be bit-exact on a large number of aecdumps.

Bug: webrtc:11803
Change-Id: I9363b834c8c8c934add0335013df60bf131da4bc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180126
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31795}
2020-07-27 15:19:58 +00:00
49c293f03d Revert "Removed VideoDecoderFactory::LegacyCreateVideoDecoder and VideoReceiveStream::Config::stream_id."
This reverts commit 4ba1044bae750ab8ee47b359c21f672386b7c3cd.

Reason for revert: Downstream projects require some updates.

Original change's description:
> Removed VideoDecoderFactory::LegacyCreateVideoDecoder and VideoReceiveStream::Config::stream_id.
> 
> Bug: webrtc:9106
> Change-Id: I7fa84095732c33d136a9354ae4f09266cffcf877
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180020
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
> Commit-Queue: Philip Eliasson <philipel@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31793}

TBR=henrika@webrtc.org,magjed@webrtc.org,philipel@webrtc.org,mflodman@webrtc.org

Change-Id: I8c980266334cc9871b9076713da3c4df8f73f8ce
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9106
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180344
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31794}
2020-07-27 13:55:00 +00:00