73ef48cf05
Remove set but otherwise unused variables
...
Recent Clang versions have enhanced -Wunused-but-set-variable which now
warns about this.
Bug: chromium:1309955
Change-Id: Ie70df85f5a6d2cbabb4e10960bfd926ff7bf32cb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257162
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Hans Wennborg <hans@chromium.org >
Cr-Commit-Position: refs/heads/main@{#36381}
2022-03-30 14:38:50 +00:00
7abf45fe2c
LSC: Apply clang-tidy's modernize-use-bool-literals
...
The check finds implicit conversions of integer literals to bools:
bool b1 = 1;
bool b2 = static_cast<bool>(1);
and transforms them to:
bool b1 = true;
bool b2 = true;
Bug: chromium:1290142
Change-Id: I6819a0bd2ca84ecadae08ed9389c17d2652589f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/248166
Auto-Submit: Anton Bikineev <bikineev@chromium.org >
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Commit-Queue: Anton Bikineev <bikineev@chromium.org >
Cr-Commit-Position: refs/heads/main@{#35778}
2022-01-24 20:42:01 +00:00
fa68ac0c4e
Reland "Remove legacy delay manger field trial and update default config."
...
This is a reland of 93849d4b2a976b0a46059d6f74d9efd8f12eab92
Original change's description:
> Remove legacy delay manger field trial and update default config.
>
> Bug: webrtc:10333
> Change-Id: I20e55d8d111d93657d1afe556fe3a325337c074c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232820
> Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
> Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35321}
Bug: webrtc:10333
Change-Id: I9b3c732309d32640d15c372a4dde37d5d44c95d1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237502
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35325}
2021-11-09 14:49:56 +00:00
46814941f2
Revert "Remove legacy delay manger field trial and update default config."
...
This reverts commit 93849d4b2a976b0a46059d6f74d9efd8f12eab92.
Reason for revert: AcmReceiverBitExactnessOldApi tests failing on MacARM64; first failing build https://ci.chromium.org/ui/p/webrtc/builders/ci/MacARM64%20M1%20Release/1038/overview
Example faliure
[ RUN ] AcmReceiverBitExactnessOldApi.8kHzOutput
...
(rtp_file_reader.cc:165): Failed to read
../../modules/audio_coding/acm2/audio_coding_module_unittest.cc:912: Failure
Expected equality of these values:
checksum_ref
Which is: "636efe6d0a148f22c5383f356da3deac"
checksum_string
Which is: "6a288942d67e82076b38b17777cdaee4"
Original change's description:
> Remove legacy delay manger field trial and update default config.
>
> Bug: webrtc:10333
> Change-Id: I20e55d8d111d93657d1afe556fe3a325337c074c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232820
> Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
> Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#35321}
TBR=ivoc@webrtc.org ,jakobi@webrtc.org ,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: I0bd3832aacba8dcd8e836650786cea20b4c083be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10333
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237441
Reviewed-by: Olga Sharonova <olka@webrtc.org >
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Commit-Queue: Olga Sharonova <olka@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35324}
2021-11-09 09:10:39 +00:00
93849d4b2a
Remove legacy delay manger field trial and update default config.
...
Bug: webrtc:10333
Change-Id: I20e55d8d111d93657d1afe556fe3a325337c074c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232820
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#35321}
2021-11-08 11:14:09 +00:00
d00ce747c7
Use backticks not vertical bars to denote variables in comments for /modules/audio_coding
...
Bug: webrtc:12338
Change-Id: I02613d9fca45d00e2477f334b7a0416e7912e26b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227037
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34621}
2021-08-02 10:45:40 +00:00
55ec1a43bb
Fix some instances of -Wunused-but-set-variable.
...
Bug: chromium:1203071
Change-Id: I1ef3c8fd1f8e2bbf980d5d5217257e919f4564c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226961
Commit-Queue: Peter Kasting <pkasting@chromium.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#34579}
2021-07-28 02:08:30 +00:00
39cf3c723e
Clean up the NetEqFactory API.
...
This CL decouples NetEqFactory and AudioDecoderFactory.
AudioDecoderFactory is used in more places than just inside of NetEq, so
decoupling these makes sense.
Bug: webrtc:11005
Change-Id: I78dd856e4248e398e69a65816b062ef30555b055
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161005
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29961}
2019-11-29 14:04:44 +00:00
3a65f392a3
Expose NetEqDecodingTest for re-use in chromium tests.
...
This CL allows to trigger related tests when rolling opus
(at chromium side). Namely:
* TestOpusBitExactness
* TestOpusDtxBitExactness
This CL also prevents name clash for OpusTest:
* modules/audio_coding/test/opus_test.h: Helper class.
* modules/audio_coding/neteq/opus_unittest.cc: Local test fixture.
Bug: chromium:1002973
Change-Id: If8470b5f64fbdb1f7a84b838bde62d8c90390f2c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159033
Commit-Queue: Yves Gerey <yvesg@google.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29759}
2019-11-11 17:45:46 +00:00
