a907e01c63
Adding constness.
...
Make a few member variables in the Transport class officially const so that it's clear that locking isn't needed for access. There are getters for some of these (e.g. content_name()) that don't have locking or checking, so making the variables const is at least a way to guard against regressions. Also making the clock_ member in overuse_frame_detector.h const for clarity that it doesn't require a lock for access.
No code change.
Review URL: https://webrtc-codereview.appspot.com/35949004
Cr-Commit-Position: refs/heads/master@{#8186}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8186 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-28 17:33:45 +00:00
0b1534c52e
Use int64_t for milliseconds more often, primarily for TimeUntilNextProcess.
...
This fixes a variety of MSVC warnings about value truncations when implicitly
storing the 64-bit values we get back from e.g. TimeTicks in 32-bit objects, and
removes the need for a number of explicit casts.
This also moves a number of constants so they're declared right where they're used, which is easier to read and maintain, and makes some of them of integral type rather than using the "enum hack".
BUG=chromium:81439
TEST=none
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/33649004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7905 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-15 22:09:40 +00:00
cd621a8657
Add thread annotations to overuse_frame_detector class.
...
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29029004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7678 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-11 09:40:19 +00:00
7f10513efc
Remove unused code in overuse detector.
...
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7557 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-29 10:05:21 +00:00
9aed002090
Add ability to include a larger time span (in addition to encode time) for measuring the processing time of a frame.
...
Controlled by setting enable_extended_processing_usage. Enabled by default.
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13289004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7460 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-16 06:57:12 +00:00
74aaf29a0f
Raw packet loss rate reported by RTP_RTCP module may vary too drastically over time. This CL is to add a filter to the value in VoE before lending it to audio coding module.
...
The filter is an exponential filter borrowed from video coding module.
The method is written in a new class called PacketLossProtector (not sure if the name is nice), which can be used in the future for more sophisticated logic.
BUG=
R=henrika@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20809004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6709 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-16 21:28:26 +00:00
d980307197
Add max limit of number for overuses. When limit is reached always apply the rampup delay.
...
BUG=1577
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6451 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-16 14:27:19 +00:00
734a532723
Add additional metric (relative standard deviation of encode time) for overuse detection.
...
This code is currently only for testing.
BUG=1577
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19619004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6381 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-10 06:35:22 +00:00
ab6bf4f54c
Added api for getting cpu measures using a struct.
...
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6249 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-27 07:43:15 +00:00
88fbb2d86b
Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
...
Same as https://webrtc-codereview.appspot.com/19519004 . The issue in
http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Linux ...
is solved by this change
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/libjingle/libjing ...
(tested locally).
BUG=3380
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17619005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6218 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 21:18:46 +00:00
2fa7f79094
Revert 6202 "Switch to using base/constructormagic.h and remove ..."
...
> Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
>
> BUG=N/A
> R=andrew@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/19519004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14579007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6210 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 11:07:29 +00:00
125ffd709d
Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
...
BUG=N/A
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19519004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6202 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-20 15:20:44 +00:00
8a8c3ef2ae
Add ability to configure cpu overuse options via an API.
...
BUG=1577
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9299006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5736 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-20 13:15:01 +00:00
a0a6df3910
Modified overuse detection thresholds.
...
BUG=1577
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8949005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5585 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-20 17:37:37 +00:00
b60346e951
Reset estimate if no frame has been seen for a certain time (to avoid large jitter if stop sending).
...
Add delay before start processing after a reset.
BUG=1577
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8699006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5561 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-17 19:02:15 +00:00
8f690bc222
Increase overuse and normal use thresholds for Mac.
...
BUG=1577
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8629004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5544 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-13 14:43:18 +00:00
9e5b0342f6
Added a delay measurement, measures the time between an incoming captured frame until the frame is being processed. Measures the delay per second.
...
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4249004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5212 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-04 13:47:44 +00:00
c7ff8f990a
Added measure of encode time. Added encode time to the ViE CpuOveruseMeasure api.
...
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4099004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5178 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-26 11:12:33 +00:00
b24d33565c
Added ViE API for getting overuse measure.
...
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3129005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5141 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-20 13:51:40 +00:00
e2af622edf
- Reset capture deltas at resolution change.
...
- Applied smoothing of capture jitter.
- Adjusted thresholds.
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2070005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4817 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-23 20:05:39 +00:00
a957570d62
Overuse detection based on capture-input jitter.
...
This is believed to be more reliable in real-world cases. The camera seems to fall behind sooner than the encoder starts taking too long time encoding, so this is believed to be an earlier trigger.
BUG=2325
R=asapersson@webrtc.org , mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2140004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4648 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-30 17:16:32 +00:00
d4412feeb0
Adding possibility to use encoding time when trigger underuse for frame based overuse detection.
...
BUG=
TEST=Added unittest.
R=asapersson@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1885004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4452 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-31 16:42:21 +00:00
6879c8adad
Hooking up first simple CPU adaptation version.
...
BUG=
R=pbos@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1767004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4384 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-23 11:35:00 +00:00
e6168f5f41
Adding a first simple version of overuse detection, but not hooked up.
...
BUG=
R=asapersson@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1717004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4268 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-06-26 11:23:01 +00:00
