zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
19,122 Commits 1 Branch 0 Tags
aa568a64edab7adf8369c4905dcb7afbdba84cca
Commit Graph

4 Commits

Author SHA1 Message Date
Mirko Bonadei
a730c1c5ae Enabling and fixing CheckNewlineAtTheEndOfProtoFiles 
This check has been skipped during the migration from src/webrtc to
src. It was also reporting false positives. Now it should be fixed.

NOTRY=True

Bug: chromium:611808
Change-Id: Id8567dd92099e75ac35351f053829deebf28a9d1
Reviewed-on: https://webrtc-review.googlesource.com/1580
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19887}
 2017-09-18 10:58:36 +00:00
Henrik Kjellander
a18a3bf8d6 Fix Python shebang and license for presubmit_test.py 
This was missed during review of https://codereview.webrtc.org/3010153002
Having python2 in the shebang makes it fail presubmit locally on Mac.

Disable 'invalid-name' PyLint rule in 3 places to pass presubmit.

NOTRY=True
NOTREECHECKS=True
TBR=charujain@webrtc.org

Bug: none
Change-Id: I85cc5783ba11774792cd8c2f6c0b4ff47ad89270
Reviewed-on: https://webrtc-review.googlesource.com/1566
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19850}
 2017-09-15 09:22:50 +00:00
Edward Lemur
6d01f6d220 Fix PRESUBMIT.py 
NOTRY=True
TBR=kjellander@webrtc.org

Bug: webrtc:8197
Change-Id: Ie8b50faec7c6c5f7b9dd259c8312e4cec5748a42
Reviewed-on: https://webrtc-review.googlesource.com/1361
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Charu Jain <charujain@webrtc.org>
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19838}
 2017-09-14 15:15:29 +00:00
charujain
9893e253f9 PRESUBMIT: Enforce tracker prefix for all BUG entries 
Changed function definition from private to public. This was needed to test the function and to maintain the consistency.

BUG=webrtc:8197
NOTRY=True
R=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/3010153002 .
Cr-Commit-Position: refs/heads/master@{#19831}
 2017-09-14 11:33:23 +00:00