82c71af262
Revert "Modernize rtc::SSLCertificate"
...
This reverts commit 55cd3ac804811e02b9b14026c683f9b30ea0c0bb.
Reason for revert: Breaks Chrome compile: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932588150164377824/+/steps/compile__with_patch_/0/stdout
Original change's description:
> Modernize rtc::SSLCertificate
>
> Bug: webrtc:9860
> Change-Id: Idfce546ded500d957397c5bd873200565d3e6b64
> Reviewed-on: https://webrtc-review.googlesource.com/c/105280
> Reviewed-by: Benjamin Wright <benwright@webrtc.org >
> Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
> Commit-Queue: Steve Anton <steveanton@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25150}
TBR=steveanton@webrtc.org ,qingsi@webrtc.org ,benwright@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:9860
Change-Id: I4ff090f2612252cd656a34a0181aff81488c6edf
Reviewed-on: https://webrtc-review.googlesource.com/c/105946
Reviewed-by: Niklas Enbom <niklas.enbom@webrtc.org >
Commit-Queue: Niklas Enbom <niklas.enbom@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25182}
2018-10-15 17:31:05 +00:00
6932fb2e34
Revert "Reland: Use unique_ptr and ArrayView in SSLFingerprint"
...
This reverts commit 47f3240a6621e90a17d92e620ae765c353c87e11.
Reason for revert: Breaks WebRTC roll into Chromium.
Original change's description:
> Reland: Use unique_ptr and ArrayView in SSLFingerprint
>
> Bug: webrtc:9860
> Change-Id: I550528556aa27050015de29d9d7d99cd9df59ce5
> Reviewed-on: https://webrtc-review.googlesource.com/c/105520
> Reviewed-by: Benjamin Wright <benwright@webrtc.org >
> Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
> Commit-Queue: Steve Anton <steveanton@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25149}
TBR=steveanton@webrtc.org ,qingsi@webrtc.org ,benwright@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:9860
Change-Id: Ib1b5759abf6e79a569ca04b66eabc3021d4c16e4
Reviewed-on: https://webrtc-review.googlesource.com/c/106060
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25173}
2018-10-15 14:48:31 +00:00
55cd3ac804
Modernize rtc::SSLCertificate
...
Bug: webrtc:9860
Change-Id: Idfce546ded500d957397c5bd873200565d3e6b64
Reviewed-on: https://webrtc-review.googlesource.com/c/105280
Reviewed-by: Benjamin Wright <benwright@webrtc.org >
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25150}
2018-10-12 19:51:23 +00:00
47f3240a66
Reland: Use unique_ptr and ArrayView in SSLFingerprint
...
Bug: webrtc:9860
Change-Id: I550528556aa27050015de29d9d7d99cd9df59ce5
Reviewed-on: https://webrtc-review.googlesource.com/c/105520
Reviewed-by: Benjamin Wright <benwright@webrtc.org >
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25149}
2018-10-12 19:48:45 +00:00
2b1562632a
Revert "Use unique_ptr and ArrayView in SSLFingerprint"
...
This reverts commit cc21e61e07e641f58315a8976427c77614138c90.
Reason for revert: Breaks WebRTC roll in Chromium. See https://chromium-review.googlesource.com/c/chromium/src/+/1275426
Original change's description:
> Use unique_ptr and ArrayView in SSLFingerprint
>
> Bug: webrtc:9860
> Change-Id: Id919c3a53604357c5ab449f6ab8a1d2ea6575fbe
> Reviewed-on: https://webrtc-review.googlesource.com/c/105220
> Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
> Reviewed-by: Benjamin Wright <benwright@webrtc.org >
> Commit-Queue: Steve Anton <steveanton@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25102}
TBR=steveanton@webrtc.org ,qingsi@webrtc.org ,benwright@webrtc.org
Change-Id: Icd48314289f3285bfab034712bc022acb5eea88a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9860
Reviewed-on: https://webrtc-review.googlesource.com/c/105307
Reviewed-by: Henrik Grunell <henrikg@webrtc.org >
Commit-Queue: Henrik Grunell <henrikg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25112}
2018-10-11 11:16:01 +00:00
cc21e61e07
Use unique_ptr and ArrayView in SSLFingerprint
...
Bug: webrtc:9860
Change-Id: Id919c3a53604357c5ab449f6ab8a1d2ea6575fbe
Reviewed-on: https://webrtc-review.googlesource.com/c/105220
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Benjamin Wright <benwright@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25102}
2018-10-11 03:44:49 +00:00
2e00abc98e
Reland "[cleanup] Remove useless includes."
...
Reason for reland: Downstream project fixed.
Original change's description:
> [cleanup] Remove useless includes.
>
> Manual cleanup guided by include-what-you-use diagnostic.
>
> Bug: webrtc:8311
> Change-Id: I00be03392cc7ee005101427ea7dc701621ccea68
> Reviewed-on: https://webrtc-review.googlesource.com/c/103320
> Commit-Queue: Yves Gerey <yvesg@webrtc.org >
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25013}
Bug: webrtc:8311
Change-Id: Id6ec4aeb798886a90ace640a190eaf16497ba31b
Reviewed-on: https://webrtc-review.googlesource.com/c/104120
Commit-Queue: Yves Gerey <yvesg@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25034}
2018-10-08 07:44:19 +00:00
96a0f61917
Revert "[cleanup] Remove useless includes."
...
This reverts commit be8b5348c76105f8fe869b0cae4065ddca106419.
Reason for revert: Breaks downstream project
Original change's description:
> [cleanup] Remove useless includes.
>
> Manual cleanup guided by include-what-you-use diagnostic.
>
> Bug: webrtc:8311
> Change-Id: I00be03392cc7ee005101427ea7dc701621ccea68
> Reviewed-on: https://webrtc-review.googlesource.com/c/103320
> Commit-Queue: Yves Gerey <yvesg@webrtc.org >
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25013}
TBR=phoglund@google.com ,phoglund@webrtc.org ,yvesg@webrtc.org
Change-Id: I7a6e1cdfef685173b76f234ad598083043dcd9a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8311
Reviewed-on: https://webrtc-review.googlesource.com/c/104022
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25015}
2018-10-05 13:13:45 +00:00
be8b5348c7
[cleanup] Remove useless includes.
...
Manual cleanup guided by include-what-you-use diagnostic.
Bug: webrtc:8311
Change-Id: I00be03392cc7ee005101427ea7dc701621ccea68
Reviewed-on: https://webrtc-review.googlesource.com/c/103320
Commit-Queue: Yves Gerey <yvesg@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25013}
2018-10-05 11:51:06 +00:00
a76af0ca2e
Move base64.h to the proper location.
...
Move base64.h to the proper location and put redirect header into the
old place to be able to switch downstream users on new location.
Bug: webrtc:8366
Change-Id: I5191fe631d32178d2efd1315ca9abd4250102291
Reviewed-on: https://webrtc-review.googlesource.com/88223
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#24069}
2018-07-23 15:40:36 +00:00
918f50c5d1
Use absl::make_unique and absl::WrapUnique directly
...
Instead of going through our wrappers in ptr_util.h.
This CL was generated by the following script:
git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",'
git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g'
git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g'
git checkout -- rtc_base/ptr_util{.h,_unittest.cc}
git cl format
Followed by manually adding dependencies on
//third_party/abseil-cpp/absl/memory until `gn check` stopped
complaining.
Bug: webrtc:9473
Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c
Reviewed-on: https://webrtc-review.googlesource.com/86600
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 10:59:49 +00:00
d6f86e8fca
This changeset adds dependency injection support for SSL Root Certs.
...
This extends the API surface so that
custom certificates can be provided by an API user in both the standalone and
factory creation paths for the OpenSSLAdapter. Prior to this change the SSL
roots were hardcoded in a header file and directly included into
openssladapter.cc. This forces the 100 kilobytes of certificates to always be
compiled into the library. This is undesirable in certain linking cases where
these certificates can be shared from another binary that already has an
equivalent set of trusted roots hard coded into the binary.
Support for removing the hard coded SSL roots has also been added through a new
build flag. By default the hard coded SSL roots will be included and will be
used if no other trusted root certificates are provided.
The main goal of this CL is to reduce total binary size requirements of WebRTC
by about 100kb in certain applications where adding these certificates is
redundant.
Change-Id: Ifd36d92b5cb32d1b3098a61ddfc244d76df8f30f
Bug: chromium:526260
Change-Id: Ifd36d92b5cb32d1b3098a61ddfc244d76df8f30f
Reviewed-on: https://webrtc-review.googlesource.com/64841
Commit-Queue: Benjamin Wright <benwright@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#23180}
2018-05-09 00:24:05 +00:00
