ad502fa727
Revert "Switch low bw audio test to histograms."
...
This reverts commit 71c9a18f2532f4aec0727ce7b932aca8b61fab6f.
Reason for revert: Relevant python code isn't pulled when the test runs on swarming.
Original change's description:
> Switch low bw audio test to histograms.
>
> Also requires a recipe change so the results processor switches to
> histogram mode when this CL is landed.
>
> Bug: chromium:1029452
> Change-Id: Ic09deefc3f4f9d7a82ffeafeb5209fcfc361aece
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171683
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30884}
TBR=phoglund@webrtc.org ,titovartem@webrtc.org
Change-Id: I6b3645ff939943a21185a1a1c8c5a0877e29db8c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029452
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171692
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30893}
2020-03-26 06:46:33 +00:00
71c9a18f25
Switch low bw audio test to histograms.
...
Also requires a recipe change so the results processor switches to
histogram mode when this CL is landed.
Bug: chromium:1029452
Change-Id: Ic09deefc3f4f9d7a82ffeafeb5209fcfc361aece
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171683
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30884}
2020-03-25 14:52:10 +00:00
1b20c41dcb
Greatly simplify flags for test binaries.
...
Since we're now calling the shots of what flags get passed in the
recipes, we can just pass the right ones right away and remove all
the flag renaming.
--isolated-script-test-output is no longer passed, so we can just
remove it. The recipe is currently passing
--isolated-script-perf-test-output but I will start passing the
underscore version shortly.
Bug: chromium:1051927
Change-Id: I571090e62f79ea17c793295df7f5abb21f45d207
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171681
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30878}
2020-03-25 09:56:07 +00:00
cbc91efaa0
Improve low bandwidth audio test instrumentatin, fix PC test
...
Bug: webrtc:10138
Change-Id: I1d72fcac642064e569f6aac259fd0b6e0cf5c8b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146603
Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28644}
2019-07-23 11:54:10 +00:00
b1f2d60456
Reland "Fix collection of audio metrics from PC test framework for audio test"
...
This is a reland of 2d0880b56954f57548deea51dfa678b80dbf618f
To fix perf bot issue reading of perf results file was updated. Now perf
results file will be generated by each test and then returned via output to
the python script, which will get it and put into final file.
Original change's description:
> Fix collection of audio metrics from PC test framework for audio test
>
> Bug: webrtc:10138
> Change-Id: I18a8509a0cdc4ed1db6894c7540d5c0a155d6233
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144784
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
> Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28514}
Bug: webrtc:10138
Change-Id: I1347f09427736362a2d550612b48e09c06cfb1d1
No-Presubmit: True
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145201
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28527}
2019-07-10 15:21:30 +00:00
4876cb21c8
Revert "Fix collection of audio metrics from PC test framework for audio test"
...
This reverts commit 2d0880b56954f57548deea51dfa678b80dbf618f.
Reason for revert: Breaks perf tests (e.g. https://ci.chromium.org/p/webrtc/builders/perf/Perf%20Android32%20(L%20Nexus4)/1470 ).
Original change's description:
> Fix collection of audio metrics from PC test framework for audio test
>
> Bug: webrtc:10138
> Change-Id: I18a8509a0cdc4ed1db6894c7540d5c0a155d6233
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144784
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
> Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28514}
TBR=oprypin@webrtc.org ,ossu@webrtc.org ,titovartem@webrtc.org
Change-Id: Id45abfbb0de47d95fe6cb396b1c29efb97a43797
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10138
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144883
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28519}
2019-07-09 20:09:14 +00:00
2d0880b569
Fix collection of audio metrics from PC test framework for audio test
...
Bug: webrtc:10138
Change-Id: I18a8509a0cdc4ed1db6894c7540d5c0a155d6233
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144784
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28514}
2019-07-09 13:08:53 +00:00
637b0b5d38
Make Python-based performance tests output an empty result output.json
...
TBR: phoglund@webrtc.org
Bug: webrtc:9767
Change-Id: I2e51e33ae2fd13a1e09f641dd4f2819f5901b15b
Reviewed-on: https://webrtc-review.googlesource.com/101360
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Yves Gerey <yvesg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#24784}
2018-09-21 15:45:38 +00:00
9599fd4414
Make num-retries default a string.
...
TBR=phoglund@webrtc.org
Bug: chromium:755660
Change-Id: I770a79a78721a312b603aec40d23689245a48001
Reviewed-on: https://webrtc-review.googlesource.com/61343
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#22392}
2018-03-12 21:19:51 +00:00
5b9c6840b1
Add num-retries flag to Android perf tests.
...
Add a flag to Android perf tests, so we can specify the number of
retries.
Bug: chromium:755660
Change-Id: Ic498373421b7e0fdf779a4659a0c79d47a59fbde
Reviewed-on: https://webrtc-review.googlesource.com/61103
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#22390}
2018-03-12 19:51:09 +00:00
ed7b4ff9e3
Use isolated-script-test-perf-output on low_bandwidth_audio_test.
...
Instead of chartjson-result-file, since that's the flag passed by the recipe.
TBR=phoglund@webrtc.org
Bug: chromium:807737
Change-Id: I3a679ab7e5c0a446e675d0f4647344cc4194b357
Reviewed-on: https://webrtc-review.googlesource.com/46541
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#21858}
2018-02-01 20:35:24 +00:00
d8b041cc54
Ignore extra arguments in low_bandwidth_audio_test.
...
R=phoglund@webrtc.org
TBR=solenberg@webrtc.org
Bug: chromium:755660
Change-Id: I39488f6905875bdc08b006619b972d3f1af2fce1
Reviewed-on: https://webrtc-review.googlesource.com/39924
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#21641}
2018-01-16 14:07:54 +00:00
b4017712c5
Store JSON perf results for low_bandwidth_audio_test.
...
Bug: chromium:755660
Change-Id: I87c19f8dde14772e75f93c723f11408702ca8c8e
Reviewed-on: https://webrtc-review.googlesource.com/39515
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#21615}
2018-01-15 15:24:09 +00:00
88b23f6662
Fix flag name in low_bandwidth_audio_test.py
...
TBR=kjellander@webrtc.org , oprypin@webrtc.org
No-Try: true
Bug: chromium:755660
Change-Id: I6bf5dda5374cae16da54aa10e77b136c638e1975
Reviewed-on: https://webrtc-review.googlesource.com/6442
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20148}
2017-10-04 17:26:14 +00:00
7e3b5697d9
Ignore swarming arguments in low_bandwidth_audio_test.py
...
Needed because swarming adds --isolated-script-test-output and --isolated-script-test-perf-output
See for example:
https://chromium-swarm.appspot.com/task?id=39006c763bebf710
No-Try: true
Bug: chromium:755660
Change-Id: Iff9fb3441200f760c511a67211fbc4a1272717b4
Reviewed-on: https://webrtc-review.googlesource.com/6362
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20146}
2017-10-04 16:19:44 +00:00
b0250f0504
Reland "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
...
This is a reland of f4898a650954691d79bbc146d5b454fb5e67ec47
Original change's description:
> Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script.
>
> They should've been downloaded already.
>
> NOTRY=True
>
> Bug: chromium:755660
> Change-Id: I8ecb355f06026a38bd9377633e2be6c55d7c6452
> Reviewed-on: https://webrtc-review.googlesource.com/5620
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20109}
No-Try: true
Bug: chromium:755660
Change-Id: I391130545eee5d4928101f87ac4a4e0945d665a1
Reviewed-on: https://webrtc-review.googlesource.com/6380
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20140}
2017-10-04 13:03:24 +00:00
45a0b36d3f
Revert "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
...
Reason for revert: Breaks windows bot.
https://build.chromium.org/p/client.webrtc.perf/builders/Win7/builds/3804
TBR=kjellander@webrtc.org ,phoglund@webrtc.org ,ehmaldonado@webrtc.org ,oprypin@webrtc.org
Change-Id: I0f2221b66c4f7dcf0a6f03004e5acc24c77ba8b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/6001
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20117}
2017-10-03 14:00:15 +00:00
f4898a6509
Reland "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
...
This reverts commit bb1222f3adacec0a096451a79c391663e9f22335.
Reason for revert: Fixing
Original change's description:
> Revert "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
>
> This reverts commit 20196984558b890ee7648d5cc778bc055fdeb5b2.
>
> Reason for revert: Fails on Mac
> https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/4070
>
> Original change's description:
> > Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script.
> >
> > They should've been downloaded already.
> >
> > NOTRY=True
> >
> > Bug: chromium:755660
> > Change-Id: I8ecb355f06026a38bd9377633e2be6c55d7c6452
> > Reviewed-on: https://webrtc-review.googlesource.com/5620
> > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
> > Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
> > Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#20109}
>
> TBR=kjellander@webrtc.org ,phoglund@webrtc.org ,ehmaldonado@webrtc.org ,oprypin@webrtc.org
>
> Change-Id: I0cfc1d0b398587a023af528536e7d995c6de1413
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:755660
> Reviewed-on: https://webrtc-review.googlesource.com/5940
> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20112}
No-Try: true
Bug: chromium:755660
Change-Id: Idbf30003c78c4093afcaf99dc0c5bb3468cdcf6d
Reviewed-on: https://webrtc-review.googlesource.com/5941
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20113}
2017-10-03 12:49:51 +00:00
bb1222f3ad
Revert "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
...
This reverts commit 20196984558b890ee7648d5cc778bc055fdeb5b2.
Reason for revert: Fails on Mac
https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/4070
Original change's description:
> Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script.
>
> They should've been downloaded already.
>
> NOTRY=True
>
> Bug: chromium:755660
> Change-Id: I8ecb355f06026a38bd9377633e2be6c55d7c6452
> Reviewed-on: https://webrtc-review.googlesource.com/5620
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#20109}
TBR=kjellander@webrtc.org ,phoglund@webrtc.org ,ehmaldonado@webrtc.org ,oprypin@webrtc.org
Change-Id: I0cfc1d0b398587a023af528536e7d995c6de1413
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/5940
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20112}
2017-10-03 12:33:52 +00:00
2019698455
Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script.
...
They should've been downloaded already.
NOTRY=True
Bug: chromium:755660
Change-Id: I8ecb355f06026a38bd9377633e2be6c55d7c6452
Reviewed-on: https://webrtc-review.googlesource.com/5620
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20109}
2017-10-03 11:25:10 +00:00
5a6aa4f05d
Fix path to root in low_bandwidth_audio_test.py
...
BUG=chromium:611808
TBR=solenberg@webrtc.org
NOTRY=True
NOPRESUBMIT=True
NOTREECHECKS=True
Change-Id: Iba2b0851ee99916b9809231b4b27046315fd8565
Reviewed-on: https://webrtc-review.googlesource.com/1569
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org >
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19849}
2017-09-15 08:29:11 +00:00
bb547203bf
Moving src/webrtc into src/.
...
In order to eliminate the WebRTC Subtree mirror in Chromium,
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00