27ce02eb06
Do not delete temporary directory if user specified it manually.
...
This prevents user from accidentally specifying a directory that contains
files that the user wants to keep.
BUG=webrtc:7608
NOTRY=True
Review-Url: https://codereview.webrtc.org/2876803002
Cr-Commit-Position: refs/heads/master@{#18096}
2017-05-11 10:36:21 +00:00
2e3574dd18
Test for Gradle project generation.
...
BUG=webrtc:7608
Review-Url: https://codereview.webrtc.org/2858043006
Cr-Commit-Position: refs/heads/master@{#18063}
2017-05-09 09:10:57 +00:00
90fd7d84fd
Rename tools-webrtc -> tools_webrtc
...
This aligns with established naming convention for all
other directories.
BUG=webrtc:7593
NOTRY=True
NOTREECHECKS=True
R=ehmaldonado@webrtc.org , mbonadei@webrtc.org
TBR=henrika@webrtc.org
Review-Url: https://codereview.webrtc.org/2864213004 .
Cr-Commit-Position: refs/heads/master@{#18059}
2017-05-09 06:30:13 +00:00
9c7e56498b
Properly send URL parameters in all requests
...
https://codereview.webrtc.org/2825313002/
added this only to connection URL but it's needed everywhere
BUG=webrtc:7548
Review-Url: https://codereview.webrtc.org/2858493003
Cr-Commit-Position: refs/heads/master@{#17981}
2017-05-03 08:58:39 +00:00
78ef2c7da7
Disable video quality test due to unexpected failures
...
BUG=webrtc:7548
NOTRY=True
Review-Url: https://codereview.webrtc.org/2854803002
Cr-Commit-Position: refs/heads/master@{#17966}
2017-05-02 07:09:32 +00:00
2e79958c42
Fix redirecting to local AppRTC server in video quality test
...
BUG=webrtc:7185
Review-Url: https://codereview.webrtc.org/2843003002
Cr-Commit-Position: refs/heads/master@{#17888}
2017-04-26 13:52:35 +00:00
30cda5ef98
Espresso test for loopback video quality testing
...
Update the AppRTCMobileTestStubbedVideoIO test to run on
phones without Internet connection. This is done by bringing up
a local instance of AppRTC on the Linux machine connected to
the Android device.
Running this test will need the webrtc.DEPS solution to be configured
for the checkout, since that will pull down the precompiled AppRTC
package that is needed.
Continued from http://crrev.com/2780493002#ps20001 (by kjellander@)
Continued from http://crrev.com/2741743002#ps180001 (by mandermo@)
BUG=webrtc:7185
Review-Url: https://codereview.webrtc.org/2825313002
Cr-Commit-Position: refs/heads/master@{#17838}
2017-04-24 11:15:13 +00:00
76ec9d7364
Removed duplicated annotation in webrtc/examples/androidtests/AndroidManifest.xml
...
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2679143002
Cr-Commit-Position: refs/heads/master@{#17787}
2017-04-20 12:31:32 +00:00
c88b5d56ad
Reland of PyLint fixes for tools-webrtc and webrtc/tools (patchset #1 id:1 of https://codereview.webrtc.org/2737233003/ )
...
Reason for revert:
Fixing errors for reland. I have tested that this does not make Chromium video quality tests fail.
Original issue's description:
> Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001 of https://codereview.webrtc.org/2736233003/ )
>
> Reason for revert:
> Fails video quality tests in Chrome: http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/6568
> I should have looked more closer at those :(
>
> Original issue's description:
> > PyLint fixes for tools-webrtc and webrtc/tools
> >
> > Fix a lot of errors before bringing in the new config in
> > https://codereview.webrtc.org/2737963003/
> >
> > BUG=webrtc:7303
> > NOTRY=True
> >
> > Review-Url: https://codereview.webrtc.org/2736233003
> > Cr-Commit-Position: refs/heads/master@{#17137}
> > Committed: f5318e1f39
>
> TBR=oprypin@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7303
>
> Review-Url: https://codereview.webrtc.org/2737233003
> Cr-Commit-Position: refs/heads/master@{#17142}
> Committed: 94f4d9effc
NOTRY=true
BUG=webrtc:7312
Review-Url: https://codereview.webrtc.org/2741733003
Cr-Commit-Position: refs/heads/master@{#17541}
2017-04-05 13:42:43 +00:00
8444405aa4
Try re-enabling two PeerConnectionClientTests:
...
- org.appspot.apprtc.test.PeerConnectionClientTest#testCaptureFormatChange
- org.appspot.apprtc.test.PeerConnectionClientTest#testVideoSourceRestart
The tests were previously flaky but significant changes to the test
architecture have been made since. Opportunistically try to re-enable
them.
BUG=webrtc:6478
Review-Url: https://codereview.webrtc.org/2748863003
Cr-Commit-Position: refs/heads/master@{#17245}
2017-03-15 12:50:13 +00:00
94f4d9effc
Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001 of https://codereview.webrtc.org/2736233003/ )
...
Reason for revert:
Fails video quality tests in Chrome: http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/6568
I should have looked more closer at those :(
Original issue's description:
> PyLint fixes for tools-webrtc and webrtc/tools
>
> Fix a lot of errors before bringing in the new config in
> https://codereview.webrtc.org/2737963003/
>
> BUG=webrtc:7303
> NOTRY=True
>
> Review-Url: https://codereview.webrtc.org/2736233003
> Cr-Commit-Position: refs/heads/master@{#17137}
> Committed: f5318e1f39
TBR=oprypin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7303
Review-Url: https://codereview.webrtc.org/2737233003
Cr-Commit-Position: refs/heads/master@{#17142}
2017-03-09 14:09:33 +00:00
f5318e1f39
PyLint fixes for tools-webrtc and webrtc/tools
...
Fix a lot of errors before bringing in the new config in
https://codereview.webrtc.org/2737963003/
BUG=webrtc:7303
NOTRY=True
Review-Url: https://codereview.webrtc.org/2736233003
Cr-Commit-Position: refs/heads/master@{#17137}
2017-03-09 10:26:46 +00:00
0d4e235a96
Revert of Temporarily disable failing video_quality_loopback_test.py (patchset #1 id:1 of https://codereview.webrtc.org/2704073002/ )
...
Reason for revert:
Enabling this again so we can start running it experimentally on the bots.
Original issue's description:
> Temporarily disable failing video_quality_loopback_test.py
>
> BUG=webrtc:7185
> TBR=mandermo@webrtc.org
>
> Review-Url: https://codereview.webrtc.org/2704073002 .
> Cr-Commit-Position: refs/heads/master@{#16697}
> Committed: 6951a28b41
TBR=mandermo@webrtc.org
BUG=webrtc:7185
NOTRY=True
Review-Url: https://codereview.webrtc.org/2734333002
Cr-Commit-Position: refs/heads/master@{#17110}
2017-03-08 10:10:21 +00:00
c898825eb4
Add kjellander to OWNERS for *.py in examples/android{app,tests}
...
BUG=webrtc:7229
NOTRY=True
Review-Url: https://codereview.webrtc.org/2735673002
Cr-Commit-Position: refs/heads/master@{#17062}
2017-03-06 11:56:57 +00:00
3b2fb203fd
Add PESQ precompiled tool for audio quality testing
...
BUG=webrtc:7229
Review-Url: https://codereview.webrtc.org/2715933003
Cr-Commit-Position: refs/heads/master@{#17055}
2017-03-06 10:23:34 +00:00
5d43f74585
Remove buildbot annotation for video_quality_loopback_test.py
...
In https://codereview.webrtc.org/2704073002 an attempt was made to make
the buildbot step show up as orange, which didn't work. The step showed
up as a test failure, which will confuse sheriffs.
BUG=webrtc:7185
TBR=mandermo@webrtc.org
Review-Url: https://codereview.webrtc.org/2699383002 .
Cr-Commit-Position: refs/heads/master@{#16699}
2017-02-19 08:31:01 +00:00
6951a28b41
Temporarily disable failing video_quality_loopback_test.py
...
BUG=webrtc:7185
TBR=mandermo@webrtc.org
Review-Url: https://codereview.webrtc.org/2704073002 .
Cr-Commit-Position: refs/heads/master@{#16697}
2017-02-19 05:53:23 +00:00
d103f4ba4a
Modify android video_quality_loopback_test to run commands from the src dir.
...
R=kjellander@webrtc.org , mandermo@webrtc.org
TBR=perkj@webrtc.org
BUG=chromium:685222
NOTRY=True
Review-Url: https://codereview.webrtc.org/2695713002
Cr-Commit-Position: refs/heads/master@{#16647}
2017-02-16 15:20:26 +00:00
3029210c35
Move Android video quality loopback script.
...
It makes sense it's closer to the source code of the actual test.
Fix a bug that caused --help to fail.
BUG=webrtc:7034
NOTRY=True
Review-Url: https://codereview.webrtc.org/2681833007
Cr-Commit-Position: refs/heads/master@{#16505}
2017-02-09 09:05:54 +00:00
b99b5960e1
Add chromium-junit4 tag to instrumentation test AndroidManifests.
...
This tag is supposed to be temporary and removed when all Chromium tests
have been migrated to JUnit4.
BUG=webrtc:7123,chromium:640116
NOTRY=True
Review-Url: https://codereview.webrtc.org/2683583002
Cr-Commit-Position: refs/heads/master@{#16465}
2017-02-07 12:12:30 +00:00
e8aca24446
Move file capturer/renderer tests to the correct location.
...
Move file capturer/renderer tests from the AppRTCMobile tests directory
to the WebRTC tests directory. These tests do not test AppRTCMobile but
rather WebRTC functionality. Therefore, they belong in WebRTC tests
directory.
BUG=webrtc:6545
Review-Url: https://codereview.webrtc.org/2632233002
Cr-Commit-Position: refs/heads/master@{#16115}
2017-01-17 11:32:06 +00:00
a6069e8a01
Espresso test case to control loopback call
...
The test case is put inside a new test target. That test target will be started from a test script to asses video quality.
BUG=webrtc:6545
Review-Url: https://codereview.webrtc.org/2585813002
Cr-Commit-Position: refs/heads/master@{#16088}
2017-01-16 10:23:09 +00:00
77dc71f0f5
Remove some Android lint suppressions.
...
These were the easiest to remove, so let's start with these.
BUG=webrtc:6597
R=magjed@webrtc.org
TBR=kjellander@webrtc.org
Review-Url: https://codereview.webrtc.org/2628563002
Cr-Commit-Position: refs/heads/master@{#16023}
2017-01-12 08:16:56 +00:00
cb79d519fa
Update AppRTCMobile tests to use JUnit4.
...
BUG=webrtc:6597
Review-Url: https://codereview.webrtc.org/2621253002
Cr-Commit-Position: refs/heads/master@{#16010}
2017-01-11 14:21:26 +00:00
0582e6ca36
Add FlexFEC settings toggle in Android AppRTCMobile.
...
BUG=webrtc:5654
Review-Url: https://codereview.webrtc.org/2550393002
Cr-Commit-Position: refs/heads/master@{#15481}
2016-12-08 14:51:35 +00:00
9890a5861f
Testing of FileVideoCapturer.
...
Based on https://codereview.webrtc.org/2273573003/
BUG=webrtc:6545
Review-Url: https://codereview.webrtc.org/2405463002
Cr-Commit-Position: refs/heads/master@{#14801}
2016-10-27 14:26:44 +00:00
a8bec8d8e7
Testing of VideoFileRenderer with byte frames
...
BUG=webrtc:6545
Review-Url: https://codereview.webrtc.org/2415563002
Cr-Commit-Position: refs/heads/master@{#14781}
2016-10-26 08:47:14 +00:00
64e1a32e2f
Second try to get "Support for video file instead of camera and output video out to file" accepted
...
The old CL can be found here: https://codereview.webrtc.org/2273573003/
The orginal broke down stream, this CL tries to solve those issues.
BUG=webrtc:6545
Review-Url: https://codereview.webrtc.org/2426003002
Cr-Commit-Position: refs/heads/master@{#14665}
2016-10-18 15:47:59 +00:00
67a8c986ab
Revert of Support for video file instead of camera and output video out to file (patchset #17 id:320001 of https://codereview.webrtc.org/2273573003/ )
...
Reason for revert:
Breaks internal project.
Original issue's description:
> Support for video file instead of camera and output video out to file
>
> When video out to file is enabled the remote video which is recorded is
> not show on screen.
>
> You can use this command line for file input and output:
> monkeyrunner ./webrtc/examples/androidapp/start_loopback_stubbed_camera_saved_video_out.py --devname 02157df28cd47001 --videoin /storage/emulated/0/reference_video_1280x720_30fps.y4m --videoout /storage/emulated/0/output.y4m --videoout_width 1280 --videoout_height 720 --videooutsave /tmp/out.y4m
>
> BUG=webrtc:6545
>
> Committed: https://crrev.com/44666997ca912705f8f96c9bd211e719525a3ccc
> Cr-Commit-Position: refs/heads/master@{#14660}
TBR=magjed@webrtc.org ,sakal@webrtc.org ,jansson@chromium.org ,mandermo@google.com ,mandermo@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6545
Review-Url: https://codereview.webrtc.org/2425763003
Cr-Commit-Position: refs/heads/master@{#14664}
2016-10-18 13:05:40 +00:00
44666997ca
Support for video file instead of camera and output video out to file
...
When video out to file is enabled the remote video which is recorded is
not show on screen.
You can use this command line for file input and output:
monkeyrunner ./webrtc/examples/androidapp/start_loopback_stubbed_camera_saved_video_out.py --devname 02157df28cd47001 --videoin /storage/emulated/0/reference_video_1280x720_30fps.y4m --videoout /storage/emulated/0/output.y4m --videoout_width 1280 --videoout_height 720 --videooutsave /tmp/out.y4m
BUG=webrtc:6545
Review-Url: https://codereview.webrtc.org/2273573003
Cr-Commit-Position: refs/heads/master@{#14660}
2016-10-18 11:52:06 +00:00
134af7a9af
Disable flaky Android capture tests:
...
- org.appspot.apprtc.test.PeerConnectionClientTest#testCaptureFormatChange
- org.appspot.apprtc.test.PeerConnectionClientTest#testVideoSourceRestart
BUG=webrtc:6478
R=glaznev@webrtc.org , sakal@webrtc.org
Review URL: https://codereview.webrtc.org/2393653002 .
Cr-Commit-Position: refs/heads/master@{#14533}
2016-10-05 22:05:28 +00:00
b6760f9e44
Format all Java in WebRTC.
...
BUG=webrtc:6419
TBR=henrika@webrtc.org
Review-Url: https://codereview.webrtc.org/2377003002
Cr-Commit-Position: refs/heads/master@{#14432}
2016-09-29 11:12:51 +00:00
c1815cf084
Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ )
...
Reason for revert:
Internal project is updated.
Original issue's description:
> Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ )
>
> Reason for revert:
> Breaks internal project.
>
> Original issue's description:
> > Rename AppRTCDemo on Android and iOS to AppRTCMobile
> >
> > The purpose is to make it clearer it is a mobile application.
> >
> > BUG=webrtc:6359
> > NOPRESUBMIT=true
> >
> > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a
> > Cr-Commit-Position: refs/heads/master@{#14356}
>
> TBR=sakal@webrtc.org ,kthelgason@webrtc.org ,tommi@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6359
>
> Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1
> Cr-Commit-Position: refs/heads/master@{#14358}
TBR=sakal@webrtc.org ,kthelgason@webrtc.org ,tommi@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6359
Review URL: https://codereview.webrtc.org/2373443005 .
Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 08:10:52 +00:00
87ef6f7501
Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ )
...
Reason for revert:
Breaks internal project.
Original issue's description:
> Rename AppRTCDemo on Android and iOS to AppRTCMobile
>
> The purpose is to make it clearer it is a mobile application.
>
> BUG=webrtc:6359
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a
> Cr-Commit-Position: refs/heads/master@{#14356}
TBR=sakal@webrtc.org ,kthelgason@webrtc.org ,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6359
Review-Url: https://codereview.webrtc.org/2358133003
Cr-Commit-Position: refs/heads/master@{#14358}
2016-09-22 17:15:43 +00:00
d3af58bdab
Rename AppRTCDemo on Android and iOS to AppRTCMobile
...
The purpose is to make it clearer it is a mobile application.
BUG=webrtc:6359
NOPRESUBMIT=true
Review-Url: https://codereview.webrtc.org/2343403002
Cr-Commit-Position: refs/heads/master@{#14356}
2016-09-22 16:12:38 +00:00
1c6d3f7eae
Add new Camera2Enumerator.isSupported with Context parameter.
...
The old method is marked deprecated and will be removed soon. The new
method checks if all cameras on the device support better than legacy
implementation of the camera2 API.
BUG=webrtc:6390
Review-Url: https://codereview.webrtc.org/2354883002
Cr-Commit-Position: refs/heads/master@{#14350}
2016-09-22 12:52:13 +00:00
d3235f0cd9
Re-order and remove unused Java imports.
...
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/2203723002 .
Cr-Commit-Position: refs/heads/master@{#13608}
2016-08-02 13:44:19 +00:00
0e4bffbed0
Add an option to enable level control to Android AppRTC Demo.
...
BUG=webrtc:6152
R=magjed@webrtc.org
Review URL: https://codereview.webrtc.org/2193753002 .
Cr-Commit-Position: refs/heads/master@{#13572}
2016-07-29 12:08:26 +00:00
2c3f46ec1a
Add an option to disable built-in AGC/NS to AppRTC Demo.
...
R=henrika@webrtc.org
Review-Url: https://codereview.webrtc.org/2184653002
Cr-Commit-Position: refs/heads/master@{#13530}
2016-07-26 13:03:12 +00:00
b224d80166
Camera2 in AppRTC Android Demo.
...
Add an option to use Camera2 implemantion of CameraVideoCapturer in
AppRTC Android Demo. It is enabled by default.
BUG=webrtc:5519
Review-Url: https://codereview.webrtc.org/2077663003
Cr-Commit-Position: refs/heads/master@{#13391}
2016-07-06 07:58:35 +00:00
c00687ff5d
Add an option to disable built-in AEC to AppRTC Android Demo
...
BUG=webrtc:5923
Review-Url: https://codereview.webrtc.org/2002093002
Cr-Commit-Position: refs/heads/master@{#12885}
2016-05-25 07:09:50 +00:00
f8312cb45a
Convert LooperExecutorTest in AppRTC Demo into JUnit test
...
LooperExecutorTest now uses Robolectric instead of being instrumentation
test. This allows the test to be run faster and easier.
Review-Url: https://codereview.webrtc.org/1989813002
Cr-Commit-Position: refs/heads/master@{#12825}
2016-05-20 10:56:54 +00:00
7cf11476b9
Replace LooperExecutor with built-in class in Android AppRTC Demo
...
LooperExecutor is only truly needed in WebSocketChannelClient because of
WebSocketClient from autobanh requiring thread to have a looper. So
LooperExecutor was left there but replaced everywhere else with built-in
singleThreadExecutor/singleThreadScheduledExecutor.
Motivation behind this change is that built-in class behaves better
under testing environment and doesn't require hacky
RobolectricLooperExecutor.
Review-Url: https://codereview.webrtc.org/1992213002
Cr-Commit-Position: refs/heads/master@{#12823}
2016-05-20 09:41:08 +00:00
aa551e66a2
Add test annotation to PeerConnectionClientTest.testLoopbackVp9DecodeToTexture test.
...
Adding the last test, which was missed in
https://codereview.webrtc.org/1962533002/
TBR=phoglund@webrtc.org
Review URL: https://codereview.webrtc.org/1961113002 .
Cr-Commit-Position: refs/heads/master@{#12666}
2016-05-09 17:15:24 +00:00
85d5108b0b
Add test annotation to PeerConnectionClientTest.testLoopbackVp9 test.
...
Test annotations were added to all tests but
PeerConnectionClientTest.testLoopbackVp9 in
https://codereview.webrtc.org/1876233002 .
Recent changes in the Chromium toolchain now makes
the test fail if annotations are missing.
TBR=phoglund@webrtc.org
Review URL: https://codereview.webrtc.org/1962533002 .
Cr-Commit-Position: refs/heads/master@{#12658}
2016-05-08 19:59:08 +00:00
9c4fadc199
Add test annotations to AppRTCDemoTest.
...
After rolling in https://codereview.webrtc.org/1847963004 the AppRTCDemoTest
started running 0 tests due to https://crbug.com/601464 . Adding test annotations
makes the tests being executed again.
BUG=chromium:601464
NOTRY=True
Review URL: https://codereview.webrtc.org/1876233002
Cr-Commit-Position: refs/heads/master@{#12325}
2016-04-12 04:27:40 +00:00
7fb69db670
Reland the CL to remove candidates when doing continual gathering
...
When doing candidate re-gathering in the same ICE generation, signal the remote side to remove its remote candidates.
Fixed the pure virtual method in jsep.h
BUG=
R=glaznev@webrtc.org , pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1788703003 .
Cr-Commit-Position: refs/heads/master@{#11985}
2016-03-14 18:59:34 +00:00
6f59a4fc4f
Revert of Remove candidates when doing continual gathering (patchset #15 id:560001 of https://codereview.webrtc.org/1648813004/ )
...
Reason for revert:
Breaks the build. Suggest we reland with a default implementation of the new method, update Chrome, land a change that changes |{}| -> |= 0;|
Here's the error:
FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/content/renderer/media/webrtc/test_support_content.mock_peer_connection_dependency_factory.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=262839-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DOSX -DWEBRTC_MAC -DWEBRTC_POSIX -DXML_STATIC -DWEBRTC_CHROMIUM_BUILD -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -I../../third_party/khronos -I../../gpu -I../../skia/config -Igen/angle -I../../third_party/WebKit/Source -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../skia/ext -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -Igen/ui/resources -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -I../../third_party/WebKit -I../../ipc -I../../third_party/opus/src/include -I../../third_party/WebKit -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/libwebp -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/iccjpeg -I../../third_party/libjpeg_turbo -I../../v8/include -I../../third_party/webrtc_overrides -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../third_party -I../../third_party/expat/files/lib -I../../third_party/libvpx/source/libvpx -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O2 -gdwarf-2 -fvisibility=hidden -Werror -mmacosx-version-min=10.6 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/Mac_Builder/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -fcolor-diagnostics -fno-strict-aliasing -c ../../content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc -o obj/content/renderer/media/webrtc/test_support_content.mock_peer_connection_dependency_factory.o
../../content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc:404:14: error: allocating an object of abstract class type 'content::MockSessionDescription'
return new MockSessionDescription(type, sdp);
^
../../third_party/webrtc/api/jsep.h💯 18: note: unimplemented pure virtual method 'RemoveCandidates' in 'MockSessionDescription'
virtual size_t RemoveCandidates(
^
1 error generated.
ninja: build stopped: subcommand failed.
Original issue's description:
> When doing candidate re-gathering in the same generation, Remove the existing local candidate on the same network
> and signaling the remote side to remove its remote candidate by setting the candidate priority to 0.
>
> BUG=
>
> Committed: https://crrev.com/84430da6817ce69c53bfad088be5c9df8b420f01
> Cr-Commit-Position: refs/heads/master@{#11958}
TBR=pthatcher@webrtc.org ,deadbeef@webrtc.org ,glaznev@webrtc.org ,honghaiz@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.webrtc.org/1785613011
Cr-Commit-Position: refs/heads/master@{#11960}
2016-03-11 22:05:15 +00:00
84430da681
When doing candidate re-gathering in the same generation, Remove the existing local candidate on the same network
...
and signaling the remote side to remove its remote candidate by setting the candidate priority to 0.
BUG=
Review URL: https://codereview.webrtc.org/1648813004
Cr-Commit-Position: refs/heads/master@{#11958}
2016-03-11 21:28:12 +00:00
6a4a03c59c
Add an option to soft reset HW decoder.
...
Soft reset can be used when input frame resolution changes
to avoid re creating MediaCodec instance.
Instead MediaCodec is flushed and some variables are reset.
R=pbos@webrtc.org , perkj@webrtc.org
Review URL: https://codereview.webrtc.org/1732533002 .
Cr-Commit-Position: refs/heads/master@{#11878}
2016-03-04 22:11:02 +00:00