2072b87261
Reland "[Battery]: Delay start of TaskQueuePacedSender." Take 2
...
This is a reland of 89cb65ed663a9000b9f7c90a78039bd85731e9ae
... and f28aade91dcc2cb8f590dc1379ac7ab5c1981909
Reason for revert: crashes due to uninitialized pacing_bitrate_
crbug.com/1190547
Apparently pacer() is sometimes being used before EnsureStarted()
Fix: Instead of delaying first call to SetPacingRates(),
this CL no-ops MaybeProcessPackets() until EnsureStarted()
is called for the first time.
Original change's description:
> [Battery]: Delay start of TaskQueuePacedSender.
>
> To avoid unnecessary repeating tasks, TaskQueuePacedSender is started
> only upon RtpTransportControllerSend::EnsureStarted().
>
> More specifically, the repeating task happens in
> TaskQueuePacedSender::MaybeProcessPackets() every 500ms, using a self
> task_queue_.PostDelayedTask().
>
> Bug: chromium:1152887
> Change-Id: I72c96d2c4b491d5edb45a30b210b3797165cbf48
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208560
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#33421}
Bug: chromium:1152887
Change-Id: I9aba4882a64bbee7d97ace9059dea8a24c144f93
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212880
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
Cr-Commit-Position: refs/heads/master@{#33554}
2021-03-24 18:46:51 +00:00
9054aa8904
Update WebRTC code version (2021-03-24T04:02:05).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Iabedc63b5ae56b3d1ae18e18f0dc33bb4aac8e6b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212924
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33546}
2021-03-24 05:54:43 +00:00
f7b1b95f11
Add RTCRemoteOutboundRtpStreamStats for audio streams
...
Changes:
- adding the `RTCRemoteOutboundRtpStreamStats` dictionary (see [1])
- collection of remote outbound stats (only for audio streams)
- adding `remote_id` to the inbound stats and set with the ID of the
corresponding remote outbound stats only if the latter are available
- unit tests
[1] https://www.w3.org/TR/webrtc-stats/#dom-rtcremoteoutboundrtpstreamstats
Tested: verified from chrome://webrtc-internals during an appr.tc call
Bug: webrtc:12529
Change-Id: Ide91dc04a3c387ba439618a9c6b64a95994a1940
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211042
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33545}
2021-03-23 18:44:12 +00:00
e2ac591c0d
Update WebRTC code version (2021-03-23T04:03:37).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I5ce88d419a3f5d7c930185746a2b82fbd0d4ce2d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212844
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33533}
2021-03-23 06:02:50 +00:00
464bcd4502
Revert "Reland "[Battery]: Delay start of TaskQueuePacedSender.""
...
This reverts commit dd4d5e36c6205457add1fd9df9061ca60d315fe7.
Reason for revert: crashes due to uninitialized pacing_bitrate_
crbug.com/1190547
Original change's description:
> Reland "[Battery]: Delay start of TaskQueuePacedSender."
>
> This is a reland of 89cb65ed663a9000b9f7c90a78039bd85731e9ae
> Reason for revert: failing trybots: https://ci.chromium.org/ui/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win8%20Tester/7757/overview
>
> Original change's description:
> > [Battery]: Delay start of TaskQueuePacedSender.
> >
> > To avoid unnecessary repeating tasks, TaskQueuePacedSender is started
> > only upon RtpTransportControllerSend::EnsureStarted().
> >
> > More specifically, the repeating task happens in
> > TaskQueuePacedSender::MaybeProcessPackets() every 500ms, using a self
> > task_queue_.PostDelayedTask().
> >
> > Bug: chromium:1152887
> > Change-Id: I72c96d2c4b491d5edb45a30b210b3797165cbf48
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208560
> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
> > Reviewed-by: Henrik Boström <hbos@webrtc.org >
> > Reviewed-by: Erik Språng <sprang@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#33421}
>
> Bug: chromium:1152887
> Change-Id: Ia4fae13294472160e2dff40738b6fd245700beeb
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211920
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
> Cr-Commit-Position: refs/heads/master@{#33491}
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1152887, chromium:1190547
Change-Id: I8ce3ba2fee8a38f918e20db953ce1c4b923cdd18
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212700
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33528}
2021-03-22 14:46:06 +00:00
2bab0efee4
Update WebRTC code version (2021-03-20T04:03:21).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I0fc6a3f7ebfa2c97c077038808032d3aceaf1c75
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212569
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33511}
2021-03-20 05:38:27 +00:00
ef7d61ed1c
Update WebRTC code version (2021-03-19T04:04:06).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I350e7a652c3ed3170f4f69536d58e6275c148d14
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212563
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33508}
2021-03-19 06:09:10 +00:00
426d679886
Update WebRTC code version (2021-03-18T04:03:50).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ia0ef229c0c85d5c3e98b0e3bd6cec5a8223def9e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212402
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33497}
2021-03-18 05:57:37 +00:00
dd4d5e36c6
Reland "[Battery]: Delay start of TaskQueuePacedSender."
...
This is a reland of 89cb65ed663a9000b9f7c90a78039bd85731e9ae
Reason for revert: failing trybots: https://ci.chromium.org/ui/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win8%20Tester/7757/overview
Original change's description:
> [Battery]: Delay start of TaskQueuePacedSender.
>
> To avoid unnecessary repeating tasks, TaskQueuePacedSender is started
> only upon RtpTransportControllerSend::EnsureStarted().
>
> More specifically, the repeating task happens in
> TaskQueuePacedSender::MaybeProcessPackets() every 500ms, using a self
> task_queue_.PostDelayedTask().
>
> Bug: chromium:1152887
> Change-Id: I72c96d2c4b491d5edb45a30b210b3797165cbf48
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208560
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#33421}
Bug: chromium:1152887
Change-Id: Ia4fae13294472160e2dff40738b6fd245700beeb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211920
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
Cr-Commit-Position: refs/heads/master@{#33491}
2021-03-17 16:10:02 +00:00
1827483784
Update WebRTC code version (2021-03-17T04:02:27).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ieb3a5ba026c315fd9259e99559919269c8ab8405
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212200
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33486}
2021-03-17 06:06:51 +00:00
0855302391
Update WebRTC code version (2021-03-16T04:03:07).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ib8280d5c7367d2a391ccbb8be865ddffa0d98992
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212047
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33470}
2021-03-16 05:57:33 +00:00
13118a7c0b
Update WebRTC code version (2021-03-15T04:05:00).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Id2d9c40b49760f048b9a862fca8c881ee45c09c0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211828
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33455}
2021-03-15 06:09:07 +00:00
cf70793c5f
Update WebRTC code version (2021-03-12T04:03:49).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Iab3ca0106ad3a58e4097ae85855ddb2887771d15
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211601
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33443}
2021-03-12 06:03:55 +00:00
54dbc3be3f
Revert "[Battery]: Delay start of TaskQueuePacedSender."
...
This reverts commit 89cb65ed663a9000b9f7c90a78039bd85731e9ae.
Reason for revert: Breaks downstream project
Original change's description:
> [Battery]: Delay start of TaskQueuePacedSender.
>
> To avoid unnecessary repeating tasks, TaskQueuePacedSender is started
> only upon RtpTransportControllerSend::EnsureStarted().
>
> More specifically, the repeating task happens in
> TaskQueuePacedSender::MaybeProcessPackets() every 500ms, using a self
> task_queue_.PostDelayedTask().
>
> Bug: chromium:1152887
> Change-Id: I72c96d2c4b491d5edb45a30b210b3797165cbf48
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208560
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#33421}
Bug: chromium:1152887
Change-Id: I781d3bf614d5d0c03f292c0e478f24ede91624bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211345
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33430}
2021-03-11 09:01:01 +00:00
89cb65ed66
[Battery]: Delay start of TaskQueuePacedSender.
...
To avoid unnecessary repeating tasks, TaskQueuePacedSender is started
only upon RtpTransportControllerSend::EnsureStarted().
More specifically, the repeating task happens in
TaskQueuePacedSender::MaybeProcessPackets() every 500ms, using a self
task_queue_.PostDelayedTask().
Bug: chromium:1152887
Change-Id: I72c96d2c4b491d5edb45a30b210b3797165cbf48
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208560
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33421}
2021-03-10 16:03:28 +00:00
68ef4e5b00
Update WebRTC code version (2021-03-10T04:02:37).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I2418fb1a561d64d8a57c36f69fe2080f19e243e7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211181
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33411}
2021-03-10 06:10:44 +00:00
668dbf66ce
[Stats] Populate "frames" stats for video source.
...
Spec: https://www.w3.org/TR/webrtc-stats/#dom-rtcvideosourcestats-frames
Wiring up the "frames" stats with the cumulative fps counter on the video source.
Tests:
./out/Default/peerconnection_unittests
./out/Default/video_engine_tests
Bug: webrtc:12499
Change-Id: I4103f56ed04cb464f5f7e70fbf2d77c25a867a68
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208782
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33404}
2021-03-09 08:54:38 +00:00
5ab9b32ee6
Update WebRTC code version (2021-03-09T04:03:43).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I8915d8f307b09348e8879027d47a2a546103db54
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/210920
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33403}
2021-03-09 06:13:31 +00:00
456a2642d3
Update WebRTC code version (2021-03-08T04:01:44).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ia9c79e506989ca773c47399b3f1eca56875b096c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/210640
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33395}
2021-03-08 05:59:19 +00:00
aedb0f0c66
Update WebRTC code version (2021-03-07T04:02:41).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I1f4e7859d1fcca9154840ad72bac68e152456ef9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/210380
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33394}
2021-03-07 05:50:46 +00:00
77f97ec066
Update WebRTC code version (2021-03-06T04:02:56).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ied0c453f05c0d2d172661b712d63660ce1227988
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/210120
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33392}
2021-03-06 05:40:47 +00:00
1413e2db4c
Update WebRTC code version (2021-03-05T04:03:29).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I8fbcbf192da90593ad03fc8da0392957d33753ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/209861
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33387}
2021-03-05 05:57:29 +00:00
d744c5a9e4
Update WebRTC code version (2021-03-04T04:02:19).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ie58acd9eee4556c17fd62cb65f146030e2724ab9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/209580
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33379}
2021-03-04 05:55:43 +00:00
1e2da374b3
Update WebRTC code version (2021-02-28T04:02:30).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: If3304144dbf58dec0babaf873a5858f40539b908
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/209020
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33353}
2021-02-28 04:56:14 +00:00
ac615b6766
Update WebRTC code version (2021-02-27T04:03:14).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: If05da5731bedf3310c0748de02ade5c8597e94d3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208920
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33352}
2021-02-27 06:02:56 +00:00
c96aa30c13
Minor refactoring of RtpVideoSender
...
Bug: None
Change-Id: I7cc16d4e435974090310bd3a7cea9eaf0586be8c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208761
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33351}
2021-02-26 13:20:52 +00:00
1124ed1ab2
Communicate encoder resolutions via rtc::VideoSinkWants.
...
This will allow us to optimize the internal buffers of
webrtc::VideoFrame for the resolution(s) that we actually want to
encode.
Bug: webrtc:12469, chromium:1157072
Change-Id: If378b52b5e35aa9a9800c1f7dfe189437ce43253
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208540
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33342}
2021-02-25 11:10:55 +00:00
49b2792b70
Update WebRTC code version (2021-02-25T04:03:13).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I8cd8299f20e4f16b5ba9ee540764a1a8720af5cd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208680
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33339}
2021-02-25 06:36:17 +00:00
61d1773c03
Remove deactivated RTP modules from PacketRouter map.
...
Apart from making the map smaller, a purpose of this is guaranteeing
that if a module has been deactived it will not receive new packets
from the pacer, which will be needed for deferred sequencing.
Bug: webrtc:11340
Change-Id: I171a13413c5b8d3fa569c2d56bd9a54bff7c7976
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208542
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33335}
2021-02-24 20:09:13 +00:00
5fec23cdb5
Update WebRTC code version (2021-02-24T04:02:50).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ifaf8855bd61278071f7f7044ff6fbbcb9642d382
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208620
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33326}
2021-02-24 05:36:09 +00:00
e5caa9e2d3
Update WebRTC code version (2021-02-23T04:03:09).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I85d36dcb263d4d7be8fbf66f583bbd01806a1687
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208500
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33321}
2021-02-23 06:41:22 +00:00
1dd94a023a
Use pixels from single active stream if set in CanDecreaseResolutionTo
...
Simulcast with one active stream:
Use pixels from single active stream if set (instead of input stream which could be larger) to avoid going below the min_pixel_per_frame limit when downgrading resolution.
Bug: none
Change-Id: I65acb12cc53e46f726ccb5bfab8ce08ff0c4cf78
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208101
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33309}
2021-02-22 10:25:32 +00:00
a21ea29ff0
Update WebRTC code version (2021-02-20T04:03:37).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I9c606d5c64699ce34e4dee44241341e3efa37bf9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208380
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33307}
2021-02-20 05:55:48 +00:00
f3dc47e2c4
Ending a statement with a semicolon
...
Bug: None
Change-Id: If7b2e0197e61d34daab68e8fcdb8b43678c1fe31
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205940
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33304}
2021-02-19 16:53:54 +00:00
753c76a705
Update WebRTC code version (2021-02-19T04:02:42).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I030dbe6eb4b064404e3c670171897544717891ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208320
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33298}
2021-02-19 06:38:13 +00:00
9915db3453
Move Call's histogram reporting code into destructor.
...
This is for better compatibility with thread annotations and how the
histogram data is collected. In the dtor we can make assumptions about
the state of the object, but that context is lost in member methods
even though they're only called from the destructor (and therefore
thread annotations can't "know" that the object is being destructed
inside those calls).
Bug: webrtc:11993
Change-Id: I8b698cc3340fb0db49430da6f7a9b9a02cabf0c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208200
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33295}
2021-02-18 09:58:54 +00:00
86d37256c9
Update WebRTC code version (2021-02-18T04:03:24).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I4d272dc98a377b1099863ca8588e40d444043298
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208180
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33292}
2021-02-18 05:59:14 +00:00
46e5a2f3f4
Update WebRTC code version (2021-02-17T04:02:09).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I0d3464ede38efac65eae1ac5a05d1c3866e29f6e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207980
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33284}
2021-02-17 05:45:27 +00:00
d1bbec3120
Update WebRTC code version (2021-02-16T04:03:42).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I7f6a4b16064f65553e7755f464c430a19a7a6e9d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207806
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33274}
2021-02-16 05:16:44 +00:00
8408c9938c
Remove 'secondary sink' concept from webrtc::VideoReceiveStream.
...
In practice, support for multiple sinks is not needed and supporting
the API that allows for dynamically adding/removing sinks at runtime,
adds to the complexity of the implementation.
This CL removes that Add/Remove methods for secondary sinks as well
as vectors of callback pointers (which were either of size 0 or 1).
Instead, an optional callback pointer is added to the config struct
for VideoReceiveStream, that an implementation can consider to be
const and there's not a need to do thread synchronization for that
pointer for every network packet.
As part of webrtc:11993, this simplifies the work towards keeping
the processing of network packets on the network thread. The secondary
sinks, currently operate on the worker thread.
Bug: webrtc:11993
Change-Id: I10c473e57d3809527a1b689f4352e903a4c78168
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/207421
Commit-Queue: Tommi <tommi@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33272}
2021-02-15 18:08:17 +00:00
cc4743795b
[Battery]: Delay start of CallStats.
...
To avoid unnecessary repeating tasks, CallStats' timer is started only
upon Call::EnsureStarted().
Bug: chromium:1152887
Change-Id: I1015315f42127bf510affc3d22c930b20eac8bba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206880
Commit-Queue: Tommi <tommi@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33232}
2021-02-11 12:00:05 +00:00
d15a575ec3
Use SequenceChecker from public API
...
Bug: webrtc:12419
Change-Id: I00cca16a0ec70246156ba00b97aa7ae5ccbf5364
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205323
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33220}
2021-02-10 15:04:55 +00:00
e44f24e199
Handle longer AudioSendStream::Config strings
...
Switch to using StringBuilder which suports a variable sized
buffer.
Bug: webrtc:12455
Change-Id: I956d2385e6a26ce6fbb73869506d9d79de786a2e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206473
Commit-Queue: Evan Shrubsole <eshr@google.com >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33215}
2021-02-10 10:53:29 +00:00
b609718b87
Update WebRTC code version (2021-02-09T04:03:22).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: If6d3a838596bb69bd4e96791bb3e6279075edb07
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206447
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33199}
2021-02-09 05:57:33 +00:00
69c0118c51
Update WebRTC code version (2021-02-08T04:03:13).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I02005a02b3486f5c0550e3ad3a15a308a47aa7c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206388
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33186}
2021-02-08 05:18:08 +00:00
c3c63c8cea
Update WebRTC code version (2021-02-07T04:04:50).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I4497e145863a392283b7a4b1a78af8e2046fdda3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206343
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33185}
2021-02-07 05:17:56 +00:00
9554a7b641
Account for extra capacity rtx packet might need
...
When calculating maximum allowed size for a media packet.
In particular take in account that rtx packet might need to
include mid and repaired-rsid extensions when media packet can omit them.
Bug: webrtc:11031
Change-Id: I3e7bc36437c23e0330316588d2a46978407c8c45
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206060
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33184}
2021-02-06 21:34:08 +00:00
129caca888
Update WebRTC code version (2021-02-06T04:03:11).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I47ceb533ef8d54a3b69fbca9b491fb6fe5384849
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/206160
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33182}
2021-02-06 06:06:22 +00:00
b6d87ddd55
Update WebRTC code version (2021-02-05T04:04:12).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ied96d66fca07187898064a59e64d9b4f4ae3fb26
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205921
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33171}
2021-02-05 05:57:54 +00:00
ad3258647e
Reland "Prepare to avoid hops to worker for network events."
...
This is a reland of d48a2b14e7545d0a0778df753e062075c044e2a1
The diff of the reland (what caused the tsan error) can be seen
by diffing patch sets 2 and 3. Essentially I missed keeping the calls
to the transport controller on the worker thread. Note to self to add
thread/sequence checks to that code so that we won't have to rely on
tsan :)
Original change's description:
> Prepare to avoid hops to worker for network events.
>
> This moves the thread hop for network events, from BaseChannel and
> into Call. The reason for this is to move the control over those hops
> (including DeliverPacket[Async]) into the same class where the state
> is held that is affected by those hops. Once that's done, we can start
> moving the relevant network state over to the network thread and
> eventually remove the hops.
>
> I'm also adding several TODOs for tracking future steps and give
> developers a heads up.
>
> Bug: webrtc:11993
> Change-Id: Ice7ee3b5b6893532df52039324293979196d341d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/204800
> Commit-Queue: Tommi <tommi@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#33138}
Bug: webrtc:11993, webrtc:12430
Change-Id: I4fccaa418d22c2087a55bbb3ddbb25fac3b4dfcc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205580
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33153}
2021-02-03 17:44:47 +00:00
