2baef3509f
Revert "Move api/rtp_headers.h to its own build target."
...
This reverts commit a67050debcb5a3461a452a7928d7aaea1562747e.
Reason for revert: breaks downstream projects
Original change's description:
> Move api/rtp_headers.h to its own build target.
>
> Reduces dependencies on the libjingle_peerconnection_api target from
> lower-level code.
>
> Bug: None
> Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27213}
TBR=danilchap@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
Change-Id: I8cccaa8be1700ca8db141db7252eb6ce588ba2e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128645
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27215}
2019-03-20 16:47:30 +00:00
a67050debc
Move api/rtp_headers.h to its own build target.
...
Reduces dependencies on the libjingle_peerconnection_api target from
lower-level code.
Bug: None
Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27213}
2019-03-20 16:00:49 +00:00
471783fc87
Remove rtc::QueuedTask alias, use webrtc::QueuedTask directly
...
Use absl::WrapUnique/absl::make_unique to create the queued tasks.
Bug: webrtc:10191
Change-Id: I8f47a60cb326b0fc361c7f0e338b25373d39937c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126525
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27063}
2019-03-11 16:49:21 +00:00
fc52b912a3
Implicitly suppress //build/config/clang:find_bad_constructs.
...
Since there is no way to enable/disable these diagnostics at runtime,
this CL moves the suppression into the rtc_* templates in order to
remove the need to explicitly add the snippet of code needed to
suppress it (currently copy/pasted in 144 locations).
The diagnostic that causes the most problems is the one about "complex
class/struct explicit ctor/dtor" [1] because WebRTC doesn't find
it useful enough.
Other diagnostics are good (for example the one that warns about
using "virtual" instead of "override", but that will be covered by
this clang-tidy check [2]) while others are Chromium related so
they have never triggered.
[1] - https://cs.chromium.org/chromium/src/tools/clang/plugins/FindBadConstructsConsumer.cpp?l=147-167&rcl=b4bebe1aa15dba7ca5fcc6456a81a55665327c3a
[2] - https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html
Bug: webrtc:163
Change-Id: Icbf27efa5b369100a31e6a32df1a0913729b3b34
Reviewed-on: https://webrtc-review.googlesource.com/c/125088
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26918}
2019-03-01 10:18:17 +00:00
b8a4d688f9
Allow injection of task queue factory in RtcEventLog.
...
Bug: webrtc:10365
Change-Id: I48dcaaa7cecf8a201a30b81f23056a4d3a72c5a4
Reviewed-on: https://webrtc-review.googlesource.com/c/124825
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26906}
2019-02-28 16:59:54 +00:00
08f6a6c672
Import proto_library.gni when rtc_enable_protobuf is true
...
Import proto_library.gni when rtc_enable_protobuf is true instead of when
build_with_mozilla is false.
Makes it maybe easier to reason about the intention (e.g. intention is to not
compile any protobuf in, hence flag rtc_enable_protobuf)
The build file could not work if build_with_mozilla = true but
rtc_enable_protobuf = true.
Bug: webrtc:10338
Change-Id: I26e5983bd1519aa46c308b11796d518de5ef7597
Reviewed-on: https://webrtc-review.googlesource.com/c/123763
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26868}
2019-02-27 09:56:42 +00:00
8aa00f0371
Add missing absl/memory/memory.h to rtc_event_generic_ack_received.cc
...
absl/memory/memory.h needs to be included for absl::WrapUnique on the
C++17 mode build, as absl/types/optional.h has a conditional include of
memory.h.
Tbr: terelius@webrtc.org
Bug: chromium:752720
Change-Id: I7bdfb200f29ac8ec11f0b102304b7788595e7eb9
Reviewed-on: https://webrtc-review.googlesource.com/c/123360
Commit-Queue: Taiju Tsuiki <tzik@chromium.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26815}
2019-02-22 11:14:38 +00:00
5e2aad1c95
Support GenericPacketReceived/Sent/AckReceived event logs.
...
This change does not include receive_timestamps for ACKs, because there is 1 problem.
That problem will be resolved in a separate change.
I am getting receive_timestamp errors that have to do with delta compression with optional fields.
Two failure modes that I noticed:
1) the base event does not have the timestamp: it crashes with length validation
# Check failed: base <= MaxUnsignedValueOfBitWidth(params_.value_width_bits()) (1820716 vs. 131071)
2) all events are null, it crashes with assert that X events were expected, but no events were deserialized.
Bug: webrtc:9719
Change-Id: I5d1bbb95dfd15ca7321667aad5e4d89c085e9c06
Reviewed-on: https://webrtc-review.googlesource.com/c/122360
Commit-Queue: Peter Slatala <psla@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26668}
2019-02-13 17:06:22 +00:00
f6adac87b4
Add rtc event generic packet sent and received.
...
Bug: webrtc:9719
Change-Id: I2f692d9c1b33ac390975a9e695c7652cdc1b1e6e
Reviewed-on: https://webrtc-review.googlesource.com/c/121680
Commit-Queue: Peter Slatala <psla@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Bjorn Mellem <mellem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26616}
2019-02-08 19:13:57 +00:00
f380284035
(7) Rename files to snake_case: remove forwarding headers
...
Bug: webrtc:10159
Change-Id: I2ba899e0283b953538c7941c8790213e36d7c70e
Reviewed-on: https://webrtc-review.googlesource.com/c/118561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26417}
2019-01-26 00:33:46 +00:00
d970807e0c
Remove rtc_base/scoped_ref_ptr.h.
...
The type rtc::scoped_refptr<T> is now part of api/. Please include it from
api/scoped_refptr.h.
More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o .
Bug: webrtc:9887, webrtc:8205
No-Try: True
Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf
Reviewed-on: https://webrtc-review.googlesource.com/c/119041
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:29:58 +00:00
7e4341db60
Reland "Reland "Adds richer packet and ice processing to ParsedRtcEventLog.""
...
This is a reland of 6fc6a0cbb10ee0e988b47f48935b630ba41d109d
Original change's description:
> Reland "Adds richer packet and ice processing to ParsedRtcEventLog."
>
> This is a reland of 4306a25dfcaba7defe09f5d4b669736d374fe985
>
> Original change's description:
> > Adds richer packet and ice processing to ParsedRtcEventLog.
> >
> > Bug: webrtc:10170
> > Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000
> > Reviewed-on: https://webrtc-review.googlesource.com/c/116069
> > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#26268}
>
> Bug: webrtc:10170
> Change-Id: Ie523427acba02b554583223b9ef800249d8d8f2b
> Reviewed-on: https://webrtc-review.googlesource.com/c/117724
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26350}
Bug: webrtc:10170
Change-Id: I9b57ca754197822de9966ee4c93526c7f2159dfd
Reviewed-on: https://webrtc-review.googlesource.com/c/118784
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26362}
2019-01-23 10:00:01 +00:00
71b5a7df77
Revert "Reland "Adds richer packet and ice processing to ParsedRtcEventLog.""
...
This reverts commit 6fc6a0cbb10ee0e988b47f48935b630ba41d109d.
Reason for revert: Incorrect DCHECK
Original change's description:
> Reland "Adds richer packet and ice processing to ParsedRtcEventLog."
>
> This is a reland of 4306a25dfcaba7defe09f5d4b669736d374fe985
>
> Original change's description:
> > Adds richer packet and ice processing to ParsedRtcEventLog.
> >
> > Bug: webrtc:10170
> > Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000
> > Reviewed-on: https://webrtc-review.googlesource.com/c/116069
> > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#26268}
>
> Bug: webrtc:10170
> Change-Id: Ie523427acba02b554583223b9ef800249d8d8f2b
> Reviewed-on: https://webrtc-review.googlesource.com/c/117724
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26350}
TBR=terelius@webrtc.org ,srte@webrtc.org
Change-Id: I5a8ef5cf4d4dab783482ef4968b3a832b805d759
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10170
Reviewed-on: https://webrtc-review.googlesource.com/c/118783
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26351}
2019-01-22 07:39:05 +00:00
6fc6a0cbb1
Reland "Adds richer packet and ice processing to ParsedRtcEventLog."
...
This is a reland of 4306a25dfcaba7defe09f5d4b669736d374fe985
Original change's description:
> Adds richer packet and ice processing to ParsedRtcEventLog.
>
> Bug: webrtc:10170
> Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000
> Reviewed-on: https://webrtc-review.googlesource.com/c/116069
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26268}
Bug: webrtc:10170
Change-Id: Ie523427acba02b554583223b9ef800249d8d8f2b
Reviewed-on: https://webrtc-review.googlesource.com/c/117724
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26350}
2019-01-21 19:47:38 +00:00
4a7b3acfcf
Add DTLSTransport info into sender/receiver state.
...
This is in preparation for letting Chrome extract DTLSTransport
information after SLD/SRD instead of doing it on-demand.
Bug: chromium:907849
Change-Id: Iac6b174c98d3d14136e1fd25bce4a9292f6c8b41
Reviewed-on: https://webrtc-review.googlesource.com/c/116984
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26289}
2019-01-17 10:21:32 +00:00
876d1d3fed
Revert "Reland "Adds richer packet and ice processing to ParsedRtcEventLog.""
...
This reverts commit 20aae1de5c745fd62025e3464f736416c849e270.
Reason for revert: Accidental revert.
Original change's description:
> Reland "Adds richer packet and ice processing to ParsedRtcEventLog."
>
> This reverts commit 5586d7fb5717fd772463c17a4675491980c5d017.
>
> Reason for revert: <INSERT REASONING HERE>
>
> Original change's description:
> > Revert "Adds richer packet and ice processing to ParsedRtcEventLog."
> >
> > This reverts commit 4306a25dfcaba7defe09f5d4b669736d374fe985.
> >
> > Reason for revert: Breaks downstream project
> >
> > Original change's description:
> > > Adds richer packet and ice processing to ParsedRtcEventLog.
> > >
> > > Bug: webrtc:10170
> > > Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/116069
> > > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > > Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#26268}
> >
> > TBR=terelius@webrtc.org ,srte@webrtc.org
> >
> > Change-Id: Ic50fdfb6b10c26e77728b594f553bc4aac4eb0ab
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:10170
> > Reviewed-on: https://webrtc-review.googlesource.com/c/117780
> > Reviewed-by: Amit Hilbuch <amithi@webrtc.org >
> > Commit-Queue: Amit Hilbuch <amithi@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#26270}
>
> TBR=terelius@webrtc.org ,srte@webrtc.org ,amithi@webrtc.org
>
> Change-Id: I5e87fb472b91dd4b6fa177418f03a9031035ec60
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10170
> Reviewed-on: https://webrtc-review.googlesource.com/c/117721
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26274}
TBR=terelius@webrtc.org ,srte@webrtc.org ,amithi@webrtc.org
Change-Id: Ie020006b02dda628c638ba00ac519f6da2aaa090
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10170
Reviewed-on: https://webrtc-review.googlesource.com/c/117723
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26275}
2019-01-16 08:26:37 +00:00
20aae1de5c
Reland "Adds richer packet and ice processing to ParsedRtcEventLog."
...
This reverts commit 5586d7fb5717fd772463c17a4675491980c5d017.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Revert "Adds richer packet and ice processing to ParsedRtcEventLog."
>
> This reverts commit 4306a25dfcaba7defe09f5d4b669736d374fe985.
>
> Reason for revert: Breaks downstream project
>
> Original change's description:
> > Adds richer packet and ice processing to ParsedRtcEventLog.
> >
> > Bug: webrtc:10170
> > Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000
> > Reviewed-on: https://webrtc-review.googlesource.com/c/116069
> > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#26268}
>
> TBR=terelius@webrtc.org ,srte@webrtc.org
>
> Change-Id: Ic50fdfb6b10c26e77728b594f553bc4aac4eb0ab
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10170
> Reviewed-on: https://webrtc-review.googlesource.com/c/117780
> Reviewed-by: Amit Hilbuch <amithi@webrtc.org >
> Commit-Queue: Amit Hilbuch <amithi@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26270}
TBR=terelius@webrtc.org ,srte@webrtc.org ,amithi@webrtc.org
Change-Id: I5e87fb472b91dd4b6fa177418f03a9031035ec60
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10170
Reviewed-on: https://webrtc-review.googlesource.com/c/117721
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26274}
2019-01-16 07:44:23 +00:00
5586d7fb57
Revert "Adds richer packet and ice processing to ParsedRtcEventLog."
...
This reverts commit 4306a25dfcaba7defe09f5d4b669736d374fe985.
Reason for revert: Breaks downstream project
Original change's description:
> Adds richer packet and ice processing to ParsedRtcEventLog.
>
> Bug: webrtc:10170
> Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000
> Reviewed-on: https://webrtc-review.googlesource.com/c/116069
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26268}
TBR=terelius@webrtc.org ,srte@webrtc.org
Change-Id: Ic50fdfb6b10c26e77728b594f553bc4aac4eb0ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10170
Reviewed-on: https://webrtc-review.googlesource.com/c/117780
Reviewed-by: Amit Hilbuch <amithi@webrtc.org >
Commit-Queue: Amit Hilbuch <amithi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26270}
2019-01-15 21:58:02 +00:00
4306a25dfc
Adds richer packet and ice processing to ParsedRtcEventLog.
...
Bug: webrtc:10170
Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000
Reviewed-on: https://webrtc-review.googlesource.com/c/116069
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26268}
2019-01-15 16:30:38 +00:00
aec15aa810
(5) Rename files to snake_case: install forwarding headers
...
Mechanically generated with this command:
tools_webrtc/do-renames.sh install all-renames.txt && git cl format
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ic8e99f71f2da62e5c99863c6d24a8cfe311466cd
Reviewed-on: https://webrtc-review.googlesource.com/c/115682
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26227}
2019-01-11 17:13:36 +00:00
10542f21c8
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
...
Mechanically generated by running this command:
tools_webrtc/do-renames.sh update all-renames.txt && git cl format
Then manually updating:
tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833
Reviewed-on: https://webrtc-review.googlesource.com/c/115653
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 17:11:39 +00:00
b8b3c9918f
Clean up visibility and dependencies of RTC event log build targets.
...
- Remove visibility of encoder target.
- Remove unnecessary dependency on task_queue.
- Remove CreateRtcEventLogFactory() declaration from the rtc_event_log_api target
since the function is not defined in that target.
Bug: None
Change-Id: Id9edee86f358d08ea063d62bd96e9653c5b06d55
Reviewed-on: https://webrtc-review.googlesource.com/c/116060
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26215}
2019-01-11 11:05:12 +00:00
03fbf1eb4b
Simplifies RtcEventProcessor interface.
...
Bug: webrtc:10170
Change-Id: Ie643e47c55b8c35ca9b8ef31eda5b1673f19d7b3
Reviewed-on: https://webrtc-review.googlesource.com/c/116066
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26160}
2019-01-08 15:16:19 +00:00
852fe661b7
Removes deprecated alias ParsedRtcEventLogNew.
...
Bug: webrtc:10170
Change-Id: I4dca6ff7c84fd1e18348d3c7bbdbbc8b6117bffc
Reviewed-on: https://webrtc-review.googlesource.com/c/116161
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26135}
2019-01-04 13:58:52 +00:00
b290a6d767
Renames RtcEventLogParseNew to RtcEventLogParser
...
Bug: webrtc:10170
Change-Id: I9232c276229a64fa4d8321b6c996387fe130f68b
Reviewed-on: https://webrtc-review.googlesource.com/c/116064
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Minyue Li <minyue@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26128}
2019-01-03 19:39:04 +00:00
3f2b9aad4a
Moves logged event structs to separate header.
...
Bug: webrtc:10170
Change-Id: I2f6f5b9688f5064fc476063e4e64ac3f9a335b3c
Reviewed-on: https://webrtc-review.googlesource.com/c/116061
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26123}
2019-01-03 14:46:06 +00:00
e7673cf922
RtcEventLogImpl nits
...
1. Make |output_period_ms_| optional, so as to clarify where
it gets assigned a value. (I.e. the value set by the ctor
is not retained.)
2. Some extra const modifiers.
Bug: webrtc:8111
Change-Id: I9f3ad7ff763cfbc9c9385f7fd4325ba696772765
Reviewed-on: https://webrtc-review.googlesource.com/c/112588
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25877}
2018-12-03 13:50:43 +00:00
846dfdfd01
Log DTLS writable changes to RtcEventLog
...
Bug: webrtc:9972
Change-Id: I8d29dcbc200bd0aad7f4c2600459c4d344c61bbb
Reviewed-on: https://webrtc-review.googlesource.com/c/111453
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Zach Stein <zstein@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25866}
2018-12-01 01:00:28 +00:00
c64078fdc0
Log DTLS state changes to RtcEventLog
...
Bug: webrtc:9972
Change-Id: Icb2cdda87c1c42607ed06653e053699532f25e84
Reviewed-on: https://webrtc-review.googlesource.com/c/111023
Commit-Queue: Zach Stein <zstein@webrtc.org >
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25832}
2018-11-28 19:49:29 +00:00
3e70781361
[Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
...
This is a follow-up to
https://webrtc-review.googlesource.com/c/src/+/106280 .
This time the whole code base is covered.
Some files may have not been fixed though, whenever the IWYU tool
was breaking the build.
Bug: webrtc:8311
Change-Id: I2c31f552a87e887d33931d46e87b6208b1e483ef
Reviewed-on: https://webrtc-review.googlesource.com/c/111965
Commit-Queue: Yves Gerey <yvesg@google.com >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25830}
2018-11-28 18:25:07 +00:00
2222a80e79
Delete unneeded includes of common_types.h and gn deps on webrtc_common.
...
Bug: webrtc:5876
Change-Id: Iae14e5f1679067a5a5e0584ca830aee0870c8807
Reviewed-on: https://webrtc-review.googlesource.com/c/111463
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25715}
2018-11-20 16:28:39 +00:00
d474672dcd
Make rtc_event_log protos publicly visible.
...
Bug: None
Change-Id: I189f249914e0fa67826b69aacf93288aa54ac0d5
Reviewed-on: https://webrtc-review.googlesource.com/c/111254
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25689}
2018-11-19 12:25:23 +00:00
76f9954b17
Remove the old RTC event log parser.
...
The new parser provides the same functionality (with a slightly
different API) and is backwards compatible with the legacy wire format.
Downstream projects seem to have transitioned to the new parser API.
Bug: webrtc:8111
Change-Id: Icb458f0d55e0a4566c4b7b4a53cab48f0b9d6fd8
Reviewed-on: https://webrtc-review.googlesource.com/c/110782
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25635}
2018-11-14 11:35:28 +00:00
428a160dd6
Remove rtc_event_log2text
...
out/Default/protoc --decode=webrtc.rtclog.EventStream logging/rtc_event_log/rtc_event_log.proto < event_log_filename
performs a similar function.
Bug: webrtc:8111
Change-Id: I4aed302857651ec418dbc1bb05c97daf582bc83e
Reviewed-on: https://webrtc-review.googlesource.com/c/110725
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25627}
2018-11-13 18:12:27 +00:00
c7e3af1ad9
Remove rtc_event_log2stats.
...
This tool does not seem useful enough to justfy the maintenance cost.
If we want something like this in the future, then the core logic
should be added to the parser.
Bug: webrtc:8111
Change-Id: Ifc3dc9b91e85246d35d7775c68d0f2dc687516aa
Reviewed-on: https://webrtc-review.googlesource.com/c/110724
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25623}
2018-11-13 15:43:15 +00:00
0b1b5c1b2a
Hide RtcEvent members behind accessors
...
Bug: webrtc:8111
Change-Id: I3d350a6e159330aed7362162006860ac86ed7c32
Reviewed-on: https://webrtc-review.googlesource.com/c/109881
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25590}
2018-11-10 23:34:07 +00:00
d95b0a2fbd
Use delta-encoding in new WebRTC event logs
...
The new event log format makes use of delta encoding to compress
parts of the log.
Bug: webrtc:8111
Change-Id: I7bec839555323a7537dcec831d4ac1d5eb109932
Reviewed-on: https://webrtc-review.googlesource.com/c/109161
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25584}
2018-11-09 16:39:16 +00:00
69807e8871
Depend directly on destination targets.
...
Makes 'gn check' happy.
Followup to https://webrtc-review.googlesource.com/c/src/+/106820
Bug: webrtc:5876, webrtc:9855
Change-Id: I33fa2c31ba26dc10c9a9c17da0ffed255c1f4d5b
Reviewed-on: https://webrtc-review.googlesource.com/c/108760
Commit-Queue: Yves Gerey <yvesg@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25447}
2018-10-31 10:21:40 +00:00
ff43541927
Delta compression efficiency improvement for non-existent base
...
Before this CL, when we encoded a sequence with a non-existent
base, we pretended that the delta was 0, and the first delta was
based on that. However, in a sequence where the deltas are small,
but where the first element is big, that would produce
unnecessarily wide deltas. Therefore, we change the behavior in
cases where the base is non-existent, to encode the first existent
value (if any) as a varint; the delta width may then be smaller.
This CL include two piggy-backed changes:
1. Varint encoding/decoding moved to its own file (and an
additional flavor added).
2. The unit tests for delta encoding are further parameterized
with a random seed.
Bug: webrtc:8111
Change-Id: I76fff577c86d019c8334bf74b76bd35db06ff68d
Reviewed-on: https://webrtc-review.googlesource.com/c/107860
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25395}
2018-10-26 18:17:40 +00:00
c35096d975
Reland "Encode RTC event logs in new format."
...
This is a reland of ece3c228a2cbd1c1b05eee3a7f55dbb6f020acbc
Original change's description:
> Encode RTC event logs in new format.
>
> This CL adds the encoder and wires it up to the event log.
> Parser and unit tests are uploaded in a separate CL.
>
> Bug: webrtc:8111
> Change-Id: I6470003e55c2c4006cd8349a2c4bdc3f9491d869
> Reviewed-on: https://webrtc-review.googlesource.com/c/106708
> Commit-Queue: Björn Terelius <terelius@webrtc.org >
> Reviewed-by: Elad Alon <eladalon@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25333}
Bug: webrtc:8111
Change-Id: I22eeca36d6b1f7cfa1ac65347571ebe33cecc1fc
Reviewed-on: https://webrtc-review.googlesource.com/c/108082
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25382}
2018-10-26 09:20:02 +00:00
825f83b99e
Revert "Encode RTC event logs in new format."
...
This reverts commit ece3c228a2cbd1c1b05eee3a7f55dbb6f020acbc.
Reason: Breaks downstream project.
Bug: webrtc:8111
Change-Id: Ia264802b35a576d74b8a249ed742a8177e5cbe24
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/107721
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25340}
2018-10-24 13:18:03 +00:00
ece3c228a2
Encode RTC event logs in new format.
...
This CL adds the encoder and wires it up to the event log.
Parser and unit tests are uploaded in a separate CL.
Bug: webrtc:8111
Change-Id: I6470003e55c2c4006cd8349a2c4bdc3f9491d869
Reviewed-on: https://webrtc-review.googlesource.com/c/106708
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25333}
2018-10-24 12:21:43 +00:00
73f3917e89
Add support for signed deltas in FixedLengthDeltaEncoder
...
Signed deltas can yield a more efficient encoding when the encoded
sequence sometimes moves backwards.
Bug: webrtc:8111
Change-Id: Ib1a50192851214ccc3f2bd7eaf88f4be97e4beb0
Reviewed-on: https://webrtc-review.googlesource.com/c/100423
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25324}
2018-10-23 16:52:31 +00:00
cb21ffe899
Add blob-encoding support for RTC event logs
...
A blob is a string of binary information, whose length may not
necessarily be determined by looking into the string, so that
concatenating all blobs without explicitly including their lengths
as part of their encoding is not a viable option.
Bug: webrtc:8111
Change-Id: I89fdca660e89a6a71eff3ecb7b86416312b81f23
Reviewed-on: https://webrtc-review.googlesource.com/c/104201
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Yves Gerey <yvesg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25278}
2018-10-19 17:30:02 +00:00
50b1e6b760
Add fixed-size delta-encoding/decoding code for WebRTC event logs
...
Add code for delta-encoding and decoding, to be used when producing
WebRTC event logs of the new format.
This CL supports fixed-size encoding only. Also, no support for
signed deltas or optional values yet. These will be added in
subsequent CLs.
Bug: webrtc:8111
Change-Id: I531abd99fd924f4c9e692abe565bc6f66c875ad5
Reviewed-on: https://webrtc-review.googlesource.com/c/100304
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25256}
2018-10-18 13:51:05 +00:00
608298b6ae
Move RtcEventLog::CreateNull implementation near declaration.
...
having implementation and declaration in same build target helps
setting dependencies
Bug: None
Change-Id: Ibf22e9c8781def9d84ce4562d0f0eaba5abd39cf
Reviewed-on: https://webrtc-review.googlesource.com/c/106900
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25255}
2018-10-18 13:39:58 +00:00
a39a00737f
Reland "Deprecates legacy transport feedback adapter."
...
This is a reland of a5778e0d560ffb3e07637547ba8468f4762a2b3e
Original change's description:
> Deprecates legacy transport feedback adapter.
>
> Bug: webrtc:9586
> Change-Id: Ib8c9cec1eb7f3cfa90b18b4b64171fa1b06713cf
> Reviewed-on: https://webrtc-review.googlesource.com/c/105984
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25184}
TBR=terelius@webrtc.org
Bug: webrtc:9586
Change-Id: I4e2b42f71cc13d3ff92c3c11de63bde16c58439b
Reviewed-on: https://webrtc-review.googlesource.com/c/106143
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25190}
2018-10-15 20:43:39 +00:00
f714ee1f8f
Revert "Deprecates legacy transport feedback adapter."
...
This reverts commit a5778e0d560ffb3e07637547ba8468f4762a2b3e.
Reason for revert:
../../rtc_tools/event_log_visualizer/analyzer.cc(1084,3): error: use of undeclared identifier 'webrtc_cc'
webrtc_cc::TransportFeedbackAdapter transport_feedback(&clock);
Original change's description:
> Deprecates legacy transport feedback adapter.
>
> Bug: webrtc:9586
> Change-Id: Ib8c9cec1eb7f3cfa90b18b4b64171fa1b06713cf
> Reviewed-on: https://webrtc-review.googlesource.com/c/105984
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#25184}
TBR=terelius@webrtc.org ,srte@webrtc.org
Change-Id: I768149f9f4c5db740c2d5938cb3df1d54a8283d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9586
Reviewed-on: https://webrtc-review.googlesource.com/c/106141
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25185}
2018-10-15 18:24:11 +00:00
a5778e0d56
Deprecates legacy transport feedback adapter.
...
Bug: webrtc:9586
Change-Id: Ib8c9cec1eb7f3cfa90b18b4b64171fa1b06713cf
Reviewed-on: https://webrtc-review.googlesource.com/c/105984
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#25184}
2018-10-15 18:01:08 +00:00
1ac95546dd
Include optional.h in rtc_event_log_parser_new.cc
...
Bug: None
Change-Id: I5ef8227ca4763232717808aae2f6395ce66a4ed9
Reviewed-on: https://webrtc-review.googlesource.com/103160
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#24927}
2018-10-02 11:57:40 +00:00
