72859e5e15
Make RtpEncodingParameters to not reverse active flags order
...
Bug: webrtc:11319
Change-Id: If63db02d282ee622c12405f85c0fbae1ba13fcb2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168196
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30459}
2020-02-05 17:36:26 +00:00
261f792f83
Allow software fallback on lowest simulcast stream for temporal support
...
Bug: webrtc:11324
Change-Id: Ie505be0cda74c0444065d86c3727671c62bd4842
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167527
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Evan Shrubsole <eshr@google.com >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30437}
2020-01-31 16:44:47 +00:00
184ea66aed
Reland "Reland "Reland "Distinguish between send and receive codecs"""
...
This reverts commit a104ceb0ceec0f95e199e6d6704f41ec88a51fc5.
Reason for revert: Keep logic as is.
Original change's description:
> Revert "Reland "Reland "Distinguish between send and receive codecs"""
>
> This reverts commit 9bac68c0cc4444b852416396f0e0f31ea66a9cfe.
>
> Reason for revert: Breaks perf test on iOS.
>
> Original change's description:
> > Reland "Reland "Distinguish between send and receive codecs""
> >
> > This reverts commit 00a30873c415d717af8dcdf21c2df7fd4b6d1ed2.
> >
> > Reason for revert: Flaky test in Chromium fixed.
> >
> > Original change's description:
> > > Revert "Reland "Distinguish between send and receive codecs""
> > >
> > > This reverts commit 133bf2bd28596aab5c7684e0ea3da99b1fece77f.
> > >
> > > Reason for revert: Breaks Chromium import due to flaky test in Chromium.
> > >
> > > Original change's description:
> > > > Reland "Distinguish between send and receive codecs"
> > > >
> > > > This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
> > > >
> > > > Reason for revert: Fixed negotiation of send-only clients.
> > > >
> > > > Original change's description:
> > > > > Revert "Distinguish between send and receive codecs"
> > > > >
> > > > > This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
> > > > >
> > > > > Reason for revert: breaks negotiation with send-only clients
> > > > >
> > > > > (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> > > > > (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> > > > > (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
> > > > >
> > > > > Original change's description:
> > > > > > Distinguish between send and receive codecs
> > > > > >
> > > > > > Even though send and receive codecs may be the same, they might have
> > > > > > different support in HW. Distinguish between send and receive codecs
> > > > > > to be able to keep track of which codecs have HW support.
> > > > > >
> > > > > > Bug: chromium:1029737
> > > > > > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > > Cr-Commit-Position: refs/heads/master@{#30284}
> > > > >
> > > > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > > > >
> > > > > Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: chromium:1029737
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Commit-Queue: Steve Anton <steveanton@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30292}
> > > >
> > > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > > >
> > > >
> > > > Bug: chromium:1029737
> > > > Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30348}
> > >
> > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: I9f8731309749e07ce7e651e1550ecfabddb1735f
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167205
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30360}
> >
> > TBR=steveanton@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: I1cc2d83bd884f10685503a9c31288f96c935d6a3
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167206
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30367}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
> Change-Id: I0a9b0b58922ce7c558b3d31b64cc12086b2a6a55
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167364
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30373}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Bug: chromium:1029737
Change-Id: Id381cb6d8e03b0fca941e392978362af6fdab0b6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167531
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30415}
2020-01-29 18:53:54 +00:00
99d6d8115b
Adding absolute capture timestamp to AudioTrackSinkInterface.
...
Bug: webrtc:10739
Change-Id: I8c134cbe82452ac71625cd0c810c783a73f17822
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167532
Commit-Queue: Minyue Li <minyue@webrtc.org >
Reviewed-by: Chen Xing <chxg@google.com >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30408}
2020-01-29 13:46:28 +00:00
a104ceb0ce
Revert "Reland "Reland "Distinguish between send and receive codecs"""
...
This reverts commit 9bac68c0cc4444b852416396f0e0f31ea66a9cfe.
Reason for revert: Breaks perf test on iOS.
Original change's description:
> Reland "Reland "Distinguish between send and receive codecs""
>
> This reverts commit 00a30873c415d717af8dcdf21c2df7fd4b6d1ed2.
>
> Reason for revert: Flaky test in Chromium fixed.
>
> Original change's description:
> > Revert "Reland "Distinguish between send and receive codecs""
> >
> > This reverts commit 133bf2bd28596aab5c7684e0ea3da99b1fece77f.
> >
> > Reason for revert: Breaks Chromium import due to flaky test in Chromium.
> >
> > Original change's description:
> > > Reland "Distinguish between send and receive codecs"
> > >
> > > This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
> > >
> > > Reason for revert: Fixed negotiation of send-only clients.
> > >
> > > Original change's description:
> > > > Revert "Distinguish between send and receive codecs"
> > > >
> > > > This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
> > > >
> > > > Reason for revert: breaks negotiation with send-only clients
> > > >
> > > > (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> > > > (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> > > > (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
> > > >
> > > > Original change's description:
> > > > > Distinguish between send and receive codecs
> > > > >
> > > > > Even though send and receive codecs may be the same, they might have
> > > > > different support in HW. Distinguish between send and receive codecs
> > > > > to be able to keep track of which codecs have HW support.
> > > > >
> > > > > Bug: chromium:1029737
> > > > > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30284}
> > > >
> > > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > > >
> > > > Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: chromium:1029737
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Commit-Queue: Steve Anton <steveanton@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30292}
> > >
> > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > >
> > >
> > > Bug: chromium:1029737
> > > Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30348}
> >
> > TBR=steveanton@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: I9f8731309749e07ce7e651e1550ecfabddb1735f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167205
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30360}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
> Change-Id: I1cc2d83bd884f10685503a9c31288f96c935d6a3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167206
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30367}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Change-Id: I0a9b0b58922ce7c558b3d31b64cc12086b2a6a55
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167364
Commit-Queue: Johannes Kron <kron@webrtc.org >
Reviewed-by: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30373}
2020-01-24 16:44:17 +00:00
9bac68c0cc
Reland "Reland "Distinguish between send and receive codecs""
...
This reverts commit 00a30873c415d717af8dcdf21c2df7fd4b6d1ed2.
Reason for revert: Flaky test in Chromium fixed.
Original change's description:
> Revert "Reland "Distinguish between send and receive codecs""
>
> This reverts commit 133bf2bd28596aab5c7684e0ea3da99b1fece77f.
>
> Reason for revert: Breaks Chromium import due to flaky test in Chromium.
>
> Original change's description:
> > Reland "Distinguish between send and receive codecs"
> >
> > This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
> >
> > Reason for revert: Fixed negotiation of send-only clients.
> >
> > Original change's description:
> > > Revert "Distinguish between send and receive codecs"
> > >
> > > This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
> > >
> > > Reason for revert: breaks negotiation with send-only clients
> > >
> > > (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> > > (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> > > (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
> > >
> > > Original change's description:
> > > > Distinguish between send and receive codecs
> > > >
> > > > Even though send and receive codecs may be the same, they might have
> > > > different support in HW. Distinguish between send and receive codecs
> > > > to be able to keep track of which codecs have HW support.
> > > >
> > > > Bug: chromium:1029737
> > > > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30284}
> > >
> > > TBR=steveanton@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Commit-Queue: Steve Anton <steveanton@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30292}
> >
> > TBR=steveanton@webrtc.org ,kron@webrtc.org
> >
> >
> > Bug: chromium:1029737
> > Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30348}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
> Change-Id: I9f8731309749e07ce7e651e1550ecfabddb1735f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167205
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30360}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Change-Id: I1cc2d83bd884f10685503a9c31288f96c935d6a3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167206
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30367}
2020-01-23 23:02:59 +00:00
760fd52494
Replace MockAudioDeviceModule mock refcounting with real refcounting
...
Bug: webrtc:11308
Change-Id: Ic55ec2c4b45f8fc709fe1348556bdeea6202e7a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166580
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30366}
2020-01-23 19:04:58 +00:00
00a30873c4
Revert "Reland "Distinguish between send and receive codecs""
...
This reverts commit 133bf2bd28596aab5c7684e0ea3da99b1fece77f.
Reason for revert: Breaks Chromium import due to flaky test in Chromium.
Original change's description:
> Reland "Distinguish between send and receive codecs"
>
> This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
>
> Reason for revert: Fixed negotiation of send-only clients.
>
> Original change's description:
> > Revert "Distinguish between send and receive codecs"
> >
> > This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
> >
> > Reason for revert: breaks negotiation with send-only clients
> >
> > (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> > (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> > (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
> >
> > Original change's description:
> > > Distinguish between send and receive codecs
> > >
> > > Even though send and receive codecs may be the same, they might have
> > > different support in HW. Distinguish between send and receive codecs
> > > to be able to keep track of which codecs have HW support.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30284}
> >
> > TBR=steveanton@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Steve Anton <steveanton@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30292}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
>
> Bug: chromium:1029737
> Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30348}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Change-Id: I9f8731309749e07ce7e651e1550ecfabddb1735f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167205
Reviewed-by: Johannes Kron <kron@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30360}
2020-01-23 13:10:53 +00:00
897776e36c
Pass SDP video parameters to encoder.
...
Bug: webrtc:11265
Change-Id: I4f3373793de697e9d89c22ba2d9be4bfe571beea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167201
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30359}
2020-01-23 12:33:10 +00:00
133bf2bd28
Reland "Distinguish between send and receive codecs"
...
This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8.
Reason for revert: Fixed negotiation of send-only clients.
Original change's description:
> Revert "Distinguish between send and receive codecs"
>
> This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
>
> Reason for revert: breaks negotiation with send-only clients
>
> (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
> (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
> (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
>
> Original change's description:
> > Distinguish between send and receive codecs
> >
> > Even though send and receive codecs may be the same, they might have
> > different support in HW. Distinguish between send and receive codecs
> > to be able to keep track of which codecs have HW support.
> >
> > Bug: chromium:1029737
> > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30284}
>
> TBR=steveanton@webrtc.org ,kron@webrtc.org
>
> Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Steve Anton <steveanton@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30292}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Bug: chromium:1029737
Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30348}
2020-01-22 13:55:41 +00:00
1acdc748ac
Split up EncoderStreamFactory::CreateEncoderStreams in two.
...
Motivation: https://google.github.io/styleguide/cppguide.html#Write_Short_Functions
This is a pure clean up CL, that should have no functional implications.
Bug: webrtc:11297
Change-Id: I077a8b52254a936b61d1fda94e8cfc39e8cf1294
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166883
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30337}
2020-01-21 14:34:39 +00:00
43bfe0b8a6
Enforce VideoEncoderConfig.num_temporal_layers >= 1.
...
This change clarifies the semantics of this field:
unset: Depends on context.
== 0: Invalid.
== 1: No temporal layering.
>= 2: Temporal layering.
We should try to remove the wrapping optional later.
Bug: webrtc:11297
Change-Id: Id765f2dc1d31a4ba3cd424978ac6054cd60152ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166528
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30336}
2020-01-21 13:38:08 +00:00
e57b266a20
Revert "Distinguish between send and receive codecs"
...
This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d.
Reason for revert: breaks negotiation with send-only clients
(webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264]
(peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER)
(peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters.
Original change's description:
> Distinguish between send and receive codecs
>
> Even though send and receive codecs may be the same, they might have
> different support in HW. Distinguish between send and receive codecs
> to be able to keep track of which codecs have HW support.
>
> Bug: chromium:1029737
> Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30284}
TBR=steveanton@webrtc.org ,kron@webrtc.org
Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30292}
2020-01-17 02:47:23 +00:00
c0f25cf762
Distinguish between send and receive codecs
...
Even though send and receive codecs may be the same, they might have
different support in HW. Distinguish between send and receive codecs
to be able to keep track of which codecs have HW support.
Bug: chromium:1029737
Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763
Commit-Queue: Johannes Kron <kron@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30284}
2020-01-16 15:42:05 +00:00
b2b2031457
Concatenate string literals at compile time.
...
This CL was generated by running:
git ls-files | grep ".cc" | xargs perl -i -ne 'BEGIN {undef $/}; s/("[\s\n]*<<[\s\n]*")/" "/g; print;'; git cl format
After that I manually edited modules/audio_processing/gain_controller2.cc to preserve its original
formatting.
This primary benefit of this change is a small reduction in binary size.
Bug: None
Change-Id: I689fa7ba9c717c314bb167e5d592c3c4e0871e29
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165961
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30251}
2020-01-14 14:47:48 +00:00
f5ecb5f22e
Revert "Reland "Reland "Reland "Distinguish between send and receive video codecs""""
...
This reverts commit 9cad4dccc96f09d76dce3766a076052df7d75ab8.
Reason for revert: Breaks downstream tests.
Original change's description:
> Reland "Reland "Reland "Distinguish between send and receive video codecs"""
>
> This is a reland of 4e64e605894df287178c5a1b537fbe859b7d420c
>
> This CL lands all code except the code that activates the change,
> see media/engine/webrtc_video_engine.cc
> Once downstream projects are fixed, there will be a one-line change to
> activate the change to distinguish between send and receive video codecs.
>
> Original change's description:
> > Reland "Reland "Distinguish between send and receive video codecs""
> >
> > This is a reland of 77eb338ae48acb0cb1437da05d86941bb4063228
> >
> > Original change's description:
> > > Reland "Distinguish between send and receive video codecs"
> > >
> > > This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
> > >
> > > Reason for revert: Downstream test updated.
> > >
> > > Original change's description:
> > > > Revert "Reland "Distinguish between send and receive video codecs""
> > > >
> > > > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> > > >
> > > > Reason for revert: Breaks another downstream test.
> > > >
> > > > Original change's description:
> > > > > Reland "Distinguish between send and receive video codecs"
> > > > >
> > > > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > > > >
> > > > > Reason for revert: Downstream tests have been updated.
> > > > >
> > > > > Original change's description:
> > > > > > Revert "Distinguish between send and receive video codecs"
> > > > > >
> > > > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > > > >
> > > > > > Reason for revert: Breaks downstream test.
> > > > > >
> > > > > > Original change's description:
> > > > > > > Distinguish between send and receive video codecs
> > > > > > >
> > > > > > > Even though send and receive codecs are the same,
> > > > > > > they might have different support in HW.
> > > > > > > Distinguish between send and receive codecs to be able to keep
> > > > > > > track of which codecs have HW support.
> > > > > > >
> > > > > > > Bug: chromium:1029737
> > > > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > > > >
> > > > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > > > >
> > > > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > > > No-Presubmit: true
> > > > > > No-Tree-Checks: true
> > > > > > No-Try: true
> > > > > > Bug: chromium:1029737
> > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > > > >
> > > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > > >
> > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > > >
> > > > > Bug: chromium:1029737
> > > > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30078}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: chromium:1029737
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30079}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30097}
> >
> > Bug: chromium:1029737
> > Change-Id: I5912822df8169fbb3097c0f440f7924527fa950b
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162483
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30120}
>
> Bug: chromium:1029737
> Change-Id: Id4f1c6f6f0cf7b96fe93dd22d14310d286af31f3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165682
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30219}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1029737
Change-Id: I377f82866e56862f57383f96a3b96719344eef9e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165780
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30225}
2020-01-13 09:03:37 +00:00
9cad4dccc9
Reland "Reland "Reland "Distinguish between send and receive video codecs"""
...
This is a reland of 4e64e605894df287178c5a1b537fbe859b7d420c
This CL lands all code except the code that activates the change,
see media/engine/webrtc_video_engine.cc
Once downstream projects are fixed, there will be a one-line change to
activate the change to distinguish between send and receive video codecs.
Original change's description:
> Reland "Reland "Distinguish between send and receive video codecs""
>
> This is a reland of 77eb338ae48acb0cb1437da05d86941bb4063228
>
> Original change's description:
> > Reland "Distinguish between send and receive video codecs"
> >
> > This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
> >
> > Reason for revert: Downstream test updated.
> >
> > Original change's description:
> > > Revert "Reland "Distinguish between send and receive video codecs""
> > >
> > > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> > >
> > > Reason for revert: Breaks another downstream test.
> > >
> > > Original change's description:
> > > > Reland "Distinguish between send and receive video codecs"
> > > >
> > > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > > >
> > > > Reason for revert: Downstream tests have been updated.
> > > >
> > > > Original change's description:
> > > > > Revert "Distinguish between send and receive video codecs"
> > > > >
> > > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > > >
> > > > > Reason for revert: Breaks downstream test.
> > > > >
> > > > > Original change's description:
> > > > > > Distinguish between send and receive video codecs
> > > > > >
> > > > > > Even though send and receive codecs are the same,
> > > > > > they might have different support in HW.
> > > > > > Distinguish between send and receive codecs to be able to keep
> > > > > > track of which codecs have HW support.
> > > > > >
> > > > > > Bug: chromium:1029737
> > > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > > >
> > > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > > >
> > > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: chromium:1029737
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > >
> > > > Bug: chromium:1029737
> > > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30078}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30079}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:1029737
> > Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30097}
>
> Bug: chromium:1029737
> Change-Id: I5912822df8169fbb3097c0f440f7924527fa950b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162483
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30120}
Bug: chromium:1029737
Change-Id: Id4f1c6f6f0cf7b96fe93dd22d14310d286af31f3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165682
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30219}
2020-01-10 23:37:11 +00:00
27064adc34
SimulcastEncoderAdapter: In passthrough mode set correct lenght for frame_types parameter
...
If in simulcast case some streams are disabled (especially the first one), the key-frame
requests might be ignorred by e.g. libvpx vp8 encoder wrapper.
Before this CL SimulcastEncoderAdapter always passes single frame type in Encode() call.
However, if underlying encoder used simulcast, it would've expected as many frame types
as there are streams.
Bug: none
Change-Id: I7f56a6540b67273b7d3cf9fa86dc76015b92d271
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165681
Reviewed-by: Evan Shrubsole <eshr@google.com >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30210}
2020-01-10 14:16:34 +00:00
873610ca68
Fix updating degradation preference in SetRtpParameters.
...
Degradation preference could be changed before video send stream
is configured which would cause a crash.
Bug: None
Change-Id: If970e66fba0b9fdb9da789066861d919874de119
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/164463
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30141}
2020-01-03 11:16:54 +00:00
b5159fe4a7
Revert "Reland "Reland "Distinguish between send and receive video codecs"""
...
This reverts commit 4e64e605894df287178c5a1b537fbe859b7d420c.
Reason for revert: breaks a bunch of WebRtcBrowserTests on Win: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win10%20Tester/4843
Original change's description:
> Reland "Reland "Distinguish between send and receive video codecs""
>
> This is a reland of 77eb338ae48acb0cb1437da05d86941bb4063228
>
> Original change's description:
> > Reland "Distinguish between send and receive video codecs"
> >
> > This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
> >
> > Reason for revert: Downstream test updated.
> >
> > Original change's description:
> > > Revert "Reland "Distinguish between send and receive video codecs""
> > >
> > > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> > >
> > > Reason for revert: Breaks another downstream test.
> > >
> > > Original change's description:
> > > > Reland "Distinguish between send and receive video codecs"
> > > >
> > > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > > >
> > > > Reason for revert: Downstream tests have been updated.
> > > >
> > > > Original change's description:
> > > > > Revert "Distinguish between send and receive video codecs"
> > > > >
> > > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > > >
> > > > > Reason for revert: Breaks downstream test.
> > > > >
> > > > > Original change's description:
> > > > > > Distinguish between send and receive video codecs
> > > > > >
> > > > > > Even though send and receive codecs are the same,
> > > > > > they might have different support in HW.
> > > > > > Distinguish between send and receive codecs to be able to keep
> > > > > > track of which codecs have HW support.
> > > > > >
> > > > > > Bug: chromium:1029737
> > > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > > >
> > > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > > >
> > > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: chromium:1029737
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > >
> > > > Bug: chromium:1029737
> > > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30078}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30079}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:1029737
> > Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30097}
>
> Bug: chromium:1029737
> Change-Id: I5912822df8169fbb3097c0f440f7924527fa950b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162483
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30120}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
Change-Id: I709ee0eb6246aa79dde3aacfc4c47e070c4e90ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162904
Reviewed-by: Olga Sharonova <olka@webrtc.org >
Commit-Queue: Olga Sharonova <olka@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30122}
2019-12-20 13:57:12 +00:00
4e64e60589
Reland "Reland "Distinguish between send and receive video codecs""
...
This is a reland of 77eb338ae48acb0cb1437da05d86941bb4063228
Original change's description:
> Reland "Distinguish between send and receive video codecs"
>
> This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
>
> Reason for revert: Downstream test updated.
>
> Original change's description:
> > Revert "Reland "Distinguish between send and receive video codecs""
> >
> > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> >
> > Reason for revert: Breaks another downstream test.
> >
> > Original change's description:
> > > Reland "Distinguish between send and receive video codecs"
> > >
> > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > >
> > > Reason for revert: Downstream tests have been updated.
> > >
> > > Original change's description:
> > > > Revert "Distinguish between send and receive video codecs"
> > > >
> > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > >
> > > > Reason for revert: Breaks downstream test.
> > > >
> > > > Original change's description:
> > > > > Distinguish between send and receive video codecs
> > > > >
> > > > > Even though send and receive codecs are the same,
> > > > > they might have different support in HW.
> > > > > Distinguish between send and receive codecs to be able to keep
> > > > > track of which codecs have HW support.
> > > > >
> > > > > Bug: chromium:1029737
> > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: chromium:1029737
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30078}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30079}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: chromium:1029737
> Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30097}
Bug: chromium:1029737
Change-Id: I5912822df8169fbb3097c0f440f7924527fa950b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162483
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30120}
2019-12-20 11:44:42 +00:00
5cad55b240
Signal requested resolution alignment requirements from sinks to sources.
...
Bug: webrtc:11218
Change-Id: I593b0515ea389bece472234a3c4082ccc5321ea5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162400
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30113}
2019-12-19 10:39:04 +00:00
6fd58b3388
Add maxFramerate support to SimulcastEncoderAdapter
...
Bug: webrtc:11117
Change-Id: I134964e669804e1a3c5acb9b9c7ddb6c911cf610
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162203
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30107}
2019-12-17 14:08:47 +00:00
f9d92ed2c8
Revert "Reland "Distinguish between send and receive video codecs""
...
This reverts commit 77eb338ae48acb0cb1437da05d86941bb4063228.
Reason for revert: Speculative revert, as it seems to have broken webrtc-importer
Original change's description:
> Reland "Distinguish between send and receive video codecs"
>
> This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
>
> Reason for revert: Downstream test updated.
>
> Original change's description:
> > Revert "Reland "Distinguish between send and receive video codecs""
> >
> > This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
> >
> > Reason for revert: Breaks another downstream test.
> >
> > Original change's description:
> > > Reland "Distinguish between send and receive video codecs"
> > >
> > > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> > >
> > > Reason for revert: Downstream tests have been updated.
> > >
> > > Original change's description:
> > > > Revert "Distinguish between send and receive video codecs"
> > > >
> > > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > > >
> > > > Reason for revert: Breaks downstream test.
> > > >
> > > > Original change's description:
> > > > > Distinguish between send and receive video codecs
> > > > >
> > > > > Even though send and receive codecs are the same,
> > > > > they might have different support in HW.
> > > > > Distinguish between send and receive codecs to be able to keep
> > > > > track of which codecs have HW support.
> > > > >
> > > > > Bug: chromium:1029737
> > > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > > >
> > > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > > >
> > > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: chromium:1029737
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30042}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30078}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30079}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: chromium:1029737
> Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30097}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
Change-Id: I73d4fe3bb18e40a01f1b1b0c71f9dc7b85c513b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162208
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30100}
2019-12-16 15:28:41 +00:00
77eb338ae4
Reland "Distinguish between send and receive video codecs"
...
This reverts commit f2d6fe62f23f13b974d50baa9ef60426a242af03.
Reason for revert: Downstream test updated.
Original change's description:
> Revert "Reland "Distinguish between send and receive video codecs""
>
> This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
>
> Reason for revert: Breaks another downstream test.
>
> Original change's description:
> > Reland "Distinguish between send and receive video codecs"
> >
> > This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
> >
> > Reason for revert: Downstream tests have been updated.
> >
> > Original change's description:
> > > Revert "Distinguish between send and receive video codecs"
> > >
> > > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> > >
> > > Reason for revert: Breaks downstream test.
> > >
> > > Original change's description:
> > > > Distinguish between send and receive video codecs
> > > >
> > > > Even though send and receive codecs are the same,
> > > > they might have different support in HW.
> > > > Distinguish between send and receive codecs to be able to keep
> > > > track of which codecs have HW support.
> > > >
> > > > Bug: chromium:1029737
> > > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > > Cr-Commit-Position: refs/heads/master@{#30041}
> > >
> > > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> > >
> > > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: chromium:1029737
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30042}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:1029737
> > Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30078}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30079}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1029737
Change-Id: If2c3c5b5e7d86cb852a1f20f02b6ceae62b2e0c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162186
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30097}
2019-12-16 14:03:46 +00:00
f2d6fe62f2
Revert "Reland "Distinguish between send and receive video codecs""
...
This reverts commit 26e6afe93f134c844d739384784e78acc07cc145.
Reason for revert: Breaks another downstream test.
Original change's description:
> Reland "Distinguish between send and receive video codecs"
>
> This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
>
> Reason for revert: Downstream tests have been updated.
>
> Original change's description:
> > Revert "Distinguish between send and receive video codecs"
> >
> > This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
> >
> > Reason for revert: Breaks downstream test.
> >
> > Original change's description:
> > > Distinguish between send and receive video codecs
> > >
> > > Even though send and receive codecs are the same,
> > > they might have different support in HW.
> > > Distinguish between send and receive codecs to be able to keep
> > > track of which codecs have HW support.
> > >
> > > Bug: chromium:1029737
> > > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30041}
> >
> > TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
> >
> > Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1029737
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30042}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: chromium:1029737
> Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30078}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
Change-Id: Ia4971b898c9209a3736a916a1c2c48d392dfdad6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/162140
Reviewed-by: Johannes Kron <kron@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30079}
2019-12-12 22:30:25 +00:00
26e6afe93f
Reland "Distinguish between send and receive video codecs"
...
This reverts commit f22af3cca7cfe517e4126db4b7083475722c3e6d.
Reason for revert: Downstream tests have been updated.
Original change's description:
> Revert "Distinguish between send and receive video codecs"
>
> This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
>
> Reason for revert: Breaks downstream test.
>
> Original change's description:
> > Distinguish between send and receive video codecs
> >
> > Even though send and receive codecs are the same,
> > they might have different support in HW.
> > Distinguish between send and receive codecs to be able to keep
> > track of which codecs have HW support.
> >
> > Bug: chromium:1029737
> > Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> > Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> > Reviewed-by: Steve Anton <steveanton@webrtc.org >
> > Commit-Queue: Johannes Kron <kron@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30041}
>
> TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
>
> Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029737
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30042}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1029737
Change-Id: Ia70b11376b43888e2495ef21838c2d2e3c68d735
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161734
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30078}
2019-12-12 22:13:02 +00:00
977b265702
Reduce some logging at INFO level by moving log statements
...
from LS_INFO to LS_VERBOSE.
By default, unit tests run with logging at info level.
A random run today produced more than 70.000 lines of
output. This CL would reduce that by approximately 15.000.
Bug: none
Change-Id: Ie62708cebf109510a2443aa5ab5c4e645ffc6707
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161950
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30077}
2019-12-12 21:54:06 +00:00
dcb4fcc361
Execute cached video encoder switching request if encoder switching is allowed after the switch request was made.
...
Bug: webrtc:10795
Change-Id: Ib045794bf7ecec67812e1fad2ec8db987f6011df
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161943
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30067}
2019-12-11 17:16:04 +00:00
ded86c1ad8
Remove remaining settings for using legacy AEC
...
This CL removes the remaining settings for using the legacy AEC.
It also adds a missing printout of the enforce_high_pass_filtering
parameter in the ToString method.
Bug: webrtc:11165
Change-Id: I58f0861bf1c6cd24bd83f4d3e394653b2fab3d71
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161683
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Commit-Queue: Per Åhgren <peah@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30050}
2019-12-10 10:31:07 +00:00
f22af3cca7
Revert "Distinguish between send and receive video codecs"
...
This reverts commit 18314bd8d2cb27fa58e4d304bbc428e3ed1736ba.
Reason for revert: Breaks downstream test.
Original change's description:
> Distinguish between send and receive video codecs
>
> Even though send and receive codecs are the same,
> they might have different support in HW.
> Distinguish between send and receive codecs to be able to keep
> track of which codecs have HW support.
>
> Bug: chromium:1029737
> Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
> Reviewed-by: Anders Carlsson <andersc@webrtc.org >
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Commit-Queue: Johannes Kron <kron@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30041}
TBR=steveanton@webrtc.org ,andersc@webrtc.org ,kron@webrtc.org
Change-Id: I7e5807460006db613e9b3b369ec6036b88f164fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029737
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161662
Reviewed-by: Johannes Kron <kron@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30042}
2019-12-09 14:48:55 +00:00
18314bd8d2
Distinguish between send and receive video codecs
...
Even though send and receive codecs are the same,
they might have different support in HW.
Distinguish between send and receive codecs to be able to keep
track of which codecs have HW support.
Bug: chromium:1029737
Change-Id: I16a80da44c5061ca42f2aabda76e6bf0b879bf7b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161306
Reviewed-by: Anders Carlsson <andersc@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30041}
2019-12-09 13:56:55 +00:00
62ea0aaea0
Remove deprecated legacy AEC code
...
This CL removes the deprecated legacy AEC code.
Note that this CL should not be landed before the M80 release has been cut.
Bug: webrtc:11165
Change-Id: I59ee94526e62f702bb9fa9fa2d38c4e48f44753c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161238
Commit-Queue: Per Åhgren <peah@webrtc.org >
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30036}
2019-12-09 10:37:49 +00:00
33f9d2b383
Migrate WebRTC on FrameGeneratorInterface and remove FrameGenerator class
...
Bug: webrtc:10138
Change-Id: If85290581a72f81cf60181de7a7134cc9db7716e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161327
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30033}
2019-12-07 00:54:26 +00:00
907dc806c7
Reland "Add support for RtpEncodingParameters::max_framerate"
...
Perf test failure was fixed separately.
TBR=steveanton@webrtc.org ,sprang@webrtc.org ,asapersson@webrtc.org
Original change's description:
> This adds the framework support for the max_framerate parameter.
> It doesn't implement it in any encoder yet.
>
> Bug: webrtc:11117
> Change-Id: I329624cc0205c828498d3623a2e13dd3f97e1629
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160184
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Reviewed-by: Åsa Persson <asapersson@webrtc.org >
> Commit-Queue: Florent Castelli <orphis@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29907}
Bug: webrtc:11117
Change-Id: I9c1daf7887c2024c6669dc79bff89d737417458c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161445
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30030}
2019-12-06 15:11:54 +00:00
749f6604a1
Enable SSRC 0 in MediaChannel methods
...
Refactor voice engine and video engine to use default methods instead of
treating 0 as a special value.
Bug: webrtc:8694
Change-Id: I47c211c6e870cdec737d6b0d05df29a9b534a011
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158600
Reviewed-by: Markus Handell <handellm@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Saurav Das <dinosaurav@chromium.org >
Cr-Commit-Position: refs/heads/master@{#30010}
2019-12-04 23:49:04 +00:00
32565f684b
WebRtcVideoEngine: Enable encoded frame sink.
...
This change ultimately enables wiring up VideoRtpReceiver::OnGenerateKeyFrame
and OnEncodedSinkEnabled into internal::VideoReceiveStream so that encoded
frames can flow to sinks installed in VideoTrackSourceInterface.
Bug: chromium:1013590
Change-Id: I136132c210e5811547f2522ddc371d0acac90664
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161093
Commit-Queue: Markus Handell <handellm@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30001}
2019-12-04 11:15:51 +00:00
41462d58b2
Always keep abs send time extension.
...
This makes the WebRTC-KeepAbsSendTimeExtension field trial
always enabled. This means that we no longer avoid sending the
abs-send-time extension if we have negotiated sending of transport
wide sequence numbers.
The field trial WebRTC-FilterAbsSendTimeExtension is introduced to allow
reverting to the previous behavior.
Bug: webrtc:10234
Change-Id: Ifd9761d84dd1fe79af840f98ad0882a2e5adf0b0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159181
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Reviewed-by: Konrad Hofbauer <hofbauer@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29999}
2019-12-04 09:49:04 +00:00
934afc6ba1
Deprecate RtpReceiver's SetParameters method
...
This removes the SetParameters method from AudioRtpReceiver and Video
RtpReceiver, which is currently not used and is not part of the
specifications.
Bug: webrtc:11111
Change-Id: I6f67773bfef2d4b51e9ab670bde17b5fbf5f94c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159307
Reviewed-by: Patrik Höglund <phoglund@google.com >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Saurav Das <dinosaurav@chromium.org >
Cr-Commit-Position: refs/heads/master@{#29995}
2019-12-03 19:50:42 +00:00
831ce5f171
Export more symbols to fix Chromecast component build
...
When building certain Chromecast build flavors in component build mode,
there are some link errors due to symbols not being exported. This CL
fixes those issues.
TBR: kwiberg@webrtc.org
Bug: None
Change-Id: I408f0a84b8ac4610cc6b5aa6ff58248ea82c9c66
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161148
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29992}
2019-12-03 17:41:04 +00:00
269ac81a86
VideoReceiveStream: Enable encoded frame sink.
...
This change ultimately enables wiring up VideoRtpReceiver::OnGenerateKeyFrame and
OnEncodedSinkEnabled into internal::VideoReceiveStream so that encoded frames
can flow to sinks installed in VideoTrackSourceInterface.
Bug: chromium:1013590
Change-Id: I0779932c251a2159880a39b2d42d5ce439cc88e6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161090
Commit-Queue: Markus Handell <handellm@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29988}
2019-12-03 15:55:04 +00:00
014dd3c9f7
Trials should always be populated in call config.
...
The trials are always set when a Call instead is created by a
CallFactory, but a lot of unit tests creates instances directly.
This CL updates those call site. There is still a fallback in place
in RtpTransportControllerSend, since there are down-stream usages that
need to be clean up. After that, we'll remove the fallback.
Bug: webrtc:10809
Change-Id: I0aacf0473317bcd64252dd43d93c42de730e2ffa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160408
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29978}
2019-12-03 10:34:55 +00:00
7968530418
Removes caching SimulcastEncoderAdapter::GetEncoderInfo()
...
There are edge cases where the caching of encoder info will cause
issues. For instance if a sub-encoder fails en Encode call and falls
back to some other implementation, or if the fps targets shift due to
SetRates() triggering new layers to be enabled.
This CL forces a complete rebuild on every call to GetEncoderInfo().
It also adds new logging of when the info changes, as debugging issues
can be very time consuming if we can't tell that happened.
Bug: webrtc:11000
Change-Id: I7ec7962a589ccba0e188e60a11f851c9de874fab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160960
Commit-Queue: Erik Språng <sprang@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29938}
2019-11-27 17:06:54 +00:00
5cef9c3581
Revert "Add support for RtpEncodingParameters::max_framerate"
...
This reverts commit 15be5282e91ba38894e6ad51fe9a35a38a6b7f29.
Reason for revert: crbug.com/1028937
Original change's description:
> Add support for RtpEncodingParameters::max_framerate
>
> This adds the framework support for the max_framerate parameter.
> It doesn't implement it in any encoder yet.
>
> Bug: webrtc:11117
> Change-Id: I329624cc0205c828498d3623a2e13dd3f97e1629
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160184
> Reviewed-by: Steve Anton <steveanton@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Reviewed-by: Åsa Persson <asapersson@webrtc.org >
> Commit-Queue: Florent Castelli <orphis@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29907}
TBR=steveanton@webrtc.org ,asapersson@webrtc.org ,sprang@webrtc.org ,orphis@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:11117
Change-Id: Ic44dd36bea66561f0c46e73db89d451cb3e22773
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160941
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29935}
2019-11-27 14:01:53 +00:00
7a9a092708
Delete media transport integration.
...
MediaTransport is deprecated and the code is unused.
No-Try: True
Bug: webrtc:9719
Change-Id: I5b864c1e74bf04df16c15f51b8fac3d407331dcd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160620
Commit-Queue: Bjorn Mellem <mellem@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29923}
2019-11-26 19:19:36 +00:00
15be5282e9
Add support for RtpEncodingParameters::max_framerate
...
This adds the framework support for the max_framerate parameter.
It doesn't implement it in any encoder yet.
Bug: webrtc:11117
Change-Id: I329624cc0205c828498d3623a2e13dd3f97e1629
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160184
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29907}
2019-11-25 16:43:59 +00:00
00376e190a
Add totalInterFrameDelay to RTCInboundRTPStreamStats
...
Bug: webrtc:11108
Change-Id: I0e0168ba303b127a8db3946d5fa5f97a1c90fb27
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160042
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29894}
2019-11-25 10:50:37 +00:00
cb459ca6e2
Remove double declaration of cricket::kH264CodecName.
...
This symbol is declared in two places and clang-cl complains if they
disagree on the visibility (see [1]), since this declaration is
redundant this CL just removes it.
[1] - https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/432927
Bug: webrtc:9419
Change-Id: If2f04beff8fd757ec2019c3588c82b6971f012c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159029
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29729}
2019-11-07 15:24:45 +00:00
2b9317ad76
Stop checking VP8BaseHeavyTl3RateAllocation field trial on every frame.
...
- Centralize field trial string reading to RateControlSettings
- Cache RateControlSettings at all production code use sites
Bug: None
Change-Id: I0dbce9cc97fea0bc780982e7ef270b417a8c15bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158664
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29680}
2019-11-04 13:50:59 +00:00
16cec3be2c
Added allow_codec_switching parameter to RTCConfig.
...
Bug: webrtc:10795
Change-Id: I5507f1d801e262223bd18198c685b5fffa644b0b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157891
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29612}
2019-10-25 11:06:31 +00:00
