16b2a3633d
Fix the commit difference computation in roll_deps
...
(can't use commit hashes...)
TBR=phoglund@webrtc.org
Bug: webrtc:8688
No-Try: True
Change-Id: I60d7f72c1fcf2b9cfae4ba780cb3fa97ff347127
Reviewed-on: https://webrtc-review.googlesource.com/36442
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#21455}
2017-12-27 20:41:09 +00:00
65fb17bc28
Don't submit the CL in roll_deps if the revision diff is too small
...
For example, --cq-over=100 means that "Roll chromium_revision
(524047:524105)" would not be submitted because the revision
difference is below 100. The CL will still be uploaded and tested.
This will be used in the periodic run of the autoroller to prevent
committing too frequently but keep the test runs at the same rate,
as a rudimentary version of an FYI waterfall of DEPS rolls.
TBR=phoglund@webrtc.org
Bug: webrtc:8688
Change-Id: Ie46e154ddee390648d3d0c0fbb24ec93676bb275
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/36320
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#21454}
2017-12-27 16:50:59 +00:00
7f6af7a36c
Use urllib2 in roll_deps, which raises on non-200 HTTP status
...
This ensures that on service outages we get a clear early error message instead of something cryptic later down the line
Bug: None
Change-Id: Ib637ed97144284e3744aaa948f594f5795fa9c72
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/18040
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20545}
2017-11-02 00:47:46 +00:00
bbceb76f54
Add support for conditions on DEPS file.
...
See https://chromium-review.googlesource.com/687499 for the corresponding Chromium change.
Bug: None
Change-Id: I23330d161dc60fd4c8681e58ce5a8e20a2b4a3b8
Reviewed-on: https://webrtc-review.googlesource.com/4540
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#20032}
2017-09-29 05:25:46 +00:00
fbbba3f771
Remove remaining mentions of gflags
...
BUG=webrtc:7644
Review-Url: https://codereview.webrtc.org/3011413002
Cr-Commit-Position: refs/heads/master@{#19950}
2017-09-25 15:34:41 +00:00
5ab6854919
Revert "Remove remaining mentions of gflags"
...
This reverts commit 90ce84e1d3201103823a6c615ccbed9e84b1c2c4.
Reason for revert: Compilation failure on webrtc.fyi
(error: no member named 'GetLogToDebug' in 'rtc::LogMessage')
Original change's description:
> Remove remaining mentions of gflags
>
> Bug: webrtc:7644
> Change-Id: I1906419e597fe6f80247e8def78c958f3759ba00
> Reviewed-on: https://webrtc-review.googlesource.com/2687
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#19938}
TBR=kjellander@webrtc.org ,oprypin@webrtc.org
Change-Id: I0e4c7191a405e45c85d007bc385bee5de5b4d323
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:7644
Reviewed-on: https://webrtc-review.googlesource.com/3200
Reviewed-by: Oleh Prypin <oprypin@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19939}
2017-09-25 09:18:11 +00:00
90ce84e1d3
Remove remaining mentions of gflags
...
Bug: webrtc:7644
Change-Id: I1906419e597fe6f80247e8def78c958f3759ba00
Reviewed-on: https://webrtc-review.googlesource.com/2687
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19938}
2017-09-25 09:08:23 +00:00
73c81759cb
Fix autoroller script.
...
http://crrev.com/9f8b8eb2 introduced deps conditional on a variable,
we don't need to support this, so we just continue when we encounter
a dict.
NOTRY=True
Bug: None
Change-Id: I9ce22cbfd1b3ae02b4a48c9c8312a08a904f9291
Reviewed-on: https://webrtc-review.googlesource.com/2688
Reviewed-by: Charu Jain <charujain@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19930}
2017-09-22 16:50:01 +00:00
ef6ee9850b
Pass environment variable as string in autoroll script.
...
NOTRY=True
TBR=kjellander@webrtc.org
Bug: chromium:765231
Change-Id: I0121160ebd991815dd95dd6b145a68206be2d731
Reviewed-on: https://webrtc-review.googlesource.com/1844
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19883}
2017-09-18 09:46:06 +00:00
2c9ac29c5b
Autoroller: don't use GCE auth pathway
...
Even with the right credentials in place, git-cl will default to
using autogenerated GCE credentials when on a GCE machine. Tell
it to use the appropriate .gitcookies every time.
TBR=ehmaldonado@webrtc.org , kjellander@webrtc.org
NOTRY=True
Bug: chromium:765231
Change-Id: I761db91dde7db0c945e50e961c5687c835602dc4
Reviewed-on: https://webrtc-review.googlesource.com/1700
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19879}
2017-09-18 08:28:35 +00:00
6ef2002246
Use current user instead of kjellander@ in the roll script.
...
NOTRY=True
Bug: chromium:738330
Change-Id: If7a67578d03961a6613a92fb7459f1315286202e
Reviewed-on: https://webrtc-review.googlesource.com/1463
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19855}
2017-09-15 11:25:20 +00:00
92ea95e34a
Fixing WebRTC after moving from src/webrtc to src/
...
In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC
from src/webrtc to src/ (in order to preserve an healthy git history).
This CL takes care of fixing header guards, #include paths, etc...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578
Reviewed-on: https://webrtc-review.googlesource.com/1561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 05:02:56 +00:00
033a1bf337
Update autoroller to use Gerrit.
...
Rietveld has been having problems since the migration.
NOTRY=True
Bug: chromium:738330
Change-Id: I54538eee9f5734fac731702fb592580afcae3fae
Reviewed-on: https://webrtc-review.googlesource.com/1231
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19834}
2017-09-14 12:55:59 +00:00
2db9c285a7
Update README.md and codereview.settings for new source location
...
TBR=kjellander@webrtc.org
Bug: 738330
Change-Id: I5eb87ee2d08f4be73f00ebf9771b8f7c08dbadd3
Reviewed-on: https://webrtc-review.googlesource.com/1020
Commit-Queue: Aaron Gable <agable@chromium.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#19826}
2017-09-13 19:54:59 +00:00
4d46a5e1e7
Revert of move linux_internal from the autoroller CQ. (patchset #1 id:1 of https://codereview.webrtc.org/2997523002/ )
...
Reason for revert:
The credentials for the linux_internal bot are fixed now.
Original issue's description:
> Reland of move linux_internal from the autoroller CQ. (patchset #1 id:1 of https://codereview.webrtc.org/2990233002/ )
>
> Reason for revert:
> linux_internal buildbucket is broken
>
> Original issue's description:
> > Revert of Remove linux_internal from the autoroller CQ. (patchset #1 id:1 of https://codereview.webrtc.org/2985933002/ )
> >
> > Reason for revert:
> > linux_internal now checks that the CL is authored by a googler before executing the tests
> >
> > Original issue's description:
> > > Remove linux_internal from the autoroller CQ.
> > >
> > > The CQ no longer has permission to schedule builds in linux_internal.
> > >
> > > NOTRY=True
> > > TBR=kjellander@webrtc.org
> > > BUG=None
> > >
> > > Review-Url: https://codereview.webrtc.org/2985933002
> > > Cr-Commit-Position: refs/heads/master@{#19178}
> > > Committed: 5ba9730265
> >
> > TBR=mbonadei@webrtc.org ,kjellander@webrtc.org ,nodir@chromium.org
> > BUG=None
> > NOTRY=True
> >
> > Review-Url: https://codereview.webrtc.org/2990233002
> > Cr-Commit-Position: refs/heads/master@{#19240}
> > Committed: 367aaa7ca5
>
> TBR=mbonadei@webrtc.org ,kjellander@webrtc.org ,nodir@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=None
>
> Review-Url: https://codereview.webrtc.org/2997523002
> Cr-Commit-Position: refs/heads/master@{#19260}
> Committed: 81cf5bbff9
TBR=mbonadei@webrtc.org ,kjellander@webrtc.org ,nodir@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None
Review-Url: https://codereview.webrtc.org/3001523002
Cr-Commit-Position: refs/heads/master@{#19312}
2017-08-10 22:32:02 +00:00
81cf5bbff9
Reland of move linux_internal from the autoroller CQ. (patchset #1 id:1 of https://codereview.webrtc.org/2990233002/ )
...
Reason for revert:
linux_internal buildbucket is broken
Original issue's description:
> Revert of Remove linux_internal from the autoroller CQ. (patchset #1 id:1 of https://codereview.webrtc.org/2985933002/ )
>
> Reason for revert:
> linux_internal now checks that the CL is authored by a googler before executing the tests
>
> Original issue's description:
> > Remove linux_internal from the autoroller CQ.
> >
> > The CQ no longer has permission to schedule builds in linux_internal.
> >
> > NOTRY=True
> > TBR=kjellander@webrtc.org
> > BUG=None
> >
> > Review-Url: https://codereview.webrtc.org/2985933002
> > Cr-Commit-Position: refs/heads/master@{#19178}
> > Committed: 5ba9730265
>
> TBR=mbonadei@webrtc.org ,kjellander@webrtc.org ,nodir@chromium.org
> BUG=None
> NOTRY=True
>
> Review-Url: https://codereview.webrtc.org/2990233002
> Cr-Commit-Position: refs/heads/master@{#19240}
> Committed: 367aaa7ca5
TBR=mbonadei@webrtc.org ,kjellander@webrtc.org ,nodir@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None
Review-Url: https://codereview.webrtc.org/2997523002
Cr-Commit-Position: refs/heads/master@{#19260}
2017-08-07 18:39:10 +00:00
367aaa7ca5
Revert of Remove linux_internal from the autoroller CQ. (patchset #1 id:1 of https://codereview.webrtc.org/2985933002/ )
...
Reason for revert:
linux_internal now checks that the CL is authored by a googler before executing the tests
Original issue's description:
> Remove linux_internal from the autoroller CQ.
>
> The CQ no longer has permission to schedule builds in linux_internal.
>
> NOTRY=True
> TBR=kjellander@webrtc.org
> BUG=None
>
> Review-Url: https://codereview.webrtc.org/2985933002
> Cr-Commit-Position: refs/heads/master@{#19178}
> Committed: 5ba9730265
TBR=mbonadei@webrtc.org ,kjellander@webrtc.org ,nodir@chromium.org
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2990233002
Cr-Commit-Position: refs/heads/master@{#19240}
2017-08-03 17:15:18 +00:00
5ba9730265
Remove linux_internal from the autoroller CQ.
...
The CQ no longer has permission to schedule builds in linux_internal.
NOTRY=True
TBR=kjellander@webrtc.org
BUG=None
Review-Url: https://codereview.webrtc.org/2985933002
Cr-Commit-Position: refs/heads/master@{#19178}
2017-07-28 13:27:00 +00:00
1e64cfae53
Fix autoroller in accordance to upstream change
...
This broke WebRTC's presubmit
e79ddeaabf %5E%21/
GClientKeywords has been removed and replaced with a more direct substitution.
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2989603002
Cr-Commit-Position: refs/heads/master@{#19126}
2017-07-25 08:57:17 +00:00
41b59ca8bf
Fix CQ_INCLUDE_TRYBOTS CL value generated by roll_deps.py
...
A seen in https://codereview.webrtc.org/2956153004/ the CQ
is picky about the ending ;, so this CL removes it.
BUG=None
TBR=ehmaldonado@webrtc.org
NOTRY=True
Change-Id: I5e6359f0966f171c98225a982da042cc7147f765
Reviewed-on: https://chromium-review.googlesource.com/552138
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org >
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#18807}
2017-06-28 13:06:37 +00:00
912b4d57cb
Fix typo in roll_deps.py
...
https://chromium-review.googlesource.com/c/551717/ had
a typo :P
BUG=None
TBR=ehmaldonado@webrtc.org
NOTRY=True
Change-Id: I2f63c3a43de872e3255a1eb9facee1868f2d88a1
Reviewed-on: https://chromium-review.googlesource.com/551897
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#18799}
2017-06-28 07:32:52 +00:00
de4ea0cf0b
Add linux_internal trybot to DEPS autoroll script.
...
This will make this bot be triggered for autoroll CLs.
BUG=None.
TBR=ehmaldonado@webrtc.org
NOTRY=True
Change-Id: I6d8920a4c10a5dee36e5cb93a1e3cb6e3a2ed7ae
Reviewed-on: https://chromium-review.googlesource.com/551717
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org >
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#18798}
2017-06-28 06:33:42 +00:00
884ab92d7c
Update autoroller after FromImpl was removed from depot tools
...
In https://chromium-review.googlesource.com/c/509693/ the From
keyword was removed. This update the script to match that (we
also were no longer using it).
BUG=None
TBR=ehmaldonado@webrtc.org
NOTRY=True
Change-Id: I3d8fb9d696ee7677f7d250ecd0e6ff997375034b
Reviewed-on: https://chromium-review.googlesource.com/512202
Commit-Queue: Henrik Kjellander <kjellander@chromium.org >
Reviewed-by: Henrik Kjellander <kjellander@chromium.org >
Cr-Commit-Position: refs/heads/master@{#18227}
2017-05-23 07:22:23 +00:00
c99bddfc1c
Autoroller: Skip commit if there are no DEPS changes.
...
This will avoid failing with a non-zero exit code when git commit
fails due to no changes to be rolled.
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2883833003
Cr-Commit-Position: refs/heads/master@{#18146}
2017-05-15 09:40:58 +00:00
5e56d6ab94
Do not autoroll gradle and roll gradle back to 3.5.0.
...
We want to use stable gradle releases for testing.
BUG=webrtc:7608
NOTRY=True
Review-Url: https://codereview.webrtc.org/2877723002
Cr-Commit-Position: refs/heads/master@{#18094}
2017-05-11 09:41:40 +00:00
90fd7d84fd
Rename tools-webrtc -> tools_webrtc
...
This aligns with established naming convention for all
other directories.
BUG=webrtc:7593
NOTRY=True
NOTREECHECKS=True
R=ehmaldonado@webrtc.org , mbonadei@webrtc.org
TBR=henrika@webrtc.org
Review-Url: https://codereview.webrtc.org/2864213004 .
Cr-Commit-Position: refs/heads/master@{#18059}
2017-05-09 06:30:13 +00:00