445e6b034a
Break out separate compile targets for various classes
...
This reduces the degree of interdependency among modules related
to the PeerConnection class, and makes it easier to isolate inappropriate
external dependencies.
Bug: webrtc:11967
Change-Id: Id9777a2ab690cc349dd5842a3a95e24478144c71
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185882
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32235}
2020-09-29 15:14:22 +00:00
6b4d962947
Fix standard GetStats to not modify NetEq state.
...
Add a get_and_clear_legacy_stats flag to AudioReceiveStream::GetStats,
to distinguish calls from standard GetStats and legacy GetStats.
Add const method NetEq::CurrentNetworkStatistics to get current
values of stateless NetEq stats. Standard GetStats will then call this
method instead of NetEq::NetworkStatistics.
Bug: webrtc:11622
Change-Id: I3833a246a9e39b18c99657a738da22c6e2bd5f5e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183600
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32092}
2020-09-14 09:51:21 +00:00
3a034e15b4
Split DataChannel into two separate classes for RTP and SCTP.
...
Done in preparation for some threading changes that would be quite
messy if implemented with the class as-is.
This results in some code duplication, but is preferable to
one class having two completely different modes of operation.
RTP data channels are in the process of being removed anyway,
so the duplicated code won't last forever.
Bug: webrtc:9883
Change-Id: Idfd41a669b56a4bb4819572e4a264a4ffaaba9c0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178940
Commit-Queue: Taylor <deadbeef@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31691}
2020-07-10 00:03:21 +00:00
2e94de596e
Add GetSctpStats to PeerConnectionInternal, remove sctp_data_channels()
...
This removes code from DataChannelController that exposes
an internal vector of data channels and puts the onus of
returning stats for a data channel, on the data channel
object itself. This will come in handy as we make threading
changes to the data channel object.
Change-Id: Ie164cc5823cd5f9782fc5c9a63aa4c76b8229639
Bug: webrtc:11547, webrtc:11687
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177244
Commit-Queue: Tommi <tommi@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31533}
2020-06-16 16:36:42 +00:00
a0ff50c031
Reland "Improve outbound-rtp statistics for simulcast"
...
This reverts commit 9a925c9ce33a6ccdd11b545b11ba68e985c2a65d.
Reason for revert: The original CL is updated in PS #2 to
fix the googRtt issue which was that when the legacy sender
stats were put in "aggregated_senders" we forgot to update
rtt_ms the same way that we do it for "senders".
Original change's description:
> Revert "Improve outbound-rtp statistics for simulcast"
>
> This reverts commit da6cda839dac7d9d18eba8d365188fa94831e0b1.
>
> Reason for revert: Breaks googRtt in legacy getStats API
>
> Original change's description:
> > Improve outbound-rtp statistics for simulcast
> >
> > Bug: webrtc:9547
> > Change-Id: Iec4eb976aa11ee743805425bedb77dcea7c2c9be
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168120
> > Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> > Reviewed-by: Erik Språng <sprang@webrtc.org >
> > Reviewed-by: Henrik Boström <hbos@webrtc.org >
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Commit-Queue: Eldar Rello <elrello@microsoft.com >
> > Cr-Commit-Position: refs/heads/master@{#31097}
>
> TBR=hbos@webrtc.org ,sprang@webrtc.org ,stefan@webrtc.org ,srte@webrtc.org ,hta@webrtc.org ,elrello@microsoft.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: webrtc:9547
> Change-Id: I06673328c2a5293a7eef03b3aaf2ded9d13df1b3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174443
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Commit-Queue: Henrik Boström <hbos@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#31165}
TBR=hbos@webrtc.org ,sprang@webrtc.org ,stefan@webrtc.org ,srte@webrtc.org ,hta@webrtc.org ,elrello@microsoft.com
# Not skipping CQ checks because this is a reland.
Bug: webrtc:9547
Change-Id: I723744c496c3c65f95ab6a8940862c8b9f544338
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174480
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31169}
2020-05-05 20:22:19 +00:00
9a925c9ce3
Revert "Improve outbound-rtp statistics for simulcast"
...
This reverts commit da6cda839dac7d9d18eba8d365188fa94831e0b1.
Reason for revert: Breaks googRtt in legacy getStats API
Original change's description:
> Improve outbound-rtp statistics for simulcast
>
> Bug: webrtc:9547
> Change-Id: Iec4eb976aa11ee743805425bedb77dcea7c2c9be
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168120
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Eldar Rello <elrello@microsoft.com >
> Cr-Commit-Position: refs/heads/master@{#31097}
TBR=hbos@webrtc.org ,sprang@webrtc.org ,stefan@webrtc.org ,srte@webrtc.org ,hta@webrtc.org ,elrello@microsoft.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:9547
Change-Id: I06673328c2a5293a7eef03b3aaf2ded9d13df1b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174443
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#31165}
2020-05-05 13:38:51 +00:00
da6cda839d
Improve outbound-rtp statistics for simulcast
...
Bug: webrtc:9547
Change-Id: Iec4eb976aa11ee743805425bedb77dcea7c2c9be
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168120
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Eldar Rello <elrello@microsoft.com >
Cr-Commit-Position: refs/heads/master@{#31097}
2020-04-17 11:28:00 +00:00
08d1806e54
Extend rtc::AdapterType with 2g, 3G, 4G & 5G enum values.
...
This patch adds new enum values for different types of cellular
connections.
The new costs are currently blocked when sending to remote,
(so that arbitrary network switches does not starts occurring).
The end-game for this series to be able to distinguish between
different type of cellular connections in the ice-layer (e.g when
selecting/switching connections).
BUG: webrtc:11473
Change-Id: I587ac8fdff4f6cdd0f8905f327232f58818db4f6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172582
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30970}
2020-04-02 07:48:36 +00:00
ac0a4cbbd8
Reland "Fix GetStats bytesSent/Received, wireup headerBytesSent/Received"
...
This is a reland of fbde32e596f06893d6dda13eb7d29f4c251cf08b
The chromium problem should be fixed with
https://chromium-review.googlesource.com/c/chromium/src/+/1862437
Original change's description:
> Fix GetStats bytesSent/Received, wireup headerBytesSent/Received
>
> Changes the standard GetStats, legacy GetStats unchanged.
>
> Bug: webrtc:10525
> Change-Id: Ie10fe8079f1d8b4cc6bbe513f6a2fc91477b5441
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156084
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29462}
Tbr: kwiberg@webrtc.org
Bug: webrtc:10525
Change-Id: I3b61f9535aa3f1fca2ed84f068233803d4ec9fe2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157045
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29485}
2019-10-15 10:43:59 +00:00
ef0627fb50
Revert "Fix GetStats bytesSent/Received, wireup headerBytesSent/Received"
...
This reverts commit fbde32e596f06893d6dda13eb7d29f4c251cf08b.
Reason for revert: It seems to break WebRTC FYI tests in Chromium.
https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Linux%20Tester/4763
Original change's description:
> Fix GetStats bytesSent/Received, wireup headerBytesSent/Received
>
> Changes the standard GetStats, legacy GetStats unchanged.
>
> Bug: webrtc:10525
> Change-Id: Ie10fe8079f1d8b4cc6bbe513f6a2fc91477b5441
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156084
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#29462}
TBR=kwiberg@webrtc.org ,hbos@webrtc.org ,nisse@webrtc.org ,hta@webrtc.org
Change-Id: I6a983ea4d5ff38e49f096a8ff5cd9b426768f955
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10525
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157043
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29478}
2019-10-15 08:55:06 +00:00
fbde32e596
Fix GetStats bytesSent/Received, wireup headerBytesSent/Received
...
Changes the standard GetStats, legacy GetStats unchanged.
Bug: webrtc:10525
Change-Id: Ie10fe8079f1d8b4cc6bbe513f6a2fc91477b5441
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156084
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29462}
2019-10-14 13:07:13 +00:00
317a1f09ed
Use std::make_unique instead of absl::make_unique.
...
WebRTC is now using C++14 so there is no need to use the Abseil version
of std::make_unique.
This CL has been created with the following steps:
git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt
git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt
git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt
diff --new-line-format="" --unchanged-line-format="" \
/tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \
uniq > /tmp/only_make_unique.txt
diff --new-line-format="" --unchanged-line-format="" \
/tmp/only_make_unique.txt /tmp/memory.txt | \
xargs grep -l "absl/memory" > /tmp/add-memory.txt
git grep -l "\babsl::make_unique\b" | \
xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g"
git checkout PRESUBMIT.py abseil-in-webrtc.md
cat /tmp/add-memory.txt | \
xargs sed -i \
's/#include "absl\/memory\/memory.h"/#include <memory>/g'
git cl format
# Manual fix order of the new inserted #include <memory>
cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \
xargs sed -i '/#include "absl\/memory\/memory.h"/d'
git ls-files | grep BUILD.gn | \
xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d'
python tools_webrtc/gn_check_autofix.py \
-m tryserver.webrtc -b linux_rel
# Repead the gn_check_autofix step for other platforms
git ls-files | grep BUILD.gn | \
xargs sed -i 's/absl\/memory:memory/absl\/memory/g'
git cl format
Bug: webrtc:10945
Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#29209}
2019-09-17 15:47:29 +00:00
149dc72dfa
Add support for RTCTransportStats.selectedCandidatePairChanges
...
This patch adds accounting and reporting needed for
newly added RTCTransportStats.selectedCandidatePairChanges,
https://w3c.github.io/webrtc-stats/#dom-rtctransportstats-selectedcandidatepairchanges
a) P2PTransportChannel counts everytime selected_connection_
is modified and reports this counter in the GetStats()-call.
b) RTCStatsCollector puts the counter into the standardized
stats object.
Bug: webrtc:10900
Change-Id: Ibaeca18706b8edcbcb44b0c6f2754854bcb545ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149830
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28987}
2019-08-28 13:22:08 +00:00
bbeb10925e
Reporting audio device underrun counter
...
Bug: webrtc:10884
Change-Id: I35636fcbc1e2a19a89242379cdff6ec5c12fd21a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149200
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Alex Narest <alexnarest@google.com >
Cr-Commit-Position: refs/heads/master@{#28874}
2019-08-16 11:49:55 +00:00
5b5d97c938
Reland of "Reporting of decoding_codec_plc events""
...
This is a reland of 0a88ea050cda58de81d624cf2764d46929447ed5.
The new stat will not be reported unless it is GT 0.
Reporting of decoding_codec_plc events
Bug: webrtc:10838
Change-Id: Ic8585b4eeae9a2643374f15bc2578d1141e59683
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148448
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Commit-Queue: Alex Narest <alexnarest@google.com >
Cr-Commit-Position: refs/heads/master@{#28797}
2019-08-07 18:41:46 +00:00
032ea9cbc7
Remove "Missing track ID" StatsCollector log message
...
Bug: None
Change-Id: I94a70d5cbe4238220bf0939ba5807cf51195fe7f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147661
Reviewed-by: Amit Hilbuch <amithi@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28727}
2019-07-31 19:33:16 +00:00
bedb7a8aea
Revert "Reporting of decoding_codec_plc events"
...
This reverts commit 0a88ea050cda58de81d624cf2764d46929447ed5.
Reason for revert: This CL breaks Chromium's FYI bots (example: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Linux%20Tester/4033 ).
Original change's description:
> Reporting of decoding_codec_plc events
>
> Change-Id: Id71b37244bc98bffaf25131a519127b3d2b86a8f
>
> Bug: webrtc:10838
> Change-Id: Id71b37244bc98bffaf25131a519127b3d2b86a8f
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147263
> Commit-Queue: Alex Narest <alexnarest@google.com >
> Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28700}
TBR=mflodman@webrtc.org ,alexnarest@google.com
Change-Id: I5e5dd29ee375ba422f79932d4b8c3fd028a53db4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10838
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147269
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28707}
2019-07-30 14:39:09 +00:00
0a88ea050c
Reporting of decoding_codec_plc events
...
Change-Id: Id71b37244bc98bffaf25131a519127b3d2b86a8f
Bug: webrtc:10838
Change-Id: Id71b37244bc98bffaf25131a519127b3d2b86a8f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/147263
Commit-Queue: Alex Narest <alexnarest@google.com >
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28700}
2019-07-29 16:40:23 +00:00
fc02a793c2
Revert "Piping audio interruption metrics to API layer"
...
This reverts commit 299c4e68461f1c4428b2a919913b161115025dff.
Reason for revert: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win10%20Tester/2753
../../chrome/browser/media/webrtc/webrtc_browsertest_base.cc(539): error: Expected equality of these values:
"ok-got-stats"
ExecuteJavascript("verifyLegacyStatsGenerated()", tab)
Which is: "Test failed: Error: \"googInterruptionCount\" is not a whitelisted stat. Exposing new metrics in the legacy getStats() API is not allowed. Please follow the standardization process: https://docs.google.com/document/d/1q1CJVUqJ6YW9NNRc0tENkLNny8AHrKZfqjy3SL89zjc/edit?usp=sharing\n at failTest (http://127.0.0.1:50650/webrtc/test_functions.js:46:15 )\n at http://127.0.0.1:50650/webrtc/peerconnection.js:481:19 "
With diff:
@@ -1,1 +1,3 @@
-ok-got-stats
+Test failed: Error: \"googInterruptionCount\" is not a whitelisted stat. Exposing new metrics in the legacy getStats() API is not allowed. Please follow the standardization process: https://docs.google.com/document/d/1q1CJVUqJ6YW9NNRc0tENkLNny8AHrKZfqjy3SL89zjc/edit?usp=sharing
+ at failTest (http://127.0.0.1:50650/webrtc/test_functions.js:46:15 )
+ at http://127.0.0.1:50650/webrtc/peerconnection.js:481:19
Original change's description:
> Piping audio interruption metrics to API layer
>
> Bug: webrtc:10549
> Change-Id: Ie6abe5819c5b73dc5f5f89bdc375bad77f44ce97
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134303
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
> Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27788}
TBR=henrik.lundin@webrtc.org ,kwiberg@webrtc.org ,ivoc@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:10549
Change-Id: I345306ba9758c0a3b1597724fa860d3e3fdb8995
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134464
Commit-Queue: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27802}
2019-04-29 11:23:16 +00:00
299c4e6846
Piping audio interruption metrics to API layer
...
Bug: webrtc:10549
Change-Id: Ie6abe5819c5b73dc5f5f89bdc375bad77f44ce97
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134303
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27788}
2019-04-26 13:32:34 +00:00
efe4c92d54
Use RtpSender/RtpReceiver track ID for legacy GetStats
...
Previously, legacy GetStats would look up the track ID by querying the
local/remote SDP by SSRC. This doesn't work with Unified Plan since the
RtpSender/RtpReceiver track IDs may not correspond to the track ID
stored in the SDP.
This CL changes legacy GetStats to pull the track ID directly from the
RtpSenders and RtpReceivers as it generates the stats. This has a few
additional benefits:
1) Unsignaled receive SSRC stats should now get correctly matched to
the unsigneled RtpReceiver track ID for both Plan B and Unified
Plan.
2) Removes a couple methods on PeerConnection that were only used by
the legacy StatsCollector.
3) Keeps the SSRC -> track ID mapping more localized which should make
the code easier to understand.
Bug: chromium:943493
Change-Id: I43ecde8c3a3d1c5f9c749ba6c8dfb11e8c4950fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129782
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Amit Hilbuch <amithi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27324}
2019-03-27 18:14:00 +00:00
fe0b499634
legacy stats: update timestamp on localcandidate/remotecandidate
...
updates the timestamp on the local and remote candidate stats for consistency
with other places. This also makes the graphs on chrome://webrtc-internals
work (even though most values don't update so showing graphs is not meaningful)
BUG=chromium:937833
Change-Id: I3267dd7a5f5a887dcd0756137077b8f02c201905
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128765
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27248}
2019-03-22 17:26:20 +00:00
739baf097b
[clang-tidy] Apply performance-for-range-copy fixes.
...
This CL applies clang-tidy's performance-for-range-copy [1] on the
WebRTC codebase.
All changes in this CL are automatically generated by both clang-tidy
and 'git cl format'.
[1] - https://clang.llvm.org/extra/clang-tidy/checks/performance-for-range-copy.html
Bug: webrtc:10215
Change-Id: I7c83290b8866d76129bbec4e24e6701f5014102e
Reviewed-on: https://webrtc-review.googlesource.com/c/120043
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26420}
2019-01-28 09:53:50 +00:00
10542f21c8
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
...
Mechanically generated by running this command:
tools_webrtc/do-renames.sh update all-renames.txt && git cl format
Then manually updating:
tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833
Reviewed-on: https://webrtc-review.googlesource.com/c/115653
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 17:11:39 +00:00
1c05765831
(3) Rename files to snake_case: move the files
...
Mechanically generated with this command:
tools_webrtc/do-rename.sh move all-renames.txt
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I8b05b6eab9b9d18b29c2199bbea239e9add1e690
Reviewed-on: https://webrtc-review.googlesource.com/c/115481
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26225}
2019-01-11 17:05:20 +00:00
